| *** MarkAtwood has quit IRC | 01:31 | |
| *** mrmartin has joined #storyboard | 04:41 | |
| *** mrmartin has quit IRC | 04:49 | |
| *** jcoufal has joined #storyboard | 06:49 | |
| *** jtomasek has joined #storyboard | 07:39 | |
| SotK | subscription loading is very nice in storyboard.openstack.org now | 08:09 |
|---|---|---|
| SotK | thanks Zara! | 08:10 |
| Zara | :D | 08:59 |
| * Zara is relieved it hasn't broken everything | 08:59 | |
| Zara | seems faster :) stories still seem to take longer than I'd like to load. I wonder if it's checking through the whole list, where before it only did a GET for a stuff that displayed on that page? | 09:02 |
| Zara | ignore that strange 'a' | 09:03 |
| SotK | it seems that the API takes 1s to actually finish responding to the GET for the stories themselves for some reason | 09:03 |
| Zara | yeah, the projects are faster and there are fewer, so I'm wondering if it's because the GET gets all the projects/stories | 09:05 |
| Zara | though if we do limit = 100, I don't see how we can make sure it's the *right* 100. | 09:06 |
| SotK | the GET for the subscriptions seems fairly reasonable (170ms) | 09:06 |
| Zara | oh, sorry, misinterpreted you | 09:07 |
| SotK | I guess there is something wrong in the API for it to take 1s for 100 stories | 09:07 |
| * SotK will poke around when he's fixed this nightmare bug in worklist permissions | 09:08 | |
| Zara | someone else did say that the individual GETs were slow | 09:08 |
| Zara | https://storyboard.openstack.org/#!/story/129 | 09:08 |
| Zara | this one | 09:08 |
| persia | I was trying to understand the relationship between stories 81, 329, and 2000322. Is there any mechanism to indicate if they are duplicate or non-duplicate, etc. except through comments? | 09:13 |
| SotK | nope, other than commenting and marking the task contained within invalid I guess | 09:13 |
| persia | Does that cause the story to become inactive? | 09:15 |
| SotK | I think it should do, yes | 09:15 |
| persia | Any thoughts on which should be the master of those three, or are they not actually duplicates? | 09:16 |
| SotK | 2000322 has an up-to-date list of tasks, but the others have some bits of useful discussion in | 09:18 |
| * SotK is partly to blame for this | 09:18 | |
| persia | The currency of 2000322 was the main reason I didn't just decide to pick the lowest number. | 09:19 |
| persia | (my usual criteria for duplicate conflation) | 09:19 |
| Zara | 81 seemed like more of a 'how should we do this?'; 329 follows on in more detail; 2000322 has a lot more detail and concrete steps (yeah, they're numbered chronologically) | 09:20 |
| Zara | I'd say they could be brought together into one story, but they're not duplicates in their current form. | 09:21 |
| persia | The content is certainly not duplicate, but I fear something went odd with workflow. | 09:22 |
| Zara | yeah, I wondered if perhaps it was to do with a lack of pagination and stories being visible and/or the search bar not working, but that's speculation. | 09:23 |
| persia | In my mind, once one knows how to do something, one adds more tasks to complete the story (being an encapsulation of some particular issue). | 09:23 |
| persia | For this history case, I wonder if perhaps the right way is t create (completed) tasks covering the narrative you've outlined, such that only 2000322 is current. | 09:24 |
| SotK | could work, but I'm not sure what the tasks would be in this case ("Discuss it a bit"?) | 09:26 |
| *** mrmartin has joined #storyboard | 10:41 | |
| Zara | I got excited about the 'show stories created by current user on dashboard' patch then realised 'browse stories by creator id' still needed more reviews | 11:22 |
| SotK | indeed :( | 11:25 |
| Zara | btw, I vaguely rememeber there was something funny about the fix test patch, which is why I left it alone, but I'm not sure if I got it mixed up with something else or if it might have slipped through the net while I was on holiday or something. https://review.openstack.org/#/c/213732/ | 11:25 |
| Zara | very sorry if I should have looked at this ages ago. | 11:25 |
| SotK | the weirdness there was that I'm not actually entirely sure if it will do much to help, but its worth a try :P | 11:30 |
| Zara | haha | 11:32 |
| Zara | ah, I see, it went in my 'doesn't matter' pile and I forgot about it, sorry anyway. xD I'm not sure we should be merging things for the testing side if we're not sure if they'll be helping, since it seems like that means we're not sure what's going on. | 11:33 |
| Zara | I guess how sure is 'not actually entirely sure'? | 11:33 |
| Zara | if there's a fair chance it'll help and it's not likely to do any damage I guess we should risk it. the main negative I see is that it makes the codebase harder to maintain if there are some quirky extras in there. | 11:35 |
| SotK | I think it will make the gate-storyboard-js-integration test do something vaguely useful on patches to storyboard-webclient | 11:35 |
| SotK | it shouldn't make anything worse | 11:35 |
| SotK | it currently doesn't work because it uses the wrong credentials for the database creation | 11:36 |
| SotK | however it doesn't fix it for patches to storyboard (the python api) because some bit in project-config assumes that js-integratoin gate tests are done only on projects that use grunt IIRC | 11:37 |
| SotK | so it tries to do `tox -e grunt ...` but can't because tox.ini in storyboard doesn't know what that means | 11:37 |
| Zara | ah, so there'd need to be something more like 'tox -e venv' for storyboard itself. | 11:39 |
| Zara | I think I get it, anyway. :) I'll +2 then, sounds like this is necessary even if it turns out not to be the complete fix | 11:39 |
| Zara | I'm getting deja vu; sorry if we had this conversation literally months ago | 11:40 |
| SotK | I don't think we had the whole thing, even if we had some of it xD | 11:40 |
| Zara | heh | 11:43 |
| Zara | ohh that was terrifying | 11:43 |
| Zara | I accidentally just fetched storyboard changes into the webclient directory | 11:43 |
| Zara | git was not happy | 11:43 |
| SotK | hahaha, oops | 11:44 |
| Zara | it's fine now, but that was a scary moment until I worked out what had happened. | 11:44 |
| Zara | (my screen was covered with 'fatal error: unable to find gruntfile' in red. I daresay the test is doing something similar, haha) | 11:46 |
| * Zara notices that add tag box is visible to non-logged in users, although they can't add tags | 11:54 | |
| Zara | could do with hiding. | 11:54 |
| SotK | create a story so we don't forget :D | 11:55 |
| Zara | heh | 11:55 |
| Zara | https://storyboard.openstack.org/#!/story/list | 11:58 |
| Zara | erm | 11:58 |
| Zara | https://storyboard.openstack.org/#!/story/2000379 | 11:58 |
| Zara | I tried to capture the drama of the revelation | 11:58 |
| * SotK thinks you succeeded | 12:03 | |
| Zara | \o/ | 12:03 |
| * SotK regrets not adding sensible blockquote styling when he added markdown support | 12:08 | |
| SotK | I think I have permissions working properly at last! | 12:21 |
| * SotK amends his migration to create permissions for existing boards/worklists | 12:21 | |
| Zara | \o/ | 12:23 |
| *** gothicmindfood has quit IRC | 12:43 | |
| * Zara briefly tries to work out how 'updated' filters things | 12:46 | |
| Zara | seems it doesn't count comments | 12:46 |
| Zara | it'd be nice to have 'updated' (and so on) filters for the list of stories in a project, too. | 12:47 |
| * SotK agrees | 12:47 | |
| SotK | as for the "Updated on" field, its handled automatically by MySQL whenever the record is changed AIUI | 12:48 |
| SotK | or maybe its some sqlalchemy magic with a comment that mislead me | 12:48 |
| Zara | I'll add a story for filters for stories in projects for now | 12:49 |
| *** gothicmindfood has joined #storyboard | 12:49 | |
| Zara | I can see how it could turn out to be tougher than expected depending on quirks of the implementation and what information is avaialable where. | 12:50 |
| Zara | also a question of how it'd work from the 'where do I put this on the screen?' side of things | 12:51 |
| Zara | my guess would be a dropdown next to the '# of results' one, but there's a reason I keep away from anything touching on graphic design where possible. | 12:52 |
| Zara | it seems the time it takes stories to load varies | 13:02 |
| Zara | between 1 and 7 seconds (just counting for now). :S | 13:03 |
| SotK | :/ | 13:04 |
| Zara | hm, getting an odd error while testing patch, not sure if relevant | 13:27 |
| Zara | ah, could be because I didn't restart sb, actually | 13:28 |
| *** coolsvap has quit IRC | 14:12 | |
| *** coolsvap has joined #storyboard | 14:14 | |
| SotK | gah, noticed something I forgot to do | 14:34 |
| Zara | that's been my whole week | 14:44 |
| Zara | I'm good at noticing them, less good at doing them. | 14:44 |
| SotK | :) | 14:45 |
| * SotK updates http://185.98.149.23/ to have his permissions stuff in | 15:06 | |
| SotK | please try and break it | 15:06 |
| Zara | heh | 15:08 |
| Zara | (argh, my own instance is being funny and won't let me update stories' descriptions. changed storyboard and storyboard-webclient to master, still not working. :S not the case on other instances running from master so seems to be local, at least) | 15:09 |
| Zara | wondering if it's to do wit the accidental mixing up of the git fetch earlier | 15:09 |
| Zara | *with | 15:09 |
| SotK | hmm, weird | 15:09 |
| SotK | what error do you get? | 15:09 |
| Zara | hm, that test-project page seems to do a GET for each subscription | 15:11 |
| Zara | as for my error, 500: PUT /api/v1/stories/5: 'unicode' object has no attribute '_sa_instance_state' | 15:11 |
| SotK | heh, I probably haven't pulled master since the change was merged | 15:11 |
| Zara | hehehe | 15:11 |
| SotK | interesting, I have seen that before too | 15:11 |
| Zara | I wondered if you'd added it just to mock me | 15:11 |
| Zara | ah, I don't think the worklist reloading looks bad tbh | 15:14 |
| Zara | I passed owndership to you http://185.98.149.23/#!/worklist/9 | 15:15 |
| Zara | *ownership | 15:15 |
| Zara | does the archive button work yet? | 15:15 |
| SotK | it works, but you can't unarchive anything | 15:17 |
| Zara | ah, right, may be worth hiding until that's possible? (trying making a board work. I'd kiiiiiiind of like tab to go to 'add lane' rather than save, but it's such a small niggle it doesn't really matter and might just be my workflow) | 15:17 |
| SotK | heh, tab doesn't ever get to add lane I notice | 15:19 |
| Zara | okay, just tried making a private board: http://185.98.149.23/#!/board/5 | 15:20 |
| Zara | the save button didn't work once; cancelled the dialogue and opened it again and it did so I'm not sure what was up there. :S | 15:20 |
| Zara | wasn't able to replicate it, anyway | 15:20 |
| Zara | I edited some stuff before saving and then tried to add a card so it might have been something to do with that stuff updating | 15:21 |
| SotK | hmm, weird | 15:21 |
| SotK | the privateness of the board is working anyhow | 15:23 |
| *** openstackgerrit has quit IRC | 15:31 | |
| *** openstackgerrit has joined #storyboard | 15:32 | |
| Zara | yay | 15:37 |
| Zara | should now be not private: http://185.98.149.23/#!/board/5 | 15:37 |
| * SotK wonders if it should have lanes | 15:37 | |
| Zara | it should :S | 15:38 |
| SotK | :( | 15:38 |
| Zara | 4 of them ;_; | 15:38 |
| * Zara tries adding you as a user | 15:38 | |
| SotK | I see them now! | 15:38 |
| Zara | so seems they're only visible to users | 15:39 |
| Zara | hm. | 15:39 |
| SotK | easy to fix | 15:39 |
| Zara | ah, great | 15:39 |
| SotK | I guess its because it was private once | 15:39 |
| Zara | yeah | 15:39 |
| SotK | aha, the logic for deciding whether a lane is visible is weird | 15:55 |
| Zara | heh | 15:56 |
| SotK | I thought something was wrong there, but couldn't put my finger on what it was until now | 15:58 |
| Zara | what was it? | 15:59 |
| SotK | if the board was private, it returned False unless you had permissions to edit the board or move cards | 16:00 |
| SotK | if it was public, it returned False unless you had permissions to edit the board or move cards too, which it shouldn't have done | 16:00 |
| SotK | it should just return True for visibilty if the board is public | 16:00 |
| SotK | I was too focussed on doing the right thing when it was private to notice the mistake though | 16:01 |
| Zara | ah, right | 16:02 |
| Zara | heh | 16:02 |
| SotK | can you remove me as a user on that board and see if it works now? | 16:03 |
| Zara | should be removed | 16:03 |
| SotK | success! | 16:03 |
| SotK | I can see but not change | 16:03 |
| Zara | \o/ | 16:04 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Implement complex permissions for worklists and boards https://review.openstack.org/235472 | 16:15 |
| Zara | oooooooo | 16:15 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Update $resource wrappers to use new permissions API https://review.openstack.org/235475 | 16:17 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add UI for complex permissions on boards and worklists https://review.openstack.org/235476 | 16:17 |
| Zara | ugh, still getting my 500 my own instance | 16:21 |
| SotK | on the description editing? | 16:21 |
| * SotK hasn't found a way to fix stories that that starts happening on | 16:21 | |
| Zara | yeah | 16:21 |
| Zara | I think also the title editing for that one | 16:22 |
| SotK | oh, I've not seen it on the title :/ | 16:22 |
| SotK | I'll investigate that tomorrow | 16:22 |
| Zara | yeah, shallow googling suggests it's a sqlalchemy thing-- but annoying because I have no idea when it started | 16:23 |
| Zara | I like to test patches by seeing if anything changes... | 16:23 |
| Zara | (as well as looking at the code, heh) | 16:23 |
| Zara | seems to affect the two oldest stories, at least | 16:24 |
| Zara | okay, seems to be oldest three stories and then nothing after that | 16:26 |
| Zara | might be relevant | 16:26 |
| * Zara goes to check projects | 16:26 | |
| Zara | projects seem fine | 16:26 |
| *** jcoufal has quit IRC | 16:34 | |
| *** mrmartin has quit IRC | 19:54 | |
| *** mrmartin has joined #storyboard | 19:54 | |
| *** lifeless has quit IRC | 20:34 | |
| *** mrmartin has quit IRC | 20:39 | |
| *** wendar_ has joined #storyboard | 23:29 | |
| *** wendar has quit IRC | 23:30 | |
| *** persia has quit IRC | 23:30 | |
| *** persia has joined #storyboard | 23:30 | |
| *** coolsvap has quit IRC | 23:54 | |
| *** wendar_ has quit IRC | 23:54 | |
| *** jtomasek has quit IRC | 23:54 | |
| *** davidlenwell has quit IRC | 23:54 | |
| *** NikitaKonovalov has quit IRC | 23:54 | |
| *** rainya has quit IRC | 23:54 | |
| *** ChanServ has quit IRC | 23:54 | |
| *** persia has quit IRC | 23:54 | |
| *** jjardon has quit IRC | 23:54 | |
| *** dabukalam has quit IRC | 23:54 | |
| *** cody-somerville has quit IRC | 23:54 | |
| *** cody-somerville- has quit IRC | 23:55 | |
| *** Zara has quit IRC | 23:55 | |
| *** SotK has quit IRC | 23:55 | |
| *** openstackgerrit has quit IRC | 23:55 | |
| *** pleia2 has quit IRC | 23:55 | |
| *** gothicmindfood has quit IRC | 23:55 | |
| *** pedroalvarez has quit IRC | 23:55 | |
| *** jasondotstar has quit IRC | 23:55 | |
| *** ttx has quit IRC | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!