| *** cody-somerville has joined #storyboard | 03:24 | |
| *** cody-somerville has quit IRC | 05:06 | |
| *** jtomasek has joined #storyboard | 07:04 | |
| *** jcoufal has joined #storyboard | 07:05 | |
| *** ttx has quit IRC | 07:23 | |
| *** ttx has joined #storyboard | 07:23 | |
| *** jcoufal has quit IRC | 10:11 | |
| Zara | fixed one of the bugs. still a million more to go. :D | 10:30 |
|---|---|---|
| *** mrmartin has joined #storyboard | 10:30 | |
| *** jcoufal has joined #storyboard | 12:03 | |
| *** mrmartin has quit IRC | 12:11 | |
| Zara | ack I completely forgot that I meant to make today my reviewing day, before I go on holiday | 12:17 |
| pdar | heya, when looking at the list of stories in storyboard, i couldnt see how to look at stories "x to y" for x!=1 | 12:19 |
| pdar | is there a way to do this? | 12:19 |
| Zara | SotK wrote patches about pagination | 12:19 |
| SotK | not easily until the pagination patches are merged | 12:19 |
| Zara | ah, there we go | 12:19 |
| * SotK finds the thing to change to do it without that... | 12:19 | |
| Zara | list of webclient patches here https://review.openstack.org/#/q/status:open+project:openstack-infra/storyboard-webclient,n,z | 12:20 |
| Zara | hehe, need to +2 again post-rebase... | 12:21 |
| * pdar finds it | 12:22 | |
| SotK | pdar: set `params.marker` equal to some number !=1 around line 115 in src/app/search/directive/search_results.js to do it without the pagination patches | 12:22 |
| pdar | ta Zara SotK | 12:27 |
| Zara | np. some of these are so old that I've lost track of what's actually been merged at this point. | 12:28 |
| Zara | patch approved! sorry, got distracted by a conversation on another channel about pokemon. | 12:53 |
| SotK | \o/ thanks | 12:54 |
| Zara | I see we're still awaiting reviews for its companion patch, here: https://review.openstack.org/#/c/198768/ | 12:54 |
| Zara | oh and https://review.openstack.org/#/c/198769/ | 13:05 |
| Zara | I thought that had been merged earlier, but must have just been the storyboard side o fit | 13:06 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Make result_set_pager show the correct numbers https://review.openstack.org/195511 | 13:15 |
| * SotK grumbles about merge conflicts | 13:18 | |
| Zara | :( | 13:19 |
| Zara | hahaha, I thought I'd introduced a bug with my subscriptions code, but actually it's an error message that has been there all along | 13:19 |
| Zara | the code's still horrible for other reasons, but that's not one of them! :D | 13:20 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add paging controls to the result set pager https://review.openstack.org/198768 | 13:21 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Implement offset/limit pagination of lists https://review.openstack.org/198769 | 13:21 |
| SotK | haha :) | 13:21 |
| Zara | (atm it refreshes now with each click to a star, but it refreshes *the whole page*. and the code is still spaghetti and will need duplicating for each type of resource. I've hung back a bit from implementing it elsewhere because I'd like to get a better method of doing it instead. normally with these things I eventually realise that I just needed 3 extra lines in the original file, but hey. :)) | 13:25 |
| Zara | tested pg title patch, seems to work fine and is long-overdue; thanks SotK | 13:40 |
| SotK | thanks :) | 13:41 |
| *** jcoufal has quit IRC | 13:44 | |
| Zara | creator_id stuff works fine. I don't think search from searchbox is implemented for it, but they're showing up on the dashboard. I'd also be wary of merging it before subscriptions patch, if it's not urgent | 15:03 |
| Zara | since it may dramatically increase the time it takes the dashboard page to display | 15:03 |
| SotK | That's a good point, probably worth hanging back on merging that then | 15:04 |
| SotK | re scrollbar in the navbar: I think we should merge it and add a story to http://storyboard.openstack.org/ to come up with a more elegant solution | 15:05 |
| * SotK is in favour of incrementally improving things | 15:05 | |
| Zara | ditto | 15:06 |
| Zara | I honestly didn't realise there was an admin thing below 'profile' when I first started using storyboard, because it was hidden | 15:10 |
| Zara | a scrollbar is ugly but it won't actually stop people from finding features they need, so it's got that going for it. :P | 15:11 |
| Zara | I'm off to catch a train soon; any urgent storyboard-related stuff before I go? | 15:12 |
| * SotK can't think of anything | 15:13 | |
| pdar | oh, I just noticed the "About" and "Licence" links appear mid scroll thing | 15:13 |
| SotK | https://review.openstack.org/#/c/199095/ fixes that I think | 15:14 |
| Zara | I like that we all noticed all the same things first xD | 15:14 |
| Zara | I'd like it to immediately seem polished when people first start to use it. it's so pretty. | 15:15 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Allow scroll when navbar content exceeds height of screen https://review.openstack.org/196079 | 15:28 |
| *** CTtpollard has quit IRC | 15:35 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Stop 'about' and 'license' buttons overlapping others https://review.openstack.org/199095 | 15:35 |
| *** mrmartin has joined #storyboard | 18:01 | |
| *** cody-somerville has joined #storyboard | 18:54 | |
| *** jtomasek has quit IRC | 19:04 | |
| *** mrmartin has quit IRC | 19:07 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Stop using fixed-width containers https://review.openstack.org/201124 | 19:53 |
| *** cody-somerville has quit IRC | 20:00 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!