| krotscheck | So when a user clicks on the link, they see the pretty webclient, not the API | 00:00 |
|---|---|---|
| greghaynes | aha! | 00:00 |
| krotscheck | Since the webclient and the APi are separate projects, and are not necessarily installed on the same server, how do we handle tha? | 00:00 |
| krotscheck | Hence me teaching the API that it should send any and all HTTP requests with text/html accepts headers to a different domain. | 00:00 |
| krotscheck | And then just write the API url to the changed resource into the email. | 00:01 |
| greghaynes | yea, totally makes sense now | 00:01 |
| greghaynes | and yep, thats an issue ;) | 00:01 |
| krotscheck | All the little prerequisites that one never thinks of when someone says: I need email! | 00:02 |
| greghaynes | yea, the app I worked on was monolithic so this also wasnt an issue | 00:02 |
| greghaynes | I guess another email question - are we going to actually be doing the sending or is this just smtp to a relay thatll do the sending? | 00:10 |
| greghaynes | it ends up being an issue for things like dkim which kind of suck to do in python | 00:10 |
| greghaynes | but help a lot to not be considered a spammer | 00:11 |
| greghaynes | (might be an -infra questoin) | 00:11 |
| krotscheck | greghaynes: Honestly, i think we have to use sendmail and make someone else send it. Reason is that some clouds actively sending email. | 00:19 |
| * krotscheck glares at HP | 00:19 | |
| krotscheck | sorry | 00:19 |
| krotscheck | s/actively/actively block/ | 00:19 |
| greghaynes | yea, thats actually a good idea | 00:21 |
| greghaynes | otherwise you end up having to do all sorts of domain specific config in your app for what type of headers you want to put in the messages | 00:21 |
| greghaynes | and making that someone elses problem is awesome | 00:21 |
| krotscheck | Ok, so you hit the API at, say, /v1/projects | 00:25 |
| krotscheck | Middleware catches that you want HTML, so it does a 303 See Other | 00:25 |
| krotscheck | And it sends you to…. configured_url/?somevariablename=/v1/projects | 00:26 |
| krotscheck | So that the JS client can parse it. | 00:26 |
| krotscheck | But what is that variable nam? | 00:26 |
| krotscheck | Actually | 00:30 |
| greghaynes | wait, theres a 1:1 mapping from api endpoints to ui entrypoints? | 00:30 |
| krotscheck | greghaynes: Not quite, but we’re pretty close | 00:32 |
| krotscheck | API starts (I believe) at /api/v1 | 00:32 |
| krotscheck | UI starts at #!/ | 00:32 |
| krotscheck | And there’s some resources that are just not represented. | 00:33 |
| krotscheck | But overall, yeah, I think that was kindof the idea. | 00:33 |
| krotscheck | I think the UI uses singular resources, but that can be changed. | 00:33 |
| * krotscheck is seriously thinking about making the UI represent the api structure as closely as possible where posisble. | 00:34 | |
| greghaynes | hrm, if you can, seems hard | 00:34 |
| krotscheck | At the very least, the GET url’s to see specific resources should be the same. | 00:34 |
| krotscheck | Well, for exampel: | 00:34 |
| krotscheck | https://storyboard.openstack.org/#!/project_group/55 | 00:34 |
| krotscheck | In the API, that’s /api/v1/project_groups/55 | 00:34 |
| krotscheck | I’m ok with stripping out everything before the resource name, and then making the UI adhere to a similar url structure. | 00:35 |
| greghaynes | yea, if youre able to have mappings like that its awesome | 00:36 |
| greghaynes | which you might totally be able to in a ticket tracking system, its pretty data driven | 00:36 |
| krotscheck | Exactly | 00:39 |
| *** Piet has joined #storyboard | 00:43 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Redirect Browsers from API to Client https://review.openstack.org/155551 | 01:03 |
| krotscheck | greghaynes: ^^ | 01:04 |
| greghaynes | krotscheck: So interesting issue, it seems were not catching IntegrityError's as DBReferenceError's | 01:05 |
| greghaynes | and this is surfacing when I switch to pymysql for some reason | 01:06 |
| krotscheck | …wha? | 01:06 |
| greghaynes | oh joy, and this is in oslo.db AFAICT | 01:06 |
| greghaynes | yea, im kind of mind=blpwn | 01:07 |
| greghaynes | best guess is pymysql and mysql-python raise different exceptions for foreign key errors | 01:07 |
| greghaynes | oh my, I just saw what is actually going in in oslo.db for this | 01:22 |
| greghaynes | some things cannot be unseen | 01:22 |
| greghaynes | krotscheck: https://review.openstack.org/155574 | 01:54 |
| * greghaynes needs a drink after that one | 01:54 | |
| krotscheck | No way | 01:55 |
| krotscheck | What? | 01:55 |
| greghaynes | yep | 01:55 |
| krotscheck | WHAT IS THAT THING | 01:55 |
| greghaynes | like I said, some things cannot be unseen | 01:55 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Switch from mysql-python to PyMySQL https://review.openstack.org/152339 | 02:18 |
| greghaynes | now to try out this cross-repo dependency thing :) | 02:19 |
| *** coolsvap_ is now known as coolsvap | 06:18 | |
| *** mrmartin has joined #storyboard | 06:48 | |
| *** alexismonville has joined #storyboard | 06:50 | |
| *** yolanda_ has joined #storyboard | 06:57 | |
| *** jtomasek has joined #storyboard | 07:15 | |
| *** alexismonville has quit IRC | 07:29 | |
| *** alexismonville has joined #storyboard | 07:32 | |
| *** alexismonville has quit IRC | 07:54 | |
| *** jcoufal has joined #storyboard | 08:09 | |
| *** mrmartin has quit IRC | 08:29 | |
| *** CTtpollard has joined #storyboard | 08:37 | |
| *** openstackgerrit has quit IRC | 08:42 | |
| *** openstackgerrit has joined #storyboard | 08:42 | |
| *** yolanda_ has quit IRC | 08:48 | |
| *** yolanda has quit IRC | 08:48 | |
| *** yolanda has joined #storyboard | 08:48 | |
| *** yolanda_ has joined #storyboard | 08:48 | |
| *** CTtpollard has quit IRC | 09:02 | |
| *** MaxV has joined #storyboard | 09:09 | |
| *** CTtpollard has joined #storyboard | 09:17 | |
| *** tpollard_ has joined #storyboard | 09:17 | |
| *** CTtpollard has quit IRC | 09:21 | |
| *** tpollard_ has quit IRC | 09:23 | |
| *** CTtpollard has joined #storyboard | 09:23 | |
| *** mrmartin has joined #storyboard | 09:38 | |
| *** yolanda_ has quit IRC | 11:30 | |
| *** yolanda has quit IRC | 11:30 | |
| *** yolanda_ has joined #storyboard | 11:31 | |
| *** yolanda has joined #storyboard | 11:31 | |
| *** alexismonville has joined #storyboard | 12:55 | |
| *** jcoufal_ has joined #storyboard | 13:30 | |
| *** jcoufal has quit IRC | 13:33 | |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Fix tests to use correct base classes https://review.openstack.org/155750 | 14:10 |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Session per request https://review.openstack.org/155751 | 14:10 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added branches to storyboard https://review.openstack.org/150447 | 14:14 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added milestones https://review.openstack.org/152500 | 14:20 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added new paginate query https://review.openstack.org/153231 | 14:24 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Delete all user tokens method https://review.openstack.org/155759 | 14:39 |
| *** jcoufal_ has quit IRC | 14:57 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Delete all user tokens method https://review.openstack.org/155759 | 15:29 |
| *** Piet has quit IRC | 15:33 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Fix owner_id rejection https://review.openstack.org/155787 | 15:41 |
| *** coolsvap is now known as coolsvap_ | 15:43 | |
| *** jedimike has joined #storyboard | 15:43 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Fix comments put method https://review.openstack.org/155790 | 15:44 |
| *** MaxV has quit IRC | 16:30 | |
| *** jcoufal has joined #storyboard | 16:46 | |
| *** jcoufal has quit IRC | 16:51 | |
| *** yolanda_ has quit IRC | 16:55 | |
| *** CTtpollard has quit IRC | 17:03 | |
| openstackgerrit | Merged openstack-infra/storyboard: Fix owner_id rejection https://review.openstack.org/155787 | 17:08 |
| *** CTtpollard has joined #storyboard | 17:58 | |
| openstackgerrit | Merged openstack-infra/storyboard: Added new paginate query https://review.openstack.org/153231 | 17:59 |
| *** krotscheck has quit IRC | 18:00 | |
| *** krotscheck has joined #storyboard | 18:00 | |
| *** alexismonville has quit IRC | 18:01 | |
| krotscheck | It’s patches like this that make me really happy: https://review.openstack.org/#/c/155751/ | 18:03 |
| krotscheck | (Even though I -1’d it) | 18:03 |
| openstackgerrit | Merged openstack-infra/storyboard: Fix tests to use correct base classes https://review.openstack.org/155750 | 18:03 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Switch from mysql-python to PyMySQL https://review.openstack.org/152339 | 18:16 |
| * krotscheck should be getting better with reviews from here on out. | 18:17 | |
| krotscheck | I have a better search that shows me what I need to look at. | 18:17 |
| greghaynes | heh, its the cycle of using gerrit | 18:17 |
| greghaynes | you think you found a way to manage your reviews list | 18:17 |
| greghaynes | then you want to add a different project to your review list | 18:17 |
| greghaynes | anyhow, the oslo.db fix is merged, so ^ should pass py27 now | 18:18 |
| krotscheck | Oh good :) | 18:19 |
| krotscheck | Which means it’ll show on my review list :) | 18:19 |
| * krotscheck filters out anything that doesn’t pass jenkins | 18:19 | |
| CTtpollard | cool | 18:21 |
| CTtpollard | that's a good filter ;) | 18:24 |
| * greghaynes wonders why not use the pecan TransactionHook for https://review.openstack.org/#/c/155751/1/storyboard/api/middleware/session_hook.py | 18:27 | |
| greghaynes | since really thats what we want to be wrapping, not sessions | 18:27 |
| *** Piet has joined #storyboard | 18:30 | |
| *** CTtpollard has quit IRC | 18:31 | |
| greghaynes | aw crap, oslo.db fix is merged but need to ask them for a release | 18:34 |
| greghaynes | this also sucks becuase our requirements are essentially oslo.db>=this_new_version | 18:37 |
| greghaynes | which isnt going to fly with global-reqs | 18:37 |
| greghaynes | sweet, so they say release will be on monday \O/ | 18:43 |
| greghaynes | krotscheck: Something about the api redirect deal, thats going to make debugging the API annoying | 18:52 |
| krotscheck | greghaynes: Propose it! | 18:52 |
| krotscheck | greghaynes: Isn’t that why we hve unit tests? | 18:53 |
| krotscheck | greghaynes: I mean functional tests? | 18:53 |
| krotscheck | Or do you mean hitting it directly with your browser? | 18:53 |
| greghaynes | yes, but its still fun to hit it with your browser at times | 18:53 |
| krotscheck | greghaynes: I ususally end up using https://chrome.google.com/webstore/detail/postman-rest-client/fdmmgilgnpjigdojojpjoooidkmcomcm | 18:54 |
| greghaynes | yea, that is a thing | 18:54 |
| krotscheck | greghaynes: I get why though. | 18:54 |
| greghaynes | krotscheck: oh, so the request for things for GSoC is going out, someone working on storyboard might not be a bad GSoC deal | 18:58 |
| krotscheck | GSoC? | 18:58 |
| krotscheck | Oh! | 18:58 |
| krotscheck | Linky? | 18:58 |
| greghaynes | http://lists.openstack.org/pipermail/openstack-dev/2015-February/056850.html | 18:59 |
| greghaynes | Ive been a mentor 3 or so times so I wouldnt mind proposing something | 19:00 |
| krotscheck | Yeah, I had an intern last year that resulted in some neat work done. | 19:00 |
| krotscheck | WOuldn’t mind doing that again. | 19:00 |
| krotscheck | Dunno what project in storyboard would fit well though, any thoughts? | 19:00 |
| *** Piet has quit IRC | 19:01 | |
| greghaynes | heh, that is exactly the info I am lacking | 19:01 |
| greghaynes | given that ive just been messing around with it for a few weeks ;) | 19:01 |
| krotscheck | Cool, let’s put that on monday’s agenda for some brainstorming :) | 19:01 |
| greghaynes | SGTM | 19:01 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Fix comments put method https://review.openstack.org/155790 | 19:07 |
| greghaynes | krotscheck: For this redirect thing, since we have a default_client_url in the API config, is there an reason we dont just build urls that are default_client_url/#!/api_path directly? | 19:15 |
| greghaynes | build urls like that in the emails, that is | 19:16 |
| krotscheck | greghaynes: That seems like too obvious a solution. | 19:18 |
| greghaynes | :p | 19:18 |
| krotscheck | greghaynes: But yeah. | 19:18 |
| krotscheck | greghaynes: Way too simple and obvious. | 19:18 |
| krotscheck | Hrm, creating project gorups in the UI client doesn’t seem to work anymore. | 19:31 |
| *** yolanda has quit IRC | 19:47 | |
| *** yolanda has joined #storyboard | 19:49 | |
| yolanda | krotscheck , what happens? i approved a change before | 19:53 |
| krotscheck | yolanda: Nothing- it hangs in some kind of an infinite promise loop. | 19:53 |
| krotscheck | I’ll take a look as soon as I’m done rooting around in our routes. | 19:54 |
| yolanda | i don't seem to have perms for that in adin | 19:54 |
| yolanda | admin | 19:54 |
| yolanda | does it happen locally? | 19:54 |
| krotscheck | yolanda: Yeah, in my local | 19:56 |
| krotscheck | As I said, I’ll look into it :) | 19:56 |
| yolanda | ok, understood :) | 20:09 |
| yolanda | no computer for today | 20:10 |
| *** jcoufal has joined #storyboard | 20:22 | |
| krotscheck | Oh god I’m about to do something that makes me feel dirty | 20:45 |
| *** Piet has joined #storyboard | 22:08 | |
| *** jcoufal has quit IRC | 22:29 | |
| *** alexismonville has joined #storyboard | 22:32 | |
| *** mrmartin has quit IRC | 22:33 | |
| *** alexismonville has quit IRC | 22:45 | |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Separate out py3 requirements and remove email https://review.openstack.org/155078 | 22:55 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Switch from mysql-python to PyMySQL https://review.openstack.org/152339 | 23:14 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Reorder py27 test to happen after py3 tests https://review.openstack.org/155161 | 23:33 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use python3 compatible httpclient https://review.openstack.org/155139 | 23:34 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use python3 compatible unicode types https://review.openstack.org/155140 | 23:37 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use python3 compatible urllib https://review.openstack.org/155150 | 23:38 |
| *** jedimike has quit IRC | 23:38 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Notification hook checks for old entity. https://review.openstack.org/155920 | 23:38 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use python3 compatible urllib https://review.openstack.org/155150 | 23:49 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use Python 3 compatible configparser https://review.openstack.org/155922 | 23:49 |
| greghaynes | ok, were getting close | 23:49 |
| greghaynes | now just on to runtime errors | 23:49 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!