| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email base plugin. https://review.openstack.org/151948 | 00:15 |
|---|---|---|
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email SMTP Sender https://review.openstack.org/149792 | 00:15 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: [WIP] Email Send Cron Worker https://review.openstack.org/151416 | 00:15 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Working Directory Utility Method https://review.openstack.org/151947 | 00:15 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Outbox https://review.openstack.org/151413 | 00:15 |
| krotscheck | I have _NO_ idea why my sender test passes locally but not on jenkins. | 00:15 |
| krotscheck | Here’s hoping this time it works. | 00:15 |
| jesusaurus | krotscheck: silly question, but did you look at dependency versions / did you try locally with a clean slate? | 00:20 |
| krotscheck | jesusaurus: I did not. | 00:21 |
| krotscheck | jesusaurus: I’ll try that again next time around. it’s odd though that the errors are all DB related, when the code changes themselves don’t touch the DB. | 00:21 |
| jesusaurus | yeah, thats very odd | 00:21 |
| greghaynes | I really wish we had some tests that either didnt mock out smtp or did at a much lower level so we could compare what message content is actually being sent over the wire | 00:22 |
| greghaynes | maybe spawn a background smtpd that writes out messages to an mbox and compare the resulting mbox | 00:22 |
| greghaynes | I say this because email is *the worst* for hitting encoding issues, and when we hit them were really going to want to be able to make a test case in that format | 00:23 |
| krotscheck | greghaynes: If that’s somethign we can set up on our jenkins nodes, that’d be pretty awesome. | 00:25 |
| jesusaurus | you could probably do something with nullmailer to a local mbox | 00:26 |
| greghaynes | yea, I think it'd be doable. /me adds background task to do this | 00:26 |
| greghaynes | hrm | 00:27 |
| greghaynes | well, python has a build in smtpd thats pretty simple | 00:27 |
| greghaynes | could probably just make a fixture around it | 00:27 |
| krotscheck | greghaynes: I see a thing here that might be a thing: https://pypi.python.org/pypi/pytest-localserver | 00:29 |
| greghaynes | ooo | 00:29 |
| greghaynes | haha, even has smtpd example | 00:30 |
| greghaynes | its a py.test plugin so might need to be fixturified | 00:30 |
| krotscheck | I don’t know if it intercepts at the level you want it to though, ti suggests that it just grabs things and puts them into an outbox? | 00:30 |
| greghaynes | yea, thatd be fine, then we just send email to it and compare | 00:31 |
| krotscheck | If not that, then this: http://code.activestate.com/recipes/440690/ | 00:31 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use python3 compatible httpclient https://review.openstack.org/155139 | 00:59 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use python3 compatible unicode types https://review.openstack.org/155140 | 00:59 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use python3 compatible urllib https://review.openstack.org/155150 | 01:19 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use python3 compatible unicode types https://review.openstack.org/155140 | 01:22 |
| greghaynes | so https://bugs.launchpad.net/testrepository/+bug/1229445 is a hilarious bug | 01:41 |
| openstack | Launchpad bug 1212909 in Testrepository "duplicate for #1229445 ImportError _bsddb with deadsnakes python2.6 anydbm" [Critical,Triaged] | 01:41 |
| greghaynes | fix for that incoming | 01:41 |
| greghaynes | er, workaround | 01:41 |
| krotscheck | Wait, dead snakes? | 01:54 |
| greghaynes | best kind of snakes | 01:56 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Switch from mysql-python to PyMySQL https://review.openstack.org/152339 | 02:06 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Reorder py27 test to happen after py3 tests https://review.openstack.org/155161 | 02:08 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use python3 compatible httpclient https://review.openstack.org/155139 | 02:10 |
| *** Piet has quit IRC | 03:22 | |
| greghaynes | interestingly - switching to pymysql results in a foreign key constraint error during tets | 03:31 |
| greghaynes | which is scary | 03:31 |
| *** Piet has joined #storyboard | 03:32 | |
| *** coolsvap has joined #storyboard | 05:19 | |
| *** coolsvap has quit IRC | 05:21 | |
| *** coolsvap_ has joined #storyboard | 05:22 | |
| *** coolsvap_ is now known as coolsvap | 05:22 | |
| *** alexismonville has quit IRC | 06:27 | |
| openstackgerrit | Merged openstack-infra/storyboard: Reject false creator_id from requests https://review.openstack.org/151650 | 06:58 |
| *** jcoufal has joined #storyboard | 07:35 | |
| yolanda | krotscheck, remove the +2 | 07:45 |
| *** coolsvap has quit IRC | 07:48 | |
| *** coolsvap has joined #storyboard | 07:48 | |
| *** jcoufal has quit IRC | 07:49 | |
| *** jcoufal has joined #storyboard | 07:49 | |
| *** mrmartin has joined #storyboard | 08:05 | |
| openstackgerrit | Merged openstack-infra/storyboard: Add test_after_publishes_payload to test_notification_hook https://review.openstack.org/155017 | 08:05 |
| yolanda | ttx, krotscheck, when you have a chance... https://review.openstack.org/#/c/151650/ | 08:08 |
| yolanda | i'd like to have another +2 here and merge | 08:08 |
| ttx | yolanda: looking | 08:15 |
| ttx | it's merged now | 08:16 |
| yolanda | thx | 08:21 |
| *** openstackgerrit has quit IRC | 08:21 | |
| *** openstackgerrit has joined #storyboard | 08:21 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added branches to storyboard https://review.openstack.org/150447 | 08:50 |
| *** jtomasek has joined #storyboard | 08:51 | |
| *** MaxV has joined #storyboard | 08:55 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added branches to storyboard https://review.openstack.org/150447 | 09:01 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Datetime instances from SQLAlchemy now all contain timezone. https://review.openstack.org/155083 | 09:01 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added milestones https://review.openstack.org/152500 | 09:02 |
| *** jtomasek has quit IRC | 09:20 | |
| *** jtomasek has joined #storyboard | 09:34 | |
| *** jtomasek has quit IRC | 09:37 | |
| *** jtomasek has joined #storyboard | 09:37 | |
| *** ssam2 has joined #storyboard | 09:58 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added branches to storyboard https://review.openstack.org/150447 | 10:06 |
| yolanda | oh, that storyboard seems to be doing something wrong | 10:10 |
| yolanda | i got | 10:10 |
| yolanda | 400: PUT /api/v1/tasks/2060: You can't change author of task. | 10:10 |
| yolanda | and i really didn't do that | 10:10 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added milestones https://review.openstack.org/152500 | 10:16 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added new paginate query https://review.openstack.org/153231 | 10:19 |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard-webclient: Fix error notifications https://review.openstack.org/155242 | 10:33 |
| yolanda | mm, NikitaKonovalov, you there? found a bug, but only happening to me with some stories | 10:36 |
| yolanda | for example https://storyboard.openstack.org/#!/story/2000018 | 10:36 |
| yolanda | i want to change the status from Review to Merged | 10:36 |
| yolanda | when i do it, it shows me error "You can't change the author of the task" | 10:36 |
| yolanda | it happens because the Author of the story is another, not me | 10:37 |
| yolanda | but i created the task | 10:37 |
| yolanda | so i'm author of the task | 10:37 |
| yolanda | when i want to update my task, it complains about the author, i bet that because story and task authors don't match | 10:37 |
| yolanda | or aripinen ^ | 10:38 |
| NikitaKonovalov | ok, let's see' | 10:51 |
| *** alexismonville has joined #storyboard | 11:03 | |
| yolanda | mm, ttx, bad paste, i meant that https://review.openstack.org/#/c/152133/ | 11:06 |
| yolanda | for the change i asked you to review before, sorry | 11:06 |
| yolanda | anytime | 11:31 |
| yolanda | uups, bad window... | 11:31 |
| ttx | yolanda: done | 13:02 |
| yolanda | thx | 13:02 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Fix in project groups validation https://review.openstack.org/152133 | 13:12 |
| *** jcoufal_ has joined #storyboard | 13:17 | |
| *** jcoufal has quit IRC | 13:20 | |
| *** ssam2 has quit IRC | 13:36 | |
| *** ssam2 has joined #storyboard | 13:54 | |
| *** ssam2 has quit IRC | 14:00 | |
| *** jcoufal_ has quit IRC | 14:02 | |
| *** jcoufal has joined #storyboard | 14:02 | |
| *** Piet has quit IRC | 14:06 | |
| *** miqui_ has joined #storyboard | 14:13 | |
| *** ssam2 has joined #storyboard | 14:17 | |
| *** ssam2 has quit IRC | 14:30 | |
| *** jtomasek has quit IRC | 14:31 | |
| *** jcoufal has quit IRC | 14:33 | |
| *** jcoufal_ has joined #storyboard | 14:33 | |
| *** ssam2 has joined #storyboard | 14:43 | |
| *** jtomasek has joined #storyboard | 14:44 | |
| *** Piet has joined #storyboard | 15:39 | |
| *** ssam2 has quit IRC | 15:43 | |
| *** ssam2 has joined #storyboard | 15:43 | |
| *** ssam2 has quit IRC | 15:56 | |
| *** jedimike has joined #storyboard | 15:59 | |
| yolanda | krotscheck, https://review.openstack.org/155242 | 16:54 |
| *** MaxV has quit IRC | 16:54 | |
| *** CTtpollard has quit IRC | 17:04 | |
| *** jcoufal_ has quit IRC | 17:07 | |
| *** coolsvap is now known as coolsvap_ | 17:12 | |
| *** coolsvap_ is now known as coolsvap | 17:55 | |
| *** jedimike has quit IRC | 18:30 | |
| krotscheck | FYI everyone: https://review.openstack.org/155086 just merged, py34 is now a nonvoting test for storyboard. | 18:42 |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard-webclient: Fix error notifications https://review.openstack.org/155242 | 18:49 |
| *** Piet has quit IRC | 18:55 | |
| *** coolsvap is now known as coolsvap_ | 18:57 | |
| greghaynes | \o/ | 19:13 |
| *** alexismonville has quit IRC | 19:40 | |
| *** alexismonville has joined #storyboard | 20:11 | |
| *** jtomasek has quit IRC | 20:35 | |
| *** alexismonville has quit IRC | 20:39 | |
| *** Piet has joined #storyboard | 21:42 | |
| *** Piet has quit IRC | 21:49 | |
| *** mrmartin has quit IRC | 22:28 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email base plugin. https://review.openstack.org/151948 | 23:34 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email SMTP Sender https://review.openstack.org/149792 | 23:34 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Send Cron Worker https://review.openstack.org/151416 | 23:34 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Working Directory Utility Method https://review.openstack.org/151947 | 23:34 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Outbox https://review.openstack.org/151413 | 23:34 |
| * krotscheck is pondering canonical url resolution | 23:35 | |
| * krotscheck needs it for email templating. | 23:36 | |
| greghaynes | huh? | 23:37 |
| greghaynes | that reminds me, do we actually have a worker model for the email senders? like an mq queue they consume from or something | 23:38 |
| *** openstack has joined #storyboard | 23:42 | |
| krotscheck | greghaynes: Not yet, that’s next. | 23:53 |
| krotscheck | The workers are there. | 23:53 |
| krotscheck | Sorry | 23:53 |
| krotscheck | The worker framework is there. | 23:53 |
| krotscheck | It’s what we use for subscriptions. | 23:53 |
| krotscheck | The email consumer to that queue isn’t there yet. | 23:53 |
| krotscheck | I’m putting the pieces together. Like right now I’m trying to build a set of email templates for single events, and would like to include a URL in the message. | 23:54 |
| krotscheck | But fact is that the APi doesn’t know about the client. | 23:54 |
| krotscheck | So linking back to the client requires some kind of hey-look-over-here parsing. | 23:54 |
| krotscheck | My current thought is to add wsgi middleware that checks for the Accepts header, and if it’s text/html or some flavor thereof, send you to a oconfigured default client URl instead. | 23:55 |
| krotscheck | So if in an email you get https://storyboard.openstack.org/api/v1/story/1, and you click on it in your email, it’ll eventually 302 to #!/story/1 | 23:56 |
| krotscheck | Or something like that | 23:56 |
| krotscheck | But if you’re parsing URL’s from an automated email parser, and you send a request with Accepts: application/json, you won’t get the redirect and will get the raw resource instead. | 23:56 |
| greghaynes | so in the last system like this I worked on we would serialize the objects we were operating on and include them in the message we put on the worker queue | 23:56 |
| greghaynes | so the consumers just had to do a templating job | 23:57 |
| greghaynes | this prevents other issues, like races | 23:57 |
| krotscheck | greghaynes: That merged on monday https://review.openstack.org/#/c/152318/ | 23:57 |
| greghaynes | where you push a message onto the queue, the db value changes, then yore trying to template on old message using new data | 23:57 |
| greghaynes | oh nice :) | 23:57 |
| greghaynes | yep | 23:57 |
| krotscheck | We actually include the full before/after entity, so the worker can do a diff if it wants to | 23:58 |
| greghaynes | yea, exactly, thats what you need | 23:58 |
| greghaynes | so I must be missing some context with the problem then | 23:58 |
| krotscheck | rcarrillocruz did that piece in the previous patch, all I did was add it to the notification messages. | 23:58 |
| krotscheck | Right, so let’s say I build an email. I’m on the API right now, which is installed at “api.storyboard.openstack.org” or something like that. When I build the email, I want to build a URL that eventually goes to “client.storyboard.api.org" | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!