| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added functional tests for the OAuth Endpoint https://review.openstack.org/152752 | 00:57 |
|---|---|---|
| krotscheck | 700 lines of tests. | 00:57 |
| krotscheck | Note that they don’t actually pass, because our oauth endpoint doesn’t actually do what it’s supposed to. | 00:58 |
| krotscheck | Anyone can feel free to jump in and help fix it :) | 01:00 |
| *** cody-somerville has quit IRC | 01:25 | |
| *** Piet has quit IRC | 01:33 | |
| *** cody-somerville has joined #storyboard | 02:14 | |
| *** cody-somerville has quit IRC | 02:24 | |
| *** coolsvap_ is now known as coolsvap | 05:57 | |
| *** mrmartin has joined #storyboard | 06:17 | |
| *** alexismonville has joined #storyboard | 07:04 | |
| yolanda | k, i'll take a look this morning | 07:38 |
| *** jcoufal has joined #storyboard | 07:54 | |
| *** alexismonville has quit IRC | 08:05 | |
| *** mrmartin has quit IRC | 08:33 | |
| *** mrmartin has joined #storyboard | 08:37 | |
| *** gforcada has joined #storyboard | 08:40 | |
| *** alexismonville has joined #storyboard | 08:45 | |
| *** gforcada has quit IRC | 08:45 | |
| *** MaxV has joined #storyboard | 08:49 | |
| *** gforcada has joined #storyboard | 09:16 | |
| rcarrillocruz | krotscheck: i'm cool taking that task | 09:23 |
| rcarrillocruz | let's sync up when you are online (was off yesterday) | 09:23 |
| *** ssam2 has joined #storyboard | 09:48 | |
| *** jcoufal_ has joined #storyboard | 09:52 | |
| *** jcoufal has quit IRC | 09:53 | |
| *** jtomasek has joined #storyboard | 10:12 | |
| *** gforcada has left #storyboard | 10:14 | |
| *** yolanda has quit IRC | 10:54 | |
| *** yolanda has joined #storyboard | 10:54 | |
| *** mattfarina has joined #storyboard | 11:44 | |
| *** alexismonville1 has joined #storyboard | 12:13 | |
| openstackgerrit | Merged openstack-infra/storyboard: Fix NotFound errors https://review.openstack.org/152137 | 12:13 |
| openstackgerrit | Merged openstack-infra/storyboard: Fix status code on delete https://review.openstack.org/151603 | 12:13 |
| *** ilyashakhat_ has joined #storyboard | 12:17 | |
| *** alexismonville has quit IRC | 12:20 | |
| *** ilyashakhat has quit IRC | 12:20 | |
| *** mase_x200 has joined #storyboard | 12:33 | |
| *** mase_x200 has quit IRC | 12:44 | |
| *** mase_x200 has joined #storyboard | 12:56 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added branches to storyboard https://review.openstack.org/150447 | 12:57 |
| *** jesusaurus has quit IRC | 13:00 | |
| *** ongk has quit IRC | 13:00 | |
| *** ongk has joined #storyboard | 13:03 | |
| *** jesusaurus has joined #storyboard | 13:05 | |
| *** mase_x200 has quit IRC | 13:10 | |
| *** mrmartin has quit IRC | 13:36 | |
| *** alexismonville1 has quit IRC | 13:39 | |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard-webclient: Fix in project groups validation https://review.openstack.org/152133 | 13:50 |
| yolanda | krotscheck, about validation errors, the only place i've seen that is on the auth screen. The others just log an error on the console to show the real error | 13:50 |
| *** alexismonville has joined #storyboard | 13:54 | |
| *** reed has joined #storyboard | 14:14 | |
| *** mrmartin has joined #storyboard | 14:25 | |
| yolanda | krotscheck, when you come online, i've been looking at that code for http interceptor but i can't follow quite well where the notifications are consumed to generate and display an error | 14:26 |
| *** alexismonville has quit IRC | 15:07 | |
| *** jcoufal has joined #storyboard | 15:09 | |
| *** alexismonville has joined #storyboard | 15:09 | |
| *** jcoufal_ has quit IRC | 15:12 | |
| *** mattfarina has quit IRC | 15:27 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added new way to filter stories by tags https://review.openstack.org/152951 | 15:39 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added branches to storyboard https://review.openstack.org/150447 | 15:43 |
| *** CTtpollard has quit IRC | 15:44 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added branches to storyboard https://review.openstack.org/150447 | 15:51 |
| *** CTtpollard has joined #storyboard | 15:57 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added branches to storyboard https://review.openstack.org/150447 | 15:58 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added milestones https://review.openstack.org/152500 | 15:58 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added new way to filter stories by tags https://review.openstack.org/152951 | 16:00 |
| *** mattfarina has joined #storyboard | 16:12 | |
| *** coolsvap is now known as coolsvap_ | 16:28 | |
| *** MaxV has quit IRC | 17:06 | |
| *** alexismonville has quit IRC | 17:11 | |
| *** jcoufal has quit IRC | 17:26 | |
| krotscheck | yolanda: Ok, I’m back | 17:28 |
| krotscheck | So, I didn’t actually write the OAuth things, I believe that was all NikitaKonovalov | 17:28 |
| krotscheck | All I did was speed-read the spec and wrote some tests. | 17:28 |
| yolanda | Ricardo told me he will take care of the oauth things | 17:29 |
| krotscheck | Awesome | 17:30 |
| yolanda | i was trying to see why errors aren't shown, i saw that you have an http interceptor | 17:30 |
| yolanda | that sends an event | 17:30 |
| *** Piet has joined #storyboard | 17:30 | |
| yolanda | but i don't see where are they trapped | 17:30 |
| krotscheck | Yeah, and that error is supposed to be picked up by the error environment | 17:30 |
| yolanda | which is that error environmetn? | 17:31 |
| yolanda | is there something on place to consume that errors and show an alert? | 17:31 |
| yolanda | i saw a Notification class, but i see that this is only consuming events at launching the app | 17:32 |
| krotscheck | app/notification/service/notification_service.js I think | 17:32 |
| krotscheck | It’s supposed to add global interceptors that remain persistent | 17:32 |
| yolanda | i put logs there and it's not actively consuming messages | 17:33 |
| krotscheck | If those are getting removed, that’s a problem. | 17:33 |
| yolanda | i raise an error for example in project groups, a dupe one | 17:33 |
| *** jtomasek has quit IRC | 17:33 | |
| yolanda | i can see error is published by the broadcaster | 17:33 |
| yolanda | but doesn't arrive to the notification service | 17:33 |
| krotscheck | Interesting | 17:34 |
| krotscheck | So, the message interception lives in the notification_controller, loaded by the notifications directive. | 17:35 |
| krotscheck | Wait a sec, did something merge recently? | 17:36 |
| yolanda | i approved a pair of changes today, the ones about the abort | 17:36 |
| krotscheck | Hrm. | 17:36 |
| krotscheck | Ok. | 17:36 |
| yolanda | <openstackgerrit> Merged openstack-infra/storyboard: Fix NotFound errors https://review.openstack.org/152137 | 17:36 |
| yolanda | <openstackgerrit> Merged openstack-infra/storyboard: Fix status code on delete https://review.openstack.org/151603 | 17:36 |
| krotscheck | Did it break login? | 17:36 |
| yolanda | i'm logged | 17:37 |
| yolanda | let me logout/login | 17:37 |
| yolanda | it's fine for me | 17:37 |
| krotscheck | Cool | 17:38 |
| krotscheck | I just want to make sure things don’t break. | 17:38 |
| *** ssam2 has quit IRC | 17:38 | |
| yolanda | mm, i commented that bit on the code | 17:44 |
| yolanda | // Iterate through the interceptors. | 17:44 |
| yolanda | if (!!interceptors[i].method(n)) { | 17:44 |
| yolanda | return; | 17:44 |
| yolanda | } | 17:44 |
| yolanda | }*/ | 17:44 |
| yolanda | and show alerts appearing for first time | 17:44 |
| yolanda | so there may be something odd there | 17:45 |
| yolanda | mm, i can see it | 17:51 |
| yolanda | method is something lke | 17:51 |
| yolanda | if (message.type === 'http') { | 17:52 |
| yolanda | if (message.message === 401) { | 17:52 |
| yolanda | // An unauthorized error. Refreshing the access token | 17:52 |
| yolanda | // might help. | 17:52 |
| yolanda | handle_401(); | 17:52 |
| yolanda | } | 17:52 |
| yolanda | if (message.message === 403) { | 17:52 |
| yolanda | // Forbidden error. A user should be warned tha he is | 17:52 |
| yolanda | // doing something wrong. | 17:52 |
| yolanda | handle_403(); | 17:52 |
| yolanda | } | 17:52 |
| yolanda | return true; // Stop processing this notifications. | 17:52 |
| yolanda | our error code is 400 | 17:52 |
| yolanda | so just ignored | 17:52 |
| yolanda | we need to properly handle 400 errors on that list, or any other error codes that may come | 17:52 |
| krotscheck | Hrm. | 17:53 |
| * krotscheck doesn’t have enough of that code in memory yet. | 17:53 | |
| yolanda | weird for me is that this code is on auth/notification/auth_error_handling.js | 17:53 |
| yolanda | and no auth related | 17:53 |
| yolanda | i think new interceptors need to be added | 17:54 |
| *** coolsvap_ is now known as coolsvap | 17:57 | |
| yolanda | i'll continue with that, looks as now i'm on the way... | 17:58 |
| krotscheck | kk | 17:59 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added functional tests for the OAuth Endpoint https://review.openstack.org/152752 | 18:14 |
| *** coolsvap is now known as coolsvap_ | 18:20 | |
| *** alexismonville has joined #storyboard | 18:22 | |
| *** alexismonville has quit IRC | 18:30 | |
| *** frvge has joined #storyboard | 18:45 | |
| frvge | Hi all, I'm trying to link Ubuntu One to Storyboard, but I always get a 500 error so I'm unable to use Storyboard. The error message unfortunately isn't very helpful :( | 18:45 |
| krotscheck | frvge: We’ve got a similar report from a different user, who disabled the various data requests that storyboard depends on. Did you uncheck name/email on ubuntu one perhaps? | 18:46 |
| frvge | I'll have a look. It was the first time I also used Ubuntu One. | 18:47 |
| krotscheck | frvge: Unlikely then. | 18:47 |
| frvge | Both are checked. | 18:48 |
| krotscheck | frvge: At the moment, we still have some holes in how the data we get back from Ubuntu One is handled. Empty values, or ones with odd characters, tend to blow up. | 18:48 |
| frvge | My surname contains a space. | 18:48 |
| krotscheck | frvge: both? There should be three: Full name, username, email address. | 18:48 |
| krotscheck | That might be the problem :) | 18:49 |
| frvge | The site has requested some personal information, please choose what you would like to share: Full name: Frank van Gemeren Email address: xxxxx@gmail.com Yes, log me in or cancel | 18:49 |
| krotscheck | Huhn. | 18:50 |
| frvge | Maybe something messed up. I can try to remove my account from Ubuntu One | 18:50 |
| krotscheck | frvge: Let me do a bit of research, back in 10 | 18:50 |
| frvge | THanks. It's way past end of business day here, so I'm off here. :) I just re-registered with just "Frank" as name, and it's still failing for me. | 18:52 |
| krotscheck | frvge: Yeah, there’s a missing field from the request, and I’m trying to figure out where that can be set. | 18:53 |
| krotscheck | frvge: I’m afraid it may have been deprecated. | 18:53 |
| frvge | krotscheck: ok. If you could look into it, that'd be much appreciated. | 18:54 |
| krotscheck | frvge: Would you mind logging into launchpad to see if you can set it there? | 18:54 |
| krotscheck | https://launchpad.net/ | 18:54 |
| krotscheck | frvge: It should be the ‘launchpad id' | 18:55 |
| frvge | krotscheck: pinkywithabrain | 18:55 |
| krotscheck | Cool | 18:56 |
| frvge | ** | 18:56 |
| frvge | ^^ :) | 18:56 |
| krotscheck | frvge: So if you go to https://launchpad.net/~pinkywithabrain/+edit you can see it in the ‘name’ field? | 18:57 |
| frvge | kortscheck: correct. | 18:58 |
| krotscheck | Good. Can you log into storyboard again and see if it asks for three fields now? | 18:58 |
| krotscheck | If not, then I have to do some fast patching. | 18:58 |
| frvge | krotscheck: works :) thanks | 18:59 |
| krotscheck | frvge: You’re welcome! | 19:00 |
| krotscheck | frvge: Filed https://storyboard.openstack.org/#!/story/2000152 for future improvements. | 19:09 |
| frvge | krotscheck: Thank you. | 19:15 |
| *** frvge has quit IRC | 19:16 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added functional tests for the OAuth Endpoint https://review.openstack.org/152752 | 19:53 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added functional tests for the OAuth Endpoint https://review.openstack.org/152752 | 19:55 |
| krotscheck | rcarrillocruz: I had to add some test cases to the OAuth tests due to the errors that came up in the channel earlier today. | 19:55 |
| krotscheck | Also, the actual error checks were wrong. | 19:55 |
| rcarrillocruz | k, i haven't been able to look at it yet anyway, this week I'm oncall and having fun with tickets and issues | 19:58 |
| rcarrillocruz | krotscheck: your amendment to my change re: notificationhook got a -1 from Jenkins, needing a rebase | 19:58 |
| rcarrillocruz | just a FYI in case you didn't see | 19:58 |
| krotscheck | rcarrillocruz: That’s what I’m working on right now. | 19:59 |
| krotscheck | rcarrillocruz: Gotcah | 19:59 |
| rcarrillocruz | cool | 19:59 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Explicit Hook Priorities https://review.openstack.org/152253 | 20:00 |
| *** mattfarina has quit IRC | 20:24 | |
| *** cody-somerville has joined #storyboard | 20:24 | |
| *** mattfarina has joined #storyboard | 20:58 | |
| *** mattfarina has quit IRC | 20:58 | |
| *** mrmartin has quit IRC | 21:15 | |
| *** mrmartin has joined #storyboard | 21:17 | |
| *** mrmartin has quit IRC | 21:22 | |
| *** Piet has quit IRC | 21:33 | |
| *** alexismonville has joined #storyboard | 21:52 | |
| *** alexismonville has quit IRC | 22:18 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: OAuth Functional Tests https://review.openstack.org/153068 | 22:22 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added OAuth check for response_type 'code' https://review.openstack.org/153069 | 22:22 |
| krotscheck | If anyone has pointers on ^^ to figure out how to properly recast the exception into the right kind of response, I’d be muchly appreciative :) | 22:32 |
| *** mattfarina has joined #storyboard | 22:44 | |
| *** alexismonville has joined #storyboard | 22:59 | |
| *** mattfarina has quit IRC | 23:04 | |
| *** reed has quit IRC | 23:24 | |
| *** alexismonville has quit IRC | 23:25 | |
| *** alexismonville1 has joined #storyboard | 23:25 | |
| *** alexismonville has joined #storyboard | 23:45 | |
| *** alexismonville1 has quit IRC | 23:45 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!