| *** cody-somerville has quit IRC | 00:02 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Revert "Delete created_at and updated_at fields from requests" https://review.openstack.org/152353 | 00:07 |
|---|---|---|
| krotscheck | aripinen_: ^^ Had to revert your patch, it broke login. | 00:08 |
| krotscheck | We really need to get functional tests around Oauth. | 00:08 |
| krotscheck | NikitaKonovalov, yolanda, aripinen_, rcarrillocruz: Anyone want to volunteer to write tests for our oauth endpoints? :) | 00:09 |
| krotscheck | This is the second time in as many weeks (i think, it might have been 2 weeks ago) that a patch broke login. More coverage will surface these things, and writing functional tests for our Oauth endpoints is actually not that difficult with mocks. | 00:12 |
| krotscheck | So for the time being let’s assume I’m -2’ing any API patch until we have coverage on /oauth/ | 00:12 |
| krotscheck | I’ll jump on this in the morning if nobody else picks it up. | 00:12 |
| krotscheck | gforcada_: That patch has been approved, storyboard should be back and working in at most 30 mintues | 00:14 |
| gforcada_ | krotscheck: wow that's cool, thanks a lot! | 00:14 |
| krotscheck | gforcada_: You’re welcome! | 00:16 |
| *** gforcada_ has quit IRC | 00:19 | |
| openstackgerrit | Merged openstack-infra/storyboard: Revert "Delete created_at and updated_at fields from requests" https://review.openstack.org/152353 | 00:26 |
| *** mase_x200 has quit IRC | 01:44 | |
| *** alexismonville has joined #storyboard | 04:23 | |
| *** alexismonville has quit IRC | 04:32 | |
| *** coolsvap|afk is now known as coolsvap | 04:42 | |
| *** mrmartin has joined #storyboard | 06:16 | |
| yolanda | krotscheck, i'll try to find a gap | 07:14 |
| *** jtomasek has joined #storyboard | 07:55 | |
| *** gforcada has joined #storyboard | 08:24 | |
| *** gforcada is now known as gforcada_ | 08:24 | |
| *** CTtpollard has joined #storyboard | 08:28 | |
| *** jcoufal has joined #storyboard | 08:35 | |
| *** MaxV has joined #storyboard | 08:40 | |
| *** alexismonville has joined #storyboard | 08:43 | |
| *** MaxV has quit IRC | 08:47 | |
| *** MaxV has joined #storyboard | 08:49 | |
| *** alexismonville has quit IRC | 08:52 | |
| *** CTtpollard has quit IRC | 09:27 | |
| *** CTtpollard has joined #storyboard | 09:27 | |
| *** CTtpollard has quit IRC | 09:27 | |
| *** CTtpollard has joined #storyboard | 09:27 | |
| *** jedimike has joined #storyboard | 09:39 | |
| *** yolanda has quit IRC | 09:40 | |
| *** gforcada has joined #storyboard | 09:50 | |
| *** jtomasek has quit IRC | 09:52 | |
| *** gforcada_ has quit IRC | 09:52 | |
| *** alexismonville has joined #storyboard | 09:56 | |
| *** ssam2 has joined #storyboard | 10:00 | |
| *** alexismonville has quit IRC | 10:02 | |
| *** mrmartin has quit IRC | 10:04 | |
| *** alexismonville has joined #storyboard | 10:04 | |
| *** jtomasek has joined #storyboard | 10:05 | |
| *** mrmartin has joined #storyboard | 10:09 | |
| *** alexismonville has quit IRC | 10:20 | |
| *** yolanda has joined #storyboard | 10:21 | |
| yolanda | krotscheck, NikitaKonovalov, so looks as i don't have time for tests, feel free to assign yourselves, sorry | 10:21 |
| * CTtpollard returns from FOSDEM | 10:22 | |
| *** alexismonville has joined #storyboard | 11:04 | |
| *** alexismonville has quit IRC | 11:05 | |
| *** jcoufal_ has joined #storyboard | 11:29 | |
| *** jcoufal has quit IRC | 11:32 | |
| *** jcoufal_ has quit IRC | 11:34 | |
| *** jcoufal has joined #storyboard | 11:59 | |
| *** jcoufal has quit IRC | 12:23 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added branches to storyboard https://review.openstack.org/150447 | 12:27 |
| *** jcoufal has joined #storyboard | 12:28 | |
| *** alexismonville has joined #storyboard | 12:31 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added milestones https://review.openstack.org/152500 | 12:47 |
| *** alexismonville has quit IRC | 13:00 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added milestones https://review.openstack.org/152500 | 13:06 |
| *** alexismonville has joined #storyboard | 13:06 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added milestones https://review.openstack.org/152500 | 13:12 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added branches to storyboard https://review.openstack.org/150447 | 13:14 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added milestones https://review.openstack.org/152500 | 13:39 |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: User abort call instead of returning response https://review.openstack.org/152515 | 13:48 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added milestones https://review.openstack.org/152500 | 13:51 |
| *** mattfarina has joined #storyboard | 14:55 | |
| *** mattfarina has quit IRC | 14:58 | |
| *** mattfarina has joined #storyboard | 15:01 | |
| *** coolsvap is now known as coolsvap|afk | 15:01 | |
| *** mattfarina has quit IRC | 15:11 | |
| *** mattfarina has joined #storyboard | 15:20 | |
| *** mattfarina has quit IRC | 15:28 | |
| *** jtomasek has quit IRC | 15:33 | |
| *** jtomasek has joined #storyboard | 15:42 | |
| *** coolsvap|afk is now known as coolsvap | 15:46 | |
| *** CTtpollard has quit IRC | 15:49 | |
| *** coolsvap is now known as coolsvap_ | 15:50 | |
| *** CTtpollard has joined #storyboard | 15:51 | |
| *** coolsvap_ is now known as coolsvap|afk | 15:52 | |
| *** coolsvap|afk is now known as swapnilkulkarni | 15:54 | |
| *** swapnilkulkarni is now known as swapnil | 15:54 | |
| *** swapnil is now known as swapnilk | 15:54 | |
| *** jtomasek has quit IRC | 15:59 | |
| *** alexismonville has quit IRC | 15:59 | |
| *** jtomasek has joined #storyboard | 16:04 | |
| *** alexismonville has joined #storyboard | 16:33 | |
| *** alexismonville has quit IRC | 16:34 | |
| *** mattfarina has joined #storyboard | 17:07 | |
| *** MaxV has quit IRC | 17:11 | |
| *** alexismonville has joined #storyboard | 17:13 | |
| *** MaxV has joined #storyboard | 17:14 | |
| *** MaxV has quit IRC | 17:19 | |
| *** mattfarina has quit IRC | 17:34 | |
| *** jcoufal has quit IRC | 17:44 | |
| *** ssam2 has quit IRC | 17:50 | |
| *** alexismonville has quit IRC | 17:53 | |
| *** jtomasek has quit IRC | 18:12 | |
| *** mrmartin has quit IRC | 18:38 | |
| *** mrmartin has joined #storyboard | 18:40 | |
| *** jedimike has quit IRC | 19:05 | |
| *** yolanda has quit IRC | 19:10 | |
| *** swapnilk is now known as coolsvap_ | 19:15 | |
| *** coolsvap_ is now known as coolsvap | 19:19 | |
| *** gforcada has quit IRC | 19:27 | |
| *** yolanda has joined #storyboard | 19:35 | |
| *** coolsvap is now known as coolsvap_ | 19:41 | |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard-webclient: Fix in project groups validation https://review.openstack.org/152133 | 19:48 |
| *** mattfarina has joined #storyboard | 19:51 | |
| *** mattfarina has quit IRC | 19:53 | |
| yolanda | hi krotscheck, you there? | 20:06 |
| krotscheck | Nope | 20:06 |
| krotscheck | I am a turing machine | 20:06 |
| yolanda | ah, then, bye :) | 20:06 |
| krotscheck | :) | 20:07 |
| * krotscheck is working on OAuth tests. | 20:07 | |
| yolanda | so no time today for the oauth tests, are you on it? if not i can pick them tomorrow | 20:07 |
| yolanda | ok | 20:07 |
| yolanda | have said nothing :) | 20:07 |
| krotscheck | If I don’t finish them today you can pick up my patch in the morning :) | 20:07 |
| yolanda | ok, just ping me with something in the channel and i'll read | 20:08 |
| yolanda | i'm just resending fixes on patches, had no time for nothing today | 20:09 |
| yolanda | i amended the testing spec a bit, with your comments | 20:09 |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard: Prevent duplicate register_options call https://review.openstack.org/151630 | 20:11 |
| *** anteaya has quit IRC | 20:34 | |
| *** openstackgerrit has quit IRC | 20:50 | |
| *** openstackgerrit has joined #storyboard | 20:51 | |
| *** anteaya has joined #storyboard | 20:53 | |
| krotscheck | The problem with writing tests is that you discover that the service is broken. | 21:06 |
| *** mrmartin has quit IRC | 21:25 | |
| *** alexismonville has joined #storyboard | 22:30 | |
| *** cody-somerville has joined #storyboard | 22:35 | |
| *** Piet has joined #storyboard | 22:42 | |
| *** alexismonville has quit IRC | 23:34 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!