| mordred | jeblair: I agree with you - SergeyLukjanov said he preferred keeping sqlite support because it's easier for him to run locally | 00:25 |
|---|---|---|
| mordred | but I would vote for ditching the sqlite support altogether | 00:25 |
| mordred | jeblair: I took a stab at doing that last weekend - got frustrated and quit | 00:27 |
| mordred | jeblair: I'll try again | 00:27 |
| krotscheck | jeblair: if mordred throws in the towel I can take a swing at it too as soon as I get pagination working in the UI | 00:48 |
| jeblair | yeah, i'm normally sympathetic to being able to run things locally, but sqlalchemy migrations don't actually help us test anything we care about, and make it hard to test the thing we do care about. i think we should drop them. | 00:49 |
| krotscheck | I think we're actually using alembic for migrations, no? | 00:50 |
| mordred | yeah. alembic for the migrations - I think he's saying, if we can't test them as we're using them - then they're a bunch of effort for not much gain | 00:58 |
| mordred | whcih I think is a bug in the test suite infrastructure | 00:58 |
| *** openstack has joined #storyboard | 01:05 | |
| *** krotscheck has quit IRC | 01:19 | |
| *** tteggel has quit IRC | 01:22 | |
| *** tteggel has joined #storyboard | 01:23 | |
| *** david-lyle has joined #storyboard | 03:09 | |
| *** saju_m has joined #storyboard | 06:52 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard: Rename migration revisions https://review.openstack.org/79869 | 07:40 |
| *** jcoufal has joined #storyboard | 07:59 | |
| *** saju_m has quit IRC | 08:41 | |
| *** hashar has joined #storyboard | 08:41 | |
| *** saju_m has joined #storyboard | 09:09 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard: Fill the last_login field https://review.openstack.org/79887 | 09:18 |
| *** jcoufal has quit IRC | 09:20 | |
| *** jcoufal has joined #storyboard | 09:22 | |
| *** hashar has quit IRC | 09:58 | |
| *** hashar has joined #storyboard | 10:10 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard: Missing security decorators added https://review.openstack.org/79895 | 10:18 |
| *** saju_m has quit IRC | 10:49 | |
| *** hashar has quit IRC | 11:20 | |
| *** ChanServ changes topic to "test/gate jobs are queuing now in preparation for gerrit maintenance at 12:00 utc (eta to resume is 12:30 utc)" | 11:28 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard: Missing security decorators added https://review.openstack.org/79895 | 11:52 |
| *** ChanServ changes topic to "gerrit on review.openstack.org is down for maintenance (eta to resume is 12:30 utc)" | 12:07 | |
| *** david-lyle has quit IRC | 12:24 | |
| *** ChanServ changes topic to "gerrit on review.openstack.org is down for maintenance (revised eta to resume is 13:00 utc)" | 12:24 | |
| *** saju_m has joined #storyboard | 12:37 | |
| *** hashar has joined #storyboard | 12:46 | |
| *** openstackgerrit has quit IRC | 12:54 | |
| *** openstackgerrit has joined #storyboard | 12:54 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard-webclient: Hide "Create Project" for non-superusers https://review.openstack.org/79939 | 13:05 |
| *** openstackgerrit has quit IRC | 13:08 | |
| *** openstackgerrit has joined #storyboard | 13:08 | |
| *** openstack has joined #storyboard | 14:04 | |
| *** mfer has joined #storyboard | 14:17 | |
| *** krotscheck has joined #storyboard | 14:26 | |
| *** david-lyle has joined #storyboard | 14:30 | |
| *** ChanServ changes topic to "Storyboard | http://git.openstack.org/cgit/openstack-infra/storyboard/ | Weekly Meeting: Thursdays at 16:00 UTC in #openstack-meeting" | 14:42 | |
| *** saju_m has quit IRC | 15:03 | |
| *** saju_m has joined #storyboard | 15:04 | |
| *** krotscheck has quit IRC | 15:06 | |
| *** mfer has quit IRC | 15:07 | |
| *** miqui has joined #storyboard | 15:19 | |
| *** mfer has joined #storyboard | 15:38 | |
| *** saju_m has quit IRC | 15:40 | |
| *** che-arne has joined #storyboard | 15:58 | |
| *** krotscheck has joined #storyboard | 16:54 | |
| krotscheck | ruhe, NikitaKonovalov: That renaming change on the migrations - I like it, how's that going to impact our servers? | 16:55 |
| *** cody-somerville has quit IRC | 16:58 | |
| NikitaKonovalov | well, the current db state is kept in alembic_versioin table | 16:59 |
| *** cody-somerville has joined #storyboard | 16:59 | |
| *** cody-somerville has joined #storyboard | 16:59 | |
| NikitaKonovalov | so if we change it manually somehow from a hash to a 005 it shoul work | 16:59 |
| krotscheck | Well, given that the migrations are currently completely borked, it might be the right time to do this. | 17:00 |
| krotscheck | speaking of which.... | 17:00 |
| krotscheck | mordred, any progress on your commit that broke storyboard? | 17:00 |
| krotscheck | NikitaKonovalov: In the meantime, can I get a critique of this: https://etherpad.openstack.org/p/StoryboardPerms | 17:02 |
| *** cody-somerville has quit IRC | 17:03 | |
| *** cody-somerville_ has joined #storyboard | 17:03 | |
| *** cody-somerville_ has quit IRC | 17:03 | |
| *** cody-somerville_ has joined #storyboard | 17:03 | |
| *** saju_m has joined #storyboard | 17:16 | |
| *** jcoufal has quit IRC | 17:31 | |
| *** openstackstatus has quit IRC | 17:38 | |
| *** openstackstatus has joined #storyboard | 17:39 | |
| openstackgerrit | A change was merged to openstack-infra/storyboard: Rename migration revisions https://review.openstack.org/79869 | 17:54 |
| *** hashar has quit IRC | 17:54 | |
| krotscheck | ALright, everyone, get to rebasing your changes :) | 17:59 |
| krotscheck | Also, high priority story for everyone: http://storyboard.openstack.org/#!/story/29/overview | 18:08 |
| krotscheck | Since we don't have priorities yet. | 18:08 |
| krotscheck | And holy shit do we need paging - mordred just ran the project import script. | 18:08 |
| mordred | krotscheck: search doesn't work | 18:09 |
| mordred | on the project page | 18:09 |
| krotscheck | mordred: Search wasn't MVP | 18:09 |
| krotscheck | I can pull the search box. | 18:09 |
| krotscheck | It's literally not connected to anything right now. | 18:09 |
| ruhe | krotscheck: http://storyboard.openstack.org/#!/story/29/overview i can take a stab at this at the weekend | 18:26 |
| ruhe | i should apologise for my inactivity recently. i've been pulled out to pull out another project | 18:27 |
| *** saju_m has quit IRC | 18:30 | |
| *** cody-somerville_ is now known as cody-somerville | 18:39 | |
| krotscheck | AFK, everyone, lunch. HOpefully I'll have znc up and running after lunch so I can get scrollback. | 18:43 |
| *** krotscheck has quit IRC | 18:43 | |
| ruhe | here is an idea how to fix sqlite problem: | 18:57 |
| ruhe | 1. explicitly disable everything related to sqlite in migration tests | 18:58 |
| ruhe | 2. in all other unit tests populate DB (which would still be sqlite) from SQLA metadata | 18:58 |
| ruhe | 3. use https://review.openstack.org/#/c/74081/ to make sure that our model is in sync with migrations (only on MySQL and Postgres) | 18:59 |
| ruhe | mordred: what do you think? ^^ | 19:00 |
| *** krotscheck has joined #storyboard | 19:25 | |
| * krotscheck peers suspiciously at his ZNC server. | 19:25 | |
| krotscheck | ooooOOOOoooo | 19:27 |
| krotscheck | Buffer playback! | 19:27 |
| krotscheck | Neat! | 19:28 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Go back to alembic migrations https://review.openstack.org/79208 | 19:42 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Missing security decorators added https://review.openstack.org/79895 | 19:44 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Fill the last_login field https://review.openstack.org/79887 | 19:44 |
| ruhe | krotscheck: what do you think of my idea to resolve sqlite problem? | 19:45 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Logging in with a pre-existing user saves details https://review.openstack.org/79705 | 19:46 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Added paging to list endpoints https://review.openstack.org/79757 | 19:47 |
| krotscheck | ruhe: Was that in scrollback? | 19:48 |
| ruhe | yes | 19:48 |
| ruhe | i'll copy it | 19:48 |
| ruhe | here is an idea how to fix sqlite problem: | 19:48 |
| ruhe | 1. explicitly disable everything related to sqlite in migration tests | 19:48 |
| ruhe | 2. in all other unit tests populate DB (which would still be sqlite) from SQLA metadata | 19:49 |
| ruhe | 3. use https://review.openstack.org/#/c/74081/ to make sure that our model is in sync with migrations (only on MySQL and Postgres) | 19:49 |
| krotscheck | Hrm, that looks good. | 19:49 |
| krotscheck | So, I like 3. | 19:50 |
| krotscheck | And I like 1 | 19:50 |
| krotscheck | But I think that 2 should be "Fuck you, install a database" | 19:50 |
| krotscheck | We're only going to test what we actually use. Adding a ton of extra edge case code just for our unit tests, when all they're really testing is integration with a database that we don't want anyone using in production,.... | 19:51 |
| krotscheck | ...well, seems like a lot of extra effort for no real benefit. | 19:52 |
| krotscheck | If at some point oslo starts supporting SQLite, fine. | 19:52 |
| krotscheck | But I don't want to maintain that. | 19:52 |
| ruhe | krotscheck: well, since most (or all) developers are here and i haven't seen much of resistance towards getting rid of sqlite., i think that your approach is the best | 19:52 |
| krotscheck | Nuke it from orbit! | 19:53 |
| krotscheck | :) | 19:53 |
| krotscheck | AFK, need to go interview Andrew :) | 19:53 |
| ruhe | could you please ask him to check out his skype? | 19:54 |
| mordred | krotscheck: nuke all the things | 20:25 |
| ruhe | re: drop sqlite. on the other hand - we will have to generate database with a random name for each test | 20:29 |
| *** che-arne has quit IRC | 20:30 | |
| ruhe | i know ceilometer folks are trying to do the same thing, but it seems like there are other potential issues: | 20:36 |
| ruhe | https://review.openstack.org/#/c/59489/ | 20:36 |
| ruhe | https://review.openstack.org/#/c/63049/ | 20:36 |
| krotscheck | Willdo | 21:03 |
| krotscheck | ruhe: Willdo | 21:03 |
| *** mfer has quit IRC | 21:20 | |
| *** cody-somerville- has joined #storyboard | 21:26 | |
| openstackgerrit | A change was merged to openstack-infra/storyboard: Fill the last_login field https://review.openstack.org/79887 | 21:29 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Logging in with a pre-existing user saves details https://review.openstack.org/79705 | 21:42 |
| openstackgerrit | A change was merged to openstack-infra/storyboard: Missing security decorators added https://review.openstack.org/79895 | 21:47 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Logging in with a pre-existing user saves details https://review.openstack.org/79705 | 21:47 |
| ruhe | krotscheck: did znc return my comments about problems we might have when we drop sqlite completely? :) | 22:45 |
| *** david_lyle_ has joined #storyboard | 23:39 | |
| *** david-lyle has quit IRC | 23:41 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!