| *** krotscheck has quit IRC | 03:19 | |
| *** david-lyle has joined #storyboard | 04:08 | |
| *** krotscheck has joined #storyboard | 04:15 | |
| *** krotscheck has quit IRC | 04:52 | |
| *** krotscheck has joined #storyboard | 04:57 | |
| *** krotscheck has quit IRC | 06:00 | |
| *** jcoufal has joined #storyboard | 08:24 | |
| *** jcoufal has quit IRC | 09:00 | |
| *** jcoufal_ has joined #storyboard | 09:00 | |
| *** jcoufal_ has quit IRC | 09:02 | |
| *** hashar has joined #storyboard | 09:09 | |
| *** jcoufal has joined #storyboard | 09:15 | |
| *** saju_m has joined #storyboard | 10:05 | |
| *** saju_m has quit IRC | 10:18 | |
| *** saju_m has joined #storyboard | 10:30 | |
| *** saju_m has quit IRC | 10:54 | |
| *** hashar has quit IRC | 11:17 | |
| *** hashar has joined #storyboard | 11:19 | |
| *** hashar has quit IRC | 11:57 | |
| *** david-lyle has quit IRC | 12:21 | |
| *** miqui has quit IRC | 12:29 | |
| *** hashar has joined #storyboard | 13:14 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard: Only public user fields in unauthorized requests https://review.openstack.org/78586 | 13:24 |
|---|---|---|
| *** mfer has joined #storyboard | 13:37 | |
| *** jcoufal has quit IRC | 13:50 | |
| *** david-lyle has joined #storyboard | 14:26 | |
| *** krotscheck has joined #storyboard | 14:29 | |
| *** jcoufal has joined #storyboard | 14:40 | |
| *** jcoufal has quit IRC | 15:06 | |
| *** jcoufal has joined #storyboard | 15:07 | |
| *** jcoufal has quit IRC | 15:12 | |
| *** jcoufal has joined #storyboard | 15:13 | |
| *** jcoufal has quit IRC | 15:25 | |
| *** miqui has joined #storyboard | 15:33 | |
| *** krotscheck has quit IRC | 15:41 | |
| openstackgerrit | A change was merged to openstack-infra/storyboard-webclient: Creating a new story now requires authentication. https://review.openstack.org/79390 | 15:50 |
| openstackgerrit | A change was merged to openstack-infra/storyboard-webclient: Fixed padding on modals. https://review.openstack.org/79393 | 15:50 |
| openstackgerrit | A change was merged to openstack-infra/storyboard-webclient: Clean-up the address-bar after auth https://review.openstack.org/78953 | 15:50 |
| openstackgerrit | A change was merged to openstack-infra/storyboard-webclient: Added UI switches for authentication state. https://review.openstack.org/79478 | 15:50 |
| openstackgerrit | A change was merged to openstack-infra/storyboard: Only public user fields in unauthorized requests https://review.openstack.org/78586 | 15:51 |
| *** jcoufal has joined #storyboard | 16:00 | |
| *** krotscheck has joined #storyboard | 16:41 | |
| krotscheck | mordred: When you get a chance can you poke around the s.o.o database and see what's going on in the projects table? My migration seems to have not done anything, and I'm curious as to whether the database was recreated. | 16:56 |
| krotscheck | mordred: I'm pretty certain it hasn't been wiped though - I'm still running into the unique name constraint. | 16:57 |
| *** david-lyle has quit IRC | 17:01 | |
| mordred | krotscheck: the migrations are blocked on s.o.o | 17:01 |
| mordred | krotscheck: because the description migration does not work | 17:01 |
| krotscheck | mordred: Ah, gotcha | 17:02 |
| mordred | NikitaKonovalov, SergeyLukjanov ^^ we could really use some help on this | 17:02 |
| *** jcoufal has quit IRC | 17:04 | |
| krotscheck | mordred: Does it look like you'll have time to look at this? | 17:07 |
| mordred | no, I do not | 17:10 |
| mordred | sorry | 17:10 |
| mordred | this has to be a solved problem somewhere | 17:10 |
| mordred | krotscheck: I'm going to keep pinging people until I find someone who knows what's up | 17:15 |
| mordred | krotscheck: I _believe_ this should be accoutned for in all of that new oslo. code that you synced | 17:16 |
| krotscheck | mordred: Well, I si=ynced a lot of it, but I won't admit to fully grokking how all those opportunistic tests are supposed to be set up. | 17:17 |
| krotscheck | Honestly, it's probably my fault. | 17:17 |
| mordred | I'm _sure_ that it's not | 17:18 |
| krotscheck | ...oh? | 17:18 |
| krotscheck | Well, that's a relief. | 17:18 |
| *** miqui has quit IRC | 17:21 | |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Logging in with a pre-existing user saves details https://review.openstack.org/79705 | 17:45 |
| NikitaKonovalov | I have no idea why, but after running migrations in master I found that all projects and stories had is_active NULL indatabase | 17:46 |
| *** hashar has quit IRC | 17:48 | |
| krotscheck | NikitaKonovalov: I was working on that the other day, and I'm stumped too. I was able to get the migrations on mysql to work properly by setting server_default. | 17:49 |
| *** mfer has quit IRC | 17:50 | |
| krotscheck | NikitaKonovalov: mordred's working on trying to get an alter_table statement to work properly. | 17:50 |
| krotscheck | NikitaKonovalov: Could it be that the new oslo code makes the migration_patch unecessary? | 17:51 |
| NikitaKonovalov | I'll have a look | 17:52 |
| krotscheck | NikitaKonovalov: https://review.openstack.org/#/c/79208 | 17:52 |
| NikitaKonovalov | but AFAIK the new oslo stuff is about session management, not hacking the engine's behaviour | 17:52 |
| NikitaKonovalov | the migration_pathch is making drop_column work with sqlite | 17:54 |
| krotscheck | NikitaKonovalov: That's what I figured. | 17:55 |
| NikitaKonovalov | and we will have to maintain some hacks in oslo or in our code utill sqlite itself support drops correctly | 17:55 |
| krotscheck | NikitaKonovalov: I wonder if that patch should get moved to oslo anyway... | 17:55 |
| krotscheck | NikitaKonovalov: Oh, it's already in? | 17:55 |
| *** david-lyle has joined #storyboard | 17:56 | |
| NikitaKonovalov | I have not found any mentions of drop_column there | 18:01 |
| mordred | NikitaKonovalov: so - the new migration we're having problems with is an alter column | 18:05 |
| mordred | which sqlite also doesn't do | 18:05 |
| mordred | so we made a hack in the migration to make it pass unit tests - but THAT doesn't work on mysql | 18:05 |
| mordred | https://review.openstack.org/#/c/79208/ | 18:05 |
| mordred | that ^^ is what the migration should look like -and works on mysql - but does not work in the unittest | 18:06 |
| *** mfer has joined #storyboard | 18:06 | |
| mordred | so - if we can get the unittest suite happy with that migration in that patch, then we'll be good | 18:06 |
| krotscheck | I don't suppose anyone has an example of a migration that includes an INSERT? | 18:10 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Replaced first_name and last_name with full_name. https://review.openstack.org/79720 | 18:34 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Consume full_name rather than first_name and last_name https://review.openstack.org/79723 | 18:38 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Replaced first_name and last_name with full_name. https://review.openstack.org/79720 | 19:05 |
| * krotscheck nukes sqllite from orbit | 19:05 | |
| *** imagin has joined #storyboard | 19:16 | |
| *** imagin has quit IRC | 19:24 | |
| *** nastyansk has joined #storyboard | 19:30 | |
| *** nastyansk has quit IRC | 19:42 | |
| *** hashar has joined #storyboard | 20:17 | |
| *** elesan has joined #storyboard | 20:30 | |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Added paging to list endpoints https://review.openstack.org/79757 | 20:37 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Added paging to list endpoints https://review.openstack.org/79757 | 20:39 |
| *** elesan has quit IRC | 20:42 | |
| krotscheck | Anyone here and interested in discussing API design? | 20:54 |
| krotscheck | I'm building on the paging commit I just added, and hit a snag when implementing it in angular | 20:54 |
| krotscheck | ...actually, I may be lying. | 20:55 |
| krotscheck | Just a sec. | 20:55 |
| krotscheck | Yup, I'm lying. | 20:57 |
| krotscheck | Different question. What's the easiest way to get python to convert 0 to "0" rather than "None"? | 21:00 |
| krotscheck | Correction: Pecan seems to be converting non-set parameters to None, not accepting the defaults. | 21:06 |
| *** tteggel has quit IRC | 21:28 | |
| *** rainya has quit IRC | 21:28 | |
| *** SotK has quit IRC | 21:28 | |
| *** mfer has quit IRC | 21:28 | |
| *** david-lyle has quit IRC | 21:28 | |
| *** cody-somerville has quit IRC | 21:28 | |
| *** ilyashakhat has quit IRC | 21:28 | |
| *** hashar has quit IRC | 21:28 | |
| *** jeblair has quit IRC | 21:28 | |
| *** openstackgerrit has quit IRC | 21:28 | |
| *** NikitaKonovalov has quit IRC | 21:28 | |
| *** SergeyLukjanov has quit IRC | 21:28 | |
| *** ruhe has quit IRC | 21:28 | |
| *** gothicmindfood has quit IRC | 21:28 | |
| *** pleia2 has quit IRC | 21:28 | |
| *** lifeless has quit IRC | 21:28 | |
| *** jesusaurus has quit IRC | 21:28 | |
| *** mordred has quit IRC | 21:28 | |
| *** wendar has quit IRC | 21:29 | |
| *** ttx has quit IRC | 21:29 | |
| *** ChanServ has quit IRC | 21:29 | |
| *** zaro has quit IRC | 21:29 | |
| *** anteaya has quit IRC | 21:29 | |
| *** robtaylor has quit IRC | 21:29 | |
| *** krotscheck has quit IRC | 21:30 | |
| *** krotscheck has joined #storyboard | 21:32 | |
| *** krotscheck has quit IRC | 21:35 | |
| *** wendar has joined #storyboard | 21:41 | |
| *** tteggel has joined #storyboard | 21:41 | |
| *** ttx has joined #storyboard | 21:41 | |
| *** krotscheck_ has joined #storyboard | 21:41 | |
| *** hashar has joined #storyboard | 21:41 | |
| *** david-lyle has joined #storyboard | 21:41 | |
| *** cody-somerville has joined #storyboard | 21:41 | |
| *** jeblair has joined #storyboard | 21:41 | |
| *** openstackgerrit has joined #storyboard | 21:41 | |
| *** ilyashakhat has joined #storyboard | 21:41 | |
| *** NikitaKonovalov has joined #storyboard | 21:41 | |
| *** SergeyLukjanov has joined #storyboard | 21:41 | |
| *** ruhe has joined #storyboard | 21:41 | |
| *** zaro has joined #storyboard | 21:41 | |
| *** gothicmindfood has joined #storyboard | 21:41 | |
| *** pleia2 has joined #storyboard | 21:41 | |
| *** anteaya has joined #storyboard | 21:41 | |
| *** lifeless has joined #storyboard | 21:41 | |
| *** jesusaurus has joined #storyboard | 21:41 | |
| *** mordred has joined #storyboard | 21:41 | |
| *** robtaylor has joined #storyboard | 21:41 | |
| *** ChanServ has joined #storyboard | 21:41 | |
| *** dickson.freenode.net sets mode: +o ChanServ | 21:41 | |
| *** rainya has joined #storyboard | 21:41 | |
| *** krotscheck_ is now known as krotscheck | 21:42 | |
| *** SotK has joined #storyboard | 21:44 | |
| *** hashar has quit IRC | 22:01 | |
| *** openstackstatus has joined #storyboard | 22:44 | |
| *** che-arne has joined #storyboard | 22:58 | |
| *** david-lyle has quit IRC | 23:08 | |
| jeblair | krotscheck: didn't we used to have some stuff in the db? http://storyboard.openstack.org/#!/project/list | 23:16 |
| krotscheck | jeblair: | 23:17 |
| krotscheck | jeblair: We do | 23:17 |
| krotscheck | jeblair: mordred is arguing with alembic at the moment, we're having serious issues with database migrations and all the workarounds we have to do for postgres, mysql, sqlite. | 23:17 |
| krotscheck | jeblair: So while the migrations pass in jenkins, they're failing against mysql | 23:18 |
| jeblair | i'm sure you're familiar with some of this; but i think the ideal state would be that we only attempt to support what we test | 23:19 |
| jeblair | and that we test mysql in the gate | 23:19 |
| jeblair | and drop sqlite because it's not designed to be used anyway and makes life hard | 23:19 |
| krotscheck | jeblair: I would LOVE that. I am in no way clueful enough about how oslo and all that sqlalchemy magic works to rip those things out. | 23:20 |
| *** che-arne has quit IRC | 23:20 | |
| krotscheck | jeblair: mordred should probably fill you in on exactly why things there are not-good, I've been waving my hands and hoping he makes the problems go away. | 23:20 |
| jeblair | and mysql tests should probably use a test fixture that creates the db before each test; i think mordred and clarkb were working on that; i'm not certain of the current state | 23:20 |
| krotscheck | jeblair: They do. | 23:21 |
| krotscheck | I believe | 23:21 |
| jeblair | oh i thought mysql wasn't being tested | 23:21 |
| krotscheck | Hey man, i can only learn one thing at a time. Oslo was last week, and even that only gave me a cursory intro. | 23:22 |
| jeblair | there does seem to be a lot of code in there to test mysql | 23:25 |
| jeblair | it's not going to actually run because the username is not actually "openstack_cifail" | 23:25 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!