| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Storyboard API Interface and basic project management https://review.openstack.org/67582 | 01:31 |
|---|---|---|
| * gothicmindfood does the "go-krotscheck" dance | 01:32 | |
| *** gothicmindfood has quit IRC | 01:32 | |
| krotscheck | Eh? | 01:33 |
| krotscheck | What is this, congrats-and-quit? | 01:33 |
| krotscheck | srsly? | 01:33 |
| krotscheck | Yeeesh | 01:33 |
| *** krotscheck has quit IRC | 01:36 | |
| *** drdee has joined #storyboard | 01:59 | |
| *** taps has quit IRC | 02:11 | |
| *** miqui has quit IRC | 02:16 | |
| *** miqui has joined #storyboard | 02:28 | |
| *** drdee has quit IRC | 02:52 | |
| *** drdee has joined #storyboard | 02:53 | |
| *** drdee has quit IRC | 03:25 | |
| *** miqui has quit IRC | 03:52 | |
| *** miqui has joined #storyboard | 03:53 | |
| *** miqui has quit IRC | 04:29 | |
| openstackgerrit | A change was merged to openstack-infra/storyboard: Fixed doc build https://review.openstack.org/67376 | 04:59 |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 06:41 | |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 06:50 | |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 07:18 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 08:23 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack-infra/storyboard: API tests for rest https://review.openstack.org/67447 | 09:19 |
| *** SergeyLukjanov is now known as SergeyLukjanov_a | 09:27 | |
| *** SergeyLukjanov_a is now known as SergeyLukjanov_ | 09:28 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 09:40 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 09:47 | |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 09:47 | |
| *** jesusaurus has quit IRC | 10:35 | |
| *** jesusaurus has joined #storyboard | 10:37 | |
| *** drdee has joined #storyboard | 12:18 | |
| *** drdee has quit IRC | 13:02 | |
| *** miqui has joined #storyboard | 14:49 | |
| miqui | ..hello | 14:58 |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 15:33 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_a | 16:07 | |
| *** SergeyLukjanov_a is now known as SergeyLukjanov_ | 16:08 | |
| *** _ruhe is now known as ruhe | 16:20 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 16:28 | |
| *** taps has joined #storyboard | 16:58 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 17:10 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 17:18 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 17:28 | |
| *** gothicmindfood has joined #storyboard | 17:32 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 18:21 | |
| *** gothicmindfood has quit IRC | 18:31 | |
| *** krotscheck has joined #storyboard | 18:33 | |
| *** ruhe is now known as _ruhe | 18:39 | |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Add tests for Alembic migrations https://review.openstack.org/66414 | 18:55 |
| krotscheck | patchy patch | 18:57 |
| krotscheck | So, what is general openstack policy on how many +1's you need to get something approved? Is that a personal thing, or is there a set policy? | 19:00 |
| krotscheck | For instance: I have +2 on storyboard-core. Should I wait until at least one other person reviews something? | 19:01 |
| krotscheck | I'm not going to push my own code btw. | 19:01 |
| *** _ruhe is now known as ruhe | 19:01 | |
| ruhe | krotscheck: general rule is two have at least two +2 for a patch | 19:01 |
| krotscheck | ruhe: Got it. | 19:02 |
| krotscheck | That means we need at least one more +2 on the project, because mordred and ttx are super busy | 19:02 |
| krotscheck | ruhe: I just wish we could get some movement on some of these patches :/ | 19:03 |
| krotscheck | I don't want to start building features that are dependent on other patches which are dependent on other patches. Down that route lies madness. | 19:03 |
| ruhe | krotscheck: i don't see any problem when you approve a patch with only one +2 from you. as you said mordred and ttx are super busy. so it's the only way for now | 19:04 |
| krotscheck | ruhe: Fair point. | 19:04 |
| krotscheck | Let's keep our eyes open for other +2's though, preferably non-HP types. | 19:04 |
| * krotscheck may be dropping hints | 19:05 | |
| ruhe | :) | 19:05 |
| mordred | krotscheck: I do not believe you've failed everyone - I'm pretty sure that you've got a big blocker from infra being slammed right now | 19:06 |
| mordred | (reading old scrollback) | 19:06 |
| krotscheck | So, david-lyle: I've got a javascript standards question regarding how openstack should handle inheritance. There's a non-trivial performance boost we get from using prototypical inheritance and avoiding closures/lambdas, because of the way most javascript parsers assign pointers. On the flipside, prototypical inheritance means that everything we do is a public method (no concealing functionality in method scope). I'm more of a fan of the latte | 19:08 |
| krotscheck | r myself. | 19:08 |
| krotscheck | Actually, that's a question for everyone | 19:08 |
| krotscheck | Unlike in python, there's not one obvious correct way to do things in javascript :/ | 19:10 |
| krotscheck | A quick performance benchmark that illustrates the issue: https://coderwall.com/p/jj6fwa | 19:11 |
| mordred | krotscheck: in terms of performance - I do think that snappy usability is important | 19:14 |
| krotscheck | mordred: I agree. For things like live graph rendering this kind of a decision is super important. | 19:15 |
| ruhe | krotscheck: i'm a total in n00b in js. but here is a question: wouldn't overall application performance be influenced by the way how framework (jquery, anguler, etc) handles inheritance? | 19:15 |
| krotscheck | ruhe: Oh. Hrm. Point | 19:15 |
| krotscheck | ruhe, mordred: In the case of most applications, I don't think it matters. | 19:16 |
| krotscheck | ruhe, mordred: If we want to offload a LOT of processing to the browser though, it's something that bears consideration. | 19:16 |
| krotscheck | Example: Drawing a single line graph? Probably fine. | 19:16 |
| krotscheck | Building a 3D engine? Definitely not. | 19:16 |
| krotscheck | mordred: One thing about snappy usability is that the major lag will come from network traffic, not from the javascript engine. | 19:19 |
| krotscheck | And that's something we can manage. For example: You click on ticket. Page needs time to get ticket data, so we show you a page with a loading spinner and some good estimate on how long it might take to get the data. | 19:19 |
| krotscheck | My project patch does that, but of course I don't have an API yet ;) | 19:20 |
| krotscheck | (So there's no lag there to show it off) | 19:20 |
| krotscheck | ruhe: By the way, I rebased your patch and will push it through as soon as check finishes. | 19:20 |
| ruhe | krotscheck: that's great! | 19:21 |
| ruhe | krotscheck: is webclient in a state when we can point it to api server? | 19:21 |
| krotscheck | ruhe: Yes, yes it is. | 19:21 |
| krotscheck | ruhe: In fact, let me put together a patch that removes the mocks... | 19:21 |
| mordred | krotscheck: then based on that, I'd say lets write clean code - I don't think we need to optimize for a 3d image | 19:22 |
| ruhe | krotscheck: good, then we (me and Nikita) will try see tomorrow how they work together | 19:22 |
| krotscheck | ruhe: Got it. | 19:22 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard-webclient: Remove mock API interfaces from storyboard. https://review.openstack.org/68464 | 19:27 |
| openstackgerrit | A change was merged to openstack-infra/storyboard: Add tests for Alembic migrations https://review.openstack.org/66414 | 19:27 |
| krotscheck | ruhe: There you go. | 19:27 |
| krotscheck | (On both counts :) ) | 19:27 |
| ruhe | thanks :) | 19:28 |
| krotscheck | Now on to the API patch... | 19:28 |
| mordred | woot | 19:33 |
| krotscheck | I hope ruhe and NikitaKonovalov_ don't mind me going in and handling their rebases. | 19:36 |
| ruhe | krotscheck: i appreciate your help | 19:37 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Introducing basic REST API https://review.openstack.org/63118 | 19:38 |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 19:57 | |
| openstackgerrit | A change was merged to openstack-infra/storyboard: Introducing basic REST API https://review.openstack.org/63118 | 19:59 |
| krotscheck | Dum dee dum | 20:00 |
| krotscheck | Ok, next. | 20:00 |
| openstackgerrit | Michael Krotscheck proposed a change to openstack-infra/storyboard: Load projects from yaml file https://review.openstack.org/66280 | 20:02 |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 20:28 | |
| * krotscheck might have storyboard-webclient running side-by-side with the api :) | 20:35 | |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 20:42 | |
| mordred | krotscheck: w00t! | 20:43 |
| mordred | krotscheck: like, running locally and working and stuff? | 20:43 |
| ruhe | it's alive, it's alive!!! | 20:46 |
| krotscheck | mordred, ruhe: Well, running side by side. | 20:47 |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 20:47 | |
| krotscheck | mordred, ruhe: I'm still trying to figure out how to invoke the db migration from a tarball install | 20:47 |
| krotscheck | i.e.: I got it running from storyboard, with db migration and whatnot. | 20:48 |
| krotscheck | now I'm trying to have storyboard-webclient to do a tox install from tarballs and run tests against that. | 20:49 |
| ruhe | krotscheck: that's easy - storyboard-db-manage --config-file /etc/storyboard/storyboard.conf upgrade head | 20:49 |
| krotscheck | ruhe: Yeah, that gives me an sqlalchemy error | 20:50 |
| ruhe | can you post it to paste.openstack.org? | 20:50 |
| krotscheck | It's a missing db connection string | 20:51 |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 20:51 | |
| krotscheck | it's just that I'm still a novice with all the python tools, so debugging takes me longer | 20:51 |
| ruhe | krotscheck: you need something like "# connection = mysql://root:pass@127.0.0.1:3306/storyboard" in your storyboard.conf | 20:52 |
| krotscheck | Since you're curious though | 20:52 |
| krotscheck | http://paste.openstack.org/show/61708/ | 20:52 |
| *** drdee has joined #storyboard | 20:53 | |
| ruhe | krotscheck: or "connection = sqlite://", but i'm not sure about sqlite. it seems that alembic doesn't always play well with sqlite | 20:53 |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 20:57 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 21:02 | |
| krotscheck | ruhe: That makes sense. I'm going to write a storyboard-startup script for tox, so the webclient can create an isolated DB instance for each build. | 21:04 |
| *** drdee has quit IRC | 21:11 | |
| *** ruhe is now known as _ruhe | 21:23 | |
| *** david-lyle has quit IRC | 22:06 | |
| *** david-lyle has joined #storyboard | 22:06 | |
| *** drdee has joined #storyboard | 22:14 | |
| *** miqui has quit IRC | 22:24 | |
| *** taps has quit IRC | 22:27 | |
| krotscheck | mordred: So one part of jshint is licensed under a non-OSI license. | 23:35 |
| *** drdee has quit IRC | 23:40 | |
| *** taps has joined #storyboard | 23:42 | |
| mordred | krotscheck: yeah. I've heard about that ... but we shouldn't really need to care, right/ | 23:45 |
| mordred | krotscheck: also - I'm in a meeting thing - but I'm going to ping you in a sec about the db instance per build thing | 23:45 |
| krotscheck | mordred: ooookay? | 23:46 |
| mordred | krotscheck: (it's a great idea - I just want to dig in on it and grok the mechanism you're thinking about) | 23:47 |
| krotscheck | mordred: Why don't I just throw a patch at you. | 23:47 |
| krotscheck | mordred: We're not packaging the licensed code. | 23:51 |
| *** drdee has joined #storyboard | 23:51 | |
| krotscheck | mordred: But we are "using it" to build software that could be "used for evil" | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!