*** liyi has joined #senlin | 00:39 | |
*** chenyb4 has joined #senlin | 00:50 | |
*** pzchen has joined #senlin | 01:22 | |
*** liyi_ has joined #senlin | 01:26 | |
*** liyi has quit IRC | 01:29 | |
*** Jeffrey4l has joined #senlin | 01:34 | |
openstackgerrit | zhangzhaoshan proposed openstack/senlin master: Fix a https url issue https://review.openstack.org/542527 | 01:37 |
---|---|---|
*** Jeffrey4l_ has joined #senlin | 01:46 | |
*** Jeffrey4l has quit IRC | 01:47 | |
*** liyi has joined #senlin | 01:59 | |
*** liyi_ has quit IRC | 02:03 | |
openstackgerrit | Merged openstack/senlin master: Fix user document bindings.rst policy attach specify status https://review.openstack.org/540746 | 02:26 |
openstackgerrit | chenyb4 proposed openstack/senlin master: Add NOTIFIER message topic can be specified by configuration file. https://review.openstack.org/542546 | 02:31 |
openstackgerrit | xulei proposed openstack/senlin master: Replace Chiness punctuation with English punctuation https://review.openstack.org/542550 | 02:56 |
openstackgerrit | Merged openstack/senlin master: Replace Chiness punctuation with English punctuation https://review.openstack.org/542550 | 03:07 |
*** jmlowe has quit IRC | 03:38 | |
*** jmlowe has joined #senlin | 04:26 | |
*** AlexeyAbashkin has joined #senlin | 07:20 | |
chenyb4 | hi, Qiming scaling policy miss support version message https://github.com/openstack/senlin/blob/master/senlin/policies/scaling_policy.py#L36 | 07:32 |
chenyb4 | Qiming, I'm fixing it. Can you tell me when it was supported? | 07:32 |
Qiming | Okay | 07:33 |
Qiming | Have you tried if both deletion policy 1.0 and 1.1 can be created today? | 07:33 |
chenyb4 | Qiming, deletion policy 1.0 and 1.1 If you register, there will be no problems. | 07:35 |
chenyb4 | I'm trying to add some code to avoid repeating the type list. | 07:35 |
chenyb4 | But now I find the scaling policy miss support version message. | 07:36 |
chenyb4 | Qiming, Can you give me a scaling strategy from when to support the time? | 07:37 |
*** AlexeyAbashkin has quit IRC | 07:44 | |
openstackgerrit | chenyb4 proposed openstack/senlin master: Add scaling policy version support message https://review.openstack.org/542692 | 07:44 |
Qiming | If I remembered clearly, scaling policy was added with deletion policy 1.0 | 07:49 |
chenyb4 | Yes, I got the policy support time with the scaling_policy.yaml creation time. | 07:51 |
chenyb4 | examples/scaling_policy.yaml creation time. | 07:52 |
*** AlexeyAbashkin has joined #senlin | 07:54 | |
openstackgerrit | chenyb4 proposed openstack/senlin master: Fix lb and delete policy not support 1.0 version https://review.openstack.org/542076 | 09:03 |
chenyb4 | Qiming, 我重新提交了,修改了一点代码,关于1.0版本支持 | 09:04 |
chenyb4 | sorry | 09:04 |
*** liyi has quit IRC | 09:15 | |
*** Jeffrey4l_ has quit IRC | 09:17 | |
*** Jeffrey4l has joined #senlin | 09:18 | |
*** AlexeyAbashkin has quit IRC | 09:56 | |
*** AlexeyAbashkin has joined #senlin | 09:57 | |
*** liyi has joined #senlin | 10:01 | |
*** liyi has quit IRC | 10:05 | |
*** pzchen has quit IRC | 10:30 | |
*** pzchen has joined #senlin | 10:32 | |
*** pzchen has quit IRC | 10:37 | |
openstackgerrit | chenyb4 proposed openstack/senlin master: Fix lb and delete policy not support 1.0 version https://review.openstack.org/542076 | 10:43 |
*** chenyb4 has quit IRC | 10:52 | |
*** Guest37081 has joined #senlin | 11:12 | |
*** AlexeyAbashkin has quit IRC | 11:27 | |
*** AlexeyAbashkin has joined #senlin | 11:30 | |
*** Guest37081 has quit IRC | 11:33 | |
*** liyi has joined #senlin | 11:48 | |
*** liyi has quit IRC | 11:53 | |
*** blkart has quit IRC | 12:00 | |
*** blkart has joined #senlin | 12:00 | |
*** chenyb4 has joined #senlin | 12:39 | |
*** liyi has joined #senlin | 12:55 | |
*** liyi has quit IRC | 12:59 | |
chenyb4 | hi, Qiming https://review.openstack.org/#/c/542076/ I don't see what you mean. | 13:12 |
Qiming | That patch is not needed | 13:13 |
Qiming | Please do as I suggested | 13:13 |
Qiming | Try create a deletion policy with version 1.0 | 13:13 |
Qiming | And create a deletion policy with version 1.1 | 13:13 |
Qiming | And see if they both work | 13:13 |
Qiming | If they both work, we don't need to register the policy twich | 13:13 |
Qiming | It means the current code is good | 13:14 |
chenyb4 | ok | 13:14 |
Qiming | A more interesting and challenging work is to rework all policies / profiles using Oslo.versionedobject | 13:18 |
Qiming | That will hopefully open the door for seamless upgrade | 13:18 |
chenyb4 | Ok, I'll see. | 13:20 |
*** jmlowe has quit IRC | 13:26 | |
chenyb4 | In the case of unregistered, it doesn't look like it's possible to create a policy 1.0 version that is not successful and can't find the 1.0 version. | 13:29 |
chenyb4 | The policy_type 'senlin.policy.deletion-1.0' could not be found. | 13:30 |
Qiming | Okay, that is the real bug we need to fix | 13:30 |
chenyb4 | Any good ideas? My previous patch was to support 1.0 through registration, and by modifying the get_type code to avoid, the policy type list was repeated. | 13:33 |
Qiming | looking | 13:35 |
Qiming | I now understand the problems | 13:36 |
Qiming | But I don't want to introduce code that breaks our current API | 13:36 |
Qiming | Your change will return one record per policy version | 13:37 |
Qiming | That is not acceptable | 13:37 |
Qiming | If we do allow setup.cfg to register a plugin multiple times, we should still combine the version support status on a per policy type basis | 13:38 |
Qiming | Look at doc/source/user/policy_types.rst | 13:40 |
Qiming | That is the format we want to present to users on command line | 13:40 |
Qiming | Also in api-ref/source/parameters.yaml line 1205, it clearly states what users should be expecting | 13:43 |
Qiming | So ... when extracting policy types from registry, we should deduplicate entries for the same policy type | 13:44 |
chenyb4 | We should register the policy type, not the version, so any version of the policy can be used if allowed. | 13:48 |
chenyb4 | Is that right? | 13:49 |
*** jmlowe has joined #senlin | 14:00 | |
*** jmlowe has quit IRC | 14:05 | |
*** jmlowe has joined #senlin | 14:13 | |
*** chenyb4 has quit IRC | 14:36 | |
*** chenyb4 has joined #senlin | 14:44 | |
*** liyi has joined #senlin | 14:53 | |
*** liyi has quit IRC | 14:58 | |
*** AlexeyAbashkin has quit IRC | 15:40 | |
*** AlexeyAbashkin has joined #senlin | 15:42 | |
*** AlexeyAbashkin has quit IRC | 15:46 | |
*** jmlowe has quit IRC | 16:06 | |
*** chenyb4 has quit IRC | 16:18 | |
*** liyi has joined #senlin | 17:03 | |
*** liyi has quit IRC | 17:07 | |
*** AlexeyAbashkin has joined #senlin | 17:12 | |
*** AlexeyAbashkin has quit IRC | 17:48 | |
*** eandersson has joined #senlin | 17:57 | |
*** AlexeyAbashkin has joined #senlin | 18:00 | |
*** jmlowe has joined #senlin | 18:01 | |
*** AlexeyAbashkin has quit IRC | 18:04 | |
*** AlexeyAbashkin has joined #senlin | 18:08 | |
*** AlexeyAbashkin has quit IRC | 19:21 | |
*** liyi has joined #senlin | 19:42 | |
*** liyi has quit IRC | 19:46 | |
*** AlexeyAbashkin has joined #senlin | 19:49 | |
*** AlexeyAbashkin has quit IRC | 19:53 | |
*** liyi has joined #senlin | 21:16 | |
*** liyi has quit IRC | 21:20 | |
openstackgerrit | Duc Truong proposed openstack/senlin master: [DNM] Example of how to support multiple policy versions https://review.openstack.org/543049 | 22:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!