| *** shu-mutou has joined #senlin | 00:25 | |
| *** chenyb4 has joined #senlin | 00:48 | |
| *** liyi has joined #senlin | 00:58 | |
| *** Qiming_ has joined #senlin | 01:40 | |
| *** Qiming has quit IRC | 01:41 | |
| *** Qiming has joined #senlin | 01:43 | |
| *** Qiming_ has quit IRC | 01:45 | |
| *** pzchen has joined #senlin | 01:54 | |
| openstackgerrit | Merged openstack/senlin-tempest-plugin master: Disable receiver integration test https://review.openstack.org/541701 | 01:56 |
|---|---|---|
| openstackgerrit | chenyb4 proposed openstack/senlin master: Fix lb policy for 1.1 version support https://review.openstack.org/541980 | 02:03 |
| openstackgerrit | Merged openstack/senlin master: Further removal of localization to please py35 https://review.openstack.org/541738 | 02:51 |
| chenyb4 | It seems that deletion_policy_lifecycle_hook.yaml and deletion_policy.yaml are different policies. | 02:58 |
| chenyb4 | deletion_policy_lifecycle_hook.yaml Just complete the notification after deletion. | 02:59 |
| chenyb4 | cc Qiming | 03:02 |
| chenyb4 | hi, dtruong | 03:08 |
| chenyb4 | dtruong, It seems that deletion_policy_lifecycle_hook.yaml and deletion_policy.yaml are different policies. | 03:09 |
| chenyb4 | dtruong, deletion_policy_lifecycle_hook.yaml Just complete the notification after deletion. | 03:09 |
| chenyb4 | dtruong, https://github.com/openstack/senlin/blob/master/examples/policies/deletion_policy_lifecycle_hook.yaml | 03:10 |
| *** liyi has quit IRC | 03:37 | |
| *** liyi has joined #senlin | 03:37 | |
| openstackgerrit | Merged openstack/senlin master: Fix lb policy for 1.1 version support https://review.openstack.org/541980 | 04:02 |
| *** liyi has quit IRC | 04:34 | |
| *** liyi has joined #senlin | 04:34 | |
| *** jkuei has quit IRC | 05:41 | |
| *** eandersson has quit IRC | 05:50 | |
| dtruong | ok, looks like i forgot to update deletion_policy.yaml to use version 1.1 | 06:14 |
| chenyb4 | dtruong, I don't understand. the deletion_policy.yaml support lifecycle ? | 06:16 |
| dtruong | yes, this was added in deletion policy version 1.1 | 06:16 |
| dtruong | but all other properties from deletion policy 1.0 are still valid in deletion policy version 1.1 | 06:17 |
| dtruong | the deletion_policy.yaml just needs to use the new version 1.1 and it should work without any other change | 06:18 |
| chenyb4 | But now it looks like 1.0 is out of support. | 06:18 |
| dtruong | yes. i was following what was done with the load balancer policy v1.1 | 06:19 |
| dtruong | it doesn't look like load balancer policy v1.0 is valid anymore | 06:19 |
| chenyb4 | I see what you mean. We started using delete policy 1.1, and the 1.0 version no longer supports it. | 06:21 |
| dtruong | yes | 06:21 |
| chenyb4 | There is also a problem that you added a deletion_policy_lifecycle_hook. Yaml, this policy file, just added queue message publishing on the deletion_policy.yaml. why ? | 06:23 |
| *** Qiming_ has joined #senlin | 06:24 | |
| Qiming_ | chenyb4: there? | 06:25 |
| Qiming_ | I have got problems connecting the free node using IRC client, so now I'm using web irc | 06:25 |
| chenyb4 | Qiming_, dtruong deletion_policy_lifecycle_hook. Yaml will be used as a separate use? | 06:26 |
| Qiming_ | just want to ping you that the support date for deletion policy 1.1 should start 2018.02, which is when Queens releases | 06:26 |
| Qiming_ | pls also check LB 1.1 policy patch, I cannot recall exactly when LB 1.1 was released, labelling it as 2018.01 is not accurate | 06:27 |
| Qiming_ | deletion hook is a new feature supported by the 1.1 deletion policy | 06:27 |
| Qiming_ | those two patches were merged too fast | 06:28 |
| chenyb4 | I saw that delete_policy.yaml has different contents with deletion_policy_lifecycle_hook. Yaml, so I think delete_policy.yaml should contain support for deletion_policy_lifecycle_hook. Yaml. | 06:29 |
| dtruong | deletion_policy.yaml is intended to show the use of a deletion policy without lifecycle | 06:30 |
| dtruong | deletion_policy_lifecycle_hook.yaml was specifically created to show how to use a deletion policy with lifecycle hooks | 06:30 |
| Qiming | chenyb4, those files are not specifications, those are examples | 06:31 |
| dtruong | either of them is valid depending on what the user needs. the only fix that is needed is to correct the version in deletion_policy.yaml to version 1.1 | 06:32 |
| Qiming | No examples there are meant to show every properties or all possible combinations of properties | 06:32 |
| *** Qiming_ has quit IRC | 06:32 | |
| chenyb4 | I just want to tell the user the right way to use it, and when we add the delete policy, we can add the release of the delete message, instead of adding the two policies to the cluster at the same time. | 06:32 |
| Qiming | You won't be able to attach two deletion policies to the same cluster | 06:33 |
| chenyb4 | i see, This is what the user should know. | 06:34 |
| Qiming | Deletion policy is designed to have only one instance attached | 06:34 |
| Qiming | Would be cool if you can suggest where such information can be provided | 06:34 |
| chenyb4 | Ok, now we have the support of lb and delete 1.0 in the type list, so we need to adjust this? | 06:35 |
| Qiming | Please try if deletion policy 1.0 and 1.1 are both accepted by the api and the engine | 06:36 |
| chenyb4 | 1.1 support in setup.cfg was registry, but 1.0 not in setup.cfg | 06:37 |
| chenyb4 | Similarly 1.0 has the same attributes as 1.1. | 06:38 |
| chenyb4 | They're not different | 06:39 |
| Qiming | both of them should be there | 06:39 |
| dtruong | i removed deletion v1.0 from the setup.cfg | 06:43 |
| dtruong | https://github.com/openstack/senlin/blob/master/setup.cfg#L53 | 06:43 |
| Qiming | d | 06:43 |
| dtruong | what is the guideline for updating a policy version? are we supposed to keep the old version? | 06:43 |
| chenyb4 | dtruong, i see | 06:43 |
| Qiming | dtruong, I think we should leave all versions there | 06:44 |
| Qiming | All "supported" versions | 06:44 |
| Qiming | :) | 06:44 |
| Qiming | Although the implementation is using the same module | 06:44 |
| dtruong | yes, that's the reason i didnt keep it | 06:45 |
| dtruong | also v1.1 has everything that was in v1.0 | 06:46 |
| dtruong | so it didnt seem to make sense to keep it | 06:46 |
| chenyb4 | My suggestion is that if you support 1.0 and 1.1, should the two versions be different? If 1.0 is the same as 1.1, is it necessary to keep 1.0? | 06:48 |
| dtruong | the main difference between 1.0 and 1.1 is that i added new properties. | 06:59 |
| dtruong | any existing deletion policy that was written for 1.0, only needs to point to version 1.1 and it should | 07:00 |
| dtruong | so i do not see the need for keeping v1.0 | 07:01 |
| *** AlexeyAbashkin has joined #senlin | 07:20 | |
| openstackgerrit | Merged openstack/senlin-tempest-plugin master: Add tests for lifecycle hooks https://review.openstack.org/539070 | 07:27 |
| *** AlexeyAbashkin has quit IRC | 07:38 | |
| *** AlexeyAbashkin has joined #senlin | 07:43 | |
| *** AlexeyAbashkin has quit IRC | 07:47 | |
| *** AlexeyAbashkin has joined #senlin | 07:52 | |
| openstackgerrit | chenyb4 proposed openstack/senlin master: Fix lb and delete policy not support 1.0 version https://review.openstack.org/542076 | 08:08 |
| chenyb4 | dtruong, Qiming if use support v1.0 i was add new patch. view https://review.openstack.org/542076 | 08:11 |
| chenyb4 | But it doesn't seem to make much sense. | 08:12 |
| Qiming | Why do we add new classes? | 08:12 |
| Qiming | Cannot we just point the two versions to the same class? | 08:13 |
| Qiming | I believe the same code has already capable of detecting if a property is valid for a particular version | 08:14 |
| chenyb4 | If you point to the same class, then a 1.0 and 1.1 repeats appear in the type list. | 08:14 |
| Qiming | Yes, that was the reason I asked you to do a test: if deletion policy 1.0 and 1.1 are both accepted by the api and the engine | 08:15 |
| Qiming | dtruong was right. | 08:16 |
| chenyb4 | ok, Give me some time. I'll try something else. | 08:29 |
| chenyb4 | hi, Qiming 9763e308f3b6e8b9f3388c515397fae2c169319a This patch has a problem. the master branch don't load other plugin | 09:21 |
| blkart | Qiming, Driver plugin openstack is not found. | 09:23 |
| chenyb4 | Qiming, https://github.com/openstack/senlin/blob/master/senlin/drivers/base.py#L37 there don't load openstack plugin | 09:23 |
| blkart | senlin/engine/environment.py", line 151, in get_driver | 09:23 |
| blkart | raise exception.InvalidPlugin(message=msg) | 09:23 |
| blkart | InvalidPlugin: Driver plugin openstack is not found. | 09:23 |
| Qiming | Can you paste a link to the patch ? | 09:24 |
| Qiming | I don't know what to do with a hash value | 09:24 |
| *** liyi has quit IRC | 09:25 | |
| chenyb4 | https://github.com/openstack/senlin/blob/master/setup.cfg#L44 It doesn't look like you can load other plug-ins. | 09:27 |
| chenyb4 | cc Qiming | 09:27 |
| blkart | Qiming, https://review.openstack.org/#/c/539149/ | 09:27 |
| Qiming | Thanks, a patch link is proper | 09:27 |
| blkart | Qiming, it sames you move openstack to os ? | 09:28 |
| Qiming | chenyb4, did you reinstall senlin after applying that patch? | 09:28 |
| chenyb4 | Qiming, yes | 09:28 |
| Qiming | that cannot happen | 09:29 |
| Qiming | When you do a python setup for senlin or pip install | 09:29 |
| Qiming | The stevedore database would be updated | 09:29 |
| chenyb4 | Qiming, python setup | 09:29 |
| Qiming | Plugins will point to new location | 09:29 |
| Qiming | It works at gate, and all following patches work on gate and my local machine | 09:30 |
| Qiming | Please check your setup | 09:30 |
| chenyb4 | Qiming, I have cleared all installation records before installing. | 09:32 |
| chenyb4 | remove /usr/lib/python2.7/site-packages/senlin or /usr/lib/python2.7/site-packages/senlin-* | 09:34 |
| chenyb4 | and execute python setup.py install | 09:35 |
| Qiming | Did I mention stevedore ? | 09:35 |
| Qiming | Read this again: https://docs.openstack.org/senlin/pike/install/ | 09:38 |
| chenyb4 | i see, thanks | 09:40 |
| Qiming | sudo pip install -e . | 09:41 |
| Qiming | This ensures that the plugins senlin provided are known to stevedore, in future when senlin asks stevedore to load a plugin, stevedore knows where to load it | 09:42 |
| Qiming | Deleting senlin code doesn't help | 09:42 |
| *** shu-mutou is now known as shu-mutou-AWAY | 09:44 | |
| *** chenyb4 has quit IRC | 10:11 | |
| *** pzchen has quit IRC | 10:12 | |
| *** liyi has joined #senlin | 12:19 | |
| *** liyi has quit IRC | 12:24 | |
| *** chenyb4 has joined #senlin | 12:26 | |
| openstackgerrit | Merged openstack/senlin master: Enable more extensions in pep8 https://review.openstack.org/538825 | 12:59 |
| *** liyi has joined #senlin | 13:02 | |
| *** AlexeyAbashkin has quit IRC | 13:03 | |
| *** AlexeyAbashkin has joined #senlin | 13:04 | |
| *** liyi has quit IRC | 13:07 | |
| openstackgerrit | OpenStack Release Bot proposed openstack/senlin master: Update reno for stable/queens https://review.openstack.org/542177 | 13:21 |
| *** AlexeyAbashkin has quit IRC | 13:56 | |
| *** AlexeyAbashkin has joined #senlin | 13:56 | |
| *** elynn has joined #senlin | 14:10 | |
| *** lixinhui has joined #senlin | 14:14 | |
| *** lixinhui has left #senlin | 14:17 | |
| *** xinhuili has joined #senlin | 14:18 | |
| *** liyi has joined #senlin | 14:24 | |
| *** liyi has quit IRC | 14:28 | |
| *** chenyb4 has quit IRC | 14:31 | |
| *** xinhuili has left #senlin | 14:32 | |
| openstackgerrit | XueFeng Liu proposed openstack/senlin master: Modify Descripition https://review.openstack.org/541720 | 15:31 |
| *** Guest37081 has joined #senlin | 15:40 | |
| *** liyi has joined #senlin | 15:43 | |
| *** liyi has quit IRC | 15:48 | |
| *** elynn has quit IRC | 16:04 | |
| *** xinhuili has joined #senlin | 16:05 | |
| *** xinhuili has quit IRC | 16:05 | |
| *** elynn has joined #senlin | 16:05 | |
| *** elynn has quit IRC | 16:14 | |
| *** Guest37081 has quit IRC | 16:21 | |
| *** Guest37081 has joined #senlin | 16:33 | |
| *** openstackgerrit has quit IRC | 16:48 | |
| *** liyi has joined #senlin | 17:03 | |
| *** Guest37081 has quit IRC | 17:04 | |
| *** liyi has quit IRC | 17:07 | |
| *** openstackgerrit has joined #senlin | 17:09 | |
| *** ChanServ sets mode: +v openstackgerrit | 17:09 | |
| openstackgerrit | Merged openstack/senlin master: Modify Descripition https://review.openstack.org/541720 | 17:09 |
| *** AlexeyAbashkin has quit IRC | 17:19 | |
| *** AlexeyAbashkin has joined #senlin | 17:23 | |
| *** AlexeyAbashkin has quit IRC | 17:28 | |
| *** AlexeyAbashkin has joined #senlin | 17:33 | |
| *** AlexeyAbashkin has quit IRC | 17:37 | |
| *** liyi has joined #senlin | 18:42 | |
| *** liyi has quit IRC | 18:46 | |
| *** AlexeyAbashkin has joined #senlin | 19:37 | |
| *** jmlowe has quit IRC | 19:59 | |
| *** jmlowe has joined #senlin | 20:11 | |
| *** liyi has joined #senlin | 20:51 | |
| *** liyi has quit IRC | 20:56 | |
| *** jmlowe has quit IRC | 20:56 | |
| *** jmlowe has joined #senlin | 21:33 | |
| *** AlexeyAbashkin has quit IRC | 22:23 | |
| *** Jeffrey4l has quit IRC | 23:34 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!