| *** jhesketh_ is now known as jhesketh | 03:14 | |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: add jobs for python-tempestconf only https://review.openstack.org/581084 | 06:07 |
|---|---|---|
| *** tosky has joined #refstack | 07:42 | |
| *** rmart04 has joined #refstack | 07:44 | |
| *** kopecmartin has joined #refstack | 08:03 | |
| arxcruz | tosky: chandankumar kopecmartin https://review.openstack.org/#/c/587816/ | 08:37 |
| arxcruz | while zuul gave +1 | 08:38 |
| tosky | it gave +1 even before, but then you changed it, should it be fine now? | 08:39 |
| tosky | I'd still like to hear about kopecmartin about Services vs VersioneServices and the place for the new methods | 08:39 |
| kopecmartin | arxcruz, tosky I had a quick look yesterday, but I need more time to understand the change | 08:52 |
| kopecmartin | I'll have a look during the day | 08:52 |
| arxcruz | kopecmartin: just remove the dependence of a constant | 08:52 |
| tosky | arxcruz: the logic itself is fine (and kopecmartin created the story, so he knows that part :) | 08:55 |
| tosky | apart from the general review on the patch, I have one question on a specific change | 08:55 |
| arxcruz | shoot | 08:56 |
| tosky | basically many new methods connected to the version are added to Services instead of VersionedServices | 08:56 |
| tosky | (I think we discussed it briefly on the review itself) | 08:56 |
| tosky | so the question is: does it make sense to keep two classes? Or is there a way to split them better? | 08:56 |
| tosky | that's it | 08:56 |
| tosky | fine with both solutions, just a consistent one | 08:56 |
| chandankumar | tosky: Hello | 09:03 |
| chandankumar | tosky: I saw the last night discussion about python-tempestconf place related to merging refstack-client and refstack with interop wg | 09:04 |
| chandankumar | tosky: I am not sure what would be the best place for us? | 09:04 |
| chandankumar | tosky: Can we reach out to QA team to again relook in the tool and adopt under QA? | 09:05 |
| arxcruz | tosky: yes, makes sense to keep both classes | 09:07 |
| arxcruz | versionedservices is not inherit from all the services because some services doesn't have versions | 09:07 |
| arxcruz | i put the methods on the Services, because i didn't wanted to do if isinstanceof(VersionedService) everywhere | 09:08 |
| arxcruz | i know from one point of view, this is bad | 09:08 |
| arxcruz | but at this moment, was the best decision imho | 09:09 |
| arxcruz | later when we get rid of the constants, and have the services loading automatically we can make this distinction | 09:09 |
| tosky | chandankumar: you can try pinging whoever you think it's appropriate | 09:12 |
| arxcruz | tosky: ^ | 09:24 |
| arxcruz | kopecmartin: ^ | 09:24 |
| kopecmartin | arxcruz, sounds reasonable | 09:24 |
| tosky | uhm, let's just not forget it | 09:25 |
| arxcruz | don't get me wrong, i was very frustated when I saw that errors because of Service | 09:36 |
| arxcruz | but then I get more frustated when I saw how much work I would have to fix it | 09:37 |
| arxcruz | lol | 09:37 |
| arxcruz | brb, upgrade my system | 09:39 |
| openstackgerrit | Merged openstack/python-tempestconf master: Fix: return the flavor ID on autodetection https://review.openstack.org/589260 | 09:44 |
| *** rmart04 has quit IRC | 09:53 | |
| openstackgerrit | Chandan Kumar proposed openstack/refstack-client master: Generate tempest.conf automatically using refstack-client https://review.openstack.org/541273 | 10:52 |
| chandankumar | kopecmartin: ^^ I have updated all the things in this change | 10:53 |
| chandankumar | now it will generate accounts.yaml as well as overrides values | 10:53 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: add jobs for python-tempestconf only https://review.openstack.org/581084 | 11:11 |
| openstackgerrit | Chandan Kumar proposed openstack/refstack-client master: Generate tempest.conf automatically using refstack-client https://review.openstack.org/541273 | 11:40 |
| chandankumar | hogepodge: Hello | 12:28 |
| chandankumar | hogepodge: I have updated the refstack integration patch https://review.openstack.org/541273 please let us know if anything we can improve on this | 12:28 |
| openstackgerrit | Merged openstack/python-tempestconf master: Fix: make sure that keystone_v3_support is a boolean https://review.openstack.org/588624 | 13:19 |
| arxcruz | kopecmartin: https://review.openstack.org/#/c/587816 please :) | 14:21 |
| openstackgerrit | Merged openstack/python-tempestconf master: Document CLI options https://review.openstack.org/580981 | 14:22 |
| kopecmartin | arxcruz, I have some questions .. commented there | 14:47 |
| arxcruz | gosh! | 14:48 |
| arxcruz | kopecmartin: done | 14:55 |
| openstackgerrit | Arx Cruz proposed openstack/python-tempestconf master: Removing dependence from SERVICE_VERSIONS https://review.openstack.org/587816 | 14:55 |
| arxcruz | now please +2 | 14:55 |
| arxcruz | :) | 14:55 |
| arxcruz | I can't stay with this patch one more day lol | 14:56 |
| kopecmartin | :D | 14:57 |
| kopecmartin | i commented again | 14:57 |
| arxcruz | kopecmartin: $service because $service can be something else | 14:57 |
| arxcruz | you never saw this before? | 14:57 |
| arxcruz | it's like replace $service with volume, metering, etc ? | 14:58 |
| arxcruz | got it? | 14:58 |
| kopecmartin | yes, but the sentence made me think in a different context, therefor it wasn't clear for first reading | 15:01 |
| kopecmartin | it doesn't return service, but the name of the service | 15:01 |
| openstackgerrit | Arx Cruz proposed openstack/python-tempestconf master: Removing dependence from SERVICE_VERSIONS https://review.openstack.org/587816 | 15:03 |
| arxcruz | kopecmartin: as far as you +2 asap ^ | 15:03 |
| tosky | arxcruz, kopecmartin: I would use <service> and <service>-feature-enabled maybe in that context | 15:03 |
| chandankumar | arxcruz: tosky kopecmartin please have a look at this https://review.openstack.org/541273 | 15:04 |
| openstackgerrit | Arx Cruz proposed openstack/python-tempestconf master: Removing dependence from SERVICE_VERSIONS https://review.openstack.org/587816 | 15:04 |
| arxcruz | tosky: kopecmartin better ^ | 15:04 |
| arxcruz | tosky: good idea, done, please +2 now | 15:04 |
| arxcruz | :) | 15:04 |
| arxcruz | chandankumar: +1 | 15:19 |
| arxcruz | tosky: please +2 again there my patch | 15:19 |
| arxcruz | even better +2+w so it can finish till tomorrow | 15:19 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: add jobs for python-tempestconf only https://review.openstack.org/581084 | 15:22 |
| tosky | arxcruz: I think I did already when you repinged | 15:26 |
| arxcruz | tosky: ty | 15:26 |
| arxcruz | tosky: i own you a tea :P | 15:26 |
| *** tosky has quit IRC | 16:57 | |
| *** kopecmartin has quit IRC | 17:13 | |
| *** markvoelker_ has quit IRC | 17:45 | |
| *** openstackgerrit has quit IRC | 18:49 | |
| -openstackstatus- NOTICE: Due to a bug, Zuul has been unable to report on cherry-picked changes over the last 24 hours. This has now been fixed; if you encounter a cherry-picked change missing its results (or was unable to merge), please recheck now. | 20:44 | |
| *** openstackgerrit has joined #refstack | 23:51 | |
| openstackgerrit | Merged openstack/python-tempestconf master: Removing dependence from SERVICE_VERSIONS https://review.openstack.org/587816 | 23:51 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!