| *** achanda has quit IRC | 00:03 | |
| *** reed has joined #openstack-zaqar | 00:14 | |
| *** VeggieMeat has joined #openstack-zaqar | 00:41 | |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Adds message processing to WebSockets driver https://review.openstack.org/144803 | 00:43 |
|---|---|---|
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Update json schema for API v1_1 https://review.openstack.org/148414 | 00:43 |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Adds a status code field to the Response https://review.openstack.org/164007 | 00:43 |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Adds a representation for the Request and Response objects https://review.openstack.org/164008 | 00:43 |
| *** sriram has joined #openstack-zaqar | 00:47 | |
| *** amitgandhinz has joined #openstack-zaqar | 01:05 | |
| *** sriram has quit IRC | 01:09 | |
| openstackgerrit | Merged openstack/zaqar: Syntax enhancements https://review.openstack.org/163223 | 01:34 |
| vkmc | rsFF, ^ | 01:34 |
| vkmc | :) | 01:34 |
| *** AAzza_afk has joined #openstack-zaqar | 02:21 | |
| *** AAzza has quit IRC | 02:22 | |
| *** AAzza_afk is now known as AAzza | 02:22 | |
| *** reed has quit IRC | 02:33 | |
| *** achanda has joined #openstack-zaqar | 02:44 | |
| *** amitgandhinz has quit IRC | 03:13 | |
| *** amalagon has quit IRC | 03:52 | |
| *** chandankumar has joined #openstack-zaqar | 04:39 | |
| *** exploreshaifali has joined #openstack-zaqar | 05:14 | |
| *** chandankumar has quit IRC | 05:36 | |
| *** exploreshaifali has quit IRC | 05:38 | |
| *** chandankumar has joined #openstack-zaqar | 05:39 | |
| *** exploreshaifali has joined #openstack-zaqar | 05:47 | |
| *** chandankumar has quit IRC | 05:52 | |
| *** exploreshaifali has quit IRC | 05:55 | |
| *** achanda has quit IRC | 06:10 | |
| *** achanda has joined #openstack-zaqar | 06:13 | |
| *** achanda has quit IRC | 06:28 | |
| *** achanda has joined #openstack-zaqar | 06:34 | |
| *** achanda has quit IRC | 06:38 | |
| *** chandankumar has joined #openstack-zaqar | 06:52 | |
| *** exploreshaifali has joined #openstack-zaqar | 07:48 | |
| *** openstackgerrit has quit IRC | 08:21 | |
| *** openstackgerrit has joined #openstack-zaqar | 08:21 | |
| *** exploreshaifali has quit IRC | 11:03 | |
| rsFF | vkmc - :) | 11:41 |
| *** exploreshaifali has joined #openstack-zaqar | 11:45 | |
| *** exploreshaifali has quit IRC | 12:23 | |
| *** chandankumar has quit IRC | 12:40 | |
| *** exploreshaifali has joined #openstack-zaqar | 13:10 | |
| *** sriram has joined #openstack-zaqar | 13:14 | |
| *** dynarro has joined #openstack-zaqar | 13:35 | |
| *** dynarro has quit IRC | 13:41 | |
| *** amitgandhinz has joined #openstack-zaqar | 14:02 | |
| *** csoukup has joined #openstack-zaqar | 14:16 | |
| *** exploreshaifali has quit IRC | 14:42 | |
| vkmc | hi everyone! | 14:58 |
| vkmc | flaper87, thx for the reviews :) | 14:59 |
| flaper87 | vkmc: np :) | 15:03 |
| flaper87 | vkmc: and HELLLLOOO!!! | 15:03 |
| vkmc | flaper87, hi hi hi | 15:03 |
| *** mpanetta has joined #openstack-zaqar | 15:12 | |
| openstackgerrit | Merged openstack/zaqar: Adds a representation for the Request and Response objects https://review.openstack.org/164008 | 15:23 |
| *** reed has joined #openstack-zaqar | 15:40 | |
| vkmc | flaper87, if you have a moment, I could use some help with the tests | 15:40 |
| vkmc | for websocket | 15:41 |
| vkmc | I'm not sure if I'm following the right approach | 15:41 |
| flaper87 | vkmc: here | 15:44 |
| *** exploreshaifali has joined #openstack-zaqar | 15:46 | |
| vkmc | flaper87, so, basically, I copied the bits for the WSGI driver tests and added a client protocol in here https://review.openstack.org/#/c/144803/6/zaqar/tests/unit/transport/websocket/base.py | 15:47 |
| vkmc | that should set up the websocket server and also provide the client protocol for all the tests that we are going to need | 15:47 |
| * flaper87 clicks | 15:47 | |
| vkmc | and for each test, in the setUp, we instantiate the client protocol and... | 15:48 |
| vkmc | https://review.openstack.org/#/c/144803/6/zaqar/tests/unit/transport/websocket/v1_1/test_queue_lifecycle.py | 15:48 |
| vkmc | there is when I get doubtful | 15:48 |
| vkmc | the server is already running and ready to get messages | 15:48 |
| vkmc | but the client... should I create a different thread for it? because once it sends a message, it has to be ready to listen to the response | 15:49 |
| flaper87 | mmh, I don't understand why you need a thread for the client | 15:50 |
| flaper87 | ah because it opens a connection and keeps it open | 15:50 |
| flaper87 | ? | 15:50 |
| vkmc | yep | 15:50 |
| flaper87 | does it have an internal loop ? | 15:50 |
| vkmc | what do you mean by that? | 15:50 |
| flaper87 | vkmc: and internal event loop * | 15:51 |
| vkmc | the websocket library performs the controls internally | 15:51 |
| flaper87 | I mean, if it's a matter of opening a connection and keeping it open, I don't think it needs a separate thread/process | 15:51 |
| flaper87 | because it won't lock | 15:51 |
| flaper87 | it opens the connection and that's it | 15:51 |
| flaper87 | but if it has an event loop that will prevent the test to keep going then it's a problem | 15:52 |
| vkmc | mmh | 15:52 |
| vkmc | I'll try a few things | 15:53 |
| flaper87 | vkmc: one question, do we really need that TestBase ? | 15:53 |
| flaper87 | it looks a lot like the one we already have | 15:53 |
| flaper87 | considering that transports are initialized based on the config, is there a way to re-use the one we have already ? | 15:54 |
| vkmc | flaper87, we don't, I could refactor | 15:54 |
| vkmc | I was thinking on doing so in a follow up :) this was a quick solution | 15:54 |
| vkmc | but refactoring shouldn't take much | 15:54 |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Adds a status code field to the Response https://review.openstack.org/164007 | 15:57 |
| flaper87 | vkmc: it looks like it does have an event loop https://github.com/tavendo/AutobahnPython/blob/master/examples/asyncio/websocket/echo/client.py#L68 | 15:58 |
| vkmc | flaper87, yes, that is what I don't want to do | 15:59 |
| vkmc | flaper87, seems like we don't have another choice though, right? | 16:00 |
| vkmc | if I start the event loop in the setUp, and finish it in the dropDown | 16:00 |
| vkmc | adding an extra param to the onMessage wrapper to pass the payload | 16:01 |
| flaper87 | vkmc: unless we don't use the autobhan client | 16:01 |
| vkmc | well, I did something like that in javascript | 16:01 |
| flaper87 | also, I hate that event loop | 16:02 |
| vkmc | but I wanted to stick with python unit tests | 16:02 |
| vkmc | for consistency reasons | 16:02 |
| flaper87 | there should be other libraries we can use | 16:02 |
| vkmc | for the client side? | 16:02 |
| flaper87 | I think I used w4py in my hack | 16:02 |
| flaper87 | vkmc: yup, just client/tests | 16:02 |
| vkmc | ok | 16:02 |
| flaper87 | if it makes it easier and works, then why not? | 16:02 |
| vkmc | we could do it | 16:02 |
| flaper87 | vkmc: give it a try and let me know | 16:03 |
| vkmc | k | 16:03 |
| vkmc | thanks mentor | 16:03 |
| vkmc | talking about libraries | 16:05 |
| vkmc | hope I can use this one someday https://cryptography.io/en/latest/fernet/ | 16:05 |
| flaper87 | LOOOOOOOOOOOOOOOOOOOL | 16:08 |
| vkmc | you know you want too | 16:08 |
| * flaper87 pictures vkmc drinking fernet while using fernet in a place called fernet | 16:08 | |
| vkmc | oh yes yes | 16:09 |
| vkmc | I was already amused with this user group http://fernetjs.com/ | 16:09 |
| vkmc | during my js's times | 16:09 |
| * flaper87 will pretend he didn't read that last msg | 16:10 | |
| vkmc | ahaha | 16:10 |
| vkmc | everyone has a dark past | 16:10 |
| flaper87 | vkmc: no, my past is clean and it shines more than 3 suns put together | 16:11 |
| flaper87 | >.> | 16:11 |
| vkmc | flaper87, one problem with testing with a different library | 16:20 |
| vkmc | global-requirements | 16:20 |
| flaper87 | vkmc: mmh, shit | 16:21 |
| flaper87 | lest first see if it works and then deal with g-r | 16:21 |
| vkmc | k | 16:22 |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Update json schema for API v1_1 https://review.openstack.org/148414 | 16:24 |
| vkmc | flaper87, is there a particular reason you don't want the autobahn event loop in the middle? | 16:27 |
| flaper87 | vkmc: mmh, just making testing simpler | 16:28 |
| flaper87 | I really don't like the fact the client library requires an eventloop | 16:29 |
| flaper87 | if we can make it work easily with the eventloop then we could stick with it | 16:29 |
| flaper87 | just trying to be pragmatic w.r.t that | 16:29 |
| vkmc | makes sense | 16:29 |
| * flaper87 will dig into this event loop | 16:29 | |
| vkmc | https://docs.python.org/dev/library/asyncio-eventloops.html | 16:31 |
| vkmc | I'll dig more on it too | 16:31 |
| vkmc | I don't like the fact that they mention windows so much | 16:32 |
| *** akanksha has joined #openstack-zaqar | 16:34 | |
| openstackgerrit | Flavio Percoco proposed openstack/zaqar: Implements: help strings https://review.openstack.org/163168 | 17:15 |
| *** achanda has joined #openstack-zaqar | 17:33 | |
| vkmc | flaper87, seems like we are going to use another lib | 17:51 |
| vkmc | ideas I reached so far are just... eek | 17:51 |
| flaper87 | vkmc: mmh, understood | 17:54 |
| flaper87 | vkmc: actually, https://github.com/FlaPer87/marconi-websocket/blob/master/examples/test.py#L6-L31 | 17:55 |
| flaper87 | ws4py has a loop too | 17:55 |
| flaper87 | so, lets work together on a solution | 17:55 |
| vkmc | flaper87, the only way to received messages is using the onMessage wrapper | 17:55 |
| vkmc | s/received/receive | 17:55 |
| vkmc | that is callback function that triggers when a message is received | 17:56 |
| flaper87 | vkmc: ws4py works the same way | 17:56 |
| flaper87 | apparently | 17:56 |
| vkmc | hmm | 17:56 |
| * flaper87 had forgotten about that | 17:56 | |
| vkmc | k | 17:56 |
| vkmc | so, those wrappers have to be implemented by extending a clientprotocol class autobahn has | 17:57 |
| vkmc | the question is, how can I return the server response to the test I'm running? | 17:57 |
| vkmc | to make the required assertions | 17:57 |
| flaper87 | vkmc: did you push the latest ? | 17:58 |
| vkmc | kind of | 17:58 |
| flaper87 | one way would be by writing the assertions in the client itself | 17:58 |
| flaper87 | and giving it an instance of the test class | 17:58 |
| flaper87 | as in, passing the instance of the test to the client | 17:58 |
| vkmc | I thought about that | 17:59 |
| vkmc | but hmm | 17:59 |
| flaper87 | vkmc: it's not such a rare approach | 17:59 |
| flaper87 | I've used it before | 18:00 |
| vkmc | that is when my knowledge of testing in python falls short | 18:00 |
| vkmc | flaper87, the fact you used if before doesn't make it more natural :P | 18:00 |
| vkmc | but tell me hahahaha | 18:00 |
| flaper87 | vkmc: hahaha, I meant that it's not that weird to do that | 18:01 |
| vkmc | sure :) | 18:01 |
| flaper87 | as long as the client instance stays isolated in the test | 18:01 |
| flaper87 | and it's created for every test | 18:01 |
| vkmc | do you have a pointer on where you used that for me to peek? | 18:01 |
| vkmc | I'm dunno where, in the test flow, I should pass the test instance | 18:02 |
| vkmc | flaper87, ^ | 18:05 |
| flaper87 | mmh, let me try to look it up but for now, push all you have and lets try to take a look at this specific case | 18:06 |
| vkmc | thanks :) | 18:06 |
| vkmc | I'll move forward by adding the rest of the endpoints to for cross-transport-api-spect | 18:07 |
| vkmc | spec* | 18:07 |
| vkmc | how are we with the other changes? capabilities, notifications? | 18:08 |
| flaper87 | vkmc: I was looking at that earlier today, capabilities seems to be done, which worries me a bit because I don't remember finishing it | 18:10 |
| flaper87 | :P | 18:10 |
| flaper87 | the opt-in FIFO thing landed too | 18:10 |
| flaper87 | and the capabilities are exposed through the API too | 18:11 |
| flaper87 | I'll have to test the API | 18:11 |
| flaper87 | re notifications | 18:11 |
| flaper87 | flwang1: said he'll have something done by monday, he's been busy lately | 18:11 |
| vkmc | flaper87, maybe your alter ego finished it | 18:11 |
| vkmc | that are really good news | 18:11 |
| flaper87 | vkmc: probably, it's really expensive to keep clones alive | 18:13 |
| flaper87 | time-wise and money-wise | 18:13 |
| vkmc | flaper87, I hear ya | 18:14 |
| vkmc | another thing we have to discuss | 18:15 |
| vkmc | is what is going to happen with osprofiler | 18:15 |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Adds message processing to WebSockets driver https://review.openstack.org/144803 | 19:00 |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Update json schema for API v1_1 https://review.openstack.org/148414 | 19:00 |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Adds a status code field to the Response https://review.openstack.org/164007 | 19:00 |
| flaper87 | vkmc: re osprofiler, I was going to review that in the next couple of days | 19:00 |
| vkmc | flaper87, k, I'll take a look too | 19:01 |
| vkmc | flaper87, last change for the websockets tests here https://review.openstack.org/#/c/144803/ | 19:02 |
| vkmc | wait wait wait wait | 19:07 |
| vkmc | if the idea of passing the test instance for the protocol doesn't work | 19:09 |
| vkmc | we could ask the protocol for the datareceived... is not the best because we won't be interacting with the interface | 19:09 |
| vkmc | but it could work | 19:09 |
| vkmc | https://github.com/tavendo/AutobahnPython/blob/master/autobahn/websocket/protocol.py#L1280 | 19:09 |
| *** akanksha has quit IRC | 19:27 | |
| *** achanda has quit IRC | 20:06 | |
| *** kgriffs|afk is now known as kgriffs | 20:09 | |
| *** achanda has joined #openstack-zaqar | 20:11 | |
| *** achanda has quit IRC | 20:25 | |
| *** akanksha has joined #openstack-zaqar | 20:27 | |
| *** kgriffs is now known as kgriffs|afk | 20:38 | |
| *** exploreshaifali has quit IRC | 20:46 | |
| *** exploreshaifali has joined #openstack-zaqar | 20:56 | |
| *** exploreshaifali has quit IRC | 20:57 | |
| *** achanda has joined #openstack-zaqar | 20:57 | |
| *** kgriffs|afk is now known as kgriffs | 21:09 | |
| flaper87 | vkmc: how's it going? | 21:10 |
| *** csoukup has quit IRC | 21:15 | |
| *** achanda has quit IRC | 21:27 | |
| *** achanda has joined #openstack-zaqar | 21:33 | |
| vkmc | flaper87, with the api or with the tests_ | 21:42 |
| vkmc | flaper87, or something else? | 21:42 |
| flaper87 | vkmc: tests | 21:45 |
| vkmc | I uploaded all that I had | 21:47 |
| vkmc | but still now sure how to tackle the approach you said | 21:47 |
| vkmc | (passing the test instance to make assertions) | 21:47 |
| vkmc | I was working on the rest of the api now | 21:48 |
| flaper87 | vkmc: ok, lemme download your patch and give it a go | 21:50 |
| flaper87 | if you don't mind | 21:50 |
| vkmc | flaper87, I don't | 21:50 |
| flaper87 | cool | 21:50 |
| vkmc | in fact, I'd give you gummybears to do it | 21:50 |
| vkmc | now that I know you are willing to do it without them.... | 21:50 |
| flaper87 | vkmc: i didn't say it was for free | 21:51 |
| flaper87 | I've a notebook where I write all these things | 21:51 |
| *** sriram has quit IRC | 21:53 | |
| *** echevemaster has joined #openstack-zaqar | 22:00 | |
| *** mpanetta has quit IRC | 22:07 | |
| *** csoukup has joined #openstack-zaqar | 22:15 | |
| *** amitgandhinz has quit IRC | 22:23 | |
| vkmc | kgriffs, ping | 22:24 |
| * kgriffs waives | 22:25 | |
| vkmc | :D :D :D | 22:25 |
| vkmc | hiiii | 22:25 |
| kgriffs | hi. :) | 22:25 |
| vkmc | how are ya? | 22:25 |
| kgriffs | doing OK. Getting ready to drive cross country to Florida tomorrow | 22:30 |
| kgriffs | Next week the kids have spring break, so we're going to go play | 22:30 |
| kgriffs | vkmc: how are you? | 22:31 |
| vkmc | kgriffs, that's great! road trip! | 22:32 |
| vkmc | kgriffs, I saw in the news that is was really cold and snowy for you guys last couple of days, hope that you have a good weather for spring :) | 22:33 |
| vkmc | kgriffs, I just came back to recover my passport, I was waiting to get the visa to Canada :) | 22:33 |
| vkmc | so happy about it | 22:34 |
| vkmc | one less thing | 22:34 |
| kgriffs | awesome | 22:35 |
| vkmc | working on some changes for the persistent transport driver now :) | 22:35 |
| kgriffs | ah, cool | 22:36 |
| kgriffs | I've had my hands full working on some security stuff at Rackspace | 22:37 |
| vkmc | interesting! | 22:37 |
| kgriffs | guess what I got in the mail today? | 22:39 |
| kgriffs | Raspberry Pi 2 | 22:40 |
| vkmc | :o you cannot blame your friend again | 22:40 |
| vkmc | I feel this was your call! haha | 22:40 |
| vkmc | that's really cool, do you have plans for it already? :) | 22:40 |
| kgriffs | I was going to try a few things | 22:41 |
| kgriffs | retropie | 22:42 |
| kgriffs | volumio | 22:42 |
| kgriffs | I need to do something with blinky lights as well | 22:42 |
| vkmc | uhuh retropie neat! | 22:43 |
| vkmc | I tried it with my raspi v1 | 22:43 |
| vkmc | its pretty awesome | 22:43 |
| vkmc | I didn't know about volumio | 22:43 |
| kgriffs | re blink lights: http://www.adafruit.com/products/1616 | 22:44 |
| kgriffs | I'm tempted to pick up another rpi2 | 22:45 |
| kgriffs | sparkfun has them on sale starting at midnight MST while supplies last | 22:45 |
| kgriffs | oooh | 22:46 |
| kgriffs | https://blog.adafruit.com/category/raspberry-pi/ | 22:46 |
| * kgriffs is becoming seriously distracted | 22:46 | |
| vkmc | haha really coool | 22:46 |
| vkmc | do you build this stuff with your kids or they are too little for that yet? | 22:47 |
| kgriffs | I think Ivy could handle a soldering iron. She's 12. Next-oldest is Thomas, who is 11. | 22:52 |
| kgriffs | oops | 22:52 |
| kgriffs | I mean 10 | 22:52 |
| kgriffs | anyway, I'd like to do some things with them | 22:52 |
| *** ametts has quit IRC | 22:53 | |
| kgriffs | hard to find time at the moment because they are so busy with school, but maybe in the summer | 22:53 |
| vkmc | sure :) | 22:54 |
| kgriffs | btw | 22:54 |
| kgriffs | https://www.sparkfun.com/PiDay2015 | 22:54 |
| vkmc | pi day! | 22:54 |
| *** csoukup has quit IRC | 23:41 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!