| *** kgriffs is now known as kgriffs|afk | 00:06 | |
| *** flwang has quit IRC | 00:11 | |
| *** flwang has joined #openstack-zaqar | 00:11 | |
| *** boris-42 has joined #openstack-zaqar | 00:15 | |
| vkmc | flaper87, ping | 00:22 |
|---|---|---|
| vkmc | kgriffs|afk, hi hi hi :) | 00:22 |
| flaper87 | vkmc: pong | 00:23 |
| vkmc | flaper87, when is the freeze... exactly_ | 00:25 |
| vkmc | ? | 00:25 |
| flaper87 | vkmc: tomorrow? But honestly, we'll kind of skip it. | 00:28 |
| flaper87 | As in, we'll have exceptions for both, websocket and notifications | 00:28 |
| vkmc | k k | 00:28 |
| vkmc | would you be around to review websockets/notifications? | 00:29 |
| vkmc | so we push them forward asap | 00:29 |
| flaper87 | yes, I'll be afk for ~2hs but then back | 00:29 |
| flaper87 | in 30mins, that is | 00:29 |
| vkmc | its fine | 00:29 |
| vkmc | flaper87, did you see this? https://www.drupal.org/project/marconi | 00:37 |
| flaper87 | o.0 | 00:38 |
| flaper87 | WHAT ? | 00:38 |
| flaper87 | holy crap | 00:38 |
| vkmc | haha | 00:38 |
| flaper87 | that's soooo exiting | 00:38 |
| vkmc | there is a recent update | 00:39 |
| vkmc | that is what it caught my attention, mostly | 00:39 |
| vkmc | 29 jan 2015 | 00:39 |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Update json schema for API v1_1 https://review.openstack.org/148414 | 00:46 |
| *** csoukup has quit IRC | 00:47 | |
| cpallares | vkmc: Why is it called Marconi? | 00:51 |
| cpallares | vkmc: Ah I see, it's forked :P | 00:52 |
| vkmc | cpallares, yep :) | 00:52 |
| cpallares | That means, it's been forked since it was called Marconi. | 00:52 |
| cpallares | That's cool :D | 00:52 |
| vkmc | exactly | 00:52 |
| vkmc | they are probably waiting for the new kewl features | 00:53 |
| * vkmc tries to think how the tests for websocket should look like | 00:54 | |
| *** sriram has quit IRC | 00:54 | |
| *** flwang has quit IRC | 00:54 | |
| *** sriram has joined #openstack-zaqar | 01:05 | |
| *** flwang has joined #openstack-zaqar | 01:07 | |
| *** akanksha has quit IRC | 01:47 | |
| *** cpallares has quit IRC | 01:57 | |
| *** chandankumar has joined #openstack-zaqar | 02:39 | |
| *** achanda has quit IRC | 02:42 | |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Update json schema for API v1_1 https://review.openstack.org/148414 | 02:52 |
| *** echevemaster has quit IRC | 02:53 | |
| *** amalagon has joined #openstack-zaqar | 03:13 | |
| vkmc | flaper87, flaper87, flaper87 | 03:15 |
| *** flwang has quit IRC | 03:19 | |
| *** chandankumar has quit IRC | 03:30 | |
| *** sriram has quit IRC | 03:32 | |
| *** chandankumar has joined #openstack-zaqar | 03:48 | |
| *** chandankumar has quit IRC | 04:00 | |
| *** chandankumar has joined #openstack-zaqar | 04:13 | |
| *** chandankumar has quit IRC | 04:24 | |
| *** achanda has joined #openstack-zaqar | 04:31 | |
| *** achanda has quit IRC | 05:04 | |
| *** chandankumar has joined #openstack-zaqar | 05:20 | |
| *** achanda has joined #openstack-zaqar | 05:28 | |
| *** reed has quit IRC | 05:30 | |
| *** chandankumar has quit IRC | 05:36 | |
| *** chandankumar has joined #openstack-zaqar | 05:41 | |
| *** chandankumar has quit IRC | 05:52 | |
| *** chandankumar has joined #openstack-zaqar | 06:34 | |
| *** akanksha has joined #openstack-zaqar | 06:43 | |
| *** exploreshaifali has joined #openstack-zaqar | 07:08 | |
| *** achanda has quit IRC | 07:11 | |
| *** achanda has joined #openstack-zaqar | 07:24 | |
| *** achanda has quit IRC | 07:44 | |
| *** akanksha has quit IRC | 10:17 | |
| *** exploreshaifali has quit IRC | 10:56 | |
| *** chandankumar has quit IRC | 11:09 | |
| *** chandankumar has joined #openstack-zaqar | 11:16 | |
| *** exploreshaifali has joined #openstack-zaqar | 11:41 | |
| rsFF | hi vkmc, i noticed that you changed back to in progress, could you tell me what is the normal flow? | 12:41 |
| vkmc | rsFF, hi there! sure | 12:41 |
| vkmc | rsFF, now your patch is under review | 12:41 |
| vkmc | rsFF, when it gets merged, it will be changed automatically | 12:42 |
| vkmc | same thing happens when you set the 'In progress' status | 12:42 |
| vkmc | its set automatically by Gerrit when you submit a fix | 12:42 |
| rsFF | hummm, okay | 12:43 |
| vkmc | I'll review soon :) | 12:43 |
| vkmc | flaper87, have a moment for a few design decisions? | 12:45 |
| flaper87 | vkmc: yes, Mam. | 12:45 |
| vkmc | flaper87, :) so, I'm working on the unit tests for the websockets driver, only for the queue API for now | 12:46 |
| vkmc | flaper87, in websockets, when we do a request, then we get a response that is plain text | 12:47 |
| vkmc | flaper87, we don't have status codes like in WSGI | 12:47 |
| vkmc | wouldn't it be a good idea to add some kind of status codes? otherwise, we would be comparing strings for 'it worked' and 'it didn't work' | 12:47 |
| vkmc | seems error prone | 12:47 |
| *** vipul has quit IRC | 12:48 | |
| *** vipul has joined #openstack-zaqar | 12:48 | |
| flaper87 | mmh, yes. TBH, I thought we were already going to adopt this status codes. :D | 12:50 |
| *** kgriffs|afk is now known as kgriffs | 12:50 | |
| vkmc | flaper87, cool, I'll add a field then | 12:51 |
| vkmc | flaper87, also, we haver never discussed compatibility | 12:55 |
| vkmc | with WSGI | 12:56 |
| vkmc | I think I covered it, but I might be missing something | 12:56 |
| flaper87 | vkmc: mmh, shoot. What are your concerns? | 12:56 |
| vkmc | having two clients, one through wsgi and one through websockets | 12:57 |
| vkmc | given that messages are being stored in the backend in a standard way, it should be fine | 12:58 |
| vkmc | but I haven't tested that, ya know :) | 12:58 |
| *** cpallares has joined #openstack-zaqar | 13:07 | |
| *** cpallares has quit IRC | 13:08 | |
| *** sriram has joined #openstack-zaqar | 13:15 | |
| *** mpanetta has joined #openstack-zaqar | 13:28 | |
| *** dynarro has joined #openstack-zaqar | 13:28 | |
| *** mpanetta has quit IRC | 13:44 | |
| *** mpanetta has joined #openstack-zaqar | 13:44 | |
| *** cpallares has joined #openstack-zaqar | 14:01 | |
| *** chandankumar has quit IRC | 14:09 | |
| *** akanksha has joined #openstack-zaqar | 14:28 | |
| *** csoukup has joined #openstack-zaqar | 14:31 | |
| *** achanda has joined #openstack-zaqar | 14:36 | |
| *** achanda has quit IRC | 14:44 | |
| *** chandankumar has joined #openstack-zaqar | 14:50 | |
| *** amitgandhinz has joined #openstack-zaqar | 15:00 | |
| *** dynarro has quit IRC | 15:00 | |
| *** chandankumar has quit IRC | 15:12 | |
| *** chandankumar has joined #openstack-zaqar | 15:25 | |
| *** chandankumar has quit IRC | 15:33 | |
| openstackgerrit | David Vossel proposed openstack/zaqar: Clean up inconsistent if statement syntax in transport auth https://review.openstack.org/163875 | 15:33 |
| *** reed has joined #openstack-zaqar | 15:34 | |
| *** exploreshaifali has quit IRC | 15:41 | |
| *** flwang has joined #openstack-zaqar | 15:42 | |
| *** flwang has quit IRC | 15:44 | |
| *** amitgandhinz has quit IRC | 15:47 | |
| *** amitgandhinz has joined #openstack-zaqar | 15:51 | |
| *** amitgandhinz has quit IRC | 15:56 | |
| *** chandankumar has joined #openstack-zaqar | 16:11 | |
| *** dynarro has joined #openstack-zaqar | 16:22 | |
| *** chandankumar has quit IRC | 16:38 | |
| *** dynarro has quit IRC | 16:53 | |
| *** kgriffs is now known as kgriffs|afk | 16:56 | |
| *** chandankumar has joined #openstack-zaqar | 17:08 | |
| *** achanda has joined #openstack-zaqar | 17:32 | |
| *** kgriffs|afk is now known as kgriffs | 17:33 | |
| *** amitgandhinz has joined #openstack-zaqar | 17:38 | |
| *** kgriffs is now known as kgriffs|afk | 17:46 | |
| *** exploreshaifali has joined #openstack-zaqar | 17:55 | |
| *** sriram has quit IRC | 18:03 | |
| *** sriram has joined #openstack-zaqar | 18:03 | |
| * vkmc lurks | 18:07 | |
| vkmc | akanksha, how are you doing? | 18:07 |
| akanksha | I am just trying to look into the redis uuid validation bug | 18:08 |
| akanksha | Hi vkmc | 18:08 |
| vkmc | k | 18:08 |
| vkmc | :) | 18:08 |
| akanksha | Umm i had a doubt. | 18:09 |
| akanksha | vkmc, Since I need to write a decorator UUID validation acc. to kgriffs, Should I place it in the zaqar.common.decorators file | 18:10 |
| akanksha | ? | 18:10 |
| vkmc | akanksha, that sounds correct! | 18:10 |
| akanksha | Thats the patter I noticed in general. | 18:10 |
| akanksha | *pattern | 18:10 |
| akanksha | vkmc, I also am not sure about how to test my changes | 18:11 |
| akanksha | vkmc, so lets say once I write the decorator and wrap it around the fuctions that need it, how will I test whether it is working correctly? | 18:12 |
| akanksha | Can you help me out? | 18:12 |
| *** achanda has quit IRC | 18:17 | |
| *** achanda has joined #openstack-zaqar | 18:23 | |
| *** achanda has quit IRC | 18:23 | |
| *** achanda has joined #openstack-zaqar | 18:24 | |
| exploreshaifali | akanksha, once you make all the changes you need first try to start the zaqar server again | 18:31 |
| exploreshaifali | using *zaqar-server -v -d* | 18:31 |
| exploreshaifali | if it starts that means you are on safe side | 18:32 |
| exploreshaifali | then what I do to check tests locally - *tox -epy27* | 18:32 |
| exploreshaifali | it will give result of all tests cases | 18:36 |
| exploreshaifali | if needed fix those who fail | 18:36 |
| akanksha | hmm | 18:36 |
| akanksha | thanks exploreshaifali :) | 18:37 |
| exploreshaifali | akanksha, np at all :) | 18:37 |
| akanksha | exploreshaifali, where are the tests located? | 18:38 |
| exploreshaifali | akanksha, zaqa have two level of testing one is at https://github.com/openstack/zaqar/tree/master/zaqar/tests | 18:39 |
| exploreshaifali | another one is at https://github.com/openstack/zaqar/tree/master/tests | 18:39 |
| exploreshaifali | for mote about zaqar tests read http://www.flaper87.com/post/test-concepts-and-python/ | 18:41 |
| akanksha | Oh okay thanks a lot for those links exploreshaifali :). I want to fix this bug soon and submit a patch. I think I am way behind schedule. I want to apply for outreachy but I am not sure whether I will be able to manage it. | 18:42 |
| exploreshaifali | akanksha, surely you will able to manage it | 18:43 |
| exploreshaifali | relax | 18:43 |
| exploreshaifali | just keep working.... things will work only if you will work :) | 18:43 |
| akanksha | Yeah. Once I get this bug done, after that I'll think about applications :) | 18:43 |
| vkmc | akanksha, you can do it :) | 18:44 |
| exploreshaifali | akanksha, make sure to get reviews for application from mentor before you submit it! | 18:45 |
| *** chandankumar has quit IRC | 19:19 | |
| akanksha | Okay :) | 19:22 |
| akanksha | Thanks for the encouragement vkmc and exploreshaifali. Means a lot to me. :) | 19:23 |
| exploreshaifali | akanksha, keep it up! | 19:23 |
| *** chandankumar has joined #openstack-zaqar | 19:33 | |
| *** openstackgerrit has quit IRC | 19:40 | |
| *** openstackgerrit has joined #openstack-zaqar | 19:40 | |
| *** chandankumar has quit IRC | 19:45 | |
| *** exploreshaifali has quit IRC | 20:02 | |
| *** exploreshaifali has joined #openstack-zaqar | 20:05 | |
| *** chandankumar has joined #openstack-zaqar | 20:16 | |
| *** exploreshaifali has quit IRC | 20:39 | |
| *** chandankumar has quit IRC | 20:49 | |
| *** mpanetta has quit IRC | 21:17 | |
| *** exploreshaifali has joined #openstack-zaqar | 21:26 | |
| flaper87 | exploreshaifali: hey | 21:31 |
| flaper87 | :) | 21:31 |
| flaper87 | how are you doing? | 21:31 |
| flaper87 | how's your patch going? | 21:31 |
| exploreshaifali | flaper87, it is still giving mannnny errors | 21:32 |
| exploreshaifali | flaper87, most are assertion errors | 21:32 |
| exploreshaifali | let me paste one of them | 21:32 |
| flaper87 | exploreshaifali: :( | 21:32 |
| exploreshaifali | flaper87, sorry! | 21:33 |
| *** cpallares has quit IRC | 21:34 | |
| flaper87 | exploreshaifali: don't be sorry, what can I help you with? | 21:34 |
| exploreshaifali | flaper87, http://paste.openstack.org/show/191955/ | 21:34 |
| exploreshaifali | https://github.com/openstack/zaqar/blob/master/zaqar/transport/wsgi/v2_0/queues.py#L35 this queue_controller in argument does not have create method now | 21:37 |
| exploreshaifali | so I am searching from where does this queue_controller comes from? | 21:38 |
| flaper87 | exploreshaifali: mmh, I need to re-review your patch, not sure I follow. | 21:38 |
| flaper87 | flwang1: around? | 21:38 |
| flwang1 | flaper87: yes | 21:39 |
| flwang1 | exploreshaifali: i have some question about your patch | 21:40 |
| flwang1 | you said you're moving the queue controller from data to control, right? | 21:40 |
| flaper87 | flwang1: do you have some mins to work with exploreshaifali on that patch? Since you both need it, it'd be nice if you could join forces | 21:40 |
| exploreshaifali | yes | 21:40 |
| exploreshaifali | flwang1, yes moving queueconroller from data to control plane | 21:41 |
| flwang1 | exploreshaifali: but I saw you're just adding queue to control but didn't remove it from data | 21:43 |
| exploreshaifali | flwang1, yes for now I wnated to make the change work | 21:44 |
| exploreshaifali | flwang1, once it work I will remove queue from datadriver | 21:44 |
| flwang1 | exploreshaifali: but the jenkins gate is always failed, do you know why? | 21:44 |
| flwang1 | does it work in your local env? | 21:44 |
| exploreshaifali | no it is not | 21:45 |
| exploreshaifali | flwang1, http://paste.openstack.org/show/191955/ this is the error I am hitting right now | 21:45 |
| exploreshaifali | https://github.com/openstack/zaqar/blob/master/zaqar/transport/wsgi/v2_0/queues.py#L35 this queue_controller in argument does not have create method now | 21:46 |
| exploreshaifali | but from where this queue_controller is coming? | 21:46 |
| flwang1 | exploreshaifali: ok, if that's the case, I will download the patch and running it on my local env | 21:48 |
| flwang1 | then would you mind me submitting patch set on your patch? | 21:49 |
| exploreshaifali | flwang1, I won't mind, but I will be greatful to you more if you can guide me to work on this | 21:49 |
| flwang1 | exploreshaifali: sure, but for now, I have no idea, i need to investigate before tell you more :) | 21:50 |
| exploreshaifali | flwang1, yes yes, no issues at all :) | 21:50 |
| exploreshaifali | flwang1, as of now 3 errors are coming | 21:51 |
| exploreshaifali | flwang1, let me submit the latest changes | 21:51 |
| exploreshaifali | flwang1, do you want me to remove queue from datadriver now in new patchset? | 21:51 |
| flwang1 | exploreshaifali: it doesn't matter, I asked just because I need to understand what you're doing :) | 21:52 |
| exploreshaifali | okay! | 21:52 |
| openstackgerrit | Shaifali Agrawal proposed openstack/zaqar: Removing QueueController from data to control plane https://review.openstack.org/144340 | 21:56 |
| exploreshaifali | flwang1, ^ | 21:56 |
| flwang1 | exploreshaifali: cool, cheers | 22:00 |
| exploreshaifali | :D | 22:00 |
| *** amitgandhinz has quit IRC | 22:07 | |
| *** kgriffs|afk is now known as kgriffs | 22:08 | |
| openstackgerrit | Merged openstack/zaqar: Clean up inconsistent if statement syntax in transport auth https://review.openstack.org/163875 | 22:34 |
| *** csoukup has quit IRC | 22:35 | |
| *** sriram has quit IRC | 22:39 | |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Adds message processing to WebSockets driver https://review.openstack.org/144803 | 22:42 |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Update json schema for API v1_1 https://review.openstack.org/148414 | 22:42 |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Adds a status code field to the Response https://review.openstack.org/164007 | 22:42 |
| openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar: Adds a representation for the Request and Response objects https://review.openstack.org/164008 | 22:42 |
| *** achanda has quit IRC | 22:52 | |
| *** achanda has joined #openstack-zaqar | 22:53 | |
| *** achanda_ has joined #openstack-zaqar | 22:56 | |
| *** achanda_ has quit IRC | 22:56 | |
| *** achanda_ has joined #openstack-zaqar | 22:56 | |
| *** akanksha has quit IRC | 22:57 | |
| *** achanda has quit IRC | 22:57 | |
| *** kgriffs is now known as kgriffs|afk | 23:08 | |
| *** achanda has joined #openstack-zaqar | 23:08 | |
| *** achanda_ has quit IRC | 23:11 | |
| *** exploreshaifali has quit IRC | 23:21 | |
| *** achanda has quit IRC | 23:32 | |
| *** achanda has joined #openstack-zaqar | 23:32 | |
| *** reed has quit IRC | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!