Friday, 2016-12-16

*** harlowja has quit IRC00:06
*** hidekazu has joined #openstack-watcher00:12
*** harlowja has joined #openstack-watcher00:34
*** harlowja has quit IRC01:25
openstackgerritlicanwei proposed openstack/watcher: check the state of action plan  https://review.openstack.org/39138303:11
*** thorst has joined #openstack-watcher04:18
*** thorst has quit IRC04:45
*** thorst has joined #openstack-watcher04:49
*** thorst has quit IRC04:57
*** diga has joined #openstack-watcher05:27
*** thorst has joined #openstack-watcher05:44
*** thorst has quit IRC05:52
*** jimbaker has quit IRC06:22
*** jimbaker has joined #openstack-watcher06:26
*** thorst has joined #openstack-watcher06:39
*** thorst has quit IRC06:46
openstackgerritlicanwei proposed openstack/python-watcherclient: use 'default' instead of None  https://review.openstack.org/41166107:07
*** alexchadin has joined #openstack-watcher07:30
*** thorst has joined #openstack-watcher07:38
*** thorst has quit IRC07:44
*** alexchadin has quit IRC07:50
*** dtardivel has joined #openstack-watcher08:14
*** thorst has joined #openstack-watcher08:39
*** diga has quit IRC08:39
*** diga has joined #openstack-watcher08:40
*** danpawlik has quit IRC08:43
*** thorst has quit IRC08:44
openstackgerritMerged openstack/watcher: Function call pass parameter error  https://review.openstack.org/41001008:47
openstackgerritOpenStack Proposal Bot proposed openstack/watcher: Updated from global requirements  https://review.openstack.org/41109109:10
openstackgerritDavid TARDIVEL proposed openstack/watcher: Fix bad CDMC update on reception of service.update  https://review.openstack.org/41172009:14
*** thorst has joined #openstack-watcher09:39
*** exploreshaifali has joined #openstack-watcher09:40
*** diga has quit IRC09:41
*** thorst has quit IRC09:44
openstackgerritMerged openstack/python-watcherclient: Fix TOKENID format which should without dashed  https://review.openstack.org/40785209:52
openstackgerritMerged openstack/watcher: Repair log parameter error  https://review.openstack.org/40790109:55
*** alexchadin has joined #openstack-watcher09:56
alexchadindtardivel: hi09:56
dtardivelalexchadin: hi Alex09:57
alexchadindtardivel: I would like to discuss auto_trigger support with you09:58
dtardivelalexchadin: yep09:58
alexchadin"In your code, you filter your list of action plan with a audit.uuid. That means that your code only targeted continuous audit." why?09:59
dtardivelI ran a test yesterday on my devstack. I executed first an action plan, built from an audit_uuid1, and I added a break point to remain this action plan on ONGOING state. After that, I started again an new audit, audit_uuid2 to check if the action plan computed by this one, will be move to SUPERSEDED state.10:01
dtardivelas explain in your spec (I understood that we don't want to execute 2 action plan at the same time)10:02
dtardiveland in fact, the second action plan was set in RECOMMENDED state10:02
dtardivelbecause you use audit.uuid in your fileter10:03
dtardiveldo an continuous audit use the same audit.uuid ?10:05
alexchadinI thought, that superseded state should be set on the new action plan for audit_uuid1. for example, if we run continuous audit and its first actionplan is still ongoing, the second actionplan should be set to superseded.10:06
dtardivelit is not what you wrote in your spec :)10:07
alexchadinhm, so we need to set superseded on every actionplan for every audits, if at least one actionplan is in ongoing state10:08
alexchadinon every new actionplan*10:09
dtardivelWhat will happen if another action plan, computed by another audit, is already on-going ? You will have 2 action plans running at the time. from my point of view, we should avoid such use case for now10:09
alexchadinI understood you. I made my changes in context of one audit, not all:)10:10
alexchadinthat's why I filter by uuid10:10
alexchadinok, I will think about it10:10
dtardivelfor me, your spec id clear enought: If an action plan is running (built by any previous audit), the auto-triggered one should be cancelled10:11
alexchadinyeah10:11
alexchadinso10:12
alexchadinseems that we just need to remove uuid from filters10:12
dtardivelyep10:12
dtardivelalexchadin: I will push a patchset to be able to set auto-trigger from dashboard10:14
alexchadindtardivel: cool10:14
alexchadindtardivel: I've fixed functional tests for client, now there are no resources left after running all the tests10:15
alexchadindtardivel: one more question: do we need to check ongoing action plans even if new audit isn't auto_triggered? I think yes10:16
dtardivelalexchadin: yes i saw it. cool. thx. I will validate your last patchset this afternoon10:16
*** openstackgerrit has quit IRC10:18
dtardivelYes why not. So if an admin start 2 action plans, the second one will be set to superseded state ?10:19
dtardivelwith a warning message ?10:19
alexchadinyeap, even if they was created by auto_triggered and not auto_triggered audits10:19
dtardivel+110:19
alexchadincool10:20
*** thorst has joined #openstack-watcher10:33
*** exploreshaifali has quit IRC10:36
*** thorst has quit IRC10:41
*** alexchadin has quit IRC10:51
*** alexchadin has joined #openstack-watcher11:02
*** hidekazu has quit IRC11:05
*** openstackgerrit has joined #openstack-watcher11:10
openstackgerritAlexander Chadin proposed openstack/watcher: Add auto_trigger support to watcher  https://review.openstack.org/40371811:10
alexchadindtardivel: updated auto_trigger11:12
openstackgerritAlexander Chadin proposed openstack/python-watcherclient: Add functional tests to watcherclient  https://review.openstack.org/38918111:16
*** thorst has joined #openstack-watcher11:29
*** thorst has quit IRC11:36
openstackgerritAlexander Chadin proposed openstack/python-watcherclient: Add auto_trigger support  https://review.openstack.org/40371611:49
openstackgerritAlexander Chadin proposed openstack/watcher-specs: Ignore all *.DS_Store files  https://review.openstack.org/41062012:15
*** thorst has joined #openstack-watcher12:25
*** alexchadin has quit IRC12:26
*** alexchadin has joined #openstack-watcher12:26
*** thorst has quit IRC12:33
*** alexchadin has quit IRC12:39
*** alexchadin has joined #openstack-watcher12:39
*** alexchadin has quit IRC12:39
*** alexchadin has joined #openstack-watcher12:40
*** thorst has joined #openstack-watcher12:49
*** thorst has quit IRC12:56
*** thorst has joined #openstack-watcher12:57
*** thorst has quit IRC13:05
*** alexchadin has quit IRC13:11
*** alexchadin has joined #openstack-watcher13:11
*** alexchadin has quit IRC13:15
openstackgerritOpenStack Proposal Bot proposed openstack/watcher: Updated from global requirements  https://review.openstack.org/41109113:49
openstackgerritDavid TARDIVEL proposed openstack/watcher-dashboard: Add auto_trigger option in Audit creation form  https://review.openstack.org/41183214:14
openstackgerritDavid TARDIVEL proposed openstack/watcher-dashboard: 'next_uuid' Action field is replaced by 'parents'  https://review.openstack.org/41136114:16
*** edleafe is now known as figleaf14:18
*** thorst_ has joined #openstack-watcher14:41
*** thorst_ has quit IRC14:46
*** thorst_ has joined #openstack-watcher14:51
*** thorst_ has quit IRC15:14
*** thorst_ has joined #openstack-watcher15:35
*** thorst_ has quit IRC15:46
*** thorst_ has joined #openstack-watcher15:57
*** thorst_ has quit IRC16:01
pshedimbdtardivel, Thank you for all the reviews and rebasing and merging the code for centralizing config options. :)16:03
openstackgerritMerged openstack/watcher: Updated from global requirements  https://review.openstack.org/41109116:05
*** alexchadin has joined #openstack-watcher16:06
*** alexchadin has quit IRC16:09
*** alexchad_ has joined #openstack-watcher16:10
openstackgerritMerged openstack/python-watcherclient: Replace six.iteritems() with .items()  https://review.openstack.org/40892416:34
*** alexchad_ has quit IRC16:36
openstackgerritMerged openstack/watcher: remove unused log  https://review.openstack.org/41055616:38
openstackgerritMerged openstack/watcher: Improve the instruction of vm_workload_consolidation.  https://review.openstack.org/40792916:38
openstackgerritDavid TARDIVEL proposed openstack/python-watcherclient: Add auto_trigger support  https://review.openstack.org/40371617:02
openstackgerritMerged openstack/watcher: Fix method name in doc/source/dev/plugin/action-plugin.rst  https://review.openstack.org/40788117:02
openstackgerritMerged openstack/watcher: Fix some incorrect description in doc.  https://review.openstack.org/40503817:06
*** lamt has joined #openstack-watcher17:34
*** lamt has quit IRC18:00
*** hanrong has quit IRC18:12
*** hanrong has joined #openstack-watcher18:13
*** thorst_ has joined #openstack-watcher19:20
*** dtardivel has quit IRC19:24
*** thorst_ has quit IRC19:27
*** lamt has joined #openstack-watcher19:36
*** lamt has quit IRC19:48
*** lamt has joined #openstack-watcher19:50
*** lamt has quit IRC21:16
*** lamt has joined #openstack-watcher21:20
*** thorst_ has joined #openstack-watcher21:26
*** thorst_ has quit IRC21:35
*** thorst_ has joined #openstack-watcher21:36
*** figleaf is now known as edleafe22:29
*** lamt has quit IRC23:37

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!