*** harlowja has quit IRC | 00:06 | |
*** hidekazu has joined #openstack-watcher | 00:12 | |
*** harlowja has joined #openstack-watcher | 00:34 | |
*** harlowja has quit IRC | 01:25 | |
openstackgerrit | licanwei proposed openstack/watcher: check the state of action plan https://review.openstack.org/391383 | 03:11 |
---|---|---|
*** thorst has joined #openstack-watcher | 04:18 | |
*** thorst has quit IRC | 04:45 | |
*** thorst has joined #openstack-watcher | 04:49 | |
*** thorst has quit IRC | 04:57 | |
*** diga has joined #openstack-watcher | 05:27 | |
*** thorst has joined #openstack-watcher | 05:44 | |
*** thorst has quit IRC | 05:52 | |
*** jimbaker has quit IRC | 06:22 | |
*** jimbaker has joined #openstack-watcher | 06:26 | |
*** thorst has joined #openstack-watcher | 06:39 | |
*** thorst has quit IRC | 06:46 | |
openstackgerrit | licanwei proposed openstack/python-watcherclient: use 'default' instead of None https://review.openstack.org/411661 | 07:07 |
*** alexchadin has joined #openstack-watcher | 07:30 | |
*** thorst has joined #openstack-watcher | 07:38 | |
*** thorst has quit IRC | 07:44 | |
*** alexchadin has quit IRC | 07:50 | |
*** dtardivel has joined #openstack-watcher | 08:14 | |
*** thorst has joined #openstack-watcher | 08:39 | |
*** diga has quit IRC | 08:39 | |
*** diga has joined #openstack-watcher | 08:40 | |
*** danpawlik has quit IRC | 08:43 | |
*** thorst has quit IRC | 08:44 | |
openstackgerrit | Merged openstack/watcher: Function call pass parameter error https://review.openstack.org/410010 | 08:47 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/watcher: Updated from global requirements https://review.openstack.org/411091 | 09:10 |
openstackgerrit | David TARDIVEL proposed openstack/watcher: Fix bad CDMC update on reception of service.update https://review.openstack.org/411720 | 09:14 |
*** thorst has joined #openstack-watcher | 09:39 | |
*** exploreshaifali has joined #openstack-watcher | 09:40 | |
*** diga has quit IRC | 09:41 | |
*** thorst has quit IRC | 09:44 | |
openstackgerrit | Merged openstack/python-watcherclient: Fix TOKENID format which should without dashed https://review.openstack.org/407852 | 09:52 |
openstackgerrit | Merged openstack/watcher: Repair log parameter error https://review.openstack.org/407901 | 09:55 |
*** alexchadin has joined #openstack-watcher | 09:56 | |
alexchadin | dtardivel: hi | 09:56 |
dtardivel | alexchadin: hi Alex | 09:57 |
alexchadin | dtardivel: I would like to discuss auto_trigger support with you | 09:58 |
dtardivel | alexchadin: yep | 09:58 |
alexchadin | "In your code, you filter your list of action plan with a audit.uuid. That means that your code only targeted continuous audit." why? | 09:59 |
dtardivel | I ran a test yesterday on my devstack. I executed first an action plan, built from an audit_uuid1, and I added a break point to remain this action plan on ONGOING state. After that, I started again an new audit, audit_uuid2 to check if the action plan computed by this one, will be move to SUPERSEDED state. | 10:01 |
dtardivel | as explain in your spec (I understood that we don't want to execute 2 action plan at the same time) | 10:02 |
dtardivel | and in fact, the second action plan was set in RECOMMENDED state | 10:02 |
dtardivel | because you use audit.uuid in your fileter | 10:03 |
dtardivel | do an continuous audit use the same audit.uuid ? | 10:05 |
alexchadin | I thought, that superseded state should be set on the new action plan for audit_uuid1. for example, if we run continuous audit and its first actionplan is still ongoing, the second actionplan should be set to superseded. | 10:06 |
dtardivel | it is not what you wrote in your spec :) | 10:07 |
alexchadin | hm, so we need to set superseded on every actionplan for every audits, if at least one actionplan is in ongoing state | 10:08 |
alexchadin | on every new actionplan* | 10:09 |
dtardivel | What will happen if another action plan, computed by another audit, is already on-going ? You will have 2 action plans running at the time. from my point of view, we should avoid such use case for now | 10:09 |
alexchadin | I understood you. I made my changes in context of one audit, not all:) | 10:10 |
alexchadin | that's why I filter by uuid | 10:10 |
alexchadin | ok, I will think about it | 10:10 |
dtardivel | for me, your spec id clear enought: If an action plan is running (built by any previous audit), the auto-triggered one should be cancelled | 10:11 |
alexchadin | yeah | 10:11 |
alexchadin | so | 10:12 |
alexchadin | seems that we just need to remove uuid from filters | 10:12 |
dtardivel | yep | 10:12 |
dtardivel | alexchadin: I will push a patchset to be able to set auto-trigger from dashboard | 10:14 |
alexchadin | dtardivel: cool | 10:14 |
alexchadin | dtardivel: I've fixed functional tests for client, now there are no resources left after running all the tests | 10:15 |
alexchadin | dtardivel: one more question: do we need to check ongoing action plans even if new audit isn't auto_triggered? I think yes | 10:16 |
dtardivel | alexchadin: yes i saw it. cool. thx. I will validate your last patchset this afternoon | 10:16 |
*** openstackgerrit has quit IRC | 10:18 | |
dtardivel | Yes why not. So if an admin start 2 action plans, the second one will be set to superseded state ? | 10:19 |
dtardivel | with a warning message ? | 10:19 |
alexchadin | yeap, even if they was created by auto_triggered and not auto_triggered audits | 10:19 |
dtardivel | +1 | 10:19 |
alexchadin | cool | 10:20 |
*** thorst has joined #openstack-watcher | 10:33 | |
*** exploreshaifali has quit IRC | 10:36 | |
*** thorst has quit IRC | 10:41 | |
*** alexchadin has quit IRC | 10:51 | |
*** alexchadin has joined #openstack-watcher | 11:02 | |
*** hidekazu has quit IRC | 11:05 | |
*** openstackgerrit has joined #openstack-watcher | 11:10 | |
openstackgerrit | Alexander Chadin proposed openstack/watcher: Add auto_trigger support to watcher https://review.openstack.org/403718 | 11:10 |
alexchadin | dtardivel: updated auto_trigger | 11:12 |
openstackgerrit | Alexander Chadin proposed openstack/python-watcherclient: Add functional tests to watcherclient https://review.openstack.org/389181 | 11:16 |
*** thorst has joined #openstack-watcher | 11:29 | |
*** thorst has quit IRC | 11:36 | |
openstackgerrit | Alexander Chadin proposed openstack/python-watcherclient: Add auto_trigger support https://review.openstack.org/403716 | 11:49 |
openstackgerrit | Alexander Chadin proposed openstack/watcher-specs: Ignore all *.DS_Store files https://review.openstack.org/410620 | 12:15 |
*** thorst has joined #openstack-watcher | 12:25 | |
*** alexchadin has quit IRC | 12:26 | |
*** alexchadin has joined #openstack-watcher | 12:26 | |
*** thorst has quit IRC | 12:33 | |
*** alexchadin has quit IRC | 12:39 | |
*** alexchadin has joined #openstack-watcher | 12:39 | |
*** alexchadin has quit IRC | 12:39 | |
*** alexchadin has joined #openstack-watcher | 12:40 | |
*** thorst has joined #openstack-watcher | 12:49 | |
*** thorst has quit IRC | 12:56 | |
*** thorst has joined #openstack-watcher | 12:57 | |
*** thorst has quit IRC | 13:05 | |
*** alexchadin has quit IRC | 13:11 | |
*** alexchadin has joined #openstack-watcher | 13:11 | |
*** alexchadin has quit IRC | 13:15 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/watcher: Updated from global requirements https://review.openstack.org/411091 | 13:49 |
openstackgerrit | David TARDIVEL proposed openstack/watcher-dashboard: Add auto_trigger option in Audit creation form https://review.openstack.org/411832 | 14:14 |
openstackgerrit | David TARDIVEL proposed openstack/watcher-dashboard: 'next_uuid' Action field is replaced by 'parents' https://review.openstack.org/411361 | 14:16 |
*** edleafe is now known as figleaf | 14:18 | |
*** thorst_ has joined #openstack-watcher | 14:41 | |
*** thorst_ has quit IRC | 14:46 | |
*** thorst_ has joined #openstack-watcher | 14:51 | |
*** thorst_ has quit IRC | 15:14 | |
*** thorst_ has joined #openstack-watcher | 15:35 | |
*** thorst_ has quit IRC | 15:46 | |
*** thorst_ has joined #openstack-watcher | 15:57 | |
*** thorst_ has quit IRC | 16:01 | |
pshedimb | dtardivel, Thank you for all the reviews and rebasing and merging the code for centralizing config options. :) | 16:03 |
openstackgerrit | Merged openstack/watcher: Updated from global requirements https://review.openstack.org/411091 | 16:05 |
*** alexchadin has joined #openstack-watcher | 16:06 | |
*** alexchadin has quit IRC | 16:09 | |
*** alexchad_ has joined #openstack-watcher | 16:10 | |
openstackgerrit | Merged openstack/python-watcherclient: Replace six.iteritems() with .items() https://review.openstack.org/408924 | 16:34 |
*** alexchad_ has quit IRC | 16:36 | |
openstackgerrit | Merged openstack/watcher: remove unused log https://review.openstack.org/410556 | 16:38 |
openstackgerrit | Merged openstack/watcher: Improve the instruction of vm_workload_consolidation. https://review.openstack.org/407929 | 16:38 |
openstackgerrit | David TARDIVEL proposed openstack/python-watcherclient: Add auto_trigger support https://review.openstack.org/403716 | 17:02 |
openstackgerrit | Merged openstack/watcher: Fix method name in doc/source/dev/plugin/action-plugin.rst https://review.openstack.org/407881 | 17:02 |
openstackgerrit | Merged openstack/watcher: Fix some incorrect description in doc. https://review.openstack.org/405038 | 17:06 |
*** lamt has joined #openstack-watcher | 17:34 | |
*** lamt has quit IRC | 18:00 | |
*** hanrong has quit IRC | 18:12 | |
*** hanrong has joined #openstack-watcher | 18:13 | |
*** thorst_ has joined #openstack-watcher | 19:20 | |
*** dtardivel has quit IRC | 19:24 | |
*** thorst_ has quit IRC | 19:27 | |
*** lamt has joined #openstack-watcher | 19:36 | |
*** lamt has quit IRC | 19:48 | |
*** lamt has joined #openstack-watcher | 19:50 | |
*** lamt has quit IRC | 21:16 | |
*** lamt has joined #openstack-watcher | 21:20 | |
*** thorst_ has joined #openstack-watcher | 21:26 | |
*** thorst_ has quit IRC | 21:35 | |
*** thorst_ has joined #openstack-watcher | 21:36 | |
*** figleaf is now known as edleafe | 22:29 | |
*** lamt has quit IRC | 23:37 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!