*** lamt has quit IRC | 00:35 | |
*** dtardivel has quit IRC | 01:04 | |
*** harlowja has quit IRC | 03:03 | |
*** atuly has joined #openstack-watcher | 03:05 | |
*** atuly has quit IRC | 03:33 | |
*** atuly has joined #openstack-watcher | 03:33 | |
*** thorst_ has joined #openstack-watcher | 03:43 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/watcher: Updated from global requirements https://review.openstack.org/411091 | 03:57 |
---|---|---|
*** atuly has quit IRC | 04:09 | |
*** thorst_ has quit IRC | 04:31 | |
*** thorst_ has joined #openstack-watcher | 04:32 | |
*** thorst_ has quit IRC | 04:40 | |
*** thorst_ has joined #openstack-watcher | 05:10 | |
*** thorst_ has quit IRC | 05:18 | |
*** noama has quit IRC | 05:28 | |
*** noama has joined #openstack-watcher | 05:28 | |
*** thorst_ has joined #openstack-watcher | 06:06 | |
*** thorst_ has quit IRC | 06:15 | |
*** thorst_ has joined #openstack-watcher | 07:01 | |
*** thorst_ has quit IRC | 07:09 | |
openstackgerrit | licanwei proposed openstack/python-watcherclient: too many digits after the decimal point https://review.openstack.org/411147 | 07:35 |
*** thorst_ has joined #openstack-watcher | 07:41 | |
*** thorst_ has quit IRC | 07:49 | |
*** atuly has joined #openstack-watcher | 08:10 | |
*** thorst_ has joined #openstack-watcher | 08:35 | |
*** alexchadin has joined #openstack-watcher | 08:37 | |
openstackgerrit | Antoine Cabot proposed openstack/python-watcherclient: Remove readme reference because of sphinx error https://review.openstack.org/411169 | 08:43 |
*** thorst_ has quit IRC | 08:43 | |
openstackgerrit | David TARDIVEL proposed openstack/watcher-dashboard: Moved README.rst content to installation.rst doc https://review.openstack.org/411176 | 09:01 |
openstackgerrit | Merged openstack/python-watcherclient: Remove readme reference because of sphinx error https://review.openstack.org/411169 | 09:04 |
openstackgerrit | David TARDIVEL proposed openstack/python-watcherclient: Support parents field along with planner changes https://review.openstack.org/409126 | 09:08 |
openstackgerrit | David TARDIVEL proposed openstack/python-watcherclient: too many digits after the decimal point https://review.openstack.org/411147 | 09:08 |
openstackgerrit | Merged openstack/watcher-dashboard: Moved README.rst content to installation.rst doc https://review.openstack.org/411176 | 09:13 |
openstackgerrit | Alexander Chadin proposed openstack/watcher-specs: Add improvements to the planner and workflow mechanisms https://review.openstack.org/385871 | 09:14 |
*** thorst_ has joined #openstack-watcher | 09:30 | |
openstackgerrit | David TARDIVEL proposed openstack/watcher-dashboard: Show team and repo badges on README https://review.openstack.org/402973 | 09:31 |
*** thorst_ has quit IRC | 09:38 | |
openstackgerrit | Merged openstack/watcher-dashboard: Show team and repo badges on README https://review.openstack.org/402973 | 09:45 |
*** exploreshaifali has joined #openstack-watcher | 10:09 | |
*** openstackgerrit has quit IRC | 10:18 | |
*** alexchad_ has joined #openstack-watcher | 10:21 | |
*** alexchadin has quit IRC | 10:21 | |
*** thorst_ has joined #openstack-watcher | 10:25 | |
*** thorst_ has quit IRC | 10:32 | |
*** hidekazu has quit IRC | 10:36 | |
*** exploreshaifali has quit IRC | 10:38 | |
alexchad_ | acabot: could you please invite David here? | 10:44 |
*** openstackgerrit has joined #openstack-watcher | 10:45 | |
openstackgerrit | Alexander Chadin proposed openstack/python-watcherclient: Add functional tests to watcherclient https://review.openstack.org/389181 | 10:45 |
acabot | alexchad_ : done | 10:46 |
*** dtardivel has joined #openstack-watcher | 10:46 | |
*** alexchad_ is now known as alexchadin | 10:46 | |
alexchadin | acabot: thank you! | 10:47 |
alexchadin | dtardivel: hi! | 10:47 |
dtardivel | alexchadin: hi | 10:47 |
alexchadin | dtardivel: I will fix tempest tests now, but about this note "Moreover, parents field is not set in db" | 10:47 |
alexchadin | dtardivel: they should be linked | 10:48 |
alexchadin | shouldn't | 10:48 |
dtardivel | ok, I will fix dashboard issue if you want | 10:48 |
alexchadin | dtardivel: migrate and change_nova_service_state are independent | 10:48 |
alexchadin | to each other | 10:49 |
dtardivel | I ran a basic-consolidation on my devstack with 2 instances deployed. The computed action are corrected, by not linked | 10:49 |
openstackgerrit | Antoine Cabot proposed openstack/watcher-specs: Remove readme reference to fix Sphinx https://review.openstack.org/411229 | 10:49 |
alexchadin | dtardivel: it would be great since I'm not good with Django:) | 10:49 |
dtardivel | alexchadin: parents is set to [] on both actions | 10:49 |
alexchadin | dtardivel: yes, it is normal use case | 10:49 |
alexchadin | dtardivel: these two actions will be run in parallel | 10:50 |
dtardivel | whaooou, I thought this feature will be implemented later | 10:51 |
alexchadin | dtardivel: They should be, but I didn't make any changes to applier yet | 10:52 |
alexchadin | dtardivel: Applier will run these actions in sequence for now | 10:52 |
alexchadin | dtardivel: do you remember, that we divided BP by two? | 10:53 |
dtardivel | yes I remenber | 10:53 |
dtardivel | one thing, when I run the action plan, I see actions are executed in chained way, but in opposite way | 10:57 |
dtardivel | migration are triggered before compute state updates. And before your patchset, it was the opposite | 10:58 |
atuly | hi alexchadin | 10:59 |
alexchadin | hi atuly | 11:00 |
alexchadin | dtardivel: I will be back in 5 minutes | 11:00 |
atuly | I was reviewing | 11:00 |
atuly | https://review.openstack.org/#/c/406991/7/watcher/decision_engine/planner/default.py | 11:00 |
atuly | one basic question : weights_dict = { | 11:00 |
atuly | 'turn_host_to_acpi_s3_state': 0, | 11:00 |
atuly | 'resize': 1, | 11:00 |
atuly | 'migrate': 2, | 11:00 |
atuly | 'sleep': 3, | 11:00 |
atuly | 'change_nova_service_state': 4, | 11:00 |
atuly | 'nop': 5, | 11:00 |
atuly | can we some meaning name for nop | 11:00 |
atuly | i guess it means no_operational | 11:01 |
atuly | correct me if wrong ? | 11:01 |
alexchadin | atuly: I think, you need to ask about it vincentfrancoise or jed56, cause when I came to watcher team it was already named that way:) I think you are correct | 11:04 |
atuly | aah | 11:05 |
atuly | anyways if it not operator dependent and only specific within the file we may continue to use it as it is. | 11:07 |
alexchadin | dtardivel: ping | 11:08 |
*** thorst_ has joined #openstack-watcher | 11:19 | |
alexchadin | dtardivel: now actions are adding to database in weight order | 11:23 |
*** thorst_ has quit IRC | 11:27 | |
openstackgerrit | Kevin Mullery proposed openstack/watcher: Graph cluster model implementation https://review.openstack.org/362730 | 11:28 |
*** chrisspencer has quit IRC | 12:06 | |
*** chrisspencer has joined #openstack-watcher | 12:08 | |
*** thorst_ has joined #openstack-watcher | 12:14 | |
*** thorst_ has quit IRC | 12:21 | |
openstackgerrit | Alexander Chadin proposed openstack/watcher: New default planner https://review.openstack.org/406991 | 12:55 |
*** alexchadin has quit IRC | 12:56 | |
*** thorst_ has joined #openstack-watcher | 13:19 | |
dtardivel | atuly: nop means 'no operation'. it is just used for the dummy strategy for training | 13:47 |
*** lamt has joined #openstack-watcher | 14:10 | |
openstackgerrit | David TARDIVEL proposed openstack/python-watcherclient: Fix TOKENID format which should without dashed https://review.openstack.org/407852 | 14:40 |
openstackgerrit | David TARDIVEL proposed openstack/watcher-dashboard: 'next_uuid' Action field is replaced by 'parents' https://review.openstack.org/411361 | 14:58 |
*** alexchadin has joined #openstack-watcher | 15:11 | |
alexchadin | dtardivel: ping | 15:14 |
dtardivel | alexchadin: yep | 15:14 |
alexchadin | dtardivel: I've just seen your response, thank you | 15:14 |
dtardivel | is it clear enough ? | 15:14 |
alexchadin | I agree that it is static implementation. But we need to control order of every action type and its pre-requisites/post-reqs. for example, change_state type is not related to migrate type. They can be done in parallel | 15:16 |
alexchadin | Maybe, we can implement action types as plugins | 15:17 |
dtardivel | yes I understand, but i would prefer (and vincentfrancoise as well), we treat with // in another spec/changeset. | 15:18 |
alexchadin | BTW, turn_host_to_acpi_s3_state requires all resize/migrate actions related to the same host to be done before launching | 15:18 |
dtardivel | The general question: how can we set affinity/anti-affinyty rules between actions ? | 15:19 |
alexchadin | hm | 15:19 |
dtardivel | I kwow beginning of // constraints has been introduced in your spec, but I think we should address it in a generic way, including how to handle new action plugin dynamically .... and I have not the response today :) | 15:21 |
alexchadin | why not to support it in static way now? we can create new BP if someone wants to make it pluggable | 15:23 |
alexchadin | if we make it static now, we can implement parallel executing faster | 15:24 |
dtardivel | My concern in this case, is we will broke the possibility to extend Actions by plugin. | 15:26 |
dtardivel | we ask to acabot .... | 15:26 |
alexchadin | actions are something that appear rarely, watcher team may discuss new action impact | 15:27 |
alexchadin | I totally agree that we need pluggable actions | 15:27 |
alexchadin | but we can introduce it later, once we have some thoughts about it | 15:27 |
dtardivel | action are already pluggable today :) | 15:27 |
dtardivel | alexchadin: I have again an issue with your implementation, if I run a basic consolidation with or without your patch. Applier does not run action in the same way | 15:29 |
dtardivel | it's a opposite way with your patch, and it is not normal | 15:30 |
*** alexchadin has quit IRC | 15:30 | |
*** alexchadin has joined #openstack-watcher | 15:30 | |
alexchadin | sorry for disconnecting | 15:30 |
alexchadin | could you give me some logs? | 15:31 |
dtardivel | from what ? the DE ? | 15:31 |
alexchadin | yes | 15:32 |
alexchadin | you say that actions run in other order? | 15:33 |
alexchadin | in comparison with old version | 15:34 |
dtardivel | as explain in my comment, on devstack, a basic consolidation (b4 your patch) build an action plan with 1. change State, and 2 Migrate. And the applier runs these actions in this order. | 15:34 |
dtardivel | With your patch, the built action plan is composed by a change_state and a migrations actions, without parents. But Applier runs, in first, the migrate action and after the change_state action | 15:35 |
alexchadin | oh | 15:37 |
alexchadin | I see the reason | 15:37 |
dtardivel | did you remember we found a bug in applier side, where this one didn't read 'next' field to build the taskflow workflow ? | 15:38 |
alexchadin | yes | 15:38 |
alexchadin | Applier gets list of actions | 15:38 |
dtardivel | applier take the actions in the order theses ones have been save in db | 15:38 |
alexchadin | yeah | 15:38 |
dtardivel | and with your patch, migrate is the first action saved in db :) | 15:38 |
dtardivel | https://www.irccloud.com/pastebin/OzqXTBUW/ | 15:39 |
alexchadin | and it is strange | 15:39 |
alexchadin | since we have this one: scheduled = sorted(to_schedule, key=lambda x: (x[0]), reverse=True) | 15:39 |
dtardivel | yes but your update the weights as weel no ? | 15:39 |
alexchadin | so, probably change_nova_service_state should be the first one | 15:39 |
dtardivel | as well | 15:39 |
alexchadin | let me write new unit test:) | 15:42 |
dtardivel | as the graph is built by 'parents' link, we should find the first entry action of the graph (the one(s) that has(ve) no parent(s)). is it not the algo of applier ? | 15:43 |
dtardivel | vincentfrancoise will come back next monday. Will you at office next week as well ? | 15:44 |
alexchadin | dtardivel: yes, I will. take a look at this pseudo: http://pastebin.com/2q13UxaU | 15:44 |
alexchadin | dtardivel: It is general algorithm of executing actions in applier | 15:45 |
dtardivel | ok, so in my use case, I have no parent for both actions | 15:47 |
dtardivel | so no link in mainflow | 15:48 |
alexchadin | so, they will be executed at once | 15:49 |
dtardivel | alexchadin: I can not in fact test // action on devstack. I have only 2 actions in my action plans | 15:49 |
dtardivel | I will try to test in within our OS infra in our lab. | 15:49 |
alexchadin | great:) | 15:50 |
dtardivel | I'm reviewing your last patch on auto trigger. It's look ok for me, I need to test it quickly on my devstack | 15:51 |
alexchadin | If I'm not online, write a message on gerrit | 15:52 |
dtardivel | yep | 15:52 |
alexchadin | thank you so much:) | 15:52 |
dtardivel | you're welcome | 15:52 |
*** thorst_ has quit IRC | 15:58 | |
*** thorst_ has joined #openstack-watcher | 16:02 | |
openstackgerrit | Merged openstack/watcher-specs: Remove readme reference to fix Sphinx https://review.openstack.org/411229 | 16:08 |
openstackgerrit | David TARDIVEL proposed openstack/python-watcherclient: Add auto_trigger support https://review.openstack.org/403716 | 16:10 |
alexchadin | dtardivel: I tried to add change_state and migrate actions and I get this one: http://pastebin.com/Kis3Ha0h | 16:11 |
dtardivel | is it in DE or Applier level ? | 16:13 |
*** alexchadin has quit IRC | 16:13 | |
*** alexchadin has joined #openstack-watcher | 16:13 | |
*** michaelgugino has joined #openstack-watcher | 16:13 | |
*** alexchad_ has joined #openstack-watcher | 16:14 | |
alexchad_ | It is in DE level | 16:14 |
*** alexchadin has quit IRC | 16:14 | |
*** jwcroppe has joined #openstack-watcher | 16:18 | |
dtardivel | ok | 16:19 |
*** thorst_ has quit IRC | 16:23 | |
openstackgerrit | Antoine Cabot proposed openstack/watcher-specs: Spec for Noisy Neighbor Startegy renamed cache occupancy strategy to noisy neighbor https://review.openstack.org/398162 | 16:32 |
openstackgerrit | Antoine Cabot proposed openstack/watcher-specs: Add improvements to the planner and workflow mechanisms https://review.openstack.org/385871 | 16:32 |
openstackgerrit | Antoine Cabot proposed openstack/watcher-specs: Support Description For Dynamic Action https://review.openstack.org/401111 | 16:32 |
*** thorst_ has joined #openstack-watcher | 16:33 | |
*** alexchad_ has quit IRC | 17:29 | |
*** thorst_ has quit IRC | 17:32 | |
*** alexchadin has joined #openstack-watcher | 17:50 | |
*** acabot has quit IRC | 18:11 | |
*** harlowja has joined #openstack-watcher | 18:31 | |
*** alexchadin has quit IRC | 18:46 | |
*** harlowja has quit IRC | 18:52 | |
*** thorst_ has joined #openstack-watcher | 18:59 | |
*** wootehfoot has joined #openstack-watcher | 19:32 | |
*** wootehfoot has quit IRC | 19:33 | |
*** wootehfoot has joined #openstack-watcher | 19:33 | |
*** dtardivel has quit IRC | 19:54 | |
*** jwcroppe has quit IRC | 20:27 | |
*** jwcroppe has joined #openstack-watcher | 20:28 | |
*** lamt has quit IRC | 20:29 | |
*** jwcroppe has quit IRC | 20:31 | |
*** jwcroppe_ has joined #openstack-watcher | 20:44 | |
*** wootehfoot has quit IRC | 21:00 | |
*** michaelgugino has quit IRC | 21:13 | |
*** wootehfoot has joined #openstack-watcher | 22:11 | |
*** thorst_ has quit IRC | 23:05 | |
*** thorst_ has joined #openstack-watcher | 23:15 | |
*** wootehfoot has quit IRC | 23:15 | |
*** harlowja has joined #openstack-watcher | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!