| frickler | tc-members: in https://review.opendev.org/c/openstack/ironic-python-agent/+/954563 I commented on a signed-off line using an alias instead of the real name and it looks like gerrit doesn't verify the "real name" part, so that makes me wonder whether we need to introduce some extra check there or whether we want to rely on the reviewers for that (cf. | 09:15 |
|---|---|---|
| frickler | https://docs.openstack.org/contributors/common/dco.html#setting-up-your-git-configuration-for-dco) | 09:15 |
| opendevreview | Merged openstack/contributor-guide master: Update reference to collaboration tools https://review.opendev.org/c/openstack/contributor-guide/+/952506 | 12:13 |
| jbernard | frickler: it could be useful to include a reference in the contributer guide on how to enable sign-off in gitconfig: https://git-scm.com/docs/git-config#Documentation/git-config.txt-formatsignOff (so that remembering -s is no longer required) | 12:24 |
| jbernard | frickler: happy to submit a patch if you agree | 12:24 |
| mnasiadka | jbernard: this only affects git format-patch - we're not sending patches by email - are we? | 12:33 |
| frickler | jbernard: tbh I'm a bit unsure about that, I would want to ensure that people are really aware of the legal implications of the signoff. adding a description how to automate that is a bit like having instructions to run "rm -rf --yes-i-really-really-mean-it /" | 12:34 |
| jbernard | mnasiadka: ahh, yes that's not the right link, there is a flag in gitconfig that can enable signoff by default though | 12:34 |
| jbernard | frickler: makes sense | 12:34 |
| mnasiadka | jbernard: I think you can only do that with a git commit message template... | 12:35 |
| jbernard | mnasiadka: oh, you might be right, easy enough but certainly more complicated than a flag | 12:37 |
| jbernard | mnasiadka: a commit alias would also work | 12:38 |
| mnasiadka | yup | 12:38 |
| cardoe | Yeah they purposefully don't add a config file option for automatically signing off. | 12:51 |
| opendevreview | Sylvain Bauza proposed openstack/governance master: Make Eventlet removal deadlines more acceptable for operators https://review.opendev.org/c/openstack/governance/+/952903 | 14:35 |
| *** jbernard_ is now known as jbernard | 14:49 | |
| opendevreview | Merged openstack/governance master: Deprecate shade, os-client-config https://review.opendev.org/c/openstack/governance/+/953549 | 20:49 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!