Wednesday, 2015-04-01

mattoliveraupeluse: well it gives me the timeout 1 second issue... so hopefully the cause is the same as the others00:00
pelusemattoliverau, see https://etherpad.openstack.org/p/swift_timeout_test_failure as well00:00
pelusecool00:00
peluseOK, I have to shuttle a kid... be back online in 45 min or so00:01
mattoliveraustep 1: recreate, step 2: commence banging head agaist the wall, step N: solved. (NOTE: in unit test debugging I like to jump to banging head)00:02
hogood morining guys!00:02
claygI think at some point I decided to start creating my stub timeouts with an integer because it looked better in the log lines - and that was a really bad idea :\00:03
claygI'm not sure why __init__ calls start instead of just __enter__ - very strange00:03
openstackgerritClay Gerrard proposed openstack/swift: wip: ec reconstructor probe test  https://review.openstack.org/16429100:05
openstackgerritClay Gerrard proposed openstack/swift: Erasure Code Reconstructor  https://review.openstack.org/13187200:05
claygthat 'ought to do it00:05
claygsorry I suck so much!00:05
claygI should get a t-shirt with that on it00:05
claygor maybe it should say "sorry clayg sucks so much" - and then I could just pass them out when i'm being a dofus/jerk00:06
openstackgerritClay Gerrard proposed openstack/swift: Fix ssync sender cleanup of reverted fragment files  https://review.openstack.org/16905200:06
*** yuan has quit IRC00:08
mattoliverauho: morning00:09
homattoliverau: morning!00:23
*** dmorita has joined #openstack-swift00:24
mattoliverauLol, infra have put Clippy the paperclip on review.o.o as an april fools.. if the rest of you can't see it then it must be local date based00:26
claygoohhhhhh goodie i can't wait until tomorrow!00:35
mattoliverauclayg: congrats, patch 131872,52 has passed unit tests on gerrit! just tempest and grenade and it'll post on the change.00:36
patchbotmattoliverau: https://review.openstack.org/#/c/131872/00:36
mattoliverauand the timeout issue I was investigating is solved :)00:36
claygmattoliverau: yeah - protip don't make a Timestamp(<int>) unless you mean it!00:37
mattoliverauclayg: ok, noted ;)00:37
*** panbalag has quit IRC00:41
pelusenice clayg!00:46
peluseso what were we working on again before all this?  :)00:47
claygrenaming the object-reconstrucutrorer to object-recoder00:50
claygno wait.... no one was working on that :'(00:51
peluseoh yeah, OK how about I go fix the job cardinality00:53
pelusealso, real quick, what was wrong with doing Timeout(5) for example?00:54
claygwhen you create a Timeout like that (with an int instead of None) - it *starts* it on the eventlet hub00:56
claygthe only way to get it to *not* fire is to call .cancel - or use the with context manager to have it call .cancel for you00:56
clayg[00:05] +      clayg | peluse: https://github.com/simplegeo/eventlet/blob/master/eventlet/timeout.py#L7600:56
peluseahh, so None won't actually raise a timeout... got it00:57
*** panbalag has joined #openstack-swift01:15
*** ujjain has quit IRC01:17
*** annegentle has joined #openstack-swift01:18
*** haigang has joined #openstack-swift01:22
*** haomaiwang has quit IRC01:29
*** jrichli has joined #openstack-swift01:34
*** annegentle has quit IRC01:43
*** vinsh_ has joined #openstack-swift01:45
*** haigang has quit IRC01:48
*** vinsh has quit IRC01:48
mattoliverauI'm off to find some lunch bbs01:48
peluserock on01:50
openstackgerritpaul luse proposed openstack/swift: Erasure Code Reconstructor  https://review.openstack.org/13187201:54
openstackgerritpaul luse proposed openstack/swift: wip: ec reconstructor probe test  https://review.openstack.org/16429101:55
*** haigang has joined #openstack-swift01:58
*** haomaiwang has joined #openstack-swift02:00
openstackgerritOpenStack Proposal Bot proposed openstack/python-swiftclient: Updated from global requirements  https://review.openstack.org/8925002:01
*** panbalag has quit IRC02:08
openstackgerritpaul luse proposed openstack/swift: Fix ssync sender cleanup of reverted fragment files  https://review.openstack.org/16905202:10
claygpeluse: i feel like there must be some missing tests that should have it the ts_to_fname block?02:11
claygalso - i don't think going with suffixes.keys() is really going to make build_jobs return the right number of jobs...02:11
pelusethe only tet that would have caught it currently was probe and it did02:12
pelusethere were no unit tests for any of the ssync changes for ecrecon02:12
pelusewell, that wasn't what that change was for02:12
peluseI didn't address the job cardinality concern there, that change was because in the case of revert we were using the full suffixes dict and passing it to ssync_sender isntead of the list of suffixes02:14
claygoic gotcha02:15
pelusewrt the ssync tests for ecrecon changes, I thought acoles was adding those on his list of todo items but if not there02:16
peluse's only a few small gaps to close there02:16
*** jogriffin has joined #openstack-swift02:17
pelusewrt the job cardinality thing, I couldn't think of anything 'easy' there as was mentioned in your comment so figured before I started tearing shit up I'd better talk to you about exactly what you had in mind02:17
*** annegentle has joined #openstack-swift02:19
claygacoles_away: i'm looking at get_options in storage_policy module - added for in-process func tests - and thinking that the EC storage policy doesn't return *all* of it's options02:22
claygacoles_away: why did you add this method - in process functest based on on disk configs is such mis-feature - what needs to happen?02:23
*** annegentle has quit IRC02:24
claygacoles_away: looks like the ECStoragePolicy class needs to update it's internal options into get_options02:25
claygI wish only the one config parsing map needed to be maintained for all of this mapping02:25
peluseclayg, so let me know what you had in mind for the job building/processing deal.  You agree that what we have now works right?  It could just be a lot more efficient wrt who it talks to and how often02:31
pelusegotta bolt... catch ya tomorrow02:41
*** tsg_ has quit IRC02:48
claygyeah I think it would work - but I would really rather it be better - more efficient is a bit of an understantement when you talking cardinality of # of suffixes to # of partitions - and we have a *lot* of partitions02:54
claygthat being said I'm not working on it atm02:55
*** annegentle has joined #openstack-swift02:57
*** km has quit IRC03:00
openstackgerritJanie Richling proposed openstack/swift: WIP - Provides a simple skeleton of middleware for encryption feature.  https://review.openstack.org/15790703:08
*** jrichli has quit IRC03:09
*** vinsh_ has quit IRC03:11
*** david-lyle has joined #openstack-swift03:13
*** tsg_ has joined #openstack-swift03:22
*** ppai has joined #openstack-swift03:29
peluseclayg, OK sounds good.  I have an idea, I'll stew on it more in the morning and run it by you then03:44
*** yuan has joined #openstack-swift03:49
*** annegentle has quit IRC04:26
*** haigang has quit IRC04:38
*** haigang has joined #openstack-swift04:44
*** jogriffin has quit IRC04:46
*** haigang has quit IRC04:50
openstackgerritClay Gerrard proposed openstack/swift: Add support for policy types, 'erasure_coding' policy  https://review.openstack.org/16961404:53
openstackgerritClay Gerrard proposed openstack/swift: Initial Erasure Code Docs  https://review.openstack.org/16961504:53
clayga'ight - let's get this party started off real smooth like04:53
claygI'll be inserting patches inbetween the storage policy refactor (which I chagned a bunch so everyone can acctually get started with a for-realzy review :P) and the docs04:54
*** vinsh has joined #openstack-swift04:54
*** vinsh has quit IRC04:55
claygacoles_away: also you'll need to tell me what needs to happen for in process func tests on https://review.openstack.org/16961404:56
*** SkyRocknRoll has joined #openstack-swift05:11
*** SkyRocknRoll has joined #openstack-swift05:11
openstackgerritMatthew Oliver proposed openstack/swift: Update contianer sync to use internal client  https://review.openstack.org/14379105:15
mattoliverauclayg: ^^ tested cont sync, and works well between 2 saios, func tests between polices (EC and REPL) would be nice, but works in personal testing05:19
mattoliverauor where ever that testing woulb be05:21
zaitcevwait, it didn't use our own client before?05:21
claygI didn't really *forget* how tedious and painful all the testing is with epic rebases like this - but I'd sorta surpressed it?05:22
claygzaitcev: for the GET side of sync it would just make direct client calls05:23
claygmattoliverau: does the probe tests for container sync not bother to test cross policy when it can?05:23
mattoliverauto be honest, i have really checked, will now05:24
mattoliverauclayg: it does.. kinda.. it if there is > 1 enabled policy, it randomly chooses one for the source container and randomly chooses again for the dest container05:28
*** reed has quit IRC05:29
zaitcevhmm, now that we have internal-client.conf, maybe object expirer should be made to use it?05:32
claygmattoliverau: so it'll randomly sometimes test cross policy05:33
claygmattoliverau: maybe that's good - i suppose you want to test same policy sometimes too05:33
mattoliverauclayg: yup, but adding a corss policy probe test now05:33
claygzaitcev: I think *should* is maybe stronger than I'm willing to go for ;)05:34
mattoliverauif it has more then 1 type05:34
clayg*could* would be nice :)  but doing that work means figuring out how to do the upgrades and backwards compatible - and we suck at deprecating shit - so basically it'll be a bunch of work to make it possible to not have to do it - but we'll still have to test and support it works FOREVAR05:34
claygmattoliverau: i thought you said it was already cross-policy?05:35
*** haigang has joined #openstack-swift05:35
*** haigang has quit IRC05:35
*** zaitcev has quit IRC05:35
mattoliverauclayg: yeah, randomly selects between policies that aren't deprecated.. I can leave it if we think that is enough, but I'm playing with one that if there are more then 1 type (REPL, EC) then to do a cross policy test... if I do I can make it a dependant patch and can wait until post beta :)05:39
claygmattoliverau: if you can verify it'll hit a repl->ec check after a few runs if you do it in a loop I think that's good enough05:40
claygprobetsts are hulla slow - i don't wanna add one unless I have to - and if I'm changing/reviewing something that messes with container sync I'll probably run probetests a number of times anyway if not in a loop (now that I know i wrote it like that)05:41
claygin the more general case of "someone changed something on the backend run a "quick" test with probetests" - i think the randomness is fine05:42
mattoliveraukk, I run a loop and watch for a while then :P05:42
claygif something did break cross policy (but accidently still worked on the same policy, and they got a false confidence from a lucky probe test run) - someone would notice it soon enough05:42
claygit's not like probetests haven't been broken in the past05:42
mattoliveraulol05:43
claygif we ever mangage to get them running on the community cluster it might be interesting to see if we can have a --quick or --soak option that lets the computers run more tests without the cost of wall time on my laptop05:43
openstackgerritClay Gerrard proposed openstack/swift: Initial Erasure Code Docs  https://review.openstack.org/16961505:44
openstackgerritClay Gerrard proposed openstack/swift: Update test infrastructor  https://review.openstack.org/16962005:44
*** haigang has joined #openstack-swift05:45
*** thumpba has joined #openstack-swift05:53
mattoliverauclayg: hmm.. interesting thought.. I wonder if I can fool RS into letting me build a community cluster in the cloud for testing.. or even a big beefy SAIO or 2 to test this stuff on each commit. :P (no promises but interesting thought)06:00
*** haigang has quit IRC06:07
claygmattoliverau: yeah probetests are long way from being able to run on a multi-node setups - but that's the dream - right klrmn!?06:08
*** haigang has joined #openstack-swift06:09
*** haigang has quit IRC06:10
*** silor has joined #openstack-swift06:11
*** haigang has joined #openstack-swift06:13
*** silor1 has joined #openstack-swift06:15
*** silor has quit IRC06:18
*** haigang has quit IRC06:23
*** haigang has joined #openstack-swift06:25
openstackgerritChristian Schwede proposed openstack/swift: Check if device name is valid when adding to the ring  https://review.openstack.org/16923106:31
openstackgerritChristian Schwede proposed openstack/swift: Check if REST API version is valid  https://review.openstack.org/16850906:42
*** vinsh has joined #openstack-swift06:43
*** vinsh has quit IRC06:48
mattoliverauclayg: yay, once you have the saio setup correctly to not skip on container_sync during probe tests, it works and the test is really quick... in comparison. And does select the EC policy: http://paste.openstack.org/show/197754/06:52
mattoliverauOn that note, I'm going to go get started on cooking dinner before the wife gets home.06:53
mattoliveraucschwede: Morning (your new patchsets gave you away) :P06:53
cschwedemattoliverau: Good morning Matthew!06:54
cschwedeyeah, hard to stay undercover if you want to get something done ;)06:54
claygpeluse: notmyname: I think we need to do a master merge to feature/ec or something?06:54
mattoliveraulol06:55
*** blankspace has joined #openstack-swift07:01
*** jordanP has joined #openstack-swift07:09
hocschwede: morning! I understand your thought but to keep consistency of your thought I think it might be good to remve L1722(err = 0) in test_ringbuilder.py. what do you think?07:10
*** tsg_ has quit IRC07:10
cschwedeho: Good Morning! No, that err=0 is required to make sure the previous loop iteration is not evaluated again, which happens if the current loop doesn’t raise an exception07:12
hocschwede: I see. your right! thanks for the explnation07:13
cschwedeho: you’re welcome!07:13
hocschwede: initialized by None is more preferable?07:14
*** jistr has joined #openstack-swift07:14
cschwedeho: hmm, the SystemExit error code is always an int and the default is 0 - thus i thought it makes sense07:16
hocschwede: OK, thanks! :)07:30
*** geaaru has joined #openstack-swift07:37
claygso I think the last time I did this I wasn't quite as skillful with my use of git add -p's search feature07:37
claygafter I apply the diff from feature/ec to the review branch i can skip to just the hunk i want add it and then throw away the rest - test - apply - add -p - repeat07:38
openstackgerritClay Gerrard proposed openstack/swift: Add support for policy types, 'erasure_coding' policy  https://review.openstack.org/16961407:43
openstackgerritClay Gerrard proposed openstack/swift: Initial Erasure Code Docs  https://review.openstack.org/16961507:43
openstackgerritClay Gerrard proposed openstack/swift: Update test infrastructor  https://review.openstack.org/16962007:43
openstackgerritClay Gerrard proposed openstack/swift: Per-policy DiskFile classes  https://review.openstack.org/16965107:43
claygok, - so I'm really just starting to sketch things out here folks - don't get too excited07:44
clayg... maybe I should be doing this on github or something :\07:44
clayghi clippy!07:45
claygok, but I'm going to call it quits for tonight anyway - talk to ya'll in the meeting tomorrow07:46
claygmattoliverau: if you end up online anymore and want to help out with commit messages that'd be great!07:46
claygmattoliverau: I'll probably end up trying to troll through feature/ec and pull at random snippets from the logs there07:47
claygahh that's bullshit - i just realized my git commit -a -C <somesha> trick isn't carrying over authorship information07:47
claygI thought it did!?07:48
claygahhh what the hell - git log says it right but gerrit wants to blame everything on me :\07:48
mattoliverauclayg: i'm around if you need anything, just cooking some dinner :)07:48
claygnah i'm good and done - just thinking about splitting up all these changes - stuff like how to logically group things - and what the commits should say07:49
claygtalk to you tomorrow07:49
*** thumpba has quit IRC07:54
*** acoles_away is now known as acoles08:05
acolesgood morning08:05
openstackgerritMerged openstack/swift: Update contianer sync to use internal client  https://review.openstack.org/14379108:13
hoacoles: morning!08:21
acolesho: hello!08:26
*** vinsh has joined #openstack-swift08:32
*** vinsh has quit IRC08:37
*** ho has quit IRC08:43
*** kei_yama has quit IRC08:44
*** silor1 has quit IRC09:14
*** haomaiwang has quit IRC09:51
*** silor has joined #openstack-swift09:57
*** silor1 has joined #openstack-swift09:59
*** silor has quit IRC10:01
*** InAnimaTe has quit IRC10:20
*** jistr has quit IRC10:23
*** haigang has quit IRC10:24
*** jistr has joined #openstack-swift10:36
*** nellysmitt has joined #openstack-swift10:50
*** haigang has joined #openstack-swift10:54
*** krykowski has joined #openstack-swift11:00
*** dmorita has quit IRC11:06
*** haigang has quit IRC11:10
*** jistr is now known as jistr|demo11:11
*** ppai has quit IRC11:36
pelusemorning11:49
tdasilvamorning11:53
*** ppai has joined #openstack-swift12:02
*** emptyspace has joined #openstack-swift12:04
*** blankspace has quit IRC12:04
*** dencaval has joined #openstack-swift12:06
*** blankspace has joined #openstack-swift12:07
*** blankspace has quit IRC12:07
*** blankspace has joined #openstack-swift12:07
*** panbalag has joined #openstack-swift12:08
*** vinsh has joined #openstack-swift12:10
*** emptyspace has quit IRC12:10
openstackgerritpaul luse proposed openstack/swift: Merge master to feature/ec  https://review.openstack.org/16972012:11
peluseclayg, ask and ye shall receive...12:12
acolespeluse: tdasilva morning12:12
tdasilva:-)12:13
acolespeluse: so did you guys figure out the timeout thing?12:13
*** vinsh has quit IRC12:14
*** panbalag has quit IRC12:15
*** panbalag has joined #openstack-swift12:16
*** ppai has quit IRC12:24
peluseacoles, yes, clay did12:29
peluseacoles, he was passing a timeout value in his mock calls with Timeout so setting real timeouts in the hub12:29
peluseacoles, thanks for the comments on the ECrecon BTW, just commented on them12:30
*** rdaly2 has joined #openstack-swift12:33
*** khivin has quit IRC12:39
*** nexusz99 has joined #openstack-swift12:48
*** nexusz99 has quit IRC12:48
*** zul has quit IRC12:57
*** zul has joined #openstack-swift12:57
*** lpabon has joined #openstack-swift12:59
*** emptyspace has joined #openstack-swift13:00
acolespeluse: cool, i was worrying about the commit() being the cause13:02
*** blankspace has quit IRC13:04
*** annegentle has joined #openstack-swift13:05
*** emptyspace has quit IRC13:07
*** petertr7 has joined #openstack-swift13:11
*** SkyRocknRoll has quit IRC13:25
*** SkyRocknRoll has joined #openstack-swift13:25
*** lastops has joined #openstack-swift13:28
*** lastops has quit IRC13:28
-openstackstatus- NOTICE: gerrit has been restarted to restore event streaming. any change events missed by zuul (between 12:48 and 13:28 utc) will need to be rechecked or have new approval votes set13:29
*** haigang has joined #openstack-swift13:31
*** lastops has joined #openstack-swift13:32
*** jogriffin has joined #openstack-swift13:35
*** jogriffin has quit IRC13:41
*** nexusz99 has joined #openstack-swift13:45
*** jrichli has joined #openstack-swift13:46
*** vinsh has joined #openstack-swift13:49
*** haigang has quit IRC13:52
*** vinsh has quit IRC13:52
*** InAnimaTe has joined #openstack-swift13:53
*** SkyRocknRoll has quit IRC13:55
*** SkyRocknRoll has joined #openstack-swift13:56
*** tsg_ has joined #openstack-swift14:01
*** tsg_ has quit IRC14:06
*** annegentle has quit IRC14:09
*** zul has quit IRC14:10
*** zul has joined #openstack-swift14:11
*** zaitcev has joined #openstack-swift14:13
*** ChanServ sets mode: +v zaitcev14:13
openstackgerritChristian Schwede proposed openstack/swift: Check if REST API version is valid  https://review.openstack.org/16850914:20
*** bkopilov has quit IRC14:27
*** vinsh has joined #openstack-swift14:28
*** bkopilov has joined #openstack-swift14:28
openstackgerritChristian Schwede proposed openstack/swift: Check if device name is valid when adding to the ring  https://review.openstack.org/16923114:34
*** annegentle has joined #openstack-swift14:36
openstackgerritMerged openstack/swift: Merge master to feature/ec  https://review.openstack.org/16972014:41
*** ujjain has joined #openstack-swift14:45
*** Bsony has joined #openstack-swift15:00
*** annegent_ has joined #openstack-swift15:02
*** nellysmi_ has joined #openstack-swift15:03
*** nellysmitt has quit IRC15:04
*** annegentle has quit IRC15:04
*** nellysmitt has joined #openstack-swift15:04
*** nellysmitt has quit IRC15:05
*** rdaly2 has quit IRC15:07
*** nellysmi_ has quit IRC15:08
*** rdaly2 has joined #openstack-swift15:10
*** Guest___ has joined #openstack-swift15:15
*** bkopilov has quit IRC15:27
*** jogriffin has joined #openstack-swift15:34
*** jogriffin has quit IRC15:34
*** reed has joined #openstack-swift15:35
claygpeluse: yeah thanks that's just what I needed15:38
claygpeluse: thanks for leaving me that dangling elif in get_dev_path - it's really satisfiying to my OCD and that one was particularlly juciy15:42
*** lpabon has quit IRC15:44
*** bkopilov has joined #openstack-swift15:46
*** bkopilov has quit IRC15:46
*** Guest54459 is now known as h_m15:49
openstackgerritAlistair Coles proposed openstack/swift: Fix ssync sender cleanup of reverted fragment files  https://review.openstack.org/16905215:50
claygwow acoles is on the recoder this is awesomeon!15:50
*** mahatic has joined #openstack-swift15:54
acolesfixer15:54
acoles;)15:54
*** krykowski has quit IRC15:56
h_mhi guys! newbie question : i'm trying to deploy swift using this doc http://docs.openstack.org/juno/install-guide/install/apt/content/ch_swift.html i have a proxy-server and two storage nodes, my question is ; if add a storage_device to a storage_node and after rebalancing the ring on the proxy-server, do i have to redistribute ring configuration files on the storage nodes?15:56
h_mas described here http://docs.openstack.org/juno/install-guide/install/apt/content/swift-initial-rings-distribute.html15:57
claygacoles: peluse: the junky code at the bottom of the job_info method was trying to get rid of the None job when the list is like this [{'sync', part=0, frag_index=None}, {'sync', part=0, frag_index=1}]15:58
claygacoles: peluse: in this case it's just not useful to run process_job on both "frag_indexes" - the None job isn't really a frag index - and all it's .ts updates will get pushed over when the nodes walks for the frag_index=1 anyway16:00
*** Guest___ has quit IRC16:01
claygif len(jobs) > 2: jobs = filter(jobs, lambda j: j['frag_index'] == None) would have been better - i wonder why I didn't write that?16:01
acolesclayg: (making sure i understand) thats because frag_index=1 passed to yield_hashes will still yield all the .ts16:02
claygacoles: yeah you got it bro!16:02
acolesclayg: so when do we do a frag_index=None job, just when there are NO .data files in the suffix?16:03
claygacoles: RIGHT!  it has to happen sometimes16:03
claygacoles: the crazy part about that situation is we have no idea what our node_index is16:04
claygit's going to be hard to imagine what our partners should be16:04
claygbut I think we should still either revert to only one or sync with some random two?16:04
claygbah, probably can't be random :\16:04
acolesclayg: or we do a tombstone-storm ;)16:04
claygin the stable non-rebalacing sync case we need to deterministically eventually get to all the nodes16:05
acolesthis is useful cos i need to add tombstone test cases to  patch 16905216:05
patchbotacoles: https://review.openstack.org/#/c/169052/16:05
claygacoles: honestly I'd almost rather just stick a frag_index marker of some kind in the suffix or something16:06
claygyeah i don't know if that would work, maybe tombstone storm is the most obviously correct thing to do16:08
claygidk, I think you pass an empty flag around the chain16:09
claygit's a puzzle!16:11
acolesyup its always so much harder to delete things than create them16:11
claygit's only hard when you want to delete ALL THE THINGS!16:12
*** rdaly2 has quit IRC16:19
*** annegent_ has quit IRC16:22
acolespeluse: thanks for replies on review, i'll wait for the re-worked version. just one point i am still unsure about, which is a revert job when all missing frags in receiver suffix have been completely rebuilt.16:24
clayg"a revert job when all missing  frags in receiver suffix have been completely rebuilt16:27
claygindividually those words all have meaning to me - together I don't know what they mena16:28
acolesclayg: lol, let me try again16:28
acolesassume sender node has a suffix with frag indexes that belong on another node...16:29
claygacoles: just for the sake of argument - handoff or rebalance?16:29
acoles(handoff) but the other node has already had its frag repaired so its suffix hash matches sender suffix hash..16:30
acolesthen IF i understand we don't pass that suffix to ssync_sender (big IF there)16:30
claygacoles: yeah that the thing I don't quite get - hold on there16:31
acolesso the handoff frags don't get removed16:31
claygwhy do we do a pre-flight suffix sync on revert?16:31
clayglook at delete updated in the replicator - it calls rsync, it calls replicate, it deletes the part16:31
clayglike there's nothing the other node can tell you that is useful - you don't want any of this data anymore16:32
claygso you sync - some moves, some is already there, but in the end - you're in sync - you call sync hashes one more time to make sure the remote end doesn't have any out of date invalid hashes - then you get rid of the stuff you don't want anymore16:33
acolesits line 490 in reconstructor.py that i am stuck on16:34
acolessuffixes = self.get_suffix_delta16:34
acoleswon't that return empty list if rx suffix is same as tx suffix for that frag index?16:35
claygyeah doesn't make any sense to compare suffixes before hand on a revert job16:35
acolesscratch that ^^16:35
claygwell for that frag_index == remote_index w/e16:36
acolesyeah, that16:36
acolesthe suffix won't make it to the list passed to ssync16:36
acolesif remote hash == local hash16:36
claygyeah so - revert - don't look at suffixes - just push this crap off - every suffix you've got that's tainted with this frag_indexs you don't want - push 'em16:37
peluseacoles, just got back from an appt.  yeah, we do send the suffix list in that case16:37
claygpeluse: for revert jobs there should be no "delta" - ship it - then rip it16:37
peluseyes16:38
peluseso lets cover this again with the reworked code if that's OK16:38
claygyay!16:38
peluseshouldn't be much longer, its not as ugly as I thought it would be16:38
pelusein fact its both simpler and more efficient - go figure!16:38
* peluse hopes he didn't speak to soon... OK back to work16:39
acolespeluse: heh16:39
acolesif were were smart we could tell ssync not to bother with the missing_check/updates for that 'no-op' suffix, but thats an optimisation that could wait16:43
acolespeluse: FYI I am working on the todo in ssync_sender where recosntruct_fa returns None16:47
*** jistr|demo has quit IRC16:47
peluseacoles, great, thanks16:47
*** jordanP has quit IRC16:51
claygacoles: what do you mean no-op suffix - how are you going to skip the missing check?  like you don't want to send stuff the other end already has - think rsync16:59
claygyou just don't need a hint about what needs to be synced and what doesn't - anything you have needs to be synced - because it's about to get BALEETED17:01
acolesclayg: but if we know that the other end's suffix hash is same as ours then there is no need to do missing_check - there will be no missing items, no?17:02
*** SkyRocknRoll has quit IRC17:03
claygbut why would know the other ends suffix hash is the same as ours?  how do we know it's *still* the same as ours after all that listdirin' we just made it do.  remember, BALEETED - just ship anything we have it doesn't and be done with it17:04
claygwhat if it just has *MORE* that we do - we still need to ship what we have17:05
claygthe missing check just works out what we're going to put on the wire so it doesn't have to go read a bunch of bytes to get to the ones it wants17:06
peluseclayg, side question - how did you make that long ugly listy of expected jobs that I had #noqa on so neatly formatted?  Not manually right??17:10
openstackgerritThiago da Silva proposed openstack/swift: Select policy when running functional test  https://review.openstack.org/16759517:10
*** annegentle has joined #openstack-swift17:12
acolesclayg: i thought we said we would not repeat the local get_hashes for a revert job, so we do the REPLICATE request, remote node calculates its hashes, and then we drop into ssync which ~immediately does missing_check which causes ssync receiver to go open all those diskfiles17:12
openstackgerritThiago da Silva proposed openstack/swift: Document SWIFT_TEST_POLICY for regular functional tests  https://review.openstack.org/16795817:12
openstackgerritThiago da Silva proposed openstack/swift: Move policy_specified handling to PolicyCollection  https://review.openstack.org/16800717:13
acolesclayg: fair enough, if the remote has more than local (suffix hashes mismatch) then we can't avoid the missing_checks17:13
acolesclayg: its the receiver workload i'm thinking we could reduce17:15
claygpeluse: mostly "manually"17:15
peluseholy shit17:16
claygi have some editor macros that help quite a bit - then I cooked up a few more to get it the rest of the way17:16
claygI think torgomatic can just hilight a whole bit thing like that and his emacs' version of vim's gq just works17:16
claygpeluse: why - you're not going to ruin it again are you?17:17
claygthe whole point is that for maintence you need to be able to edit that thing - not just copy and paste in the new one17:18
peluseclayg, well, the jobs are going to be different now....17:18
peluseI should be able to edit it and future tweaks won't be bad, plus it will be smaller now17:18
claygsucks to have such big stub data structures all listed out explicitly in the test like that then doesn't it!17:18
acolespeluse: clayg: can i make reconstruct_fa raise a DiskFileError rather than returning None if it fails?17:18
claygacoles: i have no idea - ssync calls that17:19
claygacoles: he'd have to do the right thing in either case - why does he like None now?17:19
*** thumpba has joined #openstack-swift17:20
acolesclayg: right now he doesn't do the right thing, thats what i am working on17:20
peluseyeah, returning None is/was a TODO17:21
pelusejust need to gracefully exit the ssync process since we couldn't reconstruct - it will automagically try again later17:21
claygpeluse: I thought acoles was going to figure out some way to make it continue on17:22
claygacoles: ^ which sounds great!17:22
acoleshmm, yeah, i'd rather it gracefully continued17:22
claygacoles: I think if you're in the middle of a fa body and it blows up your ssync protocol is screwed and there's no way to resync the channel17:22
peluseyeah, that's what I meant - exit the current process of syncing the object that couldn't be reconstructed17:23
acolespeluse: gotcha17:23
claygacoles: but during the "gather connections to rebuild the fa" if you have a downed node here or there - should be easy enough to just not ship that one to the remote17:23
acolesclayg: ^^ thats the one. if body iter blows up all bets are off17:23
*** welldannit has joined #openstack-swift17:24
peluseclayg, so building jobs to sync tombstones and durables (whcih have no FI) currently I just do the safe thing and sync to all part nodes.  You think its better to randomly choose one of them?  If we're a handoff then we don't have much chance of getting these guys back to their primmary in a very timely manner...17:25
peluseand I mean this in the case of when we're a handoff only, if we're doing a regular sync they go to the partners....17:26
pelusetell you what, I'll post the code soon and you can look there for more context17:27
*** zhill has joined #openstack-swift17:35
*** annegentle has quit IRC17:36
*** rdaly2 has joined #openstack-swift17:39
claygpeluse: either sync or revert jobs could have no data files in them :\17:42
claygpeluse: I *do* sort like the randomly select some set of nodes trick - even if it's like "just pick half" or make it configurable17:42
*** geaaru has quit IRC17:43
claygpeluse: i feel like the node that isn't 404'ing everything in the part isn't acctually going to be letting much data out if he's the outlier17:44
claygbut i'm cool with "do everyone" as long as it's sort of paramaterized in such a way that it'd be obvious to cut it down to *some* kind of subset if we decide it's too chatty17:44
*** silor1 has quit IRC17:46
claygso i'm sorta pumped about this patch i've been building up - it's in this weird state where the object server is all mime'd and multiphased' up everything is routing to ecdiskfiles and stuff - but the proxy knows *nothing* about ec - and the weird thing is - it "works" - like passes functional tests17:50
claygbecause like it just treats it like a replicated storage policy - i just had to hack in a default for the fragment index and the call to commit will even create the durable so GET will work17:51
claygnotmyname: is the meeting in like an hour or ten mins?17:52
claygawwww bummer - got some errors :'(17:52
claygoh i think my battery is just running low17:53
claygchunkwritetimeout?17:53
acolesoh meeting!17:54
claygacoles: when is it17:54
acoles66 mins i reckon17:54
acolesclayg: yes, 1 hour to go17:55
claygk, sweet17:55
claygso did we manage to land the run functests against specific storage polices - how does that work?18:06
tdasilvaclayg: not sure if something else landed on feature/ec. Patch 167595 is still up for review on master18:07
tdasilvapatch 16759518:08
patchbottdasilva: https://review.openstack.org/#/c/167595/18:08
claygSWIFT_TEST_POLICY is like a word in functests/__init__ - it doesn't acctully help anything tho?18:08
clayglooks like an inprocess thing I guess18:08
tdasilvain that patch we also use that env. variable for setting a specific policy18:09
openstackgerritAlistair Coles proposed openstack/swift: Fix ssync sender behavior for EC reconstructor jobs  https://review.openstack.org/16905218:09
claygacoles: oh did you look at patch 169614 - is that config option stuff for the inprocess functests helpful?18:09
patchbotclayg: https://review.openstack.org/#/c/169614/18:09
acolesclayg: yes i did and yes i think you nailed it18:10
acolesbbiab for meeting18:10
claygacoles: was that fragments list on the get_ondisk_files context ment to stay around - because I think it'd be awesome - but didn't quite follow where it was being used/tested18:11
claygacoles: re patch 16905218:11
patchbotclayg: https://review.openstack.org/#/c/169052/18:11
*** fern has joined #openstack-swift18:12
*** acoles is now known as acoles_away18:12
notmynamegood morning18:14
notmynameclayg: meeting in 45 minutes18:14
claygok, i think i'm going to jump a train - should be close!18:15
openstackgerritClay Gerrard proposed openstack/swift: Initial Erasure Code Docs  https://review.openstack.org/16961518:15
openstackgerritClay Gerrard proposed openstack/swift: Per-policy DiskFile classes  https://review.openstack.org/16965118:15
openstackgerritClay Gerrard proposed openstack/swift: Allow sending object metadata after data  https://review.openstack.org/16986418:15
pelusejust dont jump a shark18:16
*** nexusz99 has quit IRC18:20
peluseclayg, acoles_away : here is the updated job build code.  I have not updated all the test expectations yet.  Put on your headphones and give thia a read, I'll go back and comment on some of acoles other notes in this area in the patch https://gist.github.com/peluse/4f77b73db5e2a220591c18:21
peluseanyone else seeing this new "paper clip" helper icon thingy using chrome on gerrit?  WTH is it and how do I get rid of it?  :)18:22
*** gvernik has joined #openstack-swift18:23
*** bkopilov has joined #openstack-swift18:23
notmynamepeluse: I think it's a present for April 118:24
notmynamepeluse: I too can not seem to get rid of it18:24
pelusefantastic...18:24
torgomaticdoes it do anything besides be dancing baloney?18:26
notmynamemore dancing if you double-triple-etc click on it18:26
*** Bsony_ has joined #openstack-swift18:27
torgomaticlike, "It looks like you've submitted code with a memory leak! Would you like help not holding onto references to everything you've ever done like some kind of demented packrat?"18:27
peluseI got it to put headphones on somehow18:27
notmynameyou seem to be trying to write code. have you considered selling it all and buying a llama farm?18:27
*** Bsony has quit IRC18:27
*** romaindornellas has joined #openstack-swift18:28
*** romaindornellas has left #openstack-swift18:28
*** swiftops has joined #openstack-swift18:29
swiftopshi guys. does anyone already play with swift-drive-audit when kernel logs are sent to messages instead of kern.log ?18:30
*** erlon has joined #openstack-swift18:35
swiftopsbecause date/time pattern is different, swift-drive-audit does not work18:36
*** Bsony_ has quit IRC18:36
torgomaticswiftops: they're the same on my machine; isn't the date format a function of your local syslog config?18:42
swiftopsI dont think. from swift-drive-audit source code, I can see they add a year addition to date format for logs from kern.log18:43
swiftopsmeaning format from kern.log is different18:44
peluseclayg, so actually in the updated job building code I posted I think there is still an opportunity to trim down the sync_to nodes in the 'None' jobs...18:46
*** ho has joined #openstack-swift18:52
notmynamemeeting will start about 10 minutes late to give clayg time to get off the train18:52
*** kota_ has joined #openstack-swift18:54
hogood morning!18:54
kota_ho: good midnight!18:55
notmynameho: kota_: we'll start about 10 minutes late, so if you need to go get coffee/tea, you've got a few minutes extra :-)18:56
hokota_: good midnight :)18:56
*** bkopilov has quit IRC18:56
kota_notmyname: ok18:56
honotmyname: good news! I will get coffee..18:57
notmynamewe're waiting for clayg to get off the train18:58
kota_notmyname: I see, let's wait...18:59
mattoliveraumorning18:59
*** acoles_away is now known as acoles19:02
notmynamegood mornign mattoliverau and acoles19:02
acolesnotmyname: hi, are we having a meeting?19:03
homattoliverau: morning19:03
notmynameacoles: ya. delayed start my about abother 5 minutes19:03
acolesoh i just read back19:03
notmyname:-)19:03
clayglets do it!19:05
notmynamewoot19:05
notmynameok, meeting starting time in #openstack-meeting19:06
*** tellesnobrega_ has joined #openstack-swift19:07
*** tellesnobrega_ has quit IRC19:08
*** joeljwright1 has joined #openstack-swift19:16
*** joeljwright has quit IRC19:18
acolesthat paperclip is getting on my nerves19:23
claygacoles: stupid clippy19:23
*** jbonjean has quit IRC19:24
cschwedeacoles: clayg: it’s just a matter of time until this patch lands: https://review.openstack.org/#/c/169508/19:24
cschwedei was like „wut, where is this trojan coming from“ this morning…19:25
*** jbonjean has joined #openstack-swift19:28
acolescschwede: its in merge conflict !! ^^19:29
*** reed has quit IRC19:40
peluseacoles, FYI I updated all comments on the ECrecon patch and am making some final changes now.  Will take just a bit to confirm them though19:45
*** dencaval has quit IRC19:45
acolespeluse: ok, thx, i won't be doing a whole lot more today19:47
peluseno sweat, thanks!19:47
acolesi nominate clippit for PTL :D19:51
notmynamewheeee19:55
jrichlilol19:56
*** kota_ has quit IRC19:58
* mattoliverau goes to find breakfast (noting on Sunday I turn my clocks back, so next meeting it'll be going back to bed days again) :(19:59
acolesmattoliverau: but look on the bright side - we may overlap more ;)20:01
mattoliverauacoles: that's true, that's a very bright side ;)20:01
acolesmattoliverau: i see your sarcasm there :P20:02
*** lcurtis has joined #openstack-swift20:04
peluseacoles, clayg updated job contruction code at https://gist.github.com/peluse/4f77b73db5e2a220591c20:05
peluseI'm going to start fixing up the tests to match, I believe this is what we're after.20:06
*** annegent_ has joined #openstack-swift20:06
acolespeluse: ok, looks cleaner20:10
peluseyeah and does the 1 job per FI per part that we were after20:10
*** acoles is now known as acoles_away20:11
*** panbalag has quit IRC20:13
*** lastops has quit IRC20:15
claygweeeeee20:28
*** annegent_ has quit IRC20:31
claygpeluse: looks close!  I think the "remove the None job" could be simplified with a list comphrehension of filter if you're more into the functional route20:33
claygpeluse: good luck with the tests20:33
claygpeluse: if it makes more sense to move tests off the GlobalSetup test case than to fix the ones that are there - by all means feel free!20:33
peluseclayg, OK I think I can do that.  I'll get the tests running first20:33
peluseI dont' think it will be bad once I get the expected stuff correct20:34
claygpeluse: I also think it'd be totally reasonable to remove the commandline options for filtering devices - if that helps simplify or reduce required tests20:34
claygpeluse: we can always add that feature later if people want it - it might be nice to have - but hardly required20:34
claygpeluse: sweet!20:35
pelusewhat commandline options for filtering devices?20:35
claygpeluse: oh idk, whatever their called "override devices" or something?20:35
peluseoh yeah, that thing :)20:36
claygnotmyname: why this no merge yet -> https://review.openstack.org/#/c/169897/20:36
claygoh well...20:37
* clayg goes to try and make the proxy work20:37
*** gvernik has quit IRC20:39
*** bkopilov has joined #openstack-swift20:57
*** vinsh has quit IRC20:58
*** scotticus has joined #openstack-swift21:02
zaitcevHow do I calculate the maximum object size? Surely the manifests cannot be limitless, as some kind of DoS prevention?21:03
swifterdarrellzaitcev: i guess it would be SLO config var max_manifest_segments (default 1000?) times swift constraints max obj size which defaults to 5 GiB?21:09
swifterdarrellzaitcev: which i guess equates to, like, 5 TB?21:09
swifterdarrellzaitcev: except that SLO can contain SLO, right?21:09
joeljwright1zaitcev: swifterdarrell: SLO can contain SLO but I believe there's a maximum recursion depth21:10
joeljwright1default is max_slo_recursion_depth = 1021:10
*** vinsh has joined #openstack-swift21:11
torgomaticright, so if you do a 10-deep SLO tree, you get a maximum of 10^9 * 5 GiB, or 4.657 EiB21:28
torgomaticer, no21:28
torgomatic1000^9 * 5 GiB, or roughly 5 trillion yottabytes21:30
torgomaticalso know as "enough"21:31
torgomatic*known21:31
ahalei figured the practical limit will be governed by max_large_object_get_time, but now I'm struggling to see where thats actually used in swift21:37
torgomaticahale: it's in common.request_helpers.SegmentedIterable21:38
ahaleahh yeah21:40
claygahale: !!!!21:41
ahalehey clay21:41
clayglol, yeah good point - you're limited to how much you can download in what - 10 hours?21:42
zaitcevcome on guys, I wanted to calclulate it myself21:42
zaitcevBut thanks21:42
*** jrichli has quit IRC21:43
claygyou can't throw a fun problem out there to a bunch of hackers - it's like catnip21:44
zaitcevtell me this is an April Fool's joke - https://review.openstack.org/#/c/169897/1/.gitreview21:50
zaitcevugh21:51
zaitcev * [new branch]      feature/ec_review -> origin/feature/ec_review21:51
openstackgerritpaul luse proposed openstack/swift: Erasure Code Reconstructor  https://review.openstack.org/13187221:52
ahaleso if it turned out your limiting factor in downloadable file size is the sata drive in the object server, would EC let you speed that up?21:52
peluseclayg, that ones for you!  ^^21:52
zaitcevUSB 3.1 might21:52
zaitcevor Fusion-IO21:52
ahaleour finance team would love fusion io storage21:53
openstackgerritpaul luse proposed openstack/swift: EC Reconstructor Probe Tests  https://review.openstack.org/16429121:55
openstackgerritpaul luse proposed openstack/swift: Fix ssync sender behavior for EC reconstructor jobs  https://review.openstack.org/16905221:57
*** fern has quit IRC22:03
*** ekarlso has quit IRC22:04
*** ekarlso has joined #openstack-swift22:04
*** 77CAAKTHH has joined #openstack-swift22:13
*** 77CAAKTHH has quit IRC22:23
*** lcurtis has quit IRC22:30
*** joeljwright1 has quit IRC22:39
*** annegentle has joined #openstack-swift22:48
*** annegentle has quit IRC22:48
*** annegentle has joined #openstack-swift22:58
pelusewow acoles_away ssync tests look great!23:06
*** chlong has joined #openstack-swift23:07
*** thumpba has quit IRC23:11
*** thumpba has joined #openstack-swift23:11
*** annegentle has quit IRC23:15
*** kei_yama has joined #openstack-swift23:19
*** petertr7 has quit IRC23:21
*** thumpba has quit IRC23:28
*** thumpba_ has joined #openstack-swift23:28
*** annegentle has joined #openstack-swift23:29
*** ChanServ changes topic to "Soft freeze of master in effect | EC Merge plan: https://etherpad.openstack.org/p/ec_merge_plan | Review Dashboard: http://goo.gl/uRzLBX | Logs: http://eavesdrop.openstack.org/irclogs/%23openstack-swift/"23:30
*** rdaly2 has quit IRC23:30
*** jrichli has joined #openstack-swift23:31
notmynameok, channel topic updated. soft freeze of master in effect23:32
*** annegentle has quit IRC23:37
openstackgerritJanie Richling proposed openstack/swift: WIP - Provides a simple skeleton of middleware for encryption feature.  https://review.openstack.org/15790723:38
claygzaitcev: what part is funny?23:40
*** mahatic has quit IRC23:41
*** mahatic has joined #openstack-swift23:42
mattoliverauSo has Nebula really gone out of business or is it just an april fools? Being a day a head can be problematic as I read things on April 1st with skeptasism but by the 2nd I forget too :P23:43
pelusenotmyname, do you a link to our etherpad for summit ideas?23:43
peluseis this it? https://wiki.openstack.org/wiki/Design_Summit/Kilo/Etherpads#Swift23:47
claygtorgomatic: you around?23:47
claygi'm looking at a change to test/unit/proxy/test_sysmeta - it doesn't seem to be needed?23:48
claygcan you diff that file from feature/ec and master and tell me what you were thinking in 04d87c8?23:48
peluseclayg, fyi im out for a few hrs but when I get back I will review acoles ssync test and fix the one intermittent test issues with the ECrecon (stupid list ordering comparison thing)23:48
claygtorgomatic: I guess with the EC PUT extraction it's just not relevant anymore23:49
claygmattoliverau: i think it might be legit - but i'm way scared that we're all going to look the fool tomorrow23:50
mattoliverauclayg: yeah, I guess time will really tell. If it is real, what an annoying day to annouce it :P23:51
pelusenotmyname, i meant for liberty not kilo23:52
claygmattoliverau: forbes picked it up - would be nice for someone to confirm something - no one is even addressing the fact that this announcement came out *today* of all days23:53
mattoliverauclayg: Which is why I was suspicous, but talking to some of the guys on my team here, they say it might be legit.. they know a few guys working there.. unless everyones in on it.. I guess we'll find out tomorrow23:54
*** zhill has quit IRC23:55
*** mahatic has quit IRC23:57
mattoliverautorgomatic: RE: Multi-Range GETS.. so far so good.. not failing when I re attempted what I tried previously! Looks like it's working :) Now to go and throw alot more test data at it.23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!