| kota_ | eranrom: quick report for py3, patch 452673 works well with tox -e py35 in my local xenial | 01:44 |
|---|---|---|
| kota_ | i've had concern about the fd leak yet but if it doesn't leak the fd, i think it's the best for now | 01:45 |
| openstackgerrit | Kota Tsuyuzaki proposed openstack/storlets master: Fix py3 unit test failures https://review.openstack.org/452673 | 01:53 |
| eranrom | kota_: Thanks for the update. I do not see how we can leak the fd, given that we are inside a with statement. | 06:23 |
| eranrom | kota_: I will not be able to join the meeting today. Can you run it? There are no special items from my side | 06:24 |
| eranrom | Also, I have squashed all ipython stuff into https://review.openstack.org/#/c/452649/ | 06:26 |
| kota_ | eranrom: ok, will do that | 07:06 |
| kota_ | eranrom: IIRC, the with context should be a solution to prevent un-closed file (and it's fd) and it's preferred than call open like `f = open(file)` | 07:08 |
| kota_ | eranrom: FWIW, what i can tell you is the py3 failure is from the os.close was called more than we expected. | 07:10 |
| kota_ | eranrom: i think, it's from the diff between py2-py3 but it seems like py3 is using os.close to close the fd in the with context | 07:10 |
| kota_ | eranrom: so that I'm realizing to think the best way is to leave the open file handling to the native handler as possible | 07:11 |
| openstackgerrit | Merged openstack/storlets master: Fix py3 unit test failures https://review.openstack.org/452673 | 07:59 |
| *** takashi has joined #openstack-storlets | 08:25 | |
| takashi | fyi, talking about a little future stuff, I do not attend to Boston summit | 08:26 |
| takashi | while I don't know any kind of developer discussion can happen there | 08:27 |
| *** takashi has quit IRC | 08:29 | |
| eranrom | Takashi, thanks for the update | 14:55 |
| eranrom | I will also not attend | 14:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!