*** deblike has quit IRC | 00:05 | |
*** yuanying-afk is now known as yuanying | 00:06 | |
openstackgerrit | Merged openstack/syntribos: Adding missing checks https://review.openstack.org/340473 | 00:09 |
---|---|---|
*** tmcpeak1 has quit IRC | 00:09 | |
*** browne has quit IRC | 00:13 | |
*** austin987 has quit IRC | 00:14 | |
unrahul | finally that patch got merged, thanks ccneill ! | 00:14 |
ccneill | np! | 00:14 |
*** davidjd-gh has joined #openstack-security | 00:16 | |
ccneill | wanna +2 this one before you head out for the day? https://review.openstack.org/#/c/313190/ | 00:16 |
ccneill | :D | 00:16 |
davidjd-gh | hello | 00:16 |
ccneill | I think these unittests will help us keep from breaking master | 00:16 |
ccneill | as you said | 00:17 |
ccneill | unrahul: ^ | 00:17 |
unrahul | :D | 00:17 |
unrahul | yup | 00:17 |
unrahul | already done, | 00:17 |
ccneill | nice, ty | 00:17 |
unrahul | see u later ccneill | 00:17 |
ccneill | have a good night unrahul | 00:17 |
unrahul | +1 | 00:19 |
*** davidjd-gh has left #openstack-security | 00:25 | |
*** austin987 has joined #openstack-security | 00:27 | |
*** markvoelker has quit IRC | 00:30 | |
*** markvoelker has joined #openstack-security | 00:31 | |
*** markvoelker has quit IRC | 00:36 | |
*** JAHoagie has quit IRC | 00:40 | |
*** davidjd-gh has joined #openstack-security | 00:41 | |
*** davidjd-gh has left #openstack-security | 00:41 | |
*** davidjd-gh has joined #openstack-security | 00:52 | |
*** davidjd-gh has left #openstack-security | 00:52 | |
*** tmcpeak has joined #openstack-security | 00:57 | |
*** salv-orlando has joined #openstack-security | 01:00 | |
*** salv-orlando has quit IRC | 01:08 | |
*** browne has joined #openstack-security | 01:09 | |
*** browne has quit IRC | 01:09 | |
*** tkelsey has joined #openstack-security | 01:12 | |
*** tkelsey has quit IRC | 01:17 | |
*** davidjd-gh has joined #openstack-security | 01:18 | |
*** zul has quit IRC | 01:19 | |
*** vinaypotluri has quit IRC | 01:21 | |
*** davidjd-gh has quit IRC | 01:22 | |
*** zul has joined #openstack-security | 01:37 | |
*** deblike has joined #openstack-security | 01:49 | |
*** salv-orlando has joined #openstack-security | 02:07 | |
*** salv-orlando has quit IRC | 02:17 | |
*** Coleoptera has joined #openstack-security | 02:20 | |
*** nkinder has quit IRC | 02:21 | |
*** nkinder has joined #openstack-security | 02:26 | |
*** Coleoptera has quit IRC | 02:28 | |
*** eric_lopez has joined #openstack-security | 02:28 | |
*** elo has quit IRC | 02:30 | |
*** markvoelker has joined #openstack-security | 02:32 | |
*** markvoelker has quit IRC | 02:38 | |
*** Coleoptera has joined #openstack-security | 02:42 | |
*** yuanying has quit IRC | 02:52 | |
*** dave-mcc_ has quit IRC | 02:58 | |
*** trecko1 has joined #openstack-security | 03:07 | |
*** trecko1 has left #openstack-security | 03:07 | |
*** elo has joined #openstack-security | 03:12 | |
*** eric_lopez has quit IRC | 03:14 | |
*** salv-orlando has joined #openstack-security | 03:16 | |
*** salv-orlando has quit IRC | 03:26 | |
*** edtubill has joined #openstack-security | 03:44 | |
*** deblike has quit IRC | 03:45 | |
*** deblike has joined #openstack-security | 03:45 | |
*** yuanying has joined #openstack-security | 03:45 | |
*** deblike has quit IRC | 03:45 | |
*** Coleoptera has quit IRC | 04:18 | |
*** jerrygb has joined #openstack-security | 04:22 | |
*** salv-orlando has joined #openstack-security | 04:24 | |
*** salv-orlando has quit IRC | 04:34 | |
*** markvoelker has joined #openstack-security | 04:34 | |
*** markvoelker has quit IRC | 04:40 | |
*** deblike has joined #openstack-security | 04:46 | |
*** deblike has quit IRC | 04:51 | |
*** salv-orlando has joined #openstack-security | 04:56 | |
*** tmcpeak has quit IRC | 05:21 | |
*** jerrygb has quit IRC | 05:30 | |
*** edtubill has quit IRC | 05:42 | |
*** edtubill has joined #openstack-security | 05:42 | |
openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding unittests for checks https://review.openstack.org/344034 | 05:42 |
*** elo has quit IRC | 05:44 | |
*** elo has joined #openstack-security | 05:46 | |
*** edtubill has quit IRC | 05:47 | |
*** deblike has joined #openstack-security | 05:47 | |
openstackgerrit | Merged openstack/syntribos: Adding unit tests for Runner https://review.openstack.org/313190 | 05:49 |
*** deblike has quit IRC | 05:52 | |
*** salv-orlando has quit IRC | 06:05 | |
*** rcernin has joined #openstack-security | 06:10 | |
*** eric_lopez has joined #openstack-security | 06:10 | |
*** elo has quit IRC | 06:12 | |
*** tkelsey has joined #openstack-security | 06:16 | |
*** elo has joined #openstack-security | 06:17 | |
*** eric_lopez has quit IRC | 06:19 | |
*** tkelsey has quit IRC | 06:20 | |
*** markvoelker has joined #openstack-security | 06:26 | |
*** markvoelker has quit IRC | 06:32 | |
*** pcaruana has joined #openstack-security | 06:36 | |
*** salv-orlando has joined #openstack-security | 06:38 | |
*** elo has quit IRC | 06:48 | |
*** deblike has joined #openstack-security | 06:48 | |
*** salv-orl_ has joined #openstack-security | 06:48 | |
*** salv-orlando has quit IRC | 06:51 | |
*** elo has joined #openstack-security | 06:52 | |
*** deblike has quit IRC | 06:53 | |
*** eric_lopez has joined #openstack-security | 06:56 | |
*** elo has quit IRC | 06:58 | |
*** tesseract- has joined #openstack-security | 06:58 | |
*** liverpooler has joined #openstack-security | 07:03 | |
*** elo has joined #openstack-security | 07:03 | |
*** eric_lopez has quit IRC | 07:05 | |
*** eric_lopez has joined #openstack-security | 07:07 | |
*** elo has quit IRC | 07:09 | |
*** jerrygb has joined #openstack-security | 07:32 | |
*** jerrygb has quit IRC | 07:37 | |
*** salv-orl_ has quit IRC | 07:38 | |
*** elo has joined #openstack-security | 07:41 | |
*** eric_lopez has quit IRC | 07:43 | |
*** elo has quit IRC | 07:49 | |
*** salv-orlando has joined #openstack-security | 07:58 | |
*** tkelsey has joined #openstack-security | 08:02 | |
*** jass93 has quit IRC | 08:26 | |
*** markvoelker has joined #openstack-security | 08:29 | |
*** unrahul has quit IRC | 08:42 | |
*** salv-orlando has quit IRC | 08:42 | |
*** jass93 has joined #openstack-security | 08:48 | |
*** salv-orlando has joined #openstack-security | 09:09 | |
*** salv-orl_ has joined #openstack-security | 09:16 | |
*** salv-orlando has quit IRC | 09:19 | |
*** salv-orl_ has quit IRC | 09:20 | |
*** aastha has quit IRC | 09:49 | |
*** markvoelker has quit IRC | 10:33 | |
*** jerrygb has joined #openstack-security | 10:51 | |
*** jerrygb has quit IRC | 10:56 | |
*** openstackgerrit has quit IRC | 11:41 | |
*** openstackgerrit has joined #openstack-security | 11:41 | |
*** jerrygb has joined #openstack-security | 11:57 | |
*** edmondsw has joined #openstack-security | 12:21 | |
*** markvoelker has joined #openstack-security | 12:29 | |
*** markvoelker has quit IRC | 12:35 | |
*** markvoelker has joined #openstack-security | 12:44 | |
*** kun_huang has quit IRC | 12:46 | |
*** markvoelker_ has joined #openstack-security | 12:46 | |
*** markvoelker has quit IRC | 12:46 | |
*** kun_huang has joined #openstack-security | 12:46 | |
*** deblike has joined #openstack-security | 13:04 | |
*** dave-mccowan has joined #openstack-security | 13:11 | |
*** d0ugal has joined #openstack-security | 13:19 | |
*** salv-orlando has joined #openstack-security | 13:23 | |
*** salv-orl_ has joined #openstack-security | 13:25 | |
*** cleong has joined #openstack-security | 13:26 | |
*** salv-or__ has joined #openstack-security | 13:27 | |
*** salv-orlando has quit IRC | 13:29 | |
*** salv-orlando has joined #openstack-security | 13:29 | |
*** salv-orl_ has quit IRC | 13:30 | |
*** salv-or__ has quit IRC | 13:33 | |
*** d0ugal has quit IRC | 13:39 | |
*** BigWillie has joined #openstack-security | 13:40 | |
*** jmckind has joined #openstack-security | 13:46 | |
*** jmckind has quit IRC | 13:48 | |
*** jmckind has joined #openstack-security | 13:53 | |
*** woodburn has joined #openstack-security | 14:02 | |
*** liverpooler has quit IRC | 14:08 | |
*** d0ugal has joined #openstack-security | 14:18 | |
*** jmckind has quit IRC | 14:18 | |
*** jmckind has joined #openstack-security | 14:21 | |
*** d0ugal has quit IRC | 14:23 | |
*** d0ugal has joined #openstack-security | 14:24 | |
*** mvaldes has joined #openstack-security | 14:33 | |
*** tmcpeak has joined #openstack-security | 14:36 | |
*** sdake has joined #openstack-security | 14:39 | |
*** zul has quit IRC | 14:49 | |
*** elo has joined #openstack-security | 14:56 | |
*** d0ugal has quit IRC | 14:59 | |
*** vinaypotluri has joined #openstack-security | 15:01 | |
*** zul has joined #openstack-security | 15:02 | |
*** mvaldes1 has joined #openstack-security | 15:02 | |
*** mvaldes has quit IRC | 15:03 | |
*** mvaldes has joined #openstack-security | 15:04 | |
*** mvaldes1 has quit IRC | 15:07 | |
*** woodburn has quit IRC | 15:07 | |
*** unrahul has joined #openstack-security | 15:08 | |
*** jmckind has quit IRC | 15:12 | |
tmcpeak | gmurphy: is sicarie around? | 15:19 |
*** sdake has quit IRC | 15:28 | |
*** Verofede0204 has joined #openstack-security | 15:31 | |
*** jmckind has joined #openstack-security | 15:31 | |
*** Verofede0204 has left #openstack-security | 15:32 | |
*** d0ugal has joined #openstack-security | 15:35 | |
*** salv-orlando has quit IRC | 15:35 | |
gmurphy | tmcpeak: get a hold of him? i'll ping him | 15:35 |
*** catintheroof has joined #openstack-security | 15:35 | |
tmcpeak | gmurphy: awesome, please do | 15:36 |
*** sicarie has joined #openstack-security | 15:37 | |
* sicarie waves | 15:37 | |
gmurphy | tmcpeak: ==^ | 15:38 |
tmcpeak | sicarie: hey | 15:38 |
tmcpeak | what's the status with the security guide checklists? | 15:38 |
tmcpeak | are they finished? part way? | 15:38 |
sicarie | good question, that’s on my list of stuff to call out for the list i’m making for hyakuhei | 15:38 |
sicarie | afaik we have just over 5 | 15:39 |
sicarie | major services covered | 15:39 |
tmcpeak | how many did you want to get? | 15:39 |
sicarie | ideally, all the ones covered in the secguide | 15:39 |
tmcpeak | is there anybody that's going to continue work or TBD? | 15:39 |
sicarie | however, i’d be willing to be more flexible on stuff like manila | 15:39 |
sicarie | yes, I am going to be doing that once i get ramped back up | 15:39 |
tmcpeak | awesome, and the 5 are fully completed? | 15:40 |
sicarie | let me check before i stick your foot in my mouth | 15:40 |
tmcpeak | haha, ok thank you | 15:40 |
sicarie | #link http://docs.openstack.org/security-guide/checklist.html | 15:41 |
sicarie | There’s definite room for improvement, but these are a solid start | 15:43 |
tmcpeak | awesome, thank you sicarie | 15:43 |
sicarie | 6 of them, and ones for db’s etc should follow quickly | 15:43 |
sicarie | np | 15:43 |
tmcpeak | thanks for grabbing him gmurphy :) | 15:43 |
*** deblike has quit IRC | 15:49 | |
gmurphy | np | 15:49 |
*** sdake has joined #openstack-security | 15:50 | |
*** salv-orlando has joined #openstack-security | 15:52 | |
*** deblike has joined #openstack-security | 15:55 | |
*** mdong has joined #openstack-security | 16:00 | |
*** d0ugal has quit IRC | 16:04 | |
openstackgerrit | Rahul U Nair proposed openstack/syntribos: Modify auto-compelete to reflect the new CLI https://review.openstack.org/344347 | 16:09 |
*** browne has joined #openstack-security | 16:15 | |
*** mvaldes has quit IRC | 16:17 | |
*** mvaldes has joined #openstack-security | 16:19 | |
*** mvaldes has quit IRC | 16:19 | |
*** mvaldes has joined #openstack-security | 16:21 | |
*** jmckind has quit IRC | 16:31 | |
*** woodburn has joined #openstack-security | 16:32 | |
*** austin987 has quit IRC | 16:33 | |
*** d0ugal has joined #openstack-security | 16:38 | |
*** austin987 has joined #openstack-security | 16:46 | |
*** tesseract- has quit IRC | 16:47 | |
*** rcernin has quit IRC | 16:49 | |
ccneill | unrahul, vinaypotluri, mdong : here's the CR I was mentioning at the end of our standup for the request object parity bug https://review.openstack.org/#/c/343953/ | 16:52 |
ccneill | I'll look for a better solution, but for now that will at least fix master | 16:53 |
ccneill | also, this one from mdong needs a +2: https://review.openstack.org/#/c/343098/ | 16:53 |
*** salv-orlando has quit IRC | 16:55 | |
*** sicarie has quit IRC | 16:55 | |
ccneill | unrahul: I wonder if we should make a file /tests/unit/utils.py for stuff like your FakeTestObject class | 16:56 |
ccneill | since I think it gets used in a few different files | 16:57 |
ccneill | probably handy to have for several reasons | 16:57 |
*** salv-orlando has joined #openstack-security | 16:58 | |
ccneill | thank you for adding unittests for these checks though! good stuff! | 16:58 |
unrahul | Hey ccneill yup, I think we should | 17:04 |
unrahul | I was thinking of adding unit tests for our tests also which would involve some mocking as well.. So may be I shall make a utils for all these and add all these classes in it.. | 17:05 |
ccneill | yep yep yep | 17:07 |
ccneill | good idea | 17:07 |
ccneill | you were up late last night! just saw the email from Jenkins at 12:40 :o | 17:07 |
openstackgerrit | Merged openstack/syntribos: added CLI option to exclude tests from runner https://review.openstack.org/343098 | 17:12 |
*** sdake has quit IRC | 17:12 | |
openstackgerrit | Merged openstack/syntribos: First pass at fix for bug #1604187 https://review.openstack.org/343953 | 17:14 |
openstack | bug 1604187 in syntribos "Inconsistencies between requestslib PreparedRequest and syntribos' RequestObject" [Medium,New] https://launchpad.net/bugs/1604187 - Assigned to Charles Neill (charles-neill) | 17:14 |
ccneill | wooot! syntribos is no longer broken in master ^^; | 17:18 |
*** sdake has joined #openstack-security | 17:20 | |
unrahul | 😀.. Ehh mm.. When was it broken?? 😀.. I don't recollect it all.. | 17:23 |
*** mvaldes has quit IRC | 17:26 | |
ccneill | O:-) if a fixup CR lands before anyone outside the dev team clones the broken version, did it ever break? | 17:31 |
*** zul has quit IRC | 17:38 | |
*** zul has joined #openstack-security | 17:39 | |
*** sdake has quit IRC | 17:41 | |
ccneill | hey OSSP folks, is this list for completed projects only, and if not, how do we add Syntribos to the list? https://security.openstack.org/#security-tool-development | 17:45 |
ccneill | "completed" meaning "1.0/stable" | 17:45 |
unrahul | Hey.. :D no comments.. | 17:45 |
unrahul | haha* | 17:45 |
unrahul | Hey ccneill my comment on that auto-completion change "I had a hunch you would say that, and I have finally transitioned to zsh so it doesn't work for me too...should we remove this all together for now as now the cafe dependencies exist.." what do you think we should do? | 17:48 |
ccneill | yeah I'm good with deleting it for now | 17:48 |
ccneill | if we really find it to be a must-have feature later, we can look into making it cross-compatible | 17:49 |
ccneill | but I think we have more pressing needs at the moment, and we can do without it since the params are clearer now | 17:49 |
unrahul | yup! makes sense. | 17:51 |
openstackgerrit | Rahul U Nair proposed openstack/syntribos: Modify auto-compelete to reflect the new CLI https://review.openstack.org/344347 | 17:52 |
ccneill | another thing we could probably stand to do is cleaning up our data/ dir | 17:54 |
unrahul | mdong: https://review.openstack.org/#/c/344034/ could you please see if this patch is good to be merged? | 17:55 |
unrahul | bufferoverflow.txt does not having anything in it.. I forgot.. why we have the file there, any reason? | 17:56 |
unrahul | Also ccneill you have an idea on how we should do it, ? cleaning up the data dir, renaming the files and all..? or merging couple of them..? | 17:57 |
*** woodburn has quit IRC | 18:03 | |
*** sdake has joined #openstack-security | 18:06 | |
ccneill | I have some ideas, but I don't have an answer off-hand | 18:06 |
ccneill | I've never really been a fan of having to define the relevant textfile in the test that uses it | 18:06 |
*** davidjd-gh has joined #openstack-security | 18:07 | |
*** davidjd-gh has left #openstack-security | 18:07 | |
ccneill | e.g. in tests like this: https://github.com/openstack/syntribos/blob/master/syntribos/tests/fuzz/ldap.py | 18:07 |
ccneill | seems like we could compact that a bit.. | 18:08 |
ccneill | since it's almost all boilerplate / stuff we could derive from the main test nmae | 18:08 |
ccneill | name* | 18:08 |
*** aastha has joined #openstack-security | 18:08 | |
ccneill | ¯\_(ツ)_/¯ I suppose we might want to do something different between e.g. headers and body, but we don't really do that today (e.g. https://github.com/openstack/syntribos/blob/master/syntribos/tests/fuzz/sql.py) | 18:09 |
*** jmckind has joined #openstack-security | 18:09 | |
unrahul | oh.. yeah.. but then.. there wont be much to write in the testcase.. ? , | 18:10 |
unrahul | yeah.. it is pretty linear and non related.. | 18:10 |
unrahul | I guess when pipelining comes it would be advantageous to specifically control which part like header body and which type of tests to be run and when.. | 18:11 |
*** mvaldes has joined #openstack-security | 18:11 | |
ccneill | right well.. I just wonder if it would be worth it to maybe have a FullFuzzTest that inherits from BaseFuzzTestCase that just goes ahead and extends it for each type automatically (body, header, param, url) | 18:12 |
ccneill | so if you want to handle things differently, you can inherit from BFTC, but if you just want a generic test like the LDAP one, you just have to inherit from FFT | 18:13 |
ccneill | FFTC* | 18:13 |
ccneill | maybe similar to extend_class | 18:13 |
unrahul | oh.. then we wouldnt want to repeat the header/body/params in most tests as it is the default.. behavior..? | 18:14 |
ccneill | I mean, I think it's just more intuitive that way | 18:15 |
ccneill | or at least to have the option to do it that way is more intuitive | 18:15 |
ccneill | we don't do anything different between body and the other classes in any of our current fuzz tests | 18:16 |
ccneill | probably not the most important thing to worry about right this minute, but I'll think about it some more | 18:19 |
*** davidjd-gh has joined #openstack-security | 18:22 | |
*** davidjd-gh has left #openstack-security | 18:22 | |
*** woodburn has joined #openstack-security | 18:29 | |
*** mdong has quit IRC | 18:30 | |
unrahul | ccneill: yeah.. that would remove lot of repetitions in the code.. and may it lil bit concise.. but one thing is that, if we don't split into a different file /class, it would be like most of the logic for fuzz tests would remain in base_fuzz .. which is not that intutive.. a new user may find it difficult to use the APIs or know whats going on behind all | 18:30 |
unrahul | the magic.. | 18:30 |
ccneill | aww, but magic is always good :P | 18:30 |
ccneill | true | 18:30 |
ccneill | but all the logic already kind of lives in BFTC.. :\ | 18:32 |
ccneill | we should probably try to make BFTC better before we start doing anything else | 18:32 |
*** davidjd-gh1 has joined #openstack-security | 18:32 | |
ccneill | i.e. data_driven_pass_cases, _get_strings | 18:32 |
*** davidjd-gh1 has left #openstack-security | 18:32 | |
unrahul | yeah.. we need to.. sometimes.. i get all worked up.. seeing the mixins.. the fuzz base class and all.. it some how feels not so straight forward as other parts.. :/ | 18:33 |
unrahul | yup.. | 18:33 |
*** mdong has joined #openstack-security | 18:43 | |
*** catintheroof has quit IRC | 18:45 | |
ccneill | ugh.. "mixins" | 18:50 |
ccneill | v_v | 18:50 |
ccneill | defined in separate files, that really only represent functionality that should be in the main class, but that are spread out and only have fun names like "_build_str_combinations" | 18:51 |
*** sdake_ has joined #openstack-security | 18:55 | |
*** sdake has quit IRC | 18:57 | |
*** tkelsey has quit IRC | 19:00 | |
unrahul | hehe yup!. | 19:05 |
*** davidjd-gh1 has joined #openstack-security | 19:08 | |
*** davidjd-gh1 has left #openstack-security | 19:09 | |
*** davidjd-gh has joined #openstack-security | 19:10 | |
*** salv-orlando has quit IRC | 19:10 | |
*** salv-orlando has joined #openstack-security | 19:10 | |
openstackgerrit | Merged openstack/syntribos: Modify auto-compelete to reflect the new CLI https://review.openstack.org/344347 | 19:16 |
*** davidjd-gh has quit IRC | 19:18 | |
*** davidjd-gh has joined #openstack-security | 19:21 | |
*** davidjd-gh has left #openstack-security | 19:21 | |
unrahul | vinaypotluri: https://review.openstack.org/#/c/344034/ could you kindly review this CR? | 19:24 |
*** davidjd-gh has joined #openstack-security | 19:32 | |
*** davidjd-gh has left #openstack-security | 19:32 | |
*** davidjd-gh has joined #openstack-security | 19:33 | |
davidjd-gh | ChanServ lag | 19:34 |
*** davidjd-gh has left #openstack-security | 19:34 | |
ccneill | unrahul: looks like your auto-complete thing merged ^ | 19:51 |
ccneill | wonder why it took so long.. | 19:51 |
openstackgerrit | Merged openstack/syntribos: Adding unittests for checks https://review.openstack.org/344034 | 19:57 |
*** davidjd-gh has joined #openstack-security | 19:57 | |
*** davidjd-gh has left #openstack-security | 19:58 | |
*** tkelsey has joined #openstack-security | 19:58 | |
*** tkelsey has quit IRC | 20:02 | |
*** jmckind has quit IRC | 20:04 | |
*** zul has quit IRC | 20:09 | |
*** mdong has quit IRC | 20:09 | |
*** zul has joined #openstack-security | 20:11 | |
*** davidjd-gh has joined #openstack-security | 20:12 | |
unrahul | vinaypotluri: check this config, https://gist.github.com/rahulunair/4066fc3212d6769d05cb389dc2fdd5c0 , it should work | 20:13 |
davidjd-gh | hello | 20:13 |
*** davidjd-gh has left #openstack-security | 20:14 | |
*** mdong has joined #openstack-security | 20:21 | |
*** davidjd-gh has joined #openstack-security | 20:23 | |
*** davidjd-gh has left #openstack-security | 20:23 | |
*** davidjd-gh has joined #openstack-security | 20:30 | |
*** davidjd-gh has left #openstack-security | 20:30 | |
*** davidjd-gh has joined #openstack-security | 20:48 | |
*** davidjd-gh has left #openstack-security | 20:48 | |
*** rcernin has joined #openstack-security | 20:54 | |
*** cleong has quit IRC | 20:59 | |
*** _elmiko is now known as elmiko | 21:02 | |
*** BigWillie has quit IRC | 21:05 | |
*** mihero has quit IRC | 21:07 | |
*** dave-mccowan has quit IRC | 21:11 | |
*** davidjd-gh has joined #openstack-security | 21:12 | |
*** davidjd-gh has left #openstack-security | 21:12 | |
*** davidjd-gh has joined #openstack-security | 21:14 | |
*** davidjd-gh has left #openstack-security | 21:14 | |
aastha | hey ccneill in the debug log we have to separate fields for response_time and test_elapsed_time, do we actually need both these fields, since I dont think think there would be much of a difference in both the times. I guess test_elapsed_time is essentially a subset(in terms of time taken) of the response_time. just wanted to check with you on that part. | 21:25 |
ccneill | I think we want both. for instance, we might want to see that init_resp took 2 seconds and the test_resp took 10 seconds | 21:26 |
ccneill | if we only show the time taken by the entire test, it just looks like a long test, but if you see the two pieces, you can see that we caused something to happen between init_req and test_req that made the server respond more slowly | 21:27 |
ccneill | it's also helpful for tweaking the max_time and time_diff_percentage configuration options. e.g. if you have max_time set to 5, and every request takes 5.5 seconds, you might bump it to 10 | 21:27 |
ccneill | sound reasonable? | 21:30 |
*** woodburn has quit IRC | 21:40 | |
unrahul | aastha: is the test_elapsed_time right now only checking the time taken to send the request, or is it the time to run the test..? | 21:42 |
unrahul | aastha: replace the config and use syntribos --config-file <config | 22:01 |
unrahul | aastha: replace the config and use syntribos --config-file <config_filename> -t CORS | 22:01 |
aastha | yes ccneill that makes sense. | 22:06 |
ccneill | cool cool | 22:06 |
ccneill | I'm trying to figure out how to reconcile RequestObject/FuzzReqests with requests.PreparedRequest.. so many bad options lol | 22:07 |
aastha | urahul test_elapsed_time is not there right now i believe, it is the total time to run the tests | 22:07 |
unrahul | aastha: :) okay | 22:07 |
*** mvaldes has quit IRC | 22:08 | |
aastha | yes i checked that too ccneill there are endless options in there.. | 22:09 |
*** elmiko is now known as _elmiko | 22:10 | |
ccneill | if only it wasn't so hard to do a pygraph of syntribos lol | 22:11 |
unrahul | :D | 22:11 |
ccneill | >< | 22:11 |
ccneill | hmm | 22:11 |
unrahul | but now, may be things have changed | 22:11 |
ccneill | let me see what it looks like now | 22:11 |
ccneill | yeah | 22:11 |
ccneill | haven't tried in a while | 22:11 |
unrahul | after adding the signals and checks.. | 22:11 |
ccneill | yeah at least my pycallgraph call doesn't have to include a CAFE_ env var lol | 22:13 |
ccneill | we'll see | 22:13 |
ccneill | if I run it with just a few test types it's probably easier to read | 22:14 |
ccneill | but when you run it with all, it generates soooo many classes >_< | 22:14 |
unrahul | oh yeah... ! I remember you had to do some hacking to make it work that time.. | 22:15 |
unrahul | Even if run it for one test..? | 22:15 |
ccneill | shouldn't be as bad for one tets | 22:15 |
ccneill | test | 22:15 |
ccneill | o_o | 22:16 |
ccneill | http://i.imgur.com/mVwIhiW.jpg | 22:17 |
ccneill | mmm those identity models.. | 22:17 |
*** salv-orl_ has joined #openstack-security | 22:21 | |
unrahul | :o | 22:23 |
*** salv-orlando has quit IRC | 22:23 | |
unrahul | still a lil crazy.. between the prepared copy call and issue.. lot of control flows.. | 22:23 |
unrahul | i guess if we run this against any project.. it would be a similar exp.. | 22:24 |
*** mdong has quit IRC | 22:26 | |
unrahul | ccneill: vinaypotluri aastha guys, I am signing off lil early today, not feeling so well, catch you guys later. | 22:27 |
ccneill | no worries! get feeling better unrahul | 22:27 |
*** davidjd-gh has joined #openstack-security | 22:28 | |
*** davidjd-gh has left #openstack-security | 22:30 | |
openstackgerrit | Vinay Potluri proposed openstack/syntribos: Added string presence check https://review.openstack.org/344489 | 22:32 |
openstackgerrit | Vinay Potluri proposed openstack/syntribos: Removed OpenCafe installation instructions https://review.openstack.org/343900 | 22:40 |
*** davidjd-gh has joined #openstack-security | 22:44 | |
*** davidjd-gh has left #openstack-security | 22:44 | |
*** mihero has joined #openstack-security | 22:45 | |
vinaypotluri | aastha: run this syntribos --config-file configs/vAPI.config -t CORS | 22:54 |
*** tkelsey has joined #openstack-security | 23:01 | |
*** tkelsey has quit IRC | 23:05 | |
*** davidjd-gh has joined #openstack-security | 23:17 | |
*** davidjd-gh has left #openstack-security | 23:17 | |
*** salv-orl_ has quit IRC | 23:19 | |
*** edmondsw has quit IRC | 23:26 | |
*** yeison has joined #openstack-security | 23:57 | |
*** yeison has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!