*** sdake has quit IRC | 00:09 | |
*** markvoelker has joined #openstack-security | 00:39 | |
*** markvoelker has quit IRC | 00:43 | |
*** davidjd-gh has joined #openstack-security | 00:57 | |
*** tmcpeak has quit IRC | 00:58 | |
*** davidjd-gh has left #openstack-security | 00:58 | |
*** deblike has joined #openstack-security | 01:22 | |
*** davidjd-gh has joined #openstack-security | 01:30 | |
*** davidjd-gh has left #openstack-security | 01:31 | |
*** deblike has quit IRC | 02:42 | |
*** elo has joined #openstack-security | 03:39 | |
*** eric_lopez has quit IRC | 03:40 | |
*** edtubill has joined #openstack-security | 03:54 | |
*** markvoelker has joined #openstack-security | 04:40 | |
*** markvoelker has quit IRC | 04:45 | |
*** edtubill has quit IRC | 05:01 | |
*** sdake has joined #openstack-security | 05:04 | |
*** sdake has quit IRC | 05:23 | |
*** sdake has joined #openstack-security | 05:24 | |
*** sdake has quit IRC | 05:56 | |
*** rcernin has joined #openstack-security | 05:57 | |
*** Maria1 has joined #openstack-security | 06:01 | |
*** rcernin has quit IRC | 06:04 | |
*** Maria1 has quit IRC | 06:06 | |
*** rcernin has joined #openstack-security | 06:17 | |
*** jass93 has quit IRC | 06:24 | |
*** pcaruana has joined #openstack-security | 06:29 | |
*** bjolo_ has quit IRC | 06:31 | |
*** jass93 has joined #openstack-security | 06:36 | |
*** markvoelker has joined #openstack-security | 06:41 | |
*** tesseract- has joined #openstack-security | 06:45 | |
*** markvoelker has quit IRC | 06:46 | |
*** rcernin has quit IRC | 06:48 | |
*** pcaruana has quit IRC | 06:48 | |
*** sdake has joined #openstack-security | 06:54 | |
*** pcaruana has joined #openstack-security | 07:02 | |
*** rcernin has joined #openstack-security | 07:02 | |
*** liverpooler has joined #openstack-security | 07:07 | |
*** sdake_ has joined #openstack-security | 07:20 | |
*** sdake has quit IRC | 07:20 | |
*** bjolo has joined #openstack-security | 07:31 | |
*** bjolo has quit IRC | 07:41 | |
*** bjolo has joined #openstack-security | 07:41 | |
*** tkelsey has joined #openstack-security | 07:42 | |
*** sdake_ has quit IRC | 07:48 | |
*** sdake has joined #openstack-security | 07:49 | |
*** bjolo_ has joined #openstack-security | 08:02 | |
*** bjolo has quit IRC | 08:05 | |
*** GoMeatal has joined #openstack-security | 08:06 | |
*** bjolo_ has quit IRC | 08:06 | |
*** bjolo_ has joined #openstack-security | 08:06 | |
GoMeatal | hey guys | 08:06 |
---|---|---|
*** bjolo_ is now known as bjolo | 08:09 | |
*** sdake_ has joined #openstack-security | 08:14 | |
*** sdake has quit IRC | 08:14 | |
*** GoMeatal has quit IRC | 08:19 | |
*** bjolo has quit IRC | 08:53 | |
*** bjolo has joined #openstack-security | 08:53 | |
*** sdake_ has quit IRC | 09:40 | |
*** bjolo_ has joined #openstack-security | 10:00 | |
*** bjolo has quit IRC | 10:01 | |
*** bjolo_ has quit IRC | 10:02 | |
*** bjolo_ has joined #openstack-security | 10:03 | |
*** bjolo_ is now known as bjolo | 10:12 | |
*** sdake has joined #openstack-security | 10:46 | |
*** sdake_ has joined #openstack-security | 11:19 | |
*** sdake has quit IRC | 11:23 | |
*** tmcpeak has joined #openstack-security | 11:41 | |
*** tmcpeak has quit IRC | 11:45 | |
*** dave-mccowan has joined #openstack-security | 11:52 | |
*** dave-mcc_ has joined #openstack-security | 11:55 | |
*** dave-mccowan has quit IRC | 11:57 | |
*** edaught has quit IRC | 12:06 | |
*** markvoelker has joined #openstack-security | 12:10 | |
*** edmondsw has joined #openstack-security | 12:33 | |
*** cleong has joined #openstack-security | 12:34 | |
*** mvaldes has joined #openstack-security | 12:47 | |
*** mvaldes1 has joined #openstack-security | 12:49 | |
*** mvaldes1 has quit IRC | 12:51 | |
*** mvaldes has quit IRC | 12:51 | |
*** bknudson_ has joined #openstack-security | 12:58 | |
*** _elmiko is now known as elmiko | 13:00 | |
*** sdake_ has quit IRC | 13:21 | |
*** bknudson_ has left #openstack-security | 13:26 | |
*** deblike has joined #openstack-security | 13:27 | |
*** JAHoagie has joined #openstack-security | 13:38 | |
*** jmckind has joined #openstack-security | 13:38 | |
*** jmckind has quit IRC | 13:41 | |
*** tmcpeak has joined #openstack-security | 13:44 | |
*** tmcpeak has quit IRC | 13:50 | |
*** JAHoagie has quit IRC | 14:00 | |
*** JAHoagie has joined #openstack-security | 14:02 | |
*** catintheroof has joined #openstack-security | 14:03 | |
*** mhayden has quit IRC | 14:10 | |
*** liverpooler has quit IRC | 14:15 | |
*** mvaldes1 has joined #openstack-security | 14:19 | |
*** mvaldes has joined #openstack-security | 14:22 | |
*** tmcpeak has joined #openstack-security | 14:24 | |
*** mvaldes1 has quit IRC | 14:25 | |
*** tmcpeak has quit IRC | 14:28 | |
*** edtubill has joined #openstack-security | 14:32 | |
*** JAHoagie has quit IRC | 14:36 | |
*** mhayden has joined #openstack-security | 14:37 | |
*** sdake has joined #openstack-security | 14:39 | |
*** tmcpeak has joined #openstack-security | 14:41 | |
*** bknudson_ has joined #openstack-security | 14:46 | |
*** bjolo has quit IRC | 14:49 | |
*** mvaldes has quit IRC | 14:52 | |
*** mvaldes has joined #openstack-security | 14:53 | |
*** unrahul has joined #openstack-security | 14:56 | |
*** nkinder has joined #openstack-security | 14:57 | |
*** vinaypotluri has joined #openstack-security | 15:13 | |
*** aastha has joined #openstack-security | 15:22 | |
*** austin987 has quit IRC | 15:29 | |
*** woodburn has quit IRC | 15:48 | |
*** woodburn has joined #openstack-security | 15:51 | |
*** woodburn has quit IRC | 15:56 | |
*** sdake_ has joined #openstack-security | 16:10 | |
*** tesseract- has quit IRC | 16:10 | |
*** sdake has quit IRC | 16:12 | |
openstackgerrit | Rahul U Nair proposed openstack/syntribos: Modifying checks to use test objects https://review.openstack.org/340602 | 16:12 |
openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding missing checks https://review.openstack.org/340473 | 16:15 |
*** sdake_ has quit IRC | 16:18 | |
*** davidjd-gh has joined #openstack-security | 16:19 | |
*** davidjd-gh has left #openstack-security | 16:19 | |
tmcpeak | tkelsey: around? | 16:21 |
tkelsey | I am, how can i help? | 16:21 |
tmcpeak | from a process perspective, how do we make sure something like this: https://review.openstack.org/343352 isn't breaking Bandit is some new and wonderful way? | 16:21 |
*** sdake has joined #openstack-security | 16:21 | |
tkelsey | the unit and functional test still all pass? | 16:23 |
*** ccneill has joined #openstack-security | 16:28 | |
*** sdake_ has joined #openstack-security | 16:41 | |
*** sdake has quit IRC | 16:44 | |
*** woodburn has joined #openstack-security | 16:46 | |
*** JAHoagie has joined #openstack-security | 16:47 | |
*** woodburn has quit IRC | 16:49 | |
tmcpeak | tkelsey: sorry, got distracted by shiny | 16:50 |
tmcpeak | you're right, I guess that should be enough :) | 16:50 |
tmcpeak | that's the point of functional testing | 16:51 |
tkelsey | tmcpeak: yup :) | 16:51 |
*** rcernin has quit IRC | 16:53 | |
*** davidjd-gh1 has joined #openstack-security | 16:57 | |
*** davidjd-gh1 has left #openstack-security | 16:58 | |
*** pcaruana has quit IRC | 16:59 | |
*** mvaldes has quit IRC | 17:02 | |
*** sweston has quit IRC | 17:04 | |
*** kun_huang has quit IRC | 17:04 | |
*** nikhil has quit IRC | 17:05 | |
*** amit213 has quit IRC | 17:05 | |
*** dstanek has quit IRC | 17:05 | |
*** zigo has quit IRC | 17:06 | |
*** zigo has joined #openstack-security | 17:06 | |
*** amit213 has joined #openstack-security | 17:09 | |
*** woodrow has quit IRC | 17:10 | |
*** sweston has joined #openstack-security | 17:10 | |
*** tkelsey has quit IRC | 17:10 | |
*** kun_huang has joined #openstack-security | 17:11 | |
*** dstanek has joined #openstack-security | 17:12 | |
*** woodrow has joined #openstack-security | 17:13 | |
*** hyakuhei has quit IRC | 17:16 | |
*** nikhil has joined #openstack-security | 17:19 | |
*** hyakuhei has joined #openstack-security | 17:20 | |
*** Ryan_Lane has quit IRC | 17:21 | |
*** Ryan_Lane has joined #openstack-security | 17:21 | |
openstackgerrit | Aastha Dixit proposed openstack/syntribos: Cors test file updated https://review.openstack.org/343111 | 17:29 |
openstackgerrit | Aastha Dixit proposed openstack/syntribos: Modified cors test to run cors check https://review.openstack.org/343823 | 17:29 |
*** browne has joined #openstack-security | 17:34 | |
*** rcernin has joined #openstack-security | 17:37 | |
openstackgerrit | Aastha Dixit proposed openstack/syntribos: Cors test file updated https://review.openstack.org/343111 | 17:42 |
openstackgerrit | Merged openstack/bandit: Updated from global requirements https://review.openstack.org/343352 | 17:44 |
openstackgerrit | Aastha Dixit proposed openstack/syntribos: Cors test file updated https://review.openstack.org/343111 | 17:50 |
*** sdake_ has quit IRC | 17:50 | |
*** sdake has joined #openstack-security | 17:57 | |
*** sdake_ has joined #openstack-security | 18:00 | |
*** sdake has quit IRC | 18:01 | |
*** mvaldes has joined #openstack-security | 18:09 | |
*** bjolo has joined #openstack-security | 18:10 | |
*** ccneill has quit IRC | 18:10 | |
*** bjolo has quit IRC | 18:14 | |
*** bjolo has joined #openstack-security | 18:14 | |
*** woodburn has joined #openstack-security | 18:14 | |
*** bjolo has quit IRC | 18:30 | |
*** pcaruana has joined #openstack-security | 18:34 | |
*** PapaDragon has joined #openstack-security | 18:38 | |
*** PapaDragon has left #openstack-security | 18:38 | |
*** PapaDragon has joined #openstack-security | 18:39 | |
*** PapaDragon has left #openstack-security | 18:39 | |
*** woodburn has quit IRC | 18:42 | |
*** ametts has joined #openstack-security | 18:49 | |
*** woodburn has joined #openstack-security | 18:55 | |
*** rcernin has quit IRC | 18:57 | |
*** ccneill has joined #openstack-security | 18:58 | |
openstackgerrit | Aastha Dixit proposed openstack/syntribos: Refactored cors test to use cors header check https://review.openstack.org/343111 | 19:14 |
*** rcernin has joined #openstack-security | 19:15 | |
*** rcernin has quit IRC | 19:16 | |
*** rcernin has joined #openstack-security | 19:16 | |
*** jerrygb has joined #openstack-security | 19:17 | |
*** mvaldes has quit IRC | 19:17 | |
*** jerrygb has quit IRC | 19:18 | |
unrahul | hey ccneill | 19:19 |
unrahul | you here? | 19:19 |
ccneill | yep | 19:19 |
ccneill | looking over your CR now | 19:20 |
unrahul | The adding a counter for Tests, ryt.. can't we have id(self), rather than a counter..? which makes more sense../ | 19:20 |
unrahul | oh.. thanks. .:) hope it gets through this time.. | 19:20 |
ccneill | id(self)? | 19:21 |
ccneill | ah | 19:22 |
unrahul | yeah id of the object.., https://docs.python.org/3/library/functions.html#id | 19:22 |
ccneill | hmm | 19:22 |
ccneill | that's probably fine too | 19:22 |
unrahul | yeah.. saw that in stackoverflow and was thinking.. | 19:22 |
ccneill | hadn't thought of that | 19:22 |
ccneill | oh | 19:22 |
ccneill | hmm | 19:22 |
ccneill | Two objects with non-overlapping lifetimes may have the same id() value. | 19:22 |
ccneill | wonder if that matters to us since we're constantly creating and destroying those test objects.. | 19:22 |
unrahul | ah crap! | 19:23 |
unrahul | that eh.. might.. | 19:23 |
ccneill | maybe you could write a unittest to make sure that there are no overlaps, try the id() method, and if it causes problems, we can look for a better solution | 19:23 |
unrahul | yup.. will do that.. thanks ccneill | 19:23 |
ccneill | np | 19:24 |
unrahul | And thank you for those reviews.. i know its not the most fun thing to do.. :D | 19:24 |
*** woodburn has quit IRC | 19:25 | |
ccneill | it'll go a lot faster once we have some more unittests I think lol | 19:26 |
ccneill | it's kept me pretty aware of all the changes we've been making, which is good | 19:26 |
ccneill | but having to check out the branch and test it locally each time to make sure everything works right.. that takes time | 19:27 |
*** davidjd-gh has joined #openstack-security | 19:34 | |
*** davidjd-gh has left #openstack-security | 19:35 | |
ccneill | unrahul: commented on these 2 CRs - https://review.openstack.org/#/c/340602/ https://review.openstack.org/#/c/340473/ | 19:55 |
ccneill | mainly just need to change some stuff related to config, the rest is minor | 19:55 |
unrahul | yeah. ccneill .. may be we should have had a feature branch.. when we initiated the major change.. but now thingss have settled.. i gues.. | 19:56 |
ccneill | >_< yep | 19:56 |
ccneill | almost there... | 19:57 |
openstackgerrit | Michael Dong proposed openstack/syntribos: Removed openCAFE dependencies from identity extension https://review.openstack.org/338403 | 19:59 |
*** Guest40341 is now known as redrobot | 20:00 | |
openstackgerrit | Merged openstack/syntribos: Refactored cors test to use cors header check https://review.openstack.org/343111 | 20:03 |
openstackgerrit | Michael Dong proposed openstack/syntribos: added CLI option to exclude tests from runner https://review.openstack.org/343098 | 20:07 |
*** tkelsey has joined #openstack-security | 20:08 | |
*** tkelsey has quit IRC | 20:12 | |
*** davidjd-gh1 has joined #openstack-security | 20:12 | |
davidjd-gh1 | hello | 20:13 |
openstackgerrit | Vinay Potluri proposed openstack/syntribos: Removed OpenCafe installation instructions https://review.openstack.org/343900 | 20:14 |
*** mdong has joined #openstack-security | 20:16 | |
tmcpeak | davidjd-gh1: hi, how's it going | 20:16 |
davidjd-gh1 | you speaking espanish? | 20:16 |
tmcpeak | I heard elmiko does | 20:17 |
elmiko | hola! | 20:18 |
davidjd-gh1 | holaelmiko | 20:18 |
*** davidjd-gh1 has left #openstack-security | 20:20 | |
elmiko | guess he just wanted to say hi | 20:20 |
tmcpeak | yeah, I feel the love. You're good people elmiko | 20:20 |
elmiko | lol | 20:21 |
elmiko | =) | 20:21 |
*** sdake_ has quit IRC | 20:24 | |
*** rcernin has quit IRC | 20:38 | |
openstackgerrit | Rahul U Nair proposed openstack/syntribos: Modifying checks to use test objects https://review.openstack.org/340602 | 20:50 |
*** cleong has quit IRC | 21:08 | |
*** tkelsey has joined #openstack-security | 21:10 | |
ccneill | unrahul, vinaypotluri, aastha: can one or more of y'all take a look at this CR? needs a +2. once it merges, it should un-break master https://review.openstack.org/#/c/338403/ | 21:10 |
unrahul | ccneill: yup! | 21:11 |
*** tkelsey has quit IRC | 21:14 | |
*** edtubill has quit IRC | 21:28 | |
openstackgerrit | Merged openstack/syntribos: Removed openCAFE dependencies from identity extension https://review.openstack.org/338403 | 21:28 |
*** krot_vaca_jul19 is now known as krotscheck | 21:30 | |
*** catintheroof has quit IRC | 21:30 | |
*** salv-orlando has joined #openstack-security | 21:41 | |
*** mvaldes has joined #openstack-security | 21:46 | |
*** rcernin has joined #openstack-security | 21:49 | |
*** rcernin has quit IRC | 21:49 | |
openstackgerrit | Michael Dong proposed openstack/syntribos: Refactored Auth test https://review.openstack.org/340477 | 21:53 |
mdong | ccneill rahulunair: had to rebase the auth test due to merge conflict, can you just take a second look real quick? | 21:53 |
ccneill | yep | 21:54 |
*** ametts has quit IRC | 21:56 | |
openstackgerrit | Merged openstack/syntribos: Modifying checks to use test objects https://review.openstack.org/340602 | 22:00 |
*** mvaldes has quit IRC | 22:01 | |
openstackgerrit | Merged openstack/syntribos: Refactored Auth test https://review.openstack.org/340477 | 22:03 |
*** elmiko is now known as _elmiko | 22:06 | |
*** amit213 has quit IRC | 22:13 | |
*** amit213 has joined #openstack-security | 22:13 | |
*** mdong has quit IRC | 22:18 | |
openstackgerrit | Charles Neill proposed openstack/syntribos: Adding unit tests for Runner https://review.openstack.org/313190 | 22:24 |
*** edmondsw has quit IRC | 22:38 | |
openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding missing checks https://review.openstack.org/340473 | 22:59 |
*** pcaruana has quit IRC | 23:05 | |
*** tkelsey has joined #openstack-security | 23:11 | |
openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding missing checks https://review.openstack.org/340473 | 23:13 |
*** tkelsey has quit IRC | 23:15 | |
unrahul | aastha: vinaypotluri kindly review this patch https://review.openstack.org/#/c/340473/ | 23:16 |
*** zul has joined #openstack-security | 23:17 | |
openstackgerrit | Charles Neill proposed openstack/syntribos: First pass at fix for bug #1604187 https://review.openstack.org/343953 | 23:32 |
openstack | bug 1604187 in syntribos "Inconsistencies between requestslib PreparedRequest and syntribos' RequestObject" [Undecided,New] https://launchpad.net/bugs/1604187 | 23:32 |
*** austin987 has joined #openstack-security | 23:33 | |
*** tmcpeak1 has joined #openstack-security | 23:40 | |
*** tmcpeak has quit IRC | 23:42 | |
openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding missing checks https://review.openstack.org/340473 | 23:45 |
*** salv-orlando has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!