| opendevreview | yangjianfeng proposed openstack/python-openstackclient master: Add router ndp proxy commands https://review.opendev.org/c/openstack/python-openstackclient/+/749038 | 03:30 |
|---|---|---|
| opendevreview | yangjianfeng proposed openstack/python-openstackclient master: Add router ndp proxy commands https://review.opendev.org/c/openstack/python-openstackclient/+/749038 | 03:37 |
| *** tkajinam|off is now known as tkajinam | 05:48 | |
| opendevreview | yangjianfeng proposed openstack/python-openstackclient master: Add router ndp proxy commands https://review.opendev.org/c/openstack/python-openstackclient/+/749038 | 06:26 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored baremetal_node and baremetal_node_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854113 | 07:27 |
| opendevreview | Sharon Koech proposed openstack/python-openstackclient master: Add ``--cascade`` CLI option to network delete command https://review.opendev.org/c/openstack/python-openstackclient/+/854032 | 07:53 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored baremetal_node and baremetal_node_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854113 | 08:15 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored baremetal_node and baremetal_node_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854113 | 08:15 |
| opendevreview | ribaudr proposed openstack/openstacksdk master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/openstacksdk/+/853949 | 09:04 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored baremetal_node and baremetal_node_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854113 | 09:16 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored baremetal_node and baremetal_node_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854113 | 09:26 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored baremetal_node and baremetal_node_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854113 | 09:32 |
| opendevreview | Will Szumski proposed openstack/ansible-collections-openstack master: Allow networks to be updated https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854170 | 11:00 |
| jm1 | gtema: can we rewrite register_machine to use baremetal/node resources? https://opendev.org/openstack/openstacksdk/src/commit/6bc56b0eb6eeb21569aae72ee8033ac64db54fb9/openstack/cloud/_baremetal.py#L160 | 11:22 |
| jm1 | for example, we could fill a Node object with all kwargs and then use baremetal.create_node() instead of self._baremetal_client.post() | 11:22 |
| jm1 | gtema: or will _baremetal_client.post() do exactly that? | 11:23 |
| opendevreview | Will Szumski proposed openstack/ansible-collections-openstack master: Allow networks to be updated https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854170 | 11:28 |
| opendevreview | Will Szumski proposed openstack/ansible-collections-openstack master: Allow networks to be updated https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854170 | 11:41 |
| opendevreview | Will Szumski proposed openstack/ansible-collections-openstack master: Allow networks to be updated https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854170 | 11:44 |
| opendevreview | Will Szumski proposed openstack/ansible-collections-openstack master: Allow networks to be updated https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854170 | 11:46 |
| frickler | gtema: stephenfin: could you please add https://review.opendev.org/c/openstack/python-openstackclient/+/749038 to your review list? I added some questions for other reviewers in my comments. I know it is late in the cycle but it would be really great if this patch would make it for Zed. otherwise the feature is in Neutron but noone can use it. | 11:53 |
| opendevreview | Areg Grigoryan proposed openstack/openstacksdk master: Bugfix for paginating for complex paths https://review.opendev.org/c/openstack/openstacksdk/+/853656 | 11:59 |
| gtema | <jm1> "gtema: or will _baremetal_client..." <- it does exactly that | 12:37 |
| gtema | frickler, but with this amount of comments ... Do you think they would be addressed quickly? | 12:38 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored baremetal_node and baremetal_node_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854113 | 12:48 |
| jm1 | gtema: oh cool! so this should work? https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854113/7/plugins/modules/baremetal_node.py#655 | 12:52 |
| jm1 | gtema: kwargs uses attribute names of the Node object such as 'chassis_id' and no longer ironic names such as 'chassis_uuid' | 12:53 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored baremetal_node and baremetal_node_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854113 | 12:54 |
| gtema | jm1: for BM I would really suggest to try not to use cloud layer. Because I have no clue whether and how ironic folks use it I have fear to touch it really. whatever is on the proxy side is always verified by tests and therefore can be fixed when necessary | 12:59 |
| jm1 | gtema: but that would imply replicating code from the sdk in aoc | 13:07 |
| gtema | which particular cases? | 13:08 |
| jm1 | gtema: maybe we should ask dtantsur how or if ironic is using this register_machine function.. | 13:08 |
| gtema | I was meaning similarly to the create_server case: for the complex cases of course we use cloud. | 13:08 |
| dtantsur | I highly suspect we do use it | 13:09 |
| jm1 | gtema: register_machine is not only creating a node but also creating baremetal nodes | 13:09 |
| frickler | gtema: yes, I've been in contact with the author already | 13:09 |
| frickler | I just would like to avoid needing another set of iterations when other reviewers have different views than me | 13:11 |
| jm1 | dtantsur: codesearch does not return any match. how could ironic possibly use it? maybe though aoc? https://codesearch.opendev.org/?q=register_machine&i=nope&literal=nope&files=&excludeFiles=&repos= | 13:11 |
| dtantsur | jm1: bifrost uses aoc, yes | 13:11 |
| dtantsur | I started doing something about this call, but never had time to finish: https://review.opendev.org/c/openstack/openstacksdk/+/849402/7 | 13:12 |
| jm1 | dtantsur, gtema: to me it looks as if aoc is the only user of register_machine(). so we could touch it without breaking ironic. | 13:14 |
| jm1 | dtantsur: oh great, so someone could pick this up :) | 13:14 |
| jm1 | wow, first X server crash for... a decade? omg.. | 13:26 |
| gtema | lol | 13:28 |
| opendevreview | Areg Grigoryan proposed openstack/openstacksdk master: Bugfix for paginating for complex paths https://review.opendev.org/c/openstack/openstacksdk/+/853656 | 14:04 |
| opendevreview | Dmitry Tantsur proposed openstack/openstacksdk master: Allow passing explicit microversions to Resource methods https://review.opendev.org/c/openstack/openstacksdk/+/849394 | 14:19 |
| dtantsur | rebase party begins ^^ | 14:19 |
| opendevreview | Dmitry Tantsur proposed openstack/openstacksdk master: baremetal: rework node creation to be closer to the backend https://review.opendev.org/c/openstack/openstacksdk/+/849505 | 14:21 |
| opendevreview | Dmitry Tantsur proposed openstack/openstacksdk master: Actually use openstacksdk from source in the Bifrost job https://review.opendev.org/c/openstack/openstacksdk/+/849564 | 14:22 |
| opendevreview | Dmitry Tantsur proposed openstack/openstacksdk master: [WIP] Migrate register_machine to use the proxy layer https://review.opendev.org/c/openstack/openstacksdk/+/849402 | 14:22 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored baremetal_node and baremetal_node_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854113 | 14:53 |
| opendevreview | Will Szumski proposed openstack/ansible-collections-openstack master: Allow networks to be updated https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854170 | 15:33 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored baremetal_node and baremetal_node_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854113 | 17:04 |
| matbu | frickler: hey, according to our discussion yesterday I'm about to revert this patch in master: https://review.opendev.org/c/openstack/osc-lib/+/841307 | 17:45 |
| matbu | frickler: and see if we need a proper fix in train only or not .. i dont think it's something really critical anyway so.. | 17:45 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored baremetal_node and baremetal_node_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854113 | 19:46 |
| opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates volume for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/853749 | 22:54 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!