| opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update federation_mapping_info module to use proxy https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849283 | 08:13 |
|---|---|---|
| opendevreview | Frikin Evgenii proposed openstack/ansible-collections-openstack master: Fix processing stack_status when make create stack https://review.opendev.org/c/openstack/ansible-collections-openstack/+/853768 | 08:58 |
| opendevreview | Frikin Evgenii proposed openstack/ansible-collections-openstack master: Fix processing stack_status when make create stack https://review.opendev.org/c/openstack/ansible-collections-openstack/+/853768 | 09:23 |
| opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update federation_mapping_info module to use proxy https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849283 | 09:57 |
| opendevreview | huang liujie proposed openstack/openstacksdk master: Replace base64.encodestring with encodebytes https://review.opendev.org/c/openstack/openstacksdk/+/853940 | 10:12 |
| opendevreview | Jan Hartkopf proposed openstack/python-openstackclient master: add support for microversion 2.93 https://review.opendev.org/c/openstack/python-openstackclient/+/847792 | 10:30 |
| opendevreview | Jan Hartkopf proposed openstack/python-openstackclient master: add support for microversion 2.93 https://review.opendev.org/c/openstack/python-openstackclient/+/847792 | 10:48 |
| opendevreview | ribaudr proposed openstack/openstacksdk master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/openstacksdk/+/853949 | 10:55 |
| opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update federation_mapping_info module to use proxy https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849283 | 11:14 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Deprecate special value 'auto' for attribute 'id' of compute_flavor https://review.opendev.org/c/openstack/ansible-collections-openstack/+/852936 | 12:10 |
| jm1 | gtema: hello :) maybe you could help me with this patch? https://review.opendev.org/c/openstack/ansible-collections-openstack/+/852119/ | 12:12 |
| gtema | ok, will have a look later today | 12:13 |
| jm1 | gtema: updating the server fails because no floating ip gets attached when auto_ip is set to true | 12:13 |
| gtema | uhg, that is one of the most tricky cases: how IP is getting assinged. There are 2000000000 different ways | 12:14 |
| gtema | will have a deeper look | 12:14 |
| anskiy | gtema: could you, please, take a look at https://review.opendev.org/c/openstack/openstacksdk/+/848095/ again? | 12:17 |
| gtema | ok | 12:18 |
| anskiy | thank you! :) | 12:19 |
| jm1 | gtema: it uses add_ips_to_server and passes a server object (with server details but without add_server_interfaces being called before) and auto_ips=True. https://review.opendev.org/c/openstack/ansible-collections-openstack/+/852119/8/plugins/modules/server.py#1093 | 12:19 |
| jm1 | gtema: the issue seems to be that add_ips_to_server returns None instead of a server object | 12:21 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Replaced expensive get_server() and fixed issues in server module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/852119 | 12:35 |
| jm1 | gtema: oh... maybe the issue is obscured by the until keyword in ci test. i am trying something else and will ping you when i need more help | 12:36 |
| gtema | hmm, ok. Such things we would need to be able to reproduce on bare devstack as well, cause only this will be useful | 12:40 |
| jm1 | gtema: i have another issue with this add_ips_to_server function. this is what i want to accomplish: https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828613/11/ci/roles/floating_ip/tasks/main.yml#271 | 12:48 |
| jm1 | gtema: here it is called: https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828613/11/plugins/modules/floating_ip.py#311 | 12:48 |
| jm1 | gtema: this call returns None as one can see at timestamp "2022-08-10 09:47:26.103680" at https://e045d1163dd923a48c48-5f55b49caeaffd6ebf7a83fc93de4834.ssl.cf2.rackcdn.com/828613/11/check/ansible-collections-openstack-functional-devstack-ansible-2.12/218c3fb/job-output.txt | 12:49 |
| jm1 | gtema: sorry, not the call to the function. the module returns null for floating_ip which means our code cannot find a floating ip | 12:50 |
| jm1 | ..when searching for all floating ips attached to that server | 12:51 |
| jm1 | gtema: i think add_ips_to_server somehow decides that it does not have to do anything. | 12:52 |
| gtema | ;-( this is so hard to analyse. Best would be to have a server and to be able to try out function manually. Cause add_ips_to_server is an entry to the hell | 12:53 |
| jm1 | gtema: sometimes it takes a while until a floating ip is listed for a server. but i handle that by waiting (with until) for the floating ip to be attached to the server... which never happens | 12:53 |
| jm1 | gtema: actually this works in my local devstack but it fails in our ci.. | 12:54 |
| gtema | he, and this is exactly what I told you yesterday: no single cloud (instead of devstack) is openstack cloud (tm) | 12:54 |
| gtema | do we have here ip_pool or ips set? | 12:55 |
| gtema | I guess only ip_pool | 12:55 |
| gtema | madness is in reality in this case due to pool and attempt to reuse eventually existing fips | 12:56 |
| gtema | for the sake of logs and reprodibility: can you add debug of the full server info and list all existing fips before this task is executed? | 12:59 |
| gtema | maybe actually we can also try to start using sdk_logging here, but that would be simply huge | 12:59 |
| opendevreview | ribaudr proposed openstack/python-openstackclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-openstackclient/+/831902 | 13:02 |
| opendevreview | ribaudr proposed openstack/python-openstackclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-openstackclient/+/831902 | 13:04 |
| jm1 | gtema: ack, will add debug statements | 13:04 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored floating_ip and floating_ip_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828613 | 13:06 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored floating_ip and floating_ip_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828613 | 13:11 |
| jm1 | gtema: we could replace add_ips_to_server in aoc modules, but that would replicate code. this belongs to sdk i would think | 13:14 |
| gtema | definitely. I want to gather few examples (conditions) when it fails and extend functional tests | 13:15 |
| opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update federation_mapping_info module to use proxy https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849283 | 14:07 |
| opendevreview | Merged openstack/openstacksdk master: Replace base64.encodestring with encodebytes https://review.opendev.org/c/openstack/openstacksdk/+/853940 | 14:46 |
| jm1 | gtema: new log for first issue https://e3e2390f493f14093eaf-5e1de375231dae3d22db48edd8691108.ssl.cf5.rackcdn.com/852119/9/check/ansible-collections-openstack-functional-devstack-ansible-2.9/b2d8736/job-output.txt | 14:53 |
| jm1 | gtema: add_ips_to_server with auto_ip=True should simply add a floating ip to server but fails with "No port on server XXX was found matching your NAT destination network XXX" | 14:54 |
| jm1 | gtema: i guess you want some extra output. will add debug statements | 14:57 |
| gtema | ok, thanks | 14:59 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Replaced expensive get_server() and fixed issues in server module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/852119 | 14:59 |
| jm1 | gtema: for the second issue with add_ips_to_server we have some debug output now https://dbb517edecb69c839e64-a1eedb38eefc88bab97a9b5aab34511e.ssl.cf1.rackcdn.com/828613/13/check/ansible-collections-openstack-functional-devstack-ansible-2.12/2bd2d7b/job-output.txt | 15:32 |
| jm1 | gtema: this is the patch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828613 | 15:32 |
| gtema | cool, thks | 15:33 |
| gtema | okay, this means clearly we are in the "reuse existing unbound fip" | 15:34 |
| gtema | this is what I was suspecting. | 15:34 |
| gtema | @jm1: do you see that port_id in the query is of a fixed ip and not floating? | 15:42 |
| jm1 | gtema:? | 15:44 |
| gtema | "Get floating ip attached to server 2" task in the log uses "port": "1e08abff-72cd-465c-b92d-18806df814d6" as filter | 15:46 |
| gtema | and this port is of a fixed address and not floating | 15:47 |
| gtema | I am wondered that in the test you simply use server2_ports.ports[1].id | 15:48 |
| opendevreview | mbu proposed openstack/osc-lib stable/train: Do not output log on bash autocomplete generation https://review.opendev.org/c/openstack/osc-lib/+/854016 | 16:04 |
| matbu | Hey folks, is it possible to merge this patch, which is a cherry pick from master: https://review.opendev.org/c/openstack/osc-lib/+/854016 | 16:07 |
| matbu | thank you by advance | 16:07 |
| matbu | (and all the previous stack for wallaby & cie) | 16:07 |
| opendevreview | Merged openstack/ansible-collections-openstack master: Deprecate special value 'auto' for attribute 'id' of compute_flavor https://review.opendev.org/c/openstack/ansible-collections-openstack/+/852936 | 16:09 |
| opendevreview | Sharon Koech proposed openstack/python-openstackclient master: Add ``--cascade`` CLI option to network delete command https://review.opendev.org/c/openstack/python-openstackclient/+/854032 | 16:28 |
| *** tkajinam is now known as tkajinam|off | 16:35 | |
| frickler | matbu: do you have info how to reproduce the issue to be fixed by that patch? to me the fix looks at least incomplete and shouldn't have been merged in master either | 16:44 |
| matbu | frickler: I have a bug here: https://bugzilla.redhat.com/show_bug.cgi?id=2083742 | 16:57 |
| matbu | frickler: i dont have much more information than that | 16:57 |
| matbu | frickler: I was just tracking it, but I take a closer look to get a proper fix if needed | 16:57 |
| frickler | matbu: thx, I just commented on the reviews in parallel. "Steps to reproduce" isn't really helpful, with that input I'd reject a bug as invalid. are you with the RDO team? getting a useable reproducer would be really helpful | 17:03 |
| matbu | frickler: yep I will ask for a reproducer to the bug reporter | 17:04 |
| *** rcastillo|rover is now known as rcastillo | 18:22 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!