| *** ccamel has joined #openstack-sdks | 00:02 | |
| *** camelCaser has quit IRC | 00:04 | |
| *** tobiash has quit IRC | 00:08 | |
| *** tobiash has joined #openstack-sdks | 00:11 | |
| *** aspiers has quit IRC | 00:35 | |
| *** goldyfruit___ has quit IRC | 01:17 | |
| *** ricolin has joined #openstack-sdks | 03:57 | |
| *** Luzi has joined #openstack-sdks | 06:38 | |
| *** gtema has joined #openstack-sdks | 07:33 | |
| *** gtema_ has joined #openstack-sdks | 07:38 | |
| *** gtema has quit IRC | 07:41 | |
| *** slaweq has joined #openstack-sdks | 07:42 | |
| *** gtema_ has quit IRC | 07:42 | |
| *** gtema has joined #openstack-sdks | 07:48 | |
| *** gtema_ has joined #openstack-sdks | 08:00 | |
| *** gtema has quit IRC | 08:02 | |
| *** gtema_ has quit IRC | 08:15 | |
| *** gtema has joined #openstack-sdks | 08:15 | |
| *** gtema_ has joined #openstack-sdks | 08:16 | |
| *** dayou has quit IRC | 08:26 | |
| *** dayou has joined #openstack-sdks | 08:32 | |
| *** ralonsoh has joined #openstack-sdks | 08:44 | |
| *** jpena|off is now known as jpena | 08:51 | |
| *** jpich has joined #openstack-sdks | 08:54 | |
| *** dtantsur|afk is now known as dtantsur | 08:55 | |
| *** gtema_ has quit IRC | 08:58 | |
| *** Luzi has quit IRC | 09:07 | |
| *** Luzi has joined #openstack-sdks | 09:22 | |
| *** cdent has joined #openstack-sdks | 09:32 | |
| *** cdent has quit IRC | 10:02 | |
| openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Add reset_interfaces argument to patch_node https://review.opendev.org/689414 | 10:16 |
|---|---|---|
| openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Add reset_interfaces argument to patch_node https://review.opendev.org/689414 | 10:18 |
| *** cdent has joined #openstack-sdks | 10:38 | |
| openstackgerrit | Dirk Mueller proposed openstack/cliff master: Revert "Pin cmd2 back to <0.9 on all versions" https://review.opendev.org/691841 | 10:54 |
| *** cdent has quit IRC | 11:18 | |
| *** cdent has joined #openstack-sdks | 11:30 | |
| openstackgerrit | Merged openstack/openstacksdk master: Increase dogpile version for Py3.7 compatibility https://review.opendev.org/691680 | 11:55 |
| *** goldyfruit___ has joined #openstack-sdks | 12:15 | |
| *** goldyfruit___ has quit IRC | 12:20 | |
| *** jpena is now known as jpena|lunch | 12:29 | |
| *** cdent has quit IRC | 12:37 | |
| *** gtema has quit IRC | 12:49 | |
| *** enriquetaso has joined #openstack-sdks | 13:01 | |
| *** dave-mccowan has joined #openstack-sdks | 13:05 | |
| *** jpena|lunch is now known as jpena | 13:19 | |
| *** goldyfruit___ has joined #openstack-sdks | 13:26 | |
| *** mriedem has joined #openstack-sdks | 13:29 | |
| *** gtema has joined #openstack-sdks | 13:41 | |
| *** goldyfruit_ has joined #openstack-sdks | 13:53 | |
| *** Luzi has quit IRC | 13:55 | |
| *** goldyfruit___ has quit IRC | 13:55 | |
| openstackgerrit | Eric Fried proposed openstack/python-openstackclient master: Remove redundant OpenStackShell.prepare_to_run_command https://review.opendev.org/691865 | 13:57 |
| efried | dtroyer, mordred: Easy one ^ | 13:57 |
| *** cdent has joined #openstack-sdks | 14:08 | |
| dtroyer | efried: not necessarily easy, there were reasons that exists, and at the moment I don't recall if all of those reasons are gone yet. They should be but I wouldn't bet dinner on it right now | 14:22 |
| efried | dtroyer: I linked the superclass impl in there | 14:23 |
| efried | At least from what I can tell, it's doing the same thing. And you said yourself (in the TODO) that it could be removed after 1.4.0 :P | 14:23 |
| efried | But anyway, this is why we have reviews... | 14:23 |
| dtroyer | Then it should be good, but consider the author | 14:24 |
| efried | hehe | 14:24 |
| *** slaweq has quit IRC | 14:54 | |
| *** slaweq has joined #openstack-sdks | 14:55 | |
| *** slaweq has quit IRC | 14:55 | |
| *** slaweq has joined #openstack-sdks | 14:55 | |
| *** enriquetaso has quit IRC | 14:59 | |
| *** cdent has quit IRC | 15:27 | |
| *** umbSublime has joined #openstack-sdks | 15:40 | |
| umbSublime | with a connection object is it possible to specify the api microversion. Something equivalent to conn.compute.get('/os-hypervisors?with_servers=true', microversion='2.53') | 15:44 |
| *** slaweq has quit IRC | 15:49 | |
| efried | umbSublime: Yes, all the methods (including the REST primitives like .get(), .put(), etc.) should take a microversion kwarg. Let me double check how it's spelled... | 15:49 |
| umbSublime | efried: sorry I wasn't really clear, my example works | 15:51 |
| efried | oh, you want to specify the default microversion for the connection so you don't have to put in the kwarg every time? | 15:52 |
| umbSublime | My question was more, is this possible with for example conn.compute.hypervisors() | 15:52 |
| * efried looks... | 15:52 | |
| *** gtema_ has joined #openstack-sdks | 15:53 | |
| *** slaweq has joined #openstack-sdks | 15:54 | |
| efried | umbSublime: I was wrong, the non-primitives don't take a microversion. You can set the default microversion on the proxy though. | 15:55 |
| umbSublime | Is that something I setup when creating the connection | 15:56 |
| * umbSublime never used the proxy | 15:56 | |
| efried | Sorry, conn.compute is the proxy | 15:56 |
| efried | So it should definitely work like: | 15:57 |
| efried | conn.compute.default_microversion = XXX | 15:57 |
| *** mgariepy has quit IRC | 15:57 | |
| efried | But there's probably a prettier way to do it, via config or something. | 15:57 |
| umbSublime | Ahh I see, thanks | 15:57 |
| *** cdent has joined #openstack-sdks | 15:58 | |
| efried | dtantsur: do you have that answer off the top ^ ? | 15:58 |
| umbSublime | and what about the 'with_servers=True', I see it works with .get, but with .hypervisors() it get's ingored. | 15:58 |
| umbSublime | I pass it as a kwarg on .hypervisors() | 15:58 |
| dtantsur | I suspect something like default_compute_microversions | 15:58 |
| *** goldyfruit___ has joined #openstack-sdks | 15:59 | |
| dtantsur | however, if you need to set it for e.g. conn.compute.hypervisors, then somebody is doing it wrong: other we or you :) | 15:59 |
| *** mgariepy has joined #openstack-sdks | 15:59 | |
| dtantsur | openstacksdk is expected to use the latest microversions it knows. if it doesn't - it's a bug. | 15:59 |
| dtantsur | if it does, then changing the default won't help you | 15:59 |
| efried | dtantsur: Didn't mordred just fix something for that? | 15:59 |
| dtantsur | maybe, I haven't been following closely the last couple of weeks | 16:00 |
| dtantsur | (relocation) | 16:00 |
| umbSublime | "somebody is doing it wrong" -> most likely me | 16:00 |
| dtantsur | umbSublime: it may help if you describe the problem you're facing | 16:00 |
| efried | https://review.opendev.org/#/c/685999/ implies we weren't getting the compute microversion we were expecting. | 16:01 |
| *** goldyfruit_ has quit IRC | 16:01 | |
| umbSublime | dtantsur: I have a meeting coming, up but I'll be back with the deets | 16:01 |
| efried | umbSublime: What version of keystoneauth are you using? | 16:02 |
| efried | it's possible that without https://review.opendev.org/#/c/685042/ you're getting 2.1 instead of 'latest'. | 16:04 |
| efried | dtantsur: ^ | 16:04 |
| dtantsur | yeah, this may be the cause | 16:05 |
| dtantsur | these microversions, never liked them :) | 16:05 |
| efried | umbSublime: So you may want to make sure you have ksa 3.18.0 (it looks like the Train fix hasn't merged yet) | 16:06 |
| efried | and see if that fixes the issue | 16:06 |
| efried | umbSublime: As for `with_servers`, that was added in the 2.53 microversion of the compute API, but we might not have brought SDK up to parity yet. | 16:07 |
| efried | yeah. | 16:12 |
| efried | umbSublime: You should propose a patch to add that :P | 16:13 |
| openstackgerrit | Eric Fried proposed openstack/python-openstackclient master: DNM: CI check https://review.opendev.org/691910 | 16:23 |
| *** enriquetaso has joined #openstack-sdks | 16:40 | |
| openstackgerrit | Merged openstack/openstacksdk master: Add support for Node tainted field https://review.opendev.org/690755 | 16:41 |
| *** jpena is now known as jpena|brb | 16:45 | |
| *** gtema_ has quit IRC | 16:51 | |
| umbSublime | efried: I'm using keystone v3. As for the microversion I get from the proxy how can i check this? i can only see 'version=2' in vars(conn.compute) | 17:13 |
| umbSublime | v3.11 for ksa | 17:14 |
| *** jpena|brb is now known as jpena | 17:24 | |
| *** gtema has quit IRC | 17:28 | |
| *** gmann is now known as gmann_afk | 17:29 | |
| *** gmann_afk is now known as gmann | 17:35 | |
| *** dtantsur is now known as dtantsur|afk | 17:41 | |
| *** jpich has quit IRC | 18:15 | |
| *** jpena is now known as jpena|off | 18:30 | |
| *** senrique_ has joined #openstack-sdks | 18:40 | |
| mriedem | dtroyer: can we get this simple osc change in https://review.opendev.org/#/c/691039/ to unblock novaclient 16.0.0 from being in u-c https://review.opendev.org/#/c/690097/ | 18:40 |
| *** enriquetaso has quit IRC | 18:42 | |
| *** ralonsoh has quit IRC | 19:08 | |
| *** senrique__ has joined #openstack-sdks | 19:33 | |
| *** senrique_ has quit IRC | 19:36 | |
| *** cdent has quit IRC | 19:39 | |
| efried | mriedem: something changed between then and now, osc isn't building: https://review.opendev.org/#/c/691910/ | 20:38 |
| efried | so your patch won't clear the gate, is my point. | 20:38 |
| mriedem | but not just mine, any you're saying | 20:38 |
| efried | And btw, I have no idea what's going on there. I can't repro "locally" | 20:38 |
| efried | yes, noticed it on one of mine, seemed unrelated, so I put that up to confirm. | 20:39 |
| efried | mebbe you can do your logstash thing and find the culprit? | 20:39 |
| * mriedem does his thing | 20:40 | |
| mriedem | my guess is some py2/3 thing was dropped/released | 20:40 |
| mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22TypeError%3A%20Unicode-objects%20must%20be%20encoded%20before%20hashing%5C%22%20AND%20tags%3A%5C%22console%5C%22&from=7d isn't super useful | 20:42 |
| *** gtema has joined #openstack-sdks | 20:42 | |
| efried | I guess it wouldn't be, since nobody's been building anything in osc except for me. | 20:43 |
| mriedem | well, could be openstack-requirements for a dependency | 20:43 |
| mriedem | but i'm not seeing anything obvious | 20:43 |
| efried | but it shows that whatever it is only affects python-openstackclient. | 20:44 |
| mriedem | this hashlib library that's blowing up here https://github.com/openstack/python-openstackclient/blob/4bde9af89251431791fc8d69fe09d5e17a8fba8f/openstackclient/tests/functional/compute/v2/test_agent.py#L24 hasn't changed in forever on pyi | 20:44 |
| mriedem | *pypi | 20:44 |
| mriedem | https://zuul.opendev.org/t/openstack/build/49ff6a5645554095b3fb51bce497aff5/log/tox/functional-0.log hmm is that in the standard lib now? | 20:44 |
| mriedem | this job must use py36? | 20:45 |
| efried | did that job recently cut over to py3? | 20:45 |
| mriedem | that's my guess | 20:45 |
| efried | well, its incarnation in python-openstackclient didn't, so unless it has an ancestor that did... | 20:45 |
| mriedem | https://docs.python.org/3.6/library/hashlib.html#hashlib.hash.update | 20:45 |
| mriedem | that's entirely possible, parent projects are moving to py3 in ussuri | 20:46 |
| efried | devstack-tox-functional | 20:46 |
| mriedem | seems ok https://opendev.org/openstack/devstack/src/branch/master/.zuul.yaml#L566 | 20:47 |
| mriedem | parent: multinode | 20:48 |
| efried | ...which is abstract, whatever that means. | 20:49 |
| mriedem | means it just has to be extended i think | 20:49 |
| efried | well, yeah | 20:50 |
| efried | btw, attempting to run simply tox -e functional on my devstack node deadlocks. | 20:50 |
| mriedem | i don't see anything recent in openstack-zuul-jobs that looks related | 20:50 |
| mriedem | or devstack | 20:50 |
| efried | yeah | 20:51 |
| *** gtema has quit IRC | 20:51 | |
| mriedem | the job does have USE_PYTHON3=False in it | 20:51 |
| mriedem | so it should be using py2 | 20:51 |
| efried | but isn't? | 20:51 |
| *** gtema has joined #openstack-sdks | 20:52 | |
| mriedem | looks like it's using py3 https://zuul.opendev.org/t/openstack/build/49ff6a5645554095b3fb51bce497aff5/log/job-output.txt#30632 | 20:52 |
| mriedem | $ /usr/bin/python3 -m virtualenv --no-download --python /usr/bin/python3 functional | 20:53 |
| efried | I'll push a fix. | 20:53 |
| efried | ...without for the moment caring that we "should be running py2". Because we really shouldn't. | 20:53 |
| *** gtema has quit IRC | 20:53 | |
| mriedem | i think you just need to put USE_PYTHON3: True in here https://github.com/openstack/python-openstackclient/blob/master/.zuul.yaml#L76 | 20:54 |
| efried | but the problem is that it *is* using py3 and md5().update() needs an encoded string. | 20:54 |
| mriedem | well, a quick fix would be setting basepython = python2 in the tox.ini functional env i think if the job isn't using py3, | 20:55 |
| openstackgerrit | Eric Fried proposed openstack/python-openstackclient master: Fix functional tests for py3 https://review.opendev.org/691980 | 20:56 |
| mriedem | but if the parent is now using py3, yeah idk what's going on there that changed | 20:56 |
| efried | mriedem: That ought to fix at least that error, we'll see if something else crops up. | 20:56 |
| efried | dtroyer: FYI: TL;DR: python-openstackclient builds broke some time between 10/24 and this morning when the functional jobs somehow got cut over to py3. Fixing via https://review.opendev.org/691980 | 20:57 |
| efried | actually, I can narrow it down further. I have a successful build Oct 28 19:31 (that's US Central time) | 20:59 |
| mordred | efried: how did we manage to break builds? | 20:59 |
| efried | mordred: haven't figured that out yet. | 21:00 |
| efried | As far as mriedem and I can tell, "something" cut over to py3 | 21:00 |
| mordred | "awesome" | 21:00 |
| efried | If this build is running py2, that'll be confirmed: https://zuul.opendev.org/t/openstack/build/ad5f0ee04fed4285b9f5429debd9b32d/log/job-output.txt | 21:00 |
| *** dtruong has quit IRC | 21:01 | |
| openstackgerrit | Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | 21:01 |
| *** dtruong has joined #openstack-sdks | 21:01 | |
| efried | I'm not good at definitively determining whether a job is running under py2 or py3, but afaict that one is py2, and today's broken ones are py3 | 21:02 |
| mordred | efried: that one seems to be py2 - I see a bunch of false for use python3 - and an uninstall of python3 package | 21:02 |
| efried | yup | 21:02 |
| efried | so | 21:02 |
| efried | some zuul ancestor somehow cut over to py3 overnight | 21:02 |
| efried | but mriedem and I couldn't find it. | 21:03 |
| efried | now - the right thing of course is for python-openstackclient to be testing under py3 anyway. | 21:03 |
| mordred | yeah | 21:03 |
| mordred | I mean- luckily that patch from you isn't super big | 21:03 |
| efried | those jobs should have probably been (cloned or) cut over yonks ago. | 21:03 |
| mordred | yup | 21:03 |
| efried | well, not yet :) | 21:03 |
| mordred | haha | 21:03 |
| mordred | I assume that patch is perfect and complete | 21:04 |
| efried | I haven't been able to run the suite locally at all, so just have to wait for zuul to tell us whether that's all that's required to cut over. | 21:04 |
| efried | mordred: actually, since you're here with your godlike powers, perhaps you could set that node up to hold when/if it fails so we can get in there and iterate? | 21:05 |
| openstackgerrit | Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | 21:05 |
| efried | still queued at the moment... | 21:05 |
| mordred | efried: yeah - one sec | 21:08 |
| mordred | efried: k. autohold placed | 21:10 |
| efried | cool | 21:11 |
| openstackgerrit | Eric Fried proposed openstack/python-openstackclient master: Fix 'versions show' helps & docs https://review.opendev.org/691989 | 21:26 |
| mriedem | efried: see http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010430.html - just hit the ML, but says that openstackclient needs to support py27 for swift | 21:29 |
| mriedem | osc isn't a library though so i'm not sure about all that | 21:30 |
| mordred | wait - yeah. doesn't make sense that keystonemiddleware would need openstackclient | 21:30 |
| mriedem | i'm replying | 21:30 |
| mordred | ++ | 21:31 |
| mordred | I just checked - osc is not a dep of keystonemiddleware | 21:31 |
| mriedem | i'm guessing it just means devstack + osc for testing swift, but osc doesn't need to be py2 for that | 21:33 |
| *** senrique__ has quit IRC | 21:37 | |
| mordred | yeah | 21:38 |
| efried | mriedem: FWIW 'openstackclient' and 'python-openstackclient' are different projects. It's likely they meant the latter even though they said the former. And in any case the former isn't a dep. | 21:38 |
| mordred | neither should be a dep | 21:38 |
| efried | just to add further depth to the confusion. | 21:38 |
| mordred | and if either are, we should fix that :) | 21:38 |
| efried | yeah. | 21:38 |
| efried | mordred: http://zuul.openstack.org/stream/d39bf114ffc943c8b28a5c602395b10b?logfile=console.log I could be wrong, but this appears to be running under py2??? | 21:39 |
| efried | is it possible that certain CI nodes are running py3 by default, so if this job doesn't say anything, it gets whatever it happens to land on?? | 21:41 |
| efried | and all four of the runs previously noted just happened to get lucky? | 21:41 |
| mordred | it really shouldn't be - we use the same images across all clouds | 21:41 |
| efried | mm. So maybe I just don't know what I'm looking at. But I saw lots of "pyXX doesn't match your env" messages fly by. | 21:42 |
| mordred | well - this is complicated - because there's the devstack install - and then there's the tox venv inside of which the functional tests run | 21:42 |
| efried | o | 21:42 |
| efried | okay, I'll stfu until it gets a bit further. | 21:43 |
| mordred | looks like the tox file should have been running functional tests themselves in py3 for a while now | 21:44 |
| mordred | so - this will be fun to understand :) | 21:44 |
| mriedem | without basepython set in tox.ini i'm guessing you get whatever node you land on | 21:45 |
| mriedem | so it's probably good to be explicit and switch those functional jobs over to py3 | 21:46 |
| mriedem | and set USE_PYTHON3=True in the zuul job def | 21:46 |
| mordred | well - basepython is set in tox ... | 21:46 |
| mordred | but yeah - we should set USE_PYTHON3=True anyway | 21:46 |
| mordred | just because | 21:46 |
| mriedem | i mean basepython isn't set in https://github.com/openstack/python-openstackclient/blob/master/tox.ini#L6 | 21:47 |
| mriedem | or https://github.com/openstack/python-openstackclient/blob/master/tox.ini#L70 | 21:47 |
| mordred | it's totally set in my local copy - what's up with that? | 21:47 |
| mordred | ah. BWAHAHAHA | 21:48 |
| mordred | https://review.opendev.org/#/c/686590/ <-- that was on the tip of my local checkout :) | 21:49 |
| *** slaweq has quit IRC | 21:52 | |
| *** mordred has left #openstack-sdks | 21:59 | |
| *** mordred has joined #openstack-sdks | 21:59 | |
| mordred | efried: am I in the right channel? my irc client somehow split this channel into two different buffers and I'm confused ... | 22:00 |
| efried | mordred: I see you, but was switched out and haven't read anything in the last 18 mins or so. Catching up... | 22:00 |
| efried | mordred: beaut. and as you can see, it failed the same jobs the same way | 22:02 |
| efried | mordred: so basically, you discovered this problem three weeks ago and didn't say anything. | 22:03 |
| efried | :P | 22:03 |
| mordred | efried: neat! | 22:03 |
| efried | my patch got past the previous point okay. It's failing some tests tho, so being able to iterate on the node will be useful. However, I likely will have to bail before then. Is it legit to hold the node until tomorrow? | 22:04 |
| *** goldyfruit___ has quit IRC | 22:04 | |
| *** mriedem has quit IRC | 22:06 | |
| mordred | yah. point me at your key though | 22:22 |
| mordred | efried: I believe the default node hold timeout is 24h | 22:22 |
| *** goldyfruit___ has joined #openstack-sdks | 22:35 | |
| *** slaweq has joined #openstack-sdks | 22:49 | |
| *** slaweq has quit IRC | 22:54 | |
| *** senrique__ has joined #openstack-sdks | 23:20 | |
| *** goldyfruit___ has quit IRC | 23:45 | |
| *** goldyfruit___ has joined #openstack-sdks | 23:48 | |
| *** senrique__ has quit IRC | 23:54 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!