Tuesday, 2019-08-13

*** dave-mccowan has quit IRC00:58
*** factor has joined #openstack-sdks01:39
*** bobh has joined #openstack-sdks01:51
openstackgerritAdrian Turjak proposed openstack/keystoneauth master: add support for auth_receipts and multi-method auth  https://review.opendev.org/67504902:37
*** bobh has quit IRC02:46
openstackgerritAdrian Turjak proposed openstack/keystoneauth master: add support for auth_receipts and multi-method auth  https://review.opendev.org/67504902:46
*** bobh has joined #openstack-sdks02:50
*** bobh has quit IRC02:57
*** gkadam has joined #openstack-sdks03:39
*** gkadam has quit IRC03:40
openstackgerritBrin Zhang proposed openstack/python-openstackclient master: Microversion 2.76: Support Specifying AZ to unshelve  https://review.opendev.org/66533604:05
*** goldyfruit_ has quit IRC04:11
*** goldyfruit_ has joined #openstack-sdks04:11
*** whoami-rajat has joined #openstack-sdks04:18
*** dave-mccowan has joined #openstack-sdks04:56
*** dave-mccowan has quit IRC05:01
*** gkadam has joined #openstack-sdks05:30
openstackgerritVieri proposed openstack/openstackclient master: Add Python 3 Train unit tests  https://review.opendev.org/67611706:48
*** slaweq has joined #openstack-sdks07:05
*** dtantsur|afk is now known as dtantsur07:32
*** jangutter has joined #openstack-sdks07:34
*** tosky has joined #openstack-sdks07:37
*** jpena|off is now known as jpena07:39
*** yolanda has quit IRC08:07
*** jpich has joined #openstack-sdks08:12
*** cdent has joined #openstack-sdks08:26
*** jpich has quit IRC09:06
*** jpich has joined #openstack-sdks09:07
*** jpich has quit IRC09:23
*** jpich has joined #openstack-sdks09:26
*** e0ne has joined #openstack-sdks09:34
*** jpich has quit IRC10:21
*** jpich has joined #openstack-sdks10:22
dtantsurmmm, so apparently our image API is using an unused "params" argument to Resource.fetch and tests fail if you wire it in..10:35
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: Add support for fields in baremetal get_* resources  https://review.opendev.org/67615410:36
dtantsurefried: needed for nova ^^ but won't pass unit tests because of the image API test weirdness10:36
dtantsurooops, sorry, it was DNS API10:37
mordreddtantsur: this is the test_wait_for_task_wait issue?10:54
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: Add support for fields in baremetal get_* resources  https://review.opendev.org/67615410:55
dtantsurmordred: no. I've uncovered two actual bugs, I think ^^^10:55
mordredah - neat10:55
dtantsurreminder for us: never ignore arguments, somebody will try to provide them :)10:55
mordred++10:56
*** goldyfruit_ has quit IRC11:13
*** jpena is now known as jpena|lunch11:25
*** slaweq_ has joined #openstack-sdks11:29
*** slaweq has quit IRC11:33
*** mriedem has joined #openstack-sdks11:52
*** ricolin has quit IRC12:01
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Fix discovery cache sharing  https://review.opendev.org/67512112:10
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rationalize endpoint_for and get_endpoint_from_catalog  https://review.opendev.org/67513012:10
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Add support for global_request_id  https://review.opendev.org/67480712:10
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Validate that connect_as connects as the project  https://review.opendev.org/67517812:10
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Replace catalog-v3.json with keystoneauth fixture  https://review.opendev.org/67518712:10
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Allow services to override proxy creation  https://review.opendev.org/67411012:10
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rationalize endpoint_for and get_endpoint_from_catalog  https://review.opendev.org/67513012:11
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Add support for global_request_id  https://review.opendev.org/67480712:14
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Validate that connect_as connects as the project  https://review.opendev.org/67517812:14
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rationalize endpoint_for and get_endpoint_from_catalog  https://review.opendev.org/67513012:16
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Replace catalog-v3.json with keystoneauth fixture  https://review.opendev.org/67518712:16
mordredsorry for the churn - I thought I could pull one of those patches out to be independent - but turns out I couldn't12:16
*** bobh has joined #openstack-sdks12:16
*** bobh has quit IRC12:21
*** jpena|lunch is now known as jpena12:22
*** bobh has joined #openstack-sdks12:35
openstackgerritMaxim Babushkin proposed openstack/openstacksdk master: Add 'tag' support to compute with supported microversion  https://review.opendev.org/67530612:40
*** slaweq__ has joined #openstack-sdks12:45
*** slaweq_ has quit IRC12:45
*** jangutter_ has joined #openstack-sdks12:49
*** factor has quit IRC12:51
*** factor has joined #openstack-sdks12:52
*** jangutter has quit IRC12:52
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: Add support for fields in baremetal get_* resources  https://review.opendev.org/67615413:03
*** jpich has quit IRC13:03
*** jpich has joined #openstack-sdks13:03
*** goldyfruit has joined #openstack-sdks13:13
*** bobh has quit IRC13:14
*** gkadam has quit IRC13:17
*** lbragstad has joined #openstack-sdks13:31
*** slaweq__ is now known as slaweq13:33
efrieddtantsur: I was going to hit you up about that13:49
efriedI was looking into it yesterday13:49
dtantsurI hope I didn't step on your shoes13:49
efriedjust got to my desk, so haven't caught up, except to see that you commented on the nova patch and seem to have identified the/a problem13:49
dtantsuryeah13:49
efriedfrom what I could tell, it was happening during construction of the proxy13:50
efriedis that the case?13:50
dtantsurefried: ignore the version blah-blah logging. the actual problem seems to be get_node(<>, fields=..). we never implemented the "fields" bit.13:50
dtantsurmy patch above hopefully adds its support13:51
* dtantsur waits for the CI13:51
efrieddtantsur: Okay, the thing that concers me is...13:51
* efried gets log links...13:51
efrieddtantsur: Okay, here13:52
efriedhttps://logs.opendev.org/99/642899/38/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/665016d/controller/logs/screen-n-cpu.txt.gz?level=ERROR13:52
dtantsur"StrictVersion instance has no attribute 'version'" is an annoying exception that *likely* hides the fact that ironic is not up yet13:53
efriedEven when this job succeeds, the "Error: StrictVersion instance has no attribute 'version'" always shows up, as does the "VirtDriverNotReady: Virt driver is not ready."13:53
dtantsurthe actual problem that fails you https://logs.opendev.org/99/642899/38/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/665016d/controller/logs/screen-n-cpu.txt.gz?level=ERROR#_Aug_13_05_19_11_54071313:53
efriedAnd we always see at least one "No compute node record for host"13:54
dtantsurefried: right, it's a bug in ironicclient that hides the ConnectionRefused or whatever13:54
dtantsurbecause ironic starts later than nova13:54
efriedright, so13:54
dtantsurI may be confusing some details, but the overall picture is like this13:54
efriedthis error didn't start appearing in this patch until the latest PS13:54
efriedlet me show you a log from before...13:54
dtantsurI've seen it many times already. Not sure if it's permanent or depends on some ordering in devstack.13:55
efriedYeah, I'm just using it as a baseline.13:57
efrieddtantsur: So this is what I consider "good": https://logs.opendev.org/99/642899/36/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/4b528c1/controller/logs/screen-n-cpu.txt.gz?level=ERROR13:57
efriedThat job succeeded ^13:57
dtantsursame problem in a recent successful run: https://logs.opendev.org/40/675940/1/check/ironicclient-tempest/f57c0f3/controller/logs/screen-n-cpu.txt.gz?level=WARNING#_Aug_12_16_38_40_79040013:57
dtantsurright13:57
efriedSo now comparing against the run in the same time frame on the *subsequent* patch, whose only difference is that it starts using .nodes...13:57
efriedhttps://logs.opendev.org/27/656027/20/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/ed7caf9/controller/logs/screen-n-cpu.txt.gz?level=ERROR13:58
efriedNow all of a sudden we're seeing this: Error: The baremetal service for 213.32.77.113:RegionOne exists but does not have any supported versions.: NotSupported: The baremetal service for 213.32.77.113:RegionOne exists but does not have any supported versions.13:58
efriedwhich comes from _make_proxy13:58
efriedi.e. when we first bootstrap the connection13:58
*** whoami-rajat has quit IRC13:59
efriedwhich implies to me that the *previous* succeeding run wasn't hitting the changed code at all, which would be... bad :(13:59
dtantsurwe better ask mordred but I suspect "does not have any supported version" may be the consequence of ironic being down still14:00
efriedThat never appears in any of the other runs though14:00
efriedI looked through a dozen yesterday14:00
efriedor14:00
efriedI guess it could be timing. If the code path that hits .nodes() happens much earlier than get_node(), and the service is still down, and we try to make the proxy and fail discovery... but we should try again a bit later, shouldn't we??14:01
*** lbragstad has quit IRC14:02
dtantsurI guess we do? I'd fix the get_node problem first, then see where we stand14:02
efrieddtantsur: Yeah, see, the next patch in the series *should* be hitting that same get_node error, but it's not getting that far: https://logs.opendev.org/27/656027/21/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/60265c4/controller/logs/screen-n-cpu.txt.gz?level=ERROR14:03
dtantsurit cannot connect to keystone, maybe that's the cause?14:04
efriedI suspect this just means the nova side needs to be more tolerant of service-not-yet-up.14:04
dtantsuryep14:04
openstackgerritMerged openstack/openstacksdk master: DRY test_connection  https://review.opendev.org/67600914:08
*** whoami-rajat has joined #openstack-sdks14:25
*** ricolin has joined #openstack-sdks14:28
efrieddustinc: ^14:48
dustincefried, dtantsur: thanks, will catch up when I get to work in about an hour14:52
dtantsurmordred, efried, https://review.opendev.org/#/c/676154/ passed now, please check14:57
*** dave-mccowan has joined #openstack-sdks14:57
*** dave-mccowan has quit IRC15:04
openstackgerritMerged openstack/openstacksdk master: Fix discovery cache sharing  https://review.opendev.org/67512115:14
efrieddtantsur: +A, thanks for the quick fix.15:35
dtantsuryvw15:36
efrieddtantsur, mordred: still trying to nail down the difference in the discovery path between ksa and sdk15:47
efriedspecifically here https://logs.opendev.org/27/656027/21/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/60265c4/controller/logs/screen-n-cpu.txt.gz?level=WARNING#_Aug_13_04_59_18_05324515:48
efriedIn this case we want ServiceUnavailable to be an exception, but I *think* it's proceeding and still trying to return a real proxy.15:48
efriedI think allow_version_hack=False would get us DiscoveryFailure here15:49
efried...but I'm not sure whether that would help :(15:49
* dtantsur looks at mordred15:50
efriedmordred: I... kind of suspect we should be defaulting allow_version_hack=False from the sdk side. AFAICT it's always True today - even for the code paths where we're not explicitly setting it.15:55
*** jpena is now known as jpena|off15:58
*** shubham_potale has joined #openstack-sdks16:06
efrieddustinc: When you're about, we should talk.16:23
*** dtantsur is now known as dtantsur|afk16:29
dustincefried: around now16:29
efrieddustinc: The nova/sdk series needs to be passing the ironic CI job before it's going to fly16:29
efriedbefore yesterday, with the fields thing, the bottom patch was passing, but the second one (and up) was failing.16:30
efriedand I still haven't been able to figure out exactly why.16:30
dustincThanks, I have not been giving it a lot of attention recently but am working on it today16:34
efrieddustinc: In the CI env, the n-cpu service comes up before ironic16:35
efriedso the first few attempts to connect will fail.16:35
efriedThis is a "normal" run: https://logs.opendev.org/40/675940/1/check/ironicclient-tempest/f57c0f3/controller/logs/screen-n-cpu.txt.gz?level=WARNING#_Aug_12_16_38_40_79040016:35
efriedAnd that's what things would look like, more or less, on the bottom patch (before the fields thing)16:37
dustincthanks, checking it out right now16:37
efriedBut then with the second patch, we would start seeing stuff like this https://logs.opendev.org/27/656027/21/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/60265c4/controller/logs/screen-n-cpu.txt.gz?level=WARNING#_Aug_13_04_59_18_05324516:37
dustinc(I knew about the fields support thing but totally forgot and thus added it back..)16:37
efriedMy current suspicion is that it's because we're using different retries/timeout than before.16:38
dustincHmm16:38
*** jangutter_ has quit IRC16:39
efrieddtantsur|afk, dustinc, mordred: I think now that we have retry opts in ksa config [1][2], we should deprecate nova's equivalents [3] via alias so that they're used for both the old (iroincclient) and new (sdk) code paths, which will assure us parity at least in that regard.16:46
efried[1] https://review.opendev.org/66628716:46
efried[2] https://review.opendev.org/67293016:46
efried[3] https://opendev.org/openstack/nova/src/branch/master/nova/conf/ironic.py#L39-L6316:46
*** jpich has quit IRC16:47
*** ricolin_ has joined #openstack-sdks16:48
*** e0ne has quit IRC16:51
*** ricolin has quit IRC16:52
*** slaweq has quit IRC16:52
*** cdent has quit IRC16:53
*** mgariepy has quit IRC16:58
*** jangutter has joined #openstack-sdks16:59
openstackgerritMerged openstack/openstacksdk master: Add support for fields in baremetal get_* resources  https://review.opendev.org/67615416:59
openstackgerritEric Fried proposed openstack/openstacksdk master: Bump keystoneauth1 minimum to 3.16.0  https://review.opendev.org/67624717:00
efriedmordred, Shrews: I'm going to propose a sdk release now, mkay?17:00
efriedaccumulated a bunch of fixes nova (at least) needs.17:00
mordredefried: ++17:01
Shrewsup to mordred, but i have no problem with it17:01
mordredefried: actually ...17:01
Shrewswill be able to restart nodepool with the object fixes, which will be nice17:01
mordredefried: should we also land https://review.opendev.org/#/c/674807/ too?17:01
mordred(that also contains the keystoneauth dep bump)17:02
* mordred is fine cutting multiple releases too17:02
efriedmordred: could do, yes. Is there a reason that wasn't +W'd?17:03
efriedmordred: also, that one bumps to 3.15.0, but we need .16. to pick up both retry changes.17:03
efriedI could rebase my bump on that one and +W it.17:03
mordred++17:03
*** ricolin_ is now known as ricolin17:04
*** jangutter has quit IRC17:10
openstackgerritEric Fried proposed openstack/openstacksdk master: Bump keystoneauth1 minimum to 3.16.0  https://review.opendev.org/67624717:11
efriedmordred: ^17:11
efriedShrews: too17:11
efrieddustinc: I'm going to start hacking at that thing I said earlier, about deprecating the existing ironic retry opts. There are other ways to get the right timeouts into the sdk proxy, but they're messier.17:15
efried...unless you want it17:15
dustincefried: go for it, I am about to push a small fix to the bottom patch17:17
efrieddustinc: are you taking out 'fields' for now?17:18
dustincI was going to leave it expecting the SDK release to add support17:18
dustincI can take it out for now if you want..17:18
efrieddustinc: meh17:19
efriedI think we're not going to be able to land anything until we've got some of these issues sorted out17:19
efriedso probably no hurry17:19
efriedbut you're going to want to put your series on top of this thing I'm doing17:20
*** mgariepy has joined #openstack-sdks17:20
efriedwhich will also require the new sdk release17:20
efriedfor which I'm going to wait for the ksa bump17:20
efriedso we got a little while until all those pieces come together.17:20
*** shubham_potale has quit IRC18:04
*** e0ne has joined #openstack-sdks18:23
openstackgerritMerged openstack/openstacksdk master: Add support for global_request_id  https://review.opendev.org/67480718:35
*** mgariepy has quit IRC19:08
*** mriedem has quit IRC19:08
*** mriedem has joined #openstack-sdks19:12
*** whoami-rajat has quit IRC19:33
*** slaweq has joined #openstack-sdks19:34
*** mgariepy has joined #openstack-sdks19:34
openstackgerritMerged openstack/openstacksdk master: Bump keystoneauth1 minimum to 3.16.0  https://review.opendev.org/67624720:35
*** e0ne has quit IRC20:38
efriedopenstacksdk release 0.34.0 proposed: https://review.opendev.org/67627620:44
*** slaweq has quit IRC22:10
*** slaweq has joined #openstack-sdks22:26
*** tosky has quit IRC22:27
*** slaweq has quit IRC22:30
openstackgerritMerged openstack/openstacksdk master: Minor refactor cleanup of _make_proxy  https://review.opendev.org/67601522:50
*** mriedem has quit IRC23:08
openstackgerritAdrian Turjak proposed openstack/keystoneauth master: add support for auth_receipts and multi-method auth  https://review.opendev.org/67504923:51

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!