Monday, 2019-08-12

*** yolanda has quit IRC00:12
*** yolanda has joined #openstack-sdks00:13
*** cmorpheus is now known as cmurphy01:24
*** yolanda has quit IRC02:32
*** yolanda has joined #openstack-sdks02:37
*** yolanda has quit IRC02:43
*** yolanda has joined #openstack-sdks02:44
*** mordred has quit IRC02:48
*** mordred has joined #openstack-sdks02:48
*** bobh has joined #openstack-sdks02:50
openstackgerritBrin Zhang proposed openstack/python-openstackclient master: Add server migration list CLI  https://review.opendev.org/67530403:01
*** bobh has quit IRC03:10
*** yolanda has quit IRC03:17
*** yolanda has joined #openstack-sdks03:22
openstackgerritBrin Zhang proposed openstack/python-openstackclient master: Add server migration list CLI  https://review.opendev.org/67530404:09
*** shubham_potale has joined #openstack-sdks04:52
*** shubham_potale has quit IRC05:01
*** e0ne has joined #openstack-sdks06:16
*** e0ne has quit IRC06:17
*** shubham_potale has joined #openstack-sdks06:24
*** slaweq has joined #openstack-sdks06:33
*** dtantsur|afk is now known as dtantsur06:42
*** toabctl has joined #openstack-sdks06:59
*** tosky has joined #openstack-sdks07:17
*** jpena|off is now known as jpena07:25
*** zbr is now known as zbr|flu07:47
*** e0ne has joined #openstack-sdks07:49
*** jpich has joined #openstack-sdks07:59
*** cdent has joined #openstack-sdks08:12
*** jpich has quit IRC08:20
*** jpich has joined #openstack-sdks08:20
*** cdent has quit IRC08:33
*** cdent has joined #openstack-sdks08:33
*** jpich has quit IRC08:36
*** jpich has joined #openstack-sdks08:37
*** slaweq has quit IRC08:42
*** mordred has quit IRC08:42
*** mordred has joined #openstack-sdks08:43
*** slaweq has joined #openstack-sdks08:43
*** openstackgerrit has quit IRC08:45
*** irclogbot_0 has quit IRC08:49
*** irclogbot_3 has joined #openstack-sdks08:53
dtantsurmordred, morning, have a second for https://review.opendev.org/#/c/674298/ ?09:29
fricklermordred: kmalloc: cmurphy: I finally found the location where ksc hardcodes using the admin endpoint: https://opendev.org/openstack/python-keystoneclient/src/branch/master/keystoneclient/httpclient.py#L25109:32
fricklerwe can do a workaround in heat, but fixing in ksc would seem better to me in the long run. seems that a lot of tests depend on the current default though09:35
*** jpich has quit IRC09:58
*** jpich has joined #openstack-sdks09:58
*** jpich has quit IRC09:59
*** jpich has joined #openstack-sdks10:03
*** jpich has quit IRC10:08
*** jpich has joined #openstack-sdks10:08
*** openstackgerrit has joined #openstack-sdks10:41
openstackgerritBence Romsics proposed openstack/openstacksdk master: Add router add/remove route operations  https://review.opendev.org/67432410:41
openstackgerritBence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route  https://review.opendev.org/67432510:55
*** whoami-rajat has joined #openstack-sdks11:08
*** jpena is now known as jpena|lunch11:40
*** pas-ha has quit IRC12:13
*** pas-ha has joined #openstack-sdks12:14
*** vdrok has quit IRC12:14
*** vdrok has joined #openstack-sdks12:14
*** bobh has joined #openstack-sdks12:15
*** bobh has quit IRC12:20
*** edleafe has joined #openstack-sdks12:29
*** jpena|lunch is now known as jpena12:30
*** bobh has joined #openstack-sdks12:32
*** bobh has quit IRC12:34
*** jroll has quit IRC13:01
*** jroll has joined #openstack-sdks13:02
*** slaweq has quit IRC13:08
*** efried_pto is now known as efried13:09
*** slaweq has joined #openstack-sdks13:11
*** mriedem has joined #openstack-sdks13:18
*** frickler has quit IRC13:18
*** frickler has joined #openstack-sdks13:34
Shrewsdtantsur: https://review.opendev.org/675134 would really help openstack infra avoid a pretty bad object leak we are seeing, if you have some time to review it14:15
dtantsurShrews: found a few minor issues, wanna fix them now or follow-up?14:17
*** elmiko has joined #openstack-sdks14:18
Shrewsdtantsur: How does re-raising the exception lose the traceback?14:19
dtantsurShrews: when you do 'raise e', the traceback will start from this instruction. when you do 'raise', the traceback is reused from the original exception.14:20
dtantsurpython fun14:20
*** slaweq has quit IRC14:20
Shrewsdtantsur: ah. so should all of those just be "raise" then ?14:20
dtantsurShrews: likely yes. In most case it's an antipattern to do 'except Something as e... raise e'.14:21
*** slaweq has joined #openstack-sdks14:21
dtantsur(python 3 has 'raise from', but let's ignore it for now)14:21
Shrewsdtantsur: ok. lemme fix that up then14:21
openstackgerritDavid Shrewsbury proposed openstack/openstacksdk master: Retry large object manifest upload  https://review.opendev.org/67513414:23
Shrewsdtantsur: ok, that look more sane?14:24
dtantsuryep14:24
Shrewsdtantsur: thx for the review. will bug mordred when he has internet again14:25
Shrewsmordred: since you are back, can you re-examine 675134 por favor?14:37
mordredShrews: I can!14:38
mordredShrews: +A - woot14:39
mordreddtantsur: wow, that's fun with user_data14:40
dtantsuryeah..14:40
efrieddtantsur: I'm not convinced you've actually done anything there.14:45
dtantsurwhere?14:45
efriedI'm playing around with it locally, but I think 't' vs 'b' only affects the data type you get *back*14:46
efriedI'm not sure it affects the data going in.14:46
efriedand since you're not returning anything here...14:46
dtantsurI was under impression 't' vs 'b' affects both directions14:47
dtantsurefried: http://paste.openstack.org/show/756340/14:47
dtantsur(this is python 3, I'm not sure there is a difference in python 2)14:48
efriedokay, I was trying to come up with a repro like that --^14:49
efriedand yeah, I meant to do it in py3, but I'm using py2 instead.14:49
efriedso, I stand corrected14:49
efried<waves hand like jedi> I was never here14:49
dtantsurhehe14:50
*** dave-mccowan has joined #openstack-sdks15:20
*** slaweq has quit IRC15:28
*** slaweq has joined #openstack-sdks15:30
*** factor has joined #openstack-sdks15:48
*** jpena is now known as jpena|off15:53
*** dave-mccowan has quit IRC15:56
*** dtruong has quit IRC15:59
*** dtruong has joined #openstack-sdks16:00
*** e0ne has quit IRC16:01
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Allow services to override proxy creation.  https://review.opendev.org/67411016:20
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Fix discovery cache sharing  https://review.opendev.org/67512116:20
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Add support for global_request_id  https://review.opendev.org/67480716:20
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rationalize endpoint_for and get_endpoint_from_catalog  https://review.opendev.org/67513016:20
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Validate that connect_as connects as the project  https://review.opendev.org/67517816:20
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Replace catalog-v3.json with keystoneauth fixture  https://review.opendev.org/67518716:20
mordreddtantsur: I had to rebase the stack, so I went ahead and squashed the cloud_region rename patch into https://review.opendev.org/#/c/67480716:23
openstackgerritMerged openstack/openstacksdk master: baremetal.configdrive: tolerate user_data as a string  https://review.opendev.org/67429816:24
dtantsurcool16:27
*** dtantsur is now known as dtantsur|afk16:37
*** jpich has quit IRC16:38
openstackgerritMerged openstack/openstacksdk master: Retry large object manifest upload  https://review.opendev.org/67513417:31
*** whoami-rajat has quit IRC17:38
*** gtmanfred has left #openstack-sdks17:43
*** cdent has quit IRC17:49
openstackgerritAlex Schultz proposed openstack/keystoneauth master: Cleanup session on delete  https://review.opendev.org/67413918:31
efriedmordred: Look, far be it from me to contradict a +1 from melissaml, but I think the test in https://review.opendev.org/#/c/674110/ needs to go a bit deeper.19:05
openstackgerritEric Fried proposed openstack/openstacksdk master: DRY test_connection  https://review.opendev.org/67600919:15
* efried fixes own mistake ^19:15
*** factor has quit IRC19:17
*** dave-mccowan has joined #openstack-sdks19:54
openstackgerritEric Fried proposed openstack/openstacksdk master: Minor refactor cleanup of _make_proxy  https://review.opendev.org/67601520:12
*** e0ne has joined #openstack-sdks20:26
*** efried has quit IRC20:39
*** efried has joined #openstack-sdks20:40
*** shubham_potale has quit IRC21:22
*** slaweq has quit IRC21:46
*** e0ne has quit IRC21:49
*** tosky has quit IRC21:55
*** mriedem is now known as mriedem_afk22:03
*** lbragstad has joined #openstack-sdks22:09
*** lbragstad has quit IRC22:17
*** dave-mccowan has quit IRC23:17
*** mriedem_afk has quit IRC23:19
*** dave-mccowan has joined #openstack-sdks23:37

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!