| *** slaweq has joined #openstack-sdks | 00:11 | |
| *** slaweq has quit IRC | 00:16 | |
| *** markvoelker has quit IRC | 00:32 | |
| *** markvoelker has joined #openstack-sdks | 00:33 | |
| *** markvoelker has quit IRC | 00:38 | |
| *** slaweq has joined #openstack-sdks | 01:11 | |
| *** slaweq has quit IRC | 01:16 | |
| *** markvoelker has joined #openstack-sdks | 01:21 | |
| *** whoami-rajat has joined #openstack-sdks | 01:35 | |
| *** slaweq has joined #openstack-sdks | 02:11 | |
| *** slaweq has quit IRC | 02:16 | |
| *** slaweq has joined #openstack-sdks | 04:11 | |
| *** slaweq has quit IRC | 04:16 | |
| *** ricolin has joined #openstack-sdks | 04:45 | |
| *** ricolin has quit IRC | 05:25 | |
| *** ricolin has joined #openstack-sdks | 05:28 | |
| *** Dinesh_Bhor has joined #openstack-sdks | 05:55 | |
| *** slaweq has joined #openstack-sdks | 06:06 | |
| *** efried1 has joined #openstack-sdks | 06:21 | |
| *** efried has quit IRC | 06:23 | |
| *** efried1 is now known as efried | 06:23 | |
| *** ricolin has quit IRC | 06:26 | |
| *** holser_ has joined #openstack-sdks | 06:42 | |
| *** markvoelker has quit IRC | 07:01 | |
| *** jpich has joined #openstack-sdks | 07:09 | |
| *** adriant has quit IRC | 07:10 | |
| *** adriant has joined #openstack-sdks | 07:11 | |
| *** ricolin has joined #openstack-sdks | 07:23 | |
| *** jpena|off is now known as jpena | 07:36 | |
| *** toabctl has quit IRC | 07:50 | |
| *** cdent has joined #openstack-sdks | 08:41 | |
| *** markvoelker has joined #openstack-sdks | 09:02 | |
| *** ricolin has quit IRC | 09:09 | |
| *** markvoelker has quit IRC | 09:35 | |
| *** e0ne has joined #openstack-sdks | 09:52 | |
| *** ITD27M01 has quit IRC | 09:55 | |
| *** jpich has quit IRC | 10:05 | |
| *** jpich has joined #openstack-sdks | 10:06 | |
| *** markvoelker has joined #openstack-sdks | 10:24 | |
| *** holser_ is now known as holser|lunch | 10:40 | |
| *** cdent has quit IRC | 10:55 | |
| *** jpena is now known as jpena|lunch | 11:02 | |
| *** tosky has joined #openstack-sdks | 12:14 | |
| *** jpena|lunch is now known as jpena | 12:25 | |
| *** holser|lunch is now known as holser_ | 12:57 | |
| *** cdent has joined #openstack-sdks | 13:02 | |
| *** mgariepy has quit IRC | 13:29 | |
| *** ITD27M01 has joined #openstack-sdks | 13:53 | |
| ITD27M01 | mordred: I really need your attention. If you have a minute, look at the https://github.com/ansible/ansible/pull/51401 | 14:01 |
|---|---|---|
| *** ricolin has joined #openstack-sdks | 14:53 | |
| *** zbr_ has joined #openstack-sdks | 15:07 | |
| *** zbr has quit IRC | 15:09 | |
| *** e0ne has quit IRC | 15:23 | |
| *** tosky has quit IRC | 15:44 | |
| elmiko | API SIG office hour is now open! \o/ | 16:00 |
| edleafe | Welcome to the API-SIG Office Hour! | 16:00 |
| elmiko | jinx! | 16:00 |
| edleafe | Heh, you beat me! | 16:00 |
| elmiko | it was like simultaneous on my end lol | 16:00 |
| edleafe | Mine got recorded first here: https://leafe.com/timeline-middle/%23openstack-sdks/2019-05-30T16:00:03 | 16:01 |
| edleafe | So we both win! | 16:01 |
| elmiko | hahaha, amazing | 16:01 |
| *** AJaeger has left #openstack-sdks | 16:02 | |
| cdent | I lost track, did the errors guidelines discussion go anywhere? | 16:15 |
| edleafe | There was a little async back-and-forth in this channel, but it didn't really go anywhere | 16:15 |
| elmiko | ++ | 16:16 |
| cmurphy | o/ | 16:16 |
| cmurphy | i don't think there's much more to discuss, it is what it is | 16:16 |
| edleafe | cdent: Starting here: https://leafe.com/timeline-middle/%23openstack-sdks/2019-05-23T20:34:53 | 16:16 |
| cdent | is there a next step? | 16:18 |
| elmiko | unless we are going to rewrite the guideline, i don't think so | 16:19 |
| cdent | potentially a patch to keystoneauth? | 16:19 |
| elmiko | that might be nice | 16:19 |
| elmiko | i have some time, i could take a look at patching it | 16:19 |
| cdent | you have time? I guess that's what happens when you work on something oher than openstack ;) | 16:20 |
| elmiko | yeah... plus when weird things happen to your group internally ;) | 16:20 |
| *** nwilburn has joined #openstack-sdks | 16:21 | |
| *** holser_ has quit IRC | 16:23 | |
| *** mgariepy has joined #openstack-sdks | 16:24 | |
| nwilburn | I found an issue with the add_ip_list function in opestack/cloud/openstackcloud.py. Basically nat_destination is not being passed to the _attach_ip_to_server function which causes issues with Ansible's os_floating_ip module (and probably other things). The immediate "fix" that I can see is to simply add a parameter "nat_destination" for add_ip_list, but this probably isn't the right way of doing | 16:27 |
| nwilburn | things. | 16:27 |
| nwilburn | Where is the best place to submit a bug report for this? | 16:27 |
| nwilburn | Apologies, it now lives in openstack/cloud/_floating_ip.py | 16:30 |
| elmiko | nwilburn: is that part of the sdk package? | 16:33 |
| nwilburn | It is | 16:35 |
| elmiko | hmm, maybe mordred knows | 16:35 |
| elmiko | at a guess, i would think here https://opendev.org/openstack/openstacksdk | 16:35 |
| elmiko | but i'm not 100% sure on that | 16:35 |
| nwilburn | Ok thanks | 16:36 |
| elmiko | don't quote me on that though ;) | 16:36 |
| elmiko | edleafe: it's been awhile since i've made pr's to openstack projects, do i want to be cloning from opendev and the using the standard `git review` mechanics? | 16:40 |
| *** cdent has quit IRC | 16:45 | |
| Shrews | nwilburn: are you setting nat_destination in your cloud.yaml file? | 16:46 |
| edleafe | elmiko: I clone from github, and then use `git review` | 16:46 |
| elmiko | ack, thanks! | 16:47 |
| nwilburn | Shrews: nat_destination is being passed in via the os_floating_ip ansible module. It does make it to the function which calls add_ip_list, but add_ip_list doesn't take a parameter of nat_destination | 16:47 |
| Shrews | nwilburn: ah, well that does sound like a bug | 16:48 |
| nwilburn | So openstacksdk tries to be smart about discovering what the nat_destination should be and it goes through a list of openstack networks looking for the last one which is attached to the public network. When the ansible module is being ran with admin credentials this results in a network being found which isn't even in the project that the server is in. Super strange | 16:49 |
| Shrews | indeed. floating ips and the surrounding logic is ... hard | 16:49 |
| nwilburn | So I added nat_destination to add_ip_list and changes up the function args for the calls. Things worked but this isn't the right way of doing things since the list of floating ips you want to attach may need differenation nat_destinations. Maybe the ip_list should actually be a list of dicts with ip:nat_destination? | 16:50 |
| *** jpich has quit IRC | 16:58 | |
| elmiko | have a good weekend edleafe, i'm gonna take a look into patching keystoneauth o/ | 17:01 |
| edleafe | elmiko: \o | 17:04 |
| *** ricolin has quit IRC | 17:42 | |
| *** jpena is now known as jpena|off | 18:13 | |
| openstackgerrit | Michael McCune proposed openstack/keystoneauth master: add handling for multiple error returns https://review.opendev.org/662281 | 18:19 |
| openstackgerrit | Michael McCune proposed openstack/keystoneauth master: add handling for multiple error returns https://review.opendev.org/662281 | 18:26 |
| elmiko | cmurphy: just a heads up ^^ | 18:29 |
| cmurphy | thanks elmiko | 18:30 |
| dtroyer | elmiko: This doesn't affect what you are doing now, but cloning from Github has some dark corner-cases now that not everything is mirrored there from the current opendev repos. That will affect everything that moved out of the official openstack/ namespace but has not been moved in Github yet.. | 19:25 |
| dtroyer | All official project repos are unaffected by that AFAIK | 19:26 |
| *** tosky has joined #openstack-sdks | 19:38 | |
| elmiko | dtroyer: ack, tyvm for the explanation. i defaulted to cloning from opendev =) | 19:44 |
| nwilburn | So I added nat_destination to add_ip_list and changes up the function args for the calls. Things worked but this isn't the right way of doing things since the list of floating ips you want to attach may need differenation nat_destinations. Maybe the ip_list should actually be a list of dicts with ip:nat_destination? | 20:04 |
| nwilburn | Oops sorry. Wrong window | 20:04 |
| elmiko | we'll forgive you /this time/ nwilburn XD | 20:15 |
| *** nwilburn has quit IRC | 20:37 | |
| *** whoami-rajat has quit IRC | 21:24 | |
| openstackgerrit | Michael McCune proposed openstack/keystoneauth master: add handling for multiple error returns https://review.opendev.org/662281 | 21:36 |
| *** bobh has joined #openstack-sdks | 22:10 | |
| *** bobh has quit IRC | 22:15 | |
| *** efried1 has joined #openstack-sdks | 22:19 | |
| *** efried has quit IRC | 22:20 | |
| *** efried1 is now known as efried | 22:20 | |
| *** bobh has joined #openstack-sdks | 22:54 | |
| *** bobh has quit IRC | 22:59 | |
| openstackgerrit | Michael McCune proposed openstack/keystoneauth master: add handling for multiple error returns https://review.opendev.org/662281 | 23:03 |
| openstackgerrit | Michael McCune proposed openstack/keystoneauth master: add handling for multiple error returns https://review.opendev.org/662281 | 23:03 |
| *** tosky has quit IRC | 23:33 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!