Wednesday, 2019-05-29

*** slaweq has joined #openstack-sdks00:11
*** slaweq has quit IRC00:24
*** dave-mccowan has joined #openstack-sdks00:31
*** markvoelker has quit IRC00:33
*** dave-mccowan has quit IRC00:35
*** efried has quit IRC00:37
*** ricolin_ has joined #openstack-sdks00:44
*** efried has joined #openstack-sdks00:45
*** slaweq has joined #openstack-sdks01:16
*** slaweq has quit IRC01:24
*** slaweq has joined #openstack-sdks02:11
*** slaweq has quit IRC02:25
openstackgerritjacky06 proposed openstack/keystoneauth master: Replace git.openstack.org URLs with opendev.org URLs  https://review.opendev.org/65501602:30
*** markvoelker has joined #openstack-sdks02:34
*** markvoelker has quit IRC03:08
*** slaweq has joined #openstack-sdks03:11
*** slaweq has quit IRC03:25
*** altlogbot_0 has quit IRC03:44
*** altlogbot_3 has joined #openstack-sdks03:46
*** markvoelker has joined #openstack-sdks04:05
*** slaweq has joined #openstack-sdks04:16
*** slaweq has quit IRC04:24
*** whoami-rajat has joined #openstack-sdks04:31
*** markvoelker has quit IRC04:37
*** altlogbot_3 has quit IRC04:38
*** altlogbot_0 has joined #openstack-sdks04:42
*** slaweq has joined #openstack-sdks05:11
*** slaweq has quit IRC05:18
*** markvoelker has joined #openstack-sdks05:34
*** gtema has joined #openstack-sdks05:55
*** dtantsur|afk is now known as dtantsur06:00
*** markvoelker has quit IRC06:08
*** slaweq has joined #openstack-sdks06:12
*** holser_ has joined #openstack-sdks06:52
*** markvoelker has joined #openstack-sdks07:05
*** tosky has joined #openstack-sdks07:11
*** ralonsoh has joined #openstack-sdks07:21
*** markvoelker has quit IRC07:37
*** tosky has quit IRC07:40
*** tosky has joined #openstack-sdks07:42
*** jpena|off is now known as jpena07:58
*** e0ne has joined #openstack-sdks07:59
*** ricolin_ has quit IRC08:07
*** ricolin has joined #openstack-sdks08:07
*** markvoelker has joined #openstack-sdks08:34
openstackgerritAndreas Jaeger proposed openstack/openstackclient master: Remove pbrx  https://review.opendev.org/66191408:39
*** cdent has joined #openstack-sdks09:05
*** markvoelker has quit IRC09:08
*** markvoelker has joined #openstack-sdks10:05
*** slaweq has quit IRC10:30
*** dave-mccowan has joined #openstack-sdks10:31
*** dave-mccowan has quit IRC10:37
*** markvoelker has quit IRC10:37
*** dtantsur is now known as dtantsur|lunch10:43
*** gtema has quit IRC10:48
*** slaweq has joined #openstack-sdks10:54
*** jpena is now known as jpena|lunch11:30
*** jangutter_ has joined #openstack-sdks11:32
*** markvoelker has joined #openstack-sdks11:34
*** jangutter has quit IRC11:36
*** redrobot has quit IRC11:39
*** markvoelker has quit IRC11:54
*** markvoelker has joined #openstack-sdks11:54
openstackgerritAkihiro Motoki proposed openstack/openstackclient master: Update sphinx dependency for python 2.7  https://review.opendev.org/66194711:55
*** e0ne has quit IRC12:16
*** redrobot has joined #openstack-sdks12:23
*** jpena|lunch is now known as jpena12:34
*** mtreinish has quit IRC12:36
*** mtreinish has joined #openstack-sdks12:36
*** AJaeger has joined #openstack-sdks12:40
AJaegermordred: for fixing openstackclient, you need to fix sphinx first - see https://review.opendev.org/#/c/661947/ and then the py27 bug in there ;(12:40
*** whoami-rajat has quit IRC12:51
*** jangutter has joined #openstack-sdks12:51
*** gmann has quit IRC12:53
*** jangutter_ has quit IRC12:54
AJaegeramotoki, mordred, I pushed a change on top of 661947. Interesting, you do not publish docs - is that intentional?12:56
* AJaeger pushes an update to publish as well...12:57
openstackgerritAndreas Jaeger proposed openstack/openstackclient master: Update sphinx dependency for python 2.7  https://review.opendev.org/66194713:02
openstackgerritAndreas Jaeger proposed openstack/openstackclient master: Switch to openstackdocstheme  https://review.opendev.org/66197413:02
AJaegeramotoki: updated your change13:03
elmikocmurphy: in answer to your last question, when i went to look back through the comments on the initial guideline proposal, it /looked/ lke someone had posted an example of returning multiple errors to a single call. outside of that though, i don't have an example at the ready.13:08
openstackgerritAndreas Jaeger proposed openstack/openstackclient master: Update sphinx dependency for python 2.7  https://review.opendev.org/66194713:23
openstackgerritAndreas Jaeger proposed openstack/openstackclient master: Switch to openstackdocstheme  https://review.opendev.org/66197413:23
*** e0ne has joined #openstack-sdks13:24
*** dmellado has quit IRC13:25
*** dmellado has joined #openstack-sdks13:25
*** dtantsur|lunch is now known as dtantsur13:35
AJaegermordred, dtroyer, so https://review.opendev.org/661947 fixes all the failures that openstackclient currently has and is the next change you need to merge...13:57
amotokiAJaeger: thanks for the update. As you pointed, we need to check the necessity of doc dependency and I will check it, but it looks good to merge 661947 first as it affects various changes.13:59
AJaegeramotoki: yes, we can discuss 661974 separately. Please discuss whether you want to publish docs, only build them - or just take the change without jobs to install less packages ;)14:00
*** whoami-rajat has joined #openstack-sdks14:03
*** gmann has joined #openstack-sdks14:10
*** ricolin has quit IRC14:20
*** ricolin has joined #openstack-sdks14:26
cmurphyelmiko: what i still find strange is that this would all be stuffed into the body of a single response, while the actual http response would only have one error code14:50
cmurphyit looks like rfc 7230 says that multiple responses could be returned for a single request but that's not how i read the guideline14:51
elmikocmurphy: i think you are right that it does seem odd for the http request to return a single error, but the body could express multiple internal errors15:23
elmikoand i would imagine in most cases the error in the body would reflect a single error about the return code15:23
elmikoif memory serves me correctly, and it might not, i think the idea was that a 500 error could expose more internal detail through this mechanism15:24
elmikoobviously for something like 404 it doesn't make much sense15:24
elmikoand yeah, i think the intent in 7230 is different than what we are describing in the guideline15:25
*** altlogbot_0 has quit IRC15:34
*** altlogbot_3 has joined #openstack-sdks15:36
*** irclogbot_0 has quit IRC15:36
*** irclogbot_3 has joined #openstack-sdks15:38
*** irclogbot_0 has joined #openstack-sdks15:38
*** dtantsur is now known as dtantsur|afk15:51
cdentcmurphy, elmiko: the goal, as I remember, is to encapsulate the fact that there could be a suite of several system errors that led up to a particular http error, and knowing both is desirable, thus the sepraration between and status and code16:01
cdentand yeah 7230 is something else16:01
cdentnot that I'm trying to defend the guideline. I've always thought it a bit weird, just trying to dredge up the reasons16:01
openstackgerritClark Boylan proposed openstack/python-openstackclient master: Replace pkg_resources with importlib-metadata  https://review.opendev.org/66185616:02
cmurphyas i said in the thread i don't mind patching keystoneauth to conform to the guideline, i just think the guideline is weird16:09
elmikocmurphy cdent, for clarity sake, i'm not trying to defend the guideline either, and it may in fact be weird.16:18
elmikothis does provide an excellent opportunity to reflect on how we might change things when turn out to not make sense16:18
elmikoi'm curious if we need to re-open that guideline and discuss it again if it turns out that a majority think it's weird and will probably never implement it16:19
cdenti suspect, unfortunately, that now that implementations of multiple styles are lose in the wild, we need to support them both forever16:20
cdentbecause though we've been willing to say that message in errors are okay to change whenever, changing their structure probably less so16:20
*** cdent has quit IRC16:22
*** ricolin has quit IRC16:42
*** holser_ is now known as holser|eod16:47
*** kmalloc_away is now known as kmalloc16:55
*** e0ne has quit IRC16:58
openstackgerritMerged openstack/keystoneauth master: Resolves a typo in a link to use Application Credentials  https://review.opendev.org/66088616:59
*** holser|eod has quit IRC17:06
*** jpena is now known as jpena|off17:15
*** tosky__ has joined #openstack-sdks17:59
*** tosky has quit IRC18:00
*** tosky__ is now known as tosky18:00
*** ralonsoh has quit IRC18:35
openstackgerritMerged openstack/keystoneauth master: Replace git.openstack.org URLs with opendev.org URLs  https://review.opendev.org/65501618:45
mordredif cdent was here, I'd say "of course, there are multiple forms of error payloads, so some things, like openstacksdk for instance, just do a shotgun approach and try their best to find some structure that might have error information in it"18:50
*** slaweq has quit IRC21:03
*** slaweq has joined #openstack-sdks21:11
*** whoami-rajat has quit IRC21:13
*** slaweq has quit IRC21:16
*** efried has quit IRC21:49
*** tosky has quit IRC21:49
*** efried has joined #openstack-sdks21:51
*** slaweq has joined #openstack-sdks22:11
*** slaweq has quit IRC22:16

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!