Friday, 2018-10-05

« Thursday, 2018-10-04 Index Saturday, 2018-10-06 »
*** pooja_jadhav has quit IRC00:17
*** pooja_jadhav has joined #openstack-sdks00:29
*** dave-mccowan has quit IRC01:16
*** mhen has quit IRC02:02
*** annp has joined #openstack-sdks03:01
*** gildub_ has joined #openstack-sdks04:39
*** gildub has quit IRC04:39
*** gildub_ has quit IRC04:39
*** gildub has joined #openstack-sdks04:40
*** openstackgerrit has quit IRC04:52
*** d0ugal has quit IRC04:52
*** rods has quit IRC04:52
*** openstackgerrit has joined #openstack-sdks04:57
*** d0ugal has joined #openstack-sdks04:57
*** rods has joined #openstack-sdks04:57
*** e0ne has joined #openstack-sdks05:34
*** e0ne has quit IRC05:50
*** e0ne has joined #openstack-sdks05:53
*** e0ne has quit IRC06:12
*** gildub has quit IRC06:38
*** markvoelker has joined #openstack-sdks06:40
*** markvoelker has quit IRC06:45
*** mhen has joined #openstack-sdks06:49
*** Luzi has joined #openstack-sdks07:26
*** olivierb_ has joined #openstack-sdks07:36
mlok, so now there is this openstacksdk-functional-devstack-networking run which is successful, but every other functional test run fails07:43
mlDo I have to adjust anything on my side?07:44
*** tosky has joined #openstack-sdks07:45
*** e0ne has joined #openstack-sdks07:49
fricklerml: looks like you need to skip your tests if fwaas is not enabled. currently they are failing instead07:52
mllike this? https://review.openstack.org/#/c/607199/4/openstack/tests/functional/network/v2/test_floating_ip.py07:57
*** ttsiouts has joined #openstack-sdks07:59
mlfwaas is not in the service list08:00
*** ttsiouts has quit IRC08:02
*** ttsiouts has joined #openstack-sdks08:03
*** ttsiouts has quit IRC08:07
*** ttsiouts has joined #openstack-sdks08:15
openstackgerritMatthias Lisin proposed openstack/openstacksdk master: Support firewall service for SDK  https://review.openstack.org/59230308:32
openstackgerritMatthias Lisin proposed openstack/openstacksdk master: openstackcloud.py: Implement FWaaS wrapper methods.  https://review.openstack.org/60481108:32
*** gildub has joined #openstack-sdks08:39
*** markvoelker has joined #openstack-sdks08:41
*** cdent has joined #openstack-sdks08:45
*** gildub has quit IRC08:45
fricklerml: something similar like that, yes. no idea how to detect fwaas, though, probably as a neutron extension?08:53
mlthat's what I did right now: https://review.openstack.org/#/c/592303/25..26/openstack/tests/functional/network/v2/test_firewall_group.py08:54
*** markvoelker has quit IRC09:15
openstackgerritStephen Finucane proposed openstack/os-api-ref master: tests: Support Sphinx 1.8+  https://review.openstack.org/60798409:23
openstackgerritStephen Finucane proposed openstack/os-api-ref master: DNM: Attempt to replace monkeypath with mock  https://review.openstack.org/60819009:23
stephenfindhellmann: I'm not sure. I've pushed up a sample of what I'm doing, if you fancy taking a look https://review.openstack.org/60819009:24
*** stephenfin is now known as finucannot09:35
*** gkadam has joined #openstack-sdks09:43
*** sheel has joined #openstack-sdks10:05
*** markvoelker has joined #openstack-sdks10:12
*** ttsiouts has quit IRC10:22
*** markvoelker has quit IRC10:44
*** annp has quit IRC10:53
*** dtantsur|afk is now known as dtantsur11:09
*** ttsiouts has joined #openstack-sdks11:40
*** markvoelker has joined #openstack-sdks11:41
*** e0ne has quit IRC11:54
*** markvoelker has quit IRC12:15
*** dtantsur is now known as dtantsur|brb12:27
*** e0ne has joined #openstack-sdks12:29
*** sheel has quit IRC12:34
*** dims_ has quit IRC12:58
*** mriedem has joined #openstack-sdks12:59
mordredml: +2 looks great! I think that's the right way to go with detecting the extension13:00
mlmordred: thanks13:00
mordredslaweq: if you get a sec, could you re-review https://review.openstack.org/#/c/592303 ? we had to rebase around a patch to fix OOM errors in the test suite13:00
mordredslaweq: if you feel like looking at https://review.openstack.org/#/c/604517 too that would be swell13:01
slaweqmordred: sure, I even had it opened in brower already :)13:01
*** Luzi has quit IRC13:04
mordredslaweq: that makes it easier :)13:06
slaweqmordred: I have one comment in https://review.openstack.org/#/c/604517/7 - if that is fine, I will +2 on it13:08
mordredslaweq: yah - that's intentional - mostly trying to get less things to run in that test since they're tested in other jobs ... I probably could clean this up even more - but I think I need a big whiteboard to draw on to do so :)13:10
slaweqmordred: ok, then it's fine for me13:10
slaweq+2'ed :)13:11
mordred\o/13:11
toskymorning/afternoon/hello, any news about the branching of openstack/openstackclient.git? (to fix the check plugin jobs for older branches)13:14
*** dave-mccowan has joined #openstack-sdks13:16
*** dave-mccowan has quit IRC13:21
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove profile  https://review.openstack.org/60441413:35
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Set endpoint_override from endpoint with noauth  https://review.openstack.org/60441513:35
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Use discovery instead of config to create proxies  https://review.openstack.org/60029213:35
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove api version default values  https://review.openstack.org/60033013:35
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Use network proxy in openstack.cloud  https://review.openstack.org/60464513:35
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove all the deprecated stuff  https://review.openstack.org/60550813:35
*** ttsiouts has quit IRC13:39
*** dtantsur|brb is now known as dtantsur13:48
mordreddtantsur: \o/13:58
*** ttsiouts has joined #openstack-sdks14:00
*** olivierb_ has quit IRC14:27
Shrewsmordred: i don't see a "self.network" in 60464514:27
*** ttsiouts has quit IRC14:31
*** ttsiouts has joined #openstack-sdks14:31
*** ttsiouts has quit IRC14:36
*** e0ne has quit IRC14:38
openstackgerritMerged openstack/openstacksdk master: Clean up python3 test and split networking into a job  https://review.openstack.org/60451715:10
openstackgerritMerged openstack/openstacksdk master: Support firewall service for SDK  https://review.openstack.org/59230315:10
mordredShrews: self is a Connection - so there's a property on self for each openstack service15:12
mordredShrews: (the sdk proxy layer stuff)15:12
mordredShrews: https://docs.openstack.org/openstacksdk/latest/user/connection.html#openstack.connection.Connection.network15:14
openstackgerritStephen Finucane proposed openstack/os-api-ref master: tests: Support Sphinx 1.8+  https://review.openstack.org/60798415:15
*** ttsiouts has joined #openstack-sdks15:21
Shrewsmordred: ??? self is an OpenStackCloud15:24
mordredShrews: yah. but an OpenStackCloud is a Connection15:27
Shrewsah, Connection derives from OpenStackCloud15:28
dtantsurmaaaaagiiiic15:28
Shrewsbut an OpenStackCloud is not a Connection15:28
Shrewsi don't think i like that magic15:28
mordredShrews: oh - sorry - it's backwards. a Connection is an OpenStackCloud15:28
mordredShrews: and we only instantiate Connection ... we should reorganize that better15:29
*** ttsiouts has quit IRC15:29
Shrewsso OpenStackCloud methods are depending on attributes in a Connection... which is weird15:29
dtantsurevery proxy is an adapter, every connection is an openstacksdk, what's unclear about it? :D15:29
*** ttsiouts has joined #openstack-sdks15:30
Shrewsdtantsur: it's normal for derived classes to reference base class attributes. but not the other way around15:30
mordredShrews: yah - end goal I think is to not have OpenStackCloud as a separate class at all - it's split currently just for hysterical raisins15:30
dtantsurjust in case: I was kidding about the "what's unclear" bit. The answer is "largely everything" :)15:30
dtantsur* hysterical raisins, that's gold15:31
mordredShrews: maybe we should make a patch that moves the content from openstack/cloud/openstackcloud into openstack/connection Connection ?15:31
Shrewsmordred: i was about to suggest that, but i wasn't sure what your end goal looks like15:32
Shrewsor else, make OpenStackCloud abstract but that might break things15:33
mordredShrews: yah - end goal is to just have a Connection - the split is purely case we haven't gotten to it yet15:33
Shrewsdo we have *any* code in other projects directly instantiating OpenStackCloud itself?15:34
*** ttsiouts has quit IRC15:34
Shrews(from sdk)15:34
Shrewsb/c this obviously breaks that15:34
mordredShrews: not that I'm aware of, no15:35
mordredand shade.OpenStackCloud is a subclass of openstack.connection.Connection15:35
mordredso most of this is designed to be as confusing to you as I could make it15:36
Shrewsgood job15:36
Shrewsok, just reviewed the suggested connection methods in the docs, so we're good there.15:38
mordredShrews: would it be helpful if we replaced more things with metaclasses?15:38
Shrewsmordred: i think i just want to understand your plan more betterer15:38
mordredme too15:39
Shrewsif the plan is "pretend OpenStackCloud is really a Connection for now and we'll move the methods later", then fine15:39
Shrewsor some other thing15:39
Shrewsbut i didn't know what it was15:40
Shrewsfrom just the review15:40
mordredyah. let's say that's the plan. I think that's a good plan15:40
Shrewsok15:41
mordredShrews: maybe we should at least rename OpenStackCloud to _OpenStackCloud so it's clear it's more of a mixin than an actual standalone class15:41
Shrewsor OpenStackCloudMixin15:41
mordred++15:41
Shrewsi think we should move the connect* methods out of that mixin class too15:47
Shrewsso it's even more clearerer15:47
*** e0ne has joined #openstack-sdks15:50
*** e0ne has quit IRC15:55
mordredShrews: ++16:08
*** mriedem has quit IRC16:09
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Add some warnings and clarifications for discovery  https://review.openstack.org/60611316:19
*** gkadam has quit IRC16:21
*** cdent has left #openstack-sdks16:30
*** dims has joined #openstack-sdks16:46
*** dtantsur is now known as dtantsur|afk17:18
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Start shifting cloud object-store methods to proxy  https://review.openstack.org/60831717:29
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Make it clear that OpenStackCloud is a mixin  https://review.openstack.org/60831817:29
mordredShrews: ^^ just for you17:29
*** imacdonn has quit IRC18:22
*** imacdonn has joined #openstack-sdks18:22
*** slaweq has quit IRC18:37
*** slaweq has joined #openstack-sdks18:38
*** e0ne has joined #openstack-sdks19:38
*** e0ne has quit IRC19:43
*** e0ne has joined #openstack-sdks19:55
*** e0ne has quit IRC19:56
openstackgerritRuby Loo proposed openstack/python-openstackclient master: Add --property option to 'server rebuild' command  https://review.openstack.org/60835020:33
*** e0ne has joined #openstack-sdks20:44
*** e0ne has quit IRC20:49
*** bobh has joined #openstack-sdks21:23
*** bobh has quit IRC22:04
openstackgerritMerged openstack/openstacksdk master: Remove profile  https://review.openstack.org/60441422:20
openstackgerritMerged openstack/openstacksdk master: Set endpoint_override from endpoint with noauth  https://review.openstack.org/60441522:20
« Thursday, 2018-10-04 Index Saturday, 2018-10-06 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!