| *** slaweq has joined #openstack-sdks | 00:11 | |
| *** slaweq has quit IRC | 00:15 | |
| *** gildub has joined #openstack-sdks | 00:21 | |
| *** gildub has quit IRC | 00:39 | |
| *** dave-mccowan has quit IRC | 00:52 | |
| *** adriant has quit IRC | 00:54 | |
| *** adriant has joined #openstack-sdks | 01:00 | |
| *** mhen has quit IRC | 01:05 | |
| *** slaweq has joined #openstack-sdks | 01:11 | |
| *** slaweq has quit IRC | 01:15 | |
| *** pooja-jadhav has joined #openstack-sdks | 02:42 | |
| *** pooja_jadhav has quit IRC | 02:46 | |
| *** slaweq has joined #openstack-sdks | 03:11 | |
| *** slaweq has quit IRC | 03:16 | |
| *** pooja-jadhav has quit IRC | 04:14 | |
| *** pooja_jadhav has joined #openstack-sdks | 04:16 | |
| *** slaweq has joined #openstack-sdks | 05:11 | |
| *** slaweq has quit IRC | 05:16 | |
| *** gildub has joined #openstack-sdks | 05:27 | |
| *** gildub has quit IRC | 05:30 | |
| *** gildub has joined #openstack-sdks | 05:31 | |
| *** gildub has quit IRC | 05:34 | |
| *** gildub has joined #openstack-sdks | 05:36 | |
| *** gildub has quit IRC | 05:36 | |
| *** gildub has joined #openstack-sdks | 05:39 | |
| *** gildub has quit IRC | 05:43 | |
| *** Luzi has joined #openstack-sdks | 05:57 | |
| *** gildub has joined #openstack-sdks | 05:59 | |
| *** slaweq has joined #openstack-sdks | 06:57 | |
| *** ttsiouts has joined #openstack-sdks | 06:59 | |
| *** mhen has joined #openstack-sdks | 07:08 | |
| *** gildub has quit IRC | 07:10 | |
| *** ttsiouts has quit IRC | 07:16 | |
| *** tosky has joined #openstack-sdks | 07:45 | |
| *** olivierb_ has joined #openstack-sdks | 07:52 | |
| *** ttsiouts has joined #openstack-sdks | 08:00 | |
| *** gildub has joined #openstack-sdks | 08:19 | |
| *** gkadam has joined #openstack-sdks | 08:30 | |
| *** gkadam has quit IRC | 08:31 | |
| *** e0ne has joined #openstack-sdks | 08:42 | |
| *** ttsiouts has quit IRC | 08:49 | |
| *** gildub has quit IRC | 08:50 | |
| *** gtema has joined #openstack-sdks | 08:54 | |
| *** ttsiouts has joined #openstack-sdks | 08:59 | |
| *** ttsiouts has quit IRC | 09:04 | |
| *** ttsiouts has joined #openstack-sdks | 09:08 | |
| *** dtantsur|afk is now known as dtantsur | 09:55 | |
| dtantsur | mordred: OOM killer, w000t | 10:00 |
|---|---|---|
| dtantsur | also my question re raising the minimum version was not exactly about raising a version of an existing service | 10:00 |
| dtantsur | I'm writing a smart proxy for bare metal API, and I wonder if it's possible to not implement all 46-something microversions in it >_< | 10:01 |
| *** ttsiouts has quit IRC | 10:21 | |
| *** ttsiouts has joined #openstack-sdks | 10:31 | |
| *** slaweq_ has joined #openstack-sdks | 10:37 | |
| *** slaweq has quit IRC | 10:40 | |
| *** slaweq__ has joined #openstack-sdks | 10:56 | |
| *** dave-mccowan has joined #openstack-sdks | 10:56 | |
| *** slaweq_ has quit IRC | 10:57 | |
| *** dave-mccowan has quit IRC | 11:01 | |
| *** dave-mccowan has joined #openstack-sdks | 11:01 | |
| *** cdent has joined #openstack-sdks | 11:14 | |
| cdent | stephenfin: what's the issue with pytest? | 11:21 |
| *** ttsiouts has quit IRC | 11:32 | |
| *** gtema has quit IRC | 11:46 | |
| *** ttsiouts has joined #openstack-sdks | 12:07 | |
| *** tosky__ has joined #openstack-sdks | 12:37 | |
| *** tosky is now known as Guest8399 | 12:37 | |
| *** tosky__ is now known as tosky | 12:37 | |
| *** Guest8399 has quit IRC | 12:39 | |
| stephenfin | cdent: IIRC, nose and pytest share the same problem: they're a-ok as test runners but its their use as a test library that raises objections | 12:49 |
| cdent | that's a shame | 12:49 |
| cdent | pytest is so much _better_ | 12:49 |
| stephenfin | cdent: I'd suggest discussing that with mordred. He cares a *lot* about this stuff :) | 12:50 |
| cdent | yeah, I'm not meaning to badger you, just wondered if you had some insight | 12:51 |
| cdent | I ran up against similar resistance when creating gabbi. I didn't want it to be unitest-based | 12:51 |
| cdent | but lifeless and a few others were super clear that I'd never get anywhere in openstack if it wasn't | 12:52 |
| stephenfin | Yeah, mordred has explain his arguments for using it pretty well a couple of times but, alas, I never recorded them and can't find them now (maybe he should write a blog?) | 12:56 |
| stephenfin | Fwiw though, while I enjoy the clever assertion handling, I'm really not a fan of the fixtures/markers. They're confusing and utterly unlike anything else I've seen in Python | 12:56 |
| *** bobh has joined #openstack-sdks | 12:59 | |
| cdent | stephenfin: I agree that pytest lost its way | 13:04 |
| cdent | I got into it in 2008ish, and back then it was very very very simple and I _loved_ it | 13:05 |
| cdent | now, there's too many magics | 13:05 |
| stephenfin | magic, yeah, that's the word | 13:05 |
| stephenfin | It took me days to grok what on earth the Sphinx tests were doing and, even now, I'm carrying code for my own tests that I don't full understand. I blame pytest for a good chunk of that | 13:09 |
| stephenfin | *fully | 13:09 |
| cdent | when I added pytest support to dynamic test generation in gabbi, the very simple yield-based strategy that I had used back in 2009ish had been deprecated in favor of something insanely inscrutable | 13:18 |
| *** slaweq__ is now known as slaweq | 13:36 | |
| *** brtknr has joined #openstack-sdks | 13:56 | |
| *** gkadam has joined #openstack-sdks | 14:00 | |
| * dtantsur follows this discussion with interest, since he was asked about pytest when giving a talk about unit testing python at the local user group | 14:04 | |
| cdent | you can still do non-magic in pytest, so it still has going for it | 14:05 |
| brtknr | I'm using python-openstackclient with python 3.7 and im getting this: | 14:06 |
| brtknr | (OS) ➜ osc-lib git:(master) openstack server list | 14:06 |
| brtknr | issubclass() arg 1 must be a class | 14:06 |
| brtknr | i can still using nova list | 14:06 |
| brtknr | i also didnt have the issue with python 3.6 | 14:07 |
| smcginnis | brtknr: I'm not sure we are fully ready for Python 3.7 yet. | 14:24 |
| *** tosky__ has joined #openstack-sdks | 14:27 | |
| *** tosky has quit IRC | 14:28 | |
| *** tosky__ is now known as tosky | 14:28 | |
| brtknr | Well, it appears to work when I make this change: http://paste.openstack.org/show/731490/ | 14:29 |
| brtknr | But I also saw this pending change on gerrit: https://review.openstack.org/#/c/597699/2 | 14:29 |
| brtknr | Last updated 30th August.... | 14:30 |
| *** pooja_jadhav has quit IRC | 14:30 | |
| brtknr | Looking at the number of changes relating to this issue, looks like its a touchy subject... | 14:31 |
| *** pooja_jadhav has joined #openstack-sdks | 14:31 | |
| brtknr | for e.g. https://review.openstack.org/#/c/584920/1 | 14:31 |
| * dtantsur recalls something about issubclass becoming more picky in 3.7 | 14:31 | |
| frickler | brtknr: our target for this cycle is to get all things working with 3.6, so 3.7 is still a bit down the road I think | 14:32 |
| brtknr | And this: https://review.openstack.org/#/c/581886/1/osc_lib/utils/__init__.py | 14:32 |
| brtknr | dtantsur: who are you? why do you speak in 3rd person | 14:34 |
| brtknr | ? | 14:34 |
| dtantsur | brtknr: https://www.livinginternet.com/r/ra_action.htm | 14:35 |
| * frickler likes that link | 14:36 | |
| * smcginnis laughs | 14:37 | |
| * brtknr says Oh... | 14:38 | |
| smcginnis | :) | 14:38 |
| *** cdent has quit IRC | 14:53 | |
| *** bobh has quit IRC | 14:58 | |
| *** e0ne has quit IRC | 14:58 | |
| brtknr | my py37 tox test is passing when i change issubclass back to isinstance... http://paste.openstack.org/show/731499/ | 15:02 |
| brtknr | according to this patch | 15:03 |
| brtknr | http://paste.openstack.org/show/731490/ | 15:03 |
| *** cdent has joined #openstack-sdks | 15:03 | |
| brtknr | on the other hand, its failing without the patch: http://paste.openstack.org/show/731500/ | 15:03 |
| *** bobh has joined #openstack-sdks | 15:04 | |
| *** olivierb_ has quit IRC | 15:04 | |
| brtknr | It also fails for py27 without the patch! | 15:04 |
| brtknr | ... wait no it doesnt | 15:05 |
| *** olivierb_ has joined #openstack-sdks | 15:05 | |
| brtknr | ... my bad | 15:05 |
| *** bobh has quit IRC | 15:10 | |
| *** ttsiouts has quit IRC | 15:11 | |
| openstackgerrit | Stephen Finucane proposed openstack/os-api-ref master: tests: Support Sphinx 1.8+ https://review.openstack.org/607984 | 15:13 |
| *** e0ne has joined #openstack-sdks | 15:13 | |
| stephenfin | dhellmann: Would appreciate your Python-fu on the above. I'm not sure why a mock decorator on the class isn't working | 15:14 |
| stephenfin | dhellmann: Specifically https://review.openstack.org/607984 | 15:14 |
| *** Luzi has quit IRC | 15:25 | |
| *** olivierb_ has quit IRC | 15:29 | |
| mordred | cdent: oh - yeah, I can't stand py.test | 15:29 |
| *** olivierb_ has joined #openstack-sdks | 15:29 | |
| mordred | cdent: but that's not why I'd suggest not using it in an openstack context - the main thing is that we have a bunch of infrastructure that's based around subunit streams | 15:31 |
| mordred | cdent: so far attempts to make a subunit output plugin for py.test have all died on the vine | 15:31 |
| cdent | yeah, that's my recollection from early gabbi too: can work however, as long as it can output subunit | 15:31 |
| mordred | yah | 15:31 |
| dtantsur | mordred: out of curiosity: why can't you stand py.test? | 15:32 |
| mordred | I thinik it would be good for the world if someone would write a good subunit plugin for py.test | 15:32 |
| mordred | dtantsur: I find the way the magical fixtures work impossible to read/follow | 15:32 |
| mordred | in talking about it as a unittest library | 15:33 |
| mordred | but also - the 'I'm a test runner and also a unittest library' annoys me since there is a unittest discovery protocol in core python - so nose and py.test mixing the two concerns is annoying | 15:33 |
| dtantsur | agreed | 15:34 |
| cdent | i think the original assertion with py.test, long before it became so magic, was that unittest (as mode and as a library) is entirely unpythonic, which I agree with | 15:34 |
| mordred | when we write tests that follow the standard unittest discovery protocol - then people are free to use py.test or stestr or nosetests on the command line as they feel like | 15:34 |
| cdent | when it moved on from holger it got a bit out of hand | 15:34 |
| *** bobh has joined #openstack-sdks | 15:37 | |
| mordred | many things do | 15:42 |
| *** bobh has quit IRC | 15:44 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Support firewall service for SDK https://review.openstack.org/592303 | 15:46 |
| mordred | ml, dtantsur, Shrews: ^^ I squashed the test fix patches into the firewall service patch - that should be green, we should be able to land it and then the gate should stop being broken | 15:47 |
| *** e0ne has quit IRC | 15:47 | |
| dtantsur | I'm not sure what I think about squashing the fixes with a huge feature patch. Is it your way of forcing us to review it? :) | 15:47 |
| mordred | dtantsur: :) ... no, it was just to avoid rebase pain since the fwaas patch also adds job config that touches the same jobs | 15:49 |
| mordred | dtantsur: I could unsquash and try rebasing it into a different order if you want though | 15:50 |
| dtantsur | I'd prefer the gate fix separate, to be honest, and the fwaas patch on top of it | 15:52 |
| *** olivierb_ has quit IRC | 15:55 | |
| Shrews | ditto. these large changes to review are just not fun | 15:56 |
| Shrews | smaller the better | 15:56 |
| mordred | kk. I'll take a stab at that real quick | 15:57 |
| edleafe | /me notes that API-SIG office hours have started | 16:00 |
| edleafe | well, office *hour* | 16:01 |
| * dtantsur is semi-around but may leave earlier | 16:04 | |
| edleafe | dtantsur: don't worry, I'll try to keep up with the volume of participants :) | 16:05 |
| dtantsur | lol | 16:06 |
| cdent | did you all see the discussion with rosmaita yesterday or so? | 16:06 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Clean up python3 test and split networking into a job https://review.openstack.org/604517 | 16:06 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Support firewall service for SDK https://review.openstack.org/592303 | 16:06 |
| * cdent finds link | 16:06 | |
| mordred | dtantsur, Shrews: ok - that wasn't as painful as I thought | 16:07 |
| mordred | I still merged the two testing update patches since they're both just basically updating .zuul.yaml | 16:07 |
| cdent | http://p.anticdent.org/3Htt | 16:07 |
| dtantsur | mordred: ok, I think this is fine | 16:09 |
| mordred | \o/ | 16:09 |
| mordred | now here's hoping I id it right :) | 16:09 |
| dtantsur | hehe | 16:09 |
| edleafe | cdent: no, didn't see that | 16:10 |
| dtantsur | okay, actually. My head refuses to do any thinking more. I guess I'll go for some jogging instead. | 16:10 |
| * cdent needs that kind of habit | 16:10 | |
| *** dtantsur is now known as dtantsur|afk | 16:10 | |
| smcginnis | If I were to work on adding more Cinder commands to python-openstackclient - is the plan now to put things in openstacksdk or other lib first, then expose it through osc? Or just use cinderclient within osc? | 16:11 |
| * smcginnis seems to remember half paying attention to some long term plan discussions | 16:11 | |
| mordred | smcginnis: the plan is to move osc to using sdk and off of python-*client - and hopefully we will be in a position to start doing rip-and-replace in a few weeks | 16:29 |
| smcginnis | mordred: So if I were to look at adding some commands, I should first look at adding that functionality to openstacksdk? | 16:31 |
| mordred | smcginnis: that would be the bestest choice - but also python-cinderclient is also currently being used, so I wouldn't block yourself on that transition | 16:35 |
| smcginnis | Great, sounds reasonable. | 16:35 |
| smcginnis | I'll see what works best, considering the long term plan I would like to avoid creating later work if possible. | 16:35 |
| openstackgerrit | Logan V proposed openstack/openstacksdk master: Add networks to Limestone vendor https://review.openstack.org/608027 | 16:57 |
| *** gkadam has quit IRC | 17:08 | |
| dhellmann | stephenfin : is mock failing because of import ordering or something? | 17:15 |
| dhellmann | stephenfin : if you have a version of a change that wasn't working, I could poke at that a bit | 17:16 |
| *** bobh has joined #openstack-sdks | 17:45 | |
| *** olivierb has joined #openstack-sdks | 18:01 | |
| *** olivierb has quit IRC | 18:01 | |
| *** imacdonn has quit IRC | 18:22 | |
| *** imacdonn has joined #openstack-sdks | 18:22 | |
| *** e0ne has joined #openstack-sdks | 18:31 | |
| *** e0ne has quit IRC | 18:33 | |
| *** mriedem has joined #openstack-sdks | 18:34 | |
| *** cdent has quit IRC | 18:39 | |
| *** mriedem has quit IRC | 19:15 | |
| *** cdent has joined #openstack-sdks | 19:23 | |
| *** mriedem has joined #openstack-sdks | 19:24 | |
| *** cdent has quit IRC | 19:54 | |
| *** e0ne has joined #openstack-sdks | 20:08 | |
| *** e0ne has quit IRC | 20:14 | |
| *** e0ne has joined #openstack-sdks | 20:30 | |
| ml | mordred: thanks for the fix. any chance you can restore +2 CR? | 20:34 |
| openstackgerrit | Matthias Lisin proposed openstack/openstacksdk master: openstackcloud.py: Implement FWaaS wrapper methods. https://review.openstack.org/604811 | 20:34 |
| *** tosky has quit IRC | 20:42 | |
| *** tosky has joined #openstack-sdks | 20:43 | |
| *** e0ne has quit IRC | 21:00 | |
| *** mriedem has quit IRC | 21:05 | |
| *** bobh has quit IRC | 21:58 | |
| *** tosky has quit IRC | 23:17 | |
| *** edleafe has quit IRC | 23:39 | |
| *** gildub has joined #openstack-sdks | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!