*** Qiming has quit IRC | 00:00 | |
openstackgerrit | Monty Taylor proposed openstack/os-client-config: Handle ksa opt with no deprecated field https://review.openstack.org/225519 | 00:10 |
---|---|---|
mordred | Shrews: if you're around ^^ I need to land that because it's actually broken for ansible | 00:13 |
openstackgerrit | Merged openstack/os-client-config: Handle ksa opt with no deprecated field https://review.openstack.org/225519 | 00:20 |
*** gildub has joined #openstack-sdks | 00:41 | |
*** chlong has joined #openstack-sdks | 00:42 | |
*** Qiming has joined #openstack-sdks | 00:54 | |
*** stevemar has joined #openstack-sdks | 01:16 | |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Format an images properties and tags https://review.openstack.org/225505 | 01:30 |
*** stevemar has quit IRC | 06:05 | |
*** ParsectiX has joined #openstack-sdks | 06:08 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-openstackclient: Imported Translations from Zanata https://review.openstack.org/225393 | 06:09 |
*** e0ne has joined #openstack-sdks | 06:10 | |
*** e0ne has quit IRC | 06:14 | |
*** gildub has quit IRC | 06:36 | |
openstackgerrit | Qiming Teng proposed stackforge/python-openstacksdk: Add support to stack update https://review.openstack.org/225560 | 07:00 |
*** ParsectiX has quit IRC | 07:00 | |
*** e0ne has joined #openstack-sdks | 07:06 | |
*** jamielennox is now known as jamielennox|away | 07:09 | |
*** chlong has quit IRC | 07:17 | |
*** ParsectiX has joined #openstack-sdks | 07:21 | |
*** ParsectiX has quit IRC | 07:30 | |
*** ParsectiX has joined #openstack-sdks | 07:31 | |
*** ParsectiX has quit IRC | 08:09 | |
*** ParsectiX has joined #openstack-sdks | 08:19 | |
*** chlong has joined #openstack-sdks | 08:43 | |
*** e0ne has quit IRC | 08:46 | |
*** boris-42 has quit IRC | 08:53 | |
*** ParsectiX has quit IRC | 09:15 | |
*** boris-42 has joined #openstack-sdks | 09:24 | |
*** ParsectiX has joined #openstack-sdks | 09:34 | |
*** e0ne has joined #openstack-sdks | 09:58 | |
*** ParsectiX has quit IRC | 10:32 | |
*** Qiming has quit IRC | 10:48 | |
*** ParsectiX has joined #openstack-sdks | 10:49 | |
*** Shrews has quit IRC | 11:17 | |
*** Shrews has joined #openstack-sdks | 11:17 | |
*** gildub has joined #openstack-sdks | 11:20 | |
*** terrylhowe has joined #openstack-sdks | 11:26 | |
openstackgerrit | Merged openstack/os-client-config: Test kwargs passing not just argparse https://review.openstack.org/224346 | 11:30 |
*** Qiming has joined #openstack-sdks | 11:37 | |
*** trown|outttypeww is now known as trown | 11:49 | |
*** gildub has quit IRC | 12:14 | |
*** e0ne has quit IRC | 12:44 | |
*** pratikmallya has joined #openstack-sdks | 13:06 | |
*** pratikma_ has joined #openstack-sdks | 13:08 | |
*** pratikmallya has quit IRC | 13:12 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient: Add image create support for image v2 https://review.openstack.org/225443 | 13:33 |
*** woodster_ has joined #openstack-sdks | 13:33 | |
dhellmann | dtroyer, terrylhowe: where do things stand with OSC, do you want a release or should I cut a stable branch from the most current release? | 13:44 |
terrylhowe | I’m not sure dhellmann | 13:45 |
*** e0ne has joined #openstack-sdks | 13:47 | |
dhellmann | terrylhowe: ok. today's the day, so we need to figure that out. is dtroyer around this week? I haven't seen him online in a while. | 13:50 |
terrylhowe | it looks like all the important patches were merged dhellmann but there is one new bug just openned that looks disturbing to me | 13:51 |
dhellmann | terrylhowe: that sounds like a good candidate for a backport, at this point | 13:53 |
*** Qiming has quit IRC | 13:55 | |
terrylhowe | ah, dhellmann that bug was not a problem actually, just give dtroyer a bit more time I guess | 13:56 |
*** Qiming has joined #openstack-sdks | 13:57 | |
*** david-ly_ is now known as david-lyle | 14:01 | |
mordred | also - I'd like to get the glance v2 patch landed | 14:01 |
mordred | it's got a +2 from stevemar - and it helps remove a workaround in devstack | 14:01 |
mordred | dhellmann, terrylhowe: https://review.openstack.org/#/c/225443/ and https://review.openstack.org/#/c/225505/ - they should be landable today | 14:02 |
*** jlvillal has joined #openstack-sdks | 14:05 | |
*** ParsectiX has quit IRC | 14:09 | |
*** jose4183 has joined #openstack-sdks | 14:09 | |
*** e0ne has quit IRC | 14:10 | |
*** ParsectiX has joined #openstack-sdks | 14:10 | |
*** ParsectiX has quit IRC | 14:11 | |
*** e0ne has joined #openstack-sdks | 14:14 | |
*** zz_steveortiz is now known as steveortiz | 14:22 | |
*** david-lyle has quit IRC | 14:22 | |
dhellmann | dtroyer, mordred: I don't have permissions on the os-client-config lp page https://launchpad.net/os-client-config | 14:23 |
dhellmann | dtroyer, mordred : can one of you fix that up according to http://docs.openstack.org/infra/manual/creators.html#set-up-launchpad | 14:23 |
mordred | there's a launchpad page? | 14:23 |
mordred | dhellmann: I cannot - I also do not have permissions | 14:24 |
dhellmann | mordred: ack | 14:24 |
*** david-lyle has joined #openstack-sdks | 14:26 | |
*** Qiming has quit IRC | 14:34 | |
*** Qiming has joined #openstack-sdks | 14:35 | |
openstackgerrit | Merged openstack/python-openstackclient: Set default auth plugin back to 'password' https://review.openstack.org/225284 | 14:40 |
openstackgerrit | Monty Taylor proposed openstack/os-client-config: Change ignore-errors to ignore_errors https://review.openstack.org/225782 | 14:41 |
openstackgerrit | OpenStack Proposal Bot proposed stackforge/python-openstacksdk: Updated from global requirements https://review.openstack.org/224699 | 14:44 |
*** pratikma_ has quit IRC | 14:46 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient: Change ignore-errors to ignore_errors https://review.openstack.org/225823 | 14:54 |
dtroyer | dhellmann, mordred: os-client-config LP should be good now, openstack-release invited to drivers team | 15:10 |
dhellmann | dtroyer: ty | 15:10 |
openstackgerrit | Merged openstack/os-client-config: Change ignore-errors to ignore_errors https://review.openstack.org/225782 | 15:13 |
*** pratikmallya has joined #openstack-sdks | 15:17 | |
*** stevemar has joined #openstack-sdks | 15:22 | |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Format an images properties and tags https://review.openstack.org/225505 | 15:26 |
openstackgerrit | Monty Taylor proposed stackforge/python-openstacksdk: Change ignore-errors to ignore_errors https://review.openstack.org/225895 | 15:27 |
*** pratikma_ has joined #openstack-sdks | 15:30 | |
*** pratikmallya has quit IRC | 15:33 | |
mordred | stevemar: zomg. we have to pass the string 'True' ? | 15:40 |
mordred | Shrews: ^^ you know how you love interacting with glance api? | 15:40 |
dtroyer | Image v2 FTW! | 15:40 |
dtroyer | I have a feeling that'll be the first convert to the SDK when that time comes… | 15:41 |
Shrews | mordred: oh, let me count the ways... | 15:42 |
Shrews | fwiw, i did not get past zero | 15:43 |
dtroyer | Shrews: that could also be interpreted as not going negative… | 15:44 |
stevemar | mordred: this has definitely been a learning experience for me | 15:45 |
*** Qiming has quit IRC | 15:46 | |
mordred | stevemar: check me here - from reading the glanceclient schema | 15:49 |
mordred | there is no such thing as is_public | 15:49 |
mordred | there is "visibility" which is an enum that can be public or private | 15:50 |
mordred | stevemar: https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v2/image_schema.py#L173-L180 | 15:51 |
stevemar | mordred: yep, thats what stuart wrote to you :) | 15:51 |
*** stevemar has quit IRC | 15:51 | |
mordred | oh - hrm. I'm bad at reading | 15:51 |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient: Add image create support for image v2 https://review.openstack.org/225443 | 15:57 |
*** stevemar has joined #openstack-sdks | 15:57 | |
*** stevemar has quit IRC | 16:02 | |
openstackgerrit | Merged stackforge/python-openstacksdk: Updated from global requirements https://review.openstack.org/224699 | 16:04 |
*** steveortiz is now known as zz_steveortiz | 16:07 | |
*** zz_steveortiz is now known as steveortiz | 16:20 | |
*** stevemar has joined #openstack-sdks | 16:37 | |
*** e0ne has quit IRC | 16:41 | |
openstackgerrit | Merged stackforge/python-openstacksdk: Change ignore-errors to ignore_errors https://review.openstack.org/225895 | 16:42 |
*** chlong has quit IRC | 16:50 | |
*** chlong has joined #openstack-sdks | 17:02 | |
*** jamespd has quit IRC | 17:03 | |
*** jamespd has joined #openstack-sdks | 17:04 | |
openstackgerrit | Merged openstack/keystoneauth: Change ignore-errors to ignore_errors https://review.openstack.org/225740 | 17:16 |
*** e0ne has joined #openstack-sdks | 17:24 | |
*** hitalia has joined #openstack-sdks | 17:32 | |
*** subscope has joined #openstack-sdks | 17:37 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient: Add image create support for image v2 https://review.openstack.org/225443 | 17:49 |
mordred | stevemar: ^^ sorry to bother you - the patch is now updated per reviews (and the latest versions passes tests too) | 17:51 |
stevemar | mordred: oh nice, i was just going to pull it down and fix it myself :P | 17:53 |
stevemar | mordred: yeah, i wasn't sure about ignoring the options, but wanted to throw that out there as an option | 17:53 |
stevemar | dtroyer: ^^^ | 17:53 |
mordred | stevemar: I think also, like the ones with missing functionality, we could certainly do that as a follow on patch non-destructively | 17:54 |
mordred | you know, if we don't put the hidden optoins in now, and we hate it, we can always add them | 17:54 |
mordred | but as soon as we add them even hidden, we can't remove them | 17:54 |
stevemar | mordred: minor doc stuff dude, sorry | 17:57 |
dtroyer | my worry without the compat options is that changing the default from v1 to v2 will break folks immediately. maybe we need to take that hit eventually anyway, is this the right time? | 17:57 |
* mordred cries | 17:57 | |
mordred | no worries | 17:57 |
mordred | dtroyer: I think it's a real break because v2 just doesn't do several of those things - I personally worry more about accepting theoption and silently ignoring it | 17:58 |
mordred | dtroyer: maybe a half-way thing - like - put in th esilent options but then test for them and throw an informative error message if someone tries to use them? | 17:59 |
mordred | dtroyer: like "you tried to use --store, but you are talking ot glance v2 which no longer supports that function" | 17:59 |
mordred | since they cannot avoid being broken - but at least this way they'll know what's up | 18:00 |
dtroyer | hmmm…. I like that idea. it's more work but like handling a deprecation thats out of our control | 18:00 |
mordred | yeah | 18:00 |
mordred | I can code that up and put it in the next rev | 18:00 |
dtroyer | sounds good. I should be in a place to go over your first review soon... | 18:00 |
mordred | cool | 18:00 |
dtroyer | it's see-the-surgeon day ;) | 18:01 |
mordred | dtroyer: also - ignore most of my devstack patches for now - if we can land this change to openstackclient most of them are not needed | 18:01 |
mordred | ooh! fun.surgeons | 18:01 |
stevemar | dtroyer: ouch | 18:01 |
mordred | dtroyer: I hear surgery is fun and everyone should do it whenever they can ... | 18:01 |
dtroyer | this is good though…all good news, I'm pain-free and the fusion is going well | 18:01 |
mordred | woot! | 18:01 |
stevemar | fusion eh | 18:02 |
dtroyer | yup, L5-S1 | 18:02 |
stevemar | dtroyer: you gonna be afk a while? or just an afternoon thing? | 18:02 |
dtroyer | actually, I'll be back at kbd after I grab some lunch, it was this morning | 18:03 |
mordred | dtroyer, stevemar: what's the right way to raise that error? | 18:10 |
mordred | exceptions.CommandError ? | 18:10 |
openstackgerrit | Merged openstack/python-openstackclient: Change ignore-errors to ignore_errors https://review.openstack.org/225823 | 18:11 |
*** trown is now known as trown|lunch | 18:15 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient: Add image create support for image v2 https://review.openstack.org/225443 | 18:19 |
mordred | stevemar, dtroyer: there ya go | 18:19 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Add image create support for image v2 https://review.openstack.org/225443 | 18:51 |
stevemar | mordred: minor tweaks ^ review if you can | 18:51 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Format an images properties and tags https://review.openstack.org/225505 | 18:53 |
*** steveortiz is now known as zz_steveortiz | 18:58 | |
mordred | stevemar: looks great - now we just need the dtroyer stamp of approval | 19:07 |
mordred | stevemar: and we may have accomplished v2 image support | 19:08 |
mordred | 'support' | 19:08 |
stevemar | \o/ | 19:08 |
stevemar | well for create anyway... | 19:08 |
stevemar | sigh, --long doesn't work for list | 19:09 |
*** trown|lunch is now known as trown | 19:10 | |
mordred | with your properties patch? | 19:11 |
stevemar | mordred: pretty sure with master | 19:12 |
stevemar | since my patch didn't touch the list function | 19:12 |
stevemar | just create and show | 19:12 |
stevemar | okay, relatively easy fix, just someone used format_dict instead of format_list for the tags | 19:13 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Use format_list instead of format_dict when listing images https://review.openstack.org/225994 | 19:18 |
stevemar | mordred: terrylhowe dtroyer ^ | 19:21 |
mordred | stevemar: +1 | 19:22 |
dtroyer | so at long last image create v2 | 19:28 |
dtroyer | thanks guys | 19:29 |
*** hitalia has quit IRC | 19:36 | |
stevemar | dtroyer: oh shittttt you +A'ed | 19:40 |
stevemar | mordred: is the glance team going to make v3 of the API any time soon? | 19:41 |
stevemar | i thought i read that somewhere | 19:41 |
dtroyer | so, y'all say its good, eh? | 19:41 |
dtroyer | I've seen rumblings to the effect that any fixing to v2 will be a v3 | 19:42 |
dtroyer | but nothing confirmable | 19:42 |
mordred | stevemar: yes | 19:42 |
mordred | :) | 19:42 |
mordred | no - I have no clue | 19:42 |
stevemar | dtroyer: yes, its bueno | 19:42 |
dtroyer | and here I was sooooo haoy to finally have that ;) | 19:43 |
stevemar | mordred: so since you have super TC power, can we draw a line in the sand and say no more CLI stuff into glancelcient :) | 19:43 |
stevemar | or i guess that has to come from glance team :( | 19:43 |
dtroyer | how about we focus on the SDK and dropping our dependence on glanceclient? | 19:43 |
stevemar | dtroyer: that's still paramount | 19:44 |
dtroyer | that'll clean up some dependencies I'd love to be free of | 19:44 |
stevemar | but it would be nice to not have duplicated work | 19:44 |
dtroyer | that's a pipe dream | 19:44 |
stevemar | dtroyer: is it? | 19:44 |
stevemar | dtroyer: we're like 90% parity with cinder | 19:44 |
stevemar | and not far off with glance | 19:44 |
mordred | I think flaper would totally be on board with ditching the glanceclient shell thing | 19:45 |
stevemar | mordred: true that, flaper already used OSC for zaqar | 19:45 |
mordred | I don't know I can force anything with magic TC powers - but I think they'd be happy to join voluntarily | 19:45 |
stevemar | even better! | 19:45 |
dtroyer | stevemar: so I read that as glanceclient vs SDK duplication, not CLI duplication which now I see you might have meant | 19:46 |
stevemar | dtroyer: ++ | 19:46 |
stevemar | dtroyer: thanks for reading my mind | 19:46 |
dtroyer | my brain may now be narc-free but it's still a wee bit slowish | 19:46 |
stevemar | dtroyer: while i have you around... https://review.openstack.org/#/c/225956/ | 19:47 |
stevemar | any idea why it's failing jenkins? apparently saharaclient can't be installed properly now | 19:48 |
dtroyer | looks like at some point it's being installed from pip, which in a saharaclient functional test I'd not expect to see | 19:51 |
stevemar | gah | 19:54 |
*** hitalia has joined #openstack-sdks | 19:59 | |
*** e0ne has quit IRC | 19:59 | |
*** e0ne has joined #openstack-sdks | 20:00 | |
openstackgerrit | Steve Martinelli proposed openstack/keystoneauth: add openid connect plugins https://review.openstack.org/224993 | 20:11 |
stevemar | glance makes me so sad | 20:20 |
stevemar | mordred: does glance not support delete image by name? | 20:21 |
stevemar | dtroyer: ^ ? | 20:21 |
dtroyer | IIRC I never tried, always used find_resource() to get the ID | 20:21 |
mordred | stevemar: I do the same thing in shade | 20:21 |
mordred | stevemar: get id, then delete by ID | 20:22 |
stevemar | mordred: how do you "get the id"? | 20:22 |
stevemar | i was thinking it would fail if i called something that had name conflicts | 20:23 |
mordred | given a name_or_id param, we fetch the list of images then return one if name_or_id matches image['name'] or image['id'] | 20:23 |
stevemar | blah | 20:23 |
mordred | although, if you're doing get | 20:23 |
mordred | we'll throw an error if you get two matches | 20:23 |
stevemar | image delete <name> is failing, which probably means <show> fails too | 20:23 |
mordred | stevemar: https://github.com/openstack-infra/shade/blob/master/shade/_utils.py#L42-L118 are the pattern functoins | 20:24 |
mordred | stevemar: (we do this for all openstack resources) | 20:24 |
stevemar | mordred: we have a similar gizmo: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/common/utils.py#L52-L121 | 20:25 |
mordred | yup | 20:28 |
mordred | looks similar to me :) | 20:28 |
*** e0ne has quit IRC | 20:29 | |
*** etoews has joined #openstack-sdks | 21:03 | |
*** trown is now known as trown|outttypeww | 21:05 | |
*** andrewbogott has joined #openstack-sdks | 21:07 | |
*** stevemar has quit IRC | 21:19 | |
*** andrewbogott has left #openstack-sdks | 21:20 | |
*** stevemar has joined #openstack-sdks | 21:20 | |
*** stevemar has quit IRC | 21:24 | |
openstackgerrit | Xav Paice proposed openstack/os-client-config: Add support for Catalyst as vendor https://review.openstack.org/226056 | 21:25 |
*** bnemec has quit IRC | 21:27 | |
mordred | oh! neat! | 21:30 |
openstackgerrit | Merged openstack/python-openstackclient: Add image create support for image v2 https://review.openstack.org/225443 | 21:35 |
*** bnemec has joined #openstack-sdks | 21:41 | |
mordred | WOOT! | 21:46 |
openstackgerrit | Merged openstack/python-openstackclient: Format an images properties and tags https://review.openstack.org/225505 | 21:54 |
openstackgerrit | Merged openstack/python-openstackclient: Use format_list instead of format_dict when listing images https://review.openstack.org/225994 | 21:54 |
*** thrash is now known as thrash|g0ne | 22:14 | |
*** jose4183 has quit IRC | 22:16 | |
*** stevemar has joined #openstack-sdks | 22:16 | |
*** stevemar has quit IRC | 22:20 | |
*** gildub has joined #openstack-sdks | 22:22 | |
*** pratikma_ has quit IRC | 22:24 | |
openstackgerrit | Merged openstack/python-openstackclient: Imported Translations from Zanata https://review.openstack.org/225393 | 22:39 |
*** pratikmallya has joined #openstack-sdks | 22:57 | |
*** jamielennox|away is now known as jamielennox | 23:23 | |
*** gildub has quit IRC | 23:23 | |
*** hitalia has quit IRC | 23:26 | |
*** Qiming has joined #openstack-sdks | 23:36 | |
*** pratikmallya has quit IRC | 23:55 | |
*** gildub has joined #openstack-sdks | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!