| *** stevemar has joined #openstack-sdks | 00:05 | |
| *** stevemar has quit IRC | 00:18 | |
| *** stevemar has joined #openstack-sdks | 00:18 | |
| *** stevemar has quit IRC | 00:22 | |
| *** stevemar has joined #openstack-sdks | 02:42 | |
| *** pratikmallya has joined #openstack-sdks | 03:17 | |
| *** pratikmallya has quit IRC | 03:22 | |
| *** boris-42 has joined #openstack-sdks | 03:48 | |
| *** pratikmallya has joined #openstack-sdks | 04:14 | |
| *** pratikmallya has quit IRC | 04:15 | |
| *** pratikma_ has joined #openstack-sdks | 04:15 | |
| *** woodster_ has quit IRC | 04:49 | |
| *** Qiming has joined #openstack-sdks | 05:01 | |
| *** stevemar has quit IRC | 05:04 | |
| *** pratikma_ has quit IRC | 05:12 | |
| *** pratikmallya has joined #openstack-sdks | 05:26 | |
| *** pratikmallya has quit IRC | 05:30 | |
| *** pratikmallya has joined #openstack-sdks | 05:55 | |
| *** pratikmallya has quit IRC | 06:42 | |
| *** pratikmallya has joined #openstack-sdks | 06:51 | |
| *** pratikmallya has quit IRC | 06:54 | |
| *** pratikmallya has joined #openstack-sdks | 06:57 | |
| *** pratikmallya has quit IRC | 07:01 | |
| *** stevemar has joined #openstack-sdks | 07:04 | |
| *** stevemar has quit IRC | 07:09 | |
| *** stevemar has joined #openstack-sdks | 08:06 | |
| *** stevemar has quit IRC | 08:10 | |
| *** jamielennox|away is now known as jamielennox | 08:59 | |
| *** stevemar has joined #openstack-sdks | 10:06 | |
| *** stevemar has quit IRC | 10:11 | |
| *** boris-42 has quit IRC | 10:20 | |
| *** jamielennox is now known as jamielennox|away | 11:26 | |
| *** pratikmallya has joined #openstack-sdks | 11:46 | |
| *** stevemar has joined #openstack-sdks | 12:07 | |
| *** stevemar has quit IRC | 12:12 | |
| *** stevemar has joined #openstack-sdks | 14:08 | |
| *** stevemar has quit IRC | 14:12 | |
| *** pratikmallya has quit IRC | 14:55 | |
| *** pratikmallya has joined #openstack-sdks | 15:00 | |
| *** pratikmallya has quit IRC | 15:19 | |
| *** Qiming has quit IRC | 15:24 | |
| *** stevemar has joined #openstack-sdks | 15:42 | |
| stevemar | mordred: i think your image create patch is closer than the one thats been in the works | 15:45 |
|---|---|---|
| mordred | stevemar: k. I'll go pull the good bits from theirs | 15:45 |
| *** pratikmallya has joined #openstack-sdks | 15:46 | |
| stevemar | mordred: are you ever not available on irc :P | 15:46 |
| mordred | stevemar: also, you mentioned store and volume, and I don't see them in the v2 api | 15:46 |
| mordred | stevemar: nope :) | 15:46 |
| mordred | stevemar: irc bouncer + phone app == win | 15:47 |
| stevemar | mordred: hmm, those were in the v1 image create command, its cool if they are not in v2, let me look at the apis | 15:47 |
| mordred | I could very easily be wrong | 15:48 |
| stevemar | mordred: ah that's an osc-ism (to include volume and force) | 15:55 |
| stevemar | looks like we call cinder to find the volume specified, then call cinderclient.upload_to_image() | 15:55 |
| stevemar | https://github.com/openstack/python-openstackclient/blob/master/openstackclient/image/v1/image.py#L218-L230 | 15:55 |
| stevemar | we can ignore that one for now | 15:55 |
| stevemar | is also looks like they removed the 'store' option in v2? | 15:57 |
| mordred | nod | 15:57 |
| stevemar | so the delta between v1 and v2 is -store and +tags | 16:01 |
| stevemar | i have a massive TODO for the summit to get glance and cinder buy-in for osc - we're so close on those two that it's silly to iterate on 2 things | 16:02 |
| *** pratikmallya has quit IRC | 16:05 | |
| *** pratikmallya has joined #openstack-sdks | 16:10 | |
| *** pratikmallya has quit IRC | 16:15 | |
| mordred | stevemar: so, do you think we should do tags like properties? | 16:43 |
| stevemar | mordred: we could do that in another patch tbh | 16:52 |
| stevemar | but yes, like properties, but without k=v pairs, just keys | 16:52 |
| mordred | ++ | 16:55 |
| mordred | stevemar: there is some good code in the other change - I'm pulling their good stuff into mine | 17:02 |
| mordred | stevemar: I'll add them both to co-authored-by | 17:02 |
| stevemar | mordred: cool cool | 17:02 |
| stevemar | mordred: just don't change the args, or face the wrath of dtroyer | 17:02 |
| mordred | stevemar: oh dear god no | 17:07 |
| mordred | stevemar: https://review.openstack.org/#/c/225443/ | 17:32 |
| stevemar | mordred: ewww properties are flattened into kwargs? | 17:36 |
| stevemar | why ... | 17:36 |
| mordred | stevemar: I have stopped asking such questions so long ago | 17:49 |
| stevemar | mordred: sillly q about the patch | 17:50 |
| stevemar | i had a comment about calling update | 17:50 |
| stevemar | you replied with why its needed | 17:50 |
| mordred | stevemar: the answer is "because bunny rabbits hate you" | 17:50 |
| stevemar | then changed update to get | 17:50 |
| mordred | stevemar: I did- then I learned about upload | 17:50 |
| * stevemar goes to learn about upload | 17:51 | |
| mordred | glanceclient/v2/images.py | 17:51 |
| mordred | line 203 | 17:51 |
| stevemar | hmm, there now | 17:52 |
| mordred | stevemar: oh! and in fact, if I'd cargo-culted code from shade properly | 17:52 |
| mordred | stevemar: I would have seen that the v2 version of image_upload_put does, indeed, use upload | 17:53 |
| mordred | at least this is code to support put and not task-create | 17:55 |
| stevemar | mordred: hmm so .create() doesn't actually upload it yet, thats interesting | 17:59 |
| stevemar | and v1 doesn't have upload | 18:00 |
| stevemar | neat | 18:00 |
| stevemar | i like that separation | 18:00 |
| mordred | yeah. honestly, I think it makes it clearer what's going on | 18:03 |
| stevemar | mordred: oh thats weird as balls - the image returned from glanceclient contains a schema with it, and you can't change the returned object if it violates the schema | 18:45 |
| mordred | stevemar: yes. the glancev2 client is ... | 18:52 |
| mordred | stevemar: well, it is very different than the rest of anything in openstack | 18:53 |
| mordred | because warlock | 18:53 |
| mordred | stevemar: https://github.com/openstack-infra/shade/blob/master/shade/meta.py#L333-L348 | 18:54 |
| mordred | stevemar: we had to special case it | 18:54 |
| stevemar | yep, warlock seems to be the cause | 19:05 |
| stevemar | i wanted to format stuff and things, but i can do that in another patch | 19:05 |
| mordred | stevemar: I'm hitting recheck on the "remove the workaround" patch | 19:06 |
| stevemar | mordred: i will have another patch to format the properties and tags into how we normally show them | 19:06 |
| mordred | stevemar: oh, awesome1 | 19:07 |
| stevemar | mordred: maybe 3 minor changes to your patch, then +2 | 19:08 |
| mordred | woot | 19:08 |
| mordred | stevemar: you're teasing me. I see no changes listed? | 19:09 |
| mordred | stevemar: ah I understand now | 19:14 |
| stevemar | mordred: now we wait for dtroyer's final stamp of approval | 19:17 |
| stevemar | hmm, what happened to the bot, not notification for osc changes | 19:45 |
| stevemar | mordred: https://review.openstack.org/#/c/225505/ | 19:46 |
| mordred | stevemar: the bot is having a sad today | 19:54 |
| mordred | stevemar: looks great | 19:55 |
| *** e0ne has joined #openstack-sdks | 20:08 | |
| *** karimb has joined #openstack-sdks | 20:12 | |
| *** e0ne has quit IRC | 20:16 | |
| *** e0ne has joined #openstack-sdks | 20:19 | |
| *** e0ne has quit IRC | 20:24 | |
| mordred | stevemar: your update had a testing sad | 20:25 |
| stevemar | mordred: yeah, apparently fakereources don't like iterkeys | 20:25 |
| mordred | stevemar: many times I feel like I spend more time coding to the fakes than actually solving the problem | 20:26 |
| stevemar | yup | 20:26 |
| stevemar | thats why i like funtional tests for this sort of stuff | 20:26 |
| *** karimb has quit IRC | 20:27 | |
| mordred | yup | 20:27 |
| *** e0ne has joined #openstack-sdks | 20:29 | |
| *** karimb has joined #openstack-sdks | 20:29 | |
| *** e0ne has quit IRC | 20:36 | |
| *** e0ne has joined #openstack-sdks | 20:40 | |
| *** e0ne has quit IRC | 20:42 | |
| *** e0ne has joined #openstack-sdks | 20:46 | |
| *** karimb has quit IRC | 20:46 | |
| *** e0ne has quit IRC | 20:50 | |
| *** pratikmallya has joined #openstack-sdks | 20:57 | |
| *** e0ne has joined #openstack-sdks | 21:02 | |
| *** e0ne has quit IRC | 21:03 | |
| *** subscope has quit IRC | 21:11 | |
| *** boris-42 has joined #openstack-sdks | 21:53 | |
| *** stevemar has quit IRC | 22:43 | |
| *** chlong has quit IRC | 22:52 | |
| *** pratikmallya has quit IRC | 22:53 | |
| mordred | aw. I just missed stevemar | 22:59 |
| *** Shrews has quit IRC | 23:01 | |
| *** jamielennox|away is now known as jamielennox | 23:19 | |
| *** Shrews has joined #openstack-sdks | 23:19 | |
| *** Shrews has quit IRC | 23:22 | |
| *** Shrews has joined #openstack-sdks | 23:22 | |
| *** openstackgerrit has joined #openstack-sdks | 23:26 | |
| *** openstackgerrit has quit IRC | 23:31 | |
| *** stevemar has joined #openstack-sdks | 23:38 | |
| *** stevemar has quit IRC | 23:43 | |
| *** Qiming has joined #openstack-sdks | 23:46 | |
| *** openstackgerrit has joined #openstack-sdks | 23:47 | |
| *** openstackgerrit has quit IRC | 23:48 | |
| *** openstackgerrit has joined #openstack-sdks | 23:49 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!