*** adi______ has joined #openstack-powervm | 00:03 | |
*** edmondsw has joined #openstack-powervm | 00:09 | |
*** adreznec_ has joined #openstack-powervm | 00:11 | |
*** adi_____ has quit IRC | 00:12 | |
*** adreznec has quit IRC | 00:12 | |
*** ChanServ has quit IRC | 00:12 | |
*** adi______ is now known as adi_____ | 00:12 | |
*** adreznec_ is now known as adreznec | 00:12 | |
*** edmondsw has quit IRC | 00:13 | |
*** ChanServ has joined #openstack-powervm | 00:13 | |
*** barjavel.freenode.net sets mode: +o ChanServ | 00:13 | |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Bump pypowervm minimum to 1.1.13 https://review.openstack.org/557854 | 00:21 |
---|---|---|
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Set volume ID as dev tag when mapping VSCSI vols https://review.openstack.org/552172 | 00:23 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Add affinity score check attribute to flavor https://review.openstack.org/555309 | 00:23 |
efried | edmondsw Bumped pypowervm minimum (we have to do that manually now) and rebased the two that were waiting on top of it. | 00:24 |
*** esberglu has joined #openstack-powervm | 00:35 | |
*** esberglu has quit IRC | 00:40 | |
*** adreznec has quit IRC | 01:30 | |
*** adreznec has joined #openstack-powervm | 01:33 | |
*** edmondsw has joined #openstack-powervm | 01:57 | |
*** edmondsw has quit IRC | 02:01 | |
*** AlexeyAbashkin has joined #openstack-powervm | 02:07 | |
*** AlexeyAbashkin has quit IRC | 02:11 | |
*** chhagarw has joined #openstack-powervm | 02:55 | |
*** chhagarw has quit IRC | 03:00 | |
*** AlexeyAbashkin has joined #openstack-powervm | 03:08 | |
*** AlexeyAbashkin has quit IRC | 03:12 | |
*** edmondsw has joined #openstack-powervm | 03:45 | |
*** edmondsw has quit IRC | 03:50 | |
*** chhagarw has joined #openstack-powervm | 04:17 | |
*** edmondsw has joined #openstack-powervm | 07:21 | |
*** edmondsw has quit IRC | 07:25 | |
*** AlexeyAbashkin has joined #openstack-powervm | 07:59 | |
*** edmondsw has joined #openstack-powervm | 09:10 | |
*** edmondsw has quit IRC | 09:14 | |
*** esberglu has joined #openstack-powervm | 09:24 | |
*** k0da has joined #openstack-powervm | 09:26 | |
*** esberglu has quit IRC | 09:29 | |
*** AlexeyAbashkin has quit IRC | 10:30 | |
*** AlexeyAbashkin has joined #openstack-powervm | 10:43 | |
*** chhagarw has quit IRC | 10:51 | |
*** edmondsw has joined #openstack-powervm | 12:41 | |
edmondsw | efried I see noticed tox failed on https://review.openstack.org/#/c/557854/ ... have you been looking at that? figured anything out or should I start digging? | 12:57 |
efried | I haven't dug yet, noticed right before I signed off last night. | 12:57 |
efried | edmondsw: It looks like we may have scrood the pooch on backward compat. | 12:58 |
efried | edmondsw: BUT hopefully just for test/mock, not for prod code paths. | 12:58 |
edmondsw | yeah I'm hoping this is just a mock thing | 12:58 |
efried | anyway, feel free to hit it, and let me know if you need help. | 12:59 |
edmondsw | ok digging | 12:59 |
efried | thanks | 12:59 |
*** efried is now known as fried_bunny | 13:10 | |
*** esberglu has joined #openstack-powervm | 13:34 | |
*** arunman has joined #openstack-powervm | 13:47 | |
*** tjakobs has joined #openstack-powervm | 13:54 | |
*** tjakobs has quit IRC | 13:59 | |
esberglu | Taking PowerVM CI down for system upgrades, should be back up by EOD | 13:59 |
*** tjakobs has joined #openstack-powervm | 14:01 | |
edmondsw | esberglu ack | 14:02 |
*** arunman has quit IRC | 14:03 | |
*** arunman has joined #openstack-powervm | 14:08 | |
fried_bunny | edmondsw: word? | 14:22 |
edmondsw | fried_bunny broke with 1.1.12, not 1.1.13, but haven't figured out why yet | 14:23 |
fried_bunny | ight | 14:23 |
*** arunman has quit IRC | 14:47 | |
edmondsw | fried_bunny so I think I have good news | 14:53 |
edmondsw | I'm able to avoid the problem is I add something like this to the failing tests: | 14:54 |
edmondsw | self.vio_wrap.uuid = '47' | 14:54 |
edmondsw | I tried this because I noticed that it was hitting a KeyError like this: | 14:54 |
edmondsw | KeyError: "wrapper_AutospecMock name='mock.uuid' id='139908444233872'>" | 14:54 |
edmondsw | when I think there should be a "<" before "Autospec" there | 14:55 |
edmondsw | since the actual uuid from the mock is <AutospecMock name='mock.uuid' id='139908444233872'> | 14:55 |
edmondsw | but I have no idea what changed that led to this | 14:55 |
fried_bunny | nod | 14:58 |
fried_bunny | Gotta take a kid to the airport, be back in 20. | 14:58 |
edmondsw | I should clarify that setting the uuid on the mock fixed 3 of the 6 failing tests (the ones in test_ssp.py) | 15:29 |
edmondsw | I'm not sure how to do similar on the other 3, and don't really know that it's necessary since we should really figure out why we're losing that '<' and address that... | 15:30 |
edmondsw | and I'm not sure how to approach that... | 15:30 |
edmondsw | I've looked through all the commits that went into 1.1.12 and I'm not seeing anything that should have caused this | 15:30 |
edmondsw | fried_bunny want to take a stab at it when you get back? | 15:30 |
fried_bunny | Okay, can do. | 15:31 |
openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: WIP: Having iSCSI Initiator locks per VIOS https://review.openstack.org/557800 | 15:33 |
fried_bunny | edmondsw: The problem doesn't seem to be with pypowervm. I put 1.1.13 in my old test env and things are passing. I suspect when I rebuild my env to pick up newer libs etc., that's when it'll break. | 15:49 |
edmondsw | hm interesting | 15:49 |
edmondsw | I didn't try just pypowervm, I did a tox recreate | 15:49 |
edmondsw | makes sense | 15:50 |
fried_bunny | Can you pastebin me the dump of the lib versions you're seeing in your sandbox? | 15:51 |
fried_bunny | edmondsw: (that big block that prints out first thing when you run tox) | 15:52 |
edmondsw | I think it only prints that when you recreate... kicked one off | 15:56 |
edmondsw | fried_bunny http://paste.openstack.org/show/718029/ | 15:58 |
fried_bunny | I think it prints it every time, cause mine printed and I didn't recreate. Thanks. | 15:58 |
edmondsw | actually shows using 1.1.13, even though I only bumped requirements to 1.1.12... I guess because u-c | 15:58 |
edmondsw | maybe it prints it every time if you run the whole suite | 15:59 |
edmondsw | rather than a specific test | 15:59 |
edmondsw | yeah, that seems to be the case | 15:59 |
edmondsw | fried_bunny I think some autospec changes have merged in nova recently, so it could also be from that and not pypi | 16:01 |
fried_bunny | that could be the case. I think I can test that pretty easily... | 16:01 |
edmondsw | question is why zuul only started failing when we bump pypowervm, though... | 16:02 |
edmondsw | is it failing for other nova-powervm commits? | 16:03 |
fried_bunny | easy to find out. | 16:05 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: DNM: Testing zuul https://review.openstack.org/557956 | 16:06 |
fried_bunny | edmondsw: ^ | 16:06 |
fried_bunny | edmondsw: Yup, updating nova did the trick. | 16:10 |
fried_bunny | When's the last time we had a patch pass, so we can narrow the field some? | 16:10 |
edmondsw | not sure | 16:11 |
edmondsw | fried_bunny this wasn't long ago: https://review.openstack.org/#/c/556495/ | 16:11 |
fried_bunny | looking... | 16:12 |
edmondsw | as in, zuul passed there | 16:13 |
edmondsw | Mar 26 8:20 AM | 16:13 |
fried_bunny | edmondsw: Bet it was https://review.openstack.org/#/c/447505/ | 16:16 |
fried_bunny | trying... | 16:16 |
fried_bunny | edmondsw: Yup. | 16:18 |
fried_bunny | Reverting that patch fixes us. | 16:18 |
edmondsw | cool | 16:19 |
fried_bunny | well, except for the part where we're broken until a nova patch happens. | 16:20 |
fried_bunny | will have to dig further into the why. | 16:20 |
fried_bunny | bbiab... | 16:20 |
*** AlexeyAbashkin has quit IRC | 16:31 | |
fried_bunny | edmondsw: We may have to dup this OOT: https://review.openstack.org/#/c/447505/44/nova/tests/unit/virt/powervm/disk/test_ssp.py | 17:00 |
edmondsw | fried_bunny yep. I don't think that would be the issue, though, right? | 17:01 |
fried_bunny | edmondsw: Only for the one failure; trying... | 17:01 |
edmondsw | I thought that was just an improvement, not necessary | 17:01 |
fried_bunny | hm, that code isn't in our OOT version. | 17:02 |
fried_bunny | edmondsw: Are you following this? | 17:38 |
fried_bunny | (in -nova) | 17:39 |
fried_bunny | esberglu: Still no depends-on from nova-powervm, right? | 17:40 |
fried_bunny | Do we have a way to hand-patch something in from a lib, like oslotest? | 17:40 |
edmondsw | sorry, was afk | 17:48 |
edmondsw | catching up | 17:48 |
openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: WIP: Having iSCSI Initiator locks per VIOS https://review.openstack.org/557800 | 17:49 |
fried_bunny | edmondsw: Can we tolerate being broken for a week? | 17:49 |
edmondsw | a whole week? | 17:49 |
*** AlexeyAbashkin has joined #openstack-powervm | 17:49 | |
fried_bunny | edmondsw: Probably at least. oslotest patch needs to merge; then they need to ask for a release; then it needs to get through requirements. | 17:52 |
*** AlexeyAbashkin has quit IRC | 17:53 | |
edmondsw | fried_bunny I guess we'll have to | 17:57 |
fried_bunny | edmondsw: Actually I may be able to fix it on our side. I think I found those UUIDs. | 17:57 |
edmondsw | the 3 in ssp.py could be fixed easily enough with one line in setup | 17:58 |
edmondsw | but the other 3 in driver.py are harder | 17:58 |
esberglu | fried_bunny: Depends-on should work for zuul | 17:58 |
esberglu | Not for powervm ci | 17:58 |
edmondsw | ahh... interesting distinction | 17:58 |
fried_bunny | edmondsw: I got the driver.py ones. | 17:58 |
fried_bunny | working the ssp ones now. | 17:58 |
fried_bunny | esberglu, edmondsw: Well, this doesn't break real code, just unit tests. So we can depends-on and it'll affect tox for us? | 17:59 |
edmondsw | just add something like this around line 84 of test_ssp.py: self.vio_wrap.uuid = '47' | 17:59 |
edmondsw | maybe want to give a full uuid | 17:59 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: DNM: Testing zuul https://review.openstack.org/557956 | 17:59 |
fried_bunny | trying ^ | 18:00 |
esberglu | fried_bunny: I think so, not 100% | 18:00 |
fried_bunny | Okay, got 'em fixed. Proposing in a sec... | 18:02 |
*** AlexeyAbashkin has joined #openstack-powervm | 18:06 | |
*** AlexeyAbashkin has quit IRC | 18:10 | |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Specify UUIDs in VIOS mocks for FeedTasks https://review.openstack.org/557975 | 18:13 |
fried_bunny | edmondsw, esberglu: ^ | 18:13 |
edmondsw | fried_bunny excellent... thanks | 18:14 |
fried_bunny | esberglu: Does this help us figure out how to get Depends-On working? https://review.openstack.org/#/c/342211/14/.zuul.yaml | 18:15 |
openstackgerrit | Claudiu Belu proposed openstack/nova-powervm master: mock: Temporarely disables the mock autospec fixture https://review.openstack.org/557976 | 18:18 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Bump pypowervm minimum to 1.1.13 https://review.openstack.org/557854 | 18:20 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Add affinity score check attribute to flavor https://review.openstack.org/555309 | 18:20 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Set volume ID as dev tag when mapping VSCSI vols https://review.openstack.org/552172 | 18:20 |
fried_bunny | edmondsw, esberglu: Rebases ^ | 18:21 |
fried_bunny | esberglu: Looks like that Depends-On didn't work: https://review.openstack.org/#/c/557956/ | 18:21 |
edmondsw | fried_bunny how would that zuul yaml help with depends-on? | 18:23 |
esberglu | fried_bunny: It might not for tox | 18:23 |
esberglu | Since it's using specific versions for the reqs | 18:23 |
esberglu | But upstream zuul definitely supports depends on | 18:24 |
fried_bunny | edmondsw: No idea; I don't speak zuul or yaml - but Claudiu pointed me to that and I thought it might help us understand what we would need to do in nova-powervm to get things working. | 18:29 |
edmondsw | would be really nice to get depends-on working | 18:33 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Introduce (empty) lower-constraints.txt https://review.openstack.org/557982 | 18:39 |
fried_bunny | sigh, the hits they just keep on a-coming. | 18:41 |
openstackgerrit | Merged openstack/nova-powervm master: Specify UUIDs in VIOS mocks for FeedTasks https://review.openstack.org/557975 | 18:49 |
openstackgerrit | Claudiu Belu proposed openstack/nova-powervm master: mock: Temporarely disables the mock autospec fixture https://review.openstack.org/557976 | 18:55 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Introduce (empty) lower_constraints.txt https://review.openstack.org/557982 | 18:55 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Introduce (empty) lower_constraints.txt https://review.openstack.org/557982 | 18:56 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Bump pypowervm minimum to 1.1.13 https://review.openstack.org/557854 | 18:56 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Add affinity score check attribute to flavor https://review.openstack.org/555309 | 18:56 |
openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Set volume ID as dev tag when mapping VSCSI vols https://review.openstack.org/552172 | 18:56 |
fried_bunny | rebases more ^ | 18:57 |
edmondsw | esberglu quick look at https://review.openstack.org/#/c/557982 ? | 19:18 |
edmondsw | fried_bunny seems like we've still got a problem with lower_constraints if you look at the next in the series | 19:20 |
fried_bunny | that's weird | 19:20 |
edmondsw | yeah... | 19:21 |
fried_bunny | well, the lower_constraints patch didn't run the requirements check job. | 19:21 |
fried_bunny | from what I can tell. | 19:21 |
edmondsw | yep, was just gonna say that | 19:21 |
edmondsw | I guess that only triggers when you change requirements | 19:22 |
fried_bunny | but it ran on the previous patch set | 19:22 |
fried_bunny | which is also weird. | 19:22 |
fried_bunny | the one where I misnamed it. | 19:22 |
edmondsw | of which commit? | 19:22 |
edmondsw | oh, I see it | 19:23 |
edmondsw | weird | 19:23 |
* fried_bunny checks the script in the requirements project... | 19:23 | |
edmondsw | looks like it needs - not _ | 19:27 |
fried_bunny | wait, wtf, is it called lower_constraints or lower-constraints? That first patch set I used - and it bounced, with the error message complaining it wants _. | 19:27 |
edmondsw | I think that may be a bug in openstack/requirements... dhellmann's commit names it lower-constraints.txt | 19:28 |
*** murb839 has joined #openstack-powervm | 19:29 | |
murb839 | .-. .-. | 19:29 |
murb839 | / \ / \ | 19:29 |
murb839 | | _ \ / _ | | 19:29 |
murb839 | ; | \ \ / / | ; | 19:29 |
murb839 | \ \ \ \_.._/ / / / | 19:29 |
murb839 | '. '.;' ';,' .' | 19:29 |
murb839 | './ _ _ \.' | 19:30 |
murb839 | .' a __ a '. | 19:30 |
murb839 | '--./ _, \/ ,_ \.--' | 19:30 |
murb839 | ----| \ /\ / |---- | 19:30 |
murb839 | .--'\ '-' '-' /'--. | 19:30 |
murb839 | _>.__ -- _.- `; | 19:30 |
murb839 | .' _ __/ _/ | 19:30 |
murb839 | / '.,:".-\ /:, | 19:30 |
murb839 | | \.' `""`'.\\ | 19:30 |
murb839 | '-,.__/ _ .-. ;|_ | 19:30 |
murb839 | /` `|| _/ `\/_ \_|| `\ | 19:30 |
murb839 | | ||/ \-./` \ / || | | 19:30 |
murb839 | \ ||__/__|___|__|| / | 19:30 |
murb839 | \_ |_Happy Easter_| / | 19:30 |
murb839 | jgs .' \ = _= _ = _= /`\ | 19:30 |
murb839 | / `-;----=--;--' \ | 19:31 |
murb839 | \ _.-' '. / | 19:31 |
murb839 | `""` `""` | 19:31 |
murb839 | L0DE AND CHRON FROM #LRH & L0DE RADIO HOUR (IRC.EFNET.ORG) WANTED TO SAY HAPPY EASTER!! | 19:31 |
murb839 | tjakobs esberglu edmondsw k0da adreznec adi_____ fried_bunny openstack openstackgerrit toan tonyb mdrabe AndyWojo openstackstatus catmando | 19:31 |
*** murb839 has quit IRC | 19:31 | |
edmondsw | fried_bunny fix proposed | 19:34 |
edmondsw | https://review.openstack.org/#/c/557927/ | 19:34 |
fried_bunny | edmondsw: Cool beans | 19:34 |
fried_bunny | It is unclear to me whether that'll mean we don't need that patch at all. | 19:37 |
edmondsw | fried_bunny why did you think that a lower-constraints.txt file is required now? | 19:37 |
fried_bunny | because I saw that error | 19:37 |
edmondsw | yeah, I don't think we should need the file | 19:37 |
edmondsw | https://github.com/openstack/requirements/commit/1e78c974263d70cd3a15bfba779c05ab60062ae2 | 19:37 |
fried_bunny | I didn't think so either, but KeyError lower-constraints.txt - what was a guy to think? | 19:37 |
edmondsw | If there is no lower-constraints.txt file the additional tests are skipped.” | 19:37 |
edmondsw | says that "If there is no lower-constraints.txt file the additional tests are skipped." | 19:38 |
fried_bunny | yuh | 19:38 |
fried_bunny | edmondsw: Fix is merging. | 19:38 |
fried_bunny | I'll rip that patch out. | 19:38 |
edmondsw | saw. cool | 19:38 |
edmondsw | fried_bunny so do you have to rebase again? | 19:39 |
fried_bunny | edmondsw: I don't think so; I think it's smart enough to rip it out once I abandon the predecessor. May need to recheck once the merge goes through. | 19:40 |
edmondsw | fried_bunny have you booked travel to the summit yet? | 19:40 |
edmondsw | I'm doing that now... looks like hotel will be Pan Pacific | 19:41 |
edmondsw | I'll be arriving late... can't fly out til Monday | 19:42 |
fried_bunny | edmondsw: Oh, shoot, no, I should do that. | 19:56 |
fried_bunny | esberglu: Is the CI still being worked? | 20:00 |
fried_bunny | oh, tomorrow, not today. So it's running? | 20:00 |
fried_bunny | oh, no, today, not tomorrow. So it's not running? | 20:00 |
fried_bunny | I'm gonna give up on nova-powervm for today. | 20:01 |
*** edmondsw has quit IRC | 20:17 | |
*** AlexeyAbashkin has joined #openstack-powervm | 21:05 | |
*** AlexeyAbashkin has quit IRC | 21:09 | |
esberglu | fried_bunny: Sorry was afk for a while | 21:13 |
esberglu | CI is almost done redeploying but then it has to get all the images ready and stuff | 21:13 |
esberglu | Should be back up in 2 hours or so | 21:14 |
esberglu | I can spam recheck on everything that needs it | 21:14 |
*** edmondsw has joined #openstack-powervm | 21:14 | |
fried_bunny | ight | 21:19 |
*** edmondsw has quit IRC | 21:19 | |
*** tjakobs has quit IRC | 21:45 | |
fried_bunny | esberglu: The pypowervm bump is (finally) passing tox. Once the CI gets going, please make sure it runs on | 21:58 |
fried_bunny | https://review.openstack.org/#/c/557854/ | 21:58 |
fried_bunny | https://review.openstack.org/#/c/555309/ | 21:58 |
fried_bunny | https://review.openstack.org/#/c/552172/ | 21:58 |
fried_bunny | and, if it passes, merge those bad boys. | 21:58 |
esberglu | fried_bunny: ack | 22:16 |
*** edmondsw has joined #openstack-powervm | 23:03 | |
*** edmondsw has quit IRC | 23:08 | |
*** k0da has quit IRC | 23:27 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!