*** AlexeyAbashkin has joined #openstack-powervm | 01:08 | |
*** AlexeyAbashkin has quit IRC | 01:13 | |
*** arunman has joined #openstack-powervm | 01:49 | |
*** arunman has quit IRC | 01:55 | |
*** AlexeyAbashkin has joined #openstack-powervm | 04:09 | |
*** AlexeyAbashkin has quit IRC | 04:14 | |
*** chhagarw has joined #openstack-powervm | 06:02 | |
*** k0da has joined #openstack-powervm | 07:26 | |
*** AlexeyAbashkin has joined #openstack-powervm | 08:00 | |
*** AlexeyAbashkin has quit IRC | 08:07 | |
*** AlexeyAbashkin has joined #openstack-powervm | 08:10 | |
*** Alexey_Abashkin has joined #openstack-powervm | 08:52 | |
*** AlexeyAbashkin has quit IRC | 08:54 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 08:54 | |
*** AlexeyAbashkin has quit IRC | 08:55 | |
*** AlexeyAbashkin has joined #openstack-powervm | 08:58 | |
*** k0da has quit IRC | 09:35 | |
*** AlexeyAbashkin has quit IRC | 10:53 | |
*** AlexeyAbashkin has joined #openstack-powervm | 11:18 | |
*** edmondsw has joined #openstack-powervm | 11:30 | |
edmondsw | efried bug in your test change on https://review.openstack.org/#/c/546813/ | 12:12 |
---|---|---|
edmondsw | you might want to let esberglu fix it so you're not committer and can +2 shortly | 12:12 |
efried | edmondsw: ack | 12:49 |
efried | edmondsw: It'll likely be middle of next week before I'm officially anointed. | 12:52 |
edmondsw | efried ack | 12:53 |
efried | edmondsw: So I can fix, or we can wait, up to you. | 12:57 |
efried | edmondsw: Or you can fix | 12:57 |
efried | that might actually work best. | 12:57 |
efried | at this point mriedem is ready to +2, so the in-house +1s are going to be less significant. | 12:58 |
*** edmondsw has quit IRC | 12:58 | |
*** edmondsw has joined #openstack-powervm | 12:59 | |
*** edmondsw has quit IRC | 13:03 | |
*** edmondsw has joined #openstack-powervm | 13:05 | |
edmondsw | efried I'll take a look. Not sure offhand how to pass an arg there but I can figure it out | 13:10 |
efried | edmondsw: I think you just have to change | 13:12 |
efried | mock_tf_run.side_effect = exception.InstanceNotFound | 13:12 |
efried | to | 13:12 |
efried | mock_tf_run.side_effect = exception.InstanceNotFound(...) | 13:12 |
edmondsw | yeah, I didn't think that would work, but just tried it and it did | 13:12 |
efried | Mock.side_effect accepts a class or an instance. | 13:12 |
edmondsw | review up | 13:13 |
*** efried has quit IRC | 13:24 | |
*** efried has joined #openstack-powervm | 13:25 | |
*** esberglu has joined #openstack-powervm | 13:28 | |
esberglu | edmondsw: efried: Reminder that CI will be down tomorrow for system upgrades | 13:29 |
edmondsw | esberglu ack | 13:29 |
efried | ack | 13:29 |
edmondsw | esberglu FYI http://lists.openstack.org/pipermail/openstack-dev/2018-March/128844.html | 13:31 |
edmondsw | I thought we used LIBS_FROM_GIT but I'm not seeing it so maybe not | 13:32 |
esberglu | edmondsw: I don't think that should affect us at all | 13:33 |
edmondsw | cool | 13:34 |
*** tjakobs has joined #openstack-powervm | 13:42 | |
*** k0da has joined #openstack-powervm | 13:42 | |
esberglu | efried: edmondsw: For a multinode devstack, can you have a compute and control on the same instance? | 15:52 |
esberglu | So 2 nodes, 1 control AND compute, 1 compute | 15:52 |
efried | yes | 15:52 |
edmondsw | yes | 15:52 |
esberglu | That's what I thought, just hadn't tried it | 15:52 |
esberglu | Thanks | 15:52 |
esberglu | edmondsw: efried: I'm thinking we get rid of our single node CI job completely | 16:21 |
esberglu | And just run multinode | 16:21 |
efried | wfm, why wouldn't we? | 16:21 |
esberglu | Exactly | 16:21 |
efried | if we had some single-node setups, we would have to not run multinode tests on 'em. | 16:21 |
edmondsw | that's what I had assumed | 16:21 |
*** k0da has quit IRC | 16:43 | |
esberglu | efried: edmondsw: 6433 for a real easy one | 16:45 |
*** AlexeyAbashkin has quit IRC | 16:53 | |
edmondsw | esberglu +1 for snapshot and I moved it to "ready for wider review". I'll let you add it to the runways queue | 17:39 |
esberglu | edmondsw: Awesome tx | 17:39 |
edmondsw | esberglu I guess you can add network hotplug to the runways queue as well | 17:42 |
*** tjakobs has quit IRC | 18:10 | |
*** k0da has joined #openstack-powervm | 18:12 | |
*** tjakobs has joined #openstack-powervm | 18:14 | |
*** AlexeyAbashkin has joined #openstack-powervm | 18:18 | |
*** AlexeyAbashkin has quit IRC | 18:23 | |
*** k0da has quit IRC | 18:33 | |
*** k0da has joined #openstack-powervm | 18:41 | |
*** esberglu has quit IRC | 18:43 | |
edmondsw | esberglu I spoke too soon on snapshot... found a couple things while looking at the rest of the series | 18:44 |
edmondsw | looks like I just missed him | 18:45 |
openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: Having iSCSI Initiator locks per VIOS https://review.openstack.org/557800 | 18:47 |
chhagarw | efried, edmondsw: I am changing the get_iscsi_initiator to have locks per vios uuid, can you have a look at the above review | 18:48 |
chhagarw | https://review.openstack.org/557800 | 18:48 |
chhagarw | I need to further change it to remove the old code, before removing want to have a first level of review, i tested this using PVC | 18:48 |
chhagarw | if it looks fine, i can update the change to remove the old mechanism and add UT. | 18:51 |
edmondsw | chhagarw looking | 18:58 |
chhagarw | thanks | 18:58 |
*** AlexeyAbashkin has joined #openstack-powervm | 19:08 | |
edmondsw | chhagarw is the locking just to prevent you from doing discovery multiple times for the same vios? | 19:12 |
edmondsw | and is that because doing it multiple times would cause a problem, or for performance? | 19:12 |
*** AlexeyAbashkin has quit IRC | 19:13 | |
chhagarw | vios initiator iqn should never change, so there is no use to call initiator discovery every time, rather to store and use it | 19:14 |
edmondsw | chhagarw comments are up | 19:26 |
chhagarw | yeah,i see them, thanks i will update | 19:34 |
chhagarw | how to enable the pypowervm debug | 19:34 |
chhagarw | in nova-powervm | 19:35 |
openstackgerrit | Taylor Jakobson proposed openstack/nova-powervm master: Refactor volume drivers https://review.openstack.org/530816 | 19:39 |
*** chhagarw has quit IRC | 19:53 | |
edmondsw | chhagarw add pypowervm=DEBUG to nova's default_log_levels conf option (comma-delimited if you also want to log other modules) | 19:59 |
edmondsw | chhagarw I didn't understand your response to gfm | 20:04 |
*** chhagarw has joined #openstack-powervm | 20:28 | |
edmondsw | chhagarw add pypowervm=DEBUG to nova's default_log_levels conf option (comma-delimited if you also want to log other modules) | 20:45 |
*** edmondsw has quit IRC | 20:47 | |
*** edmondsw has joined #openstack-powervm | 20:47 | |
*** edmondsw has quit IRC | 20:52 | |
*** esberglu has joined #openstack-powervm | 20:55 | |
*** chhagarw has quit IRC | 20:59 | |
*** esberglu has quit IRC | 21:00 | |
*** esberglu has joined #openstack-powervm | 21:17 | |
*** esberglu has quit IRC | 21:22 | |
*** esberglu has joined #openstack-powervm | 21:23 | |
*** esberglu has quit IRC | 21:28 | |
*** tjakobs has quit IRC | 21:47 | |
*** edmondsw has joined #openstack-powervm | 22:20 | |
*** edmondsw has quit IRC | 22:25 | |
*** AlexeyAbashkin has joined #openstack-powervm | 23:08 | |
*** AlexeyAbashkin has quit IRC | 23:12 | |
*** k0da has quit IRC | 23:46 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!