Wednesday, 2019-03-06

*** tetsuro has joined #openstack-placement00:02
*** ttsiouts has quit IRC00:11
openstackgerritEric Fried proposed openstack/placement master: Remove pep8 whitespace ignores  https://review.openstack.org/64055400:18
openstackgerritEric Fried proposed openstack/placement master: Nit collector  https://review.openstack.org/64055500:18
openstackgerritBrin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot  https://review.openstack.org/58033600:39
openstackgerritBrin Zhang proposed openstack/nova-specs master: Support delete_on_termination in volume attach api  https://review.openstack.org/61294900:40
efriedcdent tetsturo jaypipes re+A https://review.openstack.org/#/c/640554/ (rebased) if you please00:47
*** mriedem has quit IRC01:00
*** tetsuro has quit IRC01:32
*** tetsuro has joined #openstack-placement05:04
*** bhagyashris_ has joined #openstack-placement05:12
*** bhagyashris_ has quit IRC05:43
*** rubasov has quit IRC05:53
*** e0ne has joined #openstack-placement06:31
openstackgerritMerged openstack/placement master: Remove pep8 whitespace ignores  https://review.openstack.org/64055406:42
openstackgerritAbhishek Kekane proposed openstack/nova-specs master: Support multiple backend of Glance  https://review.openstack.org/64121006:52
openstackgerritTetsuro Nakamura proposed openstack/placement master: Use oslo_utils.excutils for reraise exception  https://review.openstack.org/64125607:12
openstackgerritAbhishek Kekane proposed openstack/nova-specs master: Support multiple backend of Glance  https://review.openstack.org/64121007:16
*** bhagyashris has joined #openstack-placement07:39
*** e0ne has quit IRC07:47
*** e0ne has joined #openstack-placement07:54
*** rubasov has joined #openstack-placement07:56
*** e0ne has quit IRC08:16
*** helenafm has joined #openstack-placement08:24
*** takashin has left #openstack-placement08:30
*** tssurya has joined #openstack-placement08:33
*** ttsiouts has joined #openstack-placement09:08
gryfc09:09
*** ttsiouts has quit IRC09:13
*** tetsuro has quit IRC09:35
*** bhagyashris has quit IRC09:54
*** e0ne has joined #openstack-placement10:35
*** cdent has joined #openstack-placement10:49
*** rubasov has quit IRC10:51
*** helenafm_ has joined #openstack-placement11:04
*** helenafm has quit IRC11:06
*** ttsiouts has joined #openstack-placement12:16
sean-k-mooneycdent: i do not have a vote in the placement ptl elections but you would get my +1 if i did.12:31
*** tetsuro has joined #openstack-placement12:31
cdentsean-k-mooney: there was some talk of using nova commits to gather eligible voters, because history is short. thank you.12:31
cdent(I'll check on that)12:31
sean-k-mooneyim going to try and attend some of the placement form/ptg sessions but if i can help out with "get the house in order" it would be a good way for me to learn more about how placement is implemented12:32
*** rubasov has joined #openstack-placement12:32
cdentthank you12:33
sean-k-mooneycdent: well i dont have enough/any real commits to placement code intree or extracted12:33
cdentrun_once?12:33
sean-k-mooneyya that was the only one12:33
sean-k-mooneymost of my contibutions to placement in the past have been "how could we use it in nova" and "what is missing to do x"12:34
cdentI think most of the work for placement over the next several months is going to be work in nova; getting shared and nested really going12:36
sean-k-mooneyya im kind of interested to work on modeling sriov in placement but i need to run that by our team next week12:37
sean-k-mooneyi need to figure out if i will be looking at cyborg stuff next cycle or not and that will determin how much time i have to work on other features.12:38
cdentI'm also really curious to get ironic using it directly, but I don't know that anyone is going to have time for that12:38
sean-k-mooneyas in for ironic standalone12:39
cdentyeah12:39
sean-k-mooneyya that would make sense. alther do they have a standalone schduler. i taught you had to specify the host when it was used standalone12:40
cdentI'm not clear on what the current situation is. Just seems an area worth investigating.12:40
sean-k-mooneyi guess if they modeled everything in placmente you coudl still use placement to find the set of candiates and impemetn your own schduler then call ironic direcly to deploy12:41
sean-k-mooneyso if you were driving ironic with OSM or ONAP it could be interesting12:42
cdentyeah, my etcd-compute experiments made it pretty clear that "scheduler" can be a very lightweight api for "make it go"12:42
sean-k-mooneyya12:42
sean-k-mooneyyou know i was talking to stephen a while ago about how if i had infinit time and energy i would love to replace the current libvirt driver with either an agentless model or distributed state model(like you etcd-compute) to reduce the need for rabbitmq12:45
sean-k-mooneyi still think we would likely need to keep rabbit for db operations like looking up flavors but we could also cache those in etcd so i think 90% or more of the usage of rabbitmq could be eliminated.12:47
sean-k-mooneydid you fully remove it in your etcd-compute driver12:48
sean-k-mooneyoh https://github.com/cdent/etcd-compute does not actully plug into nova12:51
cdentwhen I started the experiment I had no intention of it actually being able to launch real vms, but then that part proved to be "easy"12:58
cdentit's was done more as an example of "small things with placement" than "let's change nova"12:59
*** ttsiouts has quit IRC13:17
*** ttsiouts has joined #openstack-placement13:18
*** ttsiouts has quit IRC13:23
*** ttsiouts has joined #openstack-placement13:28
efriedsean-k-mooney: If you're interested in cyborg, there's some discussion going on right now around the design.13:30
efriedsean-k-mooney: Sundar implemented a PoC of what is essentially the design we agreed upon in Denver last time.13:30
sean-k-mooneyefried: yes i am interested and plan deploy the poc before denver13:31
efriedsean-k-mooney: Series starting at https://review.openstack.org/#/c/631242/13:31
sean-k-mooneythats the nova side right and he has a cyborg branch too13:32
sean-k-mooneywith the same topic?13:32
efriedcyborg side is here: https://review.openstack.org/#/c/626420/13:32
sean-k-mooneyok can we at least put them on the same gerrit topic so that they are easy to find?13:32
efriedWe're still trying to convince Jay this is the right approach. He wants to see custom resource classes and no dynamic programming (unless orchestrated externally)13:33
efriedsean-k-mooney: They're not the same topic. One is a pilot branch for the cyborg API itself; the other is consuming that API in nova. They'll have different blueprints, specs, etc.13:33
efriedThe cyborg series is linked from the commit message of the patch that starts using it.13:34
sean-k-mooneywell i need to look at what was actully implemented in the piolt before i can comment13:34
*** mriedem has joined #openstack-placement13:34
efriedsure.13:35
sean-k-mooneyefried: i personally thing that programing a device should not change its representation in placment13:35
efriedsean-k-mooney: There's an etherpad with an overview of the design (and a bit of internal discussion): https://etherpad.openstack.org/p/nova-cyborg-design-notes13:35
jaypipesefried: morning.13:36
jaypipessean-k-mooney: you too :)13:36
efriedsean-k-mooney: In the PoC, programming the device changes its traits, not its inventory.13:36
efriedHi jaypipes13:36
sean-k-mooneyjaypipes: o/13:36
sean-k-mooneyefried: it feels at first glance that cyborge by changing its traits is just using placement as metadata storage13:37
jaypipessean-k-mooney: bingo.13:38
sean-k-mooneybut it has its uses in that i may avoid having to reprogram a deivce if you trust that a guest cant do somthing malious to it13:38
jaypipessean-k-mooney: course, we've had this conversation about ten times already at each of the past PTGs over the last 1.5 years at least.13:38
sean-k-mooneye.g. you could reuse the device for another requset without needing to reprogram13:38
sean-k-mooneyhaha ya13:38
efriedjaypipes: Yes, we have, and we have always come back to the model proposed in the PoC.13:39
jaypipesOK, since the risk of derailment is high, I am going back to getting reviews done this morning, sorry guys...13:39
sean-k-mooneydidnt we lay out a 3 phase plan in both denver and dublin13:39
efriedchanging traits isn't perfect, but custom resource classes are the greater evil13:40
efriedsean-k-mooney: Yes, we did.13:40
sean-k-mooneyjaypipes: no worries i too need to jump to a neuton patch that i need to rethink13:40
sean-k-mooneyefried: well the custom resouce class would be fixed13:40
efriedno13:40
sean-k-mooneye.g. it also would not change based in the programmed image13:41
efriedcyborg would be changing the inventory every time it reprogrammed.13:41
sean-k-mooneyit would be based on the device13:41
efriedno13:41
efriedcyborg would be changing the inventory every time it reprogrammed.13:41
sean-k-mooneyit does not have to however13:41
jaypipesefried: what does the kubernetes scheduler team think about FPGAs and GPU resources?13:41
jaypipesefried: are you familiar with the PCI management proposals in k8s land for tracking custom hardware?13:42
efriedjaypipes: no idea. I would only be guessing if I said a container wants its accelerators to be programmed by the time the container is stood up.13:42
sean-k-mooneyjaypipes: they have device pluggins13:42
jaypipesright. everything is a plugin. no standards, no idea how to do standardized resource tracking. it's complete wild west.13:43
sean-k-mooneyyou can freeley add new ones for your custom device without needeing to change the core13:43
sean-k-mooneyya13:43
efriedright, was gonna ask if k8s people use placement?13:43
sean-k-mooneypros and cons13:43
jaypipesalso no ability to share resources like this between tenants with any isolation.13:43
cdent(not yet!)13:43
sean-k-mooneythey dont need to have this conversation but each deployment is totally different13:43
jaypipesI'm actually going to get back to reviews, but my point is that k8s land has done the same wild-west approach that the original nova pci manager made and it's going to bite them as hard long-term.13:45
jaypipessee the proposals from nvidia and intel over there.13:45
jaypipessame stuff, different hype.13:45
efriedThe proposed use of placement makes this anything but a wild west. It is tightly controlled and structured.13:50
*** tetsuro has quit IRC13:50
jaypipeswe'll have to agree to disagree.13:51
*** tetsuro has joined #openstack-placement13:51
efriedjaypipes: I would be happy to do so if we could move the cyborg-in-nova effort forward with the consensus-but-one that we've reached every time we've talked about this.13:52
jaypipesefried: you can just say "dude, you're being an asshole blocker for this" :)13:55
jaypipesbut at the end of the day, I have as much right as anyone to point out what I think is a bad design and a bad misuse of the placement API.13:55
efriedjaypipes: Absolutely. And your viewpoint is greatly respected. But at the end of the day, we have to be able to make progress even if there's a conflicting respected viewpoint on the table.13:57
jaypipesunderstood completely.13:57
jaypipesof course, I might disagree this is progress, but OK :)13:57
cdentIf it's true that we agreed to this plan at the last PTG, unless there are new reasons for disagreement, can we move forward, even if it is somewhat icky?13:58
efried...that's what I would like to see. IMO Sundar has done an excellent job of crisping up the details and proving them in code. AFAIK nothing new has come up - no surprises or revelations as this was being implemented.14:06
jaypipesefried: so, the only thing I had asked of the Cyborg team at the last 2 PTGs was the following: working (shown in a test) code that plumbs a VM to an FPGA programmed region. Has that been done?14:07
efriedjaypipes: In a test that you can see in gerrit? I don't think so. But the PoC series works in a devstack.14:08
efriedthe device is currently faked.14:09
efriedbut that part - putting the pci address in the xml - isn't new14:09
jaypipesefried: which is the ONLY thing I'd asked for in the last 2 years. show some code that functionally connects a VM to the FPGA.14:09
efriedyup, that's what the PoC patches do.14:10
jaypipesit's a faked device.14:10
efriedare we expecting a real device in a CI?14:11
jaypipeswe better be, otherwise we'll end up in NUMA live migration land.14:11
jaypipesand we all know how much fun that's been.14:11
efriedstanding up a CI with real hardware for a PoC seems like kind of an unreasonable ask.14:11
jaypipessame for PCI devicemanager land.14:11
jaypipesefried: not CI, sorry.14:11
efriedfor the real thing, fair14:11
jaypipesefried: I'd be happy with just a demo of real hardware.14:12
jaypipesbut I've never seen anything like that. instead, the focus has been on yet another REST API service.14:12
jaypipessorry if I'm annoyed about that14:12
jaypipesbut at least I've been consistently annoyed for 2 years on the same exact point.14:12
efriedOkay. I'll go ask Sundar to deploy his PoC against real hardware and put together some kind of demo... video or something.14:12
jaypipesin any case, it doesn't sound like anything is going to change, so I'll relent.14:13
efriedThanks. The compromise is appreciated.14:13
efried(no sarcasm, in case that came across wrong)14:14
mriedemwe should uh, maybe, not yell at people https://docs.openstack.org/placement/latest/placement-api-microversion-history.html#granular-resource-requests-to-get-allocation-candidates14:14
jaypipesheh. compromise...14:14
*** jaypipes has quit IRC14:14
cdentmriedem: but it is really important!14:15
*** jaypipes has joined #openstack-placement14:15
cdentmriedem: you fixing it, or shall i?14:16
mriedemi'm doing it14:16
efriedmriedem: That's a ``this`` role14:16
mriedemi know14:16
mriedemin a title14:16
efriedI guess in other titles we're just not using a role?14:16
efriedI don't know that that's better. But okay.14:16
mriedemyou don't really need to in a title14:16
mriedemb/c it's a title14:16
efriedstephenfin: do you have a way we can make a code-ish chunk look code-ish in a title?14:17
efried(without shouting)14:18
stephenfinefried: What do you mean?14:19
stephenfin``code``14:19
stephenfin--------14:19
openstackgerritMatt Riedemann proposed openstack/placement master: Stop yelling the 1.25 microversion history at people  https://review.openstack.org/64138114:19
mriedemstephenfin: ^14:19
mriedemhttps://docs.openstack.org/placement/latest/placement-api-microversion-history.html#granular-resource-requests-to-get-allocation-candidates14:19
stephenfinmriedem: Well that's annoying. That's a bug in openstack-docs-theme. Happy to fix if you fancy creating a quick bug at some point14:20
efriedah, that would be a better solution imo.14:21
mriedemfix how? just ignore `` `` in titles?14:21
efriednot ignore. reduce font size and match color?14:21
stephenfinYou could make it monospace but not bold and black14:21
efriedyeah, or that14:21
mriedemhttps://bugs.launchpad.net/openstack-doc-tools/+bug/181884014:23
openstackLaunchpad bug 1818840 in openstack-doc-tools "``this`` in titles is extra loud" [Undecided,New]14:24
openstackgerritMatt Riedemann proposed openstack/placement master: Stop yelling the 1.11 and 1.25 microversion history at people  https://review.openstack.org/64138114:25
openstackgerritTetsuro Nakamura proposed openstack/placement master: Prepare for negative member_of queryparam  https://review.openstack.org/64139114:31
openstackgerritTetsuro Nakamura proposed openstack/placement master: Prepare for negative member queryparam 2  https://review.openstack.org/64139214:31
openstackgerritTetsuro Nakamura proposed openstack/placement master: Negative member_of query with microversion 1.32  https://review.openstack.org/64139314:31
cdenttetsuro++14:31
tetsuroI'm going to bed since it's too late now.14:32
tetsurobye14:34
*** tetsuro has quit IRC14:34
cdenthow do people feel about visual indent?14:38
efrieddefine, please14:39
edleafeHate it14:39
efriedyou considering adding a pep ignore and/or hacking rule?14:39
efriedis this the one where the start of the continuation line is lined up with the opening paren of the first line?14:39
cdenthttps://github.com/openstack/placement/blob/master/placement/tests/unit/objects/test_resource_provider.py#L162-L16414:40
cdentedleafe: I also hate it. very bad for diffs14:40
cdentopenstacksdk forbids it, if I remember right14:41
cdentat this point, I'm thinking, not proposing14:41
efriedMy opinion: sometimes it's appropriate, sometimes it's not. I don't agree with a rule that enforces "*never* do it". But wouldn't block such a rule if majority agreed on it.14:43
efriedfor instance, the example you linked doesn't offend me at all.14:43
efriedor the one below it.14:44
edleafeOne fundamental concept with Python is that indentation is semantic. Things at the same nesting level should have the same indentation.14:45
openstackgerritEric Fried proposed openstack/placement master: DNM: Use ``code`` role in api-ref titles  https://review.openstack.org/64140414:53
efriedmriedem, stephenfin: there's that ^ for when the docs theme fix is in.14:54
stephenfinefried: Sweet, fix is here https://review.openstack.org/64140815:01
efriedstephenfin: nice. Does depends-on work for docstheme? (don't see why it wouldn't)15:01
stephenfinI would imagine so, yup15:02
efriedtrying...15:02
openstackgerritEric Fried proposed openstack/placement master: DNM: Use ``code`` role in api-ref titles  https://review.openstack.org/64140415:03
openstackgerritStephen Finucane proposed openstack/placement master: Group API versions by release  https://review.openstack.org/64142215:46
stephenfinefried: You'd also like that ^^^ coupled with this https://review.openstack.org/641423, I suspect15:46
efried...15:47
efrieddid you mean to make the former dependent on the latter?15:48
stephenfinI probably should have, yeah, but it's not compulsory15:48
stephenfinIt still looks better (IMO) even without the openstackdocstheme chang15:49
stephenfin*change15:49
*** rubasov has quit IRC16:04
*** ttsiouts has quit IRC16:08
*** ttsiouts has joined #openstack-placement16:09
openstackgerritChris Dent proposed openstack/placement master: Move ResourceClass and ResourceClassList to own module  https://review.openstack.org/64143216:10
openstackgerritChris Dent proposed openstack/placement master: Remove the ResourceClassList class  https://review.openstack.org/64143316:10
* cdent switches back to osc-placement16:10
*** ttsiouts has quit IRC16:11
*** ttsiouts has joined #openstack-placement16:11
*** Sundar has joined #openstack-placement16:15
*** tssurya has quit IRC16:18
efriedcdent: https://review.openstack.org/#/c/640555/ is now first-in-queue, and contains valid changes. We could keep it around for a while as a collector, or we could just merge it and move on, or we could split it into two changes since it's really two changes (though a whole patch for a one-character typo in a comment is the kind of thing we usually don't accept from anyone), or... something else?16:33
cdentefried: I think you should tune up the commit message and we should simply merge it16:34
cdentit's no longer really a "collector" when it is first16:34
efriedokay, stand by.16:36
openstackgerritEric Fried proposed openstack/placement master: Add explicit short-circuit in get_all_by_consumer_id  https://review.openstack.org/64055516:38
efriedcdent: ^16:38
cdentaye16:39
openstackgerritMerged openstack/placement master: Stop yelling the 1.11 and 1.25 microversion history at people  https://review.openstack.org/64138116:59
*** rubasov has joined #openstack-placement17:17
*** ttsiouts has quit IRC17:24
*** ttsiouts has joined #openstack-placement17:25
*** ttsiouts has quit IRC17:29
*** e0ne has quit IRC17:34
*** helenafm_ has quit IRC17:34
openstackgerritChris Dent proposed openstack/osc-placement master: Add support for 1.19 microversion  https://review.openstack.org/64109418:30
openstackgerritChris Dent proposed openstack/osc-placement master: Microversion 1.21 support  https://review.openstack.org/64112318:30
*** Sundar has quit IRC18:31
*** jaypipes has quit IRC18:44
*** Sundar has joined #openstack-placement19:29
*** cdent_ has joined #openstack-placement19:59
*** cdent has quit IRC20:02
*** cdent_ is now known as cdent20:02
*** e0ne has joined #openstack-placement20:03
*** Sundar has quit IRC20:19
*** e0ne has quit IRC20:21
*** cdent has quit IRC20:42
*** e0ne has joined #openstack-placement21:13
*** takashin has joined #openstack-placement21:50
*** e0ne has quit IRC21:58
*** e0ne has joined #openstack-placement22:01
*** e0ne has quit IRC22:01
openstackgerritEric Fried proposed openstack/placement master: Get rid of backslash continuations in code  https://review.openstack.org/64149722:19
openstackgerritChris Dent proposed openstack/placement master: Move ResourceClass and ResourceClassList to own module  https://review.openstack.org/64143222:20
openstackgerritChris Dent proposed openstack/placement master: Remove the ResourceClassList class  https://review.openstack.org/64143322:20
openstackgerritChris Dent proposed openstack/placement master: Move Trait and TraitList to own module  https://review.openstack.org/64150022:20
openstackgerritChris Dent proposed openstack/placement master: Make Trait._get_by_name_from_db a reader  https://review.openstack.org/64150122:20

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!