| *** ttsiouts has joined #openstack-placement | 00:07 | |
| *** openstackgerrit has joined #openstack-placement | 00:13 | |
| openstackgerrit | melanie witt proposed openstack/osc-placement master: Add 'aggregate allocation ratio set' batch command https://review.openstack.org/640898 | 00:13 |
|---|---|---|
| *** tetsuro has joined #openstack-placement | 00:13 | |
| *** ttsiouts has quit IRC | 00:29 | |
| openstackgerrit | melanie witt proposed openstack/osc-placement master: Add 'aggregate allocation ratio set' batch command https://review.openstack.org/640898 | 00:49 |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support delete_on_termination in volume attach api https://review.openstack.org/612949 | 00:54 |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot https://review.openstack.org/580336 | 00:58 |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot https://review.openstack.org/580336 | 00:59 |
| openstackgerrit | Merged openstack/placement master: Fix typo in db-auto-sync release note https://review.openstack.org/640886 | 01:01 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: FUPs for improve-debug-log series https://review.openstack.org/640909 | 01:05 |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support delete_on_termination in volume attach api https://review.openstack.org/612949 | 01:05 |
| *** bhagyashris has joined #openstack-placement | 01:55 | |
| openstackgerrit | Merged openstack/placement master: Make the PlacementFixture usable without intercept https://review.openstack.org/640852 | 02:27 |
| *** takashin has joined #openstack-placement | 02:30 | |
| *** alanmeadows has left #openstack-placement | 03:21 | |
| openstackgerrit | melanie witt proposed openstack/osc-placement master: Add 'aggregate allocation ratio set' batch command https://review.openstack.org/640898 | 04:51 |
| openstackgerrit | melanie witt proposed openstack/osc-placement master: Add 'aggregate allocation ratio set' batch command https://review.openstack.org/640898 | 05:41 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Retry new transaction on failure https://review.openstack.org/640939 | 05:46 |
| *** dims has quit IRC | 06:24 | |
| *** e0ne has joined #openstack-placement | 06:24 | |
| *** dims has joined #openstack-placement | 06:26 | |
| *** e0ne has quit IRC | 06:33 | |
| *** dims has quit IRC | 06:36 | |
| *** dims has joined #openstack-placement | 06:37 | |
| *** e0ne has joined #openstack-placement | 06:46 | |
| *** e0ne has quit IRC | 07:07 | |
| *** takashin has left #openstack-placement | 07:32 | |
| *** tssurya has joined #openstack-placement | 08:16 | |
| *** e0ne has joined #openstack-placement | 08:17 | |
| *** helenfm has joined #openstack-placement | 08:29 | |
| *** rubasov has quit IRC | 08:33 | |
| *** ttsiouts has joined #openstack-placement | 08:52 | |
| *** e0ne has quit IRC | 08:58 | |
| *** e0ne has joined #openstack-placement | 09:00 | |
| *** ttsiouts has quit IRC | 09:05 | |
| *** ttsiouts has joined #openstack-placement | 09:06 | |
| *** ttsiouts has quit IRC | 09:10 | |
| *** ttsiouts has joined #openstack-placement | 09:12 | |
| *** cdent has joined #openstack-placement | 09:15 | |
| *** bhagyashris has quit IRC | 09:38 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: cpu-model-selection: s/cpu_models/cpu_model_list/ https://review.openstack.org/640866 | 09:41 |
| cdent | tetsuro: unfortunately that whitespace change is fairly deep in that scrub-Lists stack so can't merge until we get all that stuff above it | 09:44 |
| cdent | or pull it out (which would create merge conflicts galore) | 09:44 |
| tetsuro | Yeah, I realized that just after approving it. | 09:45 |
| tetsuro | because that's not urgent I'm okay. | 09:46 |
| cdent | most of the stuff above it is fairly safe, but also not urgent | 09:47 |
| cdent | we're mostly waiting on jaypipes to ack that we are going his way later in the stack | 09:47 |
| cdent | If indeed, "ack" is what he'd like to do | 09:47 |
| tetsuro | We can wait. It can be approved after the feature freeze. | 09:50 |
| tetsuro | cdent: BTW, could you have a look on https://review.openstack.org/#/c/640939/? | 09:51 |
| cdent | Are we even having feature freeze in placement? | 09:52 |
| tetsuro | Ah, that was my thought if we cut Stein branch | 09:53 |
| cdent | yes, but that's some time away still | 09:54 |
| cdent | rc1 target is march 18-22 | 09:57 |
| tetsuro | IMO, we can go in the same way as the other official projects. IMO, the period before release and after feature freeze is for debugging and refactoring. | 09:58 |
| tetsuro | There is no reason placement does not need the period for debugging and refactoring. | 09:59 |
| cdent | yeah, I wasn't trying to suggest we should never have one, just that this cycle things are a bit weird because of the extraction | 10:02 |
| cdent | And if we had some pending feature-related commits that were nearly ready, hewing strictly to the feature freeze deadline would be overkill | 10:02 |
| tetsuro | I see. Yeah, actually I'm looking into negative-member-of feature locally and wondering I can make it before the feature freeze. | 10:04 |
| *** rubasov has joined #openstack-placement | 10:05 | |
| cdent | that's seems pretty straightforward and also very useful | 10:09 |
| cdent | brb | 10:09 |
| *** tetsuro has quit IRC | 10:25 | |
| *** tetsuro has joined #openstack-placement | 10:29 | |
| cdent | tetsuro: thanks for continuing to plug away at this aggregate creation stuff. this latest version seems to be really good | 10:39 |
| *** ttsiouts has quit IRC | 11:19 | |
| *** ttsiouts has joined #openstack-placement | 11:20 | |
| *** ttsiouts has quit IRC | 11:24 | |
| *** e0ne has quit IRC | 11:32 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Retry new transaction on failure https://review.openstack.org/640939 | 11:39 |
| tetsuro | pleasure :) | 11:40 |
| *** tetsuro has quit IRC | 11:40 | |
| *** e0ne has joined #openstack-placement | 11:42 | |
| *** ttsiouts has joined #openstack-placement | 12:01 | |
| *** mriedem has joined #openstack-placement | 12:41 | |
| jaypipes | cdent: yeah, sorry, got caught up in other reviews yesterday (and cyborg-y things) | 13:15 |
| jaypipes | cdent: lemme tackle that series right now. | 13:15 |
| cdent | no worries, I just didn't want us to get too far without you having a chance to weigh in | 13:16 |
| cdent | as it is starting to get a bit scattered (pull thread here, thing over there wiggles) | 13:16 |
| jaypipes | cdent: my entire life is a bit scattered. | 13:17 |
| * cdent gives jaypipes a palm pilot | 13:17 | |
| cdent | or, have I ever mentioned the OnIt™ | 13:17 |
| jaypipes | lol | 13:20 |
| edleafe | cdent: (reading back) Feature freeze seems like a necessity since we are keeping the same release pattern. But given the extraction issues you mentioned, we could probably be a little more generous than usual with granting exceptions | 13:36 |
| cdent | yeah, that's basically what I was trying to say above | 13:36 |
| cdent | mostly to encourage tetsuro to do even more work if he was itching | 13:38 |
| edleafe | I didn't get the impression that he needed encouragement :) | 13:38 |
| cdent | permission? | 13:38 |
| *** dklyle has joined #openstack-placement | 14:13 | |
| *** ttsiouts has quit IRC | 14:21 | |
| *** ttsiouts has joined #openstack-placement | 14:22 | |
| * cdent \o/s at jaypipes | 14:24 | |
| *** ttsiouts has quit IRC | 14:25 | |
| *** ttsiouts has joined #openstack-placement | 14:25 | |
| jaypipes | cdent, efried, edleafe: k, that ovo-ectomy should be well on its way now. sorry for the delay in reviewing. | 14:35 |
| cdent | thank you jaypipes | 14:35 |
| jaypipes | no need to thank me. thank YOU guys for making it happen. | 14:37 |
| * cdent schedules a party | 14:37 | |
| cdent | Once that stuff settles I'll do another object | 14:38 |
| *** e0ne has quit IRC | 15:02 | |
| *** e0ne has joined #openstack-placement | 15:13 | |
| *** openstackgerrit has quit IRC | 15:28 | |
| cdent | mriedem (and anyone else): quick osc-placement query. microversion 1.19 and 1.20 aren't particular user visible ( https://docs.openstack.org/placement/latest/placement-api-microversion-history.html#include-generation-and-conflict-detection-in-provider-aggregates-apis ) | 15:45 |
| cdent | in the past we skip things that seem like that, are those skip like too? | 15:46 |
| cdent | I'm trying to determine the guidelines for what is skippable | 15:46 |
| mriedem | i think 1.19 is skippable | 15:51 |
| mriedem | well, | 15:51 |
| mriedem | https://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-aggregate-list | 15:52 |
| mriedem | ^ could show the generation yeah? | 15:52 |
| *** rubasov has quit IRC | 15:52 | |
| cdent | I don't think we want humans to have to care about generations do we? | 15:53 |
| mriedem | what happens if i update aggregates without specifying a generation? | 15:53 |
| mriedem | it just overwrites right? | 15:53 |
| cdent | you mean using the older version? yea | 15:53 |
| mriedem | so if i were paranoid about data consistency and using the CLI, it might care about generation | 15:54 |
| mriedem | purely optional of course | 15:54 |
| cdent | hrmmm | 15:54 |
| cdent | the term generation isn't on that page yet | 15:55 |
| mriedem | as for 1.20, the change would be https://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-create goes from not printing anything (maybe it just prints the uuid today) to printing the response body | 15:55 |
| cdent | I get that we _could_ do that with 1.20, but what would the point be? | 15:56 |
| mriedem | looking at https://docs.openstack.org/placement/latest/placement-api-microversion-history.html 1.19 is the first thing to deal with generations | 15:56 |
| cdent | Is the goal to make a useful client, or to simply replicate the microversions? | 15:56 |
| mriedem | "This is to allow the caller to glean automatically-set fields, such as UUID and generation, without a subsequent GET." | 15:56 |
| mriedem | i don't know what the client does today after create resource provider, | 15:57 |
| mriedem | does it just get it back and show it? | 15:57 |
| mriedem | or dump the uuid? | 15:57 |
| cdent | it appears to do a | 15:57 |
| cdent | GET and then dump a selection of the fields, depending on microversion | 15:58 |
| mriedem | yeah so we could skip 1.20 | 15:58 |
| mriedem | since the client already does it | 15:58 |
| cdent | I don't think I'm the best guy for this particular job, long term | 15:59 |
| cdent | I don't think I think the same about clients as ... I'm not sure who | 15:59 |
| cdent | but there's a gap, I'll see what I can do | 15:59 |
| *** belmoreira has quit IRC | 16:00 | |
| mriedem | idk, i usually ask dtroyer if i need another opinion | 16:09 |
| * cdent will make the doughnuts | 16:10 | |
| cdent | donuts? | 16:10 |
| *** openstackgerrit has joined #openstack-placement | 16:14 | |
| openstackgerrit | Merged openstack/placement master: Factor listiness into an ObjectList base class https://review.openstack.org/637325 | 16:14 |
| openstackgerrit | Merged openstack/placement master: Move _set_objects into ObjectList https://review.openstack.org/637328 | 16:24 |
| openstackgerrit | Merged openstack/placement master: Move *List.__repr__ into ObjectList https://review.openstack.org/637332 | 16:24 |
| openstackgerrit | Merged openstack/placement master: Clean up ObjectList._set_objects signature https://review.openstack.org/637335 | 16:24 |
| openstackgerrit | Merged openstack/placement master: Move RC_CACHE in resource_class_cache https://review.openstack.org/640114 | 16:24 |
| openstackgerrit | Merged openstack/placement master: Use native list for lists of Usage https://review.openstack.org/639391 | 16:24 |
| openstackgerrit | Merged openstack/placement master: Make base test case file for object unit tests https://review.openstack.org/640406 | 16:24 |
| openstackgerrit | Merged openstack/placement master: Move reshape() into placement.objects.reshaper https://review.openstack.org/640540 | 16:34 |
| openstackgerrit | Merged openstack/placement master: ResourceProvider.increment_generation() https://review.openstack.org/640433 | 16:34 |
| openstackgerrit | Merged openstack/placement master: Move Allocation and AllocationList to own module https://review.openstack.org/640184 | 16:34 |
| openstackgerrit | Merged openstack/placement master: Use native list for lists of Allocation https://review.openstack.org/640450 | 16:34 |
| *** rubasov has joined #openstack-placement | 16:41 | |
| *** helenfm has quit IRC | 16:45 | |
| *** tssurya has quit IRC | 16:45 | |
| melwitt | hey y'all, I proposed a change to osc-placement to add a batch command for setting allocation ratios, if anyone could please review https://review.openstack.org/640898 | 17:06 |
| melwitt | context is at L67 of this etherpad https://etherpad.openstack.org/p/nova-stein-blueprint-status | 17:07 |
| -openstackstatus- NOTICE: Gerrit is being restarted for a configuration change, it will be briefly offline. | 17:11 | |
| cdent | melwitt++ | 17:12 |
| *** e0ne has quit IRC | 17:18 | |
| openstackgerrit | Chris Dent proposed openstack/osc-placement master: Add support for 1.19 microversion https://review.openstack.org/641094 | 17:31 |
| *** ttsiouts has quit IRC | 17:38 | |
| openstackgerrit | Merged openstack/placement master: FUPs for improve-debug-log series https://review.openstack.org/640909 | 17:50 |
| openstackgerrit | Merged openstack/placement master: Retry new transaction on failure https://review.openstack.org/640939 | 17:50 |
| cdent | melwitt: that osc-placement change is very nice | 17:54 |
| melwitt | cdent: thank you :) I spent a lot of time on it so that is a boost to hear | 17:55 |
| *** e0ne has joined #openstack-placement | 18:19 | |
| *** mriedem has quit IRC | 18:37 | |
| *** mriedem has joined #openstack-placement | 18:39 | |
| *** e0ne has quit IRC | 19:17 | |
| cdent | efried: looks like you called recheck on the pep8 changes, but what's needed in a rebase? | 19:28 |
| efried | yes, I realized that after, it needs a rebase on the retry patch. I'm going to wait until the one before it merges so I don't knock it out of the gate. It's almost done. | 19:29 |
| cdent | kewl | 19:29 |
| efried | (there are other ways, but I'm not in a big hurry) | 19:29 |
| cdent | indeed | 19:30 |
| cdent | I just saw it come across in email and thought "hang on..." | 19:30 |
| * cdent has some pancakes | 19:30 | |
| *** ttsiouts has joined #openstack-placement | 19:31 | |
| *** e0ne has joined #openstack-placement | 19:37 | |
| *** ttsiouts has quit IRC | 20:11 | |
| *** ttsiouts has joined #openstack-placement | 20:11 | |
| *** ttsiouts has quit IRC | 20:15 | |
| *** ttsiouts has joined #openstack-placement | 20:32 | |
| efried | cdent: When I said that patch was close before, I was looking at the check queue. It's in the gate now. | 20:33 |
| cdent | nbd | 20:34 |
| cdent | that's _really_ good | 20:35 |
| efried | however, turns out the rebase wasn't the retry patch, it was the fup for the debug log thing, renaming those RPs. | 20:35 |
| cdent | ww | 20:36 |
| cdent | it's cool to see all that stuff merge, but I guess that leave me (and whomever else) on the hook to do the other *List | 20:40 |
| efried | yup :P | 20:40 |
| melwitt | cdent: I dunno if maybe you didn't see my question in the quota usage from placement patch, but would the exception to @retrying.retry on be ks_exc.ConnectFailure to retry in the case of network issues? | 20:43 |
| cdent | melwitt: I saw it and meant to go back to it and then it sort of slipped my mind because I didn't have the answer to hand. efried probably knows the answer more quickly | 20:44 |
| cdent | (as he's been on that side of the equation more than me) | 20:44 |
| melwitt | oh, ok, sorry | 20:45 |
| cdent | no need to apologize. I was the one who forgot... | 20:45 |
| efried | melwitt: Yes, sorry, have been distracted by other things today, but that was high on my list to respond to. | 20:45 |
| efried | let me go take a look now... | 20:45 |
| melwitt | thanks yall | 20:47 |
| openstackgerrit | Chris Dent proposed openstack/osc-placement master: WIP: Microversion 1.21 support https://review.openstack.org/641123 | 20:51 |
| cdent | I reckon that's my day | 20:51 |
| cdent | at least my day on irc | 20:51 |
| cdent | goodnight all | 20:51 |
| *** cdent has quit IRC | 20:51 | |
| efried | melwitt: Responded in https://review.openstack.org/#/c/638073/ -- sorry for the delay, please lmk if I can help further. | 21:06 |
| efried | ...though I'll be afk for an hour for school runs :( | 21:06 |
| melwitt | efried: thanks. we don't want to retry for just anything from ksa right? or do we? | 21:08 |
| melwitt | and yes I knew better than the use @safe_connect, at least xD | 21:08 |
| efried | melwitt: In this case we're just doing a couple of GETs | 21:08 |
| efried | so yeah, no harm in retrying for any failure | 21:09 |
| melwitt | ok | 21:09 |
| efried | I mean, I guess some of them might not be recoverable without other action, like recreating the client. | 21:09 |
| efried | uh, hold on... | 21:09 |
| melwitt | I was thinking that retrying for an auth failure would be unhelpful, for example | 21:10 |
| efried | hum, yeah, you actually wouldn't want to bother retrying on something like EndpointNotFound... yeah | 21:10 |
| efried | melwitt: Perhaps just ConnectFailure? | 21:12 |
| melwitt | efried: ok, that's what I was thinking. thanks | 21:12 |
| *** e0ne has quit IRC | 21:13 | |
| efried | I'm not sure we're being that careful anywhere else tbh | 21:13 |
| *** e0ne has joined #openstack-placement | 21:26 | |
| *** e0ne has quit IRC | 21:30 | |
| *** takashin has joined #openstack-placement | 23:36 | |
| openstackgerrit | Merged openstack/placement master: Inline Consumer.increment_generation() https://review.openstack.org/640437 | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!