Thursday, 2018-09-06

openstackgerritfupingxie proposed openstack/nova master: Add an example to add more pci devices in nova.conf  https://review.openstack.org/59224300:42
openstackgerritMerged openstack/nova master: Move str to six.string_types  https://review.openstack.org/59949300:49
openstackgerritMerged openstack/nova master: Fix a failure to format config sample  https://review.openstack.org/59798600:50
openstackgerritfupingxie proposed openstack/nova master: Delete allocations for instances that have been moved to another node  https://review.openstack.org/58289901:23
*** lei-zh has joined #openstack-placement02:13
*** nicolasbock has quit IRC02:18
openstackgerritBrin Zhang proposed openstack/nova-specs master: Resource retrieving: add changes-before filter  https://review.openstack.org/59197603:33
openstackgerritYikun Jiang (Kero) proposed openstack/placement master: Rename PlacementPolicyFixture to PolicyFixture  https://review.openstack.org/60032603:47
*** lei-zh has quit IRC04:53
openstackgerritMerged openstack/nova stable/rocky: Don't use '_TransactionContextManager._async'  https://review.openstack.org/59742104:56
*** lei-zh has joined #openstack-placement05:17
openstackgerritMerged openstack/nova master: Doc: PowerVM does support shelve  https://review.openstack.org/59305205:47
openstackgerritTakashi NATSUME proposed openstack/nova stable/rocky: Fix a failure to format config sample  https://review.openstack.org/60033606:10
openstackgerritYikun Jiang (Kero) proposed openstack/placement master: Unify utils.py and util.py  https://review.openstack.org/60035306:54
*** e0ne has joined #openstack-placement06:58
*** tetsuro has joined #openstack-placement08:01
openstackgerritBrin Zhang proposed openstack/nova master: Resource retrieving: add changes-before filter  https://review.openstack.org/59927608:10
*** cdent has joined #openstack-placement08:19
openstackgerritElod Illes proposed openstack/nova stable/queens: Remove noisy DEBUG log  https://review.openstack.org/60037208:29
*** tetsuro has quit IRC08:37
*** tetsuro has joined #openstack-placement08:46
*** lei-zh has quit IRC09:01
*** tetsuro has quit IRC09:46
*** tetsuro has joined #openstack-placement09:48
*** e0ne has quit IRC10:15
*** nicolasbock has joined #openstack-placement10:31
openstackgerritChris Dent proposed openstack/placement master: de-novify wsgi application to expect placement config  https://review.openstack.org/60015710:35
*** e0ne has joined #openstack-placement10:39
*** cdent has quit IRC11:02
openstackgerritMerged openstack/nova master: Fix nits: Compute: Handle reshaped provider trees  https://review.openstack.org/59838711:02
openstackgerritYikun Jiang (Kero) proposed openstack/placement master: Rename PlacementPolicyFixture to PolicyFixture  https://review.openstack.org/60032611:12
openstackgerritClaudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages  https://review.openstack.org/47077511:17
*** tetsuro has quit IRC11:20
*** cdent has joined #openstack-placement11:33
cdentupdate placedock to use openstack/placement, it's happy, placecat is happy, as long as https://review.openstack.org/#/c/600157/ is in there11:36
jrollcdent: holy cow those are some fast tests, much applause11:59
cdentain't it fun?11:59
openstackgerritVladyslav Drok proposed openstack/nova master: Fix resource tracker updates during instance evacuation  https://review.openstack.org/60042512:15
*** tetsuro has joined #openstack-placement12:23
*** rubasov has joined #openstack-placement12:24
*** cdent has quit IRC12:34
*** tetsuro has quit IRC12:34
*** tetsuro has joined #openstack-placement12:38
*** e0ne has quit IRC12:41
jaypipesjroll: which tests did you think were fast?12:47
*** e0ne has joined #openstack-placement12:59
*** mriedem has joined #openstack-placement13:08
jrolljaypipes: just over a minute for -epy27,functional,pep8,py36,functional-py36, from scrollback yesterday13:15
jrollthat's pretty dang fast (especially in openstack)13:16
efriedstephenfin: Do you know how to add doc jobs? https://review.openstack.org/#/c/600268/13:23
stephenfinefried: zuul job? If so, AJaeger would be your best bet13:24
efriedThanks.13:24
jaypipesjroll: oh... I thought you were referring to cdent's message about referencing https://review.openstack.org/#/c/600157/13:28
jaypipesjroll: and I see 5+ minute times for those...13:28
jrolljaypipes: ah, gotcha13:29
openstackgerritTetsuro Nakamura proposed openstack/nova stable/rocky: placement: use simple code paths when possible  https://review.openstack.org/60044713:30
efriedapparently that time is all spend setting up the node/env13:30
efriedspent13:30
efriedthough I haven't looked.13:31
edleafeefried: http://logs.openstack.org/57/600157/2/check/openstack-tox-functional/b0513f8/job-output.txt.gz#_2018-09-06_11_17_05_07137113:33
edleafeFunctional tests took just under 53 seconds to run13:33
efriednoyce13:33
*** takashin has joined #openstack-placement13:34
efriedThere's a thing stephenfin was going to fix in tox so it didn't do some kind of heavyweight check up front, which ought to trim the local times down too.13:34
stephenfinefried: https://github.com/tox-dev/tox/commit/95f5476e31fd20a93b70027efac1f1864b6ed25c13:35
efriedstephenfin: What's with the quote changes?13:36
stephenfinefried: I had it in multiple patches and they squashed them13:37
efriedight. This in a release yet?13:37
stephenfinefried: i.e. blame them13:37
efriedheh13:37
stephenfinefried: Since 3.1.3, apparently13:38
efriedneat13:38
stephenfin(If the GitHub UI is to be believed)13:38
efriedI so don't know how to use the github ui.13:39
efriedapparently 3.1.3 isn't available for my distro, or something.13:40
openstackgerritEric Fried proposed openstack/nova master: Add an example to add more pci devices in nova.conf  https://review.openstack.org/59224313:41
*** cdent has joined #openstack-placement13:45
*** takashin has quit IRC13:58
*** takashin has joined #openstack-placement14:00
openstackgerritClaudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated  https://review.openstack.org/34221114:04
openstackgerritEric Fried proposed openstack/placement master: Make docs build  https://review.openstack.org/60026814:21
openstackgerritVladyslav Drok proposed openstack/nova master: Fix resource tracker updates during instance evacuation  https://review.openstack.org/60042514:22
openstackgerritsean mooney proposed openstack/nova master: add caching to _build_regex_range  https://review.openstack.org/59907114:38
efriedcdent: FYI AJaeger says he's going to propose a patch to cut us over to zuul templates14:40
efriedcdent: in case that was on your soon-list.14:41
cdentefried: awesome, thanks. it was sort of in the back of mind, now that we've got all those jobs14:41
cdentbut he wants to do it, awesome14:41
efriedyeah, your comment said "once we're pretty sure these work" which I think is now.14:41
efriedI like that people are getting involved. Cool to see those patches from kero14:42
cdentyes, very very cool14:42
openstackgerritAndreas Jaeger proposed openstack/placement master: Use templates in .zuul.yaml  https://review.openstack.org/60045914:45
openstackgerritAndreas Jaeger proposed openstack/placement master: Add lower-constraints job  https://review.openstack.org/60046014:47
*** takashin has left #openstack-placement14:53
*** tetsuro has quit IRC14:53
cdentyay!14:54
edleafecdent: efried: are we divvying up the tasks at the bottom of https://etherpad.openstack.org/p/placement-extract-stein-3 yet?15:00
edleafeOr can I just grab one and mark it as being worked on?15:00
cdentedleafe: I think the process is: look at the pending reviews (there aren't many) and start something. Marking it as "taken" is a good idea15:01
edleafecdent: that was my inclination, but just wanted to check15:02
cdentyou happy with that ^ efried ?15:02
cdentedleafe: some of the things listed there already have things in progress but have no marks15:03
edleafeYeah, I noticed that15:03
cdentif you're feeling really enthusiastic...fix it15:04
efriedyes, sounds like a good process15:04
cdentI also added a line in the more general section above about the question of CD, brought on by discussion with jaypipes on https://review.openstack.org/#/c/600157/15:06
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Configure placement DB context manager for nova-manage/status  https://review.openstack.org/60046415:07
cdentman, I really miss those noop gate jobs15:08
edleafeYou know you are a bad programmer when your patch fails the noop jobs15:09
efriededleafe: cdent: I think we should send out an email to the dev ML describing the process in the etherpad and encouraging contributors to pick (and mark) things to work on.15:12
efriedAs I mentioned earlier, I'm encouraged by the contributions I've seen from random people - we should foster that and get some momentum going.15:12
cdenti was gonna do a pupdate tomorrow. either somebody else do it before then, or I'll put it in there15:13
edleafeI'll write something for the ML15:13
efriedthanks ed15:15
edleafesent15:22
*** e0ne has quit IRC15:42
*** vdrok has joined #openstack-placement15:55
openstackgerritEric Fried proposed openstack/nova master: fup: Fix import order and test nit  https://review.openstack.org/60047416:16
*** mriedem is now known as mriedem_away16:19
efriedcdent, edleafe: Is https://etherpad.openstack.org/p/placement-extraction-file-notes obsolete at this point? And/or can it be merged into ...-3?16:27
cdentefried: obsolete and/or done16:28
efriedcool16:28
efriedcleaning up tabs :)16:29
efriedI have... an unreasonable number of them open.16:29
edleafeefried: yeah, it's outlived its usefulness16:29
efriedI prefer "served its purpose"16:29
openstackgerritEric Fried proposed openstack/placement master: Make docs build  https://review.openstack.org/60026816:42
openstackgerritEric Fried proposed openstack/placement master: Use templates in .zuul.yaml  https://review.openstack.org/60045916:42
openstackgerritEric Fried proposed openstack/placement master: Add lower-constraints job  https://review.openstack.org/60046016:42
openstackgerritEric Fried proposed openstack/placement master: Add api-ref job  https://review.openstack.org/59952416:45
openstackgerritEric Fried proposed openstack/placement master: Make docs build  https://review.openstack.org/60026816:45
openstackgerritEric Fried proposed openstack/placement master: Use templates in .zuul.yaml  https://review.openstack.org/60045916:45
openstackgerritEric Fried proposed openstack/placement master: Add lower-constraints job  https://review.openstack.org/60046016:45
cdentefried, edleafe, jaypipes: in case you've missed it jay of cinder has posted a doodle poll for a time to meet with cinder about their thinking about placement16:54
efriedml?16:55
cdentemail at: http://lists.openstack.org/pipermail/openstack-dev/2018-September/134371.html16:55
efriedack16:55
smcginnisJay of Cinder, son of Peter.16:56
edleafecdent: We have the Blazar meeting on Tuesday at 1017:04
edleafeYou have it checked on the doodle17:05
cdentoh, I misread that17:05
cdentI thouht that was the evening17:05
* cdent tries to fix17:05
cdentedleafe: it _is_ pm17:05
cdentoh wait17:05
cdenttimezones17:06
* cdent sighs deeply17:07
*** sean-k-mooney has quit IRC17:09
*** ChanServ sets mode: -rf 17:14
*** e0ne has joined #openstack-placement17:34
*** mriedem_away is now known as mriedem17:41
cdentjaypipes, dansmith : I put a response to you both on https://review.openstack.org/#/c/600157/ with a sort of proposal that I'd like to see dismissed quickly if it unrealistic. I don't really know. mriedem and melwitt you probably interested too17:46
melwittack17:47
melwittthanks17:48
dansmithcdent: I was basically agreeing with you, if it wasn't clear17:48
cdentdansmith: I got that you were agreeing with me on the change in that patch, but wasn't clear on the bigger picture/plan17:50
* mriedem just got back, needs to read this wall of commentage17:51
dansmithcdent: the bigger plan I'm referring to is that we're going to make nova in stein not have its own placement, which I think is the consensus17:51
mriedemi need to shat some stuff into jay's ownership transfer spec before i forget too17:51
dansmiththat's not how it went for things like the nova-volume split17:51
dansmithwhich is my only point there17:52
dansmithI'm trying to say that since we're foregoing the (what I consider) normal upgrade-to-a-split scenario, the conf thing is rather moot17:52
cdentdoes the nova-placement-api vs placement-api thing make any sense? in both senses: did I explain it well enough and is it sensible17:52
cdentbecause if we do that people can choose to carry on as before if they like17:53
dansmithum, I dunno17:53
dansmithI think it's unnecessary17:53
dansmithin that I don't think it addresses the nothing-changed situation sufficiently to be worth the potential confusion17:54
cdentI guess to me it is nothing changed: that placement is on a different import path doesn't change that it is the same as it ever was. I can see how that would not feel like that to everyone but me, however.17:55
dansmithit won't pass grenade, for example17:55
dansmithwell, pip might cheat that for us, I'm not positive17:56
cdentit would if we configured grenader to use nova-placement-api17:56
cdentand make placement a dependency of nova17:56
dansmithif that upgrade pulls in the new placement via pip yeah17:56
dansmithbut to be clear, I'm not going to be satisfied with that scenario ticking the grenade box :)17:57
* cdent nods17:57
cdentI dont' think it is good for grenade but it _might_ be good for some users and that's what I'm trying to fiture out17:57
dansmith*shrug*17:57
dansmithit'd be cheating the db schema too,17:57
dansmithwhich I also think is problematic17:57
dansmithbecause if we renumber the migrations, which I think we shoudl do,17:58
dansmithyou couldn't run placement-manage against the nova-api db without issues17:58
* dansmith has to jump on a call in 70 seconds17:58
cdentis it fair to say "don't do that"?17:59
cdent(in this usage scenario)17:59
dansmithnot imho17:59
cdentpresumably this scenario is only for people who have "reasons"17:59
dansmithI'd say if someone wants to take that risk, they should cook up their own wsgi glue17:59
cdentwell that would certainly be easy enough18:00
*** e0ne has quit IRC18:01
*** openstackgerrit has quit IRC18:05
*** e0ne has joined #openstack-placement18:06
*** e0ne has quit IRC18:08
*** melwitt is now known as melwitt_awaysick18:18
*** openstackgerrit has joined #openstack-placement18:21
openstackgerritEd Leafe proposed openstack/placement master: Remove multiple database scaffolding  https://review.openstack.org/60049718:21
mriedemcdent: jaypipes: dansmith: replied on https://review.openstack.org/#/c/600157/18:29
cdentthanks18:29
mriedemtl;dr let's ask mnaser to weigh in and hold off on merging that until we have an idea of what the grenade change looks like18:29
openstackgerritChris Dent proposed openstack/placement master: Use both unit and functional for coverage testing  https://review.openstack.org/60050118:36
openstackgerritChris Dent proposed openstack/placement master: Add a zuul check job for coverage  https://review.openstack.org/60050218:36
mriedemso besides needing to write placement.conf in grenade before upgrading to stein and starting placement in devstack on the *new* side,18:38
mriedemthe other major thing is dealing with the db migration right?18:38
cdentyes, assuming those are the constraits we're setting18:38
cdenti agree with dansmith that a bash script of mysqldump is likely the fastest thing18:39
mriedemi don't think we want to just copy/rename nova.conf to placement.conf and point placement at nova_api db and say grenade is done18:39
mriedemcdent: yeah agree there too18:39
mriedemi'm just not sure where that script would live18:39
mriedemsince it doesn't exist in nova in rocky18:39
mriedemwe could script it into grenade itself, but then it's not really re-usable by other deployment projects that want to do the same thing18:40
cdenteither in grenade on the "new" side, as part of placement18:40
cdentor perhaps in placement's tools?18:40
mriedemi'm not sure if we have placement installed at that point18:40
cdentwhich point are you thinkign?18:40
mriedemby the time the from_rocky script runs in grenade18:40
cdentgrenade's stages are hard to remember18:40
mriedemyeah, it's in the docs though i think, looking18:41
mriedemhttps://docs.openstack.org/grenade/latest/plugins.html18:41
cdentI suppose I should remember this, I think I wrote one of the first plugins, but damn that was a long time ago18:42
mriedemitem 4 in https://docs.openstack.org/grenade/latest/readme.html#theory-of-upgrade mentions the from-<release> scripts but not when they are run, i mean clearly during the upgrade phase, but18:44
* mriedem digs into code18:44
cdentI got scolded recently by my lovely wife for working too much of late, so I'm going to avoid getting sucked in now, mriedem, but if you are able to put your findings somewhere that would be teh ossum18:45
openstackgerritEd Leafe proposed openstack/placement master: Rename files to remove 'placement'  https://review.openstack.org/60050618:45
mriedemsure, maybe i'll push a grenade docs patch :)18:46
mriedemso uh, i think grenade is broken on master18:56
mriedemhttp://logs.openstack.org/75/585475/12/check/neutron-grenade/254e48b/logs/grenade_localrc.txt.gz18:57
mriedemgrenade on master is running from queens18:57
mriedemrather than rocky18:57
mriedemyikes https://review.openstack.org/#/c/591594/19:01
cdenthmm19:05
cdenttime moves slowly19:05
cdentbut doens't this mean skip level upgrades are working?19:05
*** e0ne has joined #openstack-placement19:05
cdentoh you said that over in nova :)19:05
mriedemi'll shout it from the rooftops19:10
mriedemwe can all go home now, job done19:10
cdentyay19:11
* cdent goes home19:18
cdentgoodnight all19:18
*** cdent has quit IRC19:19
dansmithmriedem: the script should be in placement I think19:35
dansmithtools/bootstrap-from-nova.sh19:35
dansmithmake sure we're using the thing that people will be given,19:35
dansmithnot require them to go fetch it out of grenade19:35
mriedemdansmith: ideally yes, i'm just trying to figure out if we even have placement pip installed by the time we run the from-rocky script19:36
dansmithnot pip installed,19:36
dansmithbut we should have the tree in /opt/stack/new yeah19:37
dansmitheven still,19:37
dansmithyou could make it a placement upgrade step, not a nova one19:37
mriedemok so it looks like we do install from the new side before calling the per-release from-<release> scripts19:44
mriedemso if we put the upgrade scripts in placement, that should work19:44
dansmithwell, even still, it's in /opt/stack if we want to go grab it19:45
dansmithbut yeah19:45
*** e0ne has quit IRC20:02
mriedemso uh, i'm thinking it might be good to maybe recap in the ML some of what came out of today?20:33
mriedemmaybe new thread specific to grenade?20:33
mriedemshall i?20:33
mriedemefried: ^20:33
efriedmriedem: Yes please. I still don't understand upgrade/grenade well enough to speak about it.20:34
*** nicolasbock has quit IRC20:34
*** nicolasbock has joined #openstack-placement20:54
*** dims has quit IRC20:55
mriedemefried: done20:58
efriedthanks dood20:58
*** dims has joined #openstack-placement21:11
openstackgerritEric Fried proposed openstack/placement master: De-nova-ify and reformat contributor guide  https://review.openstack.org/59986421:20
*** mriedem is now known as mriedem_away22:02
*** mriedem_away has quit IRC22:02
openstackgerritMerged openstack/nova-specs master: Add serial numbers for local disks  https://review.openstack.org/59524722:05
*** rubasov has quit IRC23:42
*** rubasov has joined #openstack-placement23:47

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!