Friday, 2018-07-20

*** smcginnis[m] has quit IRC00:10
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9)  https://review.openstack.org/57558100:46
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10)  https://review.openstack.org/57601700:46
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11)  https://review.openstack.org/57601800:46
*** smcginnis[m] has joined #openstack-placement00:51
openstackgerritZhenyu Zheng proposed openstack/nova master: Add regression test for bug 1781880  https://review.openstack.org/58392701:11
openstackbug 1781880 in OpenStack Compute (nova) "nova service-list for new compute service causes TypeError with servicegroup_driver mc " [Medium,In progress] https://launchpad.net/bugs/1781880 - Assigned to Zhenyu Zheng (zhengzhenyu)01:11
openstackgerritZhenyu Zheng proposed openstack/nova master: Fix nova service-list for new compute service causes TypeError  https://review.openstack.org/58393601:12
openstackgerritZhenyu Zheng proposed openstack/nova master: Fix nova service-list for new compute service causes TypeError  https://review.openstack.org/58393601:12
openstackgerritGhanshyam Mann proposed openstack/nova master: Remove stevedore extensions server_create method  https://review.openstack.org/58388201:21
*** mriedem_away has quit IRC01:31
openstackgerritGhanshyam Mann proposed openstack/nova master: Use Tempest scenario job to run all scenario tests including slow  https://review.openstack.org/56769701:34
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12)  https://review.openstack.org/57601901:51
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13)  https://review.openstack.org/57602001:51
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14)  https://review.openstack.org/57602701:51
openstackgerritmelanie witt proposed openstack/nova master: DNM: Don't overwrite greenthread-local context in target_cell  https://review.openstack.org/58233202:08
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge extended availability zone controller  https://review.openstack.org/58419702:09
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge extended availability zone controller  https://review.openstack.org/50285902:13
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge extended availability zone response into server controller  https://review.openstack.org/50285902:16
openstackgerritfupingxie proposed openstack/nova master: Delete allocations when it is re-allocated  https://review.openstack.org/58289902:19
openstackgerritZhenyu Zheng proposed openstack/nova master: Report 0 root_gb in resource tracker if instance is bfv.  https://review.openstack.org/58420402:42
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15)  https://review.openstack.org/57603102:55
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16)  https://review.openstack.org/57629902:56
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17)  https://review.openstack.org/57634402:56
*** lei-zh has joined #openstack-placement03:09
*** lei-zh1 has joined #openstack-placement03:27
*** lei-zh has quit IRC03:30
openstackgerritfupingxie proposed openstack/nova master: Trivial: Fix spelling error  https://review.openstack.org/58421203:35
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Consider forbidden traits in early exit of _get_by_one_request  https://review.openstack.org/58421804:14
*** lei-zh1 has quit IRC04:16
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge config drive extension response into server controller  https://review.openstack.org/58422304:55
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18)  https://review.openstack.org/57667304:59
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19)  https://review.openstack.org/57667604:59
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20)  https://review.openstack.org/57668905:00
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21)  https://review.openstack.org/57670905:10
*** lei-zh1 has joined #openstack-placement05:20
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge config drive extension response into server controller  https://review.openstack.org/58422305:32
openstackgerritfupingxie proposed openstack/nova master: Delete allocations when it is re-allocated  https://review.openstack.org/58289905:48
openstackgerritZhenyu Zheng proposed openstack/nova master: Update installation guide to be more clear about cellsv2  https://review.openstack.org/58424406:44
*** rubasov has quit IRC07:07
*** rubasov has joined #openstack-placement07:07
*** e0ne has joined #openstack-placement07:13
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Consider forbidden traits in early exit of _get_by_one_request  https://review.openstack.org/58421807:21
*** lei-zh1 has quit IRC07:23
*** peereb has joined #openstack-placement07:26
*** tssurya has joined #openstack-placement08:05
*** lei-zh1 has joined #openstack-placement08:07
openstackgerritZhenyu Zheng proposed openstack/nova master: Report 0 root_gb in resource tracker if instance is bfv.  https://review.openstack.org/58420408:19
openstackgerritzhufl proposed openstack/nova master: Fix missing print format error  https://review.openstack.org/58427708:32
openstackgerritLei Zhang proposed openstack/nova master: Add method to get cpu traits  https://review.openstack.org/56031708:39
openstackgerritZhenyu Zheng proposed openstack/nova master: Add regression test for bug 1781880  https://review.openstack.org/58392708:49
openstackbug 1781880 in OpenStack Compute (nova) "nova service-list for new compute service causes TypeError with servicegroup_driver mc " [Medium,In progress] https://launchpad.net/bugs/1781880 - Assigned to Zhenyu Zheng (zhengzhenyu)08:49
*** takashin has quit IRC09:02
*** lei-zh1 has quit IRC09:08
*** cdent has joined #openstack-placement09:13
*** takashin has joined #openstack-placement09:15
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Update launch-from-volume doc to latest version.  https://review.openstack.org/57224109:20
openstackgerritZhenyu Zheng proposed openstack/nova master: Add regression test for bug 1781880  https://review.openstack.org/58392709:28
openstackbug 1781880 in OpenStack Compute (nova) "nova service-list for new compute service causes TypeError with servicegroup_driver mc " [Medium,In progress] https://launchpad.net/bugs/1781880 - Assigned to Zhenyu Zheng (zhengzhenyu)09:28
openstackgerritZhenyu Zheng proposed openstack/nova master: Add regression test for bug 1781880  https://review.openstack.org/58392709:36
openstackbug 1781880 in OpenStack Compute (nova) "nova service-list for new compute service causes TypeError with servicegroup_driver mc " [Medium,In progress] https://launchpad.net/bugs/1781880 - Assigned to Zhenyu Zheng (zhengzhenyu)09:36
*** smcginnis[m] has quit IRC09:43
*** smcginnis[m] has joined #openstack-placement09:49
openstackgerritdo3meli proposed openstack/nova master: docs: add nova host-evacuate command to evacuate documentation  https://review.openstack.org/57804009:52
*** takashin_ has joined #openstack-placement10:10
*** takashin has quit IRC10:12
openstackgerritChris Dent proposed openstack/nova master: [placement] Add /reshaper handler for POST  https://review.openstack.org/57692710:52
*** jaypipes is now known as leakypipes11:32
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Start populating NUMACell.network_metadata field  https://review.openstack.org/56444111:34
openstackgerritStephen Finucane proposed openstack/nova master: Add functional tests for numa-aware-vswitches  https://review.openstack.org/58328811:34
openstackgerritStephen Finucane proposed openstack/nova master: scheduler: Start utilizing RequestSpec.network_metadata  https://review.openstack.org/56445211:34
openstackgerritStephen Finucane proposed openstack/nova master: Assorted cleanups from numa-aware-vswitches series  https://review.openstack.org/58265111:34
*** stephenfin is now known as finucannot11:34
*** avolkov has joined #openstack-placement11:38
*** lei-zh has joined #openstack-placement11:43
*** avolkov has quit IRC11:52
openstackgerritLei Zhang proposed openstack/nova master: Add method to get cpu traits  https://review.openstack.org/56031711:57
openstackgerritAndrey Volkov proposed openstack/nova master: Docs: Add Placement to Nova system architecture  https://review.openstack.org/58433812:05
*** lei-zh has quit IRC12:07
openstackgerritAndrey Volkov proposed openstack/nova master: Docs: Add more colors to Nova system architecture  https://review.openstack.org/58434512:25
*** mriedem has joined #openstack-placement12:36
*** edmondsw has joined #openstack-placement12:42
mriedemefried: looks like the retry tests in https://review.openstack.org/#/c/556669/ aren't happy12:43
mriedemnot sure what might be causing that12:43
*** takashin_ has left #openstack-placement12:45
*** edleafe is now known as figleaf12:46
*** lei-zh has joined #openstack-placement12:54
*** tssurya has quit IRC12:55
openstackgerritCorey Bryant proposed openstack/nova master: In Python3.7 async is a keyword [1]  https://review.openstack.org/58436513:07
*** lei-zh has quit IRC13:10
*** lei-zh has joined #openstack-placement13:10
*** avolkov has joined #openstack-placement13:17
*** rubasov has quit IRC13:34
*** rubasov has joined #openstack-placement13:35
efriedmriedem: Yeah, I think I noticed that yesterday, that zuul failed that test but it was fine locally.13:37
openstackgerritAndrey Volkov proposed openstack/nova master: Docs: Add more colors to Nova system architecture  https://review.openstack.org/58434513:37
efriedmriedem: ...and with only debug logging from RetryDecorator...13:50
efriedmriedem: ah, got a local repro - it's something about timing among the multiple tests using that decorator. Methinks there's a threading leak there.13:55
mriedemRetryDecorator does use looping call which uses threads yeah14:03
*** dansmith is now known as superdan14:04
*** tssurya has joined #openstack-placement14:04
mriedemcould try stubbing out greenthread.spawn() and/or sleep() to make them synchronous14:04
mriedemlike our SpawnIsSynchronous fixture14:04
*** peereb has quit IRC14:05
mriedemhttps://github.com/openstack/oslo.service/blob/master/oslo_service/loopingcall.py#L11814:05
efriedmriedem: I flipped those log messages from debug to error (so they would actually be emitted) and reproduced: http://paste.openstack.org/show/726348/14:14
efriedYou'll notice that the method was only invoked once, but the retry counter somehow got to 3 anyway.14:14
mriedemnote you can also run with OS_DEBUG=True to get debug logging in tests14:17
mriedemtry stubbing out greenthread and see if you can reproduce14:18
mriedemultimately if RetryDecorator is more pain than it's worth we could just add the thing you had back in which doesn't rely on timeouts or threading14:18
mriedemi just figured, re-use tools that are available if possible14:19
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Start populating NUMACell.network_metadata field  https://review.openstack.org/56444114:19
openstackgerritStephen Finucane proposed openstack/nova master: Add functional tests for numa-aware-vswitches  https://review.openstack.org/58328814:19
openstackgerritStephen Finucane proposed openstack/nova master: scheduler: Start utilizing RequestSpec.network_metadata  https://review.openstack.org/56445214:19
openstackgerritStephen Finucane proposed openstack/nova master: Assorted cleanups from numa-aware-vswitches series  https://review.openstack.org/58265114:19
*** tssurya has quit IRC14:30
*** efried is now known as fried_rice14:32
openstackgerritLei Zhang proposed openstack/nova master: Add method to get cpu traits  https://review.openstack.org/56031714:32
fried_ricemriedem: Still able to repro after mocking greenthread. Which means it's probably a global in oslo.service?14:36
mriedemnot sure14:38
mriedemwhat did you mock? spawn, sleep or both?14:38
fried_ricemriedem: I monkey patched eventlet.greenthread.spawn with _FakeGreenThread from nova.tests.fixtures14:41
fried_riceI'm going to try `retrying`14:42
fried_riceif I can figure out how the f'ing thing works again.14:43
fried_riceIt's complicated and not documented.14:43
mriedemok not sure if mocking spawn() is enough or if sleep() would also need to be mocked to avoid switching greenthreads14:45
fried_ricetrying...14:50
fried_ricenope14:53
fried_riceI had thought we used retrying in pypowervm, but now I see we rolled our own after all.14:56
fried_riceah, we used it in nova-powervm14:57
mriedemfried_rice: we have retrying in nova's requirements.txt14:59
mriedemso something is using it14:59
*** e0ne has quit IRC14:59
fried_riceyes, powervm :)14:59
mriedemso maybe that's a better option for this14:59
fried_riceyeah, investigating. Like I said, it's really complicated and not documented.14:59
mriedemit's at least not using threads15:00
mriedemhmm, it also hasn't been released since 201415:00
mriedemanywho15:01
fried_riceClearly it's perfect and doesn't need any changes.15:01
*** lei-zh has quit IRC15:02
*** e0ne has joined #openstack-placement15:05
*** e0ne has quit IRC15:06
*** e0ne has joined #openstack-placement15:06
*** lei-zh has joined #openstack-placement15:07
openstackgerritEric Fried proposed openstack/nova master: Check provider generation and retry on conflict  https://review.openstack.org/55666915:10
fried_ricemriedem, leakypipes: With @retrying.retry instead ^15:10
leakypipesack, on it.15:12
mriedemi'll wait for zuul results15:29
*** cdent has quit IRC15:31
*** mriedem is now known as mriedem_lunch15:43
*** lei-zh has quit IRC15:45
*** cdent has joined #openstack-placement15:51
openstackgerritStephen Finucane proposed openstack/nova master: Add functional tests for numa-aware-vswitches  https://review.openstack.org/58328815:56
openstackgerritStephen Finucane proposed openstack/nova master: scheduler: Start utilizing RequestSpec.network_metadata  https://review.openstack.org/56445215:56
openstackgerritStephen Finucane proposed openstack/nova master: Assorted cleanups from numa-aware-vswitches series  https://review.openstack.org/58265115:56
*** lei-zh has joined #openstack-placement15:56
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove reference to transient domain when detaching devices  https://review.openstack.org/58443316:00
*** e0ne has quit IRC16:14
openstackgerritCorey Bryant proposed openstack/nova master: In Python3.7 async is a keyword [1]  https://review.openstack.org/58436516:21
*** fried_rice is now known as fried_rolls16:24
openstackgerritStephen Finucane proposed openstack/nova master: scheduler: Start utilizing RequestSpec.network_metadata  https://review.openstack.org/56445216:25
openstackgerritStephen Finucane proposed openstack/nova master: Assorted cleanups from numa-aware-vswitches series  https://review.openstack.org/58265116:25
openstackgerritPierre Blanc proposed openstack/nova master: Docs: Add guide to migrate instance with snapshot  https://review.openstack.org/58444216:33
*** tssurya has joined #openstack-placement16:41
*** lei-zh has quit IRC16:48
*** cdent has quit IRC16:52
*** mriedem_lunch is now known as mriedem17:50
*** tssurya has quit IRC18:02
*** tssurya has joined #openstack-placement18:14
*** e0ne has joined #openstack-placement18:18
mriedemfried_rolls: leakypipes: +2 on https://review.openstack.org/#/c/556669/ - zuul is happy now18:23
mriedemfried_rolls: thanks for the persistence18:23
*** fried_rolls is now known as fried_rice18:38
fried_riceThanks mriedem18:38
*** tssurya has quit IRC18:58
*** tssurya has joined #openstack-placement19:00
*** e0ne has quit IRC19:08
fried_riceleakypipes: Would you please re-bless https://review.openstack.org/#/c/556669/ ?19:11
*** tssurya has quit IRC19:16
*** tssurya has joined #openstack-placement19:16
*** edmondsw has quit IRC19:19
*** edmondsw has joined #openstack-placement19:20
*** e0ne has joined #openstack-placement19:26
*** edmondsw has quit IRC19:26
leakypipesfried_rice: yes. it's next in line after mriedem's fix for the gate issue thing19:35
fried_riceFine, I guess I can wait behind a gate fix <rolls eyes>19:36
leakypipesfried_rice: honestly, all the server group and alternate hosts code makes my head hurt. takes three times as long for me to go through it, line by line, trying to keep it all in my head. :(19:38
fried_riceleakypipes: Wait til I get done with gibi's patch to introduce 1.28.19:38
leakypipesfried_rice: that's ten times easier for me to comprehend than the whole server group filters mess.19:39
mriedemleakypipes: just trust in the functional tests...19:39
leakypipesmriedem: at the end of the day, yeah, that's kind what I gotta do. :(19:39
mriedemthat's why i've started writing more and more functional tests for anything in the last year or so,19:41
mriedembecause i just don't really trust unit tests anymore19:41
mriedemwell,19:41
mriedemnot for anything that involves more than 1 nova service19:41
openstackgerritMatt Riedemann proposed openstack/nova master: compute: Ensure pre-migrating instances are destroyed during init_host  https://review.openstack.org/56228419:46
leakypipesmriedem, fried_rice: +Wallaby'd both.19:49
fried_ricethanks leakypipes19:49
mriedemthanks19:50
openstackgerritDan Smith proposed openstack/nova master: Online data migration for queued_for_delete flag  https://review.openstack.org/58450419:54
*** edmondsw has joined #openstack-placement20:20
openstackgerritPierre Blanc proposed openstack/nova master: Docs: Add guide to migrate instance with snapshot  https://review.openstack.org/58444220:33
openstackgerritDan Smith proposed openstack/nova master: Online data migration for queued_for_delete flag  https://review.openstack.org/58450420:34
*** smcginnis[m] has quit IRC21:16
*** e0ne has quit IRC21:27
*** e0ne has joined #openstack-placement21:27
*** e0ne has quit IRC21:30
*** figleaf is now known as edleafe21:41
*** avolkov has quit IRC21:45
openstackgerritEric Fried proposed openstack/nova master: docs: add nova host-evacuate command to evacuate documentation  https://review.openstack.org/57804022:05
*** smcginnis[m] has joined #openstack-placement22:05
*** fried_rice is now known as efried22:09
leakypipesefried: have you noticed this? https://bugs.launchpad.net/nova/+bug/178285122:13
openstackLaunchpad bug 1782851 in OpenStack Compute (nova) "Running tox -efast8 no longer works due to zVMConnector installation issues" [Undecided,New]22:13
efriedleakypipes: Yeah, the z stuff really effed up local tox runs.22:14
efriedleakypipes: What py3 are you running?22:14
leakypipesefried: does it matter? everything should be isolated to a venv, no?22:14
efriedleakypipes: There's a couple existing bugs & patches to fix this.22:15
leakypipesin any case...22:15
leakypipes[jaypipes@uberbox nova]$ python --version22:15
leakypipesPython 2.7.1422:15
leakypipes[jaypipes@uberbox nova]$ python3 --version22:15
leakypipesPython 3.6.322:15
leakypipesefried: ^22:15
efriedright, the lib doesn't support py3622:15
leakypipeswhat is our upstream CI on? isn't it on 3.6?22:16
efriedleakypipes: https://review.openstack.org/#/c/584016/ https://review.openstack.org/#/c/584031/ https://review.openstack.org/#/c/584014/ https://bugs.launchpad.net/designate/+bug/178260422:16
openstackLaunchpad bug 1782604 in OpenStack Compute (nova) "designate-bind9-py36 gate is failing due to python-zvm-sdk" [Undecided,In progress]22:16
efriedI think we're still at py35 in the gate.22:16
efriedleakypipes: I wish dansmith or mikal or someone had warned us about problems like this. http://lists.openstack.org/pipermail/openstack-dev/2018-April/129294.html http://lists.openstack.org/pipermail/openstack-dev/2018-April/129350.html22:17
efriedhttp://lists.openstack.org/pipermail/openstack-dev/2018-April/129350.html22:18
efriedhttps://github.com/mfcloud/python-zvm-sdk/pull/722:18
leakypipesefried: who is "mfcloud"?22:19
efriedwhere?22:19
leakypipesefried: the organization on github is called "mfcloud".22:19
efriedoh22:20
efriedno idea22:20
leakypipesMuthaFriggin Cloud, MuthaF**kas.22:20
efriedthat was my first thought, obviously.22:20
leakypipesefried: thank goodness we're pulling in a required library from an organization we have no clue about.22:20
leakypipesefried: that DEFINITELY won't end poorly.22:21
efriedleakypipes: Your sarcasm is noted22:21
efriedand appreciated22:21
leakypipes:P22:21
efriedSee the ML links above - we were warned. I think you may have weighed in on that thread too at some point.22:21
efriedI'm dead here, gonna leave before I damage code or offend someone. Have a good weekend.    ō/22:22
leakypipesciao22:22
*** tssurya has quit IRC22:52
*** alex_xu has quit IRC22:53
*** alex_xu has joined #openstack-placement23:00

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!