Thursday, 2018-07-19

*** tetsuro has joined #openstack-placement00:00
*** takashin has joined #openstack-placement00:06
*** alex_xu has quit IRC00:57
*** alex_xu has joined #openstack-placement01:02
openstackgerritMatt Riedemann proposed openstack/nova master: Use consumer generation in _heal_allocations_for_instance  https://review.openstack.org/57790501:06
*** alex_xu has quit IRC01:47
*** alex_xu has joined #openstack-placement01:48
openstackgerritTakashi NATSUME proposed openstack/nova master: Making consistent used of GiB and MiB in API ref  https://review.openstack.org/55998501:52
*** lei-zh has joined #openstack-placement01:58
openstackgerritMatt Riedemann proposed openstack/nova master: Add encrypted volume support to feature matrix docs  https://review.openstack.org/57025502:21
openstackgerritMatt Riedemann proposed openstack/nova master: Remove support for /os-floating-ips-bulk REST API  https://review.openstack.org/58291202:23
openstackgerritMatt Riedemann proposed openstack/nova master: Remove support for /os-floating-ip-dns REST API  https://review.openstack.org/58294302:23
openstackgerritMatt Riedemann proposed openstack/nova master: Remove "DEPRECATED" tag from Obsolete APIs  https://review.openstack.org/58309202:23
*** mriedem has quit IRC02:25
openstackgerritfupingxie proposed openstack/nova master: Delete allocations when it is re-allocated  https://review.openstack.org/58289902:42
*** takashin has left #openstack-placement03:04
openstackgerritGhanshyam Mann proposed openstack/nova master: Use Tempest scenario job to run all scenario tests  https://review.openstack.org/58384004:20
openstackgerritGhanshyam Mann proposed openstack/nova master: Use Tempest scenario job to run all scenario tests  https://review.openstack.org/58384004:35
*** lei-zh has quit IRC05:11
openstackgerritGhanshyam Mann proposed openstack/nova master: Fix ServerMigrationSampleJsonTests to use sample files from version dir  https://review.openstack.org/58270205:13
*** tetsuro has quit IRC05:23
*** efried has quit IRC05:29
*** bauzas has quit IRC05:30
*** bauzas has joined #openstack-placement05:35
*** efried has joined #openstack-placement05:38
*** lei-zh has joined #openstack-placement05:45
openstackgerritfupingxie proposed openstack/nova master: Delete allocations when it is re-allocated  https://review.openstack.org/58289905:47
*** tetsuro has joined #openstack-placement05:58
*** efried has quit IRC06:11
*** efried has joined #openstack-placement06:11
*** e0ne has joined #openstack-placement06:20
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge server create for config_drive extension  https://review.openstack.org/58353806:35
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge server create for bdm extensions  https://review.openstack.org/58355906:38
openstackgerritChen proposed openstack/nova master: Fix soft deleting vm fails after "nova resize" vm  https://review.openstack.org/54692006:51
*** peereb has joined #openstack-placement07:02
*** avolkov has joined #openstack-placement07:02
*** openstackgerrit has quit IRC07:04
*** rubasov has quit IRC07:24
*** tssurya has joined #openstack-placement07:33
*** openstackgerrit has joined #openstack-placement07:48
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge server create for bdm extensions  https://review.openstack.org/58355907:48
openstackgerritGhanshyam Mann proposed openstack/nova master: Remove stevedore extensions server_create method  https://review.openstack.org/58388208:20
openstackgerritfupingxie proposed openstack/nova master: Delete allocations when it is re-allocated  https://review.openstack.org/58289908:25
*** tetsuro has quit IRC08:30
openstackgerritsahid proposed openstack/nova master: hardware: fix memory check usage for small/large pages  https://review.openstack.org/53216808:31
*** bauzas has left #openstack-placement08:39
openstackgerritVishakha Agarwal proposed openstack/nova master: 'Updated_at' is NULL when show aggregate info  https://review.openstack.org/58027108:40
*** avolkov has quit IRC09:05
openstackgerritLei Zhang proposed openstack/nova master: Add method to get cpu traits  https://review.openstack.org/56031709:17
openstackgerritLei Zhang proposed openstack/nova master: Docs for reporting CPU traits feature  https://review.openstack.org/58290209:17
*** tetsuro has joined #openstack-placement09:18
*** tetsuro has quit IRC09:23
*** cdent has joined #openstack-placement09:24
openstackgerritChris Dent proposed openstack/nova master: [placement] disallow additional fiels in allocations  https://review.openstack.org/58390709:46
openstackgerritChris Dent proposed openstack/nova master: [placement] disallow additional fields in allocations  https://review.openstack.org/58390709:46
*** alex_xu has quit IRC10:03
*** peereb has quit IRC10:06
*** alex_xu has joined #openstack-placement10:08
openstackgerritZhenyu Zheng proposed openstack/nova master: Add regression test for bug 1781880  https://review.openstack.org/58392710:57
openstackbug 1781880 in OpenStack Compute (nova) "nova service-list for new compute service causes TypeError with servicegroup_driver mc " [Medium,Triaged] https://launchpad.net/bugs/1781880 - Assigned to Zhenyu Zheng (zhengzhenyu)10:57
openstackgerritLei Zhang proposed openstack/nova master: Add method to get cpu traits  https://review.openstack.org/56031711:03
*** lei-zh has quit IRC11:11
openstackgerritZhenyu Zheng proposed openstack/nova master: Add regression test for bug 1781880  https://review.openstack.org/58392711:12
openstackbug 1781880 in OpenStack Compute (nova) "nova service-list for new compute service causes TypeError with servicegroup_driver mc " [Medium,Triaged] https://launchpad.net/bugs/1781880 - Assigned to Zhenyu Zheng (zhengzhenyu)11:12
openstackgerritZhenyu Zheng proposed openstack/nova master: Add regression test for bug 1781880  https://review.openstack.org/58392711:47
openstackbug 1781880 in OpenStack Compute (nova) "nova service-list for new compute service causes TypeError with servicegroup_driver mc " [Medium,Triaged] https://launchpad.net/bugs/1781880 - Assigned to Zhenyu Zheng (zhengzhenyu)11:47
openstackgerritZhenyu Zheng proposed openstack/nova master: Fix nova service-list for new compute service causes TypeError  https://review.openstack.org/58393611:50
*** rubasov has joined #openstack-placement12:05
*** rubasov has quit IRC12:11
openstackgerritdo3meli proposed openstack/nova master: docs: add nova host-evacuate command to evacuate documentation  https://review.openstack.org/57804012:13
*** rubasov has joined #openstack-placement12:27
*** cdent has quit IRC12:27
*** edmondsw has joined #openstack-placement12:41
*** mriedem has joined #openstack-placement12:53
-openstackstatus- NOTICE: logs.openstack.org is offline, causing POST_FAILURE results from Zuul. Cause and resolution timeframe currently unknown.12:57
*** ChanServ changes topic to "logs.openstack.org is offline, causing POST_FAILURE results from Zuul. Cause and resolution timeframe currently unknown."12:57
*** rubasov has quit IRC13:08
*** rubasov has joined #openstack-placement13:09
*** avolkov has joined #openstack-placement13:17
openstackgerritEric Fried proposed openstack/nova master: Disable limits if force_hosts or force_nodes is set  https://review.openstack.org/57669313:22
*** rubasov has quit IRC13:23
*** rubasov has joined #openstack-placement13:24
*** rubasov has quit IRC13:24
*** rubasov has joined #openstack-placement13:25
*** rubasov has quit IRC13:25
*** rubasov has joined #openstack-placement13:25
*** cdent has joined #openstack-placement13:26
*** cdent has quit IRC13:26
*** cdent has joined #openstack-placement13:31
openstackgerritMatt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron  https://review.openstack.org/55633413:34
openstackgerritMatt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration  https://review.openstack.org/51542313:34
openstackgerritMatt Riedemann proposed openstack/nova master: Add VIFMigrateData.get_dest_vif  https://review.openstack.org/56693113:34
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: factor out pre_live_migration plug_vifs call  https://review.openstack.org/56693213:34
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: use dest host port bindings during pre_live_migration  https://review.openstack.org/56693313:34
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: use dest host vif migrate details for live migration  https://review.openstack.org/55137013:34
openstackgerritMatt Riedemann proposed openstack/nova master: Annotate flows and handle PortBindingDeletionFailed in ComputeManager  https://review.openstack.org/55137113:34
openstackgerritMatt Riedemann proposed openstack/nova master: Port binding based on events during live migration  https://review.openstack.org/43487013:34
openstackgerritMatt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate  https://review.openstack.org/52253713:34
*** rubasov has quit IRC13:39
*** rubasov has joined #openstack-placement13:39
*** ChanServ changes topic to "See https://docs.openstack.org/nova/latest/user/placement.html and https://developer.openstack.org/api-ref/placement/"13:40
-openstackstatus- NOTICE: logs.openstack.org is back on-line. Changes with "POST_FAILURE" job results should be rechecked.13:40
*** rubasov has quit IRC13:41
*** rubasov has joined #openstack-placement13:41
*** e0ne has quit IRC13:42
*** rubasov has quit IRC13:53
*** rubasov has joined #openstack-placement13:54
openstackgerritEric Fried proposed openstack/nova master: Disable limits if force_hosts or force_nodes is set  https://review.openstack.org/57669313:57
openstackgerritMatt Riedemann proposed openstack/nova master: Disable limits if force_hosts or force_nodes is set  https://review.openstack.org/57669314:05
*** e0ne has joined #openstack-placement14:21
openstackgerritEric Fried proposed openstack/nova master: Docs for reporting CPU traits feature  https://review.openstack.org/58290214:30
openstackgerritdo3meli proposed openstack/nova master: docs: add nova host-evacuate command to evacuate documentation  https://review.openstack.org/57804014:39
*** lei-zh has joined #openstack-placement14:53
*** lei-zh1 has joined #openstack-placement14:53
*** lei-zh has quit IRC15:04
*** e0ne has quit IRC15:06
openstackgerritStephen Finucane proposed openstack/nova master: tests: Validate huge pages  https://review.openstack.org/39965315:27
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: create functional test base class  https://review.openstack.org/40705515:27
openstackgerritMatt Riedemann proposed openstack/nova master: Fix accumulated nits from port binding for live migration series  https://review.openstack.org/58399415:34
*** alex_xu has quit IRC15:42
*** tssurya has quit IRC15:46
*** alex_xu has joined #openstack-placement15:47
openstackgerritBalazs Gibizer proposed openstack/nova master: Use placement 1.28 in scheduler report client  https://review.openstack.org/58366716:22
openstackgerritMatt Riedemann proposed openstack/nova master: Skip test_resize_server_revert_with_volume_attached in nova-lvm  https://review.openstack.org/58401816:22
gibiefried, cdent: I've followed your guidance and I think the result is cleaner in https://review.openstack.org/58366716:25
cdentgibi: cool, will look soon16:29
*** markguz_ has joined #openstack-placement16:54
*** edmondsw has quit IRC17:13
openstackgerritGraham Hayes proposed openstack/nova master: Do not install zVMCloudConnector in poy36  https://review.openstack.org/58403117:17
*** edmondsw has joined #openstack-placement17:18
openstackgerritArtom Lifshitz proposed openstack/nova master: DNM: extra logging for 1775947  https://review.openstack.org/58403217:28
*** edmondsw has quit IRC18:03
openstackgerritLei Zhang proposed openstack/nova master: Add method to get cpu traits  https://review.openstack.org/56031718:08
*** lei-zh1 has quit IRC18:17
openstackgerritMatt Riedemann proposed openstack/nova master: Do not install zVMCloudConnector in py36  https://review.openstack.org/58403118:25
*** edmondsw has joined #openstack-placement18:31
*** sean-k-mooney has quit IRC18:49
openstackgerritMatt Riedemann proposed openstack/nova master: Add regression test for bug 1781710  https://review.openstack.org/58333918:50
openstackbug 1781710 in OpenStack Compute (nova) "ServersOnMultiNodesTest.test_create_server_with_scheduler_hint_group_anti_affinity failing with "Servers are on the same host"" [High,Fix released] https://launchpad.net/bugs/1781710 - Assigned to Matt Riedemann (mriedem)18:50
openstackgerritMatt Riedemann proposed openstack/nova master: Update RequestSpec.instance_uuid during scheduling  https://review.openstack.org/58334718:50
*** avolkov has quit IRC19:04
*** avolkov has joined #openstack-placement19:11
mriedemefried: ok comments in https://review.openstack.org/#/c/556669/19:43
efriedthx19:43
mriedemlemme know if/when you want to talk about some of those19:43
mriedemsince they aren't all -1s19:43
mriedemi think we should definitely not write our own retry decorator19:45
mriedemi also generally don't love returning tuples from methods just because you have to always lookup what is being returned and in what order19:47
mriedemunless people are big on the tuple thing, i'd say we just return the response body from GET provider aggregates and GET provider traits19:47
*** e0ne has joined #openstack-placement19:50
efriednoted19:50
openstackgerritChris Dent proposed openstack/nova master: WIP POC: Use os-resource-classes in placement  https://review.openstack.org/58408419:54
openstackgerritChris Dent proposed openstack/nova master: [placement] Move resource_class_cache into placement hierarchy  https://review.openstack.org/58408519:54
openstackgerritChris Dent proposed openstack/nova master: [placement] ensure_rc_cache only at start of process  https://review.openstack.org/58408619:54
cdentjaypipes, efried, edleafe ^ that is a proof of concept of a different os-resource-classes (lighter) integrated into the placement side19:54
jaypipesok, thx cdent19:55
efriedack19:55
cdentwe need to decide if we like the "just fix it" version of the allocations schema: https://review.openstack.org/#/c/583907/19:55
cdentif so we can get that merge, or based into the stat of the reshaper stack19:55
cdentstart19:55
*** e0ne has quit IRC19:57
efriedmriedem: The tuple thing is so callers don't have to duplicate the code to process the results. The "look up what is being returned" argument doesn't really fly because if it's a dict, you gotta look up the dict format anyway. The difference with the consumers is that there's more than one thing on the outer part of the dict (would have to return a 4-tuple of consumer_gen, proj_id, user_id, allocations, which I agree20:00
mriedemsure, but then if we add new things to the response for aggregates and traits, we'll either add more stuff to the tuple or convert it to the dict format anyway,20:01
mriedemi'm fine with looking up the dict from the the response body b/c it's in the api ref and matches that20:01
mriedemthe tuple is whatever order you put them in20:01
mriedemunless you use a namedtuple or something20:01
efriedmriedem: We're also converting the list to a set20:01
mriedemdoes it need to be a set?20:02
mriedemcan you have duplicates on the placement side?20:02
efriedWithout refactoring the callers further20:02
efriedit's not about duplicates on the placement side; it's about what we're doing with the results, which can include unions/intersections with other sets.20:02
mriedemi.e. GET /resource_providers/{rp_uuid}/aggregates shouldn't return aggregates=[20:02
mriedem1,2,2] right?20:02
efriedright, see ^20:02
efriedIt can be done, it's just more refactor-creep in a patch that's already pretty loosely scoped and fuzzy around the edges.20:03
mriedemlemme look at the usage again20:03
mriedemdoes it need to be a set because of update_aggregates and update_traits in provider tree?20:04
mriedemmust not b/c provider tree casts to a set20:05
efriedaggregate_add_host and aggregate_remove_host do set math on it.20:06
efriedlike I said, I can change those to cast as well.20:06
mriedemok new_aggs = existing_aggs | set([agg_uuid])20:07
mriedemi'm fine with the tuples, i see jaypipes wanted that as well20:07
mriedemwe/i can do namedtuples down the line if it really becomes hard to maintain20:07
efriedsounds good. still working through other comments...20:07
mriedemi also noted (not with comments) that we have that @retries decorator, but that returns False if the retries get exhausted, which is different from the decorator you added and the RetryDecorator in oslo20:08
efriedYeah, that @retries decorator I am *not* a fan of, for exactly that reason (returns False)20:09
mriedembut RetryDecorator will do exactly what you added20:09
mriedemplus it makes julienne cuts20:09
cdentdoes it spiralize?20:10
efriedyeah, considered using `retrying`.  Will look into the oslo thingy.20:10
jaypipesmriedem: I prefer namedtuples. it's what I've used in the object file for tracking things like internal IDs vs. external or root IDs for providers.20:11
mriedemif you're gonna tuple, you might as well namedtuple20:12
mriedemi always say20:12
mriedemi tell maya that before bed every night20:12
mriedemalso, unrelated, but while i'm venting, jesus f'ing christ zuul is driving me nuts this week20:15
mriedemi recheck a thing for 3 days just to have to rebase it b/c it won't enter the gate queue20:15
* mriedem goes to infra20:16
* cdent goes to the cupboard20:18
cdentgoodnight20:18
*** cdent has quit IRC20:18
openstackgerritMerged openstack/nova master: Implement migrate_instance_start method for neutron  https://review.openstack.org/55633420:20
mriedemholy god yes20:20
openstackgerritArtom Lifshitz proposed openstack/nova master: DNM: extra logging for 1775947  https://review.openstack.org/58403220:26
efriedWhere are we on making @safe_connect die die DIE?20:35
*** takashin has joined #openstack-placement20:46
mriedemis that a metallica reference of a misfits cover?20:50
openstackgerritEric Fried proposed openstack/nova master: Check provider generation and retry on conflict  https://review.openstack.org/55666920:55
efriedmriedem, jaypipes: Howzat ^20:55
mriedemwill look after the meeting20:56
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in test_compute_api.py (4)  https://review.openstack.org/56846221:31
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3)  https://review.openstack.org/57410421:31
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4)  https://review.openstack.org/57410621:32
*** avolkov has quit IRC21:34
*** markguz_ has quit IRC21:34
mriedemefried: jaypipes: couple of comments in https://review.openstack.org/#/c/556669/ but +2 nonetheless21:44
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py  https://review.openstack.org/56615322:05
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Create specs directory for Stein  https://review.openstack.org/57360222:08
openstackgerritdo3meli proposed openstack/nova master: docs: add nova host-evacuate command to evacuate documentation  https://review.openstack.org/57804022:12
openstackgerritdo3meli proposed openstack/nova master: docs: add nova host-evacuate command to evacuate documentation  https://review.openstack.org/57804022:15
mriedemefried: http://logs.openstack.org/69/556669/18/check/openstack-tox-py27/4ac0817/testr_results.html.gz22:21
efriedon it22:22
efriedFTR, I did make it 4 total tries intentionally, but I thought I was in the clear because I removed all the unit tests. Not so apparently.22:23
*** edmondsw has quit IRC22:30
*** edmondsw has joined #openstack-placement22:31
*** edmondsw has quit IRC22:35
openstackgerritEric Fried proposed openstack/nova master: Check provider generation and retry on conflict  https://review.openstack.org/55666922:43
efriedmriedem: That oughtta do it.22:43
mriedemi'll watch the paint dry22:44
mriedempep8 failed23:06
efriedffs23:07
efriedcan you tell I'm tired as shit23:07
efriedand now a f'ing merge conflict?  Give me a break.23:08
mriedemha23:08
mriedemcould be worse,23:09
mriedemyou could have 2 screaming girls trashing your basement23:09
openstackgerritEric Fried proposed openstack/nova master: Check provider generation and retry on conflict  https://review.openstack.org/55666923:09
efriedpep & rebase23:09
efriedmriedem: Those were the days.23:10
efriedOh, you mean basement like a house. And girls like little girls.23:10
efriedand trashing like... never mind.23:10
openstackgerritMatt Riedemann proposed openstack/nova master: Add queued_for_delete field to InstanceMapping object  https://review.openstack.org/56679523:19
openstackgerritMatt Riedemann proposed openstack/nova master: Online migration tool for populating queued-for-delete  https://review.openstack.org/58253623:19
openstackgerritMatt Riedemann proposed openstack/nova master: Update queued-for-delete from the ComputeAPI during deletion/restoration  https://review.openstack.org/56681323:19
openstackgerritMatt Riedemann proposed openstack/nova master: [POC] Graceful handling of nova-list when a cell is down  https://review.openstack.org/56778523:19
mriedemha23:19
mriedemfilthy23:19
mriedemand inappropriate23:19
openstackgerritMatt Riedemann proposed openstack/nova master: Online migration tool for populating queued-for-delete  https://review.openstack.org/58253623:23
openstackgerritMatt Riedemann proposed openstack/nova master: Update queued-for-delete from the ComputeAPI during deletion/restoration  https://review.openstack.org/56681323:23
openstackgerritMatt Riedemann proposed openstack/nova master: [POC] Graceful handling of nova-list when a cell is down  https://review.openstack.org/56778523:23
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5)  https://review.openstack.org/57411023:24
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6)  https://review.openstack.org/57411323:25
mriedemdude you can't win http://logs.openstack.org/69/556669/20/check/openstack-tox-lower-constraints/66e8f55/testr_results.html.gz23:29
mriedemis that intermittent?23:29
mriedemretrydecorator has been around forever23:30
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7)  https://review.openstack.org/57497423:43
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8)  https://review.openstack.org/57531123:43
openstackgerritMatt Riedemann proposed openstack/nova master: Use consumer generation in _heal_allocations_for_instance  https://review.openstack.org/57790523:44
*** mriedem is now known as mriedem_away23:45

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!