| *** hamalq has quit IRC | 00:12 | |
| *** hamalq has joined #openstack-oslo | 00:12 | |
| *** openstackgerrit has joined #openstack-oslo | 01:15 | |
| openstackgerrit | Xuan Yandong proposed openstack/oslo.utils master: remove unicode from code https://review.opendev.org/c/openstack/oslo.utils/+/769022 | 01:15 |
|---|---|---|
| *** rcernin has joined #openstack-oslo | 02:39 | |
| *** hamalq has quit IRC | 02:45 | |
| *** zzzeek has quit IRC | 07:07 | |
| *** zzzeek has joined #openstack-oslo | 07:08 | |
| *** lpetrut has joined #openstack-oslo | 07:11 | |
| *** sboyron_ has joined #openstack-oslo | 07:25 | |
| *** ralonsoh has joined #openstack-oslo | 07:36 | |
| *** rpittau|afk is now known as rpittau | 07:39 | |
| *** tosky has joined #openstack-oslo | 08:46 | |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.messaging master: Allow to manage missing queue https://review.opendev.org/c/openstack/oslo.messaging/+/771232 | 08:56 |
| *** rcernin has quit IRC | 09:07 | |
| *** rcernin has joined #openstack-oslo | 09:17 | |
| *** rcernin has quit IRC | 09:25 | |
| *** rcernin has joined #openstack-oslo | 09:43 | |
| *** kevko has joined #openstack-oslo | 09:46 | |
| kevko | Hi, maybe you notices that past days there was a disscussion about caching in multiple places ... can someone check/review my patch for keystone middleware ? https://review.opendev.org/c/openstack/keystonemiddleware/+/773939 ? Thanks | 09:46 |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.messaging master: Correctly handle missing RabbitMQ queues https://review.opendev.org/c/openstack/oslo.messaging/+/771232 | 09:47 |
| stephenfin | kevko: I don't think any of us have core on that project. You probably want to ask on #openstack-keystone | 09:47 |
| kevko | stephenfin: i tried, but there is a suspicious silence :( | 10:16 |
| stephenfin | I think most of them are US based, if that help? | 10:16 |
| stephenfin | *s | 10:16 |
| kevko | stephenfin: BUT, I am touching oslo.cache in that patch ..so you will be helpful | 10:16 |
| kevko | stephenfin: probably | 10:16 |
| kevko | stephenfin: point is that keystonemiddleware is doing something very weird even if there is oslo.cache support long time ago ! (in times when oslo.cache was new lib) | 10:17 |
| kevko | (*from) | 10:17 |
| stephenfin | Yeah, the change looks reasonable from a distance but I can only +1 at most if I review in depth, unfortunately | 10:19 |
| stephenfin | So I'm not sure how much help anyone here would be | 10:19 |
| kevko | stephenfin: never mind, +1 will probably help littlebit:) | 10:20 |
| stephenfin | ack, will take a look shortly | 10:20 |
| kevko | stephenfin: thank you very much | 10:21 |
| *** rcernin has quit IRC | 10:48 | |
| *** rcernin has joined #openstack-oslo | 10:53 | |
| *** rcernin has quit IRC | 10:57 | |
| openstackgerrit | Merged openstack/etcd3gw master: Add doc/requirements https://review.opendev.org/c/openstack/etcd3gw/+/769521 | 11:46 |
| *** rcernin has joined #openstack-oslo | 11:49 | |
| openstackgerrit | Merged openstack/oslo.reports stable/train: [stable-only] Cap bandit and fix lower-constraints https://review.opendev.org/c/openstack/oslo.reports/+/769995 | 12:29 |
| stephenfin | gmann, lbragstad: https://bugs.launchpad.net/nova/+bug/1914592/comments/1 | 12:55 |
| openstack | Launchpad bug 1914592 in oslo.policy "oslo.policy 3.6.1 breaks nova" [Critical,Confirmed] - Assigned to Stephen Finucane (stephenfinucane) | 12:55 |
| stephenfin | oslo.policy's lack of copying is an issue, but nova is also doing daft things | 12:55 |
| openstackgerrit | Radosław Piliszek proposed openstack/etcd3gw master: Drop py2 support and clean things up https://review.opendev.org/c/openstack/etcd3gw/+/774082 | 13:14 |
| openstackgerrit | Radosław Piliszek proposed openstack/etcd3gw master: Drop py2 support and clean things up https://review.opendev.org/c/openstack/etcd3gw/+/774082 | 13:33 |
| *** rcernin has quit IRC | 13:43 | |
| *** kgiusti has joined #openstack-oslo | 13:44 | |
| lbragstad | stephenfin sounds good - i have that oslo.policy review on my list today though since glance is hitting the same issue as placement | 13:56 |
| openstackgerrit | Radosław Piliszek proposed openstack/etcd3gw master: Drop py2 support and clean things up https://review.opendev.org/c/openstack/etcd3gw/+/774082 | 14:11 |
| gmann | stephenfin: yeah, _handle_deprecated_rule was skipped completely and end up not adding the deprecated rule in OR. | 14:32 |
| gmann | for nova I think we should remove all those fixture and keep RealPolicyFixture only | 14:32 |
| gmann | stephenfin: if you try the workflow you mentioned in 1914592 with fix then it should work fine - https://review.opendev.org/c/openstack/oslo.policy/+/773950 | 14:33 |
| *** lpetrut has quit IRC | 15:23 | |
| *** hberaud has quit IRC | 16:15 | |
| *** hberaud has joined #openstack-oslo | 16:16 | |
| *** hberaud has quit IRC | 16:16 | |
| *** hberaud has joined #openstack-oslo | 16:17 | |
| *** hoonetorg has joined #openstack-oslo | 16:20 | |
| lbragstad | gmann https://review.opendev.org/c/openstack/oslo.policy/+/773950 looks good to me - just a couple questions inline, but they're minor | 16:45 |
| lbragstad | i'll let hberaud or stephenfin give it a look | 16:45 |
| stephenfin | I'm trying to break it but having no success, which I guess is a good thing :) | 16:46 |
| lbragstad | frustrating, in a good way | 16:47 |
| gmann | lbragstad: checking | 16:48 |
| lbragstad | i noticed glance has the same issue as placement where the enforcer bleeds between tests, i ran gmann's patch against the glance unit tests a bunch last night and i didn't see the issue crop back up | 16:57 |
| openstackgerrit | Ghanshyam proposed openstack/oslo.policy master: Work on copy of registered rule instead of original object https://review.opendev.org/c/openstack/oslo.policy/+/773950 | 16:59 |
| gmann | lbragstad: ^^ fixed the comment. | 16:59 |
| gmann | lbragstad: nice, I am sure most of them project running with policy fixture in parallel with few rules in file and few not has same issue | 17:00 |
| gmann | stephenfin: lbragstad hberaud I am trying to add nova unit/functional job in oslo.policy gate to detect these kind of issues before release only -https://review.opendev.org/c/openstack/oslo.policy/+/773947 | 17:02 |
| gmann | but tox env (from nova) use the master constraints as that is what hard coded there. does any of you know how to make tox test with oslo.policy master code? | 17:03 |
| stephenfin | gmann: You need to specify a project dependency in .zuul.yml iirc | 17:04 |
| stephenfin | via 'required-projects' | 17:04 |
| stephenfin | so it'll install using tox siblings | 17:04 |
| gmann | stephenfin: that is there as it run in oslo.policy gate which means it is already source from master | 17:04 |
| gmann | but tox use u-c version in venv | 17:05 |
| gmann | https://zuul.opendev.org/t/openstack/build/f1a4e07926cb4a70832a3ea3a782653f/log/job-output.txt#607 | 17:05 |
| stephenfin | I think you still need to specify that | 17:06 |
| stephenfin | look at .zuul.yaml for python-novaclient | 17:06 |
| gmann | I can specify but that is not needed as test running repo is always from master | 17:06 |
| gmann | let me try | 17:07 |
| openstackgerrit | Ghanshyam proposed openstack/oslo.policy master: Add nova project unit/functional tests job in gate https://review.opendev.org/c/openstack/oslo.policy/+/773947 | 17:07 |
| gmann | trying ^^ | 17:07 |
| stephenfin | Yeah, I'd normally poke mordred about this in the past | 17:08 |
| gmann | stephenfin: i think we need to set tox env var somewher poin to /opt/stack/requirements/upper-constraints.txt https://github.com/openstack/nova/blob/master/tox.ini#L27 | 17:08 |
| stephenfin | But python-novaclient has that python-novaclient-functional test which should be using python-novaclient from master, so we'll see | 17:08 |
| gmann | k | 17:08 |
| stephenfin | gmann: Okay, I failed to break your patch so kudos, but I'm still uncomfortable with us modifying any attribute of the existing object including the check | 17:21 |
| *** openstack has joined #openstack-oslo | 17:25 | |
| *** ChanServ sets mode: +o openstack | 17:25 | |
| stephenfin | cos as it is, there's another problem with this - the check_str value no longer matches the check value | 17:25 |
| stephenfin | that confused me a lot while debugging | 17:25 |
| * stephenfin would ultimately like to make 'check' a cached property and not something anyone can set | 17:25 | |
| gmann | yeah that is really confusing even for me too | 17:25 |
| stephenfin | do you mind if I push a WIP patch to show what I mean? | 17:25 |
| stephenfin | if you don't like it, we go with what you've got | 17:26 |
| gmann | sure, I can push that as alternate. checking if self.rules is all being checked in all checks etc | 17:29 |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.policy master: TODO https://review.opendev.org/c/openstack/oslo.policy/+/774111 | 17:33 |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.policy master: WIP: Don't modify 'Rule.check' https://review.opendev.org/c/openstack/oslo.policy/+/774112 | 17:33 |
| stephenfin | whoops, ignore the TODO | 17:33 |
| stephenfin | gmann: but that's what I mean. Lemme know what you think. I'm happy to go with what we have if we want to fix this asap, but I think this is a better long-term fix | 17:34 |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.policy master: WIP: Don't modify 'Rule.check' https://review.opendev.org/c/openstack/oslo.policy/+/774112 | 17:34 |
| gmann | stephenfin: that looks good (I can test locally ) and I think we can do deepcopy also for safer side https://review.opendev.org/c/openstack/oslo.policy/+/773950/4/oslo_policy/policy.py#1108 | 17:41 |
| *** zzzeek has quit IRC | 17:42 | |
| *** zzzeek has joined #openstack-oslo | 17:44 | |
| stephenfin | yup, makes sense | 17:44 |
| stephenfin | I'll rebase onto yours so | 17:44 |
| gmann | you want me to undo rest of other and you can rebase your on top of that ? | 17:45 |
| stephenfin | I can rebase onto that | 17:45 |
| gmann | ok | 17:45 |
| *** sboyron_ has quit IRC | 18:08 | |
| *** rpittau is now known as rpittau|afk | 18:10 | |
| *** hemna has quit IRC | 18:11 | |
| *** hemna has joined #openstack-oslo | 18:13 | |
| *** hamalq has joined #openstack-oslo | 18:14 | |
| *** ralonsoh has quit IRC | 18:18 | |
| *** hoonetorg has quit IRC | 18:24 | |
| openstackgerrit | Ghanshyam proposed openstack/oslo.policy master: Work on copy of registered rule instead of original object https://review.opendev.org/c/openstack/oslo.policy/+/773950 | 18:25 |
| gmann | stephenfin: fixed, sorry for that mesh ^^ | 18:25 |
| lbragstad | looks like we have another failure | 18:40 |
| *** kevko_ has joined #openstack-oslo | 18:49 | |
| *** kevko has quit IRC | 18:51 | |
| *** sboyron has joined #openstack-oslo | 18:59 | |
| *** sboyron has quit IRC | 19:05 | |
| *** rcernin has joined #openstack-oslo | 19:40 | |
| *** rcernin has quit IRC | 19:45 | |
| *** hoonetorg has joined #openstack-oslo | 20:01 | |
| *** hoonetorg has quit IRC | 20:13 | |
| *** rcernin has joined #openstack-oslo | 20:17 | |
| *** hoonetorg has joined #openstack-oslo | 20:30 | |
| *** rcernin has quit IRC | 20:31 | |
| *** rcernin has joined #openstack-oslo | 21:00 | |
| lbragstad | gmann stephenfin passed the gate https://review.opendev.org/c/openstack/oslo.policy/+/773950/5 | 21:15 |
| gmann | yeah | 21:16 |
| gmann | stephenfin: wow, required_project worked - https://review.opendev.org/c/openstack/oslo.policy/+/773947 | 21:17 |
| gmann | stephenfin: lbragstad we can see the failure on gate now https://review.opendev.org/c/openstack/oslo.policy/+/773947 | 21:17 |
| gmann | let me rebase this on top of fix | 21:17 |
| openstackgerrit | Ghanshyam proposed openstack/oslo.policy master: Add nova project unit/functional tests job in gate https://review.opendev.org/c/openstack/oslo.policy/+/773947 | 21:19 |
| *** rcernin has quit IRC | 21:39 | |
| *** rcernin has joined #openstack-oslo | 21:56 | |
| *** kevko_ has quit IRC | 21:59 | |
| *** kgiusti has left #openstack-oslo | 22:18 | |
| *** lbragstad_ has joined #openstack-oslo | 22:22 | |
| *** lbragstad has quit IRC | 22:24 | |
| *** rcernin has quit IRC | 22:26 | |
| *** rcernin has joined #openstack-oslo | 22:26 | |
| *** tkajinam has quit IRC | 22:59 | |
| *** tkajinam has joined #openstack-oslo | 22:59 | |
| *** lbragstad_ is now known as lbragstad | 23:03 | |
| gmann | lbragstad: stephenfin nova functional tests passing on fix https://review.opendev.org/c/openstack/oslo.policy/+/773947/5 | 23:06 |
| lbragstad | sweet - ship it https://review.opendev.org/c/openstack/oslo.policy/+/773950 | 23:06 |
| *** kevko_ has joined #openstack-oslo | 23:15 | |
| *** lbragstad has quit IRC | 23:21 | |
| *** lbragstad has joined #openstack-oslo | 23:23 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!