| *** ianychoi__ has joined #openstack-oslo | 00:14 | |
| *** tosky has quit IRC | 00:15 | |
| *** ianychoi_ has quit IRC | 00:17 | |
| *** eck` has quit IRC | 02:06 | |
| *** zzzeek has quit IRC | 02:12 | |
| *** zzzeek has joined #openstack-oslo | 02:12 | |
| *** lbragstad_ has joined #openstack-oslo | 02:14 | |
| *** lbragstad has quit IRC | 02:17 | |
| *** rcernin has quit IRC | 02:37 | |
| *** rcernin has joined #openstack-oslo | 02:51 | |
| *** lbragstad_ is now known as lbragstad | 03:51 | |
| *** brinzhang has quit IRC | 04:52 | |
| *** brinzhang has joined #openstack-oslo | 04:53 | |
| *** brinzhang_ has joined #openstack-oslo | 05:02 | |
| *** brinzhang has quit IRC | 05:05 | |
| *** rcernin has quit IRC | 06:08 | |
| *** rcernin has joined #openstack-oslo | 06:08 | |
| *** rcernin has quit IRC | 06:17 | |
| *** rcernin has joined #openstack-oslo | 06:17 | |
| *** rcernin has quit IRC | 06:17 | |
| *** rcernin has joined #openstack-oslo | 06:19 | |
| *** dasp has joined #openstack-oslo | 07:00 | |
| *** dasp_ has quit IRC | 07:01 | |
| *** brinzhang_ has quit IRC | 07:04 | |
| *** brinzhang_ has joined #openstack-oslo | 07:04 | |
| *** ralonsoh has joined #openstack-oslo | 07:28 | |
| *** sboyron_ has joined #openstack-oslo | 08:04 | |
| *** tosky has joined #openstack-oslo | 08:40 | |
| *** rpittau|afk is now known as rpittau | 08:41 | |
| *** brinzhang_ has quit IRC | 08:59 | |
| *** brinzhang_ has joined #openstack-oslo | 09:00 | |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.utils master: Allow to convert IPV4 addresses from text to binary form. https://review.opendev.org/c/openstack/oslo.utils/+/773863 | 10:01 |
|---|---|---|
| stephenfin | hberaud: Reviewed https://review.opendev.org/q/topic:%2522fix-json-primitive%2522+status:open Apologies for the delay | 10:19 |
| hberaud | stephenfin: I just seen thanx | 10:20 |
| hberaud | stephenfin: I think we can go with a single core approval | 10:20 |
| stephenfin | Is moguimar not around? | 10:20 |
| hberaud | stephenfin: as they already have been validated on master | 10:20 |
| hberaud | I just asked to him to review too in private message | 10:21 |
| *** rcernin has quit IRC | 10:24 | |
| *** rcernin has joined #openstack-oslo | 10:55 | |
| *** rcernin has quit IRC | 11:15 | |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.policy master: Add '__str__' for 'DeprecatedRule' https://review.opendev.org/c/openstack/oslo.policy/+/773873 | 11:16 |
| openstackgerrit | Merged openstack/whereto master: Add doc/requirements https://review.opendev.org/c/openstack/whereto/+/769787 | 11:33 |
| *** rcernin has joined #openstack-oslo | 12:01 | |
| moguimar | hberaud, stephenfin can we have code review in the first line and then backport candidate at the second on gerrit? | 12:11 |
| openstackgerrit | Stephen Finucane proposed openstack/castellan master: Allow specifying region of barbican endpoint https://review.opendev.org/c/openstack/castellan/+/772144 | 12:11 |
| stephenfin | moguimar: No, it's alphabetical. That annoys me also :) | 12:11 |
| moguimar | dang | 12:11 |
| stephenfin | Perhaps we could drop Backport-Candidate entirely? I don't think it's been that useful tbh | 12:12 |
| hberaud | If you didn't find any added value to "Backport candidate" then yes we could drop it | 12:13 |
| hberaud | It's goal isn't to annoys us | 12:14 |
| hberaud | And yes I think its added value is more than moderate | 12:15 |
| openstackgerrit | Merged openstack/oslo.cache master: Do not hardcode flush_on_reconnect, move to oslo.cache config https://review.opendev.org/c/openstack/oslo.cache/+/742193 | 12:27 |
| *** rcernin has quit IRC | 12:43 | |
| openstackgerrit | Merged openstack/oslo.service master: Drop custom implementation of EVENTLET_HUB https://review.opendev.org/c/openstack/oslo.service/+/764760 | 12:47 |
| openstackgerrit | Merged openstack/castellan master: Fix assertion typo in barbican key manager unit test https://review.opendev.org/c/openstack/castellan/+/769559 | 12:49 |
| openstackgerrit | Merged openstack/oslo.cache stable/queens: Cap Bandit below 1.6.0 and update Sphinx requirement https://review.opendev.org/c/openstack/oslo.cache/+/769557 | 12:49 |
| openstackgerrit | Merged openstack/osprofiler stable/train: [stable-only] Cap bandit to 1.6.2 https://review.opendev.org/c/openstack/osprofiler/+/770000 | 13:18 |
| openstackgerrit | Merged openstack/oslo.serialization stable/victoria: Dropping lower constraints testing https://review.opendev.org/c/openstack/oslo.serialization/+/772302 | 13:34 |
| openstackgerrit | Merged openstack/oslo.serialization stable/victoria: Fix json to_primitive when using IO OBjects https://review.opendev.org/c/openstack/oslo.serialization/+/771475 | 13:43 |
| hberaud | stephenfin, moguimar: Thanks for these patches, @moguimar please can you validate the ussuri part too https://review.opendev.org/q/topic:%22fix-json-primitive%22+(status:open) it will allow us to go down to "train" and then allow us to close this topic. | 13:50 |
| hberaud | ^ | 13:50 |
| openstackgerrit | Takashi Kajinami proposed openstack/castellan master: Simplify the reference to barbican parameters https://review.opendev.org/c/openstack/castellan/+/773892 | 13:56 |
| *** lbragstad has quit IRC | 13:57 | |
| *** zaneb has quit IRC | 13:58 | |
| openstackgerrit | Takashi Kajinami proposed openstack/castellan master: Simplify the reference to barbican parameters https://review.opendev.org/c/openstack/castellan/+/773892 | 14:01 |
| *** brinzhang_ has quit IRC | 14:17 | |
| *** brinzhang_ has joined #openstack-oslo | 14:17 | |
| openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.cache stable/ussuri: Add TLS options to oslo.cache https://review.opendev.org/c/openstack/oslo.cache/+/773904 | 14:21 |
| openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.cache stable/train: Add TLS options to oslo.cache https://review.opendev.org/c/openstack/oslo.cache/+/773905 | 14:21 |
| openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.cache stable/ussuri: Add TLS context creation from config https://review.opendev.org/c/openstack/oslo.cache/+/773906 | 14:27 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.messaging master: Allow to manage missing queue https://review.opendev.org/c/openstack/oslo.messaging/+/771232 | 14:32 |
| openstackgerrit | Takashi Kajinami proposed openstack/castellan master: Simplify the reference to barbican parameters https://review.opendev.org/c/openstack/castellan/+/773892 | 14:32 |
| hberaud | stephenfin: let me know if that make sense for you, thanks for your comments ^ (my patch) | 14:33 |
| * stephenfin looks | 14:33 | |
| *** brinzhang_ has quit IRC | 14:35 | |
| *** lbragstad has joined #openstack-oslo | 14:35 | |
| *** brinzhang_ has joined #openstack-oslo | 14:36 | |
| openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.cache stable/ussuri: Add TLS context creation from config https://review.opendev.org/c/openstack/oslo.cache/+/773906 | 14:42 |
| stephenfin | hberaud: Replied | 14:43 |
| hberaud | ack | 14:43 |
| stephenfin | If I'm missing something obvious, please let me know | 14:43 |
| openstackgerrit | Merged openstack/oslo.messaging master: Remove six https://review.opendev.org/c/openstack/oslo.messaging/+/769007 | 14:44 |
| *** bcafarel has quit IRC | 14:58 | |
| *** bcafarel has joined #openstack-oslo | 14:59 | |
| openstackgerrit | Mark Goddard proposed openstack/castellan master: barbican key manager: Add support for service user https://review.opendev.org/c/openstack/castellan/+/769560 | 15:01 |
| openstackgerrit | Merged openstack/oslo.messaging master: remove unicode from code https://review.opendev.org/c/openstack/oslo.messaging/+/769008 | 15:04 |
| openstackgerrit | Mark Goddard proposed openstack/castellan master: barbican key manager: Add support for service user https://review.opendev.org/c/openstack/castellan/+/769560 | 15:07 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.messaging master: Allow to manage missing queue https://review.opendev.org/c/openstack/oslo.messaging/+/771232 | 15:10 |
| openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.cache stable/ussuri: Bump dogpile.cache's version for Memcached TLS support https://review.opendev.org/c/openstack/oslo.cache/+/773907 | 15:14 |
| openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.cache stable/ussuri: Bump dogpile.cache's version for Memcached TLS support https://review.opendev.org/c/openstack/oslo.cache/+/773907 | 15:16 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.messaging master: Allow to manage missing queue https://review.opendev.org/c/openstack/oslo.messaging/+/771232 | 15:22 |
| openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.cache stable/victoria: Add dogpile.cache.pymemcache backend https://review.opendev.org/c/openstack/oslo.cache/+/773908 | 15:37 |
| openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.cache stable/ussuri: Add dogpile.cache.pymemcache backend https://review.opendev.org/c/openstack/oslo.cache/+/773909 | 15:39 |
| openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.cache stable/ussuri: Add dogpile.cache.pymemcache backend https://review.opendev.org/c/openstack/oslo.cache/+/773909 | 15:44 |
| openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.cache stable/ussuri: Add dogpile.cache.pymemcache backend https://review.opendev.org/c/openstack/oslo.cache/+/773909 | 15:49 |
| ralonsoh | stephenfin, hi! | 15:53 |
| ralonsoh | about latest oslo.policy version 3.6.1 | 15:53 |
| ralonsoh | https://review.opendev.org/c/openstack/requirements/+/773779 | 15:53 |
| ralonsoh | seems to clash with Nova | 15:53 |
| ralonsoh | https://d138d4f526b4feb9aa23-c0b1a48165a1318087e38ccc28dcb2b0.ssl.cf5.rackcdn.com/773779/1/check/cross-nova-functional/d9729b8/testr_results.html | 15:54 |
| stephenfin | oh wow | 15:54 |
| stephenfin | I'll take a look | 15:54 |
| ralonsoh | thanks a lot | 15:54 |
| gmann | seems deprecated rules are not added properly with https://review.opendev.org/c/openstack/oslo.policy/+/773414 | 15:56 |
| openstackgerrit | Merged openstack/oslo.serialization stable/ussuri: Dropping lower constraints testing https://review.opendev.org/c/openstack/oslo.serialization/+/772338 | 15:56 |
| openstackgerrit | Merged openstack/oslo.serialization stable/ussuri: Fix json to_primitive when using IO OBjects https://review.opendev.org/c/openstack/oslo.serialization/+/771476 | 15:56 |
| gmann | lbragstad: stephenfin ralonsoh may be new flag ( _deprecated_rule_handled ) is getting incorrect value due to this https://bugs.launchpad.net/oslo.policy/+bug/1914095 | 15:59 |
| openstack | Launchpad bug 1914095 in oslo.policy "The Enforcer object doesn't deepcopy rules before modifying them" [Undecided,New] | 15:59 |
| bnemec | How on earth did that pass the tempest tests if it broke nova? | 15:59 |
| stephenfin | bnemec: I think gmann is onto something. Tempest would init policy just once | 16:00 |
| gmann | bnemec: only difference between them is tempest test work on defaults and functional tests with policy fixture with overridden rules (most of them '') | 16:01 |
| gmann | stephenfin: yes | 16:01 |
| gmann | let me try to reproduce it locally and try with deepcopying the rule | 16:03 |
| stephenfin | okay, cool | 16:03 |
| * stephenfin has a meeting so won't be able to look at it for an hour or so | 16:03 | |
| lbragstad | i'm knee deep in glance's secure rbac patches, but let me know if you need help or a set of eyes on anything stephenfin | 16:06 |
| moguimar | smcginnis, you | 16:11 |
| moguimar | are you the requirements PTL? | 16:11 |
| gmann | moguimar: its Matthew Thode(irc prometheanfire) | 16:16 |
| moguimar | thanks gmann | 16:18 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.messaging master: Allow to manage missing queue https://review.opendev.org/c/openstack/oslo.messaging/+/771232 | 16:23 |
| openstackgerrit | Mark Goddard proposed openstack/castellan master: barbican key manager: Add support for service user https://review.opendev.org/c/openstack/castellan/+/769560 | 16:34 |
| *** slaweq has joined #openstack-oslo | 16:48 | |
| stephenfin | moguimar: I stuck you on a couple of castellan reviews since I think you're well placed to review them. Let me know if that doesn't make sense (I think you've worked on Barbican previously?) | 16:49 |
| moguimar | stephenfin, cool | 16:50 |
| openstackgerrit | Merged openstack/oslo.messaging master: Move jobs to py38 https://review.opendev.org/c/openstack/oslo.messaging/+/727787 | 16:52 |
| openstackgerrit | Ghanshyam proposed openstack/oslo.policy master: Add project unit/functional tests job in gate https://review.opendev.org/c/openstack/oslo.policy/+/773947 | 16:55 |
| stephenfin | gmann, bnemec: So what's happening is that rule is pointing to another rule, and that other rule is what's deprecated | 17:06 |
| gmann | stephenfin: yeah, deepcopy fix the issue, i am writing commit msg for fix and push soon | 17:06 |
| stephenfin | but because we've already processed that other rule (by updating the check), we don't process the embedded version | 17:07 |
| stephenfin | ah, good to hear :) I was thinking we'd have to _rely_ on rules being shared /o\ | 17:07 |
| openstackgerrit | Ghanshyam proposed openstack/oslo.policy master: Work on copy of registered rule instead of orignal object https://review.opendev.org/c/openstack/oslo.policy/+/773950 | 17:08 |
| gmann | stephenfin: ^^ | 17:08 |
| gmann | I am adding service functional/unit test also to avoid such issue in future | 17:08 |
| gmann | also releasenotes | 17:10 |
| openstackgerrit | Ghanshyam proposed openstack/oslo.policy master: Add nova project unit/functional tests job in gate https://review.opendev.org/c/openstack/oslo.policy/+/773947 | 17:19 |
| openstackgerrit | Ghanshyam proposed openstack/oslo.policy master: Add nova project unit/functional tests job in gate https://review.opendev.org/c/openstack/oslo.policy/+/773947 | 17:31 |
| *** ralonsoh has quit IRC | 17:31 | |
| openstackgerrit | Ghanshyam proposed openstack/oslo.policy master: Work on copy of registered rule instead of orignal object https://review.opendev.org/c/openstack/oslo.policy/+/773950 | 17:57 |
| gmann | stephenfin: lbragstad bnemec ^^ added the unit test and releasenotes too | 17:57 |
| lbragstad | sweet | 17:57 |
| lbragstad | thanks gmann | 17:57 |
| stephenfin | gmann: I still don't grok how it's breaking the nova job. What common attribute is getting changed? | 18:00 |
| gmann | its _deprecated_rule_handled | 18:00 |
| gmann | https://github.com/openstack/oslo.policy/blob/bd9d47aa36ad6f2f4746f09a267d7ce809a820f4/oslo_policy/policy.py#L774 | 18:00 |
| gmann | stephenfin: and based on this flag if True _handle_deprecated_rule() does not add deprecated rule on OR check https://github.com/openstack/oslo.policy/blob/bd9d47aa36ad6f2f4746f09a267d7ce809a820f4/oslo_policy/policy.py#L703 | 18:01 |
| gmann | so one test add the deprecated rule with OR as _deprecated_rule_handled is false and set it to True | 18:02 |
| gmann | and next tests find this value as True and skip adding the deprecated rule OR addition | 18:02 |
| stephenfin | Okay, but if it's set that value to True, hasn't it also already added the OR? | 18:03 |
| gmann | humm, with the bug 1914095 it should.. | 18:05 |
| openstack | bug 1914095 in oslo.policy "The Enforcer object doesn't deepcopy rules before modifying them" [Undecided,New] https://launchpad.net/bugs/1914095 | 18:05 |
| *** rpittau is now known as rpittau|afk | 18:08 | |
| gmann | stephenfin: lbragstad . ok I got it. seems another bug. we are setting _deprecated_rule_handled =True always when _handle_deprecated_rule is called not when actually deprecated rule is added in OR check | 18:39 |
| gmann | and that way depends on other flag or rule in file it end up skipping the adding OR check always | 18:40 |
| openstackgerrit | Ghanshyam proposed openstack/oslo.policy master: Work on copy of registered rule instead of orignal object https://review.opendev.org/c/openstack/oslo.policy/+/773950 | 19:22 |
| gmann | stephenfin: lbragstad fixed ^^ | 19:23 |
| *** rcernin has joined #openstack-oslo | 19:49 | |
| *** rcernin has quit IRC | 20:20 | |
| *** rcernin has joined #openstack-oslo | 20:20 | |
| *** SpamapS has quit IRC | 20:52 | |
| *** rcernin has quit IRC | 21:22 | |
| *** hamalq has joined #openstack-oslo | 21:27 | |
| hamalq | oslo_messaging.exceptions.MessagingTimeout: Timed out waiting for a reply to message | 21:47 |
| hamalq | When the rabbitmq is restarted the openstack services start raising the error above and the only fix is to restart all the services after the restart of the rabbitmq | 21:47 |
| hamalq | When that happen in the log on MQ u can see | 21:47 |
| hamalq | operation queue.declare caused a channel exception not_found: queue 'reply_fe8c409efaa44af296a0a151daf078aa' | 21:47 |
| hamalq | Which means the openstack still wait for reply from queue that is deleted due the restart of MQ and don't recover from that unless restarted | 21:47 |
| hamalq | Does that mean it's required to restart all Openstack services when MQ restarted? | 21:47 |
| hamalq | Is an oslo.messaging bug need fixing | 21:47 |
| hamalq | @hberaud ^^ | 21:49 |
| *** sboyron_ has quit IRC | 21:49 | |
| *** SpamapS has joined #openstack-oslo | 21:54 | |
| *** rcernin has joined #openstack-oslo | 22:05 | |
| *** rcernin has quit IRC | 22:06 | |
| *** rcernin has joined #openstack-oslo | 22:07 | |
| *** kgiusti has left #openstack-oslo | 22:11 | |
| *** openstackgerrit has quit IRC | 22:11 | |
| *** slaweq has quit IRC | 22:41 | |
| *** rcernin has quit IRC | 22:45 | |
| *** tosky has quit IRC | 23:54 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!