Friday, 2020-05-15

openstackgerritpunkrokk proposed openstack/tooz master: Add support for Consul ACL token parameter.  https://review.opendev.org/71848801:49
openstackgerritmelissaml proposed openstack/oslo.reports master: Remove translation sections from setup.cfg  https://review.opendev.org/72833703:05
openstackgerritmelissaml proposed openstack/oslo.policy master: Remove translation sections from setup.cfg  https://review.opendev.org/72833803:09
openstackgerritmelissaml proposed openstack/oslo.reports master: Remove translation sections from setup.cfg  https://review.opendev.org/72834003:17
openstackgerritmelissaml proposed openstack/oslo.i18n master: Remove translation sections from setup.cfg  https://review.opendev.org/72834103:17
openstackgerritmelissaml proposed openstack/oslo.middleware master: Remove translation sections from setup.cfg  https://review.opendev.org/72834203:17
openstackgerritmelissaml proposed openstack/oslo.service master: Remove translation sections from setup.cfg  https://review.opendev.org/72834303:17
openstackgerritmelissaml proposed openstack/oslo.log master: Remove translation sections from setup.cfg  https://review.opendev.org/72834403:17
openstackgerritmelissaml proposed openstack/oslo.utils master: Remove translation sections from setup.cfg  https://review.opendev.org/72834603:30
openstackgerritmelissaml proposed openstack/oslo.serialization master: Remove translation sections from setup.cfg  https://review.opendev.org/72834703:30
openstackgerritmelissaml proposed openstack/oslo.versionedobjects master: Remove translation sections from setup.cfg  https://review.opendev.org/72834803:30
openstackgerritmelissaml proposed openstack/oslo.privsep master: Remove translation sections from setup.cfg  https://review.opendev.org/72834903:30
openstackgerritmelissaml proposed openstack/oslo.db master: Remove translation sections from setup.cfg  https://review.opendev.org/72835203:42
openstackgerritmelissaml proposed openstack/oslo.vmware master: Remove translation sections from setup.cfg  https://review.opendev.org/72835303:58
openstackgerritmelissaml proposed openstack/oslo.versionedobjects master: Remove translation sections from setup.cfg  https://review.opendev.org/72835404:01
openstackgerritmelissaml proposed openstack/oslo.context master: Remove translation sections from setup.cfg  https://review.opendev.org/72835504:08
*** zzzeek has quit IRC04:23
*** zzzeek has joined #openstack-oslo04:24
*** jaosorior has joined #openstack-oslo06:43
openstackgerritAndreas Jaeger proposed openstack/openstackdocstheme master: Use xelatex as latex_engine  https://review.opendev.org/72837006:46
AJaegerstephenfin, smcginnis, hberaud, bnemec, melwitt, I propose to set xelatex unconditionally again ^06:48
AJaegerI could not find a way to override the default. stephenfin, if you have a better solution: Happy to go with that one!06:49
openstackgerritAndreas Jaeger proposed openstack/openstackdocstheme master: Update docstheme  https://review.opendev.org/72837106:52
AJaegertesting now in https://review.opendev.org/72837206:57
*** ralonsoh has joined #openstack-oslo07:12
*** rpittau|afk is now known as rpittau07:12
openstackgerritMerged openstack/oslo.cache master: Switch to Victoria tests  https://review.opendev.org/72651907:23
openstackgerritAndreas Jaeger proposed openstack/openstackdocstheme master: Add cross-tests for nova  https://review.opendev.org/72837707:28
openstackgerritAndreas Jaeger proposed openstack/openstackdocstheme master: Add cross-tests for nova  https://review.opendev.org/72837707:28
AJaegermelwitt, stephenfin, let's add cross-tests. Those should fail with current state of repo and pass before the next release ;)07:30
*** tosky has joined #openstack-oslo07:35
*** tkajinam has quit IRC08:14
hberaudAJaeger: o/08:14
hberaudAJaeger: IIRC yesterday we reintroduced the conditional engine, that's right?08:15
hberaudAJaeger: ah no... we even added the engine itself if not defined (was undefined at all)08:16
*** dtantsur|afk is now known as dtantsur08:17
AJaegerhberaud: the engine is always defined, so the conditional was a nop ;(08:21
AJaegerand my cross-tests don't work08:21
hberaudok08:22
AJaegerthey work partially - only on the docs, not on pdf08:23
hberaudok08:23
openstackgerritAndreas Jaeger proposed openstack/openstackdocstheme master: Add cross-tests for nova  https://review.opendev.org/72837708:30
openstackgerritAndreas Jaeger proposed openstack/openstackdocstheme master: Add cross-tests for nova  https://review.opendev.org/72837708:44
openstackgerritAndreas Jaeger proposed openstack/openstackdocstheme master: DNM: Add cross-tests for nova  https://review.opendev.org/72837708:56
AJaegerfound the culprit - nova sets envdir and then siblings install does not work ;(08:57
hberaudAJaeger: for the latex engine?09:05
hberaudstephenfin: o/ if you've some spare time please can you take a look to https://review.opendev.org/#/c/712479/ & https://review.opendev.org/#/c/718223/ I addressed your comments and they work as expected. Please ignore the follow up patches I still have some issues with the memcached backend...09:09
stephenfinsure09:09
AJaegerhberaud: testing openstackdocstheme from master does not work with nova directly, the envdir breaks the logic we use for installing from master (sibling install). So, I have testing up now and can discuss further with melwitt and mordred (on #openstack-infra) on how to address this in general09:16
hberaudAJaeger: ack09:16
openstackgerritMerged openstack/openstackdocstheme master: Use xelatex as latex_engine  https://review.opendev.org/72837009:19
openstackgerritStefan Nica proposed openstack/oslo.messaging stable/pike: Use default exchange for direct messaging  https://review.opendev.org/72839609:24
AJaegerstephenfin, hberaud , want to merge https://review.opendev.org/728371 as well?09:40
stephenfinAJaeger: good call, done09:41
openstackgerritAndreas Jaeger proposed openstack/openstackdocstheme master: DNM: Add cross-tests for nova  https://review.opendev.org/72837709:44
AJaegerI'm still struggling with a working test for nova with master ;(09:44
AJaegerstephenfin: are you confident this fixes the problem and should we release a new version? I am but didn't test it yet :(09:45
stephenfinI'm reasonably confident, but I can't test locally since Fedora is missing a texlive package that Sphinx needs to build PDFs :(09:46
AJaegermmh, but we should be able to test that pdflatex is not called - let me try..09:47
openstackgerritMerged openstack/openstackdocstheme master: Update docstheme  https://review.opendev.org/72837109:53
AJaegerSo, with openstackdocstheme master, file doc/build/pdf/latexmkrc has $pdflatex = 'xelatex' - and with 2.1.0 it's $pdflatex = 'pdflatex '09:54
AJaegerSo, looks correct09:54
AJaegerhberaud, stephenfin, pushed next release - https://review.opendev.org/72840409:56
openstackgerritMerged openstack/tooz master: Add support for Consul ACL token parameter.  https://review.opendev.org/71848810:01
openstackgerritmelissaml proposed openstack/oslo.versionedobjects master: Remove translation sections from setup.cfg  https://review.opendev.org/72835410:02
AJaegerstephenfin: so, 728377 build with new openstackdocstheme master correctly if I interpret the log files10:04
AJaegerstephenfin: what do you think of loggging the openstackdocstheme version? that would have helped a bit...10:05
stephenfinAJaeger: I was pretty sure Sphinx logged extension version already10:06
AJaegerstephenfin: I don't see it in output10:06
stephenfinah, I think we need to provide a version in the return value from 'setup()' https://www.sphinx-doc.org/en/master/extdev/index.html#extension-metadata10:06
stephenfinbut yeah, logging the version seems fine by me10:07
AJaegerand cross-jobs is not working completely -but I'm convinced it uses xelatex now10:08
AJaegerso, hberaud, stephenfin , let's release https://review.opendev.org/728404 - third time is a charm ;)10:09
openstackgerritmelissaml proposed openstack/oslo.limit master: Remove translation sections from setup.cfg  https://review.opendev.org/72840610:09
*** rpittau is now known as rpittau|bbl10:09
openstackgerritMerged openstack/tooz master: Switch to Victoria tests  https://review.opendev.org/72652011:28
*** threestrands has quit IRC11:46
AJaegerbnemec: could you review the docstheme release, please: https://review.opendev.org/72840411:49
*** rpittau|bbl is now known as rpittau12:06
*** raildo has joined #openstack-oslo12:15
AJaegerbnemec: it's released, nothing to do anymore ;)12:31
AJaegerstephenfin, smcginnis, I'm testing the new release with depends-on the upper-constraints update, see https://review.opendev.org/#/c/728432/1 where I listed the 3 changes I test (nova, cinder, python-cinderclient).12:41
hberaudmoguimar: o/ if you are around and if you've some spare time please can you take a look to https://review.opendev.org/#/c/712479/ & https://review.opendev.org/#/c/718223/ I addressed your comments and they work as expected. Please ignore the follow up patches I still have some issues with the memcached backend... but for now we can move forward these 2 patches12:58
smcginnisAJaeger: Looking at the cinder one in Zuul status, pdf job passed. Lower-constraints failed, but I think it at least shows it is better.12:58
smcginnisThanks for checking that.12:58
smcginnisConfirmed it pulled in 2.1.2.12:59
smcginnisAnd pdf-docs job completed successfully.12:59
smcginniss/job/step/12:59
smcginnisHmm, nova job failed though.13:01
smcginnisLooks like it could be a legitimate issue with the nova docs. Not sure why the pdf build had an issue with it but not the regular build.13:03
AJaegersmcginnis: let's check that closely. stephenfin, do you have time to help checking?13:32
AJaegersmcginnis: the novaclient might be related to my change...13:35
AJaegersmcginnis: novaclient: This is using openstackclient 2.0.2 for PDF build, let's first merge https://review.opendev.org/72843013:37
moguimarhberaud, ack13:58
moguimarI have upstream friday today =D13:59
hberaud:)14:00
*** bnemec is now known as beekneemech14:27
openstackgerritAndreas Jaeger proposed openstack/oslo.concurrency master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72826915:07
openstackgerritAndreas Jaeger proposed openstack/oslo.concurrency master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72826915:08
melwittAJaeger: do you still need help with a nova cross job? I'm not an expert but I can try to help figure out15:08
openstackgerritAndreas Jaeger proposed openstack/oslo.cache master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72826715:10
AJaegermelwitt: I'm fine now, thanks.15:12
melwittok cool15:12
AJaegermelwitt: https://review.opendev.org/728270 is green - novaclient15:12
AJaegerfor the cross-job, we need zuul-jobs about your envdir setting in tox.ini; so, I cannot do that directly.15:13
melwittah great! (green job)15:14
openstackgerritAndreas Jaeger proposed openstack/oslo.cache master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72826715:14
melwittAJaeger: sorry what do you mean about needing envdir setting?15:14
AJaeger melwitt, nova is setting in tox.ini envdir and thus sibling install fails since we expect that envdir contains the envlist (pdf-docs) and not another one, see https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/tox/library/tox_install_sibling_packages.py#L190-L194 .15:16
AJaegermelwitt: we expect .tox/pdf-docs but https://opendev.org/openstack/nova/src/branch/master/tox.ini#L182 uses .tox/docs15:16
melwittohhh I see15:17
melwittI guess we must be trying to optimize for local builds, so that all docs related test runs share same envdir15:17
AJaegeryep15:18
AJaegerand nobody checked that CI handles this nicely. avass said in #zuul that he will look into it.15:18
AJaegerBut so long as we have this, installation of siblings with nova will not work15:18
AJaegerso, be aware of it15:19
melwittI see. ok, will do, I'll follow along what avass finds and go from there. see if it's something that CI can handle or if we just need to go ahead and change our envdir for pdf-docs only15:20
melwittor other, if there's some other option I don't know about15:20
AJaegerlet's see that these pass: https://review.opendev.org/#/q/status:open++topic:reno-openstacksdocstheme and then we can merge the upper-constraints of openstackdocstheme 2.1.2 and use it15:23
melwittack15:23
AJaegermelwitt: I think the envdir is the only one - and we're good to go forward. I would have loved a cross test directly but that has to wait until avass is done. Parsing the tox.ini is a bit more complex15:23
melwittok15:24
AJaegermelwitt: sorry, for all the mess that I overlooked in reviewing. Hope we're good now without too many grey hairs for either of us ;)15:28
melwittAJaeger: haha np, grey hairs indeed xD15:30
stephenfinAJaeger: Sorry, back to back meetings. Did you get sorted or do you still need me for something?15:38
AJaegerstephenfin: all fine!15:40
AJaegerstephenfin: thanks for asking. But all loooks green - just waiting for nova and cinder builds to finish15:40
AJaegerhttps://review.opendev.org/#/q/status:open++topic:reno-openstacksdocstheme15:40
stephenfinAh, good to hear :)15:40
AJaegerstephenfin: you might want to patch the theme to return the version number15:40
AJaegerAnd I need to wait for some fixes to jobs before we can do an integration test.15:41
*** jaosorior has quit IRC16:03
AJaegermelwitt, stephenfin, nova passes: https://review.opendev.org/72826316:10
stephenfinAJaeger++16:11
melwittcool thanks AJaeger16:13
openstackgerritGhanshyam Mann proposed openstack/pycadf master: Fix hacking min version to 3.0.1  https://review.opendev.org/72753016:14
AJaegerstephenfin: updated 728263 as suggested16:15
stephenfinthanks, +216:15
AJaegerstephenfin: let's call it a weekend and celebrate ;)16:16
AJaegerthanks16:16
stephenfinHear, hear16:16
openstackgerritHervĂ© Beraud proposed openstack/tooz master: Use unittest.mock instead of third party mock  https://review.opendev.org/72849616:29
openstackgerritHervĂ© Beraud proposed openstack/tooz master: Use unittest.mock instead of third party mock  https://review.opendev.org/72849616:30
openstackgerritStephen Finucane proposed openstack/openstackdocstheme master: Provide extension version  https://review.opendev.org/72849716:42
openstackgerritStephen Finucane proposed openstack/openstackdocstheme master: trivial: Remove leftover Python 2 code  https://review.opendev.org/72849816:42
openstackgerritStephen Finucane proposed openstack/openstackdocstheme master: Use consistent logging  https://review.opendev.org/72849916:42
*** dtantsur is now known as dtantsur|afk17:08
openstackgerritjacky06 proposed openstack/oslo.serialization master: Remove the unused coding style modules  https://review.opendev.org/72850917:10
openstackgerritjacky06 proposed openstack/oslo.rootwrap master: Remove the unused coding style modules  https://review.opendev.org/72851017:10
openstackgerritjacky06 proposed openstack/oslo.reports master: Remove the unused coding style modules  https://review.opendev.org/72851117:10
openstackgerritjacky06 proposed openstack/oslo.i18n master: Remove the unused coding style modules  https://review.opendev.org/72851217:10
openstackgerritjacky06 proposed openstack/oslo.privsep master: Remove the unused coding style modules  https://review.opendev.org/72851317:10
openstackgerritjacky06 proposed openstack/oslo.limit master: Remove the unused coding style modules  https://review.opendev.org/72851417:10
openstackgerritjacky06 proposed openstack/oslo.policy master: Remove the unused coding style modules  https://review.opendev.org/72851517:10
openstackgerritjacky06 proposed openstack/oslo.cache master: Remove the unused coding style modules  https://review.opendev.org/72851617:10
openstackgerritjacky06 proposed openstack/oslo.middleware master: Remove the unused coding style modules  https://review.opendev.org/72851717:10
openstackgerritjacky06 proposed openstack/oslo.versionedobjects master: Remove the unused coding style modules  https://review.opendev.org/72851817:10
openstackgerritjacky06 proposed openstack/oslo.context master: Remove the unused coding style modules  https://review.opendev.org/72851917:10
openstackgerritjacky06 proposed openstack/oslo.utils master: Remove the unused coding style modules  https://review.opendev.org/72852017:10
openstackgerritjacky06 proposed openstack/oslo.log master: Remove the unused coding style modules  https://review.opendev.org/72852117:10
openstackgerritjacky06 proposed openstack/oslo.service master: Remove the unused coding style modules  https://review.opendev.org/72852217:10
openstackgerritjacky06 proposed openstack/oslo.concurrency master: Remove the unused coding style modules  https://review.opendev.org/72852317:10
openstackgerritjacky06 proposed openstack/oslo.vmware master: Remove the unused coding style modules  https://review.opendev.org/72852417:10
openstackgerritjacky06 proposed openstack/oslo.db master: Remove the unused coding style modules  https://review.opendev.org/72852517:10
openstackgerritjacky06 proposed openstack/oslo.messaging master: Remove the unused coding style modules  https://review.opendev.org/72852617:10
openstackgerritjacky06 proposed openstack/oslo.config master: Remove the unused coding style modules  https://review.opendev.org/72852717:10
*** rpittau is now known as rpittau|afk17:11
openstackgerritjacky06 proposed openstack/oslo.config master: Remove the unused coding style modules  https://review.opendev.org/72852717:15
openstackgerritjacky06 proposed openstack/oslo.messaging master: Remove the unused coding style modules  https://review.opendev.org/72852617:16
openstackgerritjacky06 proposed openstack/oslo.db master: Remove the unused coding style modules  https://review.opendev.org/72852517:16
openstackgerritjacky06 proposed openstack/oslo.concurrency master: Remove the unused coding style modules  https://review.opendev.org/72852317:17
openstackgerritjacky06 proposed openstack/oslo.service master: Remove the unused coding style modules  https://review.opendev.org/72852217:17
openstackgerritjacky06 proposed openstack/oslo.log master: Remove the unused coding style modules  https://review.opendev.org/72852117:17
openstackgerritjacky06 proposed openstack/oslo.utils master: Remove the unused coding style modules  https://review.opendev.org/72852017:17
openstackgerritjacky06 proposed openstack/oslo.context master: Remove the unused coding style modules  https://review.opendev.org/72851917:17
openstackgerritjacky06 proposed openstack/oslo.versionedobjects master: Remove the unused coding style modules  https://review.opendev.org/72851817:18
openstackgerritjacky06 proposed openstack/oslo.middleware master: Remove the unused coding style modules  https://review.opendev.org/72851717:18
openstackgerritjacky06 proposed openstack/oslo.policy master: Remove the unused coding style modules  https://review.opendev.org/72851517:18
openstackgerritjacky06 proposed openstack/oslo.vmware master: Remove the unused coding style modules  https://review.opendev.org/72852417:18
openstackgerritjacky06 proposed openstack/oslo.limit master: Remove the unused coding style modules  https://review.opendev.org/72851417:19
openstackgerritjacky06 proposed openstack/oslo.privsep master: Remove the unused coding style modules  https://review.opendev.org/72851317:19
openstackgerritjacky06 proposed openstack/oslo.i18n master: Remove the unused coding style modules  https://review.opendev.org/72851217:19
openstackgerritjacky06 proposed openstack/oslo.reports master: Remove the unused coding style modules  https://review.opendev.org/72851117:19
openstackgerritjacky06 proposed openstack/oslo.cache master: Remove the unused coding style modules  https://review.opendev.org/72851617:20
*** ralonsoh has quit IRC17:55
smcginnisOh my.17:56
beekneemech+118:24
openstackgerritAndreas Jaeger proposed openstack/oslo.context master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72854618:24
openstackgerritAndreas Jaeger proposed openstack/oslo.context master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72854618:24
openstackgerritAndreas Jaeger proposed openstack/oslo.db master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72854718:25
openstackgerritAndreas Jaeger proposed openstack/oslo.i18n master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72854818:26
*** iurygregory has quit IRC18:35
*** iurygregory has joined #openstack-oslo18:38
*** iurygregory has quit IRC18:45
openstackgerritAndreas Jaeger proposed openstack/oslo.context master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72854618:46
openstackgerritAndreas Jaeger proposed openstack/oslo.limit master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72856719:54
openstackgerritAndreas Jaeger proposed openstack/oslo.log master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72856819:56
openstackgerritAndreas Jaeger proposed openstack/openstackdocstheme master: WIP: Add cross-tests for nova  https://review.opendev.org/72837720:24
*** iurygregory has joined #openstack-oslo20:42
*** raildo_ has joined #openstack-oslo21:06
*** raildo has quit IRC21:08
*** raildo_ has quit IRC21:57
*** tosky has quit IRC23:39

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!