| AJaeger | stephenfin: https://zuul.opendev.org/t/openstack/build/a7a2839bb13a46049c674108b7efd098 - failure in nova with new openstackdocstheme | 06:52 |
|---|---|---|
| AJaeger | stephenfin: https://review.opendev.org/#/c/727850/ is the change, and PDF fails, so melwitt thinks https://review.opendev.org/#/c/682683/ is the culprit | 06:53 |
| *** ralonsoh has joined #openstack-oslo | 06:55 | |
| *** tosky has joined #openstack-oslo | 07:31 | |
| *** dtantsur|afk is now known as dtantsur | 07:32 | |
| *** rpittau|afk is now known as rpittau | 07:33 | |
| openstackgerrit | Stephen Finucane proposed openstack/openstackdocstheme master: Restore configuration of 'latex_engine' https://review.opendev.org/727992 | 09:31 |
| stephenfin | AJaeger: ^ | 09:31 |
| AJaeger | stephenfin: LGTM, thanks. Merge and new release? | 09:32 |
| stephenfin | Sounds good | 09:32 |
| AJaeger | smcginnis, hberaud : could you check 727992 ^, please? | 09:32 |
| AJaeger | stephenfin: will you push the release, please? I'm busy rest of day... | 09:33 |
| stephenfin | sure, np | 09:33 |
| hberaud | omw | 09:33 |
| AJaeger | thanks | 09:34 |
| *** rpittau is now known as rpittau|bbl | 10:18 | |
| openstackgerrit | melissaml proposed openstack/futurist master: Remove translation sections from setup.cfg https://review.opendev.org/728022 | 10:49 |
| openstackgerrit | Andreas Jaeger proposed openstack/tooz master: Switch to Victoria tests https://review.opendev.org/726520 | 11:14 |
| openstackgerrit | Andreas Jaeger proposed openstack/tooz master: Add nose as test-requirement https://review.opendev.org/728032 | 11:14 |
| AJaeger | stephenfin: btw. on openstack-manuals, the new theme works fine, see https://review.opendev.org/727860 and https://review.opendev.org/727862 - but no noticable benefit from parallel building | 11:24 |
| openstackgerrit | Merged openstack/oslo.messaging master: Remove six usage https://review.opendev.org/726746 | 11:30 |
| smcginnis | I wonder if that will show more benefit on a local worskstation build where someone likely has more cores available than we have on our test nodes. | 11:30 |
| openstackgerrit | Merged openstack/openstackdocstheme master: Restore configuration of 'latex_engine' https://review.opendev.org/727992 | 11:33 |
| openstackgerrit | Merged openstack/oslo.cache master: Remove unneeded babel.cfg etc https://review.opendev.org/726517 | 11:33 |
| AJaeger | smcginnis: local building time for the docs on my workstation: 14s real time vs 10s (parallel). Zuul needs around 7 minutes (including node setup, pip install) | 11:37 |
| smcginnis | What are you going to do with those extra 4 seconds of free time? :) | 11:38 |
| AJaeger | that's too little to do something meaningfull ;( | 11:38 |
| openstackgerrit | Merged openstack/oslo.cache master: Remove six https://review.opendev.org/726516 | 11:46 |
| openstackgerrit | Merged openstack/oslo.cache master: Small cleanups in tox.ini https://review.opendev.org/726518 | 11:46 |
| AJaeger | hberaud, stephenfin , could you check https://review.opendev.org/726519 for oslo.cache to update jobs for Victoria, please? | 11:49 |
| hberaud | AJaeger: omw | 11:49 |
| AJaeger | and also for debtcollector, please: https://review.opendev.org/726523 | 11:50 |
| AJaeger | thanks, hberaud | 11:50 |
| hberaud | np | 11:50 |
| hberaud | AJaeger: done | 11:52 |
| AJaeger | great | 11:54 |
| *** tkajinam has quit IRC | 12:01 | |
| *** raildo has joined #openstack-oslo | 12:06 | |
| *** rpittau|bbl is now known as rpittau | 12:15 | |
| *** kgiusti has joined #openstack-oslo | 12:29 | |
| *** hberaud has quit IRC | 12:31 | |
| *** hberaud has joined #openstack-oslo | 12:31 | |
| AJaeger | I have a build fix for tooz and a job update to Victoria, please review https://review.opendev.org/#/c/728032 and https://review.opendev.org/#/c/726520/ | 12:33 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: Adding functional tests https://review.opendev.org/712479 | 12:45 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: Refactoring functional tests based on standard usages https://review.opendev.org/718223 | 12:45 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: Adding functional tests for memcache_pool backend https://review.opendev.org/718176 | 12:45 |
| *** hoonetorg has quit IRC | 13:16 | |
| openstackgerrit | Merged openstack/debtcollector master: Switch to Victoria tests https://review.opendev.org/726523 | 13:22 |
| *** hoonetorg has joined #openstack-oslo | 13:22 | |
| openstackgerrit | Andreas Jaeger proposed openstack/oslo.cache master: Fix pep8 failure https://review.opendev.org/728078 | 13:25 |
| AJaeger | argh, why does this fail now? ^ | 13:25 |
| *** moguimar has joined #openstack-oslo | 13:47 | |
| openstackgerrit | Merged openstack/futurist master: Remove translation sections from setup.cfg https://review.opendev.org/728022 | 13:54 |
| jkulik | hi stephenfin, thanks for your answer regarding oslo.vmware. a quick question: does the swapping of suds with zeep and the needed changes for compatibility need some kind of blueprint or something? | 14:19 |
| stephenfin | jkulik: that's probably a good question for bnemec, actually. I don't think I've ever submitted a blueprint for oslo | 14:20 |
| bnemec | jkulik: It probably wouldn't hurt to fill out the spec template describing the reasons for the change: https://opendev.org/openstack/oslo-specs/src/branch/master/specs/template.rst | 14:24 |
| bnemec | If for no other reason than so you have something easy to point people to when they ask "why did you choose zeep" or "why are you doing this at all?" | 14:24 |
| bnemec | Also, I need to remove the incubation section from that. Incubator no longer exists. | 14:26 |
| openstackgerrit | Ben Nemec proposed openstack/oslo-specs master: Remove incubation section from template.rst https://review.opendev.org/728101 | 14:27 |
| smcginnis | jkulik: Just to make sure you're aware, zeep will need to be added to the global-requirements before a project can start using it. | 14:37 |
| smcginnis | jkulik: Some details can be found here: https://docs.openstack.org/project-team-guide/dependency-management.html#for-new-requirements | 14:37 |
| smcginnis | Basically just need to propose a patch to openstack/requirements to add it to global-requirements.txt and upper-constraints.txt and answer those questions in the commit message. | 14:37 |
| jkulik | ok. let's see how far I can get. I'll ask again if needed. :) | 14:38 |
| jkulik | thank you both | 14:38 |
| smcginnis | Thanks for working on that. | 14:38 |
| AJaeger | https://review.opendev.org/#/c/728078/ fixes a pep8 failure in oslo.cache that suddenly showed up, could I get a second +2, please? | 15:06 |
| openstackgerrit | Andreas Jaeger proposed openstack/oslo.cache master: Fix pep8 failure https://review.opendev.org/728078 | 15:41 |
| AJaeger | bnemec: good catch, thanks. Now, we should be fine - the victoria tests add pep8... | 15:43 |
| bnemec | AJaeger: Yeah, I saw that on your other patch. Was confused for a bit there though. :-) | 15:43 |
| AJaeger | bnemec: yes, I was surprised as well | 15:44 |
| bnemec | I kind of wonder how it missed the ussuri job bump too. | 15:45 |
| AJaeger | tooz has the same problem: https://review.opendev.org/726520 is approved but needs https://review.opendev.org/#/c/728032/1 reviewed | 15:51 |
| *** hoonetorg has quit IRC | 15:56 | |
| *** rpittau is now known as rpittau|afk | 16:01 | |
| *** hoonetorg has joined #openstack-oslo | 16:08 | |
| *** hberaud has quit IRC | 16:12 | |
| *** hberaud has joined #openstack-oslo | 16:13 | |
| *** dtantsur is now known as dtantsur|afk | 16:44 | |
| *** hoonetorg has quit IRC | 17:05 | |
| *** hoonetorg has joined #openstack-oslo | 17:19 | |
| openstackgerrit | Merged openstack/tooz master: Add nose as test-requirement https://review.opendev.org/728032 | 18:09 |
| *** ralonsoh has quit IRC | 18:21 | |
| openstackgerrit | Merged openstack/oslo.cache master: Fix pep8 failure https://review.opendev.org/728078 | 19:06 |
| openstackgerrit | Andreas Jaeger proposed openstack/oslo.cache master: Switch to newer openstackdocstheme and reno versions https://review.opendev.org/728267 | 19:42 |
| openstackgerrit | Andreas Jaeger proposed openstack/oslo.concurrency master: Switch to newer openstackdocstheme and reno versions https://review.opendev.org/728269 | 19:44 |
| openstackgerrit | Andreas Jaeger proposed openstack/oslo.concurrency master: Switch to newer openstackdocstheme and reno versions https://review.opendev.org/728269 | 19:48 |
| openstackgerrit | Andreas Jaeger proposed openstack/oslo.cache master: Switch to newer openstackdocstheme and reno versions https://review.opendev.org/728267 | 19:53 |
| *** raildo_ has joined #openstack-oslo | 19:58 | |
| *** raildo has quit IRC | 20:01 | |
| AJaeger | stephenfin: novaclient is failing docs building, see https://review.opendev.org/728270 . Any idea? | 20:02 |
| melwitt | I was just looking at that, that is unexpected bc that is the same error I got before configuring latex_engine = 'xelatex' | 20:05 |
| melwitt | so restoring it should have fixed it ... I am confused | 20:05 |
| AJaeger | and docs building fails as well on nova - https://review.opendev.org/728263 | 20:08 |
| AJaeger | melwitt: I share your confusion | 20:08 |
| melwitt | yeah so... to fix it, the earlier version of my patch was only setting latex_engine = 'xelatex' and that made the "Package inputenc Error: Unicode char" disappear. then the next error was about missing fonts, so I added those to bindep.txt. then it started passing again | 20:09 |
| melwitt | so based on that, I know it's the latex_engine setting, so somehow it's not being reflected :\ | 20:09 |
| AJaeger | melwitt: let's see whether your change to update bindep.txt makes nova pass... | 20:10 |
| * melwitt nods | 20:10 | |
| AJaeger | I hope stephenfin has an idea tomorrow since I have none quickly - and need to leave now. | 20:11 |
| melwitt | AJaeger: you know what, I bet it's somehow already defaulted to 'pdflatex' or something, so the 'if not app.config.latex_engine:' logic isn't returning True | 20:21 |
| smcginnis | That seems like a good possiblity. | 20:26 |
| smcginnis | melwitt: I think the change was that the theme settings would completely overwrite the local settings. Have you compared each to see what else might be different between the two? | 20:28 |
| melwitt | yeah, I think that has to be it. I'm seeing if I can figure out where 'app' comes from and how it's initialized | 20:28 |
| melwitt | because the only difference between the old code and the new is that the new is checking 'if not app.config.latex_engine:' before setting it. old code just used to set it regardless | 20:28 |
| melwitt | 'pdflatex' is the default https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-latex_engine | 20:30 |
| melwitt | afaict, the 'app' represents the sphinx process, so likely when you point it at a dir, it will look for conf.py and take specified settings, else it fills in with defaults. so the question is whether there's a mechanism for allowing sphinx extensions to provide config defaults | 20:45 |
| *** raildo_ has quit IRC | 20:47 | |
| *** raildo_ has joined #openstack-oslo | 20:47 | |
| *** adrianc has quit IRC | 21:10 | |
| openstackgerrit | Merged openstack/oslo.config master: Cap flake8 to be < 3.8.0 https://review.opendev.org/727236 | 21:15 |
| openstackgerrit | Ben Nemec proposed openstack/oslo.config stable/ussuri: Cap flake8 to be < 3.8.0 https://review.opendev.org/727265 | 21:18 |
| *** raildo_ has quit IRC | 21:49 | |
| *** tkajinam has joined #openstack-oslo | 22:58 | |
| *** tosky has quit IRC | 23:05 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!