| *** zz_dimtruck is now known as dimtruck | 00:00 | |
| *** mriedem has left #openstack-oslo | 00:12 | |
| *** dimtruck is now known as zz_dimtruck | 00:13 | |
| *** sputnik13 has quit IRC | 00:18 | |
| *** sputnik13 has joined #openstack-oslo | 00:19 | |
| *** mriedem has joined #openstack-oslo | 00:19 | |
| *** amrith is now known as _amrith_ | 00:21 | |
| *** sputnik13 has quit IRC | 00:23 | |
| *** mtanino__ has joined #openstack-oslo | 00:27 | |
| *** mtanino has quit IRC | 00:28 | |
| *** mtanino__ has quit IRC | 00:33 | |
| *** achanda has quit IRC | 00:40 | |
| *** _amrith_ is now known as amrith | 00:40 | |
| *** vilobhmm111 has quit IRC | 00:41 | |
| *** vilobhmm11 has joined #openstack-oslo | 00:46 | |
| *** browne has quit IRC | 00:47 | |
| *** zz_dimtruck is now known as dimtruck | 00:54 | |
| *** jimbobhickville has joined #openstack-oslo | 00:58 | |
| *** harlowja has quit IRC | 01:00 | |
| *** harlowja has joined #openstack-oslo | 01:03 | |
| *** achanda has joined #openstack-oslo | 01:18 | |
| *** EinstCrazy has joined #openstack-oslo | 01:29 | |
| *** zqfan has joined #openstack-oslo | 01:54 | |
| *** amrith is now known as _amrith_ | 01:59 | |
| *** salv-orlando has joined #openstack-oslo | 02:03 | |
| *** mriedem has quit IRC | 02:16 | |
| *** browne has joined #openstack-oslo | 02:16 | |
| *** salv-orlando has quit IRC | 02:23 | |
| *** salv-orlando has joined #openstack-oslo | 02:28 | |
| *** salv-orlando has quit IRC | 02:33 | |
| *** jimbobhickville has quit IRC | 02:34 | |
| *** EinstCrazy has quit IRC | 02:35 | |
| *** EinstCrazy has joined #openstack-oslo | 02:36 | |
| *** edmondsw has quit IRC | 02:36 | |
| *** yamamoto_ has joined #openstack-oslo | 02:37 | |
| *** gcb has quit IRC | 02:47 | |
| *** eliqiao has quit IRC | 03:01 | |
| *** openstackstatus has quit IRC | 03:01 | |
| *** eliqiao has joined #openstack-oslo | 03:02 | |
| *** gcb has joined #openstack-oslo | 03:08 | |
| *** achanda has quit IRC | 03:09 | |
| *** yamamoto_ has quit IRC | 03:20 | |
| *** dimtruck is now known as zz_dimtruck | 03:32 | |
| *** salv-orlando has joined #openstack-oslo | 03:50 | |
| *** sekrit has quit IRC | 03:51 | |
| *** salv-orlando has quit IRC | 03:52 | |
| *** salv-orlando has joined #openstack-oslo | 03:53 | |
| *** salv-orlando has quit IRC | 03:58 | |
| *** jamespage has quit IRC | 04:00 | |
| *** jamespage has joined #openstack-oslo | 04:01 | |
| *** sekrit has joined #openstack-oslo | 04:05 | |
| *** yamamoto_ has joined #openstack-oslo | 04:10 | |
| *** links has joined #openstack-oslo | 04:12 | |
| *** amotoki has joined #openstack-oslo | 04:20 | |
| *** achanda has joined #openstack-oslo | 04:22 | |
| *** achanda has quit IRC | 04:37 | |
| *** eliqiao_ has joined #openstack-oslo | 04:43 | |
| *** eliqiao has quit IRC | 04:44 | |
| *** salv-orlando has joined #openstack-oslo | 04:57 | |
| *** salv-orlando has quit IRC | 05:01 | |
| *** achanda has joined #openstack-oslo | 05:03 | |
| *** salv-orlando has joined #openstack-oslo | 05:11 | |
| *** harlowja_at_home has joined #openstack-oslo | 05:17 | |
| openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: wip: [zmq] Fix cast message loss in simulator https://review.openstack.org/302514 | 05:21 |
|---|---|---|
| *** achanda has quit IRC | 05:33 | |
| *** Will_wj has quit IRC | 05:39 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Make it easier to restart/resume a prior reverted flow https://review.openstack.org/301939 | 05:42 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.messaging: Make transport_url config option secret https://review.openstack.org/299140 | 05:43 |
| *** rcernin has joined #openstack-oslo | 05:45 | |
| *** nkrinner has joined #openstack-oslo | 05:49 | |
| *** achanda has joined #openstack-oslo | 05:59 | |
| *** lpetrut has joined #openstack-oslo | 06:05 | |
| *** ksnihyr has joined #openstack-oslo | 06:08 | |
| *** harlowja_at_home has quit IRC | 06:12 | |
| *** dukhlov has joined #openstack-oslo | 06:20 | |
| *** achanda has quit IRC | 06:22 | |
| *** pcaruana has joined #openstack-oslo | 06:26 | |
| *** eliqiao_ is now known as eliqiao | 06:28 | |
| *** dukhlov has quit IRC | 06:31 | |
| *** dukhlov has joined #openstack-oslo | 06:32 | |
| *** dukhlov has quit IRC | 06:34 | |
| *** tesseract has joined #openstack-oslo | 06:45 | |
| *** tesseract is now known as Guest12876 | 06:45 | |
| *** salv-orlando has quit IRC | 06:52 | |
| *** dukhlov has joined #openstack-oslo | 06:59 | |
| *** EinstCra_ has joined #openstack-oslo | 06:59 | |
| *** EinstCrazy has quit IRC | 07:02 | |
| openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: wip: tests: rabbitmq failover test https://review.openstack.org/301771 | 07:11 |
| *** ihrachys has joined #openstack-oslo | 07:11 | |
| *** lpetrut has quit IRC | 07:21 | |
| *** jpena|off is now known as jpean | 07:44 | |
| *** jpean is now known as jpena | 07:44 | |
| *** jamielennox is now known as jamielennox|away | 07:45 | |
| *** browne has quit IRC | 07:47 | |
| *** dukhlov has quit IRC | 07:47 | |
| *** shardy has joined #openstack-oslo | 07:47 | |
| *** dukhlov has joined #openstack-oslo | 07:50 | |
| *** dukhlov has quit IRC | 07:54 | |
| *** salv-orlando has joined #openstack-oslo | 07:54 | |
| *** dukhlov has joined #openstack-oslo | 07:55 | |
| *** dukhlov has quit IRC | 07:58 | |
| *** dukhlov has joined #openstack-oslo | 08:00 | |
| *** yassine__ has joined #openstack-oslo | 08:07 | |
| *** salv-orlando has quit IRC | 08:10 | |
| *** dukhlov has quit IRC | 08:17 | |
| *** dukhlov has joined #openstack-oslo | 08:20 | |
| *** salv-orlando has joined #openstack-oslo | 08:26 | |
| *** dukhlov has quit IRC | 08:27 | |
| *** dukhlov has joined #openstack-oslo | 08:29 | |
| *** openstackstatus has joined #openstack-oslo | 08:29 | |
| *** ChanServ sets mode: +v openstackstatus | 08:29 | |
| openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: wip: tests: rabbitmq failover test https://review.openstack.org/301771 | 08:31 |
| -openstackstatus- NOTICE: jobs depending on npm are now working again | 08:34 | |
| *** dukhlov has quit IRC | 08:38 | |
| *** dukhlov has joined #openstack-oslo | 08:40 | |
| *** dukhlov has quit IRC | 08:42 | |
| *** dukhlov has joined #openstack-oslo | 08:46 | |
| openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: tests: allow to override the functionnal tests suite args https://review.openstack.org/302600 | 08:46 |
| *** dukhlov has quit IRC | 08:48 | |
| *** dukhlov has joined #openstack-oslo | 08:49 | |
| *** ndipanov has joined #openstack-oslo | 08:50 | |
| *** cdent has joined #openstack-oslo | 08:50 | |
| *** e0ne has joined #openstack-oslo | 08:50 | |
| *** EinstCra_ is now known as EinstCrazy | 08:51 | |
| *** dukhlov has quit IRC | 08:51 | |
| *** salv-orl_ has joined #openstack-oslo | 08:52 | |
| *** salv-orlando has quit IRC | 08:55 | |
| *** vilobhmm11 has quit IRC | 09:09 | |
| *** lpetrut has joined #openstack-oslo | 09:28 | |
| *** links has quit IRC | 09:31 | |
| *** yamamoto_ has quit IRC | 09:40 | |
| *** links has joined #openstack-oslo | 09:44 | |
| *** ndipanov has quit IRC | 09:53 | |
| *** mhickey has joined #openstack-oslo | 09:54 | |
| *** ndipanov has joined #openstack-oslo | 09:54 | |
| *** achanda has joined #openstack-oslo | 09:56 | |
| *** obondarev has quit IRC | 10:00 | |
| *** achanda has quit IRC | 10:02 | |
| *** obondarev has joined #openstack-oslo | 10:06 | |
| *** obondarev has quit IRC | 10:12 | |
| *** ozamiatin has joined #openstack-oslo | 10:12 | |
| *** Kiall has quit IRC | 10:14 | |
| *** Kiall has joined #openstack-oslo | 10:14 | |
| *** cdent has quit IRC | 10:16 | |
| *** sdague has joined #openstack-oslo | 10:20 | |
| *** EinstCrazy has quit IRC | 10:30 | |
| *** obondarev has joined #openstack-oslo | 10:31 | |
| *** mhickey has quit IRC | 10:35 | |
| *** links has quit IRC | 10:39 | |
| openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: [zmq] Fix cast message loss in simulator https://review.openstack.org/302514 | 10:41 |
| *** yamamoto has joined #openstack-oslo | 10:42 | |
| *** Guest12876 is now known as tesseract | 10:47 | |
| *** tesseract is now known as Guest74036 | 10:48 | |
| *** mhickey has joined #openstack-oslo | 10:50 | |
| *** andymaier has joined #openstack-oslo | 10:53 | |
| *** links has joined #openstack-oslo | 10:56 | |
| *** achanda has joined #openstack-oslo | 10:58 | |
| *** pblaho has joined #openstack-oslo | 11:03 | |
| *** achanda has quit IRC | 11:03 | |
| *** yamamoto has quit IRC | 11:04 | |
| *** yamamoto has joined #openstack-oslo | 11:06 | |
| *** cdent has joined #openstack-oslo | 11:14 | |
| *** dukhlov has joined #openstack-oslo | 11:23 | |
| *** john_bar has quit IRC | 11:29 | |
| *** _amrith_ is now known as amrith | 11:44 | |
| *** jhesketh has joined #openstack-oslo | 11:50 | |
| *** ChanServ changes topic to "#openstack-oslo" | 11:50 | |
| *** asarfaty has joined #openstack-oslo | 11:52 | |
| asarfaty | Hi guys, I want to add a new Opt type in the oslo.config, for ports list. Could you please help me understand the number of version I should write as the version added for this type? | 11:53 |
| *** cdent has quit IRC | 11:55 | |
| *** gordc has joined #openstack-oslo | 11:55 | |
| dims | @asarfaty : we have 3.9.0 now (https://pypi.python.org/pypi/oslo.config/) so probably 3.10.0? | 11:57 |
| *** cdent has joined #openstack-oslo | 11:59 | |
| *** andymaier has quit IRC | 11:59 | |
| asarfaty | @dims : Thanks | 12:04 |
| *** EinstCrazy has joined #openstack-oslo | 12:06 | |
| *** lpetrut has quit IRC | 12:07 | |
| *** jhesketh has quit IRC | 12:07 | |
| *** lpetrut has joined #openstack-oslo | 12:07 | |
| dims | @asarfaty : hopefully others will chime in during review | 12:07 |
| *** achanda has joined #openstack-oslo | 12:07 | |
| *** jhesketh has joined #openstack-oslo | 12:07 | |
| openstackgerrit | Dmitry Mescheryakov (dmitryme) proposed openstack/oslo.messaging: Allow simulator to be launched from arbitrary directory https://review.openstack.org/302708 | 12:11 |
| openstackgerrit | Adit Sarfaty proposed openstack/oslo.config: Add PortList Opt to support configuration of a list of tcp/ip ports https://review.openstack.org/302711 | 12:14 |
| *** achanda has quit IRC | 12:15 | |
| *** asarfaty has quit IRC | 12:19 | |
| *** edmondsw has joined #openstack-oslo | 12:23 | |
| *** salv-orl_ has quit IRC | 12:28 | |
| *** pradk has joined #openstack-oslo | 12:34 | |
| *** kgiusti has joined #openstack-oslo | 12:34 | |
| *** jpena is now known as jpena|lunch | 12:35 | |
| *** lucasagomes has quit IRC | 12:37 | |
| *** lucasagomes has joined #openstack-oslo | 12:38 | |
| *** salv-orlando has joined #openstack-oslo | 12:40 | |
| *** lucasagomes has quit IRC | 12:45 | |
| *** lucasagomes has joined #openstack-oslo | 12:46 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 12:47 | |
| *** achanda has joined #openstack-oslo | 12:47 | |
| *** achanda has quit IRC | 12:58 | |
| *** rlrossit has joined #openstack-oslo | 13:02 | |
| *** achanda has joined #openstack-oslo | 13:08 | |
| openstackgerrit | Sean Dague proposed openstack/oslo.context: WIP: alternate approach to context building https://review.openstack.org/302744 | 13:12 |
| sdague | rbradfor: so this is a different approach on the context which I thought was easier to push a random patch to show instead of comment on yours in gerrit | 13:12 |
| sdague | I expect this is throw away, but it should get the concept across | 13:12 |
| *** achanda has quit IRC | 13:13 | |
| *** jimbobhickville has joined #openstack-oslo | 13:16 | |
| *** dukhlov has quit IRC | 13:25 | |
| *** dukhlov has joined #openstack-oslo | 13:26 | |
| *** mriedem has joined #openstack-oslo | 13:26 | |
| *** cdent has quit IRC | 13:31 | |
| *** yamamoto has quit IRC | 13:40 | |
| *** jpena|lunch is now known as jpena | 13:41 | |
| *** links has quit IRC | 13:46 | |
| *** yamamoto has joined #openstack-oslo | 13:57 | |
| *** cdent has joined #openstack-oslo | 13:59 | |
| rbradfor | sdague, looking | 14:00 |
| *** yamahata has joined #openstack-oslo | 14:01 | |
| rbradfor | sdague, so I've been looking at the mess that is context building of headers. | 14:01 |
| rbradfor | your approach is clean as it doesn't consider all of the deprecated approaches. | 14:02 |
| rbradfor | user_id = req.headers.get('X_USER_ID', req.headers.get('X_USER')), uth_token = req.headers.get('X_AUTH_TOKEN', req.headers.get('X_STORAGE_TOKEN')) and the whole X_TENANT_ID/X_TENANT handling. I was trying to think of an agnositic approach. | 14:03 |
| *** yamamoto has quit IRC | 14:03 | |
| rbradfor | you have just assumed these legacy things are no longer applicable. I really like that, but I do not know the status of compatibility needs. | 14:04 |
| rbradfor | sdague, another consideration, is in what use cases of instances are these _name variables needing to be defined, if generally always via middleware, then passing them just as environ is an approach we should standardize on. | 14:06 |
| rbradfor | futhermore, taking the kwargs approach further, there subclassed contexts, that just set X, by enabling oslo_context to accept a project specific set of keys, we can further reduce per project divergence of the base class. | 14:08 |
| *** nkrinner has quit IRC | 14:12 | |
| krotscheck | Any cores around? I've got a stack of middleware patches that are wedged on https://review.openstack.org/#/c/291381/ | 14:15 |
| patchbot | krotscheck: patch 291381 - oslo.middleware - Retain reference to GroupAttrs in CORS middleware | 14:15 |
| krotscheck | Not wedged. Blocked. | 14:15 |
| openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: wip: [kafka] Add functional gate job for notifications https://review.openstack.org/302797 | 14:16 |
| *** yamamoto has joined #openstack-oslo | 14:29 | |
| openstackgerrit | Kirill Bespalov proposed openstack/oslo.messaging: Replace all direct imports of python logging module with oslo.log https://review.openstack.org/302811 | 14:30 |
| *** zz_dimtruck is now known as dimtruck | 14:30 | |
| *** ozamiatin has quit IRC | 14:32 | |
| *** psanchez has quit IRC | 14:33 | |
| rbradfor | sdague, can I take https://review.openstack.org/#/c/302744 and clean it up! | 14:46 |
| sdague | rbradfor: cool, great | 14:48 |
| sdague | sorry, was on a call so missed your earlier messages | 14:48 |
| rbradfor | np | 14:48 |
| rbradfor | I added some comments to your review, includes some of my research | 14:48 |
| sdague | rbradfor: I was wondering about the deprecated options | 14:49 |
| sdague | but I didn't really go there | 14:49 |
| sdague | so... the other thing we could do | 14:49 |
| sdague | is make a RequestContext2 which is the clean new version | 14:50 |
| rbradfor | i was just taking the low road first, incrementally adding attributes, that we could plug into to, your starting with the high road of a longer term goal, and honestly why tinker around the edges, lets just role with a solid change and see how it works out, got plenty of time in cycle | 14:50 |
| sdague | then get projects to cut over to that | 14:50 |
| sdague | so that we don't need the complexity of deprecated handling bits in the main logic | 14:50 |
| rbradfor | I think the deprecation complexity goes back to middleware to sort out, we keep context clean. | 14:51 |
| sdague | ok cool | 14:51 |
| rbradfor | I don't see a need for a RequestContext2, lets' just get this right and see it is backwards compatible to enable changes to projects. | 14:52 |
| *** salv-orl_ has joined #openstack-oslo | 14:52 | |
| rbradfor | I'll clean this up, and add some more thoughts I have today. I'm on vacation from tomorrow so would like to get a passing version for feedback. | 14:52 |
| *** salv-orl_ has quit IRC | 14:53 | |
| sdague | rbradfor: cool | 14:53 |
| sdague | honestly, I think the X_TENANT_ID / X_TENANT code in nova is super old, and I wouldn't worry about it in oslo.context | 14:54 |
| rbradfor | sdague, you were just more aggressive in ripping this apart as a single change, I need to be more aggressive. | 14:54 |
| *** salv-orlando has quit IRC | 14:54 | |
| rbradfor | yep, I'm going to assume project middleware can work out that deprecated stuff. | 14:54 |
| sdague | because I think what ends up happening is step one, we get nova to pass the request env down | 14:54 |
| sdague | then we just stop it reading most of the env vars that oslo.context does | 14:54 |
| rbradfor | funny, I have a draft policy on better deprecation management, this is another example of no tracking on physical removal | 14:55 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 14:55 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:55 | |
| sdague | yeh, I think it's one of those things where it was working with different behaviors of keystone middleware, and just no one did the cleanup when they could | 14:55 |
| sdague | as it's not super clear when that would happen | 14:56 |
| sdague | we need to optimize for delete more often | 14:56 |
| rbradfor | well perhaps it's a cycle to push that discussion thru. | 14:56 |
| rbradfor | sdague, why did you add domain_name? | 14:57 |
| sdague | rbradfor: laziness? | 14:57 |
| sdague | this wasn't 100% right, I was just trying to sketch the concept | 14:58 |
| sdague | of env parsing during __init__ | 14:58 |
| sdague | and processing kwargs for overrides | 14:58 |
| sdague | all from a central master list | 14:58 |
| *** regXboi has joined #openstack-oslo | 14:58 | |
| openstackgerrit | Merged openstack/oslo.messaging: Make transport_url config option secret https://review.openstack.org/299140 | 15:05 |
| *** Guest74036 has quit IRC | 15:10 | |
| *** ksnihyr has quit IRC | 15:16 | |
| *** achanda has joined #openstack-oslo | 15:24 | |
| *** yamahata has quit IRC | 15:26 | |
| openstackgerrit | Kirill Bespalov proposed openstack/oslo.messaging: Replace all direct imports of python logging module with oslo.log https://review.openstack.org/302811 | 15:31 |
| rbradfor | sdague, so, just updated a version (see review), it didn't quite work out as planned, I had to make a few compromises, perhaps you can weigh in | 15:32 |
| sdague | oslo.context changes not reporting in here? | 15:32 |
| rbradfor | sdague, I noticed that, I don't know why, but its there | 15:33 |
| rbradfor | bot fail! | 15:33 |
| sdague | is it listed in project-config? | 15:33 |
| rbradfor | plenty of other reviews for olso.context hit this channel | 15:33 |
| sdague | oh, you are right | 15:34 |
| sdague | hmmm | 15:34 |
| rbradfor | sdague, anyway, a few things that bother me. | 15:34 |
| rbradfor | I wanted to take your CONTEXT_ATTR idea and extend to attributes to set, but not have (at least yet) any environment component, but I ran foul of boolean defaults | 15:35 |
| sdague | rbradfor: hmmm... I'm not sure exactly what you are saying there | 15:35 |
| *** links has joined #openstack-oslo | 15:36 | |
| sdague | also, is there a reason you didn't fill in the DOMAIN bits with headers? | 15:36 |
| sdague | the domain vars are listed here - http://docs.openstack.org/developer/keystonemiddleware/api/keystonemiddleware.auth_token.html#what-auth-token-adds-to-the-request-for-use-by-the-openstack-service | 15:36 |
| *** EinstCrazy has quit IRC | 15:36 | |
| *** mtanino has joined #openstack-oslo | 15:37 | |
| *** achanda has quit IRC | 15:37 | |
| rbradfor | sdague, See L42-43,51,52, given there is DOMAIN_ID and DOMAIN_NAME I'll add those. | 15:37 |
| rbradfor | so see lines 51,52 | 15:38 |
| rbradfor | but this does not work for is_admin L79 | 15:38 |
| sdague | right | 15:38 |
| rbradfor | so it's usefullness was not as indented. | 15:39 |
| sdague | honestly, my feeling is that only things which have keystone vars should be in this list | 15:39 |
| sdague | and everything else is just handed as a named parameter in __init__ | 15:39 |
| sdague | is_admin is one of those things that gets used when you need to create a context to do arbitrary db actions | 15:40 |
| sdague | because it can pass all the policy checks | 15:40 |
| rbradfor | ok, so I can see we could go back to middleware only variables. | 15:40 |
| sdague | http://codesearch.openstack.org/?q=get_admin_context&i=nope&files=&repos= | 15:41 |
| rbradfor | I know of the various usages for the booleans, is_admin, overwrite etc | 15:42 |
| sdague | rbradfor: right, I think my point is that typically contexts built with is_admin are done on the fly as ephemeral things in code | 15:43 |
| sdague | kind of an in code sudo | 15:43 |
| sdague | that is orthoginal to the request context that was created | 15:43 |
| sdague | from the wsgi request | 15:44 |
| rbradfor | a context request is created for multiple purposes. | 15:44 |
| sdague | so it's always going to be a thing you explicity ask for | 15:44 |
| sdague | sure | 15:44 |
| rbradfor | ok, I'll revert to keystone only attributes | 15:44 |
| sdague | yeh, that seems simpler | 15:45 |
| *** links has quit IRC | 15:48 | |
| *** browne has joined #openstack-oslo | 15:53 | |
| *** pcaruana has quit IRC | 15:53 | |
| rbradfor | you know if we overload CONTEXT_ATTRS with additional entries, we get _ids for free (e.g. project_id, user_id), and even project and tenant | 15:53 |
| rbradfor | I just don't know how we could then ever deprecate the user,project,tenant etc (non id) attributes | 15:54 |
| rbradfor | sdague, it would not populate them accordingly if passed as kwarg (e.g. passing user_id would not populate user) | 15:56 |
| sdague | rbradfor: right that was actually part of the reason I set up that datastructure that way | 15:57 |
| sdague | however, I agree, that means we can't deprecate them because they are auto filled | 15:57 |
| openstackgerrit | Ronald Bradford proposed openstack/oslo.context: WIP: alternate approach to context building https://review.openstack.org/302744 | 15:57 |
| sdague | I would tend to pick the names we eventually want here | 15:57 |
| sdague | which seem like they should all end in _id or _name for clarity | 15:58 |
| sdague | and do custom folding of any legacy attributes you think we want | 15:58 |
| rbradfor | sdague, hence https://review.openstack.org/#/c/290907/ | 15:58 |
| patchbot | rbradfor: patch 290907 - oslo-specs - Standardize Context Arguments spec | 15:58 |
| sdague | right | 15:58 |
| rbradfor | perhaps after vacation I'll just do that, I find all the duplication across multiple projects for _id's really annoying | 15:59 |
| *** dukhlov has quit IRC | 16:02 | |
| *** mtanino has quit IRC | 16:02 | |
| *** mtanino has joined #openstack-oslo | 16:03 | |
| sdague | yeh | 16:04 |
| sdague | rbradfor: when are you back from vacation? | 16:05 |
| rbradfor | sdague, Apr 21st? | 16:06 |
| *** yamamoto has quit IRC | 16:06 | |
| *** yamahata has joined #openstack-oslo | 16:07 | |
| sdague | ok cool | 16:08 |
| *** e0ne has quit IRC | 16:08 | |
| sdague | so basically back, regroup, then Austin? | 16:08 |
| rbradfor | sdague, yes | 16:09 |
| *** e0ne has joined #openstack-oslo | 16:09 | |
| sdague | ok, so who else do we need to review context changes? | 16:11 |
| rbradfor | I have some other context stuff I'd like to see happen, so perhaps just do it and see what people say! It can be tough because of the project dependencies, and when core patches get stuck in limbo I get a lot of half done things | 16:11 |
| sdague | because I'd love to get that context building one out there | 16:11 |
| rbradfor | sdague, well, I've invalidated myself, but I'll push for feedback, dhellmann has a good grasp of it | 16:12 |
| *** ksnihyr has joined #openstack-oslo | 16:14 | |
| sdague | ok, I'm going to get a bit of outside time before the rain comes. | 16:15 |
| *** mhickey has quit IRC | 16:17 | |
| *** david-lyle has quit IRC | 16:36 | |
| *** browne has quit IRC | 16:37 | |
| *** e0ne has quit IRC | 16:42 | |
| *** pblaho has quit IRC | 16:49 | |
| *** pblaho has joined #openstack-oslo | 16:51 | |
| *** rcernin has quit IRC | 16:52 | |
| *** lpetrut has quit IRC | 17:00 | |
| *** zqfan has quit IRC | 17:02 | |
| *** jpena is now known as jpena|off | 17:03 | |
| *** yamahata has quit IRC | 17:06 | |
| *** david-lyle has joined #openstack-oslo | 17:06 | |
| *** yamamoto has joined #openstack-oslo | 17:07 | |
| *** pcaruana has joined #openstack-oslo | 17:08 | |
| *** david-lyle has quit IRC | 17:11 | |
| *** salv-orlando has joined #openstack-oslo | 17:12 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.service: Updated from global requirements https://review.openstack.org/302988 | 17:13 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.utils: Updated from global requirements https://review.openstack.org/302989 | 17:13 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.versionedobjects: Updated from global requirements https://review.openstack.org/302990 | 17:13 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslotest: Updated from global requirements https://review.openstack.org/302991 | 17:13 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/pycadf: Updated from global requirements https://review.openstack.org/302992 | 17:13 |
| *** salv-orlando has quit IRC | 17:15 | |
| *** yamamoto has quit IRC | 17:16 | |
| *** david-lyle has joined #openstack-oslo | 17:17 | |
| *** cdent has quit IRC | 17:20 | |
| *** browne has joined #openstack-oslo | 17:21 | |
| *** david-lyle has quit IRC | 17:23 | |
| *** rcernin has joined #openstack-oslo | 17:33 | |
| *** rlrossit has quit IRC | 17:33 | |
| *** ihrachys has quit IRC | 17:41 | |
| *** rlrossit has joined #openstack-oslo | 17:48 | |
| *** e0ne has joined #openstack-oslo | 17:53 | |
| *** david-lyle has joined #openstack-oslo | 17:56 | |
| *** david-lyle has quit IRC | 17:56 | |
| *** david-lyle has joined #openstack-oslo | 17:58 | |
| *** e0ne has quit IRC | 18:03 | |
| *** shardy has quit IRC | 18:12 | |
| *** vilobhmm11 has joined #openstack-oslo | 18:13 | |
| *** e0ne has joined #openstack-oslo | 18:13 | |
| *** vilobhmm111 has joined #openstack-oslo | 18:14 | |
| *** e0ne has quit IRC | 18:14 | |
| *** vilobhmm11 has quit IRC | 18:18 | |
| *** salv-orlando has joined #openstack-oslo | 18:32 | |
| *** salv-orlando has quit IRC | 18:38 | |
| *** nihilifer has quit IRC | 18:39 | |
| *** vilobhmm111 has quit IRC | 18:39 | |
| *** cdent has joined #openstack-oslo | 18:40 | |
| openstackgerrit | Merged openstack/oslotest: Updated from global requirements https://review.openstack.org/302991 | 18:47 |
| *** salv-orlando has joined #openstack-oslo | 18:52 | |
| *** e0ne has joined #openstack-oslo | 19:00 | |
| *** salv-orlando has quit IRC | 19:01 | |
| *** nikhil has quit IRC | 19:07 | |
| *** rlrossit has quit IRC | 19:10 | |
| *** nikhil has joined #openstack-oslo | 19:11 | |
| *** david-lyle_ has joined #openstack-oslo | 19:13 | |
| *** salv-orlando has joined #openstack-oslo | 19:14 | |
| *** david-lyle has quit IRC | 19:15 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 19:17 | |
| *** david-lyle_ has quit IRC | 19:19 | |
| *** ihrachys has joined #openstack-oslo | 19:24 | |
| openstackgerrit | Merged openstack/oslo.config: Updated from global requirements https://review.openstack.org/302874 | 19:26 |
| *** david-lyle has joined #openstack-oslo | 19:29 | |
| *** vilobhmm11 has joined #openstack-oslo | 19:30 | |
| *** david-lyle has quit IRC | 19:31 | |
| rbradfor | sdague, was waiting for jenkins to submit a followup on https://review.openstack.org/#/c/302744/ . looking at more info on the 110 failed tempest tests, http://logs.openstack.org/44/302744/3/check/gate-tempest-dsvm-neutron-src-oslo.context/b8aeab6/console.html#_2016-04-07_18_08_14_944 | 19:31 |
| patchbot | rbradfor: patch 302744 - oslo.context - WIP: alternate approach to context building | 19:31 |
| *** david-lyle has joined #openstack-oslo | 19:31 | |
| *** dukhlov has joined #openstack-oslo | 19:32 | |
| *** rlrossit has joined #openstack-oslo | 19:35 | |
| sdague | rbradfor: looks like roles didn't get set correctly - | 19:36 |
| sdague | <rbradfor> sdague, was waiting for jenkins to submit a followup on https://review.openstack.org/#/c/302744/ . looking at more info on the 110 failed tempest tests, http://logs.openstack.org/44/302744/3/check/gate-tempest-dsvm-neutron-src-oslo.context/b8aeab6/console.html#_2016-04-07_18_08_14_944 | 19:36 |
| patchbot | sdague: patch 302744 - oslo.context - WIP: alternate approach to context building | 19:36 |
| sdague | http://logs.openstack.org/44/302744/3/check/gate-tempest-dsvm-neutron-src-oslo.context/b8aeab6/logs/screen-n-cpu.txt.gz#_2016-04-07_17_44_46_017 | 19:37 |
| rbradfor | nova fails, http://logs.openstack.org/44/302744/3/check/gate-tempest-dsvm-neutron-src-oslo.context/b8aeab6/logs/screen-n-cpu.txt.gz#_2016-04-07_17_44_46_017 | 19:37 |
| sdague | so nova compute died | 19:37 |
| rbradfor | sdague, ok, same one | 19:37 |
| sdague | right, roles isn't an array | 19:37 |
| *** david-lyle has quit IRC | 19:37 | |
| rbradfor | well, NoneType would indicate it was not set? | 19:38 |
| sdague | so... what must be happening here is nova is explicitly sending None down | 19:39 |
| sdague | which used to convert to an array | 19:39 |
| sdague | yeh... | 19:40 |
| sdague | this is going to need a bit of legacy compat for that | 19:40 |
| sdague | https://review.openstack.org/#/c/302744/3 | 19:42 |
| patchbot | sdague: patch 302744 - oslo.context - WIP: alternate approach to context building | 19:42 |
| sdague | updated the review comment there, I think that's the fix | 19:42 |
| rbradfor | well, I was testing in this defensive condition for other errors, I thought roles was an array | 19:43 |
| rbradfor | if not set, just checking | 19:43 |
| rbradfor | perhaps not | 19:43 |
| sdague | the from env is going to set it to [] | 19:43 |
| sdague | however, we process kwargs after that | 19:43 |
| rbradfor | agreed | 19:44 |
| sdague | so if you sent roles=None it will happy set self.roles = None | 19:44 |
| kevinbenton | dims: yo, oslo config question for you | 19:44 |
| rbradfor | sdague, ok, I'll add it to my next patchset | 19:44 |
| dims | yes kevinbenton | 19:44 |
| sdague | we could also try to go through kwargs and only set the attr if it's not None | 19:44 |
| sdague | under the assumption that no one really wants to zero those out for real | 19:45 |
| sdague | which might be a fine assumption | 19:45 |
| sdague | I don't know | 19:45 |
| rbradfor | sdague, so we need to have some attributes defined, i.e. set to at least None | 19:45 |
| kevinbenton | dims: would it be possible to change the deprecation warning logic to only print if a value is not specified to a particular option? | 19:45 |
| sdague | rbradfor: the attrs are exist | 19:45 |
| sdague | self.roles is there | 19:45 |
| kevinbenton | dims: right now, it only prints if they specify non-default, right? | 19:46 |
| sdague | the from_environ did that | 19:46 |
| sdague | but, it's None, so the iteration fails on type failure | 19:46 |
| rbradfor | yeah, the array is a special case we need as per your review comment. | 19:46 |
| sdague | yeh | 19:46 |
| dims | kevinbenton : like deprecated values? | 19:47 |
| kevinbenton | dims: yeah | 19:47 |
| kevinbenton | dims: want to deprecate all but one value | 19:47 |
| kevinbenton | dims: and unfortunately that value is not the default | 19:47 |
| dims | interesting, guess it should be possible | 19:47 |
| kevinbenton | dims: we have a legacy crappy option that is the default in the neutron l3 agent | 19:47 |
| kevinbenton | dims: and we want to warn people that it sucks and it might be removed later | 19:48 |
| sdague | rbradfor: also, yay for pre testing libraries in a full stack :) | 19:48 |
| dims | kevinbenton : there's probably another way to do it. give me a sec | 19:48 |
| kevinbenton | dims: excellent, right now i have this. https://review.openstack.org/#/c/298443/ | 19:49 |
| patchbot | kevinbenton: patch 298443 - neutron - Fix deprecation warning for external_network_bridge | 19:49 |
| kevinbenton | dims: but i was hoping for something more contained in oslo cfg | 19:49 |
| rbradfor | sdague, np, I just have to rebase as I'd added to the patchset | 19:49 |
| openstackgerrit | Ronald Bradford proposed openstack/oslo.context: Alternate approach to context building https://review.openstack.org/302744 | 19:52 |
| openstackgerrit | Ronald Bradford proposed openstack/oslo.context: Support extra attributes for context https://review.openstack.org/303049 | 19:52 |
| *** rlrossit has quit IRC | 19:53 | |
| dims | kevinbenton : sounds like a good feature to add... rbradfor : what do you think? | 19:57 |
| dims | harlowja : ^^ | 19:58 |
| harlowja | seems fair to me | 19:58 |
| kevinbenton | basically a "warn_if_not_value" param | 19:58 |
| harlowja | right | 19:59 |
| dims | harlowja : i was looking at debtcollector to see if there was anything there.. | 19:59 |
| dims | :) | 19:59 |
| kevinbenton | so i'm looking at the _get_from_namespace function in olso cfg | 19:59 |
| kevinbenton | where the warning is emitted | 19:59 |
| harlowja | dims don't think so | 19:59 |
| rbradfor | so, this is warn if value? | 19:59 |
| harlowja | warn_if_value is a lambda, or just something else? | 20:00 |
| kevinbenton | probably a lambda | 20:00 |
| harlowja | k | 20:00 |
| kevinbenton | because in our case we need a warn if not value | 20:00 |
| kevinbenton | there is one value we want to push everyone towards | 20:00 |
| *** yamahata has joined #openstack-oslo | 20:00 | |
| harlowja | right | 20:00 |
| harlowja | the-one-value-to-rule-them-all | 20:00 |
| kevinbenton | we can call it the value_worthiness_evaluator | 20:01 |
| harlowja | :) | 20:01 |
| rbradfor | so, you have a default, and you say, must be set to '', how does oslo.config treat '' as a default? | 20:03 |
| kevinbenton | rbradfor: '' is not the default though | 20:03 |
| kevinbenton | rbradfor: and unfortunately we can't change that without breaking installations | 20:04 |
| rbradfor | kevinbenton, right, so it's a backward compat issue. | 20:04 |
| kevinbenton | rbradfor: yep | 20:04 |
| kevinbenton | so i had thought that it only warns right now if something non-default is specified, is that correct? | 20:05 |
| rbradfor | we talk about deprecated options, names,groups etc in https://review.openstack.org/#/c/288720/, but this seems a case of a deprecated default value. | 20:06 |
| patchbot | rbradfor: patch 288720 - oslo-specs - [WIP] Add policy for managing deprecation | 20:06 |
| *** jpena|off is now known as jpena | 20:07 | |
| *** jpena is now known as jpena|off | 20:08 | |
| *** jpena|off is now known as jpena | 20:09 | |
| rbradfor | kevinbenton, your review seems to address your needs, seems a discussion for us to determine usefulness of a general feature. | 20:11 |
| kevinbenton | rbradfor: ack | 20:12 |
| rbradfor | kevinbenton, but it's an interesting condition. | 20:12 |
| *** lpetrut has joined #openstack-oslo | 20:13 | |
| *** kgiusti has left #openstack-oslo | 20:20 | |
| *** dukhlov has quit IRC | 20:31 | |
| *** jpena is now known as jpena|off | 20:33 | |
| *** dukhlov has joined #openstack-oslo | 20:34 | |
| *** ericksonsantos has joined #openstack-oslo | 20:41 | |
| openstackgerrit | Merged openstack/oslo.concurrency: Updated from global requirements https://review.openstack.org/302981 | 20:41 |
| *** mriedem has quit IRC | 20:46 | |
| openstackgerrit | Merged openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/302983 | 20:52 |
| *** nihilifer has joined #openstack-oslo | 20:54 | |
| openstackgerrit | Merged openstack/oslo.db: Updated from global requirements https://review.openstack.org/302875 | 20:54 |
| *** david-lyle has joined #openstack-oslo | 20:56 | |
| openstackgerrit | Merged openstack/oslo.cache: Updated from global requirements https://review.openstack.org/302980 | 20:59 |
| openstackgerrit | Merged openstack/oslo.versionedobjects: Updated from global requirements https://review.openstack.org/302990 | 21:00 |
| *** jimbobhickville has quit IRC | 21:00 | |
| openstackgerrit | Merged openstack/oslo.i18n: Updated from global requirements https://review.openstack.org/302982 | 21:00 |
| openstackgerrit | Merged openstack/oslo.privsep: Updated from global requirements https://review.openstack.org/302986 | 21:01 |
| *** pcaruana has quit IRC | 21:01 | |
| *** lucasagomes has quit IRC | 21:03 | |
| *** e0ne has quit IRC | 21:04 | |
| *** ksnihyr has quit IRC | 21:09 | |
| *** ksnihyr has joined #openstack-oslo | 21:10 | |
| *** lucasagomes has joined #openstack-oslo | 21:11 | |
| *** e0ne has joined #openstack-oslo | 21:11 | |
| *** ndipanov has quit IRC | 21:13 | |
| *** ksnihyr has quit IRC | 21:14 | |
| *** shakamunyi has joined #openstack-oslo | 21:17 | |
| openstackgerrit | Merged openstack/oslo.middleware: Updated from global requirements https://review.openstack.org/302984 | 21:18 |
| *** salv-orl_ has joined #openstack-oslo | 21:18 | |
| *** e0ne has quit IRC | 21:18 | |
| *** dukhlov has quit IRC | 21:19 | |
| *** dukhlov has joined #openstack-oslo | 21:19 | |
| *** salv-orlando has quit IRC | 21:22 | |
| *** shakamunyi has quit IRC | 21:24 | |
| openstackgerrit | Dmitriy Ukhlov proposed openstack/oslo.messaging: test https://review.openstack.org/285239 | 21:26 |
| openstackgerrit | Merged openstack/oslo.reports: Updated from global requirements https://review.openstack.org/302987 | 21:29 |
| *** lucasagomes has quit IRC | 21:37 | |
| rbradfor | dims, re https://review.openstack.org/#/c/302876/ , not sure what to make of During handling of the above exception, another exception occurred http://logs.openstack.org/76/302876/2/gate/gate-oslo.log-python34/193802d/console.html#_2016-04-07_19_33_33_213 | 21:41 |
| patchbot | rbradfor: patch 302876 - oslo.log - Updated from global requirements | 21:41 |
| *** lucasagomes has joined #openstack-oslo | 21:45 | |
| openstackgerrit | Merged openstack/pycadf: Updated from global requirements https://review.openstack.org/302992 | 21:48 |
| *** lucasagomes has quit IRC | 21:50 | |
| *** lucasagomes has joined #openstack-oslo | 21:56 | |
| *** regXboi has quit IRC | 21:58 | |
| *** ihrachys has quit IRC | 22:05 | |
| *** ksnihyr has joined #openstack-oslo | 22:10 | |
| *** jeckersb is now known as jeckersb_gone | 22:11 | |
| *** ksnihyr has quit IRC | 22:15 | |
| *** shakamunyi has joined #openstack-oslo | 22:18 | |
| *** mikal has quit IRC | 22:18 | |
| *** mikal has joined #openstack-oslo | 22:18 | |
| *** barra204 has joined #openstack-oslo | 22:20 | |
| openstackgerrit | Dmitriy Ukhlov proposed openstack/oslo.messaging: test https://review.openstack.org/285239 | 22:22 |
| *** dukhlov has quit IRC | 22:22 | |
| *** shakamunyi has quit IRC | 22:24 | |
| *** barra204 has quit IRC | 22:25 | |
| *** dimtruck is now known as zz_dimtruck | 22:28 | |
| *** rcernin has quit IRC | 22:29 | |
| *** lpetrut has quit IRC | 22:32 | |
| *** yassine__ has quit IRC | 22:37 | |
| *** gordc has quit IRC | 22:46 | |
| openstackgerrit | Merged openstack/oslo.service: Updated from global requirements https://review.openstack.org/302988 | 22:56 |
| openstackgerrit | Merged openstack/oslo.utils: Updated from global requirements https://review.openstack.org/302989 | 22:56 |
| *** zz_dimtruck is now known as dimtruck | 22:56 | |
| *** sdague has quit IRC | 22:57 | |
| *** ksnihyr has joined #openstack-oslo | 23:11 | |
| *** mriedem has joined #openstack-oslo | 23:14 | |
| *** vilobhmm111 has joined #openstack-oslo | 23:15 | |
| *** ksnihyr has quit IRC | 23:17 | |
| *** vilobhmm11 has quit IRC | 23:17 | |
| openstackgerrit | Merged openstack/oslo.policy: Updated from global requirements https://review.openstack.org/302985 | 23:21 |
| *** salv-orl_ has quit IRC | 23:24 | |
| *** jamielennox|away is now known as jamielennox | 23:36 | |
| *** vilobhmm111 has quit IRC | 23:46 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!