Wednesday, 2016-03-09

zigodims: Am I right that the newer oslo.concurrency now sets lock_path to /tmp by default?00:04
zigodims: I very much would prefer if it continued to set None, and produce error if no good settings is forced.00:05
zigodims: This is otherwise a very dangerous default.00:05
zigoYour thoughts?00:05
*** edmondsw has quit IRC00:06
openstackgerritJoshua Harlow proposed openstack/tooz: Add basic mysql table support (if provided a database) [POC]  https://review.openstack.org/29017800:09
openstackgerritJoshua Harlow proposed openstack/tooz: Add basic mysql table support (if provided a database) [POC]  https://review.openstack.org/29017800:27
openstackgerritSachi King proposed openstack-dev/pbr: Do not silently drop markers that fail to evaluate  https://review.openstack.org/28962800:27
harlowjazigo https://github.com/openstack/oslo.concurrency/commit/499d5aa36d352cf3b seemed to revert that00:27
*** salv-orlando has joined #openstack-oslo00:30
*** suro-patz has quit IRC00:30
*** browne has quit IRC00:33
*** bapalm has quit IRC00:37
*** salv-orlando has quit IRC00:40
*** mriedem has joined #openstack-oslo00:44
*** bapalm has joined #openstack-oslo00:54
*** harlowja has quit IRC00:55
*** mtanino has quit IRC01:02
*** vilobhmm11 has quit IRC01:02
*** vilobhmm11 has joined #openstack-oslo01:03
*** vilobhmm11 has quit IRC01:04
*** vilobhmm11 has joined #openstack-oslo01:04
*** sdague has joined #openstack-oslo01:06
*** browne has joined #openstack-oslo01:08
*** gcb has joined #openstack-oslo01:10
*** zz_dimtruck is now known as dimtruck01:25
openstackgerritMerged openstack-dev/pbr: Use apt-cache generated packages to provide build deps  https://review.openstack.org/28968901:26
*** sdague has quit IRC01:38
*** sdague has joined #openstack-oslo01:46
*** mtanino has joined #openstack-oslo01:53
*** _amrith_ is now known as amrith01:55
*** salv-orlando has joined #openstack-oslo01:57
dimszigo : that change was never released.01:58
*** vilobhmm11 has quit IRC01:59
*** vilobhmm11 has joined #openstack-oslo02:03
*** vilobhmm11 has quit IRC02:03
*** vilobhmm11 has joined #openstack-oslo02:03
*** salv-orlando has quit IRC02:04
*** sdague has quit IRC02:05
*** yamamoto_ has joined #openstack-oslo02:06
*** vilobhmm11 has quit IRC02:22
*** john51 has quit IRC02:31
lifelessdims: around?02:32
lifelessdims: could you +2A https://review.openstack.org/#/c/289628/ ?02:32
patchbotlifeless: patch 289628 - openstack-dev/pbr - Do not silently drop markers that fail to evaluate02:32
*** john51 has joined #openstack-oslo02:33
dimslifeless : pong02:34
dimslifeless : will review now02:35
lifelessdims: thanks02:39
dimslifeless : in the error message, the bit about "see the following error" seemed redundant. but that's ok02:40
lifelessdims: its alittle awkward, but not really many better options given the structure we're dealing with02:42
dimsack lifeless02:43
openstackgerritMerged openstack-dev/pbr: Clarifications around tags and version numbers  https://review.openstack.org/28963002:52
*** gcb has quit IRC02:52
*** yamahata has quit IRC02:53
*** mriedem has quit IRC02:54
*** vilobhmm11 has joined #openstack-oslo02:55
*** yamamoto_ has quit IRC02:56
*** vilobhmm111 has joined #openstack-oslo02:57
*** itisha has quit IRC02:59
*** vilobhmm11 has quit IRC03:00
*** gcb has joined #openstack-oslo03:13
openstackgerritChangBo Guo(gcb) proposed openstack/oslo.config: doc:Log warning when can't get information from git  https://review.openstack.org/29025503:24
*** dims has quit IRC03:25
*** dimtruck is now known as zz_dimtruck03:29
*** zz_dimtruck is now known as dimtruck03:29
openstackgerritzwei proposed openstack/oslo.service: Exception: message need '_' function  https://review.openstack.org/29025603:32
*** salv-orlando has joined #openstack-oslo03:32
*** salv-orlando has quit IRC03:35
openstackgerritChangBo Guo(gcb) proposed openstack/oslo.config: doc:Log warning when can't get information from git  https://review.openstack.org/29025503:37
*** suro-patz has joined #openstack-oslo03:38
*** yamamoto_ has joined #openstack-oslo03:39
*** dimtruck is now known as zz_dimtruck03:39
openstackgerritMerged openstack-dev/pbr: Do not silently drop markers that fail to evaluate  https://review.openstack.org/28962803:41
*** yamahata has joined #openstack-oslo03:47
*** vilobhmm111 has quit IRC03:51
*** jamielennox is now known as jamielennox|away03:54
*** suro-patz has quit IRC03:58
*** sputnik13 has quit IRC03:59
*** links has joined #openstack-oslo04:03
*** amrith is now known as _amrith_04:10
*** vilobhmm11 has joined #openstack-oslo04:12
*** zz_dimtruck is now known as dimtruck04:33
*** yamahata has quit IRC04:37
*** yamahata has joined #openstack-oslo04:38
*** dimtruck is now known as zz_dimtruck04:54
*** EinstCrazy has joined #openstack-oslo04:57
*** eliqiao has quit IRC05:04
*** eliqiao has joined #openstack-oslo05:04
*** regXboi has joined #openstack-oslo05:05
*** regXboi has quit IRC05:06
openstackgerritzwei proposed openstack/oslo.service: Exception: message need '_' function  https://review.openstack.org/29025605:07
*** salv-orlando has joined #openstack-oslo05:07
openstackgerritMerged openstack-dev/pbr: fix some variable names  https://review.openstack.org/28524905:08
*** salv-orlando has quit IRC05:13
*** claudiub has quit IRC05:15
*** EinstCrazy has quit IRC05:28
*** harlowja_at_home has joined #openstack-oslo05:29
*** vilobhmm11 has quit IRC05:31
*** vilobhmm11 has joined #openstack-oslo05:33
*** gcb has quit IRC05:41
*** nkrinner has joined #openstack-oslo05:54
*** gcb has joined #openstack-oslo05:59
openstackgerritJoshua Harlow proposed openstack/oslo.serialization: Make msgpack registries copyable (and add __contains__)  https://review.openstack.org/28961106:08
*** rcernin has joined #openstack-oslo06:09
*** gcb has quit IRC06:10
*** bnemec has quit IRC06:11
*** amotoki has joined #openstack-oslo06:25
*** salv-orlando has joined #openstack-oslo06:31
openstackgerritDmitriy Ukhlov proposed openstack/oslo.messaging: test  https://review.openstack.org/28523906:32
*** salv-orlando has quit IRC06:36
*** fhermeni has joined #openstack-oslo06:44
*** harlowja_at_home has quit IRC07:03
*** suro-patz has joined #openstack-oslo07:07
*** claudiub has joined #openstack-oslo07:07
*** jeckersb is now known as jeckersb_gone07:20
*** sputnik13_ has joined #openstack-oslo07:23
*** suro-patz has quit IRC07:24
*** nkrinner has quit IRC07:27
*** nkrinner has joined #openstack-oslo07:31
*** sigmavirus24_awa has quit IRC07:36
*** odyssey4me has quit IRC07:36
*** cloudnull has quit IRC07:38
*** odyssey4me has joined #openstack-oslo07:41
*** sputnik13_ has quit IRC07:55
*** itisha has joined #openstack-oslo08:07
*** d0ugal has joined #openstack-oslo08:09
*** dguitarbite has joined #openstack-oslo08:10
*** e0ne has joined #openstack-oslo08:10
*** binarin has joined #openstack-oslo08:11
*** browne has quit IRC08:11
*** e0ne has quit IRC08:19
*** vilobhmm11 has quit IRC08:25
*** jschwarz has joined #openstack-oslo08:28
*** fhermeni has quit IRC08:35
*** ndipanov has quit IRC08:35
*** pblaho has quit IRC08:41
*** shardy has joined #openstack-oslo08:47
*** openstackgerrit has quit IRC08:47
*** openstackgerrit has joined #openstack-oslo08:47
*** ihrachys has joined #openstack-oslo08:48
jschwarzhello - I have a question on tooz :)08:48
jschwarzI'm looking at the documentations and it specifies one needs to send a heartbeat every once in a while08:48
jschwarzsay I have a server which is using multiple threads, each one is an oslo.messaging RPC server08:49
jschwarzIs there any easy way to tell oslo.messaging to also send heartbeats (or run some function of mine every once in a while)?08:49
*** ndipanov has joined #openstack-oslo08:55
*** links has quit IRC08:55
*** amotoki has quit IRC09:10
*** bapalm has quit IRC09:14
*** lucas-dinner is now known as lucasagomes09:16
*** salv-orlando has joined #openstack-oslo09:21
*** yamahata has quit IRC09:23
*** amotoki has joined #openstack-oslo09:25
*** cloudnull has joined #openstack-oslo09:27
*** yassine has joined #openstack-oslo09:27
*** mhickey_ has joined #openstack-oslo09:27
*** sigmavirus24_awa has joined #openstack-oslo09:27
*** bapalm has joined #openstack-oslo09:27
*** salv-orlando has quit IRC09:29
*** amotoki has quit IRC09:34
*** _amrith_ is now known as amrith09:41
*** vks has joined #openstack-oslo09:43
*** amotoki has joined #openstack-oslo09:43
*** amotoki has quit IRC09:51
*** e0ne has joined #openstack-oslo09:51
vks hi, i have written a sample neutron agent which subscribe ROUTER AFTER_CREATE event. But I am not getting the call in my callback method.09:52
vks2016-03-09 01:36:08.220 7075 DEBUG neutron.callbacks.manager [-] Subscribe: <function add_router at 0x7fdbbc482ed8> router after_create subscribe /opt/stack/neutron/neutron/callbacks/manager.py:4109:54
*** amotoki has joined #openstack-oslo09:55
*** amotoki has quit IRC09:56
*** e0ne has quit IRC10:01
*** claudiub|2 has joined #openstack-oslo10:03
*** e0ne has joined #openstack-oslo10:04
*** claudiub has quit IRC10:06
*** amotoki has joined #openstack-oslo10:06
*** claudiub|2 has quit IRC10:32
openstackgerritjaveme proposed openstack/oslo.messaging: Missing version parameter in can_send_version()  https://review.openstack.org/29038510:35
openstackgerritOleksii Zamiatin proposed openstack/oslo.messaging: [zmq] Reduce number of connections  https://review.openstack.org/28709410:39
*** yamamoto_ has quit IRC10:42
openstackgerritBernhard M. Wiedemann proposed openstack/stevedore: dont claim copyright for future years  https://review.openstack.org/29038810:44
*** salv-orlando has joined #openstack-oslo10:51
*** cdent has joined #openstack-oslo10:54
*** salv-orlando has quit IRC10:56
*** sdague has joined #openstack-oslo11:06
*** dims has joined #openstack-oslo11:07
*** takedakn has joined #openstack-oslo11:19
*** yamamoto_ has joined #openstack-oslo11:33
*** links has joined #openstack-oslo11:48
*** amrith is now known as _amrith_11:51
lxslidhellmann: fyi added a mutable config session idea to the newton pad11:51
*** takedakn has quit IRC11:53
*** takedakn has joined #openstack-oslo11:53
*** salv-orlando has joined #openstack-oslo12:06
openstackgerritOleksii Zamiatin proposed openstack/oslo.messaging: [zmq] Fix ceilometer  https://review.openstack.org/28929212:09
*** amotoki has quit IRC12:10
openstackgerritMerged openstack-dev/pbr: Correct typo - s/enabeld/enabled/  https://review.openstack.org/28962312:12
*** EinstCrazy has joined #openstack-oslo12:15
*** yamamoto_ has quit IRC12:16
*** sputnik13_ has joined #openstack-oslo12:16
*** vks has quit IRC12:18
*** lucasagomes is now known as lucas-hungry12:21
dimslxsli : nice thanks12:22
*** amotoki has joined #openstack-oslo12:24
*** dguitarbite has quit IRC12:27
*** nkrinner has quit IRC12:27
*** pkholkin_ has quit IRC12:27
*** pkholkin__ has joined #openstack-oslo12:27
*** bapalm has quit IRC12:27
*** takedakn has quit IRC12:27
*** bapalm has joined #openstack-oslo12:27
*** amotoki has quit IRC12:29
*** sputnik13_ has quit IRC12:30
*** nkrinner has joined #openstack-oslo12:40
*** dguitarbite has joined #openstack-oslo12:41
*** yamamoto has joined #openstack-oslo12:45
openstackgerritFeng Xi Yan proposed openstack/oslo.vmware: Decode special chars in vSphere objects' propset  https://review.openstack.org/18745712:46
*** yamamoto has quit IRC12:47
*** yamamoto has joined #openstack-oslo12:48
*** thumpba has joined #openstack-oslo12:50
*** yamamoto has quit IRC12:53
openstackgerritIlya Shakhat proposed openstack/oslo.messaging: [WIP] Simulator: calculate message latency statistics  https://review.openstack.org/28838313:02
*** dims has quit IRC13:05
*** dims_ has joined #openstack-oslo13:05
*** gchung has joined #openstack-oslo13:09
*** edmondsw has joined #openstack-oslo13:10
*** dims_ has quit IRC13:10
*** dims has joined #openstack-oslo13:14
*** pblaho has joined #openstack-oslo13:15
*** yamamoto has joined #openstack-oslo13:17
*** yamamoto has quit IRC13:17
*** yamamoto has joined #openstack-oslo13:19
*** _amrith_ is now known as amrith13:20
openstackgerritJulien Danjou proposed openstack/oslo.middleware: cors: prevent WebOb setting a default Content-Type  https://review.openstack.org/29048213:21
*** lucas-hungry is now known as lucasagomes13:28
*** jeckersb_gone is now known as jeckersb13:32
*** links has quit IRC13:35
*** vks has joined #openstack-oslo13:37
*** jpena is now known as jpena|lunch13:39
*** rakhmerov has quit IRC13:41
*** ativelkov has quit IRC13:41
*** kzaitsev_ws has quit IRC13:41
*** binarin has quit IRC13:41
*** rlrossit has joined #openstack-oslo13:48
*** amotoki has joined #openstack-oslo13:54
*** salv-orlando has quit IRC13:55
*** yamamoto has quit IRC13:56
*** yamamoto has joined #openstack-oslo13:57
*** dtardivel has joined #openstack-oslo14:03
*** kgiusti has joined #openstack-oslo14:05
*** salv-orlando has joined #openstack-oslo14:07
*** pradk has quit IRC14:08
*** rakhmerov has joined #openstack-oslo14:12
*** salv-orlando has quit IRC14:14
*** ativelkov has joined #openstack-oslo14:15
openstackgerritJulien Danjou proposed openstack/oslo.middleware: cors: prevent WebOb setting a default Content-Type  https://review.openstack.org/29048214:19
*** mriedem has joined #openstack-oslo14:19
*** mtanino has quit IRC14:19
*** nikhil_k has joined #openstack-oslo14:24
openstackgerritMerged openstack/devstack-plugin-amqp1: Enable qpid-dispatch-router as alternative amqp backend  https://review.openstack.org/28948114:28
krotscheckAnyone around to help me brainstorm a bug?14:33
krotscheckI _think_ the set_defaults which the whole cors config discussion ended up asking for is actually a red herring.14:33
krotscheckAssuming a paste deply environment....14:34
krotscheckThe middleware chain is initialized before the app.14:34
krotscheckSo, our ConfigurableMiddleware goes and grabs the config file, and whatever defaults have been set at that point.14:35
krotscheckIn the case of the CORS middleware, it reads the values and stores them independently of oslo_config's config instance.14:35
krotscheck(For easy access)14:35
krotscheckSo, the set_default values are simply not honored in a paste.ini environment.14:36
krotscheckDo I have that right?14:39
*** jpena|lunch is now known as jpena14:47
ryansbIs there a more ideal way to copy a config object than using copy.copy?14:49
ryansbI've seen some crashes caused by the copy module getting in a loop of calling _get and __getattr__ on a ConfigOpts object14:50
*** mriedem is now known as mriedem_meeting14:52
*** bnemec has joined #openstack-oslo14:53
*** zz_dimtruck is now known as dimtruck15:03
*** xek_ is now known as xek15:05
*** mtanino has joined #openstack-oslo15:06
dimsrbradfor : dhellmann : fyi, here's a single log with deprecation messages from a dvsm/tempest - http://logs.openstack.org/01/289901/3/check/gate-tempest-dsvm-full/71b213c/logs/deprecations.txt.gz15:07
*** pblaho has quit IRC15:08
*** sigmavirus24_awa is now known as sigmavirus2415:09
*** pradk has joined #openstack-oslo15:09
rbradfordims, is that frequency you added to prefix the line?15:26
openstackgerritMichael Krotscheck proposed openstack/oslo.middleware: CORS Middleware now honors upstream Vary header  https://review.openstack.org/29058315:28
*** suro-patz has joined #openstack-oslo15:28
*** suro-patz has quit IRC15:32
dimsrbradfor : yes15:36
krotscheckdims, rbradfor, gordc: I'm throwing up some bug fixes to oslo_middleware.cors while I wait for the other patches to land. I'm not certain they're mitaka-required, but I want to get them out of my brain. Feel free to WF-2 them.15:36
dimskrotscheck : that's ok, dhellmann and i will get stable branches built from last set of releases so even if your changes land we are good15:37
krotscheckdims: coolio15:38
rbradfordims, so how do you test devstack-gate script changes manually?15:38
dimsrbradfor : i just test snippets by hand15:39
rbradfordims, I was trying to work out how to actually run devstack-vm-gate-wrap.sh locally.15:39
*** mriedem_meeting is now known as mriedem15:40
*** gchung is now known as gordc15:42
*** browne has joined #openstack-oslo15:45
dimsrbradfor : seen this? https://github.com/openstack-infra/devstack-gate#simulating-devstack-gate-tests15:46
*** nkrinner has quit IRC15:46
rbradfordims, thanks15:46
*** EinstCrazy has quit IRC15:56
*** regXboi has joined #openstack-oslo15:59
*** suro-patz has joined #openstack-oslo16:00
openstackgerritDmitriy Ukhlov proposed openstack/oslo.messaging: test  https://review.openstack.org/28523916:00
*** zzzeek has quit IRC16:03
*** zzzeek has joined #openstack-oslo16:04
*** gcb has joined #openstack-oslo16:05
*** yamahata has joined #openstack-oslo16:10
*** gcb has quit IRC16:17
openstackgerritChangBo Guo(gcb) proposed openstack/oslo.config: Disallow config option name as same as attribute of ConfigOpts  https://review.openstack.org/28975216:18
*** itisha has quit IRC16:19
openstackgerritKen Giusti proposed openstack/oslo.messaging: Fix the driver shutdown/failover logic  https://review.openstack.org/29063116:20
*** suro-patz has quit IRC16:27
*** suro-patz has joined #openstack-oslo16:28
*** gcb_ has joined #openstack-oslo16:30
*** dims has quit IRC16:33
*** harlowja_at_home has joined #openstack-oslo16:34
vkskrotscheck, hi i need some info on oslo_messaging16:39
openstackgerritChangBo Guo(gcb) proposed openstack/oslo.config: doc:Log warning when can't get information from git  https://review.openstack.org/29025516:40
*** gcb_ has quit IRC16:41
*** suro-patz has quit IRC16:41
*** gcb_ has joined #openstack-oslo16:43
*** dims has joined #openstack-oslo16:44
krotscheckvks: Oslo messaging isn't my specialty. rbradfor?16:49
*** e0ne has quit IRC16:50
vkskrotscheck, thnx16:50
vksrbradfor, hi16:50
rbradforvks, krotscheck sorry, I do nothing in oslo.messaging either.16:50
*** yamahata has quit IRC16:50
krotscheckvks: You can check the project's core list in gerrit for names to ping.16:50
vksrbradfor, :)16:50
rbradforI suggest you propose your question, people will read it, but not everybody is looking at IRC right now.16:50
rbradforbetween different timezones, meetings and other work, it may take a bit for the right person to respond.16:51
*** browne has quit IRC16:53
openstackgerritDoug Hellmann proposed openstack/oslo.config: Update reno for stable/mitaka  https://review.openstack.org/29065816:53
openstackgerritDoug Hellmann proposed openstack/oslo.db: Update reno for stable/mitaka  https://review.openstack.org/29066216:54
openstackgerritDoug Hellmann proposed openstack/oslo.log: Update reno for stable/mitaka  https://review.openstack.org/29066516:54
*** EinstCrazy has joined #openstack-oslo16:56
*** gcb_ has quit IRC16:59
*** EinstCrazy has quit IRC17:03
krotscheckAnyone know if there's a way for me to ask a ConfigOpts instance whether it has a value, or whether the returned value is the default?17:03
* krotscheck is digging through configOpts right now, but wouldn't mind pointers.17:04
bknudsonI hope dhellmann has a script for updating .gitreviews17:06
toabctlwhy are there 2 different versions mentioned for pbr in i.e. oslo.db (setup.py has >=1.8, but requirements.txt has >= 1.6)17:06
toabctl?17:06
*** kzaitsev_ws has joined #openstack-oslo17:07
*** rcernin has quit IRC17:09
vkshi i need some info on oslo_messaging. I am writing a neutron agent, which should act on router create/delete/update event. It look like oslo_messaging can be used to subscribe for the rpc event17:10
vkscan it be used ?17:10
*** yamahata has joined #openstack-oslo17:10
*** browne has joined #openstack-oslo17:18
*** jschwarz has quit IRC17:25
*** dimtruck is now known as zz_dimtruck17:30
*** zz_dimtruck is now known as dimtruck17:30
krotscheckWhat is oslo's versiond eprecation policy? i.e. how long do I have to support things?17:35
*** mhickey_ has quit IRC17:46
*** vilobhmm11 has joined #openstack-oslo17:47
*** vilobhmm111 has joined #openstack-oslo17:48
*** thumpba has quit IRC17:50
*** thumpba has joined #openstack-oslo17:51
*** vilobhmm11 has quit IRC17:51
openstackgerritDmitriy Ukhlov proposed openstack/oslo.messaging: test  https://review.openstack.org/28523917:52
*** amotoki has quit IRC17:57
*** vks has quit IRC17:59
*** shardy has quit IRC18:03
*** sputnik13 has joined #openstack-oslo18:07
*** vilobhmm111 has quit IRC18:08
*** ihrachys has quit IRC18:10
*** vks has joined #openstack-oslo18:13
*** jpena is now known as jpena|zzz18:14
*** lucasagomes is now known as lucas-dinner18:18
openstackgerritMerged openstack/osprofiler: It's unnecessary set deprecate group for option 'enabled'  https://review.openstack.org/28589818:25
*** e0ne has joined #openstack-oslo18:29
*** takedakn has joined #openstack-oslo18:29
*** takedakn has quit IRC18:30
*** mriedem has quit IRC18:36
*** mriedem has joined #openstack-oslo18:36
*** dims has quit IRC18:44
*** yamamoto has quit IRC18:45
*** dims has joined #openstack-oslo18:46
*** vks has quit IRC18:55
*** rlrossit has quit IRC18:58
*** rlrossit has joined #openstack-oslo19:00
*** cdent has quit IRC19:01
*** vilobhmm11 has joined #openstack-oslo19:06
*** boris-42 has quit IRC19:14
*** yamamoto has joined #openstack-oslo19:15
*** SergeyLukjanov has quit IRC19:19
*** SergeyLukjanov has joined #openstack-oslo19:21
*** yamamoto has quit IRC19:21
*** gordc has quit IRC19:22
openstackgerritMerged openstack/oslo.db: Update reno for stable/mitaka  https://review.openstack.org/29066219:25
*** yassine has quit IRC19:40
dhellmannbknudson : yes, I definitely do.19:40
dhellmannkrotscheck : why do you want to know if an option is set to something other than the default?19:41
openstackgerritMerged openstack/oslo.config: Update reno for stable/mitaka  https://review.openstack.org/29065819:41
bknudsondhellmann: dims: looks like we're ready to lift all the -2s?19:42
dhellmannbknudson : yeah, I think so, but I'd wait for dims just in case19:43
bknudsonI've got my own script to try out19:43
dimsbknudson : go for it!19:44
dhellmanndims : for the joint oslo presentation, do you want to prepare a single set of slides or treat it like lightning talks and change laptops for each speaker?19:44
*** yamahata has quit IRC19:44
*** sdague has quit IRC19:45
*** sigmavirus24 is now known as sigmavirus24_awa19:48
dimsdhellmann : lets do lightning talks format for now to have some freedom though the downside is that we may lose time (unless we load up all presos into the same laptop).19:48
dhellmanndims : ok, sounds good19:49
*** salv-orlando has joined #openstack-oslo19:51
*** salv-orl_ has joined #openstack-oslo19:53
*** sdague has joined #openstack-oslo19:54
*** salv-orlando has quit IRC19:56
krotscheckdhellmann: I'm trying to properly implement set_defaults for the cors middleware, and it's turning out to be tricky; the middleware creates an internal copy of the existing configopts to use for subsequent configuration blocks, which are deep-copied so that the defaults can be overridden.19:58
*** rlrossit has quit IRC19:58
krotscheckdhellmann: The second issue there is that middleware is occasionally initialized before application code, meaning that set_defaults won't actually do anything.19:59
dhellmannkrotscheck : set_defaults() always only changes the default value, and allows a user-specified value to override that regardless of the order of calls19:59
krotscheckdhellmann: I'm talking about this line: http://git.openstack.org/cgit/openstack/oslo.middleware/tree/oslo_middleware/cors.py#n14319:59
dhellmannyou want to set the defaults of a subgroup option to be the default of the master option?20:00
krotscheckdhellmann: Hence my question about deprecating as well. The whole prefix config option feature may be something we just deprecate, now that allowed_origins is a list_opt20:00
krotscheckdhellmann: I want to set the value of the subgroup to what the master is, IFF the subgroup does not have a value set.20:01
krotscheckThat way I can use one single GroupAttr instance instead of two.20:01
*** rlrossi__ has joined #openstack-oslo20:02
krotscheckOr, well, n20:02
dhellmannkrotscheck : right, so just use set_default(). It changes the default, but not the actual value of the option. If the user sets the option value in their config file, it overrides the default.20:02
krotscheckdhellmann: Maybe I'm not quite clear.20:02
ryansbHey, can someone help me out with copying a config object? I'm having trouble in python 3.4 using copy.copy20:02
*** gordc has joined #openstack-oslo20:02
krotscheckdhellmann: Right now, the value chain in a subgroup option is subgroup_value -> master_value, not subgroup_value -> master_default.20:03
krotscheckSo I can change it to just use one configopt, but that'd be a breaking change.20:03
krotscheckSorry20:03
krotscheckBasically skip the clone altogether.20:03
* krotscheck is trying to brainstorm a path forward.20:04
dhellmanndo you want subgroup_default to be master_default?20:04
dhellmannkrotscheck : I'm afraid I'm still not clear on exactly what you're trying to do, and I would like to because I think I can help you avoid writing something complicated20:06
dhellmannthere's already support for various levels of default and override setting20:06
bknudsondims: dhellmann: ok, all the -2s are lifted.20:07
dhellmannbknudson : thanks!20:07
krotscheckdhellmann: I want to rip a bunch of things out of cors middleware that, quite frankly, aren't necessary.20:07
dhellmannok20:07
dhellmannthat seems a worthy goal20:07
krotscheckdhellmann: But most of those are breaking changes, so I have to figure out a way to fix bugs in the meantime.20:07
dhellmannmakes sense20:07
krotscheckThe current order of execution bug I'm trying to figure out is this:20:08
krotscheckPaste deploy initializes cors Middleware. Middleware parses config file for [cors] and [cors.*] (this second one creates a deep clone of CORS_OPTS). Then the application is initialized, and set_defaults is called. CORS_OPTS defaults are updated, the subgroup opts are not.20:09
krotscheckSecond bug:20:09
openstackgerritJoshua Harlow proposed openstack/tooz: Add basic mysql table support (if provided a database) [POC]  https://review.openstack.org/29017820:09
dhellmanncan you change the middleware so that it registers the options before it needs to use them, instead of when it is loaded?20:10
krotscheckdhellmann: Yes, that's one approach I need to take anyway.20:10
krotscheck2nd bug:20:11
dhellmannif you register the options inside the set_defaults function exposed by the middleware *and* at runtime before they are checked, that should solve your ordering problem20:11
krotscheckThe current behavior is that if something is set in [cors], but not in [cors.*], then [cors.*] has its value set to the value that is set in [cors], via set_defaults.20:12
krotscheckBasically, there's config inheritance between [cors] and [cors.*]20:13
dhellmannok20:13
krotscheckRIght now that's done via set_defaults. I'd like to actually set the value itself.20:13
dhellmannwhy?20:13
dhellmannif the user has set a value, why do you want to override it?20:14
krotscheckdhellmann: Hrm. Similar order of operations case as above - I think there'll be aproblem that if I set the default to what is currently set in CORS_OPTS (via _get) and then the default on CORS_OPTS updates, then the defaults are now out of sync.20:16
dhellmannif the sub-options aren't registered until they are used, won't that be after the application has changed the main option defaults?20:18
dhellmanndo you want to sync the defaults, or do you want to make the value of the sub-option match the parent?20:18
dhellmannI'm confused about which sets of values you're trying to sync20:18
dhellmannmaybe if you used an actual example it would help make it clear20:18
krotscheckWell, the end goal is to remove subotps altogether, because allowed_origin is now a ListOpt.20:19
krotscheckAnd, well, I've yet to talk to someone who cares about having such fine-tune control over CORS>20:20
krotscheckMostly because, as an attack vector, just using an API directly is a better idea.20:20
dhellmannI guess you could do a few things20:21
dhellmannyou could check if the value of the subopt is different from the parent and emit a warning, then either use set_override to change the subopt or just go with what it's set to20:22
dhellmannstarting with a warning puts you on the path to deprecation20:22
dhellmannif you want the subopt to default to the value of the parent opt, unless overridden by the user, you can use set_default() instead of set_override()20:22
bknudsonbtw - is there a good python library for gerrit?20:23
bknudsongerrit rest api20:23
dhellmannbknudson : the infra team might know20:23
bknudsonnot that it was hard to write one20:23
dhellmannryansb : what kind of object are you trying to copy?20:24
*** ihrachys has joined #openstack-oslo20:25
ryansbdhellmann: cfg.ConfigOpts20:25
dhellmannryansb : why are you cloning that? what's the use case?20:26
dhellmannI don't think we expect anyone to do that20:26
ryansbWe're using it to make dynamic configs to support multiple zaqar storage backends20:26
ryansbspecifically https://github.com/openstack/zaqar/blob/stable/liberty/zaqar/storage/utils.py#L5320:26
dhellmannwhy not just make a new instance? what's the benefit of cloning the existing thing?20:27
ryansbWe do if there isn't an existing one20:28
dhellmannso if you have an instance you clone it and then change the clone? why not just make a new instance and initialize it?20:29
dhellmannor, better, register the backend options in a custom group where they can all live together in the same instance20:30
dhellmannIIUC, that's how cinder does it20:30
ryansbThe issue I'm seeing is a stackoverflow exception between the _get and the __getattr__ methods on ConfigOpts20:31
dhellmannduring the copy?20:31
ryansbyes, during the copy20:32
dhellmannwhat attribute is it looking up? we probably don't have the copy hooks in place for that class because we didn't expect anyone to do this20:32
ryansbit looks like _get calls "self.__cache" which tries to resolve using getattr20:32
dhellmannyeah20:32
ryansbbut then the __getattr__ calls _get20:32
ryansband so on until explosion20:32
dhellmannmy recommendation is that you stop trying to make a copy of the object, and we figure out a better way for you to have what you're trying to do20:33
ryansboslo.config==3.9.0 for what it's worth20:33
dhellmannbut for that, I need more details about what exactly you *are* trying to accomplish by having a copy20:33
ryansbYeah, sure, so as I understand it (I didn't write this bit, I happened across the exception on the .copy)20:34
*** fhermeni has joined #openstack-oslo20:36
ryansbwe use it in the part of zaqar that maps queues to the right storage pool20:37
bknudsonapparently gertty's got a batch review feature that I could have used20:37
fhermenihi there20:37
dhellmannbknudson : oh? I'm going to have to give that a look20:37
ryansbSo we share options across different pools20:37
dhellmannbknudson : is there a user guide or something?20:37
bknudsondhellmann: that's the thing, apparently it's poorly documented.20:38
dhellmannryansb : so there is a separate configopts instance for each pool?20:38
dhellmannhi, fhermeni20:38
ryansbdhellmann: yeah20:40
dhellmannbknudson : you don't have a script I could use to recheck a bunch of patches all at once, do you?20:40
bknudsondhellmann: I could modify this script pretty easily to post a recheck review.20:41
dhellmannryansb : ok. I still recommend instantiating independent ConfigOpts objects and populating them with the right options and config files.20:41
bknudsonlet me post the tool20:41
ryansband the copy takes the options from the pool and populates these options20:41
dhellmannryansb : *OR* not using separate objects and registering options in pool-specific groups, but that's probably a bigger change20:41
ryansbYeah, it likely would be20:41
ryansbIs there a way to, say, serialize the settings of a config option and use them to instantiate new ones20:42
openstackgerritMerged openstack/oslo.log: Update reno for stable/mitaka  https://review.openstack.org/29066520:43
ryansbor is the way just to instantiate the objects normally based on the __init__ params?20:43
*** salv-orl_ has quit IRC20:43
dhellmannwe have no facilities right now for assisting with cloning a ConfigOpts instance using any API because that is not a thing we have expected anyone to be doing20:43
dhellmannit seems that whoever wrote this didn't really understand how to use oslo.config, and didn't ask for advice, so they've designed you into a bit of a corner20:44
ryansbheh, that's possible20:44
ryansbanyways, thank you for the tips. Hopefully it's not too tight a corner20:44
dhellmannit appears that dynamic_conf() is trying to make a new ConfigOpt, ensure that some options are registered, and then ensure that some of those options have specific values?20:45
ryansbyes20:45
ryansbthat'd be correct20:45
dhellmannok, then I would just do that. call ConfigOpts(), call register_opts(), call __call__() to initialize it from the config files, and then call set_override()20:46
ryansbThat makes sense. So I'll just figure out what that base object has set, and then I can recreate it without the copying20:47
ryansbthanks again :)20:47
dhellmannthere are some public attributes of the object that you could use to pass to __call__() on the new one, but you should not reuse the same Opt instances between objects if you're calling set_override() and set_default()20:48
bknudsondhellmann: this is the tool -- https://github.com/brantlk/update_reviews/blob/master/update_reviews/__init__.py not much to it20:49
bknudsonif you think it'd be useful to have it in an openstack repo I can propose it there, too20:50
dhellmannI need something like that but I need it to let me specify the query and comment as args20:50
dhellmannbut having this as a basis would be a start, we could make it more flexible20:51
bknudsoneasy enhancements.20:51
dhellmannif you want to put it in release-tools maybe?20:51
bknudsonI'll take a stab at putting it in release-tools.20:51
dhellmannexcellent, thanks20:51
*** ihrachys has quit IRC20:51
*** e0ne has quit IRC20:53
*** sigmavirus24_awa is now known as sigmavirus2420:58
*** dims has quit IRC21:05
bknudsondhellmann: posted the code to release-tools : https://review.openstack.org/#/c/290853/21:08
patchbotbknudson: patch 290853 - openstack-infra/release-tools - Add update_reviews tool21:08
*** thumpba has quit IRC21:13
*** thumpba has joined #openstack-oslo21:14
*** thumpba has quit IRC21:18
*** sdague_ has joined #openstack-oslo21:23
dhellmannbknudson : ack, I'll take a look when I'm fresh tomorrow21:33
openstackgerritIlya Shakhat proposed openstack/oslo.messaging: [WIP] Simulator: calculate message latency statistics  https://review.openstack.org/28838321:33
*** dims has joined #openstack-oslo21:37
*** yamahata has joined #openstack-oslo21:47
*** dtardivel has quit IRC21:48
*** dims has quit IRC21:56
*** ndipanov has quit IRC21:57
*** kgiusti has left #openstack-oslo21:57
*** dims has joined #openstack-oslo21:58
*** dimtruck is now known as zz_dimtruck22:07
openstackgerritJason Dunsmore proposed openstack/oslo.service: Add ability to cancel Threads and ThreadGroups  https://review.openstack.org/29088022:14
*** gordc has quit IRC22:16
*** sdague_ has quit IRC22:17
*** sdague has quit IRC22:17
*** david-lyle has quit IRC22:19
*** david-lyle has joined #openstack-oslo22:20
*** amrith is now known as _amrith_22:24
openstackgerritMiguel Angel Ajo proposed openstack/oslo.versionedobjects: Add BaseEnumField valid_values introspection  https://review.openstack.org/28710622:27
openstackgerritEric Brown proposed openstack/oslo.context: Use project instead of tenant  https://review.openstack.org/28958822:28
*** dims has quit IRC22:29
openstackgerritMiguel Angel Ajo proposed openstack/oslo.versionedobjects: Add BaseEnumField valid_values introspection  https://review.openstack.org/28710622:30
*** mriedem has quit IRC22:31
*** fhermeni has quit IRC22:32
*** yamahata has quit IRC22:35
*** zz_dimtruck is now known as dimtruck22:38
*** regXboi has quit IRC22:43
*** dims has joined #openstack-oslo22:44
*** rlrossi__ has quit IRC22:46
*** browne has quit IRC22:55

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!