Tuesday, 2015-12-22

*** salv-orlando has joined #openstack-oslo00:00
*** salv-orl_ has quit IRC00:03
*** sdake has quit IRC00:07
*** sdake has joined #openstack-oslo00:13
harlowjai'm around00:13
*** zz_dimtruck is now known as dimtruck00:19
*** mixos has quit IRC00:19
dimsharlowja : let's do all the deprecations removals etc and cut a 2.x00:20
*** EinstCrazy has quit IRC00:25
*** dims has quit IRC00:42
*** salv-orlando has quit IRC00:51
*** EinstCrazy has joined #openstack-oslo01:01
*** sdake has quit IRC01:10
*** dims has joined #openstack-oslo01:16
openstackgerritMerged openstack/taskflow: Revert "Remove failure version number"  https://review.openstack.org/26016401:19
*** sputnik1_ has quit IRC01:30
*** sputnik13 has joined #openstack-oslo01:35
*** dims has quit IRC01:40
*** dimtruck is now known as zz_dimtruck01:43
*** mixos has joined #openstack-oslo01:48
*** zz_dimtruck is now known as dimtruck01:50
*** dims has joined #openstack-oslo01:50
*** mriedem_away has quit IRC01:53
*** mriedem has joined #openstack-oslo01:58
mriedemthis is an annoying new bug in oslo.messaging 4.0.0 https://bugs.launchpad.net/oslo.messaging/+bug/152841501:59
openstackLaunchpad bug 1528415 in oslo.messaging ""ERROR [oslo_messaging._drivers.zmq_driver.zmq_async] ZeroMQ not found!" shows up in other projects and isn't necessary" [Medium,Confirmed]01:59
harlowjabogdando ^02:05
harlowjaisn't that basically the API that mistral and others care about ...02:06
harlowjapost things to work on, let something work on them, or die trying to do that02:06
*** dims has quit IRC02:06
*** Juexun has joined #openstack-oslo02:08
*** sdake has joined #openstack-oslo02:17
*** jeckersb is now known as jeckersb_gone02:28
*** dims has joined #openstack-oslo02:29
*** bardia has quit IRC02:32
harlowjasooooooo dims02:33
harlowjahow much u want to know ;)02:33
dimsharlowja : beat up right now. will you be around tomorrow?02:34
harlowjaclearance code please02:34
harlowjalol02:34
dimslol02:34
* harlowja is just saying that the job board api looks a lot like what is getting thought about for oslo.messaging 02:34
*** sdake_ has joined #openstack-oslo02:34
*** sdake has quit IRC02:34
harlowja260246 could be that addition to tooz02:34
harlowjapossibly02:34
harlowjaget people to think about it at least02:35
harlowjawhether it merges or not, meh, whatever :-P02:35
harlowjaits the season of giving, ha02:35
*** harlowja_at_home has joined #openstack-oslo02:39
dimsthanks harlowja : i'll take a look at that02:39
harlowja:-P02:39
harlowjasputnik1_ i think had some thoughts on it to02:39
harlowjaif he's around02:39
harlowjadims cools02:39
harlowjadims https://review.openstack.org/#/c/260164/02:40
harlowjaif u get bored, ha02:40
*** zzzeek has quit IRC02:44
*** gcb has joined #openstack-oslo02:44
*** dims has quit IRC02:45
*** zzzeek has joined #openstack-oslo02:45
*** dims has joined #openstack-oslo02:47
*** gcb has quit IRC02:52
*** salv-orlando has joined #openstack-oslo02:55
*** gcb has joined #openstack-oslo03:05
*** links has joined #openstack-oslo03:06
*** jecarey has joined #openstack-oslo03:08
*** dims has quit IRC03:08
*** harlowja_at_home has quit IRC03:09
*** harlowja_at_home has joined #openstack-oslo03:09
*** Juexun_ has joined #openstack-oslo03:12
*** Juexun has quit IRC03:12
*** yamahata has quit IRC03:14
*** harlowja_at_home has quit IRC03:14
*** mriedem has quit IRC03:19
*** Juexun_ has quit IRC03:19
*** vilobhmm111 has quit IRC03:21
harlowjadims soooooooo03:22
harlowjathats trickay03:22
harlowjalol03:22
harlowjahttps://etherpad.openstack.org/p/mitaka-taskflow-2.0 listed all the dates of deprecations.... blah blah03:23
harlowjaand i think only allowed to remove things older than 1.5 years (3 cycles?)03:23
harlowja'What got removed:' section in ^03:24
*** salv-orlando has quit IRC03:35
*** harlowja_at_home has joined #openstack-oslo03:39
*** deray has joined #openstack-oslo03:54
*** jeckersb_gone is now known as jeckersb03:56
openstackgerritJoshua Harlow proposed openstack/taskflow: Trap and expose exception any 'args'  https://review.openstack.org/23727903:58
*** jecarey has quit IRC03:59
*** jecarey has joined #openstack-oslo04:01
*** zqfan has joined #openstack-oslo04:05
openstackgerritJoshua Harlow proposed openstack/taskflow: Track dirtiness of models and use it during saving  https://review.openstack.org/24144104:19
*** nikhil has joined #openstack-oslo04:33
*** vilobhmm11 has joined #openstack-oslo04:36
*** nikhil_k has quit IRC04:36
*** deray has quit IRC04:41
*** deray has joined #openstack-oslo04:46
openstackgerritMerged openstack/oslo.utils: assertIsNone(val) instead of assertEqual(None,val)  https://review.openstack.org/25995004:56
*** jamespage has quit IRC05:00
openstackgerritChangBo Guo(gcb) proposed openstack/oslo.messaging: zmq: Don't log error when can't import zmq module  https://review.openstack.org/26032205:22
*** sdake_ has quit IRC05:23
*** salv-orlando has joined #openstack-oslo05:41
*** harlowja_at_home has quit IRC05:42
*** mixos has quit IRC05:45
*** yamahata has joined #openstack-oslo05:59
*** sputnik13 has quit IRC06:12
*** sputnik13 has joined #openstack-oslo06:14
*** salv-orlando has quit IRC06:16
*** sputnik13 has quit IRC06:16
*** sputnik13 has joined #openstack-oslo06:18
*** sputnik13 has quit IRC06:20
*** sputnik13 has joined #openstack-oslo06:22
*** vilobhmm11 has quit IRC06:28
openstackgerritMerged openstack/oslo.messaging: assertIsNone(val) instead of assertEqual(None,val)  https://review.openstack.org/25994606:32
*** pasquier-s has quit IRC06:34
*** pasquier-s has joined #openstack-oslo06:34
*** dimtruck is now known as zz_dimtruck06:40
*** sdake has joined #openstack-oslo06:58
*** sdake has quit IRC07:15
*** shardy has joined #openstack-oslo07:25
*** vilobhmm11 has joined #openstack-oslo08:05
*** mkovacik_ has joined #openstack-oslo08:08
*** e0ne has joined #openstack-oslo08:11
*** binarin has quit IRC08:24
*** e0ne has quit IRC08:28
*** e0ne has joined #openstack-oslo08:33
*** yamamoto has joined #openstack-oslo08:33
*** yamamoto has quit IRC08:36
*** yamamoto has joined #openstack-oslo08:36
openstackgerritMarian Horban proposed openstack/oslo.service: Refactoring of tests/eventlet_service.py  https://review.openstack.org/26038408:38
*** salv-orlando has joined #openstack-oslo08:40
*** yamamoto has quit IRC08:41
openstackgerritMarian Horban proposed openstack/oslo.service: Refactoring of tests/eventlet_service.py  https://review.openstack.org/26038408:43
openstackgerritMarian Horban proposed openstack/oslo.service: Graceful shutdown added to ServiceLauncher  https://review.openstack.org/26038608:43
bogdandoharlowja, should we rework and move the spec for the tooz?08:44
bogdandoor fork it perhaps08:45
*** markus_z has joined #openstack-oslo08:47
*** andreaf has quit IRC08:48
*** andreaf has joined #openstack-oslo08:49
*** salv-orl_ has joined #openstack-oslo08:51
*** salv-orl_ has quit IRC08:51
*** salv-orlando has quit IRC08:51
*** salv-orlando has joined #openstack-oslo08:52
*** salv-orl_ has joined #openstack-oslo08:55
*** salv-orlando has quit IRC08:58
openstackgerritChaozhe Chen proposed openstack/oslo.versionedobjects: Remove meaningless default value in __get__()  https://review.openstack.org/26039408:58
openstackgerritMerged openstack/oslo.vmware: assertIsNone(val) instead of assertEqual(None,val)  https://review.openstack.org/25995209:02
*** jamespage has joined #openstack-oslo09:08
openstackgerritOleksii Zamiatin proposed openstack/oslo.messaging: zmq: Don't log error when can't import zmq module  https://review.openstack.org/26032209:09
*** yassine__ has joined #openstack-oslo09:11
*** e0ne has quit IRC09:16
openstackgerritOleksii Zamiatin proposed openstack/oslo.messaging: zmq: Don't log error when can't import zmq module  https://review.openstack.org/26032209:16
*** yottatsa has joined #openstack-oslo09:19
*** vilobhmm11 has quit IRC09:20
*** e0ne has joined #openstack-oslo09:20
openstackgerritjaveme proposed openstack/oslo.log: assertIsNone(val) instead of assertEqual(None,val)  https://review.openstack.org/26040709:22
*** e0ne has quit IRC09:24
openstackgerritjaveme proposed openstack/oslo.policy: assertIsNone(val) instead of assertEqual(None,val)  https://review.openstack.org/26040909:26
*** deray has quit IRC09:36
openstackgerritjaveme proposed openstack/oslo.service: assertIsNone(val) instead of assertEqual(None,val)  https://review.openstack.org/26041209:37
*** yamamoto has joined #openstack-oslo09:42
*** EinstCrazy has quit IRC09:44
*** yottatsa has quit IRC09:44
*** yamamoto has quit IRC09:48
*** yottatsa has joined #openstack-oslo09:48
*** yamamoto has joined #openstack-oslo09:58
*** yottatsa has quit IRC10:02
*** cdent has joined #openstack-oslo10:07
*** yamamoto has quit IRC10:10
*** yamamoto has joined #openstack-oslo10:23
*** yamamoto has quit IRC10:24
*** yamahata has quit IRC10:25
*** e0ne has joined #openstack-oslo10:26
openstackgerritElena Ezhova proposed openstack/oslo.service: Run sslutils and wsgi tests for python3  https://review.openstack.org/26043210:27
*** mhickey has joined #openstack-oslo10:37
*** yottatsa has joined #openstack-oslo10:39
*** EinstCrazy has joined #openstack-oslo10:54
*** yottatsa has quit IRC11:02
*** yamamoto has joined #openstack-oslo11:02
*** yamamoto has quit IRC11:02
*** yottatsa has joined #openstack-oslo11:04
*** gcb has quit IRC11:08
*** gcb has joined #openstack-oslo11:12
*** shardy has quit IRC11:14
*** lucas-dinner is now known as lucasagomes11:15
*** deray has joined #openstack-oslo11:20
*** gcb has quit IRC11:23
*** yottatsa has quit IRC11:35
*** yottatsa has joined #openstack-oslo11:38
*** salv-orl_ has quit IRC11:44
*** lxsli_festive has quit IRC11:48
*** lxsli_festive has joined #openstack-oslo11:52
openstackgerritZhihai Song proposed openstack/oslo.config: Replace assertEqual with assertTrue and assertFalse  https://review.openstack.org/26046112:07
*** jaypipes has joined #openstack-oslo12:09
openstackgerritjaveme proposed openstack/oslo.service: fix a couple of assert issues  https://review.openstack.org/26041212:09
*** yottatsa has quit IRC12:17
*** yamamoto has joined #openstack-oslo12:19
openstackgerritMerged openstack/oslo.service: Updated from global requirements  https://review.openstack.org/25810612:19
*** gcb has joined #openstack-oslo12:22
*** yamamoto has quit IRC12:23
*** yamamoto has joined #openstack-oslo12:25
*** gordc has joined #openstack-oslo12:30
*** EinstCrazy has quit IRC12:35
*** ndipanov has joined #openstack-oslo12:36
*** EinstCrazy has joined #openstack-oslo12:37
openstackgerritjanonymous proposed openstack/automaton: Put py34 first in the env order of tox  https://review.openstack.org/26047512:40
*** yamamoto has quit IRC12:40
*** pblaho has joined #openstack-oslo12:43
*** salv-orlando has joined #openstack-oslo12:45
*** yamamoto has joined #openstack-oslo12:50
*** sdake has joined #openstack-oslo12:54
openstackgerritjanonymous proposed openstack/oslo.db: Put py34 first in the env order of tox  https://review.openstack.org/26048912:55
openstackgerritjanonymous proposed openstack/oslo.vmware: Put py34 first in the env order of tox  https://review.openstack.org/26049112:56
*** gcb has quit IRC12:57
*** yottatsa has joined #openstack-oslo13:01
*** dims has joined #openstack-oslo13:01
openstackgerritJulien Danjou proposed openstack/tooz: etcd: driver with lock support  https://review.openstack.org/24687913:01
openstackgerritjanonymous proposed openstack/pycadf: Put py34 first in the env order of tox  https://review.openstack.org/26051613:15
*** ihrachys has joined #openstack-oslo13:17
*** salv-orlando has quit IRC13:18
*** salv-orlando has joined #openstack-oslo13:18
*** sdake has quit IRC13:19
*** amrith is now known as _amrith_13:23
openstackgerritMarian Horban proposed openstack/oslo.service: Removed double stopping of service on SIGHUP  https://review.openstack.org/25849913:32
*** shardy has joined #openstack-oslo13:34
*** _amrith_ is now known as amrith13:41
*** yamamoto has quit IRC13:47
*** yamamoto has joined #openstack-oslo13:48
*** yottatsa has quit IRC13:57
*** links has quit IRC13:59
*** Qwazerty has joined #openstack-oslo14:01
*** Qwazerty has left #openstack-oslo14:02
*** amrith is now known as _amrith_14:04
mhickeydims: Hi. Do you have time for a question?14:09
*** sdake has joined #openstack-oslo14:09
*** yottatsa has joined #openstack-oslo14:10
*** jeckersb is now known as jeckersb_gone14:14
*** zakora has joined #openstack-oslo14:16
*** yamamoto has quit IRC14:22
*** jeckersb_gone is now known as jeckersb14:23
*** markus_z has quit IRC14:31
*** mriedem has joined #openstack-oslo14:35
*** ihrachys has quit IRC14:36
*** links has joined #openstack-oslo14:54
dimsozamiatin : let's get this in to make mriedem happy :) https://review.openstack.org/#/c/260322/14:54
dimsmhickey : hi, what's up?14:55
ozamiatindims: agree:)14:55
mriedemthanks14:55
mhickeydims: Hey. Do you have knowledge  on o.vo?14:55
mriedemmhickey: dansmith is the main guy and he's out for the year14:56
dimsmhickey : go ahead and ask :) i'll muddle through it14:56
mhickeydims: patch https://review.openstack.org/#/c/258026/14:56
dimsy14:57
mhickeydims: reying to figure out why class FakeResource needs to be regsitered as an object. Error if set as register_if(False): http://paste.openstack.org/show/482324/14:57
mhickeydims: seems that the rpc pull/push calls obj_class_from_name() which checks the registry14:59
*** lucasagomes is now known as lucas-hungry14:59
dimsmhickey : got a traceback that shows the error?15:00
dimsmhickey : worst case i can't spot anything quick, we'll have to wait for dansmith15:00
mhickeydims: can you see the paste url?15:00
*** deray has quit IRC15:01
dimsoops. looking now15:01
mhickeydims: thats ok. I can put dan on the patch. it is not a rush.15:01
mriedemmhickey: i had a similar series for cinder https://review.openstack.org/#/q/status:merged+project:openstack/cinder+branch:master+topic:bug/151492615:02
mriedemmight help explain/show how i did it there15:02
mriedemsince they were registering test objects that didn't need to be registered15:02
mhickeymriedem: thanks for this. i will give it a look.15:03
*** _amrith_ is now known as amrith15:04
mhickeymriedem: I am using the _if(False) but unfortunately the test is looking for the object to be registered when using it.15:06
*** takedakn has joined #openstack-oslo15:07
*** ndipanov has quit IRC15:08
mriedemthere is a way to register objects just for a test run i think15:09
mhickeymriedem: ok, sounds interesting15:10
*** sdake has quit IRC15:10
mriedemmhickey: are the neutron tests resetting the registery for each run? https://review.openstack.org/#/c/243826/4/cinder/test.py15:12
*** takedakn has quit IRC15:15
dimsmhickey : try with using "with mock.patch.object(FakeResource, 'obj_class_from_name'):" for your self.rpc.pull - i see that pattern in o.vo tests/test_objects.py (test_obj_primitive_field_namespace)15:18
*** zigo_ is now known as zigo15:19
*** yottatsa has quit IRC15:20
mhickeymriedem: no15:21
*** thumpba has joined #openstack-oslo15:21
*** yottatsa has joined #openstack-oslo15:22
mhickeydims: let me try ..15:24
mhickeydims: same error15:26
*** zz_dimtruck is now known as dimtruck15:26
*** jecarey has quit IRC15:27
mhickeymriedem, dims: thanks for the feedback. i think i will wait till dan returns. I am on holidays shortly myself! :)15:29
mhickeymriedem, dims: Happy holidays! :)15:32
mriedemgood idea, don't try tackling this before a vacation, you'll ruin your time off15:32
mhickeysure, :)15:32
dimsmhickey : mriedem : yep, happy holidays!15:32
*** yottatsa has quit IRC15:37
*** yottatsa has joined #openstack-oslo15:41
openstackgerritOleksii Zamiatin proposed openstack/oslo.messaging: (WIP) [zmq] Heartbeat implementation  https://review.openstack.org/25734615:44
*** kgiusti has joined #openstack-oslo15:44
*** jecarey has joined #openstack-oslo15:48
*** yamamoto has joined #openstack-oslo15:49
*** jecarey has quit IRC15:50
*** jecarey has joined #openstack-oslo15:51
*** yottatsa has quit IRC15:54
openstackgerritMerged openstack/oslo.middleware: assertIsNone(val) instead of assertEqual(None,val)  https://review.openstack.org/25994816:03
*** lucas-hungry is now known as lucasagomes16:04
*** mhickey has quit IRC16:06
mriedemdims: what is changbo's irc nick?16:06
mriedemgcb i guess16:07
dimsmriedem : yep16:08
*** yamamoto has quit IRC16:19
*** pblaho has quit IRC16:20
*** harlowja_at_home has joined #openstack-oslo16:23
openstackgerritjanonymous proposed openstack/automaton: Put py34 first in the env order of tox ,remove py33 from envlist and python2 from trove classifier  https://review.openstack.org/26047516:24
*** shardy has quit IRC16:24
openstackgerritRonald Bradford proposed openstack/oslo.config: Cleanly handle an undefined attribute reference  https://review.openstack.org/26022516:27
openstackgerritjanonymous proposed openstack/automaton: Put py34 first in the env order of tox ,remove py33 from envlist and python2 from trove classifier  https://review.openstack.org/26047516:27
*** zakora has quit IRC16:33
mhorbanHi guys, could you please look at https://review.openstack.org/#/c/260386/ . Many of services are started by ServiceLauncher or ProcessLauncher depends on configuration.... But ServiceLauncher doesn't support whole list of signals that ProcessLauncher supports. So handlers of signals will be different for nova depends on config option 'workers'. This patch fixes it.16:41
openstackgerritChaozhe Chen proposed openstack/oslo.versionedobjects: Remove meaningless default value in __get__()  https://review.openstack.org/26039416:41
*** dims has quit IRC16:42
openstackgerritayoung proposed openstack/oslo.policy: Convert Exceptions to failures.  https://review.openstack.org/16590816:43
*** yamamoto has joined #openstack-oslo16:44
*** thumpba_ has joined #openstack-oslo16:46
openstackgerritJoshua Harlow proposed openstack/debtcollector: Add 'removed_class' class decorator  https://review.openstack.org/26011716:46
*** thumpba has quit IRC16:49
rbradforlxsli_festive, I have a few questions on status of your mutable config work.16:49
*** yamamoto has quit IRC16:56
*** yamamoto has joined #openstack-oslo16:56
*** yamamoto has quit IRC16:58
gordcharlowja_at_home: quick q, when using debtcollector (specifically @removals.remove) do we need to have this line as well: warnings.simplefilter('always')17:07
harlowja_at_homegordc, not needed, if u can use https://docs.python.org/3.1/using/cmdline.html#cmdoption-trace-W thats prefered17:08
harlowja_at_home^ that -W option allows for altering what is showed via cmdline17:08
harlowja_at_homefor example -Wonce17:08
harlowja_at_homeall gordc that 'always' does is make it always show things (no matter how many times they are repeated)17:09
harlowja_at_homehttps://docs.python.org/3.1/library/warnings.html#the-warnings-filter17:09
harlowja_at_home'once' is probably better17:09
gordcharlowja_at_home: hmm. i guess main reason i ask is i can't figure out why it's throwing an error rather than a warning17:09
gordchttp://logs.openstack.org/39/256039/2/check/gate-keystonemiddleware-python27/754bb37/testr_results.html.gz17:09
harlowja_at_homegordc, ah, thats cause keystone turned those things into errors17:09
harlowja_at_homefrom what i remember they changed warnings to blowup instead of warn17:10
gordcoh. fun17:10
harlowja_at_homeya17:10
harlowja_at_homegordc, https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/tests/unit/utils.py#L2917:10
harlowja_at_homeright there i think ;)17:10
gordcah got it.17:11
harlowja_at_homethats one way to ensure u don't have deprecation warnings :-P17:11
gordci thought it was because i didn't add the warnings.simplefilter17:11
*** dims has joined #openstack-oslo17:12
*** yamahata has joined #openstack-oslo17:12
openstackgerritJoshua Harlow proposed openstack/tooz: Add programatic introspection of drivers characteristic(s)  https://review.openstack.org/24068117:12
harlowja_at_homegordc, nah, i'm pretty sure thats just cause they are doing that :)17:12
*** boris-42 has quit IRC17:13
gordcharlowja_at_home: cool cool. thanks for help17:14
harlowja_at_homenp17:14
*** harlowja_at_home has quit IRC17:18
*** yottatsa has joined #openstack-oslo17:19
*** jecarey has quit IRC17:21
*** bauzas has joined #openstack-oslo17:21
bauzasheya17:21
bauzasI have a change that is trampled in the nova gate because http://paste.openstack.org/show/482530/17:21
bauzascan someone tell me if fixing https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_fake.py#L176-L185 is a terrible idea for making sure that datetimes still work over the wire ?17:22
bauzastbc, everything works fine but the functional test because of that fake driver17:23
*** devananda has quit IRC17:30
bauzasdims: any idea who could help me for the above ?17:31
dimsozamiatin : any ideas? ^^17:32
dimsbauzas : am on a call, will pay attention in a little bit17:32
bauzasdims: np, cool17:37
*** devananda has joined #openstack-oslo17:40
*** e0ne has quit IRC17:47
openstackgerritMerged openstack/taskflow: Start rename of BLATHER -> TRACE  https://review.openstack.org/25875217:48
*** yottatsa has quit IRC17:49
*** cburgess has quit IRC17:50
*** cburgess has joined #openstack-oslo17:52
stevemargordc: thoughts on what to do about it? cap sounds like the easiest17:57
dimsstevemar : we broke something in yesterday's releases?18:00
*** openstackgerrit has quit IRC18:02
*** openstackgerrit has joined #openstack-oslo18:02
*** yottatsa has joined #openstack-oslo18:04
*** yottatsa has quit IRC18:06
dimsbauzas : we did not break it with yesterday's release did we?18:06
dimsbauzas : that thing has not changed for a while18:06
*** cdent has quit IRC18:08
*** yottatsa has joined #openstack-oslo18:14
*** links has quit IRC18:15
*** yottatsa has quit IRC18:16
stevemardims: yeah, it's been broken for a while18:16
stevemartalking about it in -meeting18:16
openstackgerritXia Linjuan proposed openstack/oslo.messaging: Clarify the notification_topics configuration  https://review.openstack.org/26065718:18
*** dimtruck is now known as zz_dimtruck18:31
gordcstevemar: cap pycadf in liberty i guess. i don't understand why your tests turn warnings into errors.lol18:32
*** harlowja has quit IRC18:36
dougwigdhellmann: hi oslo. as pointed out in a review adding locale stuff, we have a repo neutron-lib, with a module neutron_lib, but the local files go into neutron-lib/, and are the only files in that dir, while other modules have locale with their python code, courtesy of no hyphen. how did that come about?18:36
*** harlowja has joined #openstack-oslo18:36
*** e0ne has joined #openstack-oslo18:37
*** vilobhmm11 has joined #openstack-oslo18:37
*** jecarey has joined #openstack-oslo18:39
dhellmanndougwig : aejager may know this stuff better than I do, but the locale dir needs to be named for the dist name rather than the python package name, so that's probably why18:41
dhellmanndougwig : link to the review?18:41
*** jecarey has quit IRC18:41
*** jecarey has joined #openstack-oslo18:41
dougwigdhellmann: https://review.openstack.org/#/c/257775/18:42
*** jecarey has quit IRC18:46
dhellmanndougwig : looking18:48
*** salv-orlando has quit IRC18:48
dougwigdhellmann: ty18:48
dhellmanndougwig : using oslo.messaging as an example, the locale dir should be under a dir named for $(python setup.py --name) which is the dist name18:52
dhellmanndougwig : so I think garyk is right, but for the wrong reason18:52
dhellmanndougwig : I've asked AJaeger to join us, since he knows this stuff better than I do18:53
dhellmannthough it might be too late in the day for him18:53
*** AJaeger has joined #openstack-oslo18:54
AJaegerHi, dhellmann asked me to join for a translation question. Could somebody recap, please?18:54
dougwigdhellmann: he's reviewing in infra like a madman, as usual, so i think he's around.  :)18:54
dhellmannhi, AJaeger, thanks18:54
AJaegerdougwig: me?18:54
dhellmannyep18:54
dhellmann:-)18:54
dougwigAJaeger: 11:36 AM <dougwig> dhellmann: hi oslo. as pointed out in a review adding locale stuff, we have a repo neutron-lib, with a module neutron_lib, but the local files go into neutron-lib/, and are the only files in that dir, while other modules have locale with their python code, courtesy of no hyphen. how did that come about?18:54
dhellmannAJaeger: dougwig had a question about  https://review.openstack.org/#/c/257775/ ^^18:54
dougwigAJaeger: 11:42 AM <dougwig> dhellmann: https://review.openstack.org/#/c/257775/18:54
dhellmannI replied: dougwig : using oslo.messaging as an example, the locale dir should be under a dir named for $(python setup.py --name) which is the dist name18:54
AJaegerdougwig: our infra scripts are written in such a way that they expect the locale file be placed in18:55
AJaeger$repo/locale/$repo.pot18:55
dhellmannah, fun, so I'm wrong about the reason18:55
dougwigAJaeger: ok, so putting both of your answers together, we expect the dist name to always equal the *repo* name, not the module name?18:55
AJaegerdhellmann: you can check project-config, it's in jenkins/jobs/*translation*18:55
AJaegerdougwig: repo name it is indeed18:56
dhellmanndougwig : the dist and repo name do not need to match18:56
dougwiggotcha, ok.18:56
dhellmanndougwig : and I was completely wrong about the reasoning, it has nothing to do with dist name18:56
dougwigannoying for tab completion in my source dir, but i understand now. thank you. :)18:56
AJaegerdougwig: the scripts are complicated enough and stevenk and myself prefer to not make them more complicated with some way to change the repos18:56
dougwigdhellmann: ack, thanks.18:56
AJaegerbut if either of you finds an elegant way to change the infra scripts, I happily review18:57
dougwigAJaeger: i was looking to understand, not change.18:57
AJaegerand I had hoped somebody wanted to help ;)18:57
dhellmannyeah, I'm happy with how things are I just wanted to make sure dougwig had the right info18:57
dhellmannaw18:57
*** ihrachys has joined #openstack-oslo18:58
AJaegerdougwig: you should name the repos properly, so repo name = module name ;)18:59
dougwigAJaeger: isn't the norm in python for the repo to be a-b and the module to be a_b ?19:00
*** zz_dimtruck is now known as dimtruck19:00
AJaegerwhen translations where done, we only had repos without "-" and "_" ;)19:01
AJaegerAnd then olso changed it's module name from "." to "_"19:01
AJaegerand suddenly repos appeared using "-" and wanting translations...19:01
AJaegerif we know change "-" to "_" we first need to update all repos...19:02
AJaegers/know/now/19:02
*** ianw has quit IRC19:06
*** ianw has joined #openstack-oslo19:07
*** dimtruck is now known as zz_dimtruck19:07
*** vilobhmm11 has quit IRC19:09
*** vilobhmm11 has joined #openstack-oslo19:09
*** ihrachys has quit IRC19:18
*** ozamiatin_ has joined #openstack-oslo19:22
*** zqfan has quit IRC19:31
*** yassine__ has quit IRC19:36
openstackgerritMerged openstack/oslo.messaging: zmq: Don't log error when can't import zmq module  https://review.openstack.org/26032219:37
*** dims has quit IRC19:45
*** salv-orlando has joined #openstack-oslo19:47
*** lucasagomes is now known as lucas-pto19:55
vilobhmm11lifeless : ping19:56
vilobhmm11wanted to talk about the consul review if you have few minutes19:56
*** ihrachys has joined #openstack-oslo20:01
*** ihrachys has quit IRC20:02
*** ozamiatin_ has quit IRC20:03
*** jecarey has joined #openstack-oslo20:03
*** dims has joined #openstack-oslo20:04
*** AJaeger has left #openstack-oslo20:08
*** dims_ has joined #openstack-oslo20:11
*** dims has quit IRC20:14
*** boris-42 has joined #openstack-oslo20:21
openstackgerritJoshua Harlow proposed openstack/taskflow: Track dirtiness of models and use it during saving  https://review.openstack.org/24144120:24
*** e0ne has quit IRC20:28
openstackgerritMerged openstack/oslo.policy: assertIsNone(val) instead of assertEqual(None,val)  https://review.openstack.org/26040920:30
*** e0ne has joined #openstack-oslo20:32
openstackgerritMerged openstack/tooz: Remove tested under 2.6 from docs  https://review.openstack.org/25972420:32
openstackgerritJoshua Harlow proposed openstack/taskflow: Fix currently broken and inactive mysql tests  https://review.openstack.org/26070720:36
openstackgerritJoshua Harlow proposed openstack/taskflow: Fix currently broken and inactive mysql tests  https://review.openstack.org/26070720:39
lifelessvilobhmm11: hi20:41
openstackgerritVilobh Meshram proposed openstack/tooz: Add Consul Driver  https://review.openstack.org/24536220:43
openstackgerritMerged openstack/oslo.db: Updated from global requirements  https://review.openstack.org/26026020:44
vilobhmm11lifeless : I didn;t quite understand the last part of your comment here https://review.openstack.org/#/c/245362/18/tooz/drivers/consul.py line #8520:47
vilobhmm11so wanted to discuss just that I get what you are trying to point out here20:47
*** salv-orlando has quit IRC20:49
lifelessvilobhmm11: ok20:49
lifelessvilobhmm11: so, doing the owner = at the start of the while loop will be ok20:49
lifelessvilobhmm11: my other comment was observing that if the put is taking the lock, it shouldn't matter who the owner is20:50
lifelessvilobhmm11: the current code does these operations - read, lock, verify-or-loop20:51
lifelessvilobhmm11: but there is no need for the read20:51
lifelessvilobhmm11: *except* in the case where we already own the lock, right ?20:52
*** kgiusti has left #openstack-oslo20:52
vilobhmm11lifeless : if put is taking the lock and if the process/service crashes then won't it be good to know who the owner was before20:54
lifelessvilobhmm11: I don't understand20:54
vilobhmm11by read you mean read who's the owner right ?20:55
lifelessvilobhmm11: which process, which service? There must be three involved right - consul, and two processes using the thing, lets call them c (for client) c1 and c220:55
vilobhmm11yes20:55
lifelessvilobhmm11: we read the owner, but we only use that to re-acquire a lock if we already own it.20:55
lifelesswhat benefit is there reading the owner other than that?20:56
vilobhmm11lifeless : it can be used to block if the owener is != the session id of the one who owns the lock20:57
vilobhmm11lifeless : so you mean we need not keep track of the owner information ?20:57
lifelessin the case that we acquire it first try20:58
lifelessI'm saying ,what if we did this:20:58
lifelessput20:58
lifelessif acuired: save that and return20:58
lifelessread owner20:58
lifelessif self: save that and return20:58
lifelesswhile True:20:59
lifeless  put20:59
lifeless  if acquired: save and return20:59
vilobhmm11thinking...20:59
harlowjayup looks like vilobhmm11  is thinking21:00
lifelessor something like that - I'm sure it can be tweaked, but basically - less gets, since we only ever need it once: to re-acquire a lock we previously held21:00
vilobhmm11harlowja : :P21:00
lifelessand btw - I don't know if that re-acquire can ever work21:00
lifelesssince aren't session id's transient21:00
lifelessso if c1 crashes, when it starts again it has a new session id and cannot re-acquire the lock21:01
lifelessbut - I am new to consul, so may be totally wrong :)21:01
vilobhmm11session id's are transient but if they have already been stored in the kv store and then the process crashes then they can be the source of truth for who owned the lock21:03
lifelessI don't understand21:03
lifelessif I have a random session id21:03
lifelesshow do I map that back to a real world thing21:04
lifelessor put it another way21:04
lifelesshow can this code ever be True:21:04
lifelessif owner == self._session_id21:04
vilobhmm11I take that back…every time a process starts it will have to regenerate its session21:04
vilobhmm11and agree that its transient and will be alive till the lifetime the client is up and running21:05
*** edmondsw has joined #openstack-oslo21:06
*** edmondsw has quit IRC21:06
*** amrith is now known as _amrith_21:16
*** davidlenwell has quit IRC21:24
*** adam_g has quit IRC21:27
lifelessvilobhmm11: so it sounds like the owner recovery thing won't work and can be deleted ?21:27
vilobhmm11lifeless: makes sense..will edit that..please add coment on patch #19 if you feel anything else needs to be addressed21:28
lifelessvilobhmm11: I'll wait for the new code, since its simpler, I'll give it a full review then21:30
*** adam_g has joined #openstack-oslo21:33
*** adam_g has quit IRC21:34
*** adam_g has joined #openstack-oslo21:34
*** davidlenwell has joined #openstack-oslo21:36
*** e0ne has quit IRC21:40
*** davidlenwell has quit IRC21:43
*** e0ne has joined #openstack-oslo21:45
*** adam_g has quit IRC21:52
openstackgerritJulien Danjou proposed openstack/tooz: etcd: driver with lock support  https://review.openstack.org/24687921:54
*** davidlenwell has joined #openstack-oslo21:55
*** adam_g has joined #openstack-oslo21:56
*** adam_g has quit IRC21:56
*** adam_g has joined #openstack-oslo21:56
*** e0ne has quit IRC21:59
*** e0ne has joined #openstack-oslo21:59
*** davidlenwell has quit IRC22:02
*** adam_g has quit IRC22:06
*** adam_g has joined #openstack-oslo22:10
*** adam_g has quit IRC22:11
*** adam_g has joined #openstack-oslo22:11
*** davidlenwell has joined #openstack-oslo22:12
*** e0ne has quit IRC22:16
*** david-lyle has joined #openstack-oslo22:17
openstackgerritJoshua Harlow proposed openstack/taskflow: Track dirtiness of models and use it during saving  https://review.openstack.org/24144122:19
*** pratikmallya has joined #openstack-oslo22:22
openstackgerritJoshua Harlow proposed openstack/taskflow: Track dirtiness of models and use it during saving  https://review.openstack.org/24144122:22
*** ndipanov has joined #openstack-oslo22:24
*** yamamoto has joined #openstack-oslo22:24
*** yamamoto has quit IRC22:25
*** mriedem has quit IRC22:32
*** jecarey has quit IRC22:40
*** jecarey has joined #openstack-oslo22:42
openstackgerritMerged openstack/taskflow: Fix currently broken and inactive mysql tests  https://review.openstack.org/26070722:44
openstackgerritJoshua Harlow proposed openstack/taskflow: Use the retrying lib. to do basic sqlalchemy engine validation  https://review.openstack.org/26074323:15
*** dims has joined #openstack-oslo23:18
*** dims_ has quit IRC23:19
openstackgerritJoshua Harlow proposed openstack/taskflow: Use the retrying lib. to do basic sqlalchemy engine validation  https://review.openstack.org/26074323:21
*** harlowja has quit IRC23:25
*** harlowja has joined #openstack-oslo23:25
*** sputnik1_ has joined #openstack-oslo23:35
*** salv-orlando has joined #openstack-oslo23:47
*** ChuckC has joined #openstack-oslo23:49
openstackgerritJoshua Harlow proposed openstack/debtcollector: Add 'removed_class' class decorator  https://review.openstack.org/26011723:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!