Wednesday, 2015-10-14

Nakatolifeless: Thanks, that gets me around why to drop the -U  :)00:00
*** geoffarnold has quit IRC00:02
*** geoffarn_ has joined #openstack-oslo00:03
*** yamahata has quit IRC00:04
*** yamahata has joined #openstack-oslo00:06
*** vilobhmm11 has quit IRC00:12
*** gangil has joined #openstack-oslo00:17
*** gangil has joined #openstack-oslo00:17
*** vilobhmm11 has joined #openstack-oslo00:22
*** vilobhmm11 has quit IRC00:22
*** geoffarn_ has quit IRC00:23
*** geoffarnold has joined #openstack-oslo00:24
*** gangil has quit IRC00:27
*** vilobhmm11 has joined #openstack-oslo00:33
*** itisha has joined #openstack-oslo00:39
lifelessNakato: we've flipped and flopped on the use of -U in the baseline env too, but thats a different discussion :)00:41
*** browne has quit IRC00:41
*** sdake has joined #openstack-oslo00:43
*** geoffarnold has quit IRC00:44
*** geoffarnold has joined #openstack-oslo00:45
*** haigang has joined #openstack-oslo00:45
*** sputnik13 has quit IRC00:52
*** links has joined #openstack-oslo00:53
*** eliqiao has joined #openstack-oslo00:54
*** sdake has quit IRC00:58
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo.messaging: Use a condition (and/or a dummy one) instead of a lock  https://review.openstack.org/23437200:59
*** eliqiao has quit IRC01:00
*** sdake has joined #openstack-oslo01:03
*** geoffarnold has quit IRC01:06
*** geoffarnold has joined #openstack-oslo01:06
dimslifeless: can you please review https://review.openstack.org/#/c/234372/? it's a fix for ceilometer unit tests failures01:11
dimsharlowja: and sileht worked on it. i just added a closes-bug tag01:12
harlowjaall fixed :-P01:12
harlowjaha01:12
harlowja*for now*01:12
*** vilobhmm11 has quit IRC01:13
lifelesslooking01:15
dimsthanks lifeless01:16
*** eliqiao has joined #openstack-oslo01:18
lifelessdims: you reset the votes :)01:27
*** geoffarnold has quit IRC01:27
*** geoffarn_ has joined #openstack-oslo01:27
dimslifeless: on https://review.openstack.org/#/c/234372/ that's ok, want to wait till we get sileht's ok when he wakes up01:28
*** dims has quit IRC01:33
*** dims has joined #openstack-oslo01:34
*** gangil has joined #openstack-oslo01:37
*** gangil has joined #openstack-oslo01:37
*** gangil has quit IRC01:44
*** geoffarn_ has quit IRC01:48
*** geoffarnold has joined #openstack-oslo01:49
*** shardy has quit IRC02:01
*** sdake has quit IRC02:06
*** geoffarnold has quit IRC02:10
*** browne has joined #openstack-oslo02:19
*** mtanino has quit IRC02:20
*** boris-42 has quit IRC02:28
*** yamahata has quit IRC02:40
*** haigang has quit IRC02:45
*** jecarey has joined #openstack-oslo02:47
*** zz_dimtruck is now known as dimtruck02:47
*** jecarey has quit IRC02:51
*** achanda has joined #openstack-oslo02:57
*** amotoki has joined #openstack-oslo03:14
*** amotoki has quit IRC03:30
*** amotoki has joined #openstack-oslo03:41
*** dimtruck is now known as zz_dimtruck03:47
*** amotoki has quit IRC03:50
*** amotoki has joined #openstack-oslo03:55
*** david-lyle has quit IRC04:01
*** harlowja_at_home has joined #openstack-oslo04:16
*** amotoki has quit IRC04:18
openstackgerritJoshua Harlow proposed openstack/oslo.messaging: Use a condition (and/or a dummy one) instead of a lock  https://review.openstack.org/23437204:24
*** amotoki has joined #openstack-oslo04:26
*** Kennan2 has quit IRC04:40
*** Kennan has joined #openstack-oslo04:41
*** gangil has joined #openstack-oslo04:47
*** gangil has joined #openstack-oslo04:47
*** gangil has quit IRC04:49
*** harlowja_at_home has quit IRC05:04
*** ihrachys has joined #openstack-oslo05:10
*** boris-42 has joined #openstack-oslo05:22
*** tedross has joined #openstack-oslo05:34
*** vilobhmm11 has joined #openstack-oslo05:34
*** nikhil_k has joined #openstack-oslo05:42
*** nikhil has quit IRC05:42
*** nkrinner has joined #openstack-oslo06:05
*** tedross has quit IRC06:08
*** vilobhmm11 has quit IRC06:18
*** vilobhmm11 has joined #openstack-oslo06:20
*** vilobhmm11 has quit IRC06:45
*** stevemar_ has quit IRC06:53
*** stevemar_ has joined #openstack-oslo06:54
*** cdent has joined #openstack-oslo06:56
*** stevemar_ has quit IRC06:56
*** shardy has joined #openstack-oslo06:57
*** subscope has joined #openstack-oslo06:59
*** openstackgerrit has quit IRC07:01
*** openstackgerrit has joined #openstack-oslo07:01
*** jecarey has joined #openstack-oslo07:11
*** jecarey has quit IRC07:16
*** markus_z has joined #openstack-oslo07:23
*** browne has quit IRC07:24
*** subscope has quit IRC07:26
*** achanda has quit IRC07:26
*** achanda has joined #openstack-oslo07:27
*** achanda has quit IRC07:33
*** david-lyle has joined #openstack-oslo07:57
*** yassine has joined #openstack-oslo08:08
*** ociuhandu has quit IRC08:15
*** bapalm has quit IRC08:23
*** bapalm has joined #openstack-oslo08:26
*** ndipanov has joined #openstack-oslo08:27
*** jamielennox is now known as jamielennox|away08:40
*** stevemar_ has joined #openstack-oslo08:55
*** stevemar_ has quit IRC08:58
*** edmondsw has joined #openstack-oslo08:59
*** dims_ has joined #openstack-oslo09:17
*** dims has quit IRC09:20
*** links has quit IRC09:22
*** jecarey has joined #openstack-oslo09:23
*** jecarey has quit IRC09:27
mdboothdims_: You about?09:38
mdboothdims_: I was just about to -1 that patch you just +W'd09:38
mdboothdims_: In fact, I'm going to -1 it anyway :) I'll try to explain why and you can decide what to do about it subsequently.09:40
mdboothThis looks like a tricky bit of code, and you might be rushing to a fix.09:40
dims_mdbooth: we spent the whole day yesterday working on it on several boxes on multiple set of tests.09:42
mdboothdims_: Right. The fix is a workaround, though.09:43
mdboothThe problem is a deadlock.09:43
dims_mdbooth: the right fix is for all projects to honor the contract09:43
dims_so mdbooth i'd suggest evangelizing that :)09:43
mdboothdims_: You mean that wait is called after stop()?09:44
dims_yes09:44
mdboothWell, that's another matter09:44
dims_mdbooth: after all the LOG messages for a month or two. ZERO projects fixed their code09:44
mdboothAlthough based on other solutions, I would expect to be allowed to call wait() before stop()09:44
mdboothStill, if that's the contract...09:44
mdboothI discarded a review comment saying: why don't you just raise an exception here? ;)09:45
mdboothAnyway, I still think it's wrong09:45
dims_with this code multiple calls to wait/stop and combinations will still work09:45
dims_mdbooth: yes, that was the first review about 3 months ago :)09:45
mdboothWell, not wrong09:45
mdboothIt's over-complicates instead of fixing the underlying issue09:46
mdboothGive me 10 minutes, I'll add my -1 with details.09:46
dims_mdbooth: this is the best we can do at the moment09:46
dims_mdbooth: ack thanks09:46
*** Kennan has quit IRC09:47
*** Kennan has joined #openstack-oslo09:48
mdboothdims_: Looks like jharlow was up late working on it :)09:48
mdboothdims_: -1 sent. I'll submit a patch, but only for discussion.09:57
dims_mdbooth: needs to get through o.m unit tests, o.m functional tests, dsvm+tempest and ceilometer tests :)09:58
mdboothdims_: Right, and I probably won't follow that through. However, it'll be simpler and more robust.09:59
dims_mdbooth: acl thanks09:59
mdboothdims_: I noted in that review, btw, that server.wait() doesn't honour its own contract10:01
mdbooth        Once it's finished, the underlying driver resources associated to this10:01
mdbooth        server are released (like closing useless network connections).10:01
mdboothThis is only true for a maximum of 1 thread10:02
mdboothHmm, actually no10:02
mdboothdims_: Ah, actually I think the new patch might introduce a regression...10:03
mdboothDo you want to stick a hold on it for a few minutes while I work that through?10:03
dims_sileht: around?10:03
silehtdims_, yes10:03
dims_sileht: thanks, mdbooth is reviewing that patch we just pushed :)10:04
mdboothdims_: Yes, I think that's a regression10:04
mdboothI didn't comment on it originally because I didn't read the original code closely enough and thought it was there before10:05
mdboothWell, I did comment, but I didn't note it as a regression :)10:05
dims_mdbooth: whip up a follow up patch please?10:05
mdboothSo, with the new patch a thread can call wait(), but not wait()10:06
mdboothi.e. its call to wait() can complete before the call to executor.wait() has completed10:06
mdboothBecause it it being executed concurrently by another thread10:06
mdboothSo if you've got threads A and B10:07
mdboothA: wait()10:07
mdboothB: wait()10:07
mdboothA will call the executor10:07
mdboothB will complete immediately10:07
dims_mdbooth: that's why the earlier incarnation tried to enforce that the only the thread that started should call wait/stop if i remember right10:09
mdboothI think you need both a state lock and a conditional10:10
mdboothThe conditional will just be for the internal use of wait()10:10
silehtI guess my version doesn't have this issue: https://review.openstack.org/#/c/234332/10:11
mdboothI'd have left this in review, but it's currently wending its way through the gate10:11
mdboothdims_ sileht: Is there an underlying reason for the stop/wait ordering contract, btw?10:12
mdboothOr would everybody be happier if that just worked?10:13
mdboothIs it just because the implementation doesn't allow it?10:13
silehtmdbooth, we must ensure nothing call stop/wait between driver init and executor start()10:16
*** albertw1 has joined #openstack-oslo10:18
silehtmdbooth, the original issue before the lock was introduced was: driver do IO before the first polling (like initial connection) that make greenlet switch and an other greenlet can call stop/wait, when we are back to the first greenlet we call execturo.start() on a already stopped/waitted server10:21
sileht(we start polling on executor.start())10:21
* mdbooth is on a call for about 1hr10:22
mdboothbiab10:22
markus_zodyssey4me: Do you have a minute for me about https://bugs.launchpad.net/nova/+bug/1505677 ?10:40
openstackLaunchpad bug 1505677 in openstack-ansible "oslo.versionedobjects 0.11.0 causing KeyError: 'objects' in nova-conductor log" [Critical,Confirmed] - Assigned to Jesse Pretorius (jesse-pretorius)10:40
odyssey4memarkus_z sure10:41
odyssey4memarkus_z when I mentioned it yesterday, I was pointed to https://review.openstack.org/234166 as a fix from the nova team10:41
markus_zodyssey4me: Oh, on a second thought, maybe I ask the nova folks directly, sorry :)10:41
odyssey4memarkus_z you can probably pick it up with sdague10:42
markus_zodyssey4me: Right, I'll do that.10:42
*** Kennan has left #openstack-oslo10:44
sdaguemarkus_z: yeh, I was working through a different liberty patch land independently. So the bug should be fixed now10:47
sdaguein rc310:48
sdagueit was a liberty only bug10:48
markus_zsdague: OK, cool, that's what I wanted to know, thank you very much.10:48
*** ociuhandu has joined #openstack-oslo10:53
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.messaging: PoC: batch notification listener  https://review.openstack.org/23471610:53
*** shardy is now known as shardy_afk10:55
*** stevemar_ has joined #openstack-oslo10:56
*** e0ne has joined #openstack-oslo10:56
*** stevemar_ has quit IRC10:59
*** ociuhandu has quit IRC11:01
*** albertw1 has quit IRC11:06
*** ociuhandu has joined #openstack-oslo11:08
mdboothsileht dims_: It seems to me that the issue with call ordering and wait is that you must call wait after start()11:10
mdboothstop() comes after start(), so that ordering is also correct, but it's over restrictive11:11
silehtmdbooth, during server.stop(), we can have contextswitch() before executor.start()11:12
silehtmdbooth, during server.start(), we can have contextswitch() before executor.start()11:12
sileht(first sentence is wrong)11:12
mdboothI mean specifically that executor.wait() must come after executor.start() has completed11:13
silehtmdbooth, stop() too11:13
mdboothsileht: I don't see a reason that it must come after stop()11:13
mdboothIs there one?11:13
silehtmdbooth, that can come before and after but not during11:14
mdboothYou mean you can't call wait() during stop()?11:15
* mdbooth has only looked at a single executor implementation, btw11:15
openstackgerritMerged openstack/oslo.context: Fix coverage configuration and execution  https://review.openstack.org/22988511:15
openstackgerritElena Ezhova proposed openstack/oslo.service: Document termination of children on SIGHUP  https://review.openstack.org/23472911:15
silehtmdbooth, we can't call stop or wait during start11:15
mdboothsileht: Oh, right. Internal state is inconsistent until start() completes.11:16
mdboothSo you were saying that you can't call stop() until start() completes? Which is consistent.11:16
silehtyes11:17
mdboothCool11:17
silehtI think we can remove the warning about wait/stop ordering too (if we fix wait correctly)11:17
mdboothYeah, that's what I was thinking11:18
mdboothI think I'll add a condition for that11:18
silehtI have put the warning before the lock/condition exists, since we have a state into the server and we ensure consistency around it11:19
silehtwe can allow anything ordering11:19
silehtmdbooth, are you working on a new patchset ?11:20
mdboothsileht: Yeah11:20
silehtmdbooth, cool thanks11:20
mdboothAlthough given that jharlow's patch is merging anyway, I want to use a conditional, and he added DummyConditional, I'm going to base my patch on his11:21
openstackgerritMerged openstack/oslo.policy: Add cover test requirement  https://review.openstack.org/23428911:21
mdboothAlthough, as that patch introduces a race, I'm not so sure it should merge...11:22
silehtit should not11:22
*** e0ne has quit IRC11:23
*** _amrith_ is now known as amrith11:32
openstackgerritMerged openstack/oslo.rootwrap: Fix Python 3 support for eventlet monkey-patching  https://review.openstack.org/23441211:38
*** zqfan has joined #openstack-oslo11:51
*** albertw1 has joined #openstack-oslo11:52
albertw1Hi, any idea why jenkins gave this a -1 verification, even though the checks were all successful? https://review.openstack.org/#/c/234271/11:55
silehtalbertw1, you must change the requirements repo first12:07
*** gordc has joined #openstack-oslo12:10
openstackgerritMerged openstack/oslo.versionedobjects: Updated from global requirements  https://review.openstack.org/23467712:15
ihrachyssileht: have a min to talk about oslo.messaging cleanup?12:16
*** achanda has joined #openstack-oslo12:16
silehtihrachys, sure12:16
ihrachyssileht: I wonder whether it's feasible to clean up declared topics on connection close12:17
ihrachyssileht: in neutron ovs agent, we create a connection, then declare consumers, then do some work; after that start consuming from topics12:17
*** achanda has quit IRC12:17
*** achanda has joined #openstack-oslo12:18
ihrachysthe problem is that if smth crashes after we declared those topics, no consumers are attached to the topics, so even though they are auto-delete, they are left sitting on the broker12:18
silehtihrachys, the current rabbitmq driver doesn't do that, fixing that is hard without breaking rolling upgrade12:18
ihrachyssileht: how is rolling involved?12:19
silehtihrachys, because some change need to be done on topic/queue attributes that enforce to delete/recreate topic/queue12:19
ihrachyssileht: can't we delete the topic explicitly?12:20
silehtihrachys, I don't think you can do this12:21
*** achanda has quit IRC12:22
silehtihrachys, rabbitmq doesn't make difference between cleanly closed connection and the abruptily closed one, it just applies what you set on queue/topic/exchanges (auto_delete/expiration/...)12:22
silehtihrachys, the future pika driver should not suffer from this issue12:24
ihrachyssileht: so how do we avoid the race? even though I move rpc code as near to the consumers start, there is still space for a race.12:24
silehtihrachys, the race exists since the begin of openstack I guess12:26
ihrachyssileht: pika is still for rabbit?12:27
silehtihrachys, yes12:27
ihrachyssileht: I am fine with the race, as long as I can explain there is no better fix than what I already have (moving rpc initialization closer to consumers start)12:28
silehtihrachys, but even with pika you will have this behavior but with more clearer error message12:28
ihrachyswe thought we could introduce an exit handler to clean that up, but since you say there is no safe way for that, I am fine12:28
silehtihrachys, nova-conductor for example got a timeout exception on startup and retries until consumer is present12:29
*** ociuhandu has quit IRC12:30
ihrachyssileht: but what will it retry when the conductor is restarted? then the fanout topic gets a new name (due to uuid being encoded into it)12:30
ihrachysso a new queue is created, and old one is never delete12:31
silehtfanout have autodelete so it should disapear12:31
silehtreplies have autodelete too12:32
ihrachyssileht: it does not disappear before consumers are attached12:34
ihrachyssileht: because broker thinks there will eventually be one12:35
silehtihrachys, oh I see, I wasn't thinking at this case12:39
*** shardy_a1k has joined #openstack-oslo12:39
silehtihrachys, for sure pika will not have this behavior12:40
silehtihrachys, with pika only consumer creates topics12:40
silehtihrachys, so publisher can get error for none existing consumer quicker12:40
ihrachyssileht: cool. yeah, lazy approach seems to be more fail-proof12:40
silehtand not waiting the rpc_timeout12:41
*** shardy_afk has quit IRC12:41
*** shardy_a1k has quit IRC12:45
mdboothdims_ sileht: I have written something which I think might be good. Haven't even run tests against it yet, though. Grabbing lunch.12:46
*** shardy_afk has joined #openstack-oslo12:46
mdboothI've kept jharlow's _state_cond, just formalised it12:48
*** rohit_ has joined #openstack-oslo12:51
*** regXboi has joined #openstack-oslo12:56
*** stevemar_ has joined #openstack-oslo12:57
*** eliqiao has quit IRC12:57
*** rlrossit has joined #openstack-oslo12:58
*** stevemar_ has quit IRC13:00
*** jecarey has joined #openstack-oslo13:00
*** amotoki has quit IRC13:02
*** amrith is now known as _amrith_13:15
*** amotoki has joined #openstack-oslo13:15
*** jecarey has quit IRC13:18
mdboothHow long do the oslo.messaging tests typically take to run?13:20
mdboothAre we talking long or short pieces of string?13:20
*** itisha has quit IRC13:21
*** jecarey has joined #openstack-oslo13:23
*** mriedem has joined #openstack-oslo13:25
*** amotoki has quit IRC13:32
mdboothHow do you run a single unit test in oslo.messaging in a manner which allows you to attach a debugger?13:34
mdboothNM, got it13:38
*** amotoki has joined #openstack-oslo13:40
*** shardy_afk is now known as shardy13:47
*** amotoki has quit IRC13:47
*** pradk has joined #openstack-oslo13:52
*** dims_ has quit IRC14:01
*** dims has joined #openstack-oslo14:01
*** amotoki has joined #openstack-oslo14:02
*** sigmavirus24_awa is now known as sigmavirus2414:02
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.messaging: PoC: batch notification listener  https://review.openstack.org/23471614:05
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.messaging: PoC: batch notification listener  https://review.openstack.org/23471614:06
*** stevemar_ has joined #openstack-oslo14:07
*** binarin has joined #openstack-oslo14:10
dimshi binarin!14:13
binarindims: hi14:14
dimsbinarin: don't expect you to follow this, but the hot topic of the day is https://review.openstack.org/#/c/234372/14:15
dimsbinarin: and logs are here http://eavesdrop.openstack.org/irclogs/%23openstack-oslo/14:16
*** ihrachys has quit IRC14:16
dimsif you ever need it14:16
*** _amrith_ is now known as amrith14:17
*** ihrachys has joined #openstack-oslo14:17
dimsbinarin: here's how to join the fun at openstack - https://wiki.openstack.org/wiki/Documentation/HowTo/FirstTimers14:20
*** browne has joined #openstack-oslo14:22
openstackgerritMerged openstack/oslo.messaging: Use a condition (and/or a dummy one) instead of a lock  https://review.openstack.org/23437214:28
*** jecarey has quit IRC14:29
*** jecarey has joined #openstack-oslo14:29
*** zz_dimtruck is now known as dimtruck14:32
*** jecarey has quit IRC14:34
*** jecarey has joined #openstack-oslo14:36
*** mriedem has quit IRC14:37
*** ihrachys has quit IRC14:38
*** mriedem has joined #openstack-oslo14:47
*** stevemar_ has quit IRC14:50
*** stevemar_ has joined #openstack-oslo14:51
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo-specs: Adds rabbitmq-pika-driver spec  https://review.openstack.org/22899214:52
*** stevemar_ has quit IRC14:52
*** stevemar_ has joined #openstack-oslo14:52
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.messaging: PoC: batch notification listener  https://review.openstack.org/23471614:55
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.messaging: batch notification listener  https://review.openstack.org/23471614:56
*** shardy_ has joined #openstack-oslo14:56
*** shardy has quit IRC14:57
*** harlowja_at_home has joined #openstack-oslo15:01
*** shardy_ has quit IRC15:01
*** shardy has joined #openstack-oslo15:02
openstackgerritJoshua Harlow proposed openstack/oslo.messaging: Small grammar messaging fix  https://review.openstack.org/23482515:02
harlowja_at_homesileht, dims ^ just a really small fix, noticed that, damn grammar, hahaha15:03
harlowja_at_homesomeday i'll learn english :)15:03
mdboothWith a new audience :) How long do you typically expect oslo.messaging tests to take when run locally15:03
harlowja_at_homehmmm, i think i've seen like 5 minutes?15:04
silehtharlowja_at_home, mdbooth will removes this restriction the message will become useless :)15:04
mdboothharlowja_at_home: If I can get the tests to run, I'm going to delete that message :)15:04
harlowja_at_homelol15:04
harlowja_at_homeok15:04
harlowja_at_homeguess nobody liked the periodic message, lol15:04
mdboothtox is very busy doing a lot of work and not producing any output15:05
harlowja_at_hometox be a busy man15:05
mdboothIf it were deadlocked, I'd expect it to be doing no work15:05
dimsmdbooth: try without your patch first :) baseline15:05
mdboothdims: True15:05
mdbooth1m7s, with 2 failures15:08
mdboothWorth doing :)15:08
silehtmdbooth, that two failures are perhaps OK15:08
silehtmdbooth, it's about amqp1.0 driver ?15:08
mdboothYeah, I assumed as much15:08
silehtmdbooth, that will pass on gate15:08
mdboothDoes it use https://github.com/The-Compiler/pytest-vw ?15:09
silehtlol15:09
silehtmdbooth, I don't known yet which requirement need to raised to fix that issue in gate and locally15:10
mdboothnova is really verbose when running tox tests15:10
mdboothoslo.messaging is not15:10
mdboothAny idea what the difference might be?15:10
mdboothIf it's stuck running a particular test or set of tests15:11
mdboothI would like to know what they are15:11
silehtnova have a wrapper to print ongoing test15:11
*** albertw1 has left #openstack-oslo15:14
harlowja_at_homehttps://github.com/openstack/taskflow/blob/master/tools/pretty_tox.sh ?15:15
harlowja_at_homei thought that was the wrapper (or similar)15:15
harlowja_at_homedid that get shared by everyone yet15:15
harlowja_at_home( which uses https://github.com/openstack/taskflow/blob/master/tools/subunit_trace.py or equivalent)15:16
*** amrith is now known as _amrith_15:18
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo-specs: Adds rabbitmq-pika-driver spec  https://review.openstack.org/22899215:18
*** _amrith_ is now known as amrith15:20
*** david-lyle has quit IRC15:25
*** zqfan has quit IRC15:26
mdboothGrr15:26
* mdbooth is yak shaving15:26
mdboothI'd like to work out why these tests are failing15:26
mdboothBut I don't know what tests are even running15:26
*** david-lyle has joined #openstack-oslo15:27
mdboothAll I know is that it's very busy, and doesn't complete15:27
harlowja_at_homemdbooth, suck over pretty_tox.sh and subunit_trace.py and try them15:27
harlowja_at_homemight be helpful for u15:27
*** e0ne has joined #openstack-oslo15:27
harlowja_at_homesuck/move over/copyover15:27
harlowja_at_homelol15:27
mdboothThat's the yak I'm trying to shave15:27
mdboothI know nothing of how tox works :(15:27
harlowja_at_homein this case its probably not tox :)15:27
mdboothI'm also trying to keep it that way15:27
harlowja_at_homebut ya, testr output isn't so easy to figure out whats going on :(15:28
mdboothHow do I get testr output?15:28
mdboothI get no output15:28
mdboothI can run a single test15:28
mdboothThat's fine15:28
mdboothSo I at least know that there are no import errors15:28
mdboothAnd the code is nominally sane in some conditions15:28
mdboothI don't mind running a complicated command line15:28
harlowja_at_homesome https://github.com/openstack/oslotest/blob/master/oslotest/base.py#L33 might be useful to u15:28
harlowja_at_homeexport OS_STDERR_CAPTURE=015:29
mdboothexport it to what?15:29
harlowja_at_homeexport OS_STDOUT_CAPTURE=015:29
* mdbooth just want to know what the command line is15:29
mdboothWhat command do I run to get some output?15:29
harlowja_at_homeexport OS_DEBUG=515:29
mdboothStep back15:29
harlowja_at_homek15:29
mdboothIf I don't invoke tox, what tool do I run?15:29
harlowja_at_hometestr run15:30
* mdbooth tries that15:30
harlowja_at_homemake sure u are in the virtualenv that tox creates though15:30
harlowja_at_homebefore doing this15:30
harlowja_at_homewhich is typically at .tox/py27/bin/activate15:30
*** yamahata has joined #openstack-oslo15:30
mdboothYeah, got that, thanks15:30
harlowja_at_homek15:30
dimsmdbooth: why don't you upload a review? we can poke at it too15:33
harlowja_at_homebb, heading into work15:34
*** harlowja_at_home has quit IRC15:34
mdboothharlowja: I have output! :)15:34
mdboothIt's not the output I'm looking for, but it's a step in the right direction :)15:35
mdboothdims: Intransigence :)15:35
dimslol15:36
mdboothdims: Seriously, though, it might not be nice to the gate15:36
mdboothThe tests seem to be spinning on something15:36
mdbooth   ERROR [oslo_messaging._drivers.impl_qpid] Unable to connect to AMQP server on {'username': None, 'host': 'host2:5672', 'password': None}: None. Sleeping 1 seconds15:37
mdboothIs that normal?15:37
mdboothApparently it is15:41
*** jecarey has quit IRC15:43
*** markus_z has quit IRC15:43
*** jecarey has joined #openstack-oslo15:43
* mdbooth just want the name of 1 test which fails15:44
mdboothAny test15:44
mdboothThe first one15:44
*** david-ly_ has joined #openstack-oslo15:46
*** david-lyle has quit IRC15:47
*** jecarey has quit IRC15:48
*** jecarey has joined #openstack-oslo15:49
dimsmdbooth: harlowja: sileht: got a gate-tempest-dsvm-full succeed with oslo.messaging-master (devstack review https://review.openstack.org/#/c/234811/)15:51
dimsmdbooth: harlowja: sileht: http://logs.openstack.org/11/234811/1/check/gate-tempest-dsvm-full/cb44f14//logs/testr_results.html.gz15:51
dimsmdbooth: paste.org?15:51
mdboothdims: Can do, but I'm moving again, now15:52
dimsok15:52
mdboothHopefully it's just a typo :)15:52
*** rohit_ has quit IRC15:54
*** david-ly_ is now known as david-lyle15:54
mdboothEurgh15:54
mdboothIn TestMultipleServers.test_multiple_servers15:54
mdboothHow is self.exchange1 initialised?15:54
mdboothpython -m testtools.run oslo_messaging.tests.rpc.test_server.TestMultipleServers.test_multiple_servers15:55
mdboothDoesn't do it15:55
mdboothHmm, might be some python skulduggery going on there15:56
*** ihrachys has joined #openstack-oslo16:00
openstackgerritSriram Madapusi Vasudevan proposed openstack/taskflow: feat: add max_dispatches arg to conductor's run  https://review.openstack.org/23485816:00
*** sreshetn1ak has quit IRC16:01
*** pkholkin has quit IRC16:01
*** sreshetnyak has joined #openstack-oslo16:02
mdboothNope, so the TestMultipleServers tests definitely hang, but I can't work out how to describe one of them16:06
mdboothThey seem to be using 'testscenarios' to generate multiple variants16:06
mdboothHow do I specify 1 test from 1 variant?16:07
*** sputnik13 has joined #openstack-oslo16:07
mdboothActually, nm. I'll patch those tests out and try to find a failure elsewhere16:07
*** cdent has quit IRC16:08
*** ihrachys has quit IRC16:14
*** ihrachys has joined #openstack-oslo16:17
*** jecarey has quit IRC16:18
*** jecarey has joined #openstack-oslo16:19
*** gangil has joined #openstack-oslo16:22
*** gangil has joined #openstack-oslo16:22
*** jecarey has quit IRC16:24
*** shardy has quit IRC16:25
mdboothAh, ha!16:27
mdboothI'm not accounting for DummyCondition :)16:27
mdboothThat means it ends up in a busy loop16:29
mdboothdims harlowja: Sorry, just received SIGWIFE. I now know what needs to be fixed, and I'll do it in the morning. Should be just a tweak.16:30
*** yassine has quit IRC16:31
openstackgerritGreg Hill proposed openstack/taskflow: Update decider spec to allow specifying which atoms to skip  https://review.openstack.org/23117416:34
*** jasondotstar_ has joined #openstack-oslo16:39
*** cburgess_ has joined #openstack-oslo16:44
harlowjadims cool, that loooks all green :-P16:45
harlowjai like the green, ha16:45
dimsmdbooth: no worries. a paste would have helped :)16:46
dimsmdbooth: to see how far you got16:46
*** zzzeek_ has joined #openstack-oslo16:46
*** e0ne_ has joined #openstack-oslo16:49
*** ihrachys has quit IRC16:50
*** e0ne has quit IRC16:50
*** jaypipes has quit IRC16:50
*** eezhova has quit IRC16:50
*** zzzeek has quit IRC16:50
*** cburgess has quit IRC16:50
*** rakhmerov has quit IRC16:50
*** sileht has quit IRC16:50
*** SlickNik has quit IRC16:50
*** jasondotstar has quit IRC16:50
*** amrith has quit IRC16:50
*** dulek has quit IRC16:50
*** peterstac has quit IRC16:50
*** dstanek has quit IRC16:50
*** sreshetnyak has quit IRC16:50
*** binarin has quit IRC16:50
*** rlrossit has quit IRC16:50
*** bapalm has quit IRC16:50
*** lifeless has quit IRC16:50
*** hogepodge has quit IRC16:50
*** mtreinish has quit IRC16:50
*** isq_ has quit IRC16:50
*** amaurymedeiros has quit IRC16:50
*** shardy has joined #openstack-oslo16:50
*** gangil has left #openstack-oslo16:50
harlowjamdbooth cool16:52
dimsharlowja: hmm, i'd have really liked to see where mdbooth was headed :(16:53
harlowja:-/16:53
harlowjato his wife?16:53
harlowjalol16:53
dimswith his patch :)16:53
harlowjaprobably16:54
harlowjalol16:54
*** e0ne_ is now known as e0ne16:55
*** sreshetnyak has joined #openstack-oslo16:59
*** binarin has joined #openstack-oslo16:59
*** rlrossit has joined #openstack-oslo16:59
*** bapalm has joined #openstack-oslo16:59
*** lifeless has joined #openstack-oslo16:59
*** hogepodge has joined #openstack-oslo16:59
*** mtreinish has joined #openstack-oslo16:59
*** isq_ has joined #openstack-oslo16:59
*** amaurymedeiros has joined #openstack-oslo16:59
*** ihrachys has joined #openstack-oslo17:06
*** sreshetnyak has quit IRC17:07
*** binarin has quit IRC17:07
*** rlrossit has quit IRC17:07
*** bapalm has quit IRC17:07
*** lifeless has quit IRC17:07
*** hogepodge has quit IRC17:07
*** mtreinish has quit IRC17:07
*** isq_ has quit IRC17:07
*** amaurymedeiros has quit IRC17:07
*** eezhova has joined #openstack-oslo17:07
*** amrith has joined #openstack-oslo17:07
*** jaypipes has joined #openstack-oslo17:08
*** sileht has joined #openstack-oslo17:08
*** peterstac has joined #openstack-oslo17:08
*** SlickNik has joined #openstack-oslo17:08
*** sreshetnyak has joined #openstack-oslo17:10
*** binarin has joined #openstack-oslo17:10
*** rlrossit has joined #openstack-oslo17:10
*** bapalm has joined #openstack-oslo17:10
*** lifeless has joined #openstack-oslo17:10
*** hogepodge has joined #openstack-oslo17:10
*** mtreinish has joined #openstack-oslo17:10
*** isq_ has joined #openstack-oslo17:10
*** amaurymedeiros has joined #openstack-oslo17:10
*** rakhmerov has joined #openstack-oslo17:13
*** yamahata has quit IRC17:14
*** shardy has quit IRC17:14
*** amrith is now known as _amrith_17:14
*** browne has quit IRC17:15
*** achanda has joined #openstack-oslo17:17
*** dimtruck is now known as zz_dimtruck17:17
*** vilobhmm11 has joined #openstack-oslo17:18
*** jecarey has joined #openstack-oslo17:20
*** mriedem has quit IRC17:21
*** dstanek_ has joined #openstack-oslo17:22
*** dstanek_ has quit IRC17:23
*** dstanek has joined #openstack-oslo17:24
*** jecarey has quit IRC17:24
*** nkrinner has quit IRC17:28
*** jecarey has joined #openstack-oslo17:28
*** jecarey has quit IRC17:31
*** jecarey has joined #openstack-oslo17:31
*** sreshetnyak has quit IRC17:35
*** jecarey has quit IRC17:36
*** jecarey has joined #openstack-oslo17:37
*** yamahata has joined #openstack-oslo17:38
*** jasondotstar_ is now known as jasondotstar17:39
*** zz_dimtruck is now known as dimtruck17:40
*** mriedem has joined #openstack-oslo17:40
*** sreshetnyak has joined #openstack-oslo17:45
*** nikhil_k has quit IRC17:45
*** rlrossit has quit IRC17:47
*** thumpba has joined #openstack-oslo17:51
*** rlrossit has joined #openstack-oslo17:52
*** browne has joined #openstack-oslo17:55
*** _amrith_ is now known as amrith18:00
harlowjadims sooo for the session titles, anyone want to look through a bunch of japanese hakiu ?18:01
harlowjai think we should do all haiku, lol18:01
harlowja*  haiku18:01
harlowjahttp://www.toyomasu.com/haiku/ :-P18:01
harlowjaseems relevant to the location of the summit, ha18:01
harlowja'From a bathing tub18:02
harlowjaI throw water into the lake -18:02
harlowjaslight muddiness appears.' lol18:02
harlowja:-/18:02
*** edmondsw has quit IRC18:09
*** nikhil has joined #openstack-oslo18:15
*** e0ne has quit IRC18:15
*** e0ne has joined #openstack-oslo18:20
*** ihrachys has quit IRC18:22
*** achanda has quit IRC18:25
*** edmondsw has joined #openstack-oslo18:28
*** thumpba has quit IRC18:29
*** jecarey_ has joined #openstack-oslo18:30
*** jecarey__ has joined #openstack-oslo18:32
*** jecarey has quit IRC18:33
harlowjalifeless  https://review.openstack.org/23492418:34
harlowjafyi18:34
harlowjagoing to integrate that into oslo.utils to avoid a hack that is showing up in taskflow18:34
*** david-lyle has quit IRC18:35
*** jecarey_ has quit IRC18:35
*** david-lyle has joined #openstack-oslo18:39
*** david-ly_ has joined #openstack-oslo18:40
openstackgerritJoshua Harlow proposed openstack/oslo.utils: Expose function signature fetching function  https://review.openstack.org/23492718:42
*** david-ly_ has quit IRC18:43
*** david-ly_ has joined #openstack-oslo18:44
*** david-lyle has quit IRC18:44
*** david-ly_ is now known as david-lyle18:45
*** david-lyle has quit IRC18:45
*** david-lyle has joined #openstack-oslo18:47
*** jecarey__ has quit IRC18:56
*** jecarey has joined #openstack-oslo18:57
*** david-lyle has quit IRC19:00
amrithdims, yt?19:01
amrithdowngraded to 2.5.019:02
amrithand now trying19:02
*** dimtruck is now known as zz_dimtruck19:04
amrithdims, same problem with 2.5.019:04
amrithnot sure what else has been impacted19:04
dimsdid you activate the venv and force an install of 2.5.0?19:04
*** thumpba has joined #openstack-oslo19:04
dimsamrith: ^^19:05
amrithI deleted my .tox19:05
amrithchanged my requirements.txt19:05
amrithand re-ran tox19:05
amriththat recreates the venv19:05
dimsoslo.messaging===2.5.019:06
dims?19:06
amrithoslo.messaging<2.6.0 got me 2.5.019:06
amrithoslo.messaging!=1.17.0,!=1.17.1,>=1.16.0,<2.6.0 # Apache-2.019:06
amrithamrith@amrith-work:/opt/stack/trove$ . .tox/py27/bin/activate19:07
amrith(py27)amrith@amrith-work:/opt/stack/trove$ pip list | grep oslo.messaging19:07
amrithoslo.messaging (2.5.0)19:07
amrith(py27)amrith@amrith-work:/opt/stack/trove$19:07
*** david-lyle has joined #openstack-oslo19:08
dimsamrith: gotcha. then it's a different problem :*19:08
dims:(19:08
amrithyup19:08
lifelessharlowja: ack19:09
*** achanda has joined #openstack-oslo19:09
openstackgerritJoshua Harlow proposed openstack/oslo.utils: Expose function signature fetching function  https://review.openstack.org/23492719:09
openstackgerritSriram Madapusi Vasudevan proposed openstack/taskflow: feat: add max_dispatches arg to conductor's run  https://review.openstack.org/23485819:09
harlowjalifeless thx19:09
dimsamrith: let's track it as a bug please19:09
harlowjalifeless  https://review.openstack.org/234927 switches oslo_uils to using it19:09
harlowja*oslo_utils19:09
*** zz_dimtruck is now known as dimtruck19:14
*** david-lyle has quit IRC19:25
*** david-ly_ has joined #openstack-oslo19:25
lifelessharlowja: you on twitter?19:34
harlowjawhats that crap, haha19:34
harlowjanah19:34
* harlowja never got into tweeting19:34
*** david-ly_ has quit IRC19:38
*** david-lyle has joined #openstack-oslo19:38
*** david-lyle has quit IRC19:39
*** david-lyle has joined #openstack-oslo19:41
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo.messaging: Implements rabbit-pika driver  https://review.openstack.org/22998519:42
openstackgerritJoshua Harlow proposed openstack/oslo.utils: Expose function signature fetching function  https://review.openstack.org/23492719:43
harlowjasputnik13 since i think u have looked at that code also ^19:46
harlowjadhellmann https://review.openstack.org/#/c/233301/ should that be ok to unblock now?19:49
*** e0ne has quit IRC19:49
*** jecarey has quit IRC19:54
*** stevemar_ is now known as stevemar_jays19:55
*** thumpba has quit IRC19:55
*** david-lyle has quit IRC19:56
*** jecarey_ has joined #openstack-oslo19:57
*** david-lyle has joined #openstack-oslo19:58
*** achanda has quit IRC20:00
peterstachi all, in Trove we seem to be having a problem with oslo.utils 2.6.0 causing our tox tests to hang20:00
peterstacany known issues we should be aware of?20:00
*** david-ly_ has joined #openstack-oslo20:01
*** jecarey_ has quit IRC20:01
openstackgerritSriram Madapusi Vasudevan proposed openstack/taskflow: feat: add max_dispatches arg to conductor's run  https://review.openstack.org/23485820:01
lifelessharlowja: https://sourceforge.net/p/pypi/support-requests/546/20:02
peterstacharlowja, dhellmann ^^^^20:02
harlowjahmmmm, oslo.utils causing tests to hang20:02
harlowjapeterstac any idea which part of code?20:02
harlowjaidk of any issues?20:02
harlowjadims know of any/20:02
harlowja?20:02
*** david-lyle has quit IRC20:03
harlowjalifeless looks good to me20:03
peterstacharlowja, it seems to spin throwing the same msg into the log - one sec ...20:03
harlowjahmm20:03
*** david-ly_ is now known as david-lyle__20:03
*** david-lyle__ is now known as david-lyle___20:03
dimspeterstac: haven't heard of anything20:03
peterstacok, just wondering20:04
dimspeterstac: open a bug yet?20:04
peterstacnot yet, we're still trying to investigate (wanted to make sure it wasn't us :D )20:06
*** david-lyle has joined #openstack-oslo20:06
*** david-lyle___ has quit IRC20:06
peterstacit fills the log with the following msg: http://paste.openstack.org/show/476304/20:07
harlowjalol20:08
harlowjaalways sleep with a reason20:08
dimsweird :)20:08
harlowjathou shall not sleep with no reason20:08
harlowjaso this 'fake_sleep' is raising an exception?20:09
harlowjathat seems sorta weird20:09
harlowjadoing that probably triggers https://github.com/openstack/oslo.utils/blob/master/oslo_utils/excutils.py#L22720:09
harlowjawhich now logs these kind of oddities20:09
*** amrith is now known as _amrith_20:10
harlowjahttps://review.openstack.org/#/c/230619/4/oslo_utils/excutils.py will not suffer from this afaik20:11
dimspeterstac: possibly this change? https://github.com/openstack/oslo.utils/commit/6010fb3fff11fc961c5c8038543122b909e15666#diff-3cce8243cb5c7f567a816fe701341c5020:11
harlowjasince it doesn't try to capture exceptions in sleep calls20:11
harlowjafeel free to try https://review.openstack.org/#/c/230619/20:11
harlowjawhich afaik won't have that exception being logged20:11
harlowjathe scope of that try, catch block is reduced in 230619 , likely to more of what it should be20:12
harlowjafeel free to try that out20:12
peterstacok, I'll give it a shot, thx20:13
harlowjanp20:13
openstackgerritJoshua Harlow proposed openstack/taskflow: Add in-memory backend delete() in recursive/non-recursive modes  https://review.openstack.org/18998220:17
openstackgerritJoshua Harlow proposed openstack/taskflow: Change engine 'self._check' into a decorator  https://review.openstack.org/22526620:23
*** rohit_ has joined #openstack-oslo20:34
*** achanda has joined #openstack-oslo20:41
*** achanda has quit IRC20:41
*** dimtruck is now known as zz_dimtruck20:43
*** achanda has joined #openstack-oslo20:44
*** achanda has quit IRC20:56
*** edmondsw has quit IRC21:01
*** kgiusti has quit IRC21:02
*** zz_dimtruck is now known as dimtruck21:04
*** thumpba has joined #openstack-oslo21:05
*** jecarey has joined #openstack-oslo21:10
*** achanda has joined #openstack-oslo21:12
*** dimtruck is now known as zz_dimtruck21:14
*** regXboi has quit IRC21:38
*** rlrossit has left #openstack-oslo21:40
*** jecarey has quit IRC21:43
*** jecarey has joined #openstack-oslo21:43
*** zz_dimtruck is now known as dimtruck21:44
*** jecarey has quit IRC21:48
*** achanda has quit IRC21:48
*** mriedem has quit IRC21:58
*** sigmavirus24 is now known as sigmavirus24_awa22:02
openstackgerritSriram Madapusi Vasudevan proposed openstack/taskflow: feat: add max_dispatches arg to conductor's run  https://review.openstack.org/23485822:07
*** jamielennox|away is now known as jamielennox22:07
*** yassine has joined #openstack-oslo22:09
*** yassine has quit IRC22:09
*** achanda has joined #openstack-oslo22:15
openstackgerritSriram Madapusi Vasudevan proposed openstack/taskflow: feat: add max_dispatches arg to conductor's run  https://review.openstack.org/23485822:22
*** dimtruck is now known as zz_dimtruck22:26
*** pradk has quit IRC22:41
*** jecarey has joined #openstack-oslo22:44
*** achanda has quit IRC22:45
*** openstackgerrit has quit IRC22:46
*** openstackgerrit has joined #openstack-oslo22:46
*** achanda has joined #openstack-oslo22:47
*** achanda has quit IRC22:47
*** jecarey has quit IRC22:48
*** pballand has joined #openstack-oslo23:06
*** achanda has joined #openstack-oslo23:09
*** dims_ has joined #openstack-oslo23:19
*** pballand has quit IRC23:20
*** dims has quit IRC23:22
*** pballand has joined #openstack-oslo23:23
*** _amrith_ is now known as amrith23:34
amrithdims_, yt?23:41
dims_amrith: pong23:41
amrithhi ... just wanted to make sure you heard the latest on our findings and after I said YT, by buffer filled with stuff. looks like peterstac and you chatted.23:42
amrithdo you know if he entered a bug?23:42
amrithI don't see one yet23:42
amrithat this point it seems like we should back down to 2.4 or so of oslo.utils.23:43
dims_amrith: i believe harlowja asked peterstac to try https://review.openstack.org/#/c/230619/23:45
dims_y don't see a bug yet23:45
harlowjai'm 95% confident 230619 will do what u want23:45
harlowjaother 5% cause who the hell knows how software will actually work, ha23:45
sputnik13harlowja heeeellllllppp23:45
harlowjahellpppp23:46
harlowja91123:46
harlowjaif u have an emergency, pleas press 123:46
sputnik13that's what I'm doing, 911 == harlowja23:46
sputnik13:-D23:46
sputnik131111111123:46
harlowjafor operator, please press 223:46
harlowjau pressed 1, hi, this is the hospital23:46
harlowjaplease hold23:46
harlowjalol23:46
harlowjasputnik13 whats up23:46
sputnik13http://paste.openstack.org/show/476319/ we're using tooz 0.14.0 and trying to use "zookeeper" coordinator23:47
sputnik13getting that23:47
sputnik13confuzd23:47
sputnik13there's a zookeeper driver, why it no likey23:47
harlowjalet's see23:47
harlowjapython setup.py develop23:47
harlowjaotherwise not find entrypoints23:47
harlowjaor pip install tooz23:47
harlowjathats where i've seen that23:47
harlowjawhen entrypoints are requested, but package isn't actually registered to provide them23:48
sputnik13hmmm23:48
amrithok, will check23:48
sputnik13ok23:48
harlowjasputnik13 also check which tooz version23:48
sputnik130.14.023:48
harlowjaah23:48
harlowjaya, guess u said that23:48
harlowjaha23:48
harlowjasputnik13 https://github.com/openstack/tooz/blob/0.14.0/setup.cfg23:49
harlowjasoooo ya, in that version it was called kazoo23:49
sputnik13don't ask why 0.14.0, we might maybe talk about it over sake in tokyo23:49
harlowjathink i fixed that in a later version23:49
amrithdumb question ...23:49
amrithoslo.utils>=2.0.0,!=2.6.0 # Apache-2.023:49
amrithshould prevent oslo.utils v2.6.0, yes?23:49
harlowjasputnik13 so 'kazoo' not 'zookeeper'23:49
amrithI'm losing my mind23:49
dims_y23:49
amrithit installs 2.6.0 with that line23:49
amrithin requirements.txt23:49
harlowjahttps://github.com/openstack/tooz/commit/9d8b146d7143e276223:49
harlowjasputnik13 ^23:49
amritheven if I make it line 123:49
harlowjaamrith u might not be, pip is weird23:50
dims_amrith: typically, i just activate the venv and use "pip install oslo.utils===2.6.0"23:50
dims_or whichever version23:50
amrithok23:50
dims_and then rerun tox23:50
sputnik13harlowja fantastic, you rock, thank you23:50
harlowjasputnik13 please forward your insurance so i can charge them, thx23:50
harlowjathats 2000$23:50
harlowjall23:50
harlowjalol23:50
dims_holy moly i am in the wrong business :)23:51
harlowjalol23:51
harlowjadef23:51
amrithdims ... thanks, that worked23:52
amrithwill try the fix that harlowja suggested23:52
harlowja:)23:52
amritham wondering how I'll do that23:52
amrithbut I'll figure it out23:53
amrithI have enough beer at home23:53
harlowjalol23:53
* harlowja didn't know beer installs things23:53
harlowjaTIL23:53
amrithharlowja, beer doesn't install things. beer instills confidence in person who then installs things.23:54
harlowjahaha23:54
harlowjaso beer is your catalyst i guess23:54
amrithso I assume I just take the two files you are changing and drop them in the right place in my venv23:54
amrithyes?23:54
harlowjarighto23:54
harlowjaor just 1 @ https://review.openstack.org/#/c/230619/4/oslo_utils/excutils.py23:54
harlowjathe other is a test23:54
amrithbeer is an "experience enhancer"23:54
harlowjaha23:54
*** gordc has quit IRC23:55
amrithok, just grab this excutils.py23:55
amrithgot it23:55
harlowjaright23:56
*** edmondsw has joined #openstack-oslo23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!