*** geoffarnold has quit IRC | 00:08 | |
*** geoffarn_ has joined #openstack-oslo | 00:08 | |
*** achanda has joined #openstack-oslo | 00:11 | |
*** salv-orl_ has quit IRC | 00:11 | |
*** achanda has quit IRC | 00:13 | |
*** exploreshaifali has quit IRC | 00:16 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Cache atom name -> actions and provide accessor function https://review.openstack.org/198211 | 00:18 |
---|---|---|
*** haypo has quit IRC | 00:20 | |
*** sputnik13 has quit IRC | 00:22 | |
*** stevemar_ has quit IRC | 00:25 | |
*** opal has joined #openstack-oslo | 00:26 | |
*** geoffarn_ has quit IRC | 00:28 | |
*** stevemar_ has joined #openstack-oslo | 00:29 | |
*** geoffarnold has joined #openstack-oslo | 00:29 | |
*** opal has left #openstack-oslo | 00:38 | |
*** tobe has joined #openstack-oslo | 00:49 | |
*** geoffarnold has quit IRC | 00:50 | |
*** geoffarnold has joined #openstack-oslo | 00:50 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/233882 | 01:00 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.middleware: Updated from global requirements https://review.openstack.org/233883 | 01:00 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.service: Updated from global requirements https://review.openstack.org/233884 | 01:00 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.versionedobjects: Updated from global requirements https://review.openstack.org/233885 | 01:01 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use batch 'get_atoms_states' where we can https://review.openstack.org/233889 | 01:05 |
*** browne has quit IRC | 01:10 | |
*** geoffarn_ has joined #openstack-oslo | 01:12 | |
*** geoffarnold has quit IRC | 01:12 | |
*** achanda has joined #openstack-oslo | 01:31 | |
*** geoffarn_ has quit IRC | 01:33 | |
*** geoffarnold has joined #openstack-oslo | 01:33 | |
*** mtanino has quit IRC | 01:34 | |
*** pglass has joined #openstack-oslo | 01:43 | |
*** gibi has quit IRC | 01:48 | |
*** pglass has quit IRC | 01:49 | |
*** stevemar_ has quit IRC | 01:53 | |
*** geoffarnold has quit IRC | 02:15 | |
*** geoffarnold has joined #openstack-oslo | 02:16 | |
*** vilobhmm11 has quit IRC | 02:17 | |
*** browne has joined #openstack-oslo | 02:26 | |
*** links has joined #openstack-oslo | 02:28 | |
*** dims_ has quit IRC | 02:28 | |
*** yamahata has quit IRC | 02:29 | |
*** geoffarnold has quit IRC | 02:36 | |
*** geoffarnold has joined #openstack-oslo | 02:36 | |
*** salv-orlando has joined #openstack-oslo | 02:39 | |
*** mriedem has quit IRC | 02:39 | |
*** dims__ has joined #openstack-oslo | 02:41 | |
*** stevemar_ has joined #openstack-oslo | 02:42 | |
*** salv-orlando has quit IRC | 02:47 | |
*** geoffarnold has quit IRC | 02:57 | |
*** claudiub has quit IRC | 02:58 | |
*** geoffarnold has joined #openstack-oslo | 02:58 | |
*** dims__ has quit IRC | 02:59 | |
*** salv-orlando has joined #openstack-oslo | 03:08 | |
openstackgerrit | Merged openstack/oslo.db: Fix the home-page value with Oslo wiki page https://review.openstack.org/223790 | 03:15 |
openstackgerrit | Merged openstack/oslo.utils: Add 'secret' to sensitive keys https://review.openstack.org/233847 | 03:16 |
*** salv-orlando has quit IRC | 03:17 | |
openstackgerrit | Merged openstack/oslo.rootwrap: Fix Python 3 issues in tests https://review.openstack.org/233093 | 03:17 |
*** mdbooth has quit IRC | 03:22 | |
*** mdbooth has joined #openstack-oslo | 03:28 | |
*** gibi has joined #openstack-oslo | 03:33 | |
*** gangil has joined #openstack-oslo | 03:35 | |
gangil | Hi I am using oslo_config module, when I try to use -h option it shows me all the options registers with the ConfigOpts object. Is there a way I can only show the options that I want instead of all the options? | 03:37 |
gangil | like if I could override the help message | 03:37 |
*** amotoki has joined #openstack-oslo | 03:44 | |
openstackgerrit | Jamie Lennox proposed openstack/oslo.cache: Export functions from __init__ https://review.openstack.org/233924 | 03:48 |
*** amotoki has quit IRC | 03:51 | |
*** 32NAAJR1K has quit IRC | 03:54 | |
*** amotoki has joined #openstack-oslo | 03:55 | |
*** links has quit IRC | 03:58 | |
*** dims__ has joined #openstack-oslo | 03:59 | |
*** harlowja_at_home has joined #openstack-oslo | 04:00 | |
*** dims__ has quit IRC | 04:06 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use batch 'get_atoms_states' where we can https://review.openstack.org/233889 | 04:10 |
*** salv-orlando has joined #openstack-oslo | 04:15 | |
*** amotoki has quit IRC | 04:18 | |
*** salv-orlando has quit IRC | 04:19 | |
*** geoffarn_ has joined #openstack-oslo | 04:23 | |
*** geoffarnold has quit IRC | 04:24 | |
*** amotoki has joined #openstack-oslo | 04:29 | |
*** amotoki_ has joined #openstack-oslo | 04:29 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use batch 'get_atoms_states' where we can https://review.openstack.org/233889 | 04:30 |
*** salv-orlando has joined #openstack-oslo | 04:36 | |
*** amotoki_ has quit IRC | 04:36 | |
*** nikhil_k has joined #openstack-oslo | 04:39 | |
*** salv-orlando has quit IRC | 04:40 | |
*** haigang has joined #openstack-oslo | 04:41 | |
*** nikhil has quit IRC | 04:42 | |
*** haigang has quit IRC | 04:42 | |
*** geoffarnold has joined #openstack-oslo | 04:44 | |
*** geoffarn_ has quit IRC | 04:44 | |
*** harlowja_at_home has quit IRC | 04:45 | |
*** opal has joined #openstack-oslo | 04:49 | |
*** opal has left #openstack-oslo | 04:50 | |
*** links has joined #openstack-oslo | 05:06 | |
*** geoffarnold has quit IRC | 05:19 | |
*** geoffarnold has joined #openstack-oslo | 05:19 | |
*** jecarey has joined #openstack-oslo | 05:30 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.log: Updated from global requirements https://review.openstack.org/233945 | 05:30 |
*** vilobhmm11 has joined #openstack-oslo | 05:33 | |
*** tobe has quit IRC | 05:39 | |
*** geoffarnold has quit IRC | 05:40 | |
*** nikhil has joined #openstack-oslo | 05:41 | |
*** geoffarnold has joined #openstack-oslo | 05:41 | |
*** nikhil_k has quit IRC | 05:43 | |
*** abhishekk has joined #openstack-oslo | 05:46 | |
*** nkrinner has joined #openstack-oslo | 05:46 | |
*** jecarey has quit IRC | 05:50 | |
*** stevemar_ has quit IRC | 06:03 | |
*** dims__ has joined #openstack-oslo | 06:03 | |
*** sputnik13 has joined #openstack-oslo | 06:08 | |
*** dims__ has quit IRC | 06:09 | |
*** mmasaki has joined #openstack-oslo | 06:10 | |
*** sputnik13 has quit IRC | 06:11 | |
*** vilobhmm11 has quit IRC | 06:14 | |
*** links has quit IRC | 06:20 | |
*** openstack has joined #openstack-oslo | 06:28 | |
-cameron.freenode.net- [freenode-info] channel trolls and no channel staff around to help? please check with freenode support: http://freenode.net/faq.shtml#gettinghelp | 06:28 | |
*** amotoki has joined #openstack-oslo | 06:30 | |
*** gangil has quit IRC | 06:42 | |
*** geoffarnold has quit IRC | 06:44 | |
*** geoffarnold has joined #openstack-oslo | 06:44 | |
*** achanda has quit IRC | 06:46 | |
*** achanda has joined #openstack-oslo | 06:48 | |
*** amotoki has quit IRC | 06:54 | |
*** e0ne has joined #openstack-oslo | 06:58 | |
*** e0ne has quit IRC | 06:59 | |
*** dims__ has joined #openstack-oslo | 07:05 | |
*** dims__ has quit IRC | 07:10 | |
*** exploreshaifali has joined #openstack-oslo | 07:11 | |
*** links has joined #openstack-oslo | 07:13 | |
*** ndipanov has quit IRC | 07:13 | |
*** e0ne has joined #openstack-oslo | 07:16 | |
*** achanda has quit IRC | 07:20 | |
*** exploreshaifali has quit IRC | 07:20 | |
*** itisha has quit IRC | 07:21 | |
*** haypo has joined #openstack-oslo | 07:22 | |
haypo | morning | 07:22 |
*** geoffarn_ has joined #openstack-oslo | 07:27 | |
*** xek_ is now known as xek | 07:29 | |
*** geoffarnold has quit IRC | 07:31 | |
*** eezhova has joined #openstack-oslo | 07:32 | |
*** amotoki has joined #openstack-oslo | 07:34 | |
*** yamahata has joined #openstack-oslo | 07:40 | |
*** amotoki has quit IRC | 07:42 | |
*** e0ne has quit IRC | 07:44 | |
*** geoffarn_ has quit IRC | 07:48 | |
*** geoffarnold has joined #openstack-oslo | 07:48 | |
*** browne has quit IRC | 07:50 | |
*** amotoki has joined #openstack-oslo | 07:50 | |
*** salv-orlando has joined #openstack-oslo | 07:59 | |
*** markus_z has joined #openstack-oslo | 08:01 | |
*** salv-orlando has quit IRC | 08:03 | |
*** dims__ has joined #openstack-oslo | 08:06 | |
*** links has quit IRC | 08:08 | |
*** geoffarnold has quit IRC | 08:09 | |
*** geoffarnold has joined #openstack-oslo | 08:10 | |
*** amotoki has quit IRC | 08:10 | |
*** yassine__ has joined #openstack-oslo | 08:11 | |
*** dims__ has quit IRC | 08:11 | |
*** amotoki has joined #openstack-oslo | 08:17 | |
*** links has joined #openstack-oslo | 08:17 | |
jd__ | sileht: I'm trying to fix https://bugs.launchpad.net/python-cliff/+bug/1503618 but I wonder if it's even possible without changing the whole cliff architecture | 08:18 |
openstack | Launchpad bug 1503618 in cliff "argparse abbrev function breaks parsing" [Undecided,New] | 08:18 |
jd__ | cliff should have pushed for subparsers and it does not | 08:19 |
sileht | jd__, why not just backporting allow_abbrev=False into python-argparse ? | 08:19 |
jd__ | sileht: no idea how possible it is | 08:20 |
jd__ | I can try I guess, we'll see, it seems argparse is not that dead | 08:20 |
sileht | jd__, the patch itself is really simple, but I don't known the process/acceptance to backport thing into argparse | 08:20 |
*** ndipanov has joined #openstack-oslo | 08:21 | |
jd__ | me neither, I'll try | 08:22 |
*** links has quit IRC | 08:24 | |
*** amotoki has quit IRC | 08:25 | |
*** salv-orlando has joined #openstack-oslo | 08:26 | |
*** amotoki has joined #openstack-oslo | 08:29 | |
*** yamahata has quit IRC | 08:31 | |
*** links has joined #openstack-oslo | 08:31 | |
*** gibi has quit IRC | 08:32 | |
*** gibi has joined #openstack-oslo | 08:32 | |
*** openstack has joined #openstack-oslo | 08:47 | |
*** amotoki has joined #openstack-oslo | 08:49 | |
sileht | jd__, cool | 08:50 |
*** flaper87 has quit IRC | 08:51 | |
*** flaper87 has joined #openstack-oslo | 08:51 | |
*** mdbooth has joined #openstack-oslo | 08:51 | |
*** geoffarn_ has joined #openstack-oslo | 08:53 | |
*** links has quit IRC | 08:54 | |
*** links has joined #openstack-oslo | 08:54 | |
*** markus_z has quit IRC | 08:54 | |
*** markus_z has joined #openstack-oslo | 08:54 | |
*** ozamiatin has joined #openstack-oslo | 08:57 | |
*** geoffarnold has quit IRC | 08:57 | |
*** ozamiatin has quit IRC | 09:01 | |
*** exploreshaifali has joined #openstack-oslo | 09:03 | |
*** eliqiao has quit IRC | 09:06 | |
*** dims__ has joined #openstack-oslo | 09:08 | |
*** cdent has joined #openstack-oslo | 09:10 | |
*** dims__ has quit IRC | 09:13 | |
*** geoffarn_ has quit IRC | 09:13 | |
*** geoffarnold has joined #openstack-oslo | 09:14 | |
*** links has quit IRC | 09:15 | |
*** amotoki has quit IRC | 09:20 | |
*** amotoki has joined #openstack-oslo | 09:21 | |
*** amotoki has quit IRC | 09:25 | |
*** geoffarnold has quit IRC | 09:34 | |
*** geoffarnold has joined #openstack-oslo | 09:35 | |
*** amotoki has joined #openstack-oslo | 09:38 | |
*** openstackstatus has joined #openstack-oslo | 09:38 | |
*** ChanServ sets mode: +v openstackstatus | 09:38 | |
-openstackstatus- NOTICE: gerrit is undergoing an emergency restart to investigate load issues | 09:43 | |
*** ChanServ changes topic to "gerrit is undergoing an emergency restart to investigate load issues" | 09:43 | |
*** dims__ has joined #openstack-oslo | 09:49 | |
*** geoffarnold has quit IRC | 09:56 | |
*** geoffarnold has joined #openstack-oslo | 09:56 | |
*** yassine__ has quit IRC | 09:56 | |
*** e0ne has joined #openstack-oslo | 09:58 | |
*** ozamiatin has joined #openstack-oslo | 10:01 | |
*** openstackgerrit has quit IRC | 10:01 | |
*** openstackgerrit has joined #openstack-oslo | 10:01 | |
*** amotoki has quit IRC | 10:06 | |
openstackgerrit | Daisuke Fujita proposed openstack/oslo.policy: Fix a typo in policy.py https://review.openstack.org/234110 | 10:16 |
*** geoffarn_ has joined #openstack-oslo | 10:17 | |
*** dims__ is now known as dims | 10:18 | |
openstackgerrit | Marian Horban proposed openstack/oslo.log: Fix requirements for Windows https://review.openstack.org/234112 | 10:20 |
*** shardy_ has joined #openstack-oslo | 10:20 | |
openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: Fix target resolution mismatch in neutron, nova, heat https://review.openstack.org/232720 | 10:21 |
*** geoffarnold has quit IRC | 10:21 | |
*** shardy has quit IRC | 10:22 | |
openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: Fix target resolution mismatch in neutron, nova, heat https://review.openstack.org/232720 | 10:23 |
*** shardy_ has quit IRC | 10:25 | |
*** amotoki has joined #openstack-oslo | 10:26 | |
*** shardy has joined #openstack-oslo | 10:26 | |
*** amotoki has quit IRC | 10:28 | |
*** geoffarn_ has quit IRC | 10:38 | |
*** geoffarnold has joined #openstack-oslo | 10:38 | |
openstackgerrit | Daisuke Fujita proposed openstack/oslo.reports: Fix a typo in process.py https://review.openstack.org/234121 | 10:39 |
openstackgerrit | Merged openstack/devstack-plugin-zmq: Adding LICENSE file https://review.openstack.org/230834 | 10:39 |
*** ihrachys has joined #openstack-oslo | 10:42 | |
*** edmondsw has joined #openstack-oslo | 10:52 | |
*** edmondsw has quit IRC | 10:52 | |
*** jaypipes has joined #openstack-oslo | 10:59 | |
*** geoffarnold has quit IRC | 10:59 | |
openstackgerrit | Victor Stinner proposed openstack/oslo.messaging: Remove the amqp requirements https://review.openstack.org/192417 | 11:00 |
*** geoffarnold has joined #openstack-oslo | 11:00 | |
openstackgerrit | Daisuke Fujita proposed openstack/oslo.service: Fix a typo in usage.rst https://review.openstack.org/234133 | 11:02 |
*** yassine__ has joined #openstack-oslo | 11:02 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.db: Updated from global requirements https://review.openstack.org/234136 | 11:03 |
*** ociuhandu has quit IRC | 11:14 | |
-openstackstatus- NOTICE: Gerrit has been restarted and is responding to normal load again. | 11:18 | |
*** ChanServ changes topic to "#openstack-oslo" | 11:18 | |
*** geoffarnold has quit IRC | 11:21 | |
*** geoffarnold has joined #openstack-oslo | 11:21 | |
openstackgerrit | Merged openstack/oslo.messaging: AMQP1.0: Turn off debug tracing when running tox https://review.openstack.org/233094 | 11:25 |
openstackgerrit | Merged openstack/oslo.messaging: Workaround test stream corruption issue https://review.openstack.org/227003 | 11:25 |
*** exploreshaifali has quit IRC | 11:32 | |
*** gordc has joined #openstack-oslo | 11:36 | |
*** geoffarnold has quit IRC | 11:42 | |
*** geoffarnold has joined #openstack-oslo | 11:43 | |
*** dims has quit IRC | 11:47 | |
*** dims has joined #openstack-oslo | 11:48 | |
*** kgiusti has joined #openstack-oslo | 11:53 | |
*** ociuhandu has joined #openstack-oslo | 11:56 | |
*** e0ne has quit IRC | 12:00 | |
*** geoffarnold has quit IRC | 12:03 | |
*** geoffarnold has joined #openstack-oslo | 12:04 | |
openstackgerrit | Merged openstack/oslo.log: Allow oslo.log to work on non-linux platforms https://review.openstack.org/231119 | 12:06 |
*** pradk has joined #openstack-oslo | 12:11 | |
*** ociuhandu has quit IRC | 12:13 | |
*** salv-orlando has quit IRC | 12:14 | |
*** ozamiatin has quit IRC | 12:21 | |
*** geoffarnold has quit IRC | 12:24 | |
*** geoffarnold has joined #openstack-oslo | 12:25 | |
*** ociuhandu has joined #openstack-oslo | 12:29 | |
*** ociuhandu_ has joined #openstack-oslo | 12:31 | |
*** edmondsw has joined #openstack-oslo | 12:31 | |
*** achanda has joined #openstack-oslo | 12:32 | |
*** ociuhandu has quit IRC | 12:34 | |
*** ociuhandu_ is now known as ociuhandu | 12:34 | |
*** achanda has quit IRC | 12:37 | |
odyssey4me | I appear to be seeing the following error in nova-conductor when using oslo.versionedobjects 0.11.0, but not with 0.10.0: ERROR oslo_messaging.rpc.dispatcher KeyError: 'objects' | 12:41 |
odyssey4me | more here: http://logs.openstack.org/56/233756/8/check/gate-openstack-ansible-dsvm-commit/879f745/logs/aio1_nova_conductor_container-5ec67682/nova-conductor.log | 12:41 |
*** itisha has joined #openstack-oslo | 12:42 | |
*** ozamiatin has joined #openstack-oslo | 12:45 | |
*** e0ne has joined #openstack-oslo | 12:46 | |
*** geoffarnold has quit IRC | 12:46 | |
*** geoffarnold has joined #openstack-oslo | 12:47 | |
odyssey4me | https://bugs.launchpad.net/oslo.versionedobjects/+bug/1505677 | 12:56 |
openstack | Launchpad bug 1505677 in openstack-ansible "oslo.versionedobjects 0.11.0 causing KeyError: 'objects' in nova-conductor log" [Critical,Confirmed] - Assigned to Jesse Pretorius (jesse-pretorius) | 12:56 |
*** zz_dimtruck is now known as dimtruck | 13:03 | |
ttx | mfedosin: around ? | 13:06 |
mfedosin | ttx yup | 13:07 |
ttx | mfedosin: could you rebase https://review.openstack.org/#/c/233661/ on top of https://review.openstack.org/#/c/233842/ ? | 13:07 |
mfedosin | sure, wait a sec | 13:07 |
ttx | that will put it on the check test queue with a chance of success | 13:07 |
ttx | mfedosin: I approved the other one but if we can win one hour... | 13:08 |
*** rlrossit has joined #openstack-oslo | 13:08 | |
*** geoffarn_ has joined #openstack-oslo | 13:08 | |
*** geoffarnold has quit IRC | 13:08 | |
*** alejandrito has joined #openstack-oslo | 13:09 | |
*** salv-orlando has joined #openstack-oslo | 13:10 | |
*** achanda has joined #openstack-oslo | 13:11 | |
mfedosin | ttx done | 13:11 |
ttx | mfedosin: great thx! | 13:11 |
ttx | let's see how that goes :) | 13:12 |
*** fultonj has joined #openstack-oslo | 13:12 | |
mfedosin | ttx you're welcome! Hope everything will be fine :) | 13:14 |
*** amrith is now known as _amrith_ | 13:17 | |
sdague | odyssey4me: on liberty ? | 13:18 |
sdague | odyssey4me: https://review.openstack.org/#/c/234166/ | 13:19 |
odyssey4me | sdague yup | 13:19 |
odyssey4me | I just saw that patch proposed. You think that'll fix it? | 13:19 |
*** amotoki has joined #openstack-oslo | 13:19 | |
sdague | yes | 13:19 |
*** achanda has quit IRC | 13:20 | |
sdague | we've been working through that most of the morning in -nova | 13:20 |
*** stevemar_ has joined #openstack-oslo | 13:20 | |
odyssey4me | ok, great - so I expect that we'll be seeing another rc run in the next day or two | 13:20 |
odyssey4me | heh, yeah - I really should have been sitting there as I've been testing it all morning and much of last night :/ | 13:21 |
odyssey4me | sdague it seems to me that there is value in putting caps on stable branches as soon as they're cut | 13:23 |
odyssey4me | then incrementing them only when there's a complete set of tests run | 13:23 |
sdague | odyssey4me: we did that last time, it's a wreck | 13:23 |
sdague | because of transitive dependencies | 13:24 |
odyssey4me | sdague it's not great - but what's the alternative? | 13:24 |
sdague | it's great for release day, but generated huge numbers of breaks down the road | 13:24 |
sdague | odyssey4me: if you'd like to get involved in the requirements wrangling, more help is always welcomed, but the whole issue can not be backseat quarterbacked, there are a lot of subtleties | 13:26 |
*** ihrachys has quit IRC | 13:26 | |
sdague | dims: this whole process has raised the point those that the -liberty source jobs are needed again on oslo libs I believe | 13:28 |
*** ihrachys has joined #openstack-oslo | 13:28 | |
*** geoffarn_ has quit IRC | 13:29 | |
*** amotoki has quit IRC | 13:29 | |
*** geoffarnold has joined #openstack-oslo | 13:29 | |
*** amotoki has joined #openstack-oslo | 13:40 | |
*** abhishekk has quit IRC | 13:42 | |
*** geoffarnold has quit IRC | 13:50 | |
*** geoffarnold has joined #openstack-oslo | 13:50 | |
ihrachys | flaper87: hey! re oslo.messaging consumer declaration | 13:59 |
dims | sdague: won't it make breaking changes like the namespace and requirements (removing testresources from reqs) harder? | 13:59 |
*** sigmavirus24_awa is now known as sigmavirus24 | 14:01 | |
*** tedross has joined #openstack-oslo | 14:02 | |
*** jecarey has joined #openstack-oslo | 14:02 | |
mdbooth | Can anybody point me at an openstack project currently using automaton? | 14:09 |
mdbooth | Failing that, a review which proposes using it? | 14:09 |
*** geoffarnold has quit IRC | 14:11 | |
*** geoffarnold has joined #openstack-oslo | 14:12 | |
*** pglass has joined #openstack-oslo | 14:13 | |
*** salv-orlando has quit IRC | 14:17 | |
*** ozamiatin has quit IRC | 14:23 | |
*** amotoki has quit IRC | 14:25 | |
openstackgerrit | Alexey Yelistratov proposed openstack/oslo.messaging: Implement retries for CALL https://review.openstack.org/234243 | 14:28 |
*** regXboi has joined #openstack-oslo | 14:28 | |
*** pglass has left #openstack-oslo | 14:29 | |
*** _amrith_ is now known as amrith | 14:29 | |
openstackgerrit | Alexey Yelistratov proposed openstack/oslo.messaging: Implement retries for CALL https://review.openstack.org/234243 | 14:30 |
*** achanda has joined #openstack-oslo | 14:30 | |
*** geoffarn_ has joined #openstack-oslo | 14:33 | |
*** geoffarnold has quit IRC | 14:33 | |
*** salv-orlando has joined #openstack-oslo | 14:34 | |
*** achanda has quit IRC | 14:40 | |
*** browne has joined #openstack-oslo | 14:41 | |
*** amotoki has joined #openstack-oslo | 14:44 | |
*** zqfan has quit IRC | 14:46 | |
*** geoffarn_ is now known as geoffarnoldX | 14:47 | |
*** kgiusti has quit IRC | 14:52 | |
openstackgerrit | Albert White proposed openstack/oslo.log: remove pyinotify requirement for solaris https://review.openstack.org/234271 | 14:52 |
*** tedross has quit IRC | 14:55 | |
openstackgerrit | Merged openstack/oslo.versionedobjects: Updated from global requirements https://review.openstack.org/233885 | 14:55 |
sdague | dims: yes, but unless you are capping those libraries on liberty, it's kind of required | 14:55 |
sdague | you have to do one or the other | 14:55 |
dims | sdague: right | 14:59 |
*** mriedem has joined #openstack-oslo | 14:59 | |
*** jecarey has quit IRC | 14:59 | |
*** achanda has joined #openstack-oslo | 14:59 | |
*** jecarey has joined #openstack-oslo | 14:59 | |
openstackgerrit | Merged openstack/oslo.service: Updated from global requirements https://review.openstack.org/233884 | 15:03 |
openstackgerrit | Merged openstack/oslo.middleware: Updated from global requirements https://review.openstack.org/233883 | 15:03 |
*** achanda has quit IRC | 15:04 | |
*** jecarey has quit IRC | 15:04 | |
*** salv-orl_ has joined #openstack-oslo | 15:05 | |
*** salv-orlando has quit IRC | 15:07 | |
*** jecarey has joined #openstack-oslo | 15:10 | |
openstackgerrit | Merged openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/233882 | 15:10 |
stevemar_ | dhellmann: did you create a bug in cliff for https://bitbucket.org/catherinedevlin/cmd2/pull-requests/8/fix-bug-18-by-using-sysplatform-instead-of/diff ? | 15:11 |
openstackgerrit | Merged openstack/oslo.log: Updated from global requirements https://review.openstack.org/233945 | 15:11 |
*** geoffarnoldX has quit IRC | 15:15 | |
*** geoffarnold has joined #openstack-oslo | 15:15 | |
openstackgerrit | Brant Knudson proposed openstack/oslo.policy: Add cover test requirement https://review.openstack.org/234289 | 15:21 |
*** salv-orl_ has quit IRC | 15:23 | |
*** salv-orlando has joined #openstack-oslo | 15:28 | |
*** nkrinner has quit IRC | 15:30 | |
openstackgerrit | Brant Knudson proposed openstack/oslo.policy: Add test for invalid JSON https://review.openstack.org/234297 | 15:33 |
*** geoffarnold has quit IRC | 15:36 | |
*** salv-orl_ has joined #openstack-oslo | 15:36 | |
*** geoffarnold has joined #openstack-oslo | 15:37 | |
cdent | have there been reports of timeouts coming about from oslo.message 2.6.1 or is it just me? | 15:37 |
cdent | (this is in the ceilometer tests, downgraing to <2.6.0 fixes it) | 15:37 |
cdent | s/message/messaging/ | 15:38 |
*** salv-orlando has quit IRC | 15:38 | |
dims | cdent: new news | 15:38 |
dims | cdent: log a bug yet? | 15:38 |
cdent | I'm just gathering enough data to do so | 15:38 |
cdent | thought i would see if there was related gossip :) | 15:39 |
*** fultonj has left #openstack-oslo | 15:40 | |
*** sputnik13 has joined #openstack-oslo | 15:41 | |
cdent | dims: https://bugs.launchpad.net/oslo.messaging/+bug/1505730 | 15:43 |
openstack | Launchpad bug 1505730 in oslo.messaging "oslo.messaging 2.6.1 breaks ceilometer unit tests" [Undecided,New] | 15:43 |
cdent | a pretty weak bug report but wanted to get something in there sooner than later | 15:43 |
dims | sileht: around? ^^^ | 15:46 |
ihrachys | the failure rate these days is insane :( | 15:48 |
ihrachys | if anyone wants to have a laugh, check out that patch that fixes stable/liberty for neutron: https://review.openstack.org/#/c/232270/ | 15:48 |
ihrachys | 5 patches unbreaking the gate in 5 days | 15:49 |
*** itisha has quit IRC | 15:51 | |
*** harlowja_at_home has joined #openstack-oslo | 15:53 | |
cdent | sileht, dims: the ceilo test failures appear to be for rpc: | 15:53 |
* cdent is confirming | 15:54 | |
dims | cdent: just the test_published_no_mock test? always? | 15:54 |
*** shardy_ has joined #openstack-oslo | 15:55 | |
*** yassine__ has quit IRC | 15:55 | |
cdent | ceilometer.tests.unit.alarm.test_rpc.TestRPCAlarmNotifier.test_notify_alarm | 15:55 |
cdent | ceilometer.tests.unit.alarm.test_rpc.TestRPCAlarmNotifier.test_notify_non_string_reason | 15:55 |
*** shardy has quit IRC | 15:56 | |
*** e0ne has quit IRC | 15:56 | |
cdent | ceilometer.tests.unit.publisher.test_messaging_publisher.RpcOnlyPublisherTest.test_published_no_mock | 15:57 |
cdent | those three | 15:57 |
*** geoffarnold has quit IRC | 15:57 | |
*** geoffarnold has joined #openstack-oslo | 15:58 | |
cdent | so something with rpc seems a likely candidate | 15:58 |
*** shardy_ has quit IRC | 16:00 | |
*** shardy has joined #openstack-oslo | 16:01 | |
openstackgerrit | Brant Knudson proposed openstack/oslo.policy: Add test for raising default exception https://review.openstack.org/234309 | 16:03 |
openstackgerrit | Brant Knudson proposed openstack/oslo.policy: Add test for enforce with rule doesn't exist https://review.openstack.org/234310 | 16:03 |
*** harlowja_at_home has quit IRC | 16:05 | |
*** vilobhmm11 has joined #openstack-oslo | 16:05 | |
*** yamahata has joined #openstack-oslo | 16:06 | |
openstackgerrit | Dmitriy Ukhlov proposed openstack/oslo.messaging: Implements rabbit-pika driver https://review.openstack.org/229985 | 16:09 |
*** geoffarnold has quit IRC | 16:18 | |
sileht | cdent, dims I have found the commit's culpit | 16:19 |
*** geoffarnold has joined #openstack-oslo | 16:19 | |
dims | sileht: which one? | 16:20 |
cdent | sileht++ | 16:20 |
sileht | the only commit I have written on this version -_- | 16:20 |
dims | sileht: LOL | 16:20 |
sileht | 5a98303eee26a3fb1ff18db26969c574bd6f451e | 16:20 |
cdent | if code_has('import threading'): danger_danger | 16:21 |
dims | sileht: is that the problem? | 16:22 |
sileht | it's still around the fact that application must not call wait before stop | 16:22 |
sileht | ceilometer tests need to be fixed for sure, | 16:22 |
sileht | but my change need to be reverted too, because it doesn't fail correctly when the application do the stop/wait into the wrong order | 16:23 |
cdent | sileht: I was trying that, but couldn't figure it out: the side effect on the mock is supposed to get called but apparently wasn't | 16:23 |
* cdent blames eventlet | 16:24 | |
dims | sileht: will this be a problem only in tests or will it affect normal functionality? | 16:24 |
sileht | dims, it will affect all borken apps that use wait before stop | 16:24 |
sileht | My goal was to warn developers not to break them :p | 16:24 |
sileht | cdent, I have introduce a exclusive lock between stop and wait, in ceilometer case when wait is called, it take the lock and wait for the last message to be processed (assume stop have already been called) | 16:25 |
sileht | cdent, but in ceilometer stop have not been called yet | 16:25 |
cdent | in the case of at least one of the tests it is supposed to be but apparently the sleep is not quite working?: | 16:26 |
dims | sileht: +1 to try to fix ceilometer first | 16:26 |
cdent | https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/unit/publisher/test_messaging_publisher.py#L115 | 16:27 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: Fix issue when stop/wait order is not respected https://review.openstack.org/234332 | 16:35 |
sileht | dims, cdent https://review.openstack.org/234332 | 16:35 |
* cdent reads | 16:35 | |
sileht | dims, I guess some other applications are impacted, not only ceilometer | 16:36 |
sileht | dims, and perhaps not only in their unit tests | 16:36 |
sileht | dims, do you known if we have somewhere in case a neutron with multiple workers enabled ? | 16:37 |
cdent | I'm out of brain for today so I haven't a clue on how to fix the ceilometer tests to behave appropriately | 16:37 |
cdent | It seems they are relying on the bad behavior and would need to change quite a bit | 16:38 |
sileht | cdent, yes don't worry I will fix them | 16:38 |
sileht | cdent, we just have to use a threading event before calling collector.wait() | 16:38 |
cdent | I'll be very curious to see what you do | 16:38 |
cdent | yeah, that's what I was afraid you were going to say | 16:38 |
sileht | ahah | 16:38 |
*** ozamiatin has joined #openstack-oslo | 16:39 | |
cdent | given your change, is there a new/better way to say (before stop) "block until all the messages are flushed"? | 16:39 |
*** mfedosin has quit IRC | 16:39 | |
sileht | I wonder since I have introduced this lock lock into the rpc server perhaps we just need to reallow to call wait before stop | 16:40 |
sileht | now the oslo.messaging code is safe about that. This lock protect this | 16:40 |
* dims 's head explodes :) | 16:40 | |
*** geoffarn_ has joined #openstack-oslo | 16:41 | |
cdent | don't move dims, you'll get your head pieces mixed in with my head pieces | 16:41 |
dims | :) | 16:41 |
dims | cdent: can you check if that change fixes your 3 failures? | 16:41 |
cdent | yeah, one sec | 16:41 |
dims | pretty please | 16:41 |
*** gangil has joined #openstack-oslo | 16:43 | |
*** gangil has joined #openstack-oslo | 16:43 | |
cdent | yes it does | 16:44 |
*** geoffarnold has quit IRC | 16:44 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: Fix issue when stop/wait order is not respected https://review.openstack.org/234332 | 16:44 |
dims | cdent: nice. | 16:44 |
dims | cdent: is this breaking your stable/liberty patches too? | 16:44 |
cdent | yes | 16:45 |
cdent | because oslo.messaging isn't capped | 16:45 |
sileht | I have revisited the change and remove the no more necessary restriction | 16:45 |
* cdent tries patchset 2 | 16:45 | |
sileht | it's the same thing without the useless warning | 16:45 |
* cdent likes to be thourough | 16:46 | |
cdent | except about spelling | 16:46 |
* sileht really needs to progress about that ... | 16:46 | |
cdent | it still works | 16:47 |
sileht | I have to go | 16:47 |
cdent | thanks for the quick work | 16:48 |
dims | thanks sileht | 16:49 |
*** mfedosin has joined #openstack-oslo | 16:52 | |
*** davidlenwell has quit IRC | 16:54 | |
*** davidlenwell has joined #openstack-oslo | 16:56 | |
*** cdent has quit IRC | 16:57 | |
*** jecarey has quit IRC | 17:03 | |
*** jecarey has joined #openstack-oslo | 17:03 | |
*** ozamiatin has quit IRC | 17:04 | |
dims | sileht: test_server_invalid_wait_running_server fails | 17:07 |
*** jecarey has quit IRC | 17:08 | |
*** browne has quit IRC | 17:11 | |
*** achanda has joined #openstack-oslo | 17:14 | |
*** gordc has quit IRC | 17:14 | |
*** geoffarn_ has quit IRC | 17:16 | |
*** geoffarnold has joined #openstack-oslo | 17:18 | |
*** mtanino has joined #openstack-oslo | 17:21 | |
*** markus_z has quit IRC | 17:23 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: Fix issue when stop/wait order is not respected https://review.openstack.org/234332 | 17:23 |
sileht | dims, fixed this tests is no longer needed | 17:24 |
harlowja | whatsss up folks | 17:24 |
harlowja | is everything broken?? lol | 17:24 |
*** salv-orl_ has quit IRC | 17:24 | |
*** salv-orlando has joined #openstack-oslo | 17:25 | |
dims | sileht: ah cool | 17:30 |
dims | harlowja: https://etherpad.openstack.org/p/liberty-release-gate-race | 17:30 |
harlowja | gate race | 17:30 |
harlowja | ha | 17:30 |
harlowja | more like gate laxative | 17:30 |
harlowja | lol | 17:30 |
* harlowja needs to remember this channel is logged, lol | 17:31 | |
dims | harlowja: do you have an environment to try https://review.openstack.org/#/c/234332/ | 17:31 |
dims | harlowja: CI backed up a lot | 17:31 |
*** achanda has quit IRC | 17:31 | |
harlowja | let me look at that, might be able to find something | 17:31 |
*** gangil has quit IRC | 17:32 | |
harlowja | hmmm | 17:33 |
harlowja | intersting | 17:34 |
harlowja | dims i'll mess around with that review | 17:34 |
harlowja | got some ideas | 17:35 |
dims | harlowja: ++ | 17:35 |
dims | harlowja: lots of traffic on relmgr-office channel | 17:36 |
harlowja | didn't know that was a channel, ha | 17:36 |
harlowja | to many channels :-P | 17:36 |
harlowja | openstack-relmgr-office ? | 17:37 |
*** geoffarnold has quit IRC | 17:39 | |
*** nikhil has quit IRC | 17:39 | |
*** geoffarnold has joined #openstack-oslo | 17:40 | |
*** rlrossit has quit IRC | 17:40 | |
*** nikhil has joined #openstack-oslo | 17:40 | |
*** ihrachys has quit IRC | 17:41 | |
*** gordc has joined #openstack-oslo | 17:41 | |
*** rlrossit has joined #openstack-oslo | 17:46 | |
dims | harlowja: y | 17:47 |
dims | sileht: seems to be flaky | 17:48 |
dims | hang on let me test it on a ubuntu box | 17:48 |
*** achanda has joined #openstack-oslo | 17:48 | |
*** browne has joined #openstack-oslo | 17:54 | |
*** abitha has joined #openstack-oslo | 17:55 | |
dims | sileht: harlowja: tests are still flaky with this change | 17:57 |
harlowja | :( | 17:58 |
harlowja | k | 17:58 |
harlowja | i wonder why | 17:58 |
dims | harlowja: do you see it too? | 17:58 |
dims | http://paste.openstack.org/show/476171/ | 17:59 |
harlowja | messing around, but team meeting | 17:59 |
*** vilobhmm11 has quit IRC | 17:59 | |
*** geoffarnold has quit IRC | 18:00 | |
*** vilobhmm11 has joined #openstack-oslo | 18:00 | |
*** vilobhmm11 has quit IRC | 18:00 | |
*** vilobhmm11 has joined #openstack-oslo | 18:00 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Messing around https://review.openstack.org/234372 | 18:00 |
harlowja | bb, but thats why i was messing around with ^ | 18:00 |
*** geoffarnold has joined #openstack-oslo | 18:00 | |
harlowja | some goals meeting or something | 18:01 |
harlowja | lol | 18:01 |
*** jecarey has joined #openstack-oslo | 18:03 | |
*** kgiusti has joined #openstack-oslo | 18:07 | |
*** gangil has joined #openstack-oslo | 18:08 | |
*** gangil has joined #openstack-oslo | 18:08 | |
*** jecarey has quit IRC | 18:08 | |
*** shardy_ has joined #openstack-oslo | 18:12 | |
*** shardy has quit IRC | 18:13 | |
*** ndipanov has quit IRC | 18:14 | |
*** e0ne has joined #openstack-oslo | 18:17 | |
*** mriedem has quit IRC | 18:18 | |
*** shardy_ has quit IRC | 18:18 | |
*** shardy has joined #openstack-oslo | 18:18 | |
*** ociuhandu has quit IRC | 18:19 | |
*** mriedem has joined #openstack-oslo | 18:21 | |
*** geoffarn_ has joined #openstack-oslo | 18:22 | |
*** jecarey has joined #openstack-oslo | 18:23 | |
*** zqfan has joined #openstack-oslo | 18:25 | |
*** achanda has quit IRC | 18:25 | |
*** geoffarnold has quit IRC | 18:26 | |
*** subscope has joined #openstack-oslo | 18:26 | |
*** achanda has joined #openstack-oslo | 18:27 | |
*** e0ne has quit IRC | 18:30 | |
*** salv-orlando has quit IRC | 18:35 | |
*** geoffarnold has joined #openstack-oslo | 18:43 | |
*** geoffarn_ has quit IRC | 18:43 | |
openstackgerrit | Dmitriy Ukhlov proposed openstack/oslo.messaging: Implements rabbit-pika driver https://review.openstack.org/229985 | 18:48 |
*** amotoki has quit IRC | 19:02 | |
*** vilobhmm11 has quit IRC | 19:03 | |
*** vilobhmm11 has joined #openstack-oslo | 19:03 | |
*** vilobhmm11 has quit IRC | 19:04 | |
*** geoffarnold has quit IRC | 19:04 | |
*** vilobhmm11 has joined #openstack-oslo | 19:04 | |
*** geoffarnold has joined #openstack-oslo | 19:04 | |
dims | sileht: harlowja: this seems to work without fixing anything on the oslo.messaging side - http://paste.openstack.org/show/476175/ | 19:08 |
harlowja | kk, back | 19:09 |
harlowja | interesting | 19:11 |
harlowja | basically replacing the lock code with a dummy one | 19:11 |
haypo | harlowja: hi, i saw your work on hmac & constant_time_compare(), it's a good start | 19:12 |
haypo | harlowja: i added some comments | 19:12 |
harlowja | haypo cool | 19:13 |
harlowja | haypo i just gotta get some time to finish that | 19:13 |
harlowja | maybe today | 19:13 |
haypo | harlowja: for me, the most important question is where to put the new code and how to call it :) | 19:14 |
harlowja | haypo ya, i was reading the fun fun conversation around secret module, ha | 19:14 |
harlowja | seems like guido doesn't like it still? | 19:14 |
haypo | harlowja: ah? i read "Steven D'Aprano's pre-PEP for a "secrets" module drew immediate support from the Python benevolent dictator for life (BDFL)" in the LWN article | 19:15 |
haypo | i didn't follow the discussion | 19:15 |
harlowja | haypo yes that one, i read that | 19:16 |
dims | harlowja: can you please poke at the 3 tests (that cdent mentioned) to see why the DummyLock would work? | 19:17 |
harlowja | it avoids all locking :-/ | 19:17 |
dims | i have to run an errand and get my flu shot. | 19:17 |
harlowja | k | 19:18 |
harlowja | will do | 19:18 |
dims | thanks | 19:18 |
*** e0ne has joined #openstack-oslo | 19:19 | |
haypo | i'm having headaches with eventlet, again | 19:19 |
haypo | there is an eventlet issue on python 3 in oslo.rootwrap, i found the root issue | 19:19 |
haypo | but i don't know how to fix it | 19:19 |
haypo | it looks like the right fix is to use the subprocess module from eventlet.gree | 19:19 |
haypo | but there is no monkey patching for subprocess | 19:19 |
haypo | and it looks like oslo.rootwrap supports running with and without eventlet | 19:19 |
*** alejandrito has quit IRC | 19:20 | |
*** alejandrito has joined #openstack-oslo | 19:22 | |
harlowja | haypo take your advil | 19:22 |
haypo | haha | 19:22 |
haypo | i need stronger drug | 19:23 |
harlowja | morphine? | 19:23 |
haypo | better | 19:23 |
harlowja | coke | 19:23 |
harlowja | coke-cola | 19:23 |
harlowja | lol | 19:23 |
haypo | ah, coke-cola works too | 19:23 |
harlowja | lol | 19:23 |
haypo | i will begin with tea | 19:23 |
harlowja | bb, gotta focus for a few | 19:23 |
*** geoffarn_ has joined #openstack-oslo | 19:26 | |
*** amrith is now known as _amrith_ | 19:28 | |
*** geoffarnold has quit IRC | 19:29 | |
*** _amrith_ is now known as amrith | 19:30 | |
*** alejandrito has quit IRC | 19:32 | |
*** e0ne has quit IRC | 19:43 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Use a condition (and/or a dummy one) instead of a lock https://review.openstack.org/234372 | 19:44 |
harlowja | ok, gonna expert with that | 19:44 |
harlowja | let's get ceilometer testing going, brb | 19:44 |
harlowja | *experiment, not expert, ha | 19:46 |
*** geoffarn_ has quit IRC | 19:47 | |
*** jecarey has quit IRC | 19:49 | |
*** jecarey has joined #openstack-oslo | 19:49 | |
openstackgerrit | Victor Stinner proposed openstack/oslo.rootwrap: Fix Python 3 support for eventlet monkey-patching https://review.openstack.org/234412 | 19:51 |
haypo | eventlet crazyness ----- ^^ | 19:52 |
amrith | hello, can someone point me to a sample of code that implements monkey patching for time and threading libraries if one used the eventlet executor of oslo messaging. | 19:52 |
haypo | maybe it took me longer to write the commit message than the fix itself :-D | 19:52 |
amrith | basically when we launch some tests, we get a warning that reads: | 19:52 |
amrith | RuntimeWarning: It is highly recommended that when eventlet is used that the ['thread'] modules are monkey patched when using the 'oslo.messaging eventlet executor' (to avoid spurious or unexpected lock-ups and/or hangs) | 19:52 |
amrith | looking for a pointer to some code which would do this ... | 19:53 |
amrith | thanks! | 19:53 |
harlowja | so https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/base.py#L42 dims seems weird | 19:53 |
haypo | amrith: how is eventlet enabled in your project? | 19:53 |
harlowja | late monkey patching eventlet scares me | 19:53 |
haypo | amrith: the eventlet.monkey_patch() call | 19:53 |
*** jecarey has quit IRC | 19:54 | |
haypo | there is an "eventlet best practice" spec somewhere | 19:54 |
amrith | mostly eventlet.monkey_patch(all=True, thread=False) | 19:54 |
harlowja | eck | 19:54 |
harlowja | thread=False is asking for trouble imho | 19:54 |
haypo | amrith, harlowja : http://specs.openstack.org/openstack/openstack-specs/specs/eventlet-best-practices.html | 19:54 |
haypo | amrith: try thread=True :) | 19:54 |
amrith | monkey patching is asking for trouble | 19:54 |
amrith | but that said ;) | 19:54 |
harlowja | amrith agreed | 19:54 |
haypo | amrith: haha | 19:54 |
harlowja | but thread=False is like double trouble | 19:54 |
harlowja | lol | 19:55 |
amrith | I wrote self modifying code a while ago. | 19:55 |
amrith | I think its time is long gone ;) | 19:55 |
haypo | amrith: harlowja & me tried to get ride of eventlet in openstack, but it's probably the best *compromise* right now, sorry | 19:55 |
harlowja | come back in 20 years | 19:55 |
harlowja | lol | 19:55 |
harlowja | python5.0 will have it all fixed | 19:55 |
haypo | harlowja: in 20 years, openstack will be dead, as python | 19:55 |
harlowja | :) | 19:55 |
harlowja | well then problem solved | 19:55 |
haypo | yep, that's the trick | 19:57 |
amrith | well, with monkey_patch(thread=True) the whole thing hangs ;) | 19:57 |
amrith | progress .... | 19:57 |
harlowja | thats probably a good thing imho | 19:57 |
harlowja | thread=False is imho worse | 19:58 |
haypo | "If someone has offended you, not try to get revenge. Sit on the edge of the water, and soon you will see pass his corpse into the river." | 19:58 |
harlowja | to much stuff uses locks, and it just interacts in weird manners imho with thread=False | 19:58 |
harlowja | haypo are u a vampire :-P | 19:58 |
harlowja | u might need that infinite life feature to achieve the above quote | 19:59 |
haypo | lol | 20:02 |
*** geoffarnold has joined #openstack-oslo | 20:02 | |
*** ociuhandu has joined #openstack-oslo | 20:02 | |
haypo | it's just a random quote | 20:02 |
harlowja | :) | 20:03 |
*** jecarey has joined #openstack-oslo | 20:06 | |
*** geoffarnold has quit IRC | 20:08 | |
openstackgerrit | Brant Knudson proposed openstack/oslo.policy: Use JSON generator https://review.openstack.org/234421 | 20:08 |
*** geoffarnold has joined #openstack-oslo | 20:08 | |
*** haypo has left #openstack-oslo | 20:10 | |
*** amrith is now known as _amrith_ | 20:11 | |
*** abitha has quit IRC | 20:21 | |
*** e0ne has joined #openstack-oslo | 20:22 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Use a condition (and/or a dummy one) instead of a lock https://review.openstack.org/234372 | 20:25 |
*** shardy_ has joined #openstack-oslo | 20:28 | |
*** shardy has quit IRC | 20:29 | |
*** geoffarnold has quit IRC | 20:29 | |
*** geoffarnold has joined #openstack-oslo | 20:30 | |
*** shardy_ has quit IRC | 20:33 | |
*** shardy has joined #openstack-oslo | 20:34 | |
*** e0ne has quit IRC | 20:35 | |
*** geoffarnold has quit IRC | 20:50 | |
*** tedross has joined #openstack-oslo | 20:50 | |
*** geoffarnold has joined #openstack-oslo | 20:51 | |
dims | harlowja: let's turn that into a stand alone patch? ^^ | 20:52 |
*** exploreshaifali has joined #openstack-oslo | 20:55 | |
*** subscope has quit IRC | 21:02 | |
*** salv-orlando has joined #openstack-oslo | 21:02 | |
harlowja | dims will do, still trying it out | 21:12 |
harlowja | damn interupptions :-P | 21:12 |
harlowja | but i'm pretty sure it addresses some of the weirdness | 21:12 |
*** geoffarnold has quit IRC | 21:12 | |
*** geoffarnold has joined #openstack-oslo | 21:12 | |
dims | harlowja: i see a acquire/release from start, then a acquire from wait, then a release from stop and then a release from wait if i print out stack traces | 21:15 |
harlowja | cool | 21:15 |
harlowja | that seems like the expected behavior :) | 21:15 |
harlowja | wait until done, and profit | 21:15 |
harlowja | lol | 21:15 |
dims | right, but the stop cannot enter the _state_lock() as acquire is holding on to it already | 21:16 |
dims | so wait() followed by stop() is stuck | 21:16 |
harlowja | the wait call in wait() though should release the lock | 21:17 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Use a condition (and/or a dummy one) instead of a lock https://review.openstack.org/234372 | 21:17 |
harlowja | in ^ at least | 21:18 |
harlowja | which is why i switched that to a condition variable, instead of a lock | 21:18 |
dims | harlowja: can we add the warn back in? | 21:20 |
harlowja | k | 21:20 |
harlowja | sure | 21:20 |
dims | guess we should print it only once :) | 21:21 |
harlowja | will do | 21:21 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Use a condition (and/or a dummy one) instead of a lock https://review.openstack.org/234372 | 21:22 |
harlowja | ok let's see how that works | 21:22 |
harlowja | now to test that celiomter test | 21:24 |
harlowja | with new code | 21:24 |
dims | harlowja: will it work with multiple calls to stop/wait in wrong sequences too? :) | 21:24 |
harlowja | i think so | 21:24 |
harlowja | the wait code will really wait until someone makes it not run | 21:25 |
harlowja | and then that calling thread, if it hasn't already waited for the contained executor to finish will then wait on it to | 21:25 |
dims | harlowja: so if no one calls stop() after wait() what happens then? | 21:25 |
harlowja | it waits | 21:25 |
harlowja | while self._running: | 21:26 |
harlowja | self._state_cond.wait() | 21:26 |
dims | ok | 21:26 |
harlowja | that will just put the calling thread to sleep forever | 21:26 |
harlowja | until someone actually calls stop | 21:26 |
dims | scary :) | 21:26 |
harlowja | wait() there does have a timeout | 21:26 |
harlowja | and we could use that to yell | 21:26 |
harlowja | and/or log | 21:26 |
harlowja | up to u:-P | 21:26 |
dims | let's add a timeout and log, so at least people will find something in their logs | 21:27 |
harlowja | k | 21:27 |
harlowja | what do u want timeout to be 1second? | 21:27 |
dims | sure | 21:27 |
harlowja | k | 21:27 |
harlowja | as u wish | 21:27 |
dims | let's give that a shot :) | 21:27 |
harlowja | k | 21:27 |
dims | harlowja: DummyCondition()'s wait with that self_running will burn up cpu? | 21:28 |
harlowja | dummy condition basically doesn't do anything, ha | 21:28 |
harlowja | so no waiting | 21:28 |
harlowja | it doesn't try to simulate it | 21:29 |
harlowja | basically a noop | 21:29 |
dims | let's honor the timeout param there as well | 21:29 |
dims | and sleep() for the timeout? | 21:30 |
harlowja | hmmm | 21:30 |
harlowja | if we want to get adventours | 21:30 |
harlowja | *adventurous | 21:30 |
harlowja | not sure it matters though | 21:30 |
dims | harlowja: worried that the log will fill up if it gets into that condition | 21:30 |
harlowja | ah | 21:30 |
dims | boom! | 21:30 |
dims | back in a bit | 21:31 |
harlowja | k | 21:31 |
*** pradk has quit IRC | 21:33 | |
*** geoffarnold has quit IRC | 21:34 | |
*** geoffarn_ has joined #openstack-oslo | 21:34 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Use a condition (and/or a dummy one) instead of a lock https://review.openstack.org/234372 | 21:34 |
harlowja | dims ^ | 21:34 |
*** rlrossit has left #openstack-oslo | 21:37 | |
* harlowja running the ceilomter test a bunch of time | 21:38 | |
harlowja | so far seems ok | 21:39 |
harlowja | run #14 of 1000 | 21:39 |
harlowja | lol | 21:39 |
harlowja | at least for ceilometer/tests/unit/alarm/test_rpc.py | 21:39 |
harlowja | 205 and still ok | 21:42 |
harlowja | let's try that other one | 21:42 |
dims | 3 tests in ceilometer | 21:42 |
dims | i'll run tox -e py27 in oslo.messaging | 21:43 |
harlowja | k | 21:43 |
harlowja | https://github.com/harlowja/remote_tox use that and setup a bunch of vms :-P | 21:43 |
harlowja | its what the cool people use, ha | 21:43 |
harlowja | https://github.com/harlowja/remote_tox#what-this-does | 21:44 |
harlowja | ha | 21:44 |
openstackgerrit | tonytan4ever proposed openstack/taskflow: Register conductor information on jobboard https://review.openstack.org/234448 | 21:44 |
harlowja | how i farm out tox envs | 21:44 |
dims | nice! | 21:44 |
harlowja | nothing to special, lol | 21:45 |
harlowja | ok, so 'test_messaging_publisher' ran once seems ok | 21:45 |
harlowja | will run it a few times | 21:45 |
dims | getting some issues - http://paste.openstack.org/show/476194/ | 21:46 |
harlowja | hmmmm, someone might not be expecting us to call condition wait, ha | 21:46 |
*** gordc has quit IRC | 21:47 | |
dims | almost all of them from test_impl_rabbit.py", line 479, in test_send_receive | 21:48 |
*** mriedem has quit IRC | 21:48 | |
dims | one from test_impl_rabbit.py", line 956, in test_workers_only | 21:48 |
harlowja | hmm | 21:48 |
harlowja | ya | 21:48 |
harlowja | whats up with that | 21:48 |
harlowja | let me try using my little tox thingy | 21:51 |
harlowja | see if i get that | 21:51 |
harlowja | testing code is complicated, woah | 21:53 |
harlowja | lol | 21:53 |
dims | we can probably nuke test_server_invalid_wait_running_server as sileht did that | 21:53 |
*** geoffarn_ has quit IRC | 21:54 | |
*** geoffarnold has joined #openstack-oslo | 21:55 | |
harlowja | k | 21:56 |
harlowja | ya, thats dying on my tox | 21:57 |
harlowja | let me nuke | 21:57 |
harlowja | sorta useless test imho anyway | 21:58 |
*** dimtruck is now known as zz_dimtruck | 21:58 | |
* harlowja doesn't like tests that check logging calls were made | 21:58 | |
harlowja | to fragile... | 21:58 |
*** exploreshaifali has quit IRC | 21:59 | |
dims | all i see are timing failures | 21:59 |
harlowja | k | 22:00 |
harlowja | maybe those are ok? | 22:00 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Use a condition (and/or a dummy one) instead of a lock https://review.openstack.org/234372 | 22:00 |
harlowja | timing failures are other weird ones to be testing, to transient | 22:01 |
harlowja | trying locally though | 22:01 |
dims | harlowja: what are you using _dummy_cond for? | 22:01 |
dims | ah found it in line 186 | 22:01 |
harlowja | just to avoid that logging crap | 22:02 |
harlowja | or i can do time.sleep | 22:02 |
harlowja | https://gist.github.com/harlowja/df12ca476605bf53242f dims | 22:03 |
harlowja | seems to work ok for me | 22:03 |
harlowja | minus 'saslpasswd2' stuff that idk about, ha | 22:03 |
dims | harlowja: try it a few times? | 22:03 |
harlowja | will do | 22:03 |
dims | let me try another box | 22:04 |
harlowja | k | 22:05 |
harlowja | another machine of mine reported ok | 22:05 |
harlowja | trying a few more times | 22:05 |
*** regXboi has quit IRC | 22:06 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:08 | |
*** jecarey has quit IRC | 22:09 | |
*** david-lyle has quit IRC | 22:10 | |
dims | hmm, looks like cherry picked a wrong url :) | 22:10 |
harlowja | yup, twice more seems ok | 22:10 |
harlowja | :) | 22:10 |
dims | running on 3 boxes now | 22:10 |
harlowja | kk | 22:10 |
harlowja | i ran on 3, u run on 3 | 22:10 |
harlowja | and if it all works across all 6 | 22:10 |
harlowja | then we can clap | 22:11 |
harlowja | lol | 22:11 |
harlowja | :-P | 22:11 |
dims | haha | 22:11 |
*** tedross has quit IRC | 22:12 | |
harlowja | other thing that could be improved, is to stop using executor is None to mean the server isn't running, and also have self._running to mean the same thing | 22:12 |
harlowja | both are used, i'd prefer just to use self._running and not the other | 22:12 |
*** david-lyle has joined #openstack-oslo | 22:12 | |
harlowja | anyways | 22:12 |
dims | still see it but not as frequently | 22:13 |
dims | test_impl_rabbit.py", line 479, in test_send_receive | 22:14 |
harlowja | ya, thats a timing one | 22:14 |
harlowja | maybe u got slow computers? | 22:14 |
dims | in these test cases does it hit the DummyCondition? | 22:15 |
*** geoffarnold has quit IRC | 22:15 | |
*** shardy_ has joined #openstack-oslo | 22:15 | |
harlowja | let's see what the executor type it defaults to | 22:16 |
*** geoffarnold has joined #openstack-oslo | 22:16 | |
*** shardy has quit IRC | 22:17 | |
harlowja | sooo the default is executor='blocking' | 22:19 |
harlowja | which then uses the dummy stuff | 22:19 |
harlowja | so unless told otherwise, it should all be using the dummy | 22:19 |
*** shardy_ has quit IRC | 22:21 | |
*** shardy has joined #openstack-oslo | 22:22 | |
harlowja | test_send_receive never seems to cause issues for me, weird, let me just run that in a loop | 22:22 |
*** jecarey has joined #openstack-oslo | 22:23 | |
harlowja | those tests take a while though ha | 22:24 |
dims | harlowja: ceilometer tests are working fine too | 22:25 |
harlowja | woot | 22:25 |
dims | harlowja: let's get sileht to try this tomorrow | 22:25 |
harlowja | k | 22:25 |
harlowja | (py27)harlowja@buildingbuild:~/Dev/oslo.messaging$ testr list-tests | grep "oslo_messaging.tests.drivers.test_impl_rabbit" > t.txt | 22:25 |
harlowja | (py27)harlowja@buildingbuild:~/Dev/oslo.messaging$ testr run --load-list t.txt | 22:25 |
harlowja | running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-60} ${PYTHON:-python} -m subunit.run discover -t ./ . --load-list /tmp/tmp0yhJui | cat | 22:25 |
harlowja | i'll run that a bunch | 22:25 |
harlowja | see how it goes | 22:25 |
dims | thanks | 22:25 |
dims | i'll go grab some dinner | 22:25 |
harlowja | k | 22:25 |
dims | ttyl | 22:25 |
harlowja | lata | 22:25 |
*** jecarey has quit IRC | 22:28 | |
*** edmondsw has quit IRC | 22:33 | |
*** geoffarnold has quit IRC | 22:37 | |
*** geoffarnold has joined #openstack-oslo | 22:37 | |
*** gangil has quit IRC | 22:44 | |
*** gangil has joined #openstack-oslo | 22:52 | |
*** gangil has joined #openstack-oslo | 22:52 | |
*** zqfan has quit IRC | 22:56 | |
*** geoffarn_ has joined #openstack-oslo | 22:59 | |
*** geoffarnold has quit IRC | 23:03 | |
harlowja | soo dims ran it like 5 times, no issues | 23:03 |
harlowja | 'Ran 647 tests in 212.563s (+0.141s) | 23:03 |
harlowja | PASSED (id=5)' | 23:03 |
harlowja | simlar output... | 23:03 |
harlowja | thats runnining all the tests in 'oslo_messaging.tests.drivers.test_impl_rabbit' | 23:03 |
dims | thanks harlowja | 23:09 |
harlowja | np | 23:09 |
harlowja | let's see what sileht thoughts are on that | 23:09 |
harlowja | drjosh at your service | 23:09 |
harlowja | lol | 23:09 |
*** geoffarn_ has quit IRC | 23:18 | |
*** salv-orlando has quit IRC | 23:19 | |
*** salv-orlando has joined #openstack-oslo | 23:20 | |
*** geoffarnold has joined #openstack-oslo | 23:20 | |
*** stevemar_ has quit IRC | 23:23 | |
*** stevemar_ has joined #openstack-oslo | 23:24 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use batch 'get_atoms_states' where we can https://review.openstack.org/233889 | 23:25 |
*** I has joined #openstack-oslo | 23:25 | |
*** I is now known as Guest90194 | 23:25 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use batch 'get_atoms_states' where we can https://review.openstack.org/233889 | 23:26 |
*** salv-orlando has quit IRC | 23:27 | |
*** salv-orlando has joined #openstack-oslo | 23:28 | |
*** salv-orlando has quit IRC | 23:31 | |
*** salv-orlando has joined #openstack-oslo | 23:32 | |
*** Guest90194 has quit IRC | 23:33 | |
*** salv-orlando has quit IRC | 23:34 | |
dims | harlowja: see bottom of https://etherpad.openstack.org/p/mitaka-oslo-summit-planning need better titles :) | 23:37 |
harlowja | thinking cap activated | 23:37 |
harlowja | lol | 23:37 |
*** vilobhmm11 has quit IRC | 23:37 | |
harlowja | i just need to learn some japanesse to make good ones, lol | 23:37 |
*** vilobhmm11 has joined #openstack-oslo | 23:38 | |
harlowja | will think of some | 23:38 |
*** vilobhmm11 has quit IRC | 23:39 | |
*** vilobhmm11 has joined #openstack-oslo | 23:39 | |
*** dims has quit IRC | 23:41 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Create secretutils and include 'constant_time_compare' function https://review.openstack.org/227018 | 23:41 |
*** dims has joined #openstack-oslo | 23:42 | |
harlowja | maybe we should have english then, http://matadornetwork.com/abroad/30-awesome-japanese-idioms-start-using-english/ | 23:42 |
harlowja | or other idiom that can somewhat apply to the session(s) | 23:43 |
harlowja | in kanji | 23:43 |
harlowja | '“If you do not enter the tiger’s cave, you will not catch its cub.”' | 23:43 |
harlowja | obviously | 23:43 |
*** gangil has quit IRC | 23:51 | |
*** achanda has quit IRC | 23:53 | |
Nakato | lifeless: https://review.openstack.org/#/c/228315/3/tox.ini WRT -U is it not needed because of constraints, or just not needed? The base install_command in main testenv section has -U, which I kept the same and just added constraints. | 23:54 |
lifeless | Nakato: with constraints it has no meaning | 23:57 |
lifeless | Nakato: (because we specify everything) | 23:57 |
lifeless | Nakato: its possible there are things we don't specify tht aren't in our transitive deps and are in tox venvs | 23:58 |
lifeless | Nakato: e.g. perhaps wheel - but we've no reason to be upgrading those things either | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!