| *** amotoki has joined #openstack-oslo | 00:03 | |
| *** ozamiatin has joined #openstack-oslo | 00:05 | |
| *** achanda has quit IRC | 00:12 | |
| openstackgerrit | Merged openstack/oslo.utils: Use monotonic library to avoid finding monotonic time function https://review.openstack.org/190377 | 00:14 |
|---|---|---|
| *** dimtruck is now known as zz_dimtruck | 00:16 | |
| openstackgerrit | Merged openstack/oslo.middleware: Updated from global requirements https://review.openstack.org/200714 | 00:24 |
| *** ozamiatin has quit IRC | 00:26 | |
| openstackgerrit | Merged openstack/oslo.config: Updated from global requirements https://review.openstack.org/200712 | 00:31 |
| openstackgerrit | Merged openstack/oslotest: Updated from global requirements https://review.openstack.org/200895 | 00:39 |
| *** dims has joined #openstack-oslo | 00:42 | |
| *** dims has quit IRC | 00:44 | |
| openstackgerrit | Merged openstack/oslo.vmware: Updated from global requirements https://review.openstack.org/200894 | 00:44 |
| *** salv-orlando has joined #openstack-oslo | 00:49 | |
| *** openstackgerrit has quit IRC | 00:51 | |
| *** openstackgerrit has joined #openstack-oslo | 00:51 | |
| *** salv-orlando has quit IRC | 00:54 | |
| *** ozamiatin has joined #openstack-oslo | 01:00 | |
| *** samueldmq has quit IRC | 01:08 | |
| *** ericksonsantos has quit IRC | 01:09 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add deprecated and only alias modules for the moved types https://review.openstack.org/200966 | 01:10 |
| *** achanda has joined #openstack-oslo | 01:12 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add deprecated and only alias modules for the moved types https://review.openstack.org/200966 | 01:15 |
| *** ozamiatin has quit IRC | 01:17 | |
| *** achanda has quit IRC | 01:18 | |
| *** ozamiatin has joined #openstack-oslo | 01:18 | |
| *** ozamiatin has quit IRC | 01:18 | |
| *** dims has joined #openstack-oslo | 01:24 | |
| *** dims_ has joined #openstack-oslo | 01:28 | |
| openstackgerrit | Merged openstack/oslo.i18n: Add requirements for pre-release test scripts https://review.openstack.org/188573 | 01:30 |
| openstackgerrit | Merged openstack/oslo.vmware: Update log level of session related logs https://review.openstack.org/197536 | 01:30 |
| *** dims has quit IRC | 01:31 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Update all removal_version from being ? to being 2.0 https://review.openstack.org/200970 | 01:34 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Provide a deprecated alias for the now removed stop watch class https://review.openstack.org/196278 | 01:45 |
| *** ozamiatin has joined #openstack-oslo | 01:46 | |
| *** salv-orlando has joined #openstack-oslo | 02:03 | |
| *** salv-orlando has quit IRC | 02:08 | |
| *** salv-orlando has joined #openstack-oslo | 02:08 | |
| *** salv-orlando has quit IRC | 02:10 | |
| *** harlowja_at_home has joined #openstack-oslo | 02:25 | |
| *** tobe has joined #openstack-oslo | 02:29 | |
| *** ozamiatin has quit IRC | 02:42 | |
| *** rjaiswal has joined #openstack-oslo | 02:43 | |
| *** zz_dimtruck is now known as dimtruck | 02:49 | |
| *** tobe has quit IRC | 03:01 | |
| *** tobe has joined #openstack-oslo | 03:03 | |
| *** bnemec has quit IRC | 03:08 | |
| *** bnemec has joined #openstack-oslo | 03:10 | |
| *** kevinbenton has quit IRC | 03:35 | |
| *** manishg has joined #openstack-oslo | 03:36 | |
| *** manishg has quit IRC | 03:40 | |
| *** dims_ has quit IRC | 03:48 | |
| *** achanda has joined #openstack-oslo | 03:48 | |
| *** tobe has quit IRC | 03:55 | |
| *** manishg has joined #openstack-oslo | 03:55 | |
| *** tobe has joined #openstack-oslo | 03:56 | |
| *** salv-orlando has joined #openstack-oslo | 04:02 | |
| *** achanda has quit IRC | 04:07 | |
| *** harlowja_at_home has quit IRC | 04:09 | |
| *** salv-orlando has quit IRC | 04:10 | |
| *** salv-orlando has joined #openstack-oslo | 04:13 | |
| *** kevinbenton has joined #openstack-oslo | 04:14 | |
| *** manishg has quit IRC | 04:15 | |
| *** salv-orlando has quit IRC | 04:18 | |
| *** arnaud___ has joined #openstack-oslo | 04:22 | |
| *** bnemec has quit IRC | 04:36 | |
| *** sdake has quit IRC | 04:36 | |
| *** sdake has joined #openstack-oslo | 04:37 | |
| *** dims has joined #openstack-oslo | 04:49 | |
| *** kevinbenton has quit IRC | 04:53 | |
| *** amotoki_ has joined #openstack-oslo | 04:53 | |
| *** dims has quit IRC | 04:55 | |
| *** kevinbenton has joined #openstack-oslo | 04:59 | |
| *** achanda has joined #openstack-oslo | 05:01 | |
| openstackgerrit | Merged openstack/taskflow: Provide a deprecated alias for the now removed stop watch class https://review.openstack.org/196278 | 05:05 |
| openstackgerrit | Merged openstack/taskflow: Update all removal_version from being ? to being 2.0 https://review.openstack.org/200970 | 05:05 |
| *** pcaruana has quit IRC | 05:08 | |
| *** sdake has quit IRC | 05:08 | |
| openstackgerrit | Merged openstack/taskflow: Add deprecated and only alias modules for the moved types https://review.openstack.org/200966 | 05:08 |
| *** sdake has joined #openstack-oslo | 05:13 | |
| *** manishg has joined #openstack-oslo | 05:16 | |
| *** salv-orlando has joined #openstack-oslo | 05:16 | |
| *** manishg has quit IRC | 05:20 | |
| *** salv-orlando has quit IRC | 05:24 | |
| *** salv-orlando has joined #openstack-oslo | 05:25 | |
| *** salv-orlando has quit IRC | 05:29 | |
| *** dimtruck is now known as zz_dimtruck | 05:30 | |
| *** crc32 has joined #openstack-oslo | 05:34 | |
| *** manishg has joined #openstack-oslo | 05:35 | |
| *** amotoki_ has quit IRC | 05:39 | |
| *** manishg has quit IRC | 05:40 | |
| *** sdake has quit IRC | 05:56 | |
| *** Kennan has joined #openstack-oslo | 06:03 | |
| *** Kennan2 has quit IRC | 06:03 | |
| *** nkrinner has joined #openstack-oslo | 06:04 | |
| *** hogepodge has quit IRC | 06:19 | |
| *** hogepodge has joined #openstack-oslo | 06:26 | |
| *** arnaud___ has quit IRC | 06:29 | |
| *** arnaud___ has joined #openstack-oslo | 06:29 | |
| *** manishg has joined #openstack-oslo | 06:36 | |
| *** manishg has quit IRC | 06:41 | |
| *** pcaruana has joined #openstack-oslo | 06:42 | |
| *** salv-orlando has joined #openstack-oslo | 06:43 | |
| *** amotoki_ has joined #openstack-oslo | 06:43 | |
| *** salv-orlando has quit IRC | 06:46 | |
| *** salv-orlando has joined #openstack-oslo | 06:51 | |
| *** crc32 has quit IRC | 06:54 | |
| *** salv-orlando has quit IRC | 06:56 | |
| *** achanda has quit IRC | 06:56 | |
| *** jaosorior has joined #openstack-oslo | 07:02 | |
| *** achanda has joined #openstack-oslo | 07:03 | |
| *** achanda has quit IRC | 07:16 | |
| *** browne has quit IRC | 07:22 | |
| *** viktors|weekend is now known as viktors | 07:29 | |
| *** arnaud___ has quit IRC | 07:30 | |
| *** ihrachyshka has joined #openstack-oslo | 07:31 | |
| *** manishg has joined #openstack-oslo | 07:37 | |
| *** manishg has quit IRC | 07:42 | |
| *** Kennan has quit IRC | 07:46 | |
| *** Kennan has joined #openstack-oslo | 07:46 | |
| *** salv-orlando has joined #openstack-oslo | 07:48 | |
| *** katyafervent_awa is now known as katyafervent | 07:57 | |
| *** ihrachyshka has quit IRC | 08:01 | |
| openstackgerrit | Min Pae proposed openstack/taskflow: Replace internal fsm + table with automaton library https://review.openstack.org/139784 | 08:08 |
| *** ndipanov has joined #openstack-oslo | 08:10 | |
| *** ihrachyshka has joined #openstack-oslo | 08:11 | |
| *** shardy has joined #openstack-oslo | 08:11 | |
| *** ihrachyshka has quit IRC | 08:11 | |
| *** ihrachyshka has joined #openstack-oslo | 08:11 | |
| openstackgerrit | Dirk Mueller proposed openstack/oslo.db: Remove outdated tox environments for SQLAlchemy 0.8 https://review.openstack.org/187927 | 08:14 |
| *** exploreshaifali has joined #openstack-oslo | 08:20 | |
| *** haypo has joined #openstack-oslo | 08:26 | |
| *** ozamiatin has joined #openstack-oslo | 08:32 | |
| *** yassine_ has joined #openstack-oslo | 08:34 | |
| *** manishg has joined #openstack-oslo | 08:38 | |
| *** manishg has quit IRC | 08:43 | |
| *** rjaiswal has quit IRC | 08:44 | |
| *** amotoki_ has quit IRC | 08:46 | |
| *** jamielennox has quit IRC | 08:46 | |
| *** pblaho has joined #openstack-oslo | 09:05 | |
| *** kbyrne has quit IRC | 09:10 | |
| *** kbyrne has joined #openstack-oslo | 09:15 | |
| haypo | dhellmann: hi. why did you put your patch https://review.openstack.org/#/c/181984/ was WIP? oslo_utils was replaced with oslo.utils in all projects, no? | 09:16 |
| *** e0ne has joined #openstack-oslo | 09:19 | |
| *** e0ne is now known as e0ne_ | 09:36 | |
| *** manishg has joined #openstack-oslo | 09:39 | |
| *** manishg_ has joined #openstack-oslo | 09:40 | |
| *** manishg has quit IRC | 09:40 | |
| *** exploreshaifali has quit IRC | 09:44 | |
| *** manishg_ has quit IRC | 09:45 | |
| *** jamielennox has joined #openstack-oslo | 09:46 | |
| *** exploreshaifali has joined #openstack-oslo | 09:48 | |
| *** dims has joined #openstack-oslo | 09:58 | |
| *** alexpilotti has joined #openstack-oslo | 10:00 | |
| *** e0ne_ is now known as e0ne | 10:05 | |
| dims | looks like we have almost recovered from the mock 1.1.0 fallout...except for oslo.log (https://review.openstack.org/#/c/200518/) | 10:13 |
| *** eezhova has joined #openstack-oslo | 10:15 | |
| *** amrith has left #openstack-oslo | 10:39 | |
| *** manishg has joined #openstack-oslo | 10:41 | |
| *** e0ne is now known as e0ne_ | 10:43 | |
| *** e0ne_ is now known as e0ne | 10:43 | |
| *** manishg has quit IRC | 10:45 | |
| *** browne has joined #openstack-oslo | 10:49 | |
| *** browne has quit IRC | 10:58 | |
| *** cdent has joined #openstack-oslo | 11:00 | |
| openstackgerrit | Merged openstack/oslo.service: Updated from global requirements https://review.openstack.org/200891 | 11:01 |
| openstackgerrit | Merged openstack/oslo.messaging: Verify that version in 'prepare' is valid https://review.openstack.org/193867 | 11:01 |
| *** e0ne is now known as e0ne_ | 11:01 | |
| openstackgerrit | Merged openstack/oslo.db: Remove outdated tox environments for SQLAlchemy 0.8 https://review.openstack.org/187927 | 11:02 |
| openstackgerrit | Merged openstack/oslo.messaging: Don't reply when we known that client is gone https://review.openstack.org/193037 | 11:03 |
| openstackgerrit | Merged openstack/oslo.messaging: Make heartbeat the default https://review.openstack.org/198986 | 11:04 |
| *** eezhova has quit IRC | 11:05 | |
| *** browne has joined #openstack-oslo | 11:08 | |
| *** e0ne_ is now known as e0ne | 11:14 | |
| *** shardy_ has joined #openstack-oslo | 11:17 | |
| *** shardy has quit IRC | 11:19 | |
| *** shardy_ has quit IRC | 11:23 | |
| *** shardy has joined #openstack-oslo | 11:23 | |
| *** jaypipes has joined #openstack-oslo | 11:29 | |
| *** cdent has quit IRC | 11:35 | |
| *** tobe has quit IRC | 11:36 | |
| *** achanda has joined #openstack-oslo | 11:37 | |
| *** shardy_ has joined #openstack-oslo | 11:41 | |
| *** manishg has joined #openstack-oslo | 11:42 | |
| *** shardy has quit IRC | 11:42 | |
| *** shardy_ has quit IRC | 11:46 | |
| *** manishg has quit IRC | 11:46 | |
| *** shardy has joined #openstack-oslo | 11:47 | |
| *** achanda has quit IRC | 11:50 | |
| *** eezhova has joined #openstack-oslo | 11:54 | |
| *** zz_dimtruck is now known as dimtruck | 12:08 | |
| *** bknudson has quit IRC | 12:14 | |
| *** achanda has joined #openstack-oslo | 12:15 | |
| eezhova | dims, hi! In Oslo Library Audit spreadsheet I can see a new todo: "add bandit target to tox.ini". Is there someone working on it or I can pick it and implement for oslo.service? | 12:16 |
| *** ganso_ has joined #openstack-oslo | 12:25 | |
| *** e0ne is now known as e0ne_ | 12:33 | |
| *** gordc has joined #openstack-oslo | 12:38 | |
| *** exploreshaifali has quit IRC | 12:39 | |
| *** haypo has quit IRC | 12:40 | |
| *** bknudson has joined #openstack-oslo | 12:40 | |
| *** haypo has joined #openstack-oslo | 12:40 | |
| *** manishg has joined #openstack-oslo | 12:43 | |
| *** dimtruck is now known as zz_dimtruck | 12:43 | |
| *** e0ne_ is now known as e0ne | 12:46 | |
| *** bknudson has quit IRC | 12:46 | |
| *** manishg has quit IRC | 12:47 | |
| *** dims has quit IRC | 12:55 | |
| *** Guest33195 has joined #openstack-oslo | 12:57 | |
| Guest33195 | eezhova: go for it | 12:58 |
| *** Guest33195 is now known as dims_ | 12:58 | |
| dims_ | eezhova: go for it | 12:58 |
| *** bknudson has joined #openstack-oslo | 12:59 | |
| *** shardy_ has joined #openstack-oslo | 13:03 | |
| *** shardy has quit IRC | 13:04 | |
| *** shardy_ has quit IRC | 13:08 | |
| *** shardy has joined #openstack-oslo | 13:09 | |
| *** zz_dimtruck is now known as dimtruck | 13:10 | |
| openstackgerrit | Elena Ezhova proposed openstack/oslo.service: Add Bandit to tox for security static analysis https://review.openstack.org/201120 | 13:13 |
| haypo | eezhova: what's the current status of bandit in oslo.service? | 13:17 |
| haypo | eezhova: do we start with an empty list of warnings? | 13:17 |
| eezhova | haypo, I copied the standard config from bandit repo and running tox -e bandit gave a number of warnings. In my patch I marked those places with # nosec | 13:18 |
| haypo | eezhova: i'm not sure that # nosec is the appropriate fix to all warnings :) | 13:19 |
| haypo | eezhova: what's wrong with ssl.wrap_socket()? https://review.openstack.org/#/c/201120/1/oslo_service/sslutils.py | 13:20 |
| *** ihrachyshka has quit IRC | 13:20 | |
| *** ihrachyshka has joined #openstack-oslo | 13:20 | |
| eezhova | haypo, bandit didn't like the default default SSLv23 protocol. It said it could be insecure | 13:21 |
| haypo | eezhova: by the way, using os.uradom() or random.SystemRandom) avoid the need of random.seed() -- https://review.openstack.org/#/c/201120/1/oslo_service/service.py -- see also the discussion at: https://review.openstack.org/#/c/191581/ | 13:21 |
| haypo | eezhova: it is right :) SSLv23 is worse than TLSv1 | 13:21 |
| eezhova | haypo, I see. thank you for the hints:) perhaps such issues can be fixed in a follow up patch? | 13:24 |
| haypo | eezhova: i would prefer to fix issues before turning warnings off | 13:24 |
| haypo | otherwise, we may miss the issues | 13:25 |
| eezhova | haypo, okay, I got it :) | 13:25 |
| haypo | eezhova: i reviewed your patch | 13:26 |
| *** dimtruck is now known as zz_dimtruck | 13:28 | |
| *** exploreshaifali has joined #openstack-oslo | 13:28 | |
| dims_ | sdague: please take a look at https://review.openstack.org/#/c/191581/ when you get a chance, haypo points to just use os.urandom() :) | 13:29 |
| haypo | sdague: hi. my comments are there: https://review.openstack.org/#/c/191581/5/openstack/common/crypto/utils.py & https://review.openstack.org/#/c/191581/2/openstack/common/crypto/utils.py | 13:31 |
| *** ericksonsantos has joined #openstack-oslo | 13:33 | |
| *** samueldmq has joined #openstack-oslo | 13:34 | |
| *** zz_dimtruck is now known as dimtruck | 13:34 | |
| *** dimtruck is now known as zz_dimtruck | 13:38 | |
| *** manishg has joined #openstack-oslo | 13:43 | |
| *** shardy_ has joined #openstack-oslo | 13:44 | |
| *** mriedem has joined #openstack-oslo | 13:44 | |
| *** shardy has quit IRC | 13:44 | |
| *** prad has joined #openstack-oslo | 13:46 | |
| *** manishg has quit IRC | 13:48 | |
| *** yamahata has joined #openstack-oslo | 13:48 | |
| *** shardy_ has quit IRC | 13:49 | |
| *** shardy has joined #openstack-oslo | 13:50 | |
| dhellmann | haypo: I am trying to keep an eye on when those patches merge, to make sure I'm at at least around for them. | 13:53 |
| dhellmann | dims_: how are we looking with the mock issues in the gate this morning? | 13:53 |
| haypo | dhellmann: for //review.openstack.org/#/c/181984/ i wrote that all dependencies are merged | 13:54 |
| haypo | dhellmann: but i didn't check if other projects are still using olso.utils, i only read your commit message and followed links :) | 13:54 |
| *** shardy_ has joined #openstack-oslo | 13:54 | |
| dhellmann | haypo: I keep thinking the same thing, and projects keep introducing regressions. I should have gone with ihrachyshka's suggestion and added a hacking check (I'm starting to do that now as I find regressions) | 13:55 |
| dims_ | dhellmann: one issue left - we need to merge one of yours https://review.openstack.org/#/c/200518/ but py34 is failing | 13:55 |
| dhellmann | haypo: right, I'm actually running all of the tests myself before I remove the WIP flag | 13:55 |
| dhellmann | dims_: ack, I'll look at it | 13:55 |
| *** superdan is now known as dansmith | 13:55 | |
| dims_ | dhellmann: thanks for the help over the weekend, i was able to get almost all of the things sorted | 13:56 |
| *** shardy has quit IRC | 13:56 | |
| dhellmann | dims_: great! I figured doing a little over the weekend would be (a) faster and (b) help folks for monday | 13:56 |
| ihrachyshka | dhellmann, I am happy to see I'm right but am upset I was not tough enough | 13:57 |
| dims_ | dhellmann: y, especially since the gate is relatively less busy :) | 13:57 |
| dhellmann | ihrachyshka: I've learned my lesson :-) | 13:57 |
| ihrachyshka | openstack is too huge a thing to police such changes with good will of reviewers | 13:58 |
| dims_ | :) | 13:58 |
| dhellmann | ihrachyshka: yes, and I was too slow to get my changes merged | 13:58 |
| ihrachyshka | dhellmann, I've made attempt before to get it as part of global hacking instead of per project. that said, neutron still maintains rules in its local hacking rules | 13:58 |
| *** shakamunyi has joined #openstack-oslo | 13:59 | |
| *** barra204 has joined #openstack-oslo | 13:59 | |
| ihrachyshka | I don't remember details, but I think I just dropped the ball of getting it in hacking | 13:59 |
| ihrachyshka | it seemed no one cared enough, and I was lazy | 13:59 |
| *** shardy_ has quit IRC | 14:00 | |
| *** haypo has quit IRC | 14:00 | |
| dhellmann | ihrachyshka: I stole your neutron code for mistral this weekend https://review.openstack.org/#/c/200845/ | 14:00 |
| *** shardy has joined #openstack-oslo | 14:01 | |
| ihrachyshka | dhellmann, I don't see my code there though | 14:01 |
| ihrachyshka | git add missed? | 14:01 |
| *** haypo has joined #openstack-oslo | 14:01 | |
| dhellmann | ihrachyshka: oh, hrm | 14:02 |
| dhellmann | ihrachyshka: you're right -- I hadn't noticed the failed jobs yet | 14:02 |
| *** mtanino has joined #openstack-oslo | 14:03 | |
| *** shardy_ has joined #openstack-oslo | 14:06 | |
| *** shardy has quit IRC | 14:07 | |
| *** zz_dimtruck is now known as dimtruck | 14:08 | |
| *** jecarey has joined #openstack-oslo | 14:08 | |
| dims_ | dansmith: please peek at a couple of o.vo reviews when you get a chance - https://review.openstack.org/#/q/status:open+project:openstack/oslo.versionedobjects+label:Code-Review%252B2,n,z | 14:08 |
| dansmith | dims_: oh, I hadn't noticed the replacement for the revert was up | 14:09 |
| *** browne1 has joined #openstack-oslo | 14:11 | |
| *** browne has quit IRC | 14:11 | |
| *** shardy_ has quit IRC | 14:11 | |
| *** shardy has joined #openstack-oslo | 14:11 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:14 | |
| *** achanda has quit IRC | 14:18 | |
| dansmith | ativelkov: around? | 14:18 |
| ativelkov | dansmith: yup | 14:18 |
| dansmith | https://review.openstack.org/#/c/197688/4 | 14:19 |
| dansmith | on that ^, I never dug deep into the bug to determine what the problem is.. can you explain it real quick? | 14:20 |
| openstackgerrit | Elena Ezhova proposed openstack/oslo.service: Add Bandit to tox for security static analysis https://review.openstack.org/201120 | 14:20 |
| ativelkov | dansmith: the problem was that I've added kind of proxies for lists, dicts and sets to coerce the values, and they had custom initializers expecting parameters | 14:21 |
| dansmith | and that's why you moved out the "enable" to a separate method? | 14:22 |
| ativelkov | dansmith: yup | 14:23 |
| ativelkov | otherwise this methods __init__'s could not be properly called by deepcopy | 14:24 |
| ativelkov | and then I found some more issues with deepcopying and pickle/unpickle | 14:24 |
| *** barra204 has quit IRC | 14:25 | |
| ativelkov | (some of them in that patch, some - in the subsequent patches of this series) | 14:25 |
| *** whydidyoustealmy has joined #openstack-oslo | 14:25 | |
| *** shakamunyi has quit IRC | 14:25 | |
| *** elarson has joined #openstack-oslo | 14:25 | |
| *** shakamunyi has joined #openstack-oslo | 14:26 | |
| dansmith | ativelkov: okay, the thing that seems like undesirable here is that you've got validation happening of the initial elements in coerce() and then new/later elements get checked in the mixin | 14:26 |
| dansmith | which I guess is how it was before, I just didn't really think/notice | 14:26 |
| dansmith | ativelkov: I wonder if it would be better to just initialize an empty list, enable coercing and then add the initial elements to it so that we get all the coercing in one place? | 14:27 |
| ativelkov | dansmith: I see. Before it was going that right, as it was part of the constructor. Yes, I can do it this way | 14:27 |
| dansmith | ativelkov: okay sorry to delay further, but I think that'd be better | 14:28 |
| dansmith | ativelkov: also, do we need disable_coercing? seems like that's just asking for trouble, where people think "oh, I'll just disable coercing so I can put a thing in the list" :) | 14:28 |
| ativelkov | dansmith: no problem, will update that today | 14:28 |
| dansmith | ativelkov: cool, thanks a lot | 14:28 |
| dansmith | ativelkov: please ping me when it's up so I don't miss it for so long again | 14:29 |
| ativelkov | dansmith: I'll double check: the disabling may be needed to prevent recursive calls during pickling/deep copying | 14:29 |
| dansmith | ativelkov: okay, I didn't see that it was used anywhere, but maybe I missed it | 14:29 |
| dansmith | ativelkov: perhaps making it privateish (_disable_coercing) or put a comment on it that it's only for internal use or something? | 14:30 |
| ativelkov | dansmith: yup, I'll recheck that | 14:30 |
| dansmith | excellent, thanks for your work on this! | 14:31 |
| *** zzzeek has joined #openstack-oslo | 14:31 | |
| *** whydidyoustealmy has quit IRC | 14:34 | |
| *** shakamunyi has quit IRC | 14:34 | |
| *** stevemar has joined #openstack-oslo | 14:36 | |
| ativelkov | dansmith: BTW, I found one weird thing.. do you know why nova uses fields from oslo.vo but puts them into their own base classes instead of oslo's base.VersionedObject? | 14:38 |
| dansmith | ativelkov: yes, because I haven't finished transitioning nova to use o.vo :) | 14:38 |
| dansmith | ativelkov: I've been chipping away at that problem, just not fully there yet | 14:38 |
| ativelkov | dansmith: ah, I see :) So, I have to put workarounds for that, see line 74 at https://review.openstack.org/#/c/196819/4/oslo_versionedobjects/base.py | 14:39 |
| *** zzzeek has quit IRC | 14:40 | |
| dansmith | ativelkov: ah, yeah, so the way we've been handling that is just to add things to nova first, then move to o.vo, but that's because everything has been going into nova anyway | 14:40 |
| dansmith | ativelkov: maybe I can make some more progress on that so we don't have to have that shortcut in there | 14:41 |
| ativelkov | dansmith: great. That patch is in progress anyway (needs some more built-in validators and tests on them), so it can wait | 14:42 |
| dansmith | okay cool | 14:42 |
| *** browne has joined #openstack-oslo | 14:42 | |
| *** tsekiyama has joined #openstack-oslo | 14:44 | |
| *** browne1 has quit IRC | 14:45 | |
| *** zzzeek has joined #openstack-oslo | 14:45 | |
| dhellmann | dims_: it looks like this thing in oslo.log is a change in behavior between python 2 and 3 | 14:45 |
| dims_ | right | 14:45 |
| dhellmann | the subclass check isn't being called the same way somehow | 14:46 |
| *** nkrinner is now known as nkrinner_afk | 14:48 | |
| openstackgerrit | Elena Ezhova proposed openstack/oslo.service: Add Bandit to tox for security static analysis https://review.openstack.org/201120 | 14:49 |
| *** vikash_ has joined #openstack-oslo | 14:52 | |
| vikash_ | if i am not wrong fanout cast is like a broadcast message to all exchanges, am i correct??? | 14:53 |
| *** alexpilotti has quit IRC | 14:54 | |
| *** alexpilotti has joined #openstack-oslo | 14:55 | |
| *** alexpilotti has quit IRC | 14:56 | |
| openstackgerrit | Alexander Tivelkov proposed openstack/oslo.versionedobjects: Compound fields now coerce their elements' values https://review.openstack.org/197688 | 14:57 |
| openstackgerrit | Alexander Tivelkov proposed openstack/oslo.versionedobjects: Adds value validation to the fields https://review.openstack.org/196041 | 14:57 |
| openstackgerrit | Alexander Tivelkov proposed openstack/oslo.versionedobjects: Compound Field validation (WiP) https://review.openstack.org/196819 | 14:57 |
| ihrachyshka | dansmith, hi. a question on ovo | 14:57 |
| *** alexpilotti has joined #openstack-oslo | 14:57 | |
| dansmith | ihrachyshka: okay, just about to jump on a call, but shoot | 14:58 |
| ihrachyshka | dansmith, we have QosRule that is a super class for QosBandwidthLimitRule. Now, I add some ListOfObjectFields in QosRule, and implement obj_load_attr to handle that. but then when I access the attr for subclass object, I get AttributeError | 14:58 |
| ihrachyshka | eh, sorry, that was wrong | 14:59 |
| ihrachyshka | it's easier. we just have QosPolicy class with ListofObject fields, and we reimplement obj_load_attr | 14:59 |
| *** alexpilotti has quit IRC | 14:59 | |
| ihrachyshka | and it's not triggered with . attr access | 14:59 |
| * ihrachyshka needs some coffee now that he started to mumble nonsense | 15:00 | |
| vikash_ | guys , can somebody point to topic fanout ??? | 15:00 |
| ativelkov | ihrachyshka: do you register both classes in VersionedObjectRegistry? | 15:00 |
| dansmith | ihrachyshka: yeah, that ^ :) | 15:00 |
| ihrachyshka | now, maybe that's somehow related to how we populate fields for the class... https://review.openstack.org/#/c/200608/1/neutron/objects/qos/policy.py line 48 | 15:00 |
| ihrachyshka | ativelkov, nah, I was talking nonsense, it was just QosPolicy with no subclasses. | 15:01 |
| *** alexpilotti has joined #openstack-oslo | 15:01 | |
| ihrachyshka | (don't check get_by_id impl there, it's wrong, I now switch to obj_load_attr) | 15:02 |
| ihrachyshka | oh, shi* I see the issue | 15:02 |
| ihrachyshka | a typo in the code. sorry gues. | 15:02 |
| ihrachyshka | *guys | 15:02 |
| ihrachyshka | I create %rule_types but access %rule_rules | 15:03 |
| ihrachyshka | meh | 15:03 |
| *** alexpilotti has quit IRC | 15:03 | |
| *** exploreshaifali has quit IRC | 15:03 | |
| ativelkov | dansmith: I've updated the patches | 15:03 |
| dansmith | ativelkov: okay, I just jumped on a call, but I'll leave a tab open to look | 15:04 |
| ativelkov | dansmith: thanks | 15:04 |
| *** alexpilotti has joined #openstack-oslo | 15:05 | |
| vikash_ | guys , can somebody point to topic fanout ??? | 15:06 |
| *** manishg has joined #openstack-oslo | 15:07 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.log: Do not report deprecations in subclasses https://review.openstack.org/200518 | 15:07 |
| vikash_ | is that a topic based fanout | 15:07 |
| vikash_ | ??? | 15:07 |
| vikash_ | or its just a fanout | 15:07 |
| vikash_ | ??? | 15:07 |
| dhellmann | haypo: I could use some python internals help with ^^ -- it looks like the way the subclass check is done for catching exceptions on python 2 and 3 is different | 15:08 |
| ihrachyshka | ajo, for presentations, we need to take a call on what's the plan there quickly. it's wed that is the last day for applications | 15:11 |
| *** alexpilotti has quit IRC | 15:11 | |
| vikash_ | dhellmann, the neutron rpc with fanout enable is topic fanout exchange or rather a simple fanout exchange | 15:11 |
| vikash_ | ? | 15:11 |
| ihrachyshka | ouch, wrong channel | 15:11 |
| dhellmann | vikash_: I'm not sure what you asking? | 15:11 |
| ajo | ihrachyshka, lpeer is handling it | 15:12 |
| ajo | she will register it | 15:12 |
| ihrachyshka | ajo, ack. but yeah, wrong channel | 15:12 |
| vikash_ | dhellmann, so neutron uses rpc.RPCProxy which internally uses oslo lib and which uses amqp driver to publish message based on topic | 15:13 |
| ajo | ihrachyshka: lol :) | 15:13 |
| dhellmann | vikash_: ok | 15:13 |
| vikash_ | dhellmann, so if a rpc cast is done with fanout = true, then is that a topic based fanout exchange or it jush fanouts to all the queus bind on exchange | 15:13 |
| vikash_ | ??? | 15:13 |
| *** sputnik13 has joined #openstack-oslo | 15:14 | |
| dhellmann | vikash_: I think everything is topic-based | 15:14 |
| ihrachyshka | topic of course | 15:14 |
| vikash_ | dhellmann, so that means its a topic based fanout??? | 15:14 |
| dhellmann | vikash_: what is it you're trying to do? | 15:15 |
| dhellmann | vikash_: I think that using topics is the only thing that would make sense there | 15:15 |
| dhellmann | vikash_: are you seeing an issue? because you're asking questions about the implementation of the library that shouldn't matter to an application developer, so I'm trying to understand what the real issue is. | 15:15 |
| *** jaosorior has quit IRC | 15:16 | |
| vikash_ | dhellmann, oh just trying to understand the difference between cast and fanout cast for eg https://github.com/openstack/neutron-fwaas/blob/stable/juno/neutron/services/firewall/fwaas_plugin.py#L109 | 15:18 |
| *** harlowja_at_home has joined #openstack-oslo | 15:19 | |
| *** sputnik13 has quit IRC | 15:20 | |
| dhellmann | vikash_: I'm not sure. It looks like the neutron code has changed quite a bit since juno. | 15:21 |
| vikash_ | dhellmann, ok | 15:21 |
| vikash_ | dhellmann, thnx | 15:21 |
| dhellmann | dims_: ok, I think this is an optimization in the issubclass() implementation in python 3, and that the feature just isn't going to work under python 3 | 15:24 |
| dhellmann | dims_: the __subclasscheck__ method of the metaclass is only called if nothing in the MRO for a class is found to match with a pointer test | 15:25 |
| dhellmann | dims_: there's no hook for us to use to notice that someone is catching a deprecated exception | 15:25 |
| dims_ | dhellmann: so disable the test for now? then look for a way around or document that it will not work? | 15:27 |
| dhellmann | dims_: yeah, I think so. I'm going to poke at one more thing first | 15:28 |
| dims_ | thanks dhellmann | 15:28 |
| *** ihrachyshka has quit IRC | 15:28 | |
| *** rlrossit has joined #openstack-oslo | 15:32 | |
| harlowja_at_home | u guys trying to see if people are using deprecated exceptions? | 15:35 |
| * harlowja_at_home remebers trying to get that to work, and didn't have much luck :-/ | 15:35 | |
| *** manishg has quit IRC | 15:36 | |
| *** jamespage has quit IRC | 15:36 | |
| *** miguelgrinberg has quit IRC | 15:36 | |
| *** coreywright has quit IRC | 15:36 | |
| *** kragniz has quit IRC | 15:36 | |
| *** ujjain has quit IRC | 15:36 | |
| *** cburgess has quit IRC | 15:36 | |
| *** pasquier-s has quit IRC | 15:36 | |
| *** xek has quit IRC | 15:36 | |
| *** tristanC has quit IRC | 15:36 | |
| *** SlickNik has quit IRC | 15:36 | |
| *** DuncanT has quit IRC | 15:36 | |
| *** frickler has quit IRC | 15:36 | |
| *** kragniz has joined #openstack-oslo | 15:37 | |
| *** frickler has joined #openstack-oslo | 15:37 | |
| *** manishg has joined #openstack-oslo | 15:37 | |
| *** tristanC has joined #openstack-oslo | 15:37 | |
| *** coreywright has joined #openstack-oslo | 15:37 | |
| *** xek has joined #openstack-oslo | 15:37 | |
| *** cburgess has joined #openstack-oslo | 15:37 | |
| *** miguelgrinberg_ has joined #openstack-oslo | 15:37 | |
| *** jamespage has joined #openstack-oslo | 15:37 | |
| *** jamespage has quit IRC | 15:37 | |
| *** jamespage has joined #openstack-oslo | 15:37 | |
| *** SlickNik has joined #openstack-oslo | 15:37 | |
| *** pcaruana has quit IRC | 15:38 | |
| *** ujjain has joined #openstack-oslo | 15:38 | |
| *** ujjain has quit IRC | 15:38 | |
| *** ujjain has joined #openstack-oslo | 15:38 | |
| *** pasquier-s has joined #openstack-oslo | 15:38 | |
| dhellmann | harlowja_at_home: yeah, https://review.openstack.org/#/c/200518/ | 15:38 |
| dhellmann | harlowja_at_home: the tests for that were broken because of misusing mock, so it looked like it worked when it didn't | 15:39 |
| *** arnaud___ has joined #openstack-oslo | 15:40 | |
| harlowja_at_home | intersting, ya '__subclasscheck__' and me fought for a while from what i remember | 15:40 |
| harlowja_at_home | it'd be nice to have a hook that python would call when seeing if a exception class matches a desired one, __isexceptionmatch__ or something | 15:42 |
| harlowja_at_home | i didn't think it made it possible to do that | 15:42 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Create and use a serial retry executor https://review.openstack.org/195784 | 15:44 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Cache atom name -> actions and provide accessor function https://review.openstack.org/198211 | 15:45 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Separate revert/execute failure into different outcome constants https://review.openstack.org/199848 | 15:45 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Give the GC more of a break with regard to cycles https://review.openstack.org/200370 | 15:45 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.log: Do not report deprecations in subclasses https://review.openstack.org/200518 | 15:45 |
| dims_ | dhellmann: typo "Pythyon 3" | 15:46 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.log: Do not report deprecations in subclasses https://review.openstack.org/200518 | 15:46 |
| dhellmann | dims_: fixed, thanks | 15:47 |
| *** manishg has quit IRC | 15:48 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.log: Do not report deprecations in subclasses https://review.openstack.org/200518 | 15:49 |
| dhellmann | dims_: one more draft, then I'm done | 15:49 |
| dims_ | dhellmann: cool | 15:50 |
| *** morganfainberg has quit IRC | 15:51 | |
| *** manishg has joined #openstack-oslo | 15:51 | |
| *** morganfainberg has joined #openstack-oslo | 15:52 | |
| *** pblaho has quit IRC | 15:55 | |
| *** DuncanT has joined #openstack-oslo | 15:57 | |
| *** ihrachyshka has joined #openstack-oslo | 15:57 | |
| dims_ | 2 mins to meeting time | 15:59 |
| *** ozamiatin has quit IRC | 16:00 | |
| *** rpodolyaka1 has joined #openstack-oslo | 16:00 | |
| *** ozamiatin has joined #openstack-oslo | 16:00 | |
| *** sputnik13 has joined #openstack-oslo | 16:01 | |
| *** yamahata has quit IRC | 16:04 | |
| *** yamahata has joined #openstack-oslo | 16:05 | |
| openstackgerrit | Alexander Tivelkov proposed openstack/oslo.versionedobjects: Compound fields now coerce their elements' values https://review.openstack.org/197688 | 16:08 |
| openstackgerrit | Alexander Tivelkov proposed openstack/oslo.versionedobjects: Adds value validation to the fields https://review.openstack.org/196041 | 16:08 |
| openstackgerrit | Alexander Tivelkov proposed openstack/oslo.versionedobjects: Compound Field validation (WiP) https://review.openstack.org/196819 | 16:08 |
| *** sdake has joined #openstack-oslo | 16:15 | |
| *** miguelgrinberg_ is now known as miguelgrinberg | 16:16 | |
| *** sputnik13 has quit IRC | 16:17 | |
| *** e0ne has quit IRC | 16:21 | |
| *** manishg has quit IRC | 16:22 | |
| *** mgarza_ has joined #openstack-oslo | 16:22 | |
| *** sputnik13 has joined #openstack-oslo | 16:22 | |
| *** manishg has joined #openstack-oslo | 16:23 | |
| *** sdake has quit IRC | 16:23 | |
| *** sdake has joined #openstack-oslo | 16:24 | |
| *** shakamunyi has joined #openstack-oslo | 16:25 | |
| *** whydidyoustealmy has joined #openstack-oslo | 16:25 | |
| *** ashleighfarnham has joined #openstack-oslo | 16:25 | |
| *** manishg_ has joined #openstack-oslo | 16:25 | |
| *** manishg has quit IRC | 16:26 | |
| *** exploreshaifali has joined #openstack-oslo | 16:28 | |
| *** sputnik13 has quit IRC | 16:30 | |
| *** achanda has joined #openstack-oslo | 16:31 | |
| *** arnaud___ has quit IRC | 16:31 | |
| *** yassine_ has quit IRC | 16:34 | |
| harlowja_at_home | bb, heading in to workland | 16:35 |
| *** harlowja_at_home has quit IRC | 16:36 | |
| *** whydidyoustealmy has quit IRC | 16:37 | |
| *** shakamunyi has quit IRC | 16:37 | |
| *** ozamiatin has quit IRC | 16:43 | |
| openstackgerrit | Merged openstack/oslo.cache: Region handling https://review.openstack.org/199793 | 16:43 |
| openstackgerrit | Merged openstack/oslo.cache: Don't register backends on import https://review.openstack.org/199797 | 16:44 |
| *** sputnik13 has joined #openstack-oslo | 16:45 | |
| dansmith | ativelkov: dims_: IIRC, the issue with o.vo that we reverted was manifesting in nova py27 tests, right? | 16:50 |
| ativelkov | dansmith: yes | 16:50 |
| dansmith | okay, I'm going to pull this down and try it against nova unit tests before I approve | 16:50 |
| ativelkov | and something in cinder as well | 16:50 |
| *** shakamunyi has joined #openstack-oslo | 16:51 | |
| *** whydidyoustealmy has joined #openstack-oslo | 16:51 | |
| *** alexpilotti has joined #openstack-oslo | 16:51 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Remove oslo namespace package https://review.openstack.org/181984 | 16:52 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Add oslo.config to venv environment https://review.openstack.org/201252 | 16:52 |
| *** rjaiswal has joined #openstack-oslo | 16:54 | |
| dims_ | dansmith: ack. | 16:54 |
| dims_ | ativelkov: awesome thanks | 16:54 |
| *** rpodolyaka1 has quit IRC | 17:00 | |
| *** alexpilotti has quit IRC | 17:02 | |
| *** alexpilotti has joined #openstack-oslo | 17:08 | |
| *** shakamunyi has quit IRC | 17:09 | |
| *** whydidyoustealmy has quit IRC | 17:09 | |
| *** ihrachyshka has quit IRC | 17:09 | |
| *** shakamunyi has joined #openstack-oslo | 17:09 | |
| openstackgerrit | Elena Ezhova proposed openstack/oslo.service: Add usage documentation for oslo_service.service module https://review.openstack.org/201255 | 17:10 |
| *** browne has quit IRC | 17:18 | |
| *** manishg_ has quit IRC | 17:19 | |
| *** manishg has joined #openstack-oslo | 17:19 | |
| *** manishg has quit IRC | 17:20 | |
| *** manishg has joined #openstack-oslo | 17:21 | |
| dansmith | dims_: think this is useful enough to capture somewhere? http://pastebin.com/2g9QsvbV | 17:24 |
| dims_ | dansmith: we can add it here i think - http://git.openstack.org/cgit/openstack/oslotest/tree/tools | 17:31 |
| dansmith | okay | 17:32 |
| dims_ | dansmith: i have been using this trick - https://github.com/dims/nova/blob/master/requirements.txt#L39 | 17:33 |
| dims_ | "-e git+https://" | 17:34 |
| dansmith | yeah | 17:34 |
| dansmith | I figured that wasn't as safe, | 17:34 |
| dansmith | as if something below that in the list requires a specific version I think pip will use that, right? | 17:34 |
| dansmith | maybe not in this case, I dunno | 17:34 |
| *** manishg has quit IRC | 17:35 | |
| dansmith | dims_: ah, looks like oslo_run_cross_tests does this | 17:35 |
| *** manishg has joined #openstack-oslo | 17:36 | |
| dims_ | y closest to what you were trying to do | 17:36 |
| dansmith | so... why do we hit things like broken nova unit tests because of an oslo release? | 17:36 |
| *** manishg has quit IRC | 17:37 | |
| *** alexpilotti has quit IRC | 17:37 | |
| openstackgerrit | Boris Bobrov proposed openstack/oslo.db: Check revision after a module finished upgrading https://review.openstack.org/201265 | 17:37 |
| *** manishg has joined #openstack-oslo | 17:37 | |
| *** crc32 has joined #openstack-oslo | 17:38 | |
| *** vikash_ has quit IRC | 17:40 | |
| dims_ | dansmith: in tox.ini (nova), see this in [testenv] | 17:41 |
| dims_ | install_command = pip install -U --force-reinstall {opts} {packages} | 17:41 |
| dims_ | that breaks the -e git+https:// as it somehow reinstalls the version that is in system python (not venv) | 17:41 |
| dansmith | ah | 17:42 |
| dansmith | that breaks your trick | 17:42 |
| dansmith | but not mine, I think | 17:42 |
| dims_ | right | 17:42 |
| dims_ | yes | 17:42 |
| dims_ | dansmith: so in my github repo, i removed that line from tox.ini and used the git+https and run it on travis CI periodically now - https://travis-ci.org/dims/nova - that's the learning from the last o.vo failures :) | 17:43 |
| dansmith | ah | 17:44 |
| *** alexpilotti has joined #openstack-oslo | 17:45 | |
| *** yamahata has quit IRC | 17:45 | |
| dims_ | harlowja_: futurist merges done? | 17:46 |
| * harlowja_ checking | 17:46 | |
| harlowja_ | dims_ nope, still seems in the queue | 17:47 |
| harlowja_ | waiting for whatever happens there | 17:47 |
| harlowja_ | *in queueland | 17:47 |
| *** alexpilotti has quit IRC | 17:54 | |
| *** manishg has quit IRC | 17:57 | |
| *** manishg has joined #openstack-oslo | 17:58 | |
| *** browne has joined #openstack-oslo | 17:59 | |
| *** abitha has joined #openstack-oslo | 18:01 | |
| *** rpodolyaka1 has joined #openstack-oslo | 18:16 | |
| *** ashleighfarnham has quit IRC | 18:18 | |
| *** ashleighfarnham has joined #openstack-oslo | 18:24 | |
| *** jaosorior has joined #openstack-oslo | 18:27 | |
| *** miguelgrinberg has quit IRC | 18:28 | |
| *** miguelgrinberg has joined #openstack-oslo | 18:29 | |
| *** miguelgrinberg has quit IRC | 18:29 | |
| *** miguelgrinberg has joined #openstack-oslo | 18:30 | |
| *** shakamunyi has quit IRC | 18:36 | |
| *** rpodolyaka1 has quit IRC | 18:38 | |
| *** sdake has quit IRC | 18:41 | |
| *** yamahata has joined #openstack-oslo | 18:42 | |
| *** sdake has joined #openstack-oslo | 18:44 | |
| *** shakamunyi has joined #openstack-oslo | 18:47 | |
| *** rpodolyaka1 has joined #openstack-oslo | 18:54 | |
| *** ekarlso has quit IRC | 18:56 | |
| *** ekarlso has joined #openstack-oslo | 18:58 | |
| *** e0ne has joined #openstack-oslo | 19:03 | |
| *** e0ne is now known as e0ne_ | 19:08 | |
| openstackgerrit | Michael Krotscheck proposed openstack/oslo.middleware: Added verbose debug logging to CORS https://review.openstack.org/200715 | 19:09 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove usage of taskflow.utils in examples https://review.openstack.org/201301 | 19:20 |
| *** ihrachyshka has joined #openstack-oslo | 19:21 | |
| *** e0ne_ is now known as e0ne | 19:22 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove usage **most** of taskflow.utils in examples https://review.openstack.org/201301 | 19:23 |
| *** manishg has quit IRC | 19:24 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove **most** usage of taskflow.utils in examples https://review.openstack.org/201301 | 19:24 |
| *** bnemec has joined #openstack-oslo | 19:24 | |
| *** svilgelm has joined #openstack-oslo | 19:25 | |
| svilgelm | Guys, from the requirements-core team, Could you review my patch https://review.openstack.org/#/c/199064/ I need the second +2 and merge it asap | 19:27 |
| *** manishg has joined #openstack-oslo | 19:27 | |
| *** rpodolyaka1 has quit IRC | 19:38 | |
| *** thumpba has joined #openstack-oslo | 19:42 | |
| *** ihrachyshka has quit IRC | 19:48 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove **most** usage of taskflow.utils in examples https://review.openstack.org/201301 | 19:49 |
| *** rpodolyaka1 has joined #openstack-oslo | 20:00 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.versionedobjects: Remove ununsed class in test.py https://review.openstack.org/201318 | 20:00 |
| *** manishg has quit IRC | 20:01 | |
| dims_ | harlowja_: i was scanning old bugs and saw something...net is in taskflow there's a timeutils.set_time_override(now) call, we can replace that with TimeFixture from oslo.utils i think | 20:01 |
| harlowja_ | dims_ hmmmm, thinking that bug shouldn't exist anymore | 20:02 |
| harlowja_ | which one? | 20:02 |
| harlowja_ | ah i see one usage of it | 20:02 |
| dims_ | harlowja_: was just grepping through sources (https://bugs.launchpad.net/oslo.utils/+bug/1266962) | 20:02 |
| openstack | Launchpad bug 1266962 in oslo.utils "Remove set_time_override in timeutils" [Low,In progress] - Assigned to ZhiQiang Fan (aji-zqfan) | 20:02 |
| harlowja_ | ya, i see one line for that in taskfow, hmmm | 20:02 |
| harlowja_ | will remove :-P | 20:02 |
| dims_ | not urgent at all... | 20:03 |
| harlowja_ | k | 20:03 |
| *** e0ne is now known as e0ne_ | 20:04 | |
| *** e0ne_ is now known as e0ne | 20:04 | |
| *** rpodolyaka1 has quit IRC | 20:10 | |
| *** manishg has joined #openstack-oslo | 20:10 | |
| *** manishg has quit IRC | 20:10 | |
| *** manishg has joined #openstack-oslo | 20:10 | |
| *** manishg has quit IRC | 20:20 | |
| *** lifeless has quit IRC | 20:20 | |
| *** manishg has joined #openstack-oslo | 20:20 | |
| *** lifeless has joined #openstack-oslo | 20:21 | |
| *** sputnik13 has quit IRC | 20:28 | |
| *** svilgelm has quit IRC | 20:37 | |
| *** sputnik13 has joined #openstack-oslo | 20:42 | |
| *** abitha has quit IRC | 20:44 | |
| *** manishg has quit IRC | 20:51 | |
| *** manishg has joined #openstack-oslo | 20:51 | |
| *** shardy_ has joined #openstack-oslo | 21:04 | |
| *** shardy has quit IRC | 21:05 | |
| *** shardy_ has quit IRC | 21:09 | |
| *** shardy has joined #openstack-oslo | 21:10 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.messaging: Remove oslo namespace package https://review.openstack.org/181974 | 21:12 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.messaging: Drop use of 'oslo' namespace package https://review.openstack.org/201342 | 21:12 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.i18n: Updated from global requirements https://review.openstack.org/201343 | 21:13 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.versionedobjects: Updated from global requirements https://review.openstack.org/201344 | 21:13 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove direct usage of timeutils overrides and use fixture https://review.openstack.org/201346 | 21:16 |
| harlowja_ | dims_ ^ | 21:16 |
| *** rlrossit has left #openstack-oslo | 21:16 | |
| *** _cjones_ has joined #openstack-oslo | 21:27 | |
| _cjones_ | Hi I'm running into a few py27 errors with stable/kilo branch. Anyone know the cause of these: | 21:29 |
| _cjones_ | https://gist.github.com/badgerj/770c6146eec0966cf458 | 21:29 |
| *** gordc has quit IRC | 21:30 | |
| *** mriedem is now known as mriedem_away | 21:31 | |
| *** dims___ has joined #openstack-oslo | 21:34 | |
| *** e0ne has quit IRC | 21:35 | |
| *** dims_ has quit IRC | 21:35 | |
| *** manishg has quit IRC | 21:37 | |
| *** manishg has joined #openstack-oslo | 21:37 | |
| *** thumpba has quit IRC | 21:38 | |
| jecarey | _cjones_, possibly you're hitting https://bugs.launchpad.net/tempest/+bug/1469825 | 21:39 |
| openstack | Launchpad bug 1469825 in Rally "return self._cleanups(raise_errors=raise_first) TypeError with fixtures 1.3.0 released on 6/29" [Undecided,Fix committed] | 21:39 |
| _cjones_ | jecarey: So the policy here: https://bugs.launchpad.net/tempest/+bug/1470648 would be to cap our local use of fixtures < 1.3.0? | 21:44 |
| openstack | Launchpad bug 1469825 in Rally "duplicate for #1470648 return self._cleanups(raise_errors=raise_first) TypeError with fixtures 1.3.0 released on 6/29" [Undecided,Fix committed] | 21:44 |
| bknudson | are we not supposed to use fatal_deprecations anymore? | 21:46 |
| bknudson | oh, wait no. | 21:46 |
| bknudson | I thought the comment was saying it was deprecated | 21:46 |
| *** exploreshaifali has quit IRC | 22:01 | |
| dhellmann | harlowja_, haypo, sileht, jd__, dims___: it would be great if we could get https://review.openstack.org/#/c/201342/ merged and released tomorrow | 22:05 |
| harlowja_ | cool | 22:06 |
| harlowja_ | looks ok to me | 22:06 |
| _cjones_ | jecarey: I tried pining fixtures fixtures>=0.3.14,<1.3.0 in test-requirements.txt, but I still get the same errors. Odd, because it seems very similar. | 22:06 |
| dhellmann | _cjones_: a recent version of fixtures had a behavior change that makes it fail in that way when a fixture is cleaned up twice. We fixed that in master, but didn't backport the change. What project are you working on? | 22:08 |
| _cjones_ | dhellmann: All of them really. Just trying to get our past juno code merged into kilo and getting our CI tests passing. | 22:09 |
| dhellmann | _cjones_: you have some customizations you're carrying? | 22:09 |
| _cjones_ | dhellman: Correct. | 22:09 |
| *** browne has quit IRC | 22:10 | |
| _cjones_ | I have no problem globally pining fixtures<1.3.0 to fix the issue across the board: or cherry-picking the fixes across multiple projects. But I'm surprised the pin didn't work and I still get the same results. | 22:11 |
| dhellmann | _cjones_: I'm testing locally, give me a sec to try to reproduce it | 22:12 |
| _cjones_ | dhellmann: Thanks. It could be an issue with our CI setup, but since this is run in a venv, I can't see how that could be. | 22:13 |
| *** shardy has quit IRC | 22:14 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add ability to use tooz to find and advertise workers https://review.openstack.org/151495 | 22:15 |
| dhellmann | _cjones_: capping fixtures worked for me. How did you apply the cap? | 22:15 |
| *** prad has quit IRC | 22:16 | |
| _cjones_ | https://gist.github.com/badgerj/228acf6f137134d06e0c | 22:17 |
| _cjones_ | https://gist.github.com/badgerj/033782ae539b19ba223e | 22:17 |
| _cjones_ | fixture==1.2.0 | 22:18 |
| dhellmann | _cjones_: hmm | 22:18 |
| dhellmann | _cjones_: here's a cap in stable/kilo: https://review.openstack.org/201354 | 22:18 |
| _cjones_ | dhellmann: Thanks! | 22:18 |
| _cjones_ | I was going to do it globally, but wanted to test on one project first. I'll give this a shot. | 22:19 |
| dhellmann | yeah, it worked in my local clean checkout | 22:19 |
| dhellmann | I wonder if you have something else going on in your virtualenv | 22:19 |
| *** alexpilotti has joined #openstack-oslo | 22:20 | |
| _cjones_ | That's what I was trying to figure out because I'll still have to debug that bit later. | 22:20 |
| dhellmann | _cjones_: here's what I did in my oslo.config: http://paste.openstack.org/show/372468 | 22:20 |
| *** bknudson has quit IRC | 22:23 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.config: Remove oslo namespace package https://review.openstack.org/181961 | 22:23 |
| _cjones_ | Right. The mock issue! That seems to have fixed it. Now only getting one error (unrelated to the first ones): | 22:24 |
| _cjones_ | ====================================================================== | 22:24 |
| _cjones_ | FAIL: unittest2.loader._FailedTest.tests.test_generator | 22:24 |
| _cjones_ | tags: worker-0 | 22:24 |
| _cjones_ | ---------------------------------------------------------------------- | 22:24 |
| _cjones_ | Traceback (most recent call last): | 22:24 |
| _cjones_ | ImportError: Failed to import test module: tests.test_generator | 22:24 |
| _cjones_ | Traceback (most recent call last): | 22:24 |
| _cjones_ | File "/opt/jenkins/workspace/template-nightly-topics-kilo_merge-oslo.config-py27/dut/.tox/py27/local/lib/python2.7/site-packages/unittest2/loader.py", line 456, in _find_test_path | 22:24 |
| _cjones_ | module = self._get_module_from_name(name) | 22:24 |
| _cjones_ | File "/opt/jenkins/workspace/template-nightly-topics-kilo_merge-oslo.config-py27/dut/.tox/py27/local/lib/python2.7/site-packages/unittest2/loader.py", line 395, in _get_module_from_name | 22:24 |
| _cjones_ | __import__(name) | 22:25 |
| _cjones_ | File "tests/test_generator.py", line 26, in <module> | 22:25 |
| _cjones_ | from oslo.i18n import fixture as i18n_fixture | 22:25 |
| _cjones_ | ImportError: No module named i18n | 22:25 |
| _cjones_ | Ran 1122 tests in 2.804s (+0.076s) | 22:25 |
| _cjones_ | FAILED (id=8, failures=1) | 22:25 |
| _cjones_ | error: testr failed (1) | 22:25 |
| _cjones_ | Oops. Sorry. Meant to gist that dhellman | 22:25 |
| _cjones_ | Oops. Sorry. Meant to gist that dhellmann | 22:25 |
| dhellmann | _cjones_: your oslo.i18n is too new, you'll probably have to cap that, too | 22:25 |
| _cjones_ | Thanks so much for the assistance dhellmann. I should have a bunch of stuff fixed today. | 22:26 |
| dhellmann | _cjones_: try <2.0.0 | 22:26 |
| jecarey | dhellmann, its capped in test-requirements.txt but not in requirements.txt | 22:26 |
| dhellmann | _cjones_: actually, kilo has oslo.i18n>=1.5.0,<1.6.0 | 22:26 |
| _cjones_ | dhellmann: Yup. Just saw that. | 22:27 |
| dhellmann | _cjones_: time for me to sign off, but I think you should be good to go now | 22:28 |
| *** bnemec has quit IRC | 22:28 | |
| *** dims_ has joined #openstack-oslo | 22:32 | |
| *** dims___ has quit IRC | 22:35 | |
| *** manishg has quit IRC | 22:36 | |
| *** manishg has joined #openstack-oslo | 22:37 | |
| *** shakamunyi has quit IRC | 22:45 | |
| *** dims__ has joined #openstack-oslo | 22:46 | |
| openstackgerrit | Merged openstack/oslo.versionedobjects: Compound fields now coerce their elements' values https://review.openstack.org/197688 | 22:46 |
| *** manishg has quit IRC | 22:47 | |
| *** sdake has quit IRC | 22:48 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Replace internal fsm + table with automaton library https://review.openstack.org/139784 | 22:49 |
| *** dims_ has quit IRC | 22:49 | |
| *** stevemar has quit IRC | 22:50 | |
| *** stevemar has joined #openstack-oslo | 22:51 | |
| *** jecarey has quit IRC | 22:55 | |
| *** stevemar has quit IRC | 22:56 | |
| *** dims__ has quit IRC | 22:56 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:57 | |
| *** sdake has joined #openstack-oslo | 22:57 | |
| *** browne has joined #openstack-oslo | 22:58 | |
| *** sdake_ has joined #openstack-oslo | 23:00 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add deprecated module for prior FSM code-base https://review.openstack.org/201364 | 23:02 |
| *** ashleighfarnham has quit IRC | 23:04 | |
| *** sdake has quit IRC | 23:04 | |
| *** sputnik13 has quit IRC | 23:07 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add deprecated module(s) for prior FSM/table code-base https://review.openstack.org/201364 | 23:07 |
| *** mgarza_ has quit IRC | 23:12 | |
| *** ganso_ has quit IRC | 23:18 | |
| *** mdbooth has quit IRC | 23:19 | |
| *** dimtruck is now known as zz_dimtruck | 23:20 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo.versionedobjects: Replace 'hypervisor' with 'provided' version https://review.openstack.org/201367 | 23:20 |
| *** mdbooth has joined #openstack-oslo | 23:25 | |
| *** achanda has quit IRC | 23:31 | |
| *** achanda has joined #openstack-oslo | 23:32 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Use the warn_eventlet_not_patched util function https://review.openstack.org/201370 | 23:33 |
| *** rjaiswal has quit IRC | 23:34 | |
| *** achanda has quit IRC | 23:36 | |
| *** sdake has joined #openstack-oslo | 23:37 | |
| *** sdake_ has quit IRC | 23:41 | |
| *** dims_ has joined #openstack-oslo | 23:42 | |
| *** achanda has joined #openstack-oslo | 23:49 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Some executor tweaks and cleanups https://review.openstack.org/201373 | 23:50 |
| *** stevemar has joined #openstack-oslo | 23:53 | |
| *** _cjones_ has quit IRC | 23:56 | |
| *** stevemar has quit IRC | 23:57 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove **most** usage of taskflow.utils in examples https://review.openstack.org/201301 | 23:58 |
| *** manishg has joined #openstack-oslo | 23:58 | |
| *** manishg has quit IRC | 23:59 | |
| *** manishg has joined #openstack-oslo | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!