| *** mriedem has quit IRC | 00:05 | |
| *** stevemar has quit IRC | 00:10 | |
| *** stevemar has joined #openstack-oslo | 00:10 | |
| lifeless | dhellmann: https://review.openstack.org/#/c/180587/ <- would like your input there | 00:12 |
|---|---|---|
| openstackgerrit | lifeless proposed openstack/oslo-specs: Enable optional dependencies in OpenStack projects https://review.openstack.org/187830 | 00:16 |
| *** stevemar has quit IRC | 00:19 | |
| *** stevemar has joined #openstack-oslo | 00:20 | |
| *** miguelgrinberg has quit IRC | 00:26 | |
| *** jamielennox is now known as jamielennox|away | 00:26 | |
| openstackgerrit | lifeless proposed openstack/oslo.db: Refactor deps to use extras and env markers. https://review.openstack.org/184328 | 00:27 |
| openstackgerrit | lifeless proposed openstack/oslo.db: Refactor deps to use extras and env markers. https://review.openstack.org/184328 | 00:28 |
| *** jamielennox|away is now known as jamielennox | 00:30 | |
| *** eliqiao has joined #openstack-oslo | 00:31 | |
| *** eliqiao has quit IRC | 00:37 | |
| *** harlowja_at_home has joined #openstack-oslo | 00:37 | |
| *** eliqiao has joined #openstack-oslo | 00:37 | |
| *** sputnik1_ has quit IRC | 00:38 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.cache: handle utf8 encoding properly https://review.openstack.org/196477 | 00:45 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/192382 | 00:47 |
| *** harlowja_at_home has quit IRC | 00:47 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/tooz: Updated from global requirements https://review.openstack.org/194837 | 00:48 |
| *** eliqiao has quit IRC | 00:53 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo-incubator: Remove openstack/common/report as oslo.reports is graduating https://review.openstack.org/196486 | 01:00 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo-incubator: Remove openstack/common/report as oslo.reports is graduating https://review.openstack.org/196486 | 01:06 |
| openstackgerrit | Joshua Harlow proposed openstack/futurist: Ensure we check callback '_is_periodic' on add https://review.openstack.org/196457 | 01:07 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.cache: handle utf8 encoding properly https://review.openstack.org/196477 | 01:13 |
| *** miguelgrinberg has joined #openstack-oslo | 01:28 | |
| *** vilobhmm has quit IRC | 01:35 | |
| *** vilobhmm has joined #openstack-oslo | 01:49 | |
| lifeless | dhellmann: hey so my optional-specs spec fails because oslosphinx is looking for an actual blueprint | 01:57 |
| lifeless | but there's no one project to bind this to | 01:57 |
| lifeless | what should I do? | 01:57 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove kazoo hack/fix for issue no longer needed https://review.openstack.org/182416 | 02:01 |
| *** stevemar has quit IRC | 02:07 | |
| *** stevemar has joined #openstack-oslo | 02:08 | |
| openstackgerrit | Joshua Harlow proposed openstack/automaton: Add and use a callback name fetching utility function https://review.openstack.org/196495 | 02:14 |
| openstackgerrit | Joshua Harlow proposed openstack/futurist: Move the periodic '_get_callback_name' to '_utils' https://review.openstack.org/196496 | 02:18 |
| *** stevemar has quit IRC | 02:30 | |
| *** stevemar has joined #openstack-oslo | 02:31 | |
| openstackgerrit | Merged openstack/taskflow: Use the `excutils.raise_with_cause` after doing our type check https://review.openstack.org/192448 | 02:54 |
| openstackgerrit | Merged openstack/taskflow: Add indestructible 99 bottles of beer example https://review.openstack.org/189526 | 02:55 |
| *** sputnik13 has joined #openstack-oslo | 02:55 | |
| openstackgerrit | Merged openstack/taskflow: Remove usage of deprecated 'task_notifier' property in build_car example https://review.openstack.org/191179 | 02:56 |
| openstackgerrit | Merged openstack/taskflow: Perform a few optimizations to decrease persistence interactions https://review.openstack.org/190833 | 02:56 |
| openstackgerrit | Merged openstack/taskflow: Remove reference to 'requirements-pyN.txt' files https://review.openstack.org/193816 | 02:57 |
| openstackgerrit | Merged openstack/taskflow: Add history.rst that uses generated 'ChangeLog' file https://review.openstack.org/194854 | 02:57 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/taskflow: Updated from global requirements https://review.openstack.org/194836 | 03:11 |
| *** achanda has joined #openstack-oslo | 03:11 | |
| *** tobe has joined #openstack-oslo | 03:12 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 03:15 | |
| *** achanda has quit IRC | 03:18 | |
| *** sdake has joined #openstack-oslo | 03:32 | |
| *** vilobhmm has quit IRC | 03:34 | |
| *** sdake has quit IRC | 03:36 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 03:38 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 03:39 | |
| *** sdake has joined #openstack-oslo | 03:39 | |
| openstackgerrit | Joshua Harlow proposed openstack/futurist: Ensure we check callback '_is_periodic' on add https://review.openstack.org/196457 | 03:45 |
| openstackgerrit | Joshua Harlow proposed openstack/futurist: Ensure we check callback '_is_periodic' on add https://review.openstack.org/196457 | 03:47 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 03:49 | |
| *** tobe has quit IRC | 03:55 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Just make the compiler object at __init__ time https://review.openstack.org/196525 | 03:55 |
| *** tobe has joined #openstack-oslo | 03:56 | |
| *** tobe has quit IRC | 03:56 | |
| *** rushiagr_away is now known as rushiagr | 03:57 | |
| *** sdake_ has joined #openstack-oslo | 03:58 | |
| *** tobe has joined #openstack-oslo | 03:59 | |
| *** sdake has quit IRC | 04:02 | |
| *** rushiagr is now known as rushiagr_away | 04:03 | |
| *** stevemar has quit IRC | 04:03 | |
| *** stevemar has joined #openstack-oslo | 04:04 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Replace clear zookeeper python with clear zookeeper bash https://review.openstack.org/196528 | 04:10 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Replace clear zookeeper python with clear zookeeper bash https://review.openstack.org/196528 | 04:11 |
| *** tobe has quit IRC | 04:13 | |
| *** browne has joined #openstack-oslo | 04:22 | |
| *** kzaitsev_mb has joined #openstack-oslo | 04:29 | |
| openstackgerrit | Merged openstack/taskflow: Add docstrings on runtime objects methods and link to them in docs https://review.openstack.org/194451 | 04:39 |
| openstackgerrit | Merged openstack/taskflow: Add docstrings on runtime objects methods and link to them in docs https://review.openstack.org/194451 | 04:39 |
| *** kzaitsev_mb has quit IRC | 04:53 | |
| *** kzaitsev_mb has joined #openstack-oslo | 04:57 | |
| *** manishg has quit IRC | 05:01 | |
| *** manishg has joined #openstack-oslo | 05:05 | |
| *** kzaitsev_mb has quit IRC | 05:27 | |
| *** kzaitsev_mb has joined #openstack-oslo | 05:27 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/taskflow: Updated from global requirements https://review.openstack.org/194836 | 05:27 |
| *** manishg has quit IRC | 05:39 | |
| *** manishg has joined #openstack-oslo | 05:42 | |
| *** manishg has quit IRC | 05:50 | |
| *** ihrachyshka has joined #openstack-oslo | 05:52 | |
| *** tobe has joined #openstack-oslo | 05:56 | |
| *** tobe has quit IRC | 05:58 | |
| *** tobe_ has joined #openstack-oslo | 05:58 | |
| *** nkrinner has joined #openstack-oslo | 06:00 | |
| *** stevemar has quit IRC | 06:16 | |
| *** stevemar has joined #openstack-oslo | 06:16 | |
| *** kzaitsev_mb has quit IRC | 06:23 | |
| *** stevemar has quit IRC | 06:30 | |
| openstackgerrit | Merged openstack/oslo.cache: Add tests for _memcache_pool https://review.openstack.org/196468 | 06:35 |
| *** browne has quit IRC | 06:43 | |
| *** arnaud____ has joined #openstack-oslo | 06:43 | |
| *** exploreshaifali has joined #openstack-oslo | 07:08 | |
| *** amotoki has joined #openstack-oslo | 07:17 | |
| *** stevemar has joined #openstack-oslo | 07:30 | |
| *** stevemar has quit IRC | 07:33 | |
| *** haypo has joined #openstack-oslo | 07:40 | |
| *** cdent has joined #openstack-oslo | 07:41 | |
| *** arnaud____ has quit IRC | 07:57 | |
| *** yassine has joined #openstack-oslo | 08:32 | |
| *** kbyrne has quit IRC | 08:47 | |
| *** dguitarbite has joined #openstack-oslo | 08:53 | |
| *** kbyrne has joined #openstack-oslo | 08:53 | |
| *** ndipanov has joined #openstack-oslo | 08:54 | |
| *** jaosorior has joined #openstack-oslo | 09:08 | |
| *** eezhova has quit IRC | 09:08 | |
| *** fnordahl has quit IRC | 09:15 | |
| *** fnordahl has joined #openstack-oslo | 09:17 | |
| openstackgerrit | Ilya Shakhat proposed openstack/oslo.service: Allow LoopingCall to continue on exception in callee https://review.openstack.org/193605 | 09:19 |
| *** stevemar has joined #openstack-oslo | 09:20 | |
| *** stevemar has quit IRC | 09:22 | |
| *** eezhova has joined #openstack-oslo | 09:48 | |
| *** openstackgerrit has quit IRC | 09:53 | |
| *** openstackgerrit has joined #openstack-oslo | 09:53 | |
| *** sdake_ is now known as sdake | 10:01 | |
| *** uschreiber_ has joined #openstack-oslo | 10:03 | |
| *** uschreiber_ has quit IRC | 10:05 | |
| *** yamahata has quit IRC | 10:16 | |
| *** pblaho has joined #openstack-oslo | 10:25 | |
| *** pblaho has quit IRC | 10:25 | |
| *** shardy_ has joined #openstack-oslo | 10:25 | |
| *** pblaho has joined #openstack-oslo | 10:25 | |
| *** shardy has quit IRC | 10:27 | |
| *** shardy_ has quit IRC | 10:31 | |
| *** shardy has joined #openstack-oslo | 10:31 | |
| *** dims has joined #openstack-oslo | 10:37 | |
| *** exploreshaifali has quit IRC | 10:37 | |
| *** subscope has joined #openstack-oslo | 10:42 | |
| *** subscope has quit IRC | 10:52 | |
| *** pblaho has quit IRC | 10:52 | |
| *** pblaho has joined #openstack-oslo | 10:54 | |
| dims | good <time_of_day/> | 10:56 |
| *** hogepodge has quit IRC | 10:58 | |
| dims | sileht: jd__: flaper87: found at least 4 of our projects had missing requirements using pip-missing-reqs - so i added tox entry for all projects - https://review.openstack.org/#/q/status:open+topic:pip-missing-reqs,n,z - please take a look when you get a chance | 10:58 |
| *** hogepodge has joined #openstack-oslo | 11:00 | |
| *** shardy_ has joined #openstack-oslo | 11:18 | |
| *** shardy has quit IRC | 11:19 | |
| *** shardy_ has quit IRC | 11:24 | |
| *** shardy has joined #openstack-oslo | 11:25 | |
| *** sdake has quit IRC | 11:43 | |
| *** tobe_ has quit IRC | 11:49 | |
| *** hogepodge has quit IRC | 11:56 | |
| *** ihrachyshka has quit IRC | 12:01 | |
| *** hogepodge has joined #openstack-oslo | 12:02 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.cache: Remove unnecessary file https://review.openstack.org/196636 | 12:05 |
| *** kgiusti has joined #openstack-oslo | 12:14 | |
| *** bknudson has quit IRC | 12:16 | |
| *** bknudson has joined #openstack-oslo | 12:36 | |
| *** ozamiatin has joined #openstack-oslo | 12:38 | |
| *** mtreinish has quit IRC | 12:40 | |
| *** mtreinish has joined #openstack-oslo | 12:40 | |
| *** shardy has quit IRC | 12:46 | |
| *** shardy has joined #openstack-oslo | 12:46 | |
| *** exploreshaifali has joined #openstack-oslo | 12:52 | |
| *** stevemar has joined #openstack-oslo | 12:57 | |
| *** hogepodge has quit IRC | 13:00 | |
| *** stevemar has quit IRC | 13:00 | |
| *** hogepodge has joined #openstack-oslo | 13:02 | |
| *** jlvillal has quit IRC | 13:08 | |
| *** hogepodge has quit IRC | 13:11 | |
| *** hogepodge has joined #openstack-oslo | 13:12 | |
| *** gordc_ is now known as gordc | 13:14 | |
| dims | folks, releases for this week - http://paste.openstack.org/show/324570/ - feedback welcome and appreciated! | 13:16 |
| *** jlvillal has joined #openstack-oslo | 13:19 | |
| *** ozamiatin has quit IRC | 13:20 | |
| *** ihrachyshka has joined #openstack-oslo | 13:24 | |
| *** mriedem has joined #openstack-oslo | 13:30 | |
| *** zz_jgrimm is now known as jgrimm | 13:33 | |
| *** prad has joined #openstack-oslo | 13:38 | |
| *** hogepodge has quit IRC | 13:39 | |
| *** hogepodge has joined #openstack-oslo | 13:41 | |
| *** prad has quit IRC | 13:43 | |
| *** mtanino has joined #openstack-oslo | 13:43 | |
| openstackgerrit | Merged openstack/oslo.policy: Add tox target to find missing requirements https://review.openstack.org/195842 | 13:44 |
| *** jecarey has joined #openstack-oslo | 13:52 | |
| *** prad has joined #openstack-oslo | 13:55 | |
| *** stpierre has joined #openstack-oslo | 13:57 | |
| *** exploreshaifali has quit IRC | 13:57 | |
| *** superdan is now known as dansmith | 13:57 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:58 | |
| *** boris-42 has joined #openstack-oslo | 13:59 | |
| *** amotoki has quit IRC | 13:59 | |
| *** subscope has joined #openstack-oslo | 13:59 | |
| *** subscope has quit IRC | 14:04 | |
| *** harlowja_at_home has joined #openstack-oslo | 14:11 | |
| *** rjaiswal has joined #openstack-oslo | 14:12 | |
| openstackgerrit | Brant Knudson proposed openstack/oslo.cache: Cleanup exceptions https://review.openstack.org/196478 | 14:12 |
| dhellmann | lifeless: I would go ahead and create a blueprint in oslo (we use oslo-incubator for things that aren't related to a specific library) | 14:17 |
| *** jecarey has quit IRC | 14:18 | |
| *** stevemar has joined #openstack-oslo | 14:19 | |
| *** dims has quit IRC | 14:21 | |
| *** subscope has joined #openstack-oslo | 14:24 | |
| *** dims has joined #openstack-oslo | 14:24 | |
| *** yamahata has joined #openstack-oslo | 14:25 | |
| haypo | dims: "Fix sqlalchemy.ModelBase.__contains__() behaviour" of oslo.db will break nova | 14:26 |
| haypo | dims: see https://review.openstack.org/#/c/195472/ | 14:26 |
| haypo | dims: well, it only breaks nova if oslo.db is upgraded in nova without running tests :) | 14:26 |
| dims | haypo: ran the nova tests using master of all oslo projects in (https://review.openstack.org/#/c/186418/ and https://review.openstack.org/#/c/186413/) seems to work fine | 14:27 |
| haypo | dims: > "tox -e py27" *FAILS* on nova.tests.unit.db.test_db_api.InstanceExtraTestCase.test_instance_extra_get_with_columns < | 14:28 |
| haypo | dims: hum, strange that you didn't get this failure | 14:28 |
| haypo | 2015-06-29 11:39:26.478 | {5} nova.tests.unit.db.test_db_api.InstanceExtraTestCase.test_instance_extra_get_with_columns [0.065141s] ... ok | 14:29 |
| haypo | i checked gate-nova-python27 of https://review.openstack.org/#/c/186413/ | 14:30 |
| dims | haypo: see https://review.openstack.org/#/c/186413/, i don't see any failures in gate-nova-python27 | 14:30 |
| dims | right | 14:30 |
| haypo | dims: http://logs.openstack.org/13/186413/8/check/gate-nova-python27/04e7efb/console.html says oslo.db==1.12.0, not something like "-e git+https://..." | 14:31 |
| haypo | dims: it looks like something installed oslo.db 1.12.0 instead of the git version | 14:31 |
| dims | weird | 14:32 |
| dims | looking | 14:32 |
| haypo | dims: well, https://review.openstack.org/#/c/195191/ skips the failing test to unblock the transition | 14:32 |
| haypo | dims: my plan is to skip the test in nova, upgrade oslo.db, and then fix the nova test | 14:32 |
| *** kzaitsev_mb has joined #openstack-oslo | 14:33 | |
| haypo | dims: as explained in https://review.openstack.org/#/c/195472/ | 14:33 |
| *** dguitarbite has quit IRC | 14:37 | |
| *** sdake has joined #openstack-oslo | 14:37 | |
| *** sdake_ has joined #openstack-oslo | 14:40 | |
| *** sdake has quit IRC | 14:43 | |
| *** ihrachyshka has quit IRC | 14:47 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo.service: Track created thread and disallow more than one start being active https://review.openstack.org/195358 | 14:48 |
| *** timsim has left #openstack-oslo | 14:49 | |
| *** shardy_ has joined #openstack-oslo | 14:51 | |
| *** shardy has quit IRC | 14:51 | |
| harlowja_at_home | dims, lifeless if u get sometime https://review.openstack.org/#/c/193354/ would be good to get in (to avoid further chaos later) | 14:52 |
| harlowja_at_home | should be good to go now ^ | 14:52 |
| dims | haypo: looks like sputnik13 +2 | 14:53 |
| dims | 'ed it once before | 14:53 |
| dims | and lifeless' comments are addressed | 14:54 |
| dims | so fast tracking it | 14:54 |
| harlowja_at_home | thx | 14:54 |
| haypo | dims: sorry i lost the context, on which patch? | 14:54 |
| * harlowja_at_home thinks haypo == harlowja :-P | 14:54 | |
| dims | haypo: sorry :) | 14:55 |
| haypo | harlowja_at_home: hello myself, how do i do? | 14:55 |
| harlowja_at_home | haypo, good good, u are doing wonderful | 14:55 |
| haypo | lol | 14:55 |
| harlowja_at_home | this is your ego speaking | 14:55 |
| harlowja_at_home | u need to take a vacation or something | 14:55 |
| harlowja_at_home | lol | 14:55 |
| harlowja_at_home | *this is your inner voice speaking* | 14:56 |
| * harlowja_at_home must keep it PG13, lol | 14:56 | |
| haypo | dims: is it possible to generate a list of newly deprecated functions when you build the long list of releases? | 14:58 |
| haypo | dims: same question for backward incompatible changes like my oslo.db change | 14:58 |
| *** jecarey has joined #openstack-oslo | 14:58 | |
| stevemar | dims or dhellmann is there a way to run oslo-config-generator in debug mode? i'm expecting certain oslo.cache options to appear, but they're not showing up | 14:59 |
| *** shardy_ has quit IRC | 15:00 | |
| dims | stevemar: none of them are appearing or just some? | 15:00 |
| stevemar | dims: none | 15:00 |
| dims | stevemar: looking | 15:00 |
| stevemar | dims, i am using this keystone patch: https://review.openstack.org/#/c/195873/ and the latest oslo.cache code | 15:01 |
| *** nkrinner has quit IRC | 15:02 | |
| stevemar | fwiw, the code to add the options should be here, line 314ish https://review.openstack.org/#/c/195873/11/keystone/common/config.py | 15:02 |
| *** ihrachyshka has joined #openstack-oslo | 15:03 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.cache: Expose list_opts entry points for oslo-config-generator https://review.openstack.org/196698 | 15:03 |
| *** shardy has joined #openstack-oslo | 15:04 | |
| dims | stevemar: grab that change ^^ | 15:04 |
| dims | and give me a minute to look at your review | 15:04 |
| *** kzaitsev_mb has quit IRC | 15:05 | |
| dims | stevemar: you have the right setting here https://review.openstack.org/#/c/195873/11/config-generator/keystone.conf,cm - but i had missed exposing the list_opts | 15:05 |
| dims | so you should be able to run oslo-config-generator with my change | 15:05 |
| dims | and see the options, please try and let me know | 15:05 |
| *** ozamiatin has joined #openstack-oslo | 15:06 | |
| *** ozamiatin has quit IRC | 15:06 | |
| *** sputnik13 has quit IRC | 15:07 | |
| *** zzzeek has joined #openstack-oslo | 15:07 | |
| stevemar | dims: \o/ | 15:09 |
| *** sputnik13 has joined #openstack-oslo | 15:10 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.cache: handle utf8 encoding properly https://review.openstack.org/196477 | 15:12 |
| stevemar | dims and dhellmann ^^ that and the expose list opt should be the last bits for oslo.cache | 15:13 |
| *** sputnik13 has quit IRC | 15:13 | |
| bknudson | oslo.cache needs to not use a global CONF | 15:15 |
| bknudson | and it needs docs | 15:15 |
| bknudson | and it needs exceptions that aren't insane | 15:15 |
| dims | stevemar: as keystone core, i've grandfathered you to oslo-cache-core, so please update your vote | 15:15 |
| *** ozamiatin has joined #openstack-oslo | 15:16 | |
| bknudson | and we need to make sure that there aren't symbols that are public that should not be private | 15:16 |
| dims | bknudson: want to track these using bugs? | 15:16 |
| bknudson | public that should be private | 15:16 |
| bknudson | sure, I didn't know if bugs were being used | 15:16 |
| dims | bknudson: yep, we have the launchpad created and ready | 15:16 |
| dims | bknudson: blueprints too | 15:16 |
| stevemar | dims: <3 | 15:18 |
| dhellmann | stevemar: left a comment on https://review.openstack.org/#/c/196477/4 that's a bit farther reaching than your patch /cc dims | 15:18 |
| stevemar | dhellmann: so that was an artifact of https://review.openstack.org/#/c/195873/ | 15:19 |
| dims | dhellmann: y, this one if i remember the method itself is called from within dogpile and not by the end user, so futher muddies the waters | 15:20 |
| stevemar | dhellmann: dims we have some tests in keystone (https://github.com/openstack/keystone/blob/master/keystone/tests/unit/backend/role/test_ldap.py) that have utf8 encoded values | 15:21 |
| dhellmann | dims: so that function is invoked by dogpile somehow? | 15:22 |
| stevemar | sorry, they values are utf8, and if we call the dogpile key mangler without encoding them, it blows up | 15:23 |
| stevemar | you can check out the failed tests in that patch | 15:23 |
| *** e0ne has joined #openstack-oslo | 15:23 | |
| stevemar | we've managed to get dstanek curious ... | 15:24 |
| dhellmann | stevemar: it sounds like this is a protection, but I'm not sure it's python3-compatible. I get an AttributeError if I try to call encode() on a byte string | 15:24 |
| dhellmann | if dogpile always wants a byte string and we want to help users of oslo.cache/dogpile to ensure that works then I'm OK with that. The function could use a docstring indicating that's how it's meant to be used | 15:25 |
| dstanek | stevemar: only because i saw your most recent patch in my work stream and saw the error | 15:25 |
| *** e0ne is now known as e0ne_ | 15:25 | |
| *** e0ne_ is now known as e0ne | 15:25 | |
| stevemar | dhellmann: ohh... | 15:26 |
| stevemar | yeah, its totally meant to be protection | 15:26 |
| *** david-ly_ is now known as david-lyle | 15:27 | |
| dhellmann | stevemar: yeah, my fault for not understanding more about what the lib is doing | 15:27 |
| stevemar | dhellmann: it's all good. but your point about a basestring is valid | 15:28 |
| stevemar | err bytestring | 15:28 |
| dhellmann | stevemar: I think all you need to do is add AttributeError to the exceptions ignored | 15:28 |
| stevemar | dhellmann: cool cool | 15:29 |
| openstackgerrit | Merged openstack/oslo.cache: Expose list_opts entry points for oslo-config-generator https://review.openstack.org/196698 | 15:30 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.cache: handle utf8 encoding properly https://review.openstack.org/196477 | 15:30 |
| *** arnaud____ has joined #openstack-oslo | 15:31 | |
| stevemar | dims: dhellmann ^^ i think that should get us a 0.1.2 or 0.2.0 release, and a happy keystone build | 15:31 |
| dhellmann | stevemar: are there already tests for the cases in https://review.openstack.org/#/c/196477/ ? | 15:32 |
| * stevemar is obsessed with getting a non -1 jenkins build on his keystone patch | 15:32 | |
| dhellmann | stevemar: I think dims is planning oslo releases for later today | 15:32 |
| *** cdent has quit IRC | 15:32 | |
| *** amrith is now known as _amrith_ | 15:35 | |
| stevemar | dhellmann: i could make some small unit tests that call sha_mangle_key | 15:37 |
| *** yassine has quit IRC | 15:37 | |
| *** achanda has joined #openstack-oslo | 15:37 | |
| *** yassine has joined #openstack-oslo | 15:37 | |
| *** haypo has quit IRC | 15:41 | |
| openstackgerrit | Merged openstack/taskflow: Remove 2.6 classifier + 2.6 compatibility code https://review.openstack.org/193354 | 15:41 |
| *** harlowja_still_a has joined #openstack-oslo | 15:42 | |
| *** harlowja_at_home has quit IRC | 15:46 | |
| dhellmann | stevemar: yeah, tests would be good | 15:46 |
| dhellmann | stevemar: I'm especially interested in making sure that works as expected on python 2 and 3 | 15:46 |
| *** pblaho has quit IRC | 15:46 | |
| *** e0ne has quit IRC | 15:46 | |
| *** e0ne has joined #openstack-oslo | 15:48 | |
| *** pblaho has joined #openstack-oslo | 15:48 | |
| *** haypo has joined #openstack-oslo | 15:50 | |
| *** browne has joined #openstack-oslo | 15:51 | |
| *** e0ne is now known as e0ne_ | 15:53 | |
| dims | dhellmann: stevemar: ++ on the tests | 15:53 |
| *** e0ne_ is now known as e0ne | 15:55 | |
| dims | 3 more minutes to oslo meeting | 15:57 |
| harlowja_still_a | oh man, can't wait | 15:58 |
| harlowja_still_a | :-P | 15:58 |
| harlowja_still_a | oh man oh man, ha | 15:58 |
| *** rpodolyaka1 has joined #openstack-oslo | 16:11 | |
| *** haypo has quit IRC | 16:13 | |
| *** arnaud____ has quit IRC | 16:19 | |
| *** beekneemech has joined #openstack-oslo | 16:21 | |
| *** bnemec has quit IRC | 16:23 | |
| *** sputnik13 has joined #openstack-oslo | 16:30 | |
| *** yamahata has quit IRC | 16:32 | |
| *** ashleighfarnham has joined #openstack-oslo | 16:33 | |
| krotscheck | gordc: I've had a patch responding to your comments up on https://review.openstack.org/#/c/191238/ since tuesday, do you have time to look at it today? | 16:35 |
| krotscheck | gordc: Similar with https://review.openstack.org/#/c/194268/ , responded to your comment. | 16:38 |
| krotscheck | gordc: Note that if I don't have any repsonse by tomorrow (1 week), I'm going to assume that you're ok with the change and ask dims and dhellmann to weigh in. | 16:38 |
| rpodolyaka1 | dims: sorry, on a holiday today. regarding oslo.db 2.0.0, I saw haypo already did a patch to nova, which fixes 1 unit test | 16:40 |
| dims | rpodolyaka1: ack. no worries | 16:40 |
| dims | rpodolyaka1: have a good rest of the week off :) | 16:40 |
| rpodolyaka1 | dims: heh, thanks :) | 16:40 |
| rpodolyaka1 | dims: if we held cutting of the release till tomorrow, I'd kindly ask viktors to run tests for all projects | 16:41 |
| dims | rpodolyaka1: i am running a devstack change, if that goes through then will cut a release | 16:42 |
| dims | otherwise will wait for viktors | 16:42 |
| rpodolyaka1 | dims: ah, ok. thanks a lot! | 16:42 |
| *** jgrimm has quit IRC | 16:43 | |
| *** harlowja_still_a has quit IRC | 16:47 | |
| *** zz_jgrimm has joined #openstack-oslo | 16:49 | |
| dhellmann | ihrachyshka: what's the plan for that context change we were talking about in the meeting? | 16:50 |
| *** manishg has joined #openstack-oslo | 16:50 | |
| ihrachyshka | dhellmann, I would abandon the oslo.context change, and kill string rewrite from devstack; that said, people can be uneasy loosing their names from devstack logs. So I guess with this in mind, we may actually need to go forward introducing a config option to enable names, as you said. | 16:52 |
| ihrachyshka | I'll update the patches some time next week (this week I'm off for a code sprint) | 16:53 |
| * dims steps out for a bit | 16:53 | |
| dhellmann | ihrachyshka: ok. There are 2 ways to do that. devstack can change the log format option that exists now to replace the user_identity value with the names in whatever format it wants, or we can make oslo.log have some new options for "parts" of the format, and then devstack can set only the one it wants to set | 16:53 |
| dhellmann | ihrachyshka: the first is faster, but the latter might be a nice thing for deployers | 16:54 |
| ihrachyshka | dhellmann, the first one is what we already have, though we do it for specific projects only now (neutron, nova) | 16:55 |
| dhellmann | ihrachyshka: right | 16:55 |
| ihrachyshka | dhellmann, I want to get rid of that rewrite, so option 2 | 16:55 |
| dhellmann | ihrachyshka: option 2 still requires devstack to do something, though | 16:55 |
| dhellmann | it still has to change the new option, since the default format will match what we emit now | 16:55 |
| ihrachyshka | since that rewrite caused some problems before (though I need to admit that the patch series caused me even more) | 16:55 |
| ihrachyshka | dhellmann, yeah, but something will be specific, not 'rewrite whatever oslo.log should have provided to us' | 16:56 |
| dhellmann | ok | 16:56 |
| dhellmann | the trick will be to figure out how to make the options backwards-compatible in oslo.log | 16:57 |
| dhellmann | I suppose we could get the dictionary of values from the context, then replace user_identity with a new string based on the format option | 16:57 |
| ihrachyshka | dhellmann, well, it refers, abstractly, to user_identity, and oslo.context is the one that constructs it. | 16:57 |
| dhellmann | yes, but I think in retrospect that was a mistake | 16:58 |
| ihrachyshka | remember, user_identity is not a real value from contex | 16:58 |
| *** ozamiatin has quit IRC | 16:58 | |
| dhellmann | context should tell log what the identity values are, and log should do the formatting | 16:58 |
| dhellmann | right | 16:58 |
| ativelkov | dansmith: hi, are you around? | 16:59 |
| *** e0ne has quit IRC | 16:59 | |
| dansmith | ativelkov: am now | 17:02 |
| dhellmann | ihrachyshka: https://etherpad.openstack.org/p/logging-flexibility | 17:02 |
| ativelkov | dansmith: wanted to sync-up with you on field constrains/validation in versioned_objects. I've made an initial commit: https://review.openstack.org/#/c/196041/ | 17:03 |
| dansmith | ativelkov: ah, yeah I took a partial look through it last week, but the spec deadline was taking most of my time | 17:03 |
| ativelkov | dansmith: I see. Well, there is no rush here, I just wanted to check if the chosen approach looks good to you in general | 17:05 |
| *** mriedem has quit IRC | 17:05 | |
| dhellmann | ihrachyshka: ok, I think that captures all of my current ideas on this, what do you think? | 17:05 |
| dhellmann | ihrachyshka: if I write this up as a spec, shall I include you on the list of implementers? | 17:09 |
| dansmith | ativelkov: I'll try to get to it today | 17:09 |
| dansmith | ativelkov: thanks for doing it | 17:09 |
| ihrachyshka | dhellmann, ack ,seems reasonable | 17:10 |
| ihrachyshka | dhellmann, yes, sure | 17:10 |
| dhellmann | ihrachyshka: ok, I'll write this up today or tomorrow | 17:10 |
| ihrachyshka | dhellmann, need to go, sorry. add me to reviewers if you do. thanks a lot. | 17:11 |
| * dhellmann heads to lunch | 17:11 | |
| * ihrachyshka heads to dinner | 17:11 | |
| dhellmann | ihrachyshka: thanks for working through the design with me | 17:11 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 17:15 | |
| *** ihrachyshka has quit IRC | 17:16 | |
| *** sdake has joined #openstack-oslo | 17:16 | |
| *** exploreshaifali has joined #openstack-oslo | 17:16 | |
| *** achanda has quit IRC | 17:17 | |
| *** sdake_ has quit IRC | 17:20 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.cache: handle utf8 encoding properly https://review.openstack.org/196477 | 17:22 |
| stevemar | dims: dhellmann sorry for the hold up ^ | 17:22 |
| *** hogepodge has quit IRC | 17:26 | |
| *** hogepodge has joined #openstack-oslo | 17:27 | |
| *** browne has quit IRC | 17:28 | |
| *** dontalton has joined #openstack-oslo | 17:32 | |
| *** yamahata has joined #openstack-oslo | 17:33 | |
| dhellmann | stevemar: one comment inline | 17:34 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-specs: Add user-identity-format-flexibility for oslo.log https://review.openstack.org/196752 | 17:34 |
| stevemar | dhellmann: oh we don't have those in the keystone tests like taht | 17:34 |
| dhellmann | stevemar: I'm not sure what you get in that case. possibly a bytestring? | 17:35 |
| dhellmann | stevemar: better to be explicit | 17:36 |
| dhellmann | dims: https://review.openstack.org/196752 is the result of the discussion in today's meeting with ihrachyshka | 17:36 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.cache: handle utf8 encoding properly https://review.openstack.org/196477 | 17:37 |
| stevemar | dhellmann: tested everything out, it still works so i'm happy | 17:37 |
| stevemar | i think you're right | 17:37 |
| *** yassine has quit IRC | 17:37 | |
| * dims gets back | 17:37 | |
| stevemar | w/o u'' infront it'll be a bytestring | 17:37 |
| dhellmann | stevemar: are there any strings that can't be encoded to utf-8? I don't think so, but that's the other failure mode | 17:38 |
| * dhellmann thinks we have a function in oslo.utils for this | 17:38 | |
| stevemar | hehe | 17:39 |
| dhellmann | oslo_utils.encodeutils.safe_encode, but that looks like overkill for this | 17:39 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/oslo-specs: policy: Dynamic Policies Overlay https://review.openstack.org/196753 | 17:40 |
| dhellmann | stevemar: how about set errors='xmlcharrefreplace' just to be safe? | 17:40 |
| *** samueldmq has joined #openstack-oslo | 17:41 | |
| stevemar | dhellmann: okie dokie | 17:42 |
| dims | dhellmann: stevemar: starr'ed both reviews, getting into the release mode | 17:42 |
| *** ViswaV_ has quit IRC | 17:42 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.cache: handle utf8 encoding properly https://review.openstack.org/196477 | 17:43 |
| stevemar | dhellmann: donezo | 17:43 |
| *** ViswaV has joined #openstack-oslo | 17:43 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/oslo-specs: policy: Dynamic Policies Overlay https://review.openstack.org/196753 | 17:43 |
| dhellmann | stevemar: +2 | 17:43 |
| stevemar | dhellmann: \o/ | 17:44 |
| *** exploreshaifali has quit IRC | 17:45 | |
| *** jaosorior has quit IRC | 17:46 | |
| *** achanda has joined #openstack-oslo | 17:46 | |
| *** jaosorior has joined #openstack-oslo | 17:47 | |
| *** mriedem has joined #openstack-oslo | 17:52 | |
| *** abitha has joined #openstack-oslo | 18:00 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 18:03 | |
| openstackgerrit | Merged openstack/oslo.cache: handle utf8 encoding properly https://review.openstack.org/196477 | 18:07 |
| *** exploreshaifali has joined #openstack-oslo | 18:08 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use `encodeutils.exception_to_unicode` for exception -> string function https://review.openstack.org/192458 | 18:09 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow regeneration of built-in matched python exceptions https://review.openstack.org/195817 | 18:10 |
| openstackgerrit | Brant Knudson proposed openstack/oslo.cache: Docs https://review.openstack.org/196464 | 18:12 |
| openstackgerrit | Brant Knudson proposed openstack/oslo.cache: Cleanup exceptions https://review.openstack.org/196478 | 18:13 |
| openstackgerrit | Brant Knudson proposed openstack/oslo.cache: Make symbols private https://review.openstack.org/196463 | 18:15 |
| *** crc32 has joined #openstack-oslo | 18:15 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Rename logbook module -> models module https://review.openstack.org/189995 | 18:19 |
| openstackgerrit | Brant Knudson proposed openstack/oslo.cache: Make symbols private https://review.openstack.org/196463 | 18:22 |
| openstackgerrit | Brant Knudson proposed openstack/oslo.cache: Docs https://review.openstack.org/196464 | 18:24 |
| ativelkov | dansmith: I found that field gets into _changed_fields set even if is assigned to the same value that it contained before. But if it is read_only the exception is risen only if the values differ. This seems inconsistent. Is it a bug or an intentional behavior? | 18:25 |
| *** browne has joined #openstack-oslo | 18:26 | |
| openstackgerrit | Brant Knudson proposed openstack/oslo.cache: Module docs https://review.openstack.org/196464 | 18:28 |
| *** openstackgerrit has quit IRC | 18:30 | |
| *** openstackgerrit has joined #openstack-oslo | 18:30 | |
| *** ozamiatin has joined #openstack-oslo | 18:33 | |
| *** achanda has quit IRC | 18:35 | |
| *** achanda has joined #openstack-oslo | 18:36 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/oslo-specs: policy: Dynamic Policies Overlay https://review.openstack.org/196753 | 18:36 |
| *** achanda has quit IRC | 18:41 | |
| *** stevemar has quit IRC | 18:43 | |
| *** rpodolyaka1 has quit IRC | 18:44 | |
| *** stevemar has joined #openstack-oslo | 18:44 | |
| dansmith | ativelkov: IIRC, we intentionally made the read-only field ignore identical values, I think because we were doing some obligatory behavior in our API that we would have had to change | 18:54 |
| dansmith | ativelkov: I think the read-only case is fine, but agree that we shouldn't mark the thing as dirty unless we actually change the value | 18:54 |
| *** Rockyg has joined #openstack-oslo | 18:55 | |
| ativelkov | dansmith: so, is it ok if I change it so non-readonly fields will not be marked as changed unless the values differ? | 18:55 |
| dansmith | ativelkov: yeah, I think that's probably a good idea | 18:56 |
| ativelkov | dansmith: I am going to touch it anyway, as I've found that compound fields (lists, sets, dicts) are not marked as changed if they are modified by append/insert/update etc - so I am going to change it as part of my next commit :) | 18:57 |
| dansmith | ah, okay | 18:57 |
| *** _amrith_ is now known as amrith | 19:00 | |
| *** manishg has quit IRC | 19:01 | |
| *** hogepodge has quit IRC | 19:02 | |
| *** manishg has joined #openstack-oslo | 19:02 | |
| *** manishg has quit IRC | 19:02 | |
| *** hogepodge has joined #openstack-oslo | 19:03 | |
| *** manishg_ has joined #openstack-oslo | 19:04 | |
| *** manishg_ has quit IRC | 19:04 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Retain atom `revert` result (or failure) https://review.openstack.org/192942 | 19:05 |
| *** manishg_ has joined #openstack-oslo | 19:05 | |
| *** boris-42 has quit IRC | 19:12 | |
| *** kzaitsev_mb has joined #openstack-oslo | 19:12 | |
| *** haypo has joined #openstack-oslo | 19:16 | |
| *** haypo has quit IRC | 19:16 | |
| *** haypo has joined #openstack-oslo | 19:16 | |
| openstackgerrit | Roxana Gherle proposed openstack/oslo.config: Add enforce_type option when setting an override https://review.openstack.org/195355 | 19:17 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Build-out + test a redis backed jobboard https://review.openstack.org/176951 | 19:17 |
| *** shardy has quit IRC | 19:22 | |
| *** achanda has joined #openstack-oslo | 19:22 | |
| *** shardy has joined #openstack-oslo | 19:23 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Integrate futurist (and **remove** taskflow originating code) https://review.openstack.org/196275 | 19:23 |
| *** kzaitsev_mb has quit IRC | 19:26 | |
| *** kzaitsev_mb has joined #openstack-oslo | 19:31 | |
| openstackgerrit | Alexander Tivelkov proposed openstack/oslo.versionedobjects: Compound Field validation (WiP) https://review.openstack.org/196819 | 19:32 |
| *** thangp has joined #openstack-oslo | 19:40 | |
| *** achanda has quit IRC | 19:48 | |
| *** manishg_ has quit IRC | 19:54 | |
| *** shardy has quit IRC | 19:55 | |
| *** jaosorior has quit IRC | 19:56 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Replace taskflow.types.timing alias classes with source(s) https://review.openstack.org/196278 | 19:56 |
| *** stevemar has quit IRC | 19:56 | |
| *** stevemar has joined #openstack-oslo | 19:57 | |
| openstackgerrit | Joshua Harlow proposed openstack/automaton: Disallow adding transitions from terminal states https://review.openstack.org/195323 | 19:59 |
| openstackgerrit | Joshua Harlow proposed openstack/automaton: Add `is_actionable_event` checking function https://review.openstack.org/191955 | 19:59 |
| *** achanda has joined #openstack-oslo | 20:00 | |
| *** jaosorior has joined #openstack-oslo | 20:00 | |
| *** shardy has joined #openstack-oslo | 20:01 | |
| *** kzaitsev_mb has quit IRC | 20:02 | |
| *** manishg has joined #openstack-oslo | 20:03 | |
| *** manishg has quit IRC | 20:07 | |
| *** stevemar has quit IRC | 20:08 | |
| *** kzaitsev_mb has joined #openstack-oslo | 20:11 | |
| openstackgerrit | Joshua Harlow proposed openstack/automaton: Add a bigger CD-player state-machine doctest(ed) example https://review.openstack.org/191477 | 20:11 |
| *** ozamiatin has quit IRC | 20:15 | |
| *** stevemar has joined #openstack-oslo | 20:15 | |
| *** JTen has quit IRC | 20:17 | |
| *** JTen has joined #openstack-oslo | 20:19 | |
| *** manishg has joined #openstack-oslo | 20:20 | |
| *** achanda has quit IRC | 20:22 | |
| *** manishg_ has joined #openstack-oslo | 20:24 | |
| *** manishg has quit IRC | 20:24 | |
| *** JTen has quit IRC | 20:26 | |
| *** dontalton has quit IRC | 20:26 | |
| *** ihrachyshka has joined #openstack-oslo | 20:31 | |
| *** manishg_ has quit IRC | 20:31 | |
| *** boris-42 has joined #openstack-oslo | 20:31 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/taskflow: Updated from global requirements https://review.openstack.org/194836 | 20:34 |
| openstackgerrit | Merged openstack/oslo.policy: Add six and oslo.utils to requirements https://review.openstack.org/195846 | 20:36 |
| *** zz_jgrimm has quit IRC | 20:37 | |
| *** browne has quit IRC | 20:41 | |
| *** zz_jgrimm has joined #openstack-oslo | 20:45 | |
| *** zz_jgrimm is now known as jgrimm | 20:45 | |
| *** stevemar has quit IRC | 20:49 | |
| *** stevemar has joined #openstack-oslo | 20:50 | |
| *** exploreshaifali has quit IRC | 20:51 | |
| *** jgrimm has quit IRC | 20:52 | |
| *** jgrimm has joined #openstack-oslo | 20:55 | |
| *** stevemar has quit IRC | 20:55 | |
| *** kgiusti has quit IRC | 21:02 | |
| *** manishg has joined #openstack-oslo | 21:04 | |
| *** JTen has joined #openstack-oslo | 21:05 | |
| mtreinish | dhellmann: you said that have a script to find and fix oslo namespaced imports right? | 21:05 |
| mtreinish | the oslo.db release just broke subunit2sql because we never switched it over | 21:06 |
| *** Rockyg has quit IRC | 21:09 | |
| haypo | mtreinish: you can to replace "oslo." with "oslo_" :-) | 21:09 |
| mtreinish | haypo: yes I realize that :) | 21:10 |
| mtreinish | I was about to push a patch to do that | 21:10 |
| *** jgrimm has quit IRC | 21:13 | |
| *** stpierre has quit IRC | 21:17 | |
| dhellmann | mtreinish: yep, let me get that for you | 21:17 |
| *** gordc is now known as gordc_ | 21:17 | |
| dhellmann | mtreinish: https://review.openstack.org/#/c/195263/ | 21:17 |
| *** gordc_ is now known as gordc_afk | 21:17 | |
| mtreinish | dhellmann: cool thanks | 21:20 |
| mtreinish | fwiw, you probably should respin the tool to add oslo.db now too | 21:20 |
| dhellmann | mtreinish: stand by, I'll have the subunit2sql patch for you in a sec | 21:20 |
| dhellmann | it handles oslo.db, just not as a special case | 21:20 |
| dhellmann | most of those are special case forms that I found based on different use patterns | 21:20 |
| mtreinish | oops, see that now | 21:20 |
| dhellmann | mtreinish: I didn't see subunit2sql because it was under infra, and I didn't scan those :-( | 21:21 |
| mtreinish | dhellmann: yeah I figured that was the case, no worries | 21:21 |
| mtreinish | I think subunit2sql is about the only infra project that uses oslo stuff directly | 21:22 |
| dhellmann | mtreinish: https://review.openstack.org/#/c/196872/ should do it for you | 21:22 |
| mtreinish | dhellmann: cool, thanks | 21:22 |
| *** mriedem is now known as mriedem_away | 21:24 | |
| *** browne has joined #openstack-oslo | 21:25 | |
| mtreinish | dhellmann: when that lands you'll be tied for the #3 contributor (by commit count) to subunit2sql :) | 21:27 |
| *** kevinbenton has quit IRC | 21:31 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Provide a common exception caused by base class https://review.openstack.org/196874 | 21:32 |
| harlowja | ok jd__ i think ^ will let tooz/taskflow share that common stuff (and use it for base exeption classes) | 21:34 |
| harlowja | maybe should be elsewhere, idk | 21:34 |
| openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Provide a common exception caused by base class https://review.openstack.org/196874 | 21:34 |
| harlowja | haypo let me know what u think also, since u might have some better ideas on ^ | 21:40 |
| *** kzaitsev_mb has quit IRC | 21:42 | |
| *** crc32 has quit IRC | 21:42 | |
| *** thangp has quit IRC | 21:43 | |
| *** zz_jgrimm has joined #openstack-oslo | 21:52 | |
| mtreinish | zzzeek: on subunit2sql those lines you added to the alembic env.py a while back are now causing failures on the latest release of oslo.db: http://logs.openstack.org/72/196872/1/check/gate-subunit2sql-python27/187988c/console.html#_2015-06-29_21_33_10_794 | 21:53 |
| mtreinish | zzzeek: tbh I'm not entirely sure I understand what https://review.openstack.org/#/c/147703/ did to fix the issue back then | 21:54 |
| zzzeek | mtreinish: the fix there was so that the env.py shares the same database connectivity as that of the applicaiton as a whole | 21:55 |
| mtreinish | ah, ok that makes sense | 21:56 |
| zzzeek | mtreinish: and it would now be failing because we removed “_session_maker”, which we can put back in, or you can use a new name there if I can go get it for you | 21:56 |
| mtreinish | zzzeek: ok yeah probably switching to the new name makes the most sense. I'll respin dhellmann's patch with that and also require oslo.db 2.0.0 as the min version | 21:56 |
| zzzeek | mtreinish: at the moment it woudl be facade._factory._writer_maker | 21:58 |
| zzzeek | mtreinish: but i htink we should really add a public API to LegacyEngineFacade for this (which is what “facade” is there) | 21:58 |
| mtreinish | zzzeek: ok, sure I'm in favor of doing that. But that'll require a new release for the public api, so in the meantime I guess I'll just use facade._factory._writer_maker and put a comment todo switch to the future public api | 22:00 |
| zzzeek | mtreinish: well see if it works :) | 22:00 |
| *** sdake_ has joined #openstack-oslo | 22:01 | |
| openstackgerrit | Michael Bayer proposed openstack/oslo.db: Add legacy get_sessionmaker() method https://review.openstack.org/196885 | 22:03 |
| zzzeek | mtreinish: ^^^^ | 22:03 |
| *** sdake has quit IRC | 22:04 | |
| mtreinish | zzzeek: awesome thanks | 22:06 |
| *** Rockyg has joined #openstack-oslo | 22:09 | |
| mtreinish | zzzeek: in the meantime I respun https://review.openstack.org/196872 hopefully using _writer_maker will work to unblock things | 22:10 |
| zzzeek | mtreinish: yah hope im not missing anything | 22:10 |
| *** Rockyg has quit IRC | 22:12 | |
| *** manishg has quit IRC | 22:12 | |
| *** Rockyg has joined #openstack-oslo | 22:13 | |
| mtreinish | zzzeek: looks like it worked, I just missed a call: http://logs.openstack.org/72/196872/2/check/gate-subunit2sql-python27/fad1662/console.html#_2015-06-29_22_11_32_915 | 22:14 |
| zzzeek | ok | 22:14 |
| *** ozamiatin has joined #openstack-oslo | 22:15 | |
| *** manishg has joined #openstack-oslo | 22:16 | |
| *** bknudson has quit IRC | 22:20 | |
| *** tsekiyama has joined #openstack-oslo | 22:21 | |
| *** tsbot_ has joined #openstack-oslo | 22:22 | |
| *** exploreshaifali has joined #openstack-oslo | 22:23 | |
| *** ozamiatin has quit IRC | 22:25 | |
| *** zzzeek has quit IRC | 22:26 | |
| *** prad has quit IRC | 22:31 | |
| *** jaosorior has quit IRC | 22:36 | |
| *** yassine has joined #openstack-oslo | 22:38 | |
| openstackgerrit | Joshua Harlow proposed openstack/automaton: Add a bigger CD-player state-machine doctest(ed) example https://review.openstack.org/191477 | 22:43 |
| openstackgerrit | Kevin Benton proposed openstack/oslo.messaging: Verify that version in 'prepare' is a string https://review.openstack.org/193867 | 22:45 |
| *** yassine has quit IRC | 22:47 | |
| *** dims_ has joined #openstack-oslo | 22:55 | |
| *** exploreshaifali has quit IRC | 22:56 | |
| *** ihrachyshka has quit IRC | 22:56 | |
| *** dims has quit IRC | 22:59 | |
| *** dims_ has quit IRC | 23:00 | |
| *** sdake has joined #openstack-oslo | 23:02 | |
| *** jecarey has quit IRC | 23:02 | |
| *** zzzeek has joined #openstack-oslo | 23:03 | |
| *** sdake_ has quit IRC | 23:05 | |
| *** ozamiatin has joined #openstack-oslo | 23:27 | |
| *** boris-42 has quit IRC | 23:32 | |
| *** zzzeek has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!